[exim-dev] [Bug 1630] EXPERIMENTAL_DSN SIGSEGV
https://bugs.exim.org/show_bug.cgi?id=1630 Wolfgang Breyha wbre...@gmx.net changed: What|Removed |Added Attachment #811 is|0 |1 obsolete|| --- Comment #3 from Wolfgang Breyha wbre...@gmx.net --- Created attachment 819 -- https://bugs.exim.org/attachment.cgi?id=819action=edit removed usage of user_message again This is the same patch as before fixing the SEGV, but I removed usage of user_message again since I'm uncertain in which circumstances it is set. At least it has no error code and the caller has to submit one in case 426 is inappropriate (eg. Status: 5.0.0). The event which initially caused the SEGV had no user_message set and I found no other example which does. If the rare situation occurs there is a Remote-MTA field without Diagnostic-Code which is not allowed by RFC 1891. Maybe it's better to set a addr-message in this case instead of user_message fallback. Most likely this happens for deferrals caused by DNS tempfails (eg. DANE lookups). -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1630] EXPERIMENTAL_DSN SIGSEGV
https://bugs.exim.org/show_bug.cgi?id=1630
--- Comment #4 from Git Commit g...@exim.org ---
Git commit:
http://git.exim.org/exim.git/commitdiff/9031f51a298749869af8c082bad850eb103db09a
commit 9031f51a298749869af8c082bad850eb103db09a
Author: Wolfgang Breyha wbre...@gmx.net
AuthorDate: Mon Jun 15 14:52:36 2015 +0100
Commit: Jeremy Harris jgh146...@wizmail.org
CommitDate: Mon Jun 15 16:12:05 2015 +0100
DSN: fix null deref when bounce is due to conn-timeout. Bug 1630
---
src/src/deliver.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/src/deliver.c b/src/src/deliver.c
index 2ee71f5..ec030fe 100644
--- a/src/src/deliver.c
+++ b/src/src/deliver.c
@@ -4876,17 +4876,8 @@ if (s)
s += 2; /* skip : */
fprintf(f, Diagnostic-Code: smtp; );
}
-/* user_message set? use it instead */
-else if ((s = addr-user_message))
- {
- DEBUG(D_deliver)
-debug_printf(DSN Diagnostic-Code: addr-user_message = %s\n, s);
- /* local errors like timeout get 426 */
- fprintf(f, Diagnostic-Code: smtp; 426 );
- }
/* no message available. do nothing */
-else
- return;
+else return;
while (*s)
if (*s == '\\' s[1] == 'n')
--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim
details at http://www.exim.org/ ##
[exim-dev] [Bug 1630] EXPERIMENTAL_DSN SIGSEGV
https://bugs.exim.org/show_bug.cgi?id=1630 Jeremy Harris jgh146...@wizmail.org changed: What|Removed |Added CC||jgh146...@wizmail.org Status|NEW |ASSIGNED Assignee|ni...@exim.org |jgh146...@wizmail.org -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1630] EXPERIMENTAL_DSN SIGSEGV
https://bugs.exim.org/show_bug.cgi?id=1630 Git Commit g...@exim.org changed: What|Removed |Added CC||g...@exim.org --- Comment #2 from Git Commit g...@exim.org --- Git commit: http://git.exim.org/exim.git/commitdiff/ca410e79c6e8e0a7b90796aba361d3caa97329b0 commit ca410e79c6e8e0a7b90796aba361d3caa97329b0 Author: Wolfgang Breyha wbre...@gmx.net AuthorDate: Sat Jun 6 20:07:04 2015 +0100 Commit: Jeremy Harris jgh146...@wizmail.org CommitDate: Sat Jun 6 20:07:04 2015 +0100 dsn: fix null deref when bounce is due to conn-timeout. bug 1630 src/src/deliver.c | 40 ++-- 1 file changed, 26 insertions(+), 14 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 1630] EXPERIMENTAL_DSN SIGSEGV
https://bugs.exim.org/show_bug.cgi?id=1630 Wolfgang Breyha wbre...@gmx.net changed: What|Removed |Added Attachment #810 is|0 |1 obsolete|| --- Comment #1 from Wolfgang Breyha wbre...@gmx.net --- Created attachment 811 -- https://bugs.exim.org/attachment.cgi?id=811action=edit retry using the logic of print_address_error() -- You are receiving this mail because: You are on the CC list for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
