[exim-dev] [Bug 514] log slow DNS queries
https://bugs.exim.org/show_bug.cgi?id=514 Jeremy Harris jgh146...@wizmail.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #13 from Jeremy Harris jgh146...@wizmail.org --- Nobody complained -- You are receiving this mail because: You are the QA Contact for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
https://bugs.exim.org/show_bug.cgi?id=514 Git Commit g...@exim.org changed: What|Removed |Added CC||g...@exim.org --- Comment #12 from Git Commit g...@exim.org --- Git commit: http://git.exim.org/exim.git/commitdiff/846430d945e9056842ad7f12f85d43435d78baf0 commit 846430d945e9056842ad7f12f85d43435d78baf0 Author: Jeremy Harris jgh146...@wizmail.org AuthorDate: Thu May 7 21:36:22 2015 +0100 Commit: Jeremy Harris jgh146...@wizmail.org CommitDate: Thu May 7 21:36:22 2015 +0100 log lengthy dns lookups. bug 514 original by derrick.r...@gmail.com, massaged by jh doc/doc-docbook/spec.xfpt| 12 +++ doc/doc-txt/NewStuff | 2 ++ src/src/globals.c| 1 + src/src/globals.h| 1 + src/src/host.c | 76 +++- src/src/readconf.c | 1 + test/confs/0606 | 24 ++ test/dnszones-src/db.test.ex | 6 test/runtest | 3 ++ test/scripts/-Basic/0606 | 19 +++ test/src/fakens.c| 67 +++--- test/stderr/0606 | 39 +++ test/stdout/0606 | 20 13 files changed, 258 insertions(+), 13 deletions(-) -- You are receiving this mail because: You are the QA Contact for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
https://bugs.exim.org/show_bug.cgi?id=514 Jeremy Harris jgh146...@wizmail.org changed: What|Removed |Added Target Milestone|Exim 4.77 |Exim 4.86 Status|NEW |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
https://bugs.exim.org/show_bug.cgi?id=514 Jeremy Harris jgh146...@wizmail.org changed: What|Removed |Added Hardware|Other |All OS|Linux |All -- You are receiving this mail because: You are the QA Contact for the bug. -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
--- You are receiving this mail because: --- You are the QA contact for the bug. http://bugs.exim.org/show_bug.cgi?id=514 Nigel Metheringham ni...@exim.org changed: What|Removed |Added Target Milestone|Exim 4.72 |Exim 4.73 Target Milestone|Exim 4.73 |Exim 4.77 Jeremy Harris jgh146...@wizmail.org changed: What|Removed |Added CC||jgh146...@wizmail.org AssignedTo|ni...@exim.org |jgh146...@wizmail.org -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
--- You are receiving this mail because: --- You are the QA contact for the bug. http://bugs.exim.org/show_bug.cgi?id=514 --- Comment #10 from Derrick [EMAIL PROTECTED] 2008-11-21 01:43:05 --- Unfortunately, the wrappers I wrote are avoided by the test suite. Ideally I think host.c should be rewritten in some areas with the following goals in mind: * do less 'test harness' special casing (the test README mentions test domains handled in exim that /could/ be handled by fakens... they should be) * clean up the preprocessor decisions, including... * have a single function for each get host by name and get host by address. They should return a common type, independent of how it is implemented on the available system. Unfortunately, this effort is beyond my comfort level and available time. -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
--- You are receiving this mail because: --- You are the QA contact for the bug. http://bugs.exim.org/show_bug.cgi?id=514 Derrick [EMAIL PROTECTED] changed: What|Removed |Added Attachment #284 is|0 |1 obsolete|| Attachment #285 is|0 |1 obsolete|| Attachment #286 is|0 |1 obsolete|| --- Comment #11 from Derrick [EMAIL PROTECTED] 2008-11-21 01:45:08 --- Created an attachment (id=287) -- (http://bugs.exim.org/attachment.cgi?id=287) patch Replacing individual patches with cvs unified patch. As mentioned, this is not properly tested (due to test suite limitations and my lack of access to machines with varying gethostby* implementions) -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
Re: [exim-dev] [Bug 514] log slow DNS queries
On Thu, 20 Nov 2008, Derrick wrote: I've made changes per the suggestions. I feel that in order to properly test this, I'd need a nameserver that I can tinker with by making it delay responses. Also I cannot properly test all the various ways that host lookups are done, since most are excluded by preprocessor statements based on the available functions. Any ideas for testing? If I remember correctly (and I've now been away from Exim for over a year, so maybe I don't :-), the test suite contains a fake nameserver that can be made to delay and otherwise give non-normal responses. Grep the Exim code for stuff about testing and take a look at the scripts and other documentation in the test suite. -- Philip Hazel -- ## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
--- You are receiving this mail because: --- You are the QA contact for the bug. http://bugs.exim.org/show_bug.cgi?id=514 --- Comment #6 from Derrick [EMAIL PROTECTED] 2008-11-15 22:10:35 --- Created an attachment (id=286) -- (http://bugs.exim.org/attachment.cgi?id=286) host.c patch - majority of changes -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
--- You are receiving this mail because: --- You are the QA contact for the bug. http://bugs.exim.org/show_bug.cgi?id=514 --- Comment #4 from Derrick [EMAIL PROTECTED] 2008-11-15 22:07:40 --- Created an attachment (id=284) -- (http://bugs.exim.org/attachment.cgi?id=284) macros.h patch -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
--- You are receiving this mail because: --- You are the QA contact for the bug. http://bugs.exim.org/show_bug.cgi?id=514 --- Comment #3 from Derrick [EMAIL PROTECTED] 2008-11-15 22:06:41 --- Attaching patches. Wrote wrappers for all the lower level functions used in host.c -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
--- You are receiving this mail because: --- You are the QA contact for the bug. http://bugs.exim.org/show_bug.cgi?id=514 --- Comment #7 from Kjetil Torgrim Homme [EMAIL PROTECTED] 2008-11-16 17:00:41 --- Please redo patches as unified or context diff, and put them in one file. I think you should use gettimeofday, 1 second granularity isn't very accurate. lastly, this will inundate the log, so I think you either need to implement a hardcoded cutoff (say, 0.5 seconds) or your host_lookup_time suggestion, although I'd call it something like log_slow_host_lookup. -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[exim-dev] [Bug 514] log slow DNS queries
--- You are receiving this mail because: --- You are the QA contact for the bug. http://bugs.exim.org/show_bug.cgi?id=514 Derrick [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Derrick [EMAIL PROTECTED] 2008-10-26 17:45:01 --- Exim logging is either on or off for specific log types. At least I don't see any conditional logging options: http://exim.org/exim-html-current/doc/html/spec_html/ch49.html#SECTlogselector I'd suggest a 'host_lookup_time' option which will produce more output than may be necessary. This would be similar to 'deliver_time' and off by default. Any thoughts for / against this option? -- Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email -- ## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
