Re: [exim] failed: condition name expected, but found ""

2021-04-25 Thread Jeremy Harris via Exim-users

On 25/04/2021 22:51, Wayne via Exim-users wrote:

transport_filter = ${if 
match_address{$sender_address}{myfromaddress@somedomain}{/bin/mycmd}}



   == recipi...@domain.com R=dnslookup T=remote_smtp defer (0): Expansion of "${if" from command 
"${if  match_address{$sender_address}{myfromaddress@somedomain}{/sbin/mycmd}}" in remote_smtp 
transport failed: condition name expected, but found ""
    deliveries are done 

"match_address" is listed under Expansion Conditions but that must
not be what a "condition name" is?


The argument for a transport_filter option is split (by whitespace)
before each element is string-expanded.  See the discussion in
the generic-options-for-transports chapter of the docs.
--
Cheers,
  Jeremy

--
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/


[exim] failed: condition name expected, but found ""

2021-04-25 Thread Wayne via Exim-users
I must be misunderstanding the documentation or the log error below.

I have this condition in my smtp transport.

transport_filter = ${if 
match_address{$sender_address}{myfromaddress@somedomain}{/bin/mycmd}}

I get this error in the log:

LOG: MAIN
  == recipi...@domain.com R=dnslookup T=remote_smtp defer (0): Expansion of 
"${if" from command "${if  
match_address{$sender_address}{myfromaddress@somedomain}{/sbin/mycmd}}" in 
remote_smtp transport failed: condition name expected, but found ""
   deliveries are done 

"match_address" is listed under Expansion Conditions but that must
not be what a "condition name" is?

What am I doing wrong?

Wayne

-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/


Re: [exim] gmail - spf/dkim/dmarc question

2021-04-25 Thread Andrew C Aitchison via Exim-users

On Sun, 25 Apr 2021, Wayne via Exim-users wrote:


I'm using EXIM, though I don't believe this is an EXIM specific issue.
Perhaps someone on this list has run into this before.

I've used a few different tools to verify my SPF, DKIM and DMARC DNS
records to ensure they are valid. If I send an email to my gmail
account, open the message, click on the menu on the right side of the
message and choose "show original". The table at the top of the
message contains "DKIM: 'PASS' with domain useunix.net".

While viewing the original, I can see in the received headers that
gmail adds:

ARC-Authentication-Results: i=1; mx.google.com;


I *think* Google values ARC above DMARC.


  dkim=pass header.i=@useunix.net header.s=dkim-2020090201
header.b=jKl5NQPj;
  spf=pass (google.com: domain of wcu...@useunix.net designates
172.104.219.156 as permitted sender) smtp.mailfrom=wcu...@useunix.net;
  dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=useunix.net


So DKIM, SPF and DMARC all pass.


If I send to my gmail account from my office, which uses O365, and
view the original the table at the top has entries for DKIM but also
for SPF and DMARC.

SPF:PASS with IP X.X.X.X
DKIM:   'PASS' with domain myworkdomain.com
DMARC:  'PASS'

Any idea why the discrepancy in the fields that gmail displays at the
top of the message? I must have something configured incorrectly
somewhere, but gmail doesn't make it easy for me to determine what the
issue is.


The difference could be that yours has ARC headers, or that Google
has special handling for O365, but the evidence suggests that
Google are happy with what you are doing.

--
Andrew C. Aitchison Kendal, UK
and...@aitchison.me.uk

--
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/


Re: [exim] gmail - spf/dkim/dmarc question

2021-04-25 Thread Wayne via Exim-users
On Sun, Apr 25, 2021 at 11:30:07PM +0300, Evgeniy Berdnikov via Exim-users 
wrote:
> On Sun, Apr 25, 2021 at 07:10:57PM +, Wayne via Exim-users wrote:
> > Any idea why the discrepancy in the fields that gmail displays at the
> > top of the message?
> 
>  What you are considered as "discrepancy" and why?
> -- 
>  Eugene Berdnikov
> 

Why does the table not list "DMARC: PASS" and "SPF: PASS" for messages sent 
from my
system? I have what appear to valid SPF, DKIM and DMARC records in the DNS.

Wayne

-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/


Re: [exim] gmail - spf/dkim/dmarc question

2021-04-25 Thread Evgeniy Berdnikov via Exim-users
On Sun, Apr 25, 2021 at 07:10:57PM +, Wayne via Exim-users wrote:
> Any idea why the discrepancy in the fields that gmail displays at the
> top of the message?

 What you are considered as "discrepancy" and why?
-- 
 Eugene Berdnikov

-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/


[exim] gmail - spf/dkim/dmarc question

2021-04-25 Thread Wayne via Exim-users
I'm using EXIM, though I don't believe this is an EXIM specific issue.
Perhaps someone on this list has run into this before.

I've used a few different tools to verify my SPF, DKIM and DMARC DNS
records to ensure they are valid. If I send an email to my gmail
account, open the message, click on the menu on the right side of the
message and choose "show original". The table at the top of the
message contains "DKIM: 'PASS' with domain useunix.net".

While viewing the original, I can see in the received headers that
gmail adds:

ARC-Authentication-Results: i=1; mx.google.com;
   dkim=pass header.i=@useunix.net header.s=dkim-2020090201
header.b=jKl5NQPj;
   spf=pass (google.com: domain of wcu...@useunix.net designates
172.104.219.156 as permitted sender) smtp.mailfrom=wcu...@useunix.net;
   dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=useunix.net 



If I send to my gmail account from my office, which uses O365, and
view the original the table at the top has entries for DKIM but also
for SPF and DMARC.

SPF:PASS with IP X.X.X.X
DKIM:   'PASS' with domain myworkdomain.com
DMARC:  'PASS'



Any idea why the discrepancy in the fields that gmail displays at the
top of the message? I must have something configured incorrectly
somewhere, but gmail doesn't make it easy for me to determine what the
issue is.

Thanks in advance,
Wayne


-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/


Re: [exim] "allow_insecure_tainted_data = yes" - was: tainted data issues

2021-04-25 Thread Heiko Schlittermann via Exim-users
Thank you for spending your time :)

Andreas Metzler via Exim-users  (So 25 Apr 2021 08:12:58 
CEST):
>  void
> -openlogs();
> +open_logs(const char *m);
> is the proper fix?

It is one possible fix. But the char* isn't used anymore (was there for
debugging). I updated the branch.

> log.c: In function 'set_file_path':
> log.c:654:45: warning: pointer type mismatch in conditional expression
>   654 | uschar *ss = *log_file_path ? log_file_path : LOG_FILE_PATH;

Same here. Fixed.

> In file included from exim.h:486,
>  from log.c:13:
> log.c:657:31: warning: passing argument 1 of 'string_nextinlist_trc' from 
> incompatible pointer type [-Wincompatible-pointer-types]
>   657 | while ((s = string_nextinlist(&ss, &sep, log_buffer, 
> LOG_BUFFER_SIZE)))
> functions.h:560:25: note: in definition of macro 'string_nextinlist'
>   560 |  string_nextinlist_trc((lp), (sp), (b), (l), US __FUNCTION__, 
> __LINE__)

ditto.
And finally I set my compiler options to be about the same as yours.

-- 
Heiko


signature.asc
Description: PGP signature
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/