Re: [exim] Preservation of $spam_action variable

2021-03-22 Thread Paul Warren via Exim-users

Hi Jeremy,

On 22/03/2021 16:54, Jeremy Harris via Exim-users wrote:

On 22/03/2021 16:35, Paul Warren via Exim-users wrote:

It seems that that "spam_action" isn't preserved either:

https://github.com/Exim/exim/blob/master/src/src/spool_out.c#L238

I'm I missing something, or is this just an omission from the docs?


Looks like the latter.  The variable was added in 2015, postdating
the merge of EXISCAN in 2004, and there was no code in that commit
(c5f280e20a) passing it via the spool.

I could touch up the docs, or just add the code (if you want to
do the latter yourself, it's pretty obvious for both the reading
and writing sides).  I'm assuming it's likely to be a short string.


Thanks for confirming.  It looks like the longest standard string is 
"rewrite subject", so yes, not too long.


That said, at least for our purposes, the score is sufficient so just 
tweaking the docs would be fine.


Paul


--
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/


Re: [exim] Preservation of $spam_action variable

2021-03-22 Thread Jeremy Harris via Exim-users

On 22/03/2021 16:35, Paul Warren via Exim-users wrote:

The documentation says:

"When the spam condition is run, it sets up a number of expansion variables. Except 
for $spam_report, these variables are saved with the received message so are available 
for use at delivery time."

https://www.exim.org/exim-html-current/doc/html/spec_html/ch-content_scanning_at_acl_time.html#SECID206

It seems that that "spam_action" isn't preserved either:

https://github.com/Exim/exim/blob/master/src/src/spool_out.c#L238

I'm I missing something, or is this just an omission from the docs?


Looks like the latter.  The variable was added in 2015, postdating
the merge of EXISCAN in 2004, and there was no code in that commit
(c5f280e20a) passing it via the spool.

I could touch up the docs, or just add the code (if you want to
do the latter yourself, it's pretty obvious for both the reading
and writing sides).  I'm assuming it's likely to be a short string.
--
Cheers,
  Jeremy

--
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/


[exim] Preservation of $spam_action variable

2021-03-22 Thread Paul Warren via Exim-users

The documentation says:

"When the spam condition is run, it sets up a number of expansion 
variables. Except for $spam_report, these variables are saved with the 
received message so are available for use at delivery time."


https://www.exim.org/exim-html-current/doc/html/spec_html/ch-content_scanning_at_acl_time.html#SECID206

It seems that that "spam_action" isn't preserved either:

https://github.com/Exim/exim/blob/master/src/src/spool_out.c#L238

I'm I missing something, or is this just an omission from the docs?

Paul






--
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/