Re: [Echo]New object-rotate-right icon draft (last of object-* series)
On Wed, 2008-09-17 at 16:16 -0700, Luya Tshimbalanga wrote: Martin Sourada a écrit : Good, just check whether you have the 48x48 icon grouped and labelled as scalable (otherwise the scalable icon might end up being empty). I recently realised I tend to forgot to do that step (and it's possible I forgot to do it in the object-rotate-* icons), so I'll probably create another script that would just check if the source SVG is OK and print warnings/errors if there are problems... Or maybe I could check it in the echo-add-icon before anything is done... I just hit another bug. For some reasons, png icons on any size will appears either empty or out of space. Check out the git. Luya Actually there were two objects with inkscape:layer set to plate, check this output: $ /usr/bin/inkscape -i 256x256 -e /home/martin/Projects/Echo/git/base/256x256/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i 48x48 -e /home/martin/Projects/Echo/git/base/48x48/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i 32x32 -e /home/martin/Projects/Echo/git/base/32x32/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i 24x24 -e /home/martin/Projects/Echo/git/base/24x24/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i 22x22 -e /home/martin/Projects/Echo/git/base/22x22/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i 16x16 -e /home/martin/Projects/Echo/git/base/16x16/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i rect5309 -e /home/martin/Projects/Echo/git/base/256x256/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i rect5311 -e /home/martin/Projects/Echo/git/base/48x48/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i rect5313 -e /home/martin/Projects/Echo/git/base/32x32/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i rect5315 -e /home/martin/Projects/Echo/git/base/24x24/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i rect5317 -e /home/martin/Projects/Echo/git/base/22x22/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 $ /usr/bin/inkscape -i rect5319 -e /home/martin/Projects/Echo/git/base/16x16/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 Seems like you imported another one-canvas SVG, but didn't removed the hidden plate layer, which of course imported not as a layer but as an object inside the layer you imported it to. You can delete it using Edit - XMLEditor... I've fixed both the SVG and the commit. signature.asc Description: This is a digitally signed message part ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
On Thu, 2008-09-18 at 10:54 +0200, Martin Sourada wrote: I've fixed both the SVG and the commit. And I attach fixed SVG for the object-rotate-right. Martin attachment: object-rotate-right.svg signature.asc Description: This is a digitally signed message part ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
On Wed, 2008-09-17 at 16:16 -0700, Luya Tshimbalanga wrote: Martin Sourada a écrit : Good, just check whether you have the 48x48 icon grouped and labelled as scalable (otherwise the scalable icon might end up being empty). I recently realised I tend to forgot to do that step (and it's possible I forgot to do it in the object-rotate-* icons), so I'll probably create another script that would just check if the source SVG is OK and print warnings/errors if there are problems... Or maybe I could check it in the echo-add-icon before anything is done... I just hit another bug. For some reasons, png icons on any size will appears either empty or out of space. Check out the git. Luya I could perhaps add a check for whether the same size isn't generated twice. I think that's the best solution for this. But if I checked for the correctness of the SVG at the before doing anything, this another check might not be necessary... Martin signature.asc Description: This is a digitally signed message part ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
Martin Sourada a écrit : $ /usr/bin/inkscape -i rect5319 -e /home/martin/Projects/Echo/git/base/16x16/actions/object-rotate-left.png object-rotate-left.svg /dev/null 21 Seems like you imported another one-canvas SVG, but didn't removed the hidden plate layer, which of course imported not as a layer but as an object inside the layer you imported it to. You can delete it using Edit - XMLEditor... I've fixed both the SVG and the commit. I saw that but I was not sure if that layer was a cause. It was hard to detect visually. I am pushing your corrected object-rotate-right version. Luya - still in learning mode ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
On Wed, 2008-09-17 at 10:05 -0700, Luya Tshimbalanga wrote: Based on object-icon-left icon set. Only difference is the direction. It should be fine after tweaking the previous object-rotate-left. Comment welcome. Luya ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list The 256x256 is too thick, compare with object-rotate-left. The 48x48 needs a little tweak on the out-most border, in top left corner of the canvas it's a little blurry. The 32x32 one seems to have blurry transition between the orange and white part (not 100% sure about that, it feels that way). The 22x22 is a little offset. Compare the positioning with the same object in object-rotate-left. Other that that it looks good :) One suggestion: try to compare the images directly with object-rotate-left to better see the differences ;-) Martin signature.asc Description: This is a digitally signed message part ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
Martin Sourada a écrit : The 256x256 is too thick, compare with object-rotate-left. Whoops, corrected. The 48x48 needs a little tweak on the out-most border, in top left corner of the canvas it's a little blurry. Slight alignment set on left side. The 32x32 one seems to have blurry transition between the orange and white part (not 100% sure about that, it feels that way). Changed the direction of gradient. The 22x22 is a little offset. Fixed. svg version is hosted due to limit. Luya Reference: -- http://luya.fedorapeople.org/echo/actions/object-rotate-right.svg inline: object-rotate-right.png signature.asc Description: OpenPGP digital signature ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
Martin Sourada a écrit : I've fixed the remaining issues, see the attachment (I've also removed unused defs in the SVG, so it's not that big now). Martin Ok. There is no further comment. Shall I push it to git? Luya signature.asc Description: OpenPGP digital signature ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
On Wed, 2008-09-17 at 14:41 -0700, Luya Tshimbalanga wrote: Martin Sourada a écrit : I've fixed the remaining issues, see the attachment (I've also removed unused defs in the SVG, so it's not that big now). Martin Ok. There is no further comment. Shall I push it to git? Luya You are free to do so. Don't forget to let the echo-add-icon script also do the branch specific changes - it's not only adding symlinks, but also adding the icon to the build scripts (for master branch). You haven't done this for object-flip-* pushes (so I've done it instead ;-). You can call the scrip multiple times - if you do not make any changes, it generates (almost always) the exact same PNGs and always same SVGs, so if you forget to make the branch changes, you can push it once again and do them for the second time (or e.g. if you forget to add symlink, ...). It also checks for whether the icon / symlink is already included in the build scripts (speaking now about master branch), so it should not do any duplicities either, so you don't have to worry calling it multiple times on same icon ;-) Martin signature.asc Description: This is a digitally signed message part ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
Martin Sourada a écrit : You are free to do so. Don't forget to let the echo-add-icon script also do the branch specific changes - it's not only adding symlinks, but also adding the icon to the build scripts (for master branch). You haven't done this for object-flip-* pushes (so I've done it instead ;-). You can call the scrip multiple times - if you do not make any changes, it generates (almost always) the exact same PNGs and always same SVGs, so if you forget to make the branch changes, you can push it once again and do them for the second time (or e.g. if you forget to add symlink, ...). So that was the bug from echo-artist package. Good to see the process is fixed. It also checks for whether the icon / symlink is already included in the build scripts (speaking now about master branch), so it should not do any duplicities either, so you don't have to worry calling it multiple times on same icon ;-) Let's give a try. Luya signature.asc Description: OpenPGP digital signature ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
On Wed, 2008-09-17 at 15:46 -0700, Luya Tshimbalanga wrote: So that was the bug from echo-artist package. Good to see the process is fixed. The only bug I am aware of so far was exposed in this commit: http://git.fedorahosted.org/git/?p=echo-icon-theme;a=commitdiff;h=c7faed7f8e939924ac9408d3827a310b8a03d2e8#patch7 That was fixed with echo-artist-0.1.1. Let's give a try. Luya Good, just check whether you have the 48x48 icon grouped and labelled as scalable (otherwise the scalable icon might end up being empty). I recently realised I tend to forgot to do that step (and it's possible I forgot to do it in the object-rotate-* icons), so I'll probably create another script that would just check if the source SVG is OK and print warnings/errors if there are problems... Or maybe I could check it in the echo-add-icon before anything is done... Martin signature.asc Description: This is a digitally signed message part ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
Re: [Echo]New object-rotate-right icon draft (last of object-* series)
Martin Sourada a écrit : Good, just check whether you have the 48x48 icon grouped and labelled as scalable (otherwise the scalable icon might end up being empty). I recently realised I tend to forgot to do that step (and it's possible I forgot to do it in the object-rotate-* icons), so I'll probably create another script that would just check if the source SVG is OK and print warnings/errors if there are problems... Or maybe I could check it in the echo-add-icon before anything is done... I just hit another bug. For some reasons, png icons on any size will appears either empty or out of space. Check out the git. Luya signature.asc Description: OpenPGP digital signature ___ Fedora-art-list mailing list Fedora-art-list@redhat.com http://www.redhat.com/mailman/listinfo/fedora-art-list
