Re: Question about dist-cvs make targets
On Thu, Jan 07, 2010 at 09:28:26AM -0800, Jesse Keating wrote:
As I proceed to port our make system over into fedpkg, I've ran across a
couple targets that are giving me pause.
Is anybody out there making use of the following targets?
patch
I use this quite often to generate patches, but unluckily it only works
if the tarball is extracted into a dir called %{name}-%{version}.
I believe there is also a rediff target, which just renegerates a
patch and copies the comment above the patch.
unused-patches
I use this to easily get a list of patches I can cvs remove after I
removed them from the spec.
Regards
Till
pgptxnl3ULAbr.pgp
Description: PGP signature
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
On Thu, Jan 07, 2010 at 07:47:10PM +0100, Enrico Scholz wrote: Jonathan Underwood jonathan.underw...@gmail.com writes: I have used make patch quite a bit when developing patches. I guess it's just a wrapper around gendiff though, so it maybe redundant i.e. in my use case I could have been using gendiff. fwiw, 'gendiff' does not retain comments in patches and fails when one file is touched by multiple patches. I wrote a wrapper around 'quilt' which is used like Iirc there is a rediff target to keep the comments in a spec. gendiff works with multiple patches if one only wants to modify the last patch and the patches are applied with the right backup-suffixes in %patch. | %apply -n23 -p1 This expands to | quilt import -p 1 %PATCH23 | quilt push -f resp. | %patch23 -p1 on systems without this macro. Refreshing and developing of patches is very easy in this way. Would you please provide more instructions about how to implement it and how to use it? Regards Till pgpIFCjyNs1uS.pgp Description: PGP signature -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
Till Maas opensou...@till.name writes: Would you please provide more instructions about how to implement it and how to use it? quilt has builtin support for spec files. You only need to run quilt setup foo.spec. Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E And now for something completely different. -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
On Thu, 07 Jan 2010 18:28:26 +0100, Jesse Keating wrote: Is anybody out there making use of the following targets? I wanted to use this one: unused-fedora-patches but it does not work, it works only for kernel; fix has been ignored: https://fedorahosted.org/fedora-infrastructure/ticket/1881 Regards, Jan -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Question about dist-cvs make targets
As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? check export patch unused-patches unused-fedora-patches If so, please reply to which one, and in what scenario you use those targets. Thanks! -- Jesse Keating Fedora -- Freedom² is a feature! identi.ca: http://identi.ca/jkeating signature.asc Description: This is a digitally signed message part -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Thu, 7 Jan 2010, Jesse Keating wrote:
As I proceed to port our make system over into fedpkg, I've ran across a
couple targets that are giving me pause.
Is anybody out there making use of the following targets?
check
export
patch
unused-patches
unused-fedora-patches
If so, please reply to which one, and in what scenario you use those
targets. Thanks!
I was using 'unused-patches' until the packaging guidelines had us change
Patch lines to use %{name} if that applied. The unused-patches target would
be helpful if it could expand RPM macros.
That may have changed now. I haven't checked it in a while.
- --
David Cantrell dcantr...@redhat.com
Red Hat / Honolulu, HI
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.13 (GNU/Linux)
iEYEARECAAYFAktGHxAACgkQ5hsjjIy1VkkA8ACeIRILiiyrMYGvRIf/HW4/C1Rh
wK8AoLRRd0JWEftiXv7Vqpop0LLG1eXg
=Ix6d
-END PGP SIGNATURE-
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
2010/1/7 Jesse Keating jkeat...@redhat.com: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? check export patch unused-patches unused-fedora-patches If so, please reply to which one, and in what scenario you use those targets. Thanks! I have used make patch quite a bit when developing patches. I guess it's just a wrapper around gendiff though, so it maybe redundant i.e. in my use case I could have been using gendiff. -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
Jesse Keating píše v Čt 07. 01. 2010 v 09:28 -0800: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? unused-patches I tried to use this one when putting some packages with long history and some balast into a shape, but I wasn't 100% successful IIRC. If so, please reply to which one, and in what scenario you use those targets. Thanks! Dan -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
On Thu, Jan 07, 2010 at 09:28:26AM -0800, Jesse Keating wrote: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? check export patch unused-patches unused-fedora-patches If so, please reply to which one, and in what scenario you use those targets. Thanks! I used 'unused-patches' every now then to quickly check which patches are obsolete - it is easier than doing it by hand in packages which have more than 10 patches applied. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
On Thu, Jan 7, 2010 at 5:28 PM, Jesse Keating jkeat...@redhat.com wrote: unused-patches I use this one, but it's probably something that should just happen as part of a build sanity check, or even better make it harder to cause (the new dist-git setup might do this right?) -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
On Thu, 2010-01-07 at 07:51 -1000, David Cantrell wrote:
I was using 'unused-patches' until the packaging guidelines had us change
Patch lines to use %{name} if that applied. The unused-patches target would
be helpful if it could expand RPM macros.
That's a guideline worth ignoring.
If I'm being less charitable, that's a guideline worth deleting.
- ajax
signature.asc
Description: This is a digitally signed message part
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
Jonathan Underwood jonathan.underw...@gmail.com writes: I have used make patch quite a bit when developing patches. I guess it's just a wrapper around gendiff though, so it maybe redundant i.e. in my use case I could have been using gendiff. fwiw, 'gendiff' does not retain comments in patches and fails when one file is touched by multiple patches. I wrote a wrapper around 'quilt' which is used like | %apply -n23 -p1 This expands to | quilt import -p 1 %PATCH23 | quilt push -f resp. | %patch23 -p1 on systems without this macro. Refreshing and developing of patches is very easy in this way. Enrico -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
On Thu, 2010-01-07 at 19:47 +0100, Enrico Scholz wrote: Jonathan Underwood jonathan.underw...@gmail.com writes: I have used make patch quite a bit when developing patches. I guess it's just a wrapper around gendiff though, so it maybe redundant i.e. in my use case I could have been using gendiff. fwiw, 'gendiff' does not retain comments in patches and fails when one file is touched by multiple patches. I wrote a wrapper around 'quilt' which is used like | %apply -n23 -p1 This expands to | quilt import -p 1 %PATCH23 | quilt push -f resp. | %patch23 -p1 on systems without this macro. Refreshing and developing of patches is very easy in this way. Enrico I think the patch target could be replaced by my exploded tree with git approach. -- Jesse Keating Fedora -- Freedom² is a feature! identi.ca: http://identi.ca/jkeating signature.asc Description: This is a digitally signed message part -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
DC == David Cantrell dcantr...@redhat.com writes:
DC I was using 'unused-patches' until the packaging guidelines had us
DC change Patch lines to use %{name} if that applied.
Please quote chapter and verse there. I don't recall any guidelines
requiring such a thing.
- J
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
Re: Question about dist-cvs make targets
On Thu, 7 Jan 2010, Jesse Keating wrote: As I proceed to port our make system over into fedpkg, I've ran across a couple targets that are giving me pause. Is anybody out there making use of the following targets? unused-patches I use this fairly often, typically to clean up leftovers after rebasing to new version. - Panu - -- fedora-devel-list mailing list fedora-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-devel-list
