[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Bug 449356 depends on bug 461087, which changed state. Bug 461087 Summary: provide templates for automatically-releasing handles to foreign resources https://bugzilla.mozilla.org/show_bug.cgi?id=461087 What|Old Value |New Value Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=449356
--- Comment #20 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-11-06
14:54:31 PST ---
Landed this but had to back out due to:
REFTEST TEST-PASS |
file:///builds/slave/trunk_linux-7/build/layout/reftests/bidi/bidi-003.html |
REFTEST TEST-KNOWN-FAIL |
file:///builds/slave/trunk_linux-7/build/layout/reftests/bidi/bidi-004.html |
REFTEST TEST-KNOWN-FAIL |
file:///builds/slave/trunk_linux-7/build/layout/reftests/bidi/bidi-004-j.html |
REFTEST TEST-PASS |
file:///builds/slave/trunk_linux-7/build/layout/reftests/bidi/bidi-005.html |
../../objdir/dist/bin/run-mozilla.sh: line 131: 6372 Segmentation fault
$prog ${1+$@}
program finished with exit code 139
TinderboxPrint: reftestbr/176/0/10
Haven't yet succeeded in reproducing.
--
Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-fonts-bugs-list mailing list
Fedora-fonts-bugs-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 --- Comment #21 from Robert O'Callahan (:roc) (Mozilla Corporation) [EMAIL PROTECTED] 2008-11-06 16:00:55 PST --- Try it under Valgrind. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 --- Comment #22 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-11-06 16:26:46 PST --- (In reply to comment #21) Thanks. Valgrind found the uninitialized variables in comment 15, but it hasn't reported a problem with the bidi test, with debug and optimized builds. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED Target Milestone|mozilla1.9.1|mozilla1.9.1b2 --- Comment #24 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-11-06 20:32:39 PST --- http://hg.mozilla.org/mozilla-central/rev/d062597e5b3d http://hg.mozilla.org/mozilla-central/rev/b39e3a7974f2 -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Attachment #346567||review?([EMAIL PROTECTED]) Flag|| --- Comment #16 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-11-05 16:47:34 PST --- Created an attachment (id=346567) -- (https://bugzilla.mozilla.org/attachment.cgi?id=346567) avoid static object Our leak test tools don't seem to like (non-POD?) static objects (even with function scope). -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Attachment #346567|review?([EMAIL PROTECTED]) | Flag|| Attachment #346567|0 |1 is obsolete|| Attachment #346569||review?([EMAIL PROTECTED]) Flag|| --- Comment #17 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-11-05 16:53:08 PST --- Created an attachment (id=346569) -- (https://bugzilla.mozilla.org/attachment.cgi?id=346569) avoid static object v2 Putting the smaller object after the larger hash tables. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Attachment #346344|0 |1 is obsolete|| Attachment #346569|0 |1 is obsolete|| --- Comment #19 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-11-05 17:41:32 PST --- Created an attachment (id=346583) -- (https://bugzilla.mozilla.org/attachment.cgi?id=346583) including all changes in one patch Including all changes in one patch. The only new change here is removal of the static keyword from the typedef (which some compilers didn't seem to mind/notice). --- a/gfx/thebes/src/gfxPangoFonts.cpp +++ b/gfx/thebes/src/gfxPangoFonts.cpp @@ -601,8 +601,6 @@ private: PRPackedBool mHaveFallbackFonts; }; - -static typedef FcBool (*FcPatternRemoveFunction)(FcPattern *p, const char *object, int id); -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 --- Comment #14 from Robert O'Callahan (:roc) (Mozilla Corporation) [EMAIL PROTECTED] 2008-11-04 16:50:06 PST --- What errors? -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=449356
--- Comment #15 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-11-04
17:21:41 PST ---
Uninitialized variables:
--- a/gfx/thebes/src/gfxPangoFonts.cpp
+++ b/gfx/thebes/src/gfxPangoFonts.cpp
@@ -807,1 +807,1 @@ gfxFcPangoFontSet::SortPreferredFonts()
-for (PRUint32 r; r requiredLangs.Length(); ++r) {
+for (PRUint32 r = 0; r requiredLangs.Length(); ++r) {
@@ -826,1 +826,1 @@ gfxFcPangoFontSet::SortPreferredFonts()
-for (PRUint32 r; r requiredLangs.Length(); ++r) {
+for (PRUint32 r = 0; r requiredLangs.Length(); ++r) {
Wrong test:
--- a/gfx/thebes/src/gfxFontconfigUtils.h
+++ b/gfx/thebes/src/gfxFontconfigUtils.h
@@ -213,1 +213,1 @@ public:
-PRBool IsKeyInitialized() { return mKey.IsVoid(); }
+PRBool IsKeyInitialized() { return !mKey.IsVoid(); }
The aForce parameter to UpdateFontListInternal forces a check for changes now,
but that doesn't guarantee invalidation of caches (unless a change is
detected).
--- a/gfx/thebes/src/gfxFontconfigUtils.cpp
+++ b/gfx/thebes/src/gfxFontconfigUtils.cpp
@@ -923,6 +923,7 @@ gfxFontconfigUtils::GetLangSupportEntry(
// entry-mSupport needs to be recalculated, but this is an
// indication that the set of installed fonts has changed, so
// update all caches.
+mLastConfig = NULL; // invalidates caches
UpdateFontListInternal(PR_TRUE);
return GetLangSupportEntry(aLang, aWithFonts);
}
--
Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-fonts-bugs-list mailing list
Fedora-fonts-bugs-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Robert O'Callahan (:roc) (Mozilla Corporation) [EMAIL PROTECTED] changed: What|Removed |Added Attachment #346004|review?([EMAIL PROTECTED]) |review+ Flag|| -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Attachment #342841|0 |1 is obsolete|| Attachment #344063||review?([EMAIL PROTECTED]) Flag|| --- Comment #8 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-10-21 04:53:18 PDT --- Created an attachment (id=344063) -- (https://bugzilla.mozilla.org/attachment.cgi?id=344063) font selection in Mozilla's PangoFcFontMap 1.0 This includes removal of gfxFontconfigUtils::mAliasTable for startup time improvement, as well as tidying up and making things more robust. It feels like jumping through a couple of hoops to use a PangoFcFontMap, but it seems worth it to avoid risks associated with replacing pango_itemize at this stage. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 --- Comment #10 from Robert O'Callahan (:roc) (Mozilla Corporation) [EMAIL PROTECTED] 2008-10-21 17:05:26 PDT --- One thing that would help is a big comment somewhere explaining what the overall strategy is. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Depends on||461087 -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Attachment #341049|0 |1 is obsolete|| --- Comment #6 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-10-12 21:42:06 PDT --- Created an attachment (id=342841) -- (https://bugzilla.mozilla.org/attachment.cgi?id=342841) font selection in Mozilla's PangoFcFontMap 0.4 This is a proof of concept patch. It still needs a bit of tidying up. Results from Talos on the try server: ref w/patch change Ts (ms)1435 1463 +2% Tp (ms) 446 441 -1% Tp_RSS (MB) 11080-27% Reference log: http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1223866852.1223870369.23733.gz w/patch: http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1223860252.1223863695.10237.gz The Ts change may be due to gfxFontconfigUtils being initialized earlier, reverting some of the savings from the patch in bug 404857 comment 13. If so, doing some of the initialization lazily should recover that. (Some of it may never be used.) There is more happening in the Tp test than is indicated in the overall result here. The Tp test runs through 400 pages then re-runs through the same set of 400 pages another 9 times. The reported result is an average of some sort over all 10 runs of 400 pages (possibly with some values discarded or other magic thrown in). Without the patch, the mean page load time for the first run is 584 ms, the mean for the second run is 444 ms, and the mean over the remaining runs is 460 ms. The increase after the second run is a bit concerning but it is what would be expected from bug 453200. With this patch, the mean for the first run is 446 ms (-24%), the mean for the second run is 442 ms (~0%), and the mean over the remaining runs is 459 ms (~0%). The time taken for zooming is most related (but not equivalent) to the time for the first run, so IMO having a fast first run is more important than the weight attributed to it in Talos Tp. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Keywords||footprint, perf -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 John Daggett (:jtd) [EMAIL PROTECTED] changed: What|Removed |Added Blocks||458169 -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 John Daggett (:jtd) [EMAIL PROTECTED] changed: What|Removed |Added Blocks|441473 | -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 --- Comment #5 from Christopher Blizzard [EMAIL PROTECTED] 2008-09-30 04:59:48 PDT --- Nice, Karl! Looking forward to see if we can find a happy medium here. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 --- Comment #3 from Karl Tomlinson (:karlt) [EMAIL PROTECTED] 2008-09-29 20:34:07 PDT --- (In reply to comment #0) Using Pango shapers requires being able to construct a PangoFont from a face. The best way to do this is to implement a PangoFcFont using a cairo_scaled_font_t constructed from the face. That has been done in bug 385263. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Bug 449356 depends on bug 456545, which changed state. Bug 456545 Summary: Unify pseudo-inversion of langGrouping https://bugzilla.mozilla.org/show_bug.cgi?id=456545 What|Old Value |New Value Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Depends on||456545 -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Bug 449356 depends on bug 404857, which changed state. Bug 404857 Summary: firefox reloads every font.cache for every page loaded https://bugzilla.mozilla.org/show_bug.cgi?id=404857 What|Old Value |New Value Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Karl Tomlinson (:karlt) [EMAIL PROTECTED] changed: What|Removed |Added Depends on||404857 -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 449356] Refactor gfxPangoFontGroup for user fonts
Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=449356 Nicolas Mailhot [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] ||at.com -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
