[Bug 528675] Review Request: knm-new-fonts - 12x12 JIS X 0208 Bitmap font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528675 --- Comment #4 from Akira TAGOH ta...@redhat.com 2009-10-19 04:24:33 EDT --- test name=size, even. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 528675] Review Request: knm-new-fonts - 12x12 JIS X 0208 Bitmap font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528675 Akira TAGOH ta...@redhat.com changed: What|Removed |Added Flag|needinfo?(ta...@redhat.com) | --- Comment #3 from Akira TAGOH ta...@redhat.com 2009-10-19 04:23:14 EDT --- (In reply to comment #1) 4. you should put /etc/X11/fontpath.d/knm-new and /usr/share/fonts/knm-new/fonts.dir in a separate legacy subpackage Is there any template or the proposed subpackage name for that? knm-new-fixed-legacy-fonts? or knm-new-fixed-fonts-legacy? 7. It would be nice to include a fontconfig file for the font I'm not quite sure if this kind of the bitmap fonts only available for some pt. really helps though. hmm, I haven't tested but something like this? ?xml version=1.0 encoding=UTF-8 !DOCTYPE fontconfig SYSTEM ../fonts.dtd fontconfig alias familyFixed/family default familymonospace/family /default /alias match test name=lang stringja-jp/string /test test name=family stringmonospace/string /test test name=size compare=eq double12/double /test edit name=family mode=prepend binding=same stringFixed/string /edit /match /fontconfig FWIW I don't think Japanese people wants to see the bitmap glyphs for the desktop. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 528675] Review Request: knm-new-fonts - 12x12 JIS X 0208 Bitmap font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528675 --- Comment #5 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-10-19 17:39:14 EDT --- (In reply to comment #3) (In reply to comment #1) 4. you should put /etc/X11/fontpath.d/knm-new and /usr/share/fonts/knm-new/fonts.dir in a separate legacy subpackage Is there any template or the proposed subpackage name for that? knm-new-fixed-legacy-fonts? or knm-new-fixed-fonts-legacy? There are not conventions here because I try very hard to forget core fonts exist, and new packages are not supposed to register in the core fonts system. So that's only a problem for old packages. Technically, you only have to put this stuff in a separate subpackage for multi-font srpms (because fonts.dir can only be provided by a single package), so in your case that's not absolutely needed. Sorry about this, should not have bothered you with it 7. It would be nice to include a fontconfig file for the font I'm not quite sure if this kind of the bitmap fonts only available for some pt. really helps though. The fontconfig file should not change the font visibility, and apps that can use them will be happy hmm, I haven't tested but something like this? ?xml version=1.0 encoding=UTF-8 !DOCTYPE fontconfig SYSTEM ../fonts.dtd fontconfig alias familyFixed/family default familymonospace/family /default /alias match test name=lang stringja-jp/string /test test name=family stringmonospace/string /test test name=size compare=eq double12/double /test edit name=family mode=prepend binding=same stringFixed/string /edit /match /fontconfig Please take /usr/share/fontconfig/templates/l10n-font-template.conf as model (adding maybe the size tweak) FWIW I don't think Japanese people wants to see the bitmap glyphs for the desktop. Some people say yes, others no, people have tried to write CJK rules in fontconfig for years without making everyone happy, at this stage let's not try to be creative and just use our standard template. Behdad is the only one that can hope untangling this mess. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 528675] Review Request: knm-new-fonts - 12x12 JIS X 0208 Bitmap font
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=528675
Nicolas Mailhot nicolas.mail...@laposte.net changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|nicolas.mail...@laposte.net
Flag||fedora-review?,
||needinfo?(ta...@redhat.com)
--- Comment #1 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-10-14
14:33:39 EDT ---
1. technically each file here is a font so the summary should probably be
12x12 JIS X 0208 bitmap fonts
2.
JIS X 0208 is a character set that contains Kanji characters mostly
often used.
⇒ The JIS X 0208 character set contains the most often used Kanji glyphs.
3. your provides/obsoletes are probably too complex, rpmlint complains
knm-new-fonts.noarch: W: self-obsoletion knm_new = 1.1-16 obsoletes knm_new =
1.1-16
IMHO you should drop Provides completely, repoquery says nothing requires
knm_new or knm-new-fonts in Fedora
4. you should put
/etc/X11/fontpath.d/knm-new
and
/usr/share/fonts/knm-new/fonts.dir
in a separate legacy subpackage
5. The fonts declare themselves as fixed, therefore please rename the package
knm-new-fixed-fonts (we want the font name to appear in the package name). Not
sure if using the same name as many other fonts is a good idea, but I guess I
don't care a lot
6. fc-query complains
Can't query face 0 of font file /usr/share/fonts/knm_new/knm12pb.pcf.gz
Can't query face 0 of font file /usr/share/fonts/knm_new/knm12p.pcf.gz
Can't query face 0 of font file /usr/share/fonts/knm_new/knmzn12xb.pcf.gz
Can't query face 0 of font file /usr/share/fonts/knm_new/knmzn12x.pcf.gz
You should open a bug against fontconfig to have it investigated. This is not
normal.
7. It would be nice to include a fontconfig file for the font
8. I don't think it's good style to mix macros for some commands (%{__ln_s},
%{_bindir}/mkfontdir) and not others. The current convention seems to write
plain unmacroized commands with no explicit path
Anyway that's all for the review
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-fonts-bugs-list mailing list
Fedora-fonts-bugs-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 528675] Review Request: knm-new-fonts - 12x12 JIS X 0208 Bitmap font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528675 --- Comment #2 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-10-14 15:00:21 EDT --- (In reply to comment #1) 4. you should put /etc/X11/fontpath.d/knm-new and /usr/share/fonts/knm-new/fonts.dir in a separate legacy subpackage Or maybe not, it seems we tolerate those files right now, so I won't insist on this one, doing the rest is sufficient to make this package disappear from problem reports -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 528675] Review Request: knm-new-fonts - 12x12 JIS X 0208 Bitmap font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528675 Akira TAGOH ta...@redhat.com changed: What|Removed |Added Blocks||511668 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 528675] Review Request: knm-new-fonts - 12x12 JIS X 0208 Bitmap font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528675 Akira TAGOH ta...@redhat.com changed: What|Removed |Added CC||fedora-fonts-bugs-l...@redh ||at.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
