Re: [PATCH] Re-enable rawhide compose.
On Mon, 2009-06-15 at 10:28 -0700, Jesse Keating wrote: > There isn't, we don't have a formal policy about patches when we aren't > in an infrastructure freeze. I just haven't had a chance to review the > patch and/or apply it. The patch is flagged for follow up so I will get > to it soon. Looks like Bill already applied this patch. -- Jesse Keating Fedora -- Freedom² is a feature! identi.ca: http://identi.ca/jkeating signature.asc Description: This is a digitally signed message part ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
On Sun, 2009-06-14 at 20:50 +0200, Jim Meyering wrote: > Hi Jesse, > > Is there an ACK-requirement exemption for patches that > are sufficiently simple? There isn't, we don't have a formal policy about patches when we aren't in an infrastructure freeze. I just haven't had a chance to review the patch and/or apply it. The patch is flagged for follow up so I will get to it soon. -- Jesse Keating Fedora -- Freedom² is a feature! identi.ca: http://identi.ca/jkeating signature.asc Description: This is a digitally signed message part ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
Jim Meyering wrote: > Jesse Keating wrote: >> Send a patch? ... >>From f044206b3d6d2c43c6ea5c16728841a9584e374c Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 11 Jun 2009 11:35:35 +0200 > Subject: [PATCH] configs/build/rawhide: stop upon failure > > If mktemp, clone, or any other step fails, do not perform remaining steps. > s/;/ &&/g > --- > configs/build/rawhide |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configs/build/rawhide b/configs/build/rawhide > index 4a90bb3..1cc949d 100644 > --- a/configs/build/rawhide > +++ b/configs/build/rawhide > @@ -1,3 +1,3 @@ > # rawhide compose > mailto=jkeat...@fedoraproject.org > -15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` && cd $TMPDIR; git > clone -n git://git.fedorahosted.org/git/releng; cd releng; git checkout -b > rawhide-stable; LANG=en_US.UTF-8 ./scripts/buildrawhide $(date "+\%Y\%m\%d"); > sudo -u ftpsync /usr/local/bin/update-fullfilelist fedora > +15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` && cd $TMPDIR && > git clone -n git://git.fedorahosted.org/git/releng && cd releng && git > checkout -b rawhide-stable && LANG=en_US.UTF-8 ./scripts/buildrawhide $(date > "+\%Y\%m\%d") && sudo -u ftpsync /usr/local/bin/update-fullfilelist fedora Hi Jesse, Is there an ACK-requirement exemption for patches that are sufficiently simple? ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
Jesse Keating wrote: > On Mon, 2009-06-08 at 23:20 +0200, Jim Meyering wrote: >> Sure. >> What repo? >> I have a couple fedora-infra-related ones, >> but none that contain that file, and a few quick >> searches didn't show me the light. > > Oh, it's in puppet, wasn't sure if you had puppet access. Sorry I was > short, a bit busy with the FAD and release. I'll circle back to this > and get a diff from you at some point. >From f044206b3d6d2c43c6ea5c16728841a9584e374c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 11 Jun 2009 11:35:35 +0200 Subject: [PATCH] configs/build/rawhide: stop upon failure If mktemp, clone, or any other step fails, do not perform remaining steps. s/;/ &&/g --- configs/build/rawhide |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configs/build/rawhide b/configs/build/rawhide index 4a90bb3..1cc949d 100644 --- a/configs/build/rawhide +++ b/configs/build/rawhide @@ -1,3 +1,3 @@ # rawhide compose mailto=jkeat...@fedoraproject.org -15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` && cd $TMPDIR; git clone -n git://git.fedorahosted.org/git/releng; cd releng; git checkout -b rawhide-stable; LANG=en_US.UTF-8 ./scripts/buildrawhide $(date "+\%Y\%m\%d"); sudo -u ftpsync /usr/local/bin/update-fullfilelist fedora +15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` && cd $TMPDIR && git clone -n git://git.fedorahosted.org/git/releng && cd releng && git checkout -b rawhide-stable && LANG=en_US.UTF-8 ./scripts/buildrawhide $(date "+\%Y\%m\%d") && sudo -u ftpsync /usr/local/bin/update-fullfilelist fedora -- 1.6.3.2.349.g338ec3 ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
On Mon, 2009-06-08 at 23:20 +0200, Jim Meyering wrote: > Sure. > What repo? > I have a couple fedora-infra-related ones, > but none that contain that file, and a few quick > searches didn't show me the light. Oh, it's in puppet, wasn't sure if you had puppet access. Sorry I was short, a bit busy with the FAD and release. I'll circle back to this and get a diff from you at some point. -- Jesse Keating Fedora -- Freedom² is a feature! identi.ca: http://identi.ca/jkeating signature.asc Description: This is a digitally signed message part ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
Jesse Keating wrote: > On Mon, 2009-06-08 at 21:10 +0200, Jim Meyering wrote: >> It'd be good to change the other semicolons to " &&", too. >> Otherwise, failing mktemp will not stop the script, and >> the git clone will run in $HOME. > > Send a patch? Sure. What repo? I have a couple fedora-infra-related ones, but none that contain that file, and a few quick searches didn't show me the light. ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
On Mon, 2009-06-08 at 21:10 +0200, Jim Meyering wrote: > It'd be good to change the other semicolons to " &&", too. > Otherwise, failing mktemp will not stop the script, and > the git clone will run in $HOME. > Send a patch? -- Jesse Keating Fedora -- Freedom² is a feature! identi.ca: http://identi.ca/jkeating signature.asc Description: This is a digitally signed message part ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
Jesse Keating wrote: ... > diff --git a/configs/build/rawhide b/configs/build/rawhide ... > +15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` && cd $TMPDIR; git > clone -n git://git.fedorahosted.org/git/releng; cd releng; git checkout -b > rawhide-stable; LANG=en_US.UTF-8 ./scripts/buildrawhide $(date "+\%Y\%m\%d"); > sudo -u ftpsync /usr/local/bin/update-fullfilelist fedora It'd be good to change the other semicolons to " &&", too. Otherwise, failing mktemp will not stop the script, and the git clone will run in $HOME. An alternative would be to start with "set -e;" (stop on error) 15 6 * * * masher set -e; TMPDIR=`mktemp -d /tmp/rawhide.XX`; ... or to do this: 15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` || exit 1; cd $TMPDIR... ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
On Sunday 07 June 2009 10:41:33 pm Nigel Jones wrote: > +1 +1 > - "Jesse Keating" wrote: > > Massive rawhide for start of F12 finally finished. > > > > Also increase the number of random chars for mktemp and ensure it > > worked > > before continuing. > > --- > > configs/build/rawhide |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/configs/build/rawhide b/configs/build/rawhide > > index eab9097..4a90bb3 100644 > > --- a/configs/build/rawhide > > +++ b/configs/build/rawhide > > @@ -1,3 +1,3 @@ > > # rawhide compose > > mailto=jkeat...@fedoraproject.org > > -#15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.X`; cd $TMPDIR; > > git clone -n git://git.fedorahosted.org/git/releng; cd releng; git > > checkout -b rawhide-stable; LANG=en_US.UTF-8 ./scripts/buildrawhide > > $(date "+\%Y\%m\%d"); sudo -u ftpsync > > /usr/local/bin/update-fullfilelist fedora > > +15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` && cd > > $TMPDIR; git clone -n git://git.fedorahosted.org/git/releng; cd > > releng; git checkout -b rawhide-stable; LANG=en_US.UTF-8 > > ./scripts/buildrawhide $(date "+\%Y\%m\%d"); sudo -u ftpsync > > /usr/local/bin/update-fullfilelist fedora > > -- > > 1.5.5.6 > > > > ___ > > Fedora-infrastructure-list mailing list > > Fedora-infrastructure-list@redhat.com > > https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list > > ___ > Fedora-infrastructure-list mailing list > Fedora-infrastructure-list@redhat.com > https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list signature.asc Description: This is a digitally signed message part. ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
Re: [PATCH] Re-enable rawhide compose.
+1 - "Jesse Keating" wrote: > Massive rawhide for start of F12 finally finished. > > Also increase the number of random chars for mktemp and ensure it > worked > before continuing. > --- > configs/build/rawhide |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configs/build/rawhide b/configs/build/rawhide > index eab9097..4a90bb3 100644 > --- a/configs/build/rawhide > +++ b/configs/build/rawhide > @@ -1,3 +1,3 @@ > # rawhide compose > mailto=jkeat...@fedoraproject.org > -#15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.X`; cd $TMPDIR; > git clone -n git://git.fedorahosted.org/git/releng; cd releng; git > checkout -b rawhide-stable; LANG=en_US.UTF-8 ./scripts/buildrawhide > $(date "+\%Y\%m\%d"); sudo -u ftpsync > /usr/local/bin/update-fullfilelist fedora > +15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` && cd > $TMPDIR; git clone -n git://git.fedorahosted.org/git/releng; cd > releng; git checkout -b rawhide-stable; LANG=en_US.UTF-8 > ./scripts/buildrawhide $(date "+\%Y\%m\%d"); sudo -u ftpsync > /usr/local/bin/update-fullfilelist fedora > -- > 1.5.5.6 > > ___ > Fedora-infrastructure-list mailing list > Fedora-infrastructure-list@redhat.com > https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
[PATCH] Re-enable rawhide compose.
Massive rawhide for start of F12 finally finished. Also increase the number of random chars for mktemp and ensure it worked before continuing. --- configs/build/rawhide |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configs/build/rawhide b/configs/build/rawhide index eab9097..4a90bb3 100644 --- a/configs/build/rawhide +++ b/configs/build/rawhide @@ -1,3 +1,3 @@ # rawhide compose mailto=jkeat...@fedoraproject.org -#15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.X`; cd $TMPDIR; git clone -n git://git.fedorahosted.org/git/releng; cd releng; git checkout -b rawhide-stable; LANG=en_US.UTF-8 ./scripts/buildrawhide $(date "+\%Y\%m\%d"); sudo -u ftpsync /usr/local/bin/update-fullfilelist fedora +15 6 * * * masher TMPDIR=`mktemp -d /tmp/rawhide.XX` && cd $TMPDIR; git clone -n git://git.fedorahosted.org/git/releng; cd releng; git checkout -b rawhide-stable; LANG=en_US.UTF-8 ./scripts/buildrawhide $(date "+\%Y\%m\%d"); sudo -u ftpsync /usr/local/bin/update-fullfilelist fedora -- 1.5.5.6 ___ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
