Change Request - email alias handling

2009-05-21 Thread Toshio Kuratomi
Right now FAS constructs email aliases only for accounts that are 
active.  This is causing us two problems.


1) We have recently implemented a "bot" status for accounts that makes 
it so the account can't be logged into and don't go inactive.  This 
status needs to be allowed to get email as well.


2) inactive accounts are bouncing mail, not just from the pkgdb which 
I've been handling and have a mid-term and long-term plan for fixing but 
also for the wiki watch-page function which we currently don't have a 
good mid-term plan for.  Restoring aliases for inactive accounts seems 
like the best short-term solution for this.


Fixing these requires updating the fas server code.  Attaching a patch 
to hotfix our servers with to do this.  The patch has been tested on 
fas1.stg successfully.


-Toshio
diff --git a/fas/user.py b/fas/user.py
index 236187b..627cb8e 100644
--- a/fas/user.py
+++ b/fas/user.py
@@ -534,7 +534,7 @@ https://admin.fedoraproject.org/accounts/user/edit/%(username)s
 search = unicode(search, 'utf-8', 'replace')
 
 re_search = search.translate({ord(u'*'): ur'%'}).lower()
-people = People.query.filter(and_(People.username.like(re_search), People.status == 'active')).order_by('username')
+people = People.query.filter(and_(People.username.like(re_search), People.status.in_('active', 'bot', 'inactive'))).order_by('username')
 emails = {}
 # Run filter_private via side effect
 for person, discard in ((p, p.filter_private()) for p in people):
___
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list


Re: Change Request - email alias handling

2009-05-21 Thread Mike McGrath
On Thu, 21 May 2009, Toshio Kuratomi wrote:

> Right now FAS constructs email aliases only for accounts that are active.
> This is causing us two problems.
>
> 1) We have recently implemented a "bot" status for accounts that makes it so
> the account can't be logged into and don't go inactive.  This status needs to
> be allowed to get email as well.
>
> 2) inactive accounts are bouncing mail, not just from the pkgdb which I've
> been handling and have a mid-term and long-term plan for fixing but also for
> the wiki watch-page function which we currently don't have a good mid-term
> plan for.  Restoring aliases for inactive accounts seems like the best
> short-term solution for this.
>
> Fixing these requires updating the fas server code.  Attaching a patch to
> hotfix our servers with to do this.  The patch has been tested on fas1.stg
> successfully.
>

+1

-Mike

___
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list


Re: Change Request - email alias handling

2009-05-21 Thread Jeremy Katz
On Thursday, May 21 2009, Toshio Kuratomi said:
> Fixing these requires updating the fas server code.  Attaching a patch  
> to hotfix our servers with to do this.  The patch has been tested on  
> fas1.stg successfully.

Looks good, +1

Jeremy

___
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list