[EMAIL PROTECTED]: rpms/kernel/devel kernel.spec, 1.1006, 1.1007]

2008-10-03 Thread Roland McGrath

What's this about?

___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list


Re: de-modularising for the win!

2008-10-03 Thread Dave Jones
On Fri, Oct 03, 2008 at 01:25:50PM -0400, Bill Nottingham wrote:
 > Dave Jones ([EMAIL PROTECTED]) said: 
 > > On Fri, Oct 03, 2008 at 11:25:49AM -0400, Peter Jones wrote:
 > >  > Bill Nottingham wrote:
 > >  > > See various and sundry plumber's conf discussions.
 > >  > > 
 > >  > > Comments? (The netfilter stuff needs further investigation.)
 > >  > 
 > >  > Also, please add these, since they're nearly always loaded (patch is on
 > >  > top of yours):
 > > 
 > > I think this makes sense to do now as a stop-gap, but one day,
 > > I hope we can get to a situation where we do modprobe of such
 > > things based on a config file instead of always doing it. 
 > 
 > Ideally the DM layer would be able to request_module() the map type
 > whenever necessary.

Wherever possible, yes that would be even better.

Dave

-- 
http://www.codemonkey.org.uk

___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list


Re: de-modularising for the win!

2008-10-03 Thread Bill Nottingham
Dave Jones ([EMAIL PROTECTED]) said: 
> On Fri, Oct 03, 2008 at 11:25:49AM -0400, Peter Jones wrote:
>  > Bill Nottingham wrote:
>  > > See various and sundry plumber's conf discussions.
>  > > 
>  > > Comments? (The netfilter stuff needs further investigation.)
>  > 
>  > Also, please add these, since they're nearly always loaded (patch is on
>  > top of yours):
> 
> I think this makes sense to do now as a stop-gap, but one day,
> I hope we can get to a situation where we do modprobe of such
> things based on a config file instead of always doing it. 

Ideally the DM layer would be able to request_module() the map type
whenever necessary.

Bill

___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list


Re: de-modularising for the win!

2008-10-03 Thread Dave Jones
On Fri, Oct 03, 2008 at 11:25:49AM -0400, Peter Jones wrote:
 > Bill Nottingham wrote:
 > > See various and sundry plumber's conf discussions.
 > > 
 > > Comments? (The netfilter stuff needs further investigation.)
 > 
 > Also, please add these, since they're nearly always loaded (patch is on
 > top of yours):

I think this makes sense to do now as a stop-gap, but one day,
I hope we can get to a situation where we do modprobe of such
things based on a config file instead of always doing it. 

Dave

-- 
http://www.codemonkey.org.uk

___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list


Re: de-modularising for the win!

2008-10-03 Thread Kyle McMartin
On Fri, Oct 03, 2008 at 01:06:57PM -0400, Peter Jones wrote:
> -rwxr--r-- 1 root root  25K 2008-09-23 21:38 dm-mirror.ko
> -rwxr--r-- 1 root root  25K 2008-09-23 21:38 dm-snapshot.ko
> -rwxr--r-- 1 root root 7.0K 2008-09-23 21:38 dm-zero.ko
>
> 57kB or so max.  But at the same time, these are loaded on nearly every  
> Fedora system, and loaded as modules they're taking up at least 64kB .
>

Groovy. Didn't mean it specifically for this case, but just in general
it would be good to see the size increase we're going to be looking at.

regards, Kyle

___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list


Re: de-modularising for the win!

2008-10-03 Thread Peter Jones

Kyle McMartin wrote:

On Fri, Oct 03, 2008 at 11:25:49AM -0400, Peter Jones wrote:

Bill Nottingham wrote:

See various and sundry plumber's conf discussions.

Comments? (The netfilter stuff needs further investigation.)

Also, please add these, since they're nearly always loaded (patch is on
top of yours):

diff --git a/config-generic b/config-generic
index 0f43c42..de33831 100644
--- a/config-generic
+++ b/config-generic
@@ -640,14 +640,14 @@ CONFIG_BLK_DEV_DM=y
 CONFIG_DM_CRYPT=m
 CONFIG_DM_DEBUG=y
 # CONFIG_DM_DELAY is not set
-CONFIG_DM_MIRROR=m
+CONFIG_DM_MIRROR=y
 CONFIG_DM_MULTIPATH=m
 CONFIG_DM_MULTIPATH_EMC=m
 CONFIG_DM_MULTIPATH_HP=m
 CONFIG_DM_MULTIPATH_RDAC=m
-CONFIG_DM_SNAPSHOT=m
+CONFIG_DM_SNAPSHOT=y
 CONFIG_DM_UEVENT=y
-CONFIG_DM_ZERO=m
+CONFIG_DM_ZERO=y



Not that I object to this or anything of the sort, but it would be nice
if when people were asking for things to be built-in, to see the size
difference on vmlinux on a Fedora build with it enabled.


Well, I haven't done a build (on a slow laptop right now) but these 
modules don't have anything funny going wrt compiling differently when 
modular.  So that means:


-rwxr--r-- 1 root root  25K 2008-09-23 21:38 dm-mirror.ko
-rwxr--r-- 1 root root  25K 2008-09-23 21:38 dm-snapshot.ko
-rwxr--r-- 1 root root 7.0K 2008-09-23 21:38 dm-zero.ko

57kB or so max.  But at the same time, these are loaded on nearly every 
Fedora system, and loaded as modules they're taking up at least 64kB .


--
  Peter

___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list


Re: de-modularising for the win!

2008-10-03 Thread Kyle McMartin
On Fri, Oct 03, 2008 at 11:25:49AM -0400, Peter Jones wrote:
> Bill Nottingham wrote:
>> See various and sundry plumber's conf discussions.
>>
>> Comments? (The netfilter stuff needs further investigation.)
>
> Also, please add these, since they're nearly always loaded (patch is on
> top of yours):
>
> diff --git a/config-generic b/config-generic
> index 0f43c42..de33831 100644
> --- a/config-generic
> +++ b/config-generic
> @@ -640,14 +640,14 @@ CONFIG_BLK_DEV_DM=y
>  CONFIG_DM_CRYPT=m
>  CONFIG_DM_DEBUG=y
>  # CONFIG_DM_DELAY is not set
> -CONFIG_DM_MIRROR=m
> +CONFIG_DM_MIRROR=y
>  CONFIG_DM_MULTIPATH=m
>  CONFIG_DM_MULTIPATH_EMC=m
>  CONFIG_DM_MULTIPATH_HP=m
>  CONFIG_DM_MULTIPATH_RDAC=m
> -CONFIG_DM_SNAPSHOT=m
> +CONFIG_DM_SNAPSHOT=y
>  CONFIG_DM_UEVENT=y
> -CONFIG_DM_ZERO=m
> +CONFIG_DM_ZERO=y
>

Not that I object to this or anything of the sort, but it would be nice
if when people were asking for things to be built-in, to see the size
difference on vmlinux on a Fedora build with it enabled.

regards, Kyle

___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list


Re: de-modularising for the win!

2008-10-03 Thread Peter Jones

Bill Nottingham wrote:

See various and sundry plumber's conf discussions.

Comments? (The netfilter stuff needs further investigation.)


Also, please add these, since they're nearly always loaded (patch is on
top of yours):

diff --git a/config-generic b/config-generic
index 0f43c42..de33831 100644
--- a/config-generic
+++ b/config-generic
@@ -640,14 +640,14 @@ CONFIG_BLK_DEV_DM=y
 CONFIG_DM_CRYPT=m
 CONFIG_DM_DEBUG=y
 # CONFIG_DM_DELAY is not set
-CONFIG_DM_MIRROR=m
+CONFIG_DM_MIRROR=y
 CONFIG_DM_MULTIPATH=m
 CONFIG_DM_MULTIPATH_EMC=m
 CONFIG_DM_MULTIPATH_HP=m
 CONFIG_DM_MULTIPATH_RDAC=m
-CONFIG_DM_SNAPSHOT=m
+CONFIG_DM_SNAPSHOT=y
 CONFIG_DM_UEVENT=y
-CONFIG_DM_ZERO=m
+CONFIG_DM_ZERO=y

 #
 # Fusion MPT device support

___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list