Re: pre-release kernel release tag
Le jeudi 09 août 2007 à 14:24 -0700, Roland McGrath a écrit : Also, it's just better because it accurately reflects the topology of change. A spec release is a variant of a kernel snapshot, not vice versa. Good version ordering is more important than topology Snapshot names are not always ordered, Fedora shiped non-Linus kernels in the past (-ac...), etc -- Nicolas Mailhot signature.asc Description: Ceci est une partie de message numériquement signée ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
pre-release kernel release tag
I propose we change the release format for snapshot kernels.
Now we get e.g.:
kernel-2.6.23-0.89.rc2.git2.fc8
and I suggest instead:
kernel-2.6.23-0.rc2.git2.89.fc8
That is, put the spec file version number last, not first. This way, when
we forget to reset fedora_cvs_origin after a rebase, we don't have to wait
for the next kernel version to do it, just the next gitN.
We can't make this change until 2.6.23 sails, since for rpm version
comparison rc* is any [0-9].
--- kernel.spec 09 Aug 2007 13:45:09 -0700 1.72
+++ kernel.spec 09 Aug 2007 13:46:42 -0700
@@ -126,7 +126,7 @@ Summary: The Linux kernel (the core of t
%define rctag .rc0
%endif
%endif
-%define pkg_release 0.%{fedora_build}%{?rctag}%{?gittag}%{?buildid}%{?dist}
+%define pkg_release 0%{?rctag}%{?gittag}.%{fedora_build}%{?buildid}%{?dist}
%endif
# The kernel tarball/base version
___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: pre-release kernel release tag
On Thu, 2007-08-09 at 13:59 -0700, Roland McGrath wrote:
I propose we change the release format for snapshot kernels.
Now we get e.g.:
kernel-2.6.23-0.89.rc2.git2.fc8
and I suggest instead:
kernel-2.6.23-0.rc2.git2.89.fc8
That is, put the spec file version number last, not first. This way, when
we forget to reset fedora_cvs_origin after a rebase, we don't have to wait
for the next kernel version to do it, just the next gitN.
We can't make this change until 2.6.23 sails, since for rpm version
comparison rc* is any [0-9].
Please don't do this. The kernel package is finally compliant with the
Fedora Packaging Guidelines and this change would break it again.
The reason we prefix with the 0.# is to prevent versioning comparison
madness.
If you need to do a fast rebuild, append a .# after the %{?dist}.
~spot
___
Fedora-kernel-list mailing list
Fedora-kernel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: pre-release kernel release tag
On Thu, Aug 09, 2007 at 01:59:49PM -0700, Roland McGrath wrote: I propose we change the release format for snapshot kernels. Now we get e.g.: kernel-2.6.23-0.89.rc2.git2.fc8 and I suggest instead: kernel-2.6.23-0.rc2.git2.89.fc8 That is, put the spec file version number last, not first. This way, when we forget to reset fedora_cvs_origin after a rebase, we don't have to wait for the next kernel version to do it, just the next gitN. Is it that big a deal? I intended to only reset the origin after each point release, so it doesn't really buy us anything being able to change this with every -git. Dave -- http://www.codemonkey.org.uk ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: pre-release kernel release tag
On Thu, 2007-08-09 at 13:59 -0700, Roland McGrath wrote: I propose we change the release format for snapshot kernels. Now we get e.g.: kernel-2.6.23-0.89.rc2.git2.fc8 and I suggest instead: kernel-2.6.23-0.rc2.git2.89.fc8 That is, put the spec file version number last, not first. This way, when we forget to reset fedora_cvs_origin after a rebase, we don't have to wait for the next kernel version to do it, just the next gitN. We can't make this change until 2.6.23 sails, since for rpm version comparison rc* is any [0-9]. Please don't do this. The kernel package is finally compliant with the Fedora Packaging Guidelines and this change would break it again. The reason we prefix with the 0.# is to prevent versioning comparison madness. What? I didn't propose removing the 0. prefix. What is the problem? ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: pre-release kernel release tag
On Thu, Aug 09, 2007 at 01:59:49PM -0700, Roland McGrath wrote: I propose we change the release format for snapshot kernels. Now we get e.g.: kernel-2.6.23-0.89.rc2.git2.fc8 and I suggest instead: kernel-2.6.23-0.rc2.git2.89.fc8 That is, put the spec file version number last, not first. This way, when we forget to reset fedora_cvs_origin after a rebase, we don't have to wait for the next kernel version to do it, just the next gitN. Is it that big a deal? I intended to only reset the origin after each point release, so it doesn't really buy us anything being able to change this with every -git. It's not a big deal, it's only numbers. The motivation was that it didn't get reset when we went from 2.6.22 to 2.6.23, and after one build hits rawhide, it's too late. Also, it's just better because it accurately reflects the topology of change. A spec release is a variant of a kernel snapshot, not vice versa. ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
Re: pre-release kernel release tag
On Thu, Aug 09, 2007 at 02:24:44PM -0700, Roland McGrath wrote: On Thu, Aug 09, 2007 at 01:59:49PM -0700, Roland McGrath wrote: I propose we change the release format for snapshot kernels. Now we get e.g.: kernel-2.6.23-0.89.rc2.git2.fc8 and I suggest instead: kernel-2.6.23-0.rc2.git2.89.fc8 That is, put the spec file version number last, not first. This way, when we forget to reset fedora_cvs_origin after a rebase, we don't have to wait for the next kernel version to do it, just the next gitN. Is it that big a deal? I intended to only reset the origin after each point release, so it doesn't really buy us anything being able to change this with every -git. It's not a big deal, it's only numbers. The motivation was that it didn't get reset when we went from 2.6.22 to 2.6.23, and after one build hits rawhide, it's too late. For rawhide, I don't think it really matters too much. Dave -- http://www.codemonkey.org.uk ___ Fedora-kernel-list mailing list Fedora-kernel-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-kernel-list
