[Bug 193224] Review Request: streamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: streamer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193224 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 04:52 EST --- Ok i have updated Source tarball. I don't have 64 bit machine but from warning messages i changed code and now updated files are at Spec URL: http://people.redhat.com/pnemade/streamer/streamer.spec SRPM URL: http://people.redhat.com/pnemade/streamer/streamer-1.1.4-1.fc5.src.rpm can you again review this new package for x86_64 arch? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197353] Review Request: man-pages-fr - French man pages from the Linux Documentation Project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: man-pages-fr - French man pages from the Linux Documentation Project https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197353 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 05:11 EST --- Spec URL: http://linuxelectronique.free.fr/download/fedora/5/SPECS/man-pages-fr.spec SRPM URL: http://linuxelectronique.free.fr/download/fedora/5/SRPMS/man-pages-fr-2.16.0-1.src.rpm %changelog * Thu Jul 13 2006 Alain Portal aportal AT univ-montp2 DOT fr 2.16.0-1 - Update to 2.16.0 - New extra tarball -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193531] Review Request: kicad - Electronic schematic diagrams and printed circuit board artwork
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kicad - Electronic schematic diagrams and printed circuit board artwork https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193531 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 172869] Review Request: nss-mdns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nss-mdns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172869 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 06:30 EST --- (In reply to comment #8) One of the requirements to get this included from Ulrich was that lookups are never done directly by the nss-mdns plugin, and only through avahi where it would be cached. Lennart fixed this properly in nss-mdns 0.8 Pancrazio `Ezio' de Mauro [EMAIL PROTECTED] also wrote a Perl script that will be more solid than the previous scriptlets to add and remove the mdnsminimal and mdns lines from /etc/nsswitch.conf http://files.hadess.net/redhat/perso/spec/nss-mdns.spec and http://files.hadess.net/redhat/perso/source/nss-mdns-0.8-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197936] Review Request: nas: Network Audio System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nas: Network Audio System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197936 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190045] Review Request: caps - A set of audio plugins for LADSPA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: caps - A set of audio plugins for LADSPA https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190045 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 06:50 EST --- Without running any special script on the rpm, three orphaned directories can be spotted due to missing ownership or missing dependencies: /usr/lib/ladspa/ /usr/share/ladspa/ /usr/share/ladspa/rdf/ $ rpm -qpR /home/qa/tmp/rpm/RPMS/caps-0.3.0-2.i386.rpm | grep lad $ rpmls -p /home/misc5/tmp/rpm/RPMS/caps-0.3.0-2.i386.rpm -rwxr-xr-x /usr/lib/ladspa/caps.so drwxr-xr-x /usr/share/doc/caps-0.3.0 -rw-r--r-- /usr/share/doc/caps-0.3.0/CHANGES -rw-r--r-- /usr/share/doc/caps-0.3.0/COPYING -rw-r--r-- /usr/share/doc/caps-0.3.0/README -rw-r--r-- /usr/share/doc/caps-0.3.0/README.ardour -rw-r--r-- /usr/share/doc/caps-0.3.0/README.dist -rw-r--r-- /usr/share/doc/caps-0.3.0/caps-0.3.0.pdf -rw-r--r-- /usr/share/doc/caps-0.3.0/caps.html -rw-r--r-- /usr/share/ladspa/rdf/caps.rdf -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198758] New: Review Request: gnome-phone-manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198758 Summary: Review Request: gnome-phone-manager Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.df.lth.se/~triad/krad/fc/gnome-phone-manager.spec SRPM URL: http://www.df.lth.se/~triad/krad/fc/gnome-phone-manager-0.7-1.src.rpm Description: gnome-phone-manager is a mobile phone manager for GNOME. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 172869] Review Request: nss-mdns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nss-mdns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172869 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||191931 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 172869] Review Request: nss-mdns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nss-mdns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172869 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|191931 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 08:04 EST --- Some links on the previous conversation: https://www.redhat.com/archives/fedora-devel-list/2005-November/msg00805.html https://www.redhat.com/archives/fedora-devel-list/2005-December/msg00249.html -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 172869] Review Request: nss-mdns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nss-mdns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172869 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||191931 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 08:05 EST --- Readding Chris' blocker -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 172869] Review Request: nss-mdns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nss-mdns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172869 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 08:23 EST --- The original discussion on GMane, easier to follow. http://article.gmane.org/gmane.linux.redhat.fedora.devel/30633 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196401] Review Request: mozldap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozldap Alias: mozldap https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196401 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 10:13 EST --- I don't have sponsor status, but can do the review and then kick someone who does have sponsor status when the package is approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196393] Review Request: svrcore-devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: svrcore-devel Alias: svrcore-devel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196393 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 10:14 EST --- I don't have sponsor status, but can do the 'official' review and then kick someone who does have sponsor status when the package is approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 186919] Review Request: eric: Python IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eric: Python IDE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186919 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 10:28 EST --- Thanks for the tips, Jason. Spec Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/eric-3.9.0-3.spec SRPM Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/eric-3.9.0-3.src.rpm %changelog * Wed Jul 12 2006 Rex Dieter rexdieter[AT]users.sf.net 3.9.0-3 - %%ghost .pyo files -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191200] Review Request: lvm2-cluster
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lvm2-cluster https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191200 [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |NEW Keywords||Reopened Resolution|RAWHIDE | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196393] Review Request: svrcore-devel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: svrcore-devel
Alias: svrcore-devel
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196393
--- Additional Comments From [EMAIL PROTECTED] 2006-07-13 11:41 EST ---
Okay, first pass through, spec is NOT yet okay. :)
1) Per http://fedoraproject.org/wiki/Extras/FullExceptionList, gawk, perl and
sed shouldn't be in BuildRequires:, not sure why Parag had issues there, package
builds okay in an FC6/x86_64 mock buildroot with them removed.
2) Provides: svrcore-devel is not necessary, its already named that and will
auto-provide it. (rpmlint says E: svrcore-devel useless-explicit-provides
svrcore-devel)
3) You can make the spec cleaner using 'export VAR=value' all on one line.
4) The '%{__mkdir_p} $RPM_BUILD_ROOT/%{_libdir}/pkgconfig' line should not be
under %build, it should be in %install (rpmlint complains about this: W:
svrcore-devel rpm-buildroot-usage %build %{__mkdir_p}
$RPM_BUILD_ROOT%{_libdir}/pkgconfig)
5) The first line in %install should be an rm -rf of the buildroot (rpmlint: E:
svrcore-devel no-cleaning-of-buildroot).
6) You have extraneous slashes throughout the spec. (ex:
$RPM_BUILD_ROOT/%{_libdir} should be just $RPM_BUILD_ROOT%{_libdir}, because
%{_libdir} expands out to /usr/lib or /usr/lib64).
7) Source includes a LICENSE and README file, they should be installed as docs
(rpmlint warns about lack of docs).
8) %defattr should generally be (-,root,root,-)
Here's a spec diff that cleans up all of the above issues:
--
--- svrcore-devel-orig.spec 2006-06-26 11:18:43.0 -0400
+++ svrcore-devel.spec 2006-07-13 11:45:08.0 -0400
@@ -13,11 +13,7 @@
BuildRoot:%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)
BuildRequires:nspr-devel = %{nspr_version}
BuildRequires:nss-devel = %{nss_version}
-BuildRequires:gawk
-BuildRequires:perl
-BuildRequires:sed
BuildRequires:pkgconfig
-Provides: svrcore-devel
Source0:
ftp://ftp.mozilla.org/pub/mozilla.org/directory/svrcore/releases/4.0.2/%{name}-%{version}.tar.gz
@@ -33,28 +29,19 @@
%build
# Enable compiler optimizations and disable debugging code
-BUILD_OPT=1
-export BUILD_OPT
+export BUILD_OPT=1
# Generate symbolic info for debuggers
-XCFLAGS=$RPM_OPT_FLAGS
-export XCFLAGS
+export XCFLAGS=$RPM_OPT_FLAGS
-PKG_CONFIG_ALLOW_SYSTEM_LIBS=1
-PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1
+export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1
+export PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1
-export PKG_CONFIG_ALLOW_SYSTEM_LIBS
-export PKG_CONFIG_ALLOW_SYSTEM_CFLAGS
-
-NSPR_INCLUDE_DIR=`/usr/bin/pkg-config --variable=includedir nspr`
-export NSPR_INCLUDE_DIR
-
-NSS_INCLUDE_DIR=`/usr/bin/pkg-config --variable=includedir nss`
-export NSS_INCLUDE_DIR
+export NSPR_INCLUDE_DIR=`/usr/bin/pkg-config --variable=includedir nspr`
+export NSS_INCLUDE_DIR=`/usr/bin/pkg-config --variable=includedir nss`
%ifarch x86_64 ppc64 ia64 s390x
-USE_64=1
-export USE_64
+export USE_64=1
%endif
cd mozilla/security/svrcore
@@ -63,35 +50,36 @@
# dependencies, etc.
make EXPORTS= RELEASE= REQUIRES= MODULE= IMPORTS= OBJDIR=.
INSTALL=true
+%install
+%{__rm} -rf $RPM_BUILD_ROOT
+
# Set up our package file
-%{__mkdir_p} $RPM_BUILD_ROOT/%{_libdir}/pkgconfig
-%{__cat} svrcore.pc.in | sed -e s,%%libdir%%,%{_libdir},g \
+%{__mkdir_p} $RPM_BUILD_ROOT%{_libdir}/pkgconfig
+%{__cat} mozilla/security/svrcore/svrcore.pc.in | sed -e
s,%%libdir%%,%{_libdir},g \
-e s,%%prefix%%,%{_prefix},g \
-e s,%%exec_prefix%%,%{_prefix},g \
-e s,%%includedir%%,%{_includedir},g \
-e s,%%NSPR_VERSION%%,%{nspr_version},g \
-e s,%%NSS_VERSION%%,%{nss_version},g \
-e s,%%SVRCORE_VERSION%%,%{version},g \
- $RPM_BUILD_ROOT/%{_libdir}/pkgconfig/%{name}.pc
-
-%install
+ $RPM_BUILD_ROOT%{_libdir}/pkgconfig/%{name}.pc
# There is no make install target so we'll do it ourselves.
-%{__mkdir_p} $RPM_BUILD_ROOT/%{_includedir}
-%{__mkdir_p} $RPM_BUILD_ROOT/%{_libdir}
+%{__mkdir_p} $RPM_BUILD_ROOT%{_includedir}
+%{__mkdir_p} $RPM_BUILD_ROOT%{_libdir}
cd mozilla/security/svrcore
# Copy the binary libraries we want
for file in libsvrcore.a
do
- %{__install} -m 644 $file $RPM_BUILD_ROOT/%{_libdir}
+ %{__install} -m 644 $file $RPM_BUILD_ROOT%{_libdir}
done
# Copy the include files
for file in svrcore.h
do
- %{__install} -m 644 $file $RPM_BUILD_ROOT/%{_includedir}
+ %{__install} -m 644 $file $RPM_BUILD_ROOT%{_includedir}
done
@@ -99,7 +87,8 @@
%{__rm} -rf $RPM_BUILD_ROOT
%files
-%defattr(0644,root,root)
+%defattr(-,root,root,-)
+%doc mozilla/security/svrcore/LICENSE mozilla/security/svrcore/README
%{_libdir}/pkgconfig/%{name}.pc
%{_libdir}/libsvrcore.a
[Bug 191200] Review Request: lvm2-cluster
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lvm2-cluster https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191200 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO_REPORTER OtherBugsDependingO|188268 |188267 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 11:42 EST --- Please address Paul's comments and make the latest spec file viewable so this review can continue. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194276] Review Request: kdeaccessibility: KDE accessibility tools
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kdeaccessibility: KDE accessibility tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194276
--- Additional Comments From [EMAIL PROTECTED] 2006-07-13 11:46 EST ---
from /usr/share/applications/kde/ :
I saw that the DocPath of these
ksnapshot.desktop
amarok.desktop
kdevelop.desktop
krdc.desktop
are not prefixed by X-
So, I am ignoring these errors.
MUST Items:
- MUST: rpmlint's output is clean
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the base package %{name}
- MUST: The package meets the Packaging Guidelines.
- MUST: The package is licensed (GPL) with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines.
- MUST: The License field in the package spec file matches the actual license.
- MUST: the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package is
included in %doc.
- MUST: The spec file must be written in American English.
- MUST: The spec file for the package is be legible.
- MUST: The package successfully compiles and builds into binary rpms on at
least i386.
- MUST: All build dependencies is listed in BuildRequires.
- MUST: The spec file handles locales properly.
- MUST: If the package does not contain shared library files located in the
dynamic linker's default paths
- MUST: the package is not designed to be relocatable
- MUST: the package owns all directories that it creates.
- MUST: the package does not contain any duplicate files in the %files listing.
- MUST: Permissions on files are set properly.
- MUST: The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
- MUST: The package consistently uses macros, as described in the macros section
of Packaging Guidelines.
- MUST: The package contains code, or permissable content. This is described in
detail in the code vs. content section of Packaging Guidelines.
- MUST: There are no Large documentation files
- MUST: %doc does not affect the runtime of the application. To summarize: If it
is in %doc, the program must run properly if it is not present.
- MUST: There are no Header files or static libraries
- MUST: The package does not contain library files with a suffix
- MUST: Package does NOT contain any .la libtool archives
- MUST: Package containing GUI applications includes a %{name}.desktop file, and
that file must be properly installed with desktop-file-install in the %install
section.
- MUST: Package does not own files or directories already owned by other
packages.
SHOULD Items:
- SHOULD: The source package does include license text(s) as COPYING
- SHOULD: mock builds succcessfully in i386.
- SHOULD: The reviewer tested that the package functions as described. A
package should not segfault instead of running, for example.
- SHOULD: No scriptlets were used, those scriptlets must be sane.
- SHOULD: No subpackages present.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194276] Review Request: kdeaccessibility: KDE accessibility tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdeaccessibility: KDE accessibility tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194276 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196393] Review Request: svrcore-devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: svrcore-devel Alias: svrcore-devel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196393 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 11:47 EST --- Thanks. I'll get working on it. One question though, about export var=value - I thought that was a ksh/bash-ism, not a plain old posix bourne shell feature? I'd rather have the scripting parts be maximally portable. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191200] Review Request: lvm2-cluster
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lvm2-cluster https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191200 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 12:09 EST --- *** Bug 198679 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196393] Review Request: svrcore-devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: svrcore-devel Alias: svrcore-devel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196393 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 14:36 EST --- (In reply to comment #9) One question though, about export var=value - I thought that was a ksh/bash-ism, not a plain old posix bourne shell feature? I'd rather have the scripting parts be maximally portable. True, it won't work on plain old bourne, but there's no plain old bourne on anything we ship or support anymore so I'm not sure what target platform you have in mind that it would be an issue on. Not a blocker though if you want to keep them split, I just like to keep things as short as possible. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196393] Review Request: svrcore-devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: svrcore-devel Alias: svrcore-devel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196393 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 14:42 EST --- Er, actually, I'm not certain what we have on RHEL3 (or RHEL2.1, but I dunno if that's a platform we want people running the DS stuff on)... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193156] Review Request: devallocator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: devallocator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193156 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED])| --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 15:42 EST --- Updated to latest upstream version, but I think we are going to pull this from Extras and just build it for RHEL5. Since it really is not for general use on non MLS Machines. Spec URL: ftp://people.redhat.com/dwalsh/SELinux/devallocator.spec SRPM URL: ftp://people.redhat.com/dwalsh/SELinux/devallocator-0.5.7-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193156] Review Request: devallocator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: devallocator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193156 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198691] Review Request: steghide - A Steganography Program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: steghide - A Steganography Program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198691 [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |NEW Keywords||Reopened Resolution|NOTABUG | --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 15:48 EST --- Bug appears to have been closed by mistake -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192311] Review Request: cobbler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cobbler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 15:49 EST --- Added kickstart templating support in cobbler using Cheetah. Kickstart templating works for PXE, Xen, and auto-kickstart re-provisioning alike. http://et.redhat.com/~mdehaan/software/cobbler/cobbler-0.1.1-3.src.rpm http://et.redhat.com/~mdehaan/software/cobbler/cobbler.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192313] Review Request: koan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: koan https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192313 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 15:50 EST --- Koan has been updated to take advantage of cobbler's new templating features. http://et.redhat.com/~mdehaan/software/cobbler/koan-0.1.1-3.noarch.rpm http://et.redhat.com/~mdehaan/software/cobbler/koan.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196629] Review Request: perl-SVK - A Distributed Version Control System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-SVK - A Distributed Version Control System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196629 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 16:09 EST --- Built for FC-4, FC-5, and devel. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197739] Review Request: perl-DateTime-Event-Recurrence
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-DateTime-Event-Recurrence https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197739 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 16:33 EST --- Imported into CVS, branches created, and builds requested. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197744] Review Request: perl-DateTime-Event-ICal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-DateTime-Event-ICal https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197744 Bug 197744 depends on bug 197739, which changed state. Bug 197739 Summary: Review Request: perl-DateTime-Event-Recurrence https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197739 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197744] Review Request: perl-DateTime-Event-ICal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-DateTime-Event-ICal https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197744 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 16:35 EST --- Imported into CVS, branches created, and builds requested. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197745] Review Request: perl-DateTime-Format-ICal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-DateTime-Format-ICal https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197745 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 16:36 EST --- Imported into CVS, branches created, and builds requested. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192577] Review Request: perl-OpenFrame
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-OpenFrame https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192577 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 16:38 EST --- Imported into CVS, branches created, and builds requested. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196401] Review Request: mozldap
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mozldap
Alias: mozldap
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196401
--- Additional Comments From [EMAIL PROTECTED] 2006-07-13 16:55 EST ---
Initial feedback on first pass through the spec and some rpmlint'ing:
1) Should add %dist tag
2) Source0: should be a URL, if not, explain why
3) Remove useless Provides:
4) Requires: on sub-packages should be explicit %{name} = %{version}-%{release}
instead of =
5) Use %configure instead of ./configure
6) Should quote around $RPM_OPT_FLAGS, I've seen issues if not done
7) %install is missing buildroot cleaning
8) don't create directories/files in the buildroot in %build, needs to be done
in %install (since the first thing in %install is supposed to be a buildroot
purging).
9) extraneous slashes in some path names (ex: $RPM_BUILD_ROOT/%{_libdir})
10) standard practice in Fedora is to symlink back to the actual .so rather than
create a trail of symlinks
11) preferred ldconfig post/postun format is %post -p /sbin/ldconfig
12) %defattr should be (-,root,root,-)
13) lots of extra, unnecessary %dir lines in various %files sections
14) unversioned .so files must go in -devel package when there are also
versioned .so's
15) rpmlint complains about invalid sonames, I presume this is a side-effect of
renaming them:
E: mozldap invalid-soname /usr/lib64/libssldap-5.0.so.5.17 libssldap50.so
E: mozldap invalid-soname /usr/lib64/libprldap-5.0.so.5.17 libprldap50.so
E: mozldap invalid-soname /usr/lib64/libldap-5.0.so.5.17 libldap50.so
16) the binaries all define rpaths, which is a big no-no
The following spec diff should address all but 15 and 16:
--
--- mozldap-orig.spec 2006-07-13 15:58:24.0 -0400
+++ mozldap.spec2006-07-13 16:50:58.0 -0400
@@ -10,7 +10,7 @@
Summary: Mozilla LDAP C SDK
Name: mozldap
Version: %{major}.%{minor}
-Release: 3
+Release: 3%{?dist}
License: MPL/GPL/LGPL
URL: http://www.mozilla.org/directory/csdk.html
Group:System Environment/Libraries
@@ -20,8 +20,8 @@
BuildRequires:%{nspr_name}-devel = %{nspr_version}
BuildRequires:%{nss_name}-devel = %{nss_version}
BuildRequires:%{svrcore_name} = %{svrcore_version}
-Provides: mozldap
+# Only available from cvs, tag LDAPCSDK_5_1_7_RTM
Source0: %{name}-%{version}.tar.gz
%description
@@ -35,11 +35,10 @@
%package tools
Summary: Tools for the Mozilla LDAP C SDK
Group:System Environment/Base
-Requires: %{name} = %{version}-%{release}
+Requires: %{name} = %{version}-%{release}
BuildRequires:%{nspr_name}-devel = %{nspr_version}
BuildRequires:%{nss_name}-devel = %{nss_version}
BuildRequires:%{svrcore_name} = %{svrcore_version}
-Provides: %{name}-tools
%description tools
The mozldap-tools package provides the ldapsearch,
@@ -50,10 +49,9 @@
%package devel
Summary: Development libraries and examples for Mozilla LDAP C SDK
Group:Development/Libraries
-Requires: %{name} = %{version}-%{release}
+Requires: %{name} = %{version}-%{release}
Requires: %{nspr_name}-devel = %{nspr_version}
Requires: %{nss_name}-devel = %{nss_version}
-Provides: %{name}-devel
%description devel
Header and Library files for doing development with the Mozilla LDAP C SDK
@@ -64,7 +62,8 @@
arg64=--enable-64bit
%endif
cd mozilla/directory/c-sdk
-./configure $arg64 --with-system-svrcore --enable-optimize --disable-debug
+%configure $arg64 --with-system-svrcore --enable-optimize --disable-debug
+#./configure $arg64 --with-system-svrcore --enable-optimize --disable-debug
%build
@@ -73,7 +72,7 @@
export BUILD_OPT
# Generate symbolic info for debuggers
-XCFLAGS=$RPM_OPT_FLAGS
+XCFLAGS=$RPM_OPT_FLAGS
export XCFLAGS
PKG_CONFIG_ALLOW_SYSTEM_LIBS=1
@@ -90,9 +89,12 @@
cd mozilla/directory/c-sdk
make BUILDCLU=1 HAVE_SVRCORE=1 BUILD_OPT=1
+%install
+%{__rm} -rf $RPM_BUILD_ROOT
+
# Set up our package file
-%{__mkdir_p} $RPM_BUILD_ROOT/%{_libdir}/pkgconfig
-%{__cat} %{name}.pc.in | sed -e s,%%libdir%%,%{_libdir},g \
+%{__mkdir_p} $RPM_BUILD_ROOT%{_libdir}/pkgconfig
+%{__cat} mozilla/directory/c-sdk/%{name}.pc.in | sed -e
s,%%libdir%%,%{_libdir},g \
-e s,%%prefix%%,%{_prefix},g \
-e s,%%exec_prefix%%,%{_prefix},g \
-e s,%%includedir%%,%{_includedir}/%{name},g \
@@ -100,69 +102,63 @@
-e s,%%NSS_VERSION%%,%{nss_version},g \
-e s,%%SVRCORE_VERSION%%,%{svrcore_version},g \
-e s,%%MOZLDAP_VERSION%%,%{version},g \
- $RPM_BUILD_ROOT/%{_libdir}/pkgconfig/%{name}.pc
-
-%install
+
[Bug 196401] Review Request: mozldap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozldap Alias: mozldap https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196401 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 16:58 EST --- Forgot to add 14b: add %doc mozilla/directory/c-sdk/README.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198827] New: Review Request: perl-Statistics-Descriptive - Perl module of basic descriptive statistical functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198827 Summary: Review Request: perl-Statistics-Descriptive - Perl module of basic descriptive statistical functions Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-Statistics-Descriptive.spec SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-Statistics-Descriptive-2.6-1.src.rpm Description: This module provides basic functions used in descriptive statistics. It has an object oriented design and supports two different types of data storage and calculation objects: sparse and full. With the sparse method, none of the data is stored and only a few statistical measures are available. Using the full method, the entire data set is retained and additional functions are available. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198829] New: Review Request: wfmath - WorldForge math libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198829 Summary: Review Request: wfmath - WorldForge math libraries Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.kobold.org/~wart/fedora/wfmath.spec SRPM URL: http://www.kobold.org/~wart/fedora/wfmath-0.3.4-1.src.rpm Description: WFMath provides mathematical functions for WorldForge clients. The primary focus of WFMath is geometric objects. Thus, it includes several shapes (boxes, balls, lines), in addition to the basic math objects that are used to build these shapes (points, vectors, matricies). WFMath provides a means for other system compenents to pass geometric information around in a common format. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198831] New: Review Request: varconf - Configuration library used by WorldForge apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198831 Summary: Review Request: varconf - Configuration library used by WorldForge apps Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.kobold.org/~wart/fedora/varconf.spec SRPM URL: http://www.kobold.org/~wart/fedora/varconf-0.6.4-1.src.rpm Description: Varconf is a configuration library intended for all applications. It manages configuration data in files, command line arguments, and is used by most WorldForge components. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198832] New: Review Request: skstream - C++ I/O library for WorldForge apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198832 Summary: Review Request: skstream - C++ I/O library for WorldForge apps Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.kobold.org/~wart/fedora/skstream.spec SRPM URL: http://www.kobold.org/~wart/fedora/skstream-0.3.5-1.src.rpm Description: skstream is an isotream C++ socket library and is recommended for use as a transport for Atlas-C++. It is capable of creating iostream-based socket connections for both clients and servers. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198833] New: Review Request: mercator - Terrain library for WorldForge client/server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198833 Summary: Review Request: mercator - Terrain library for WorldForge client/server Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.kobold.org/~wart/fedora/mercator.spec SRPM URL: http://www.kobold.org/~wart/fedora/mercator-0.2.4-1.src.rpm Description: Mercator is primarily aimed at terrain for multiplayer online games and forms one of the WorldForge core libraries. It is intended to be used as a terrain library on the client, while a subset of features are useful on the server. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198829] Review Request: wfmath - WorldForge math libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wfmath - WorldForge math libraries https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198829 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198833 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198834] New: Review Request: sage - OpenGL extensions library using SDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198834 Summary: Review Request: sage - OpenGL extensions library using SDL Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.kobold.org/~wart/fedora/sage.spec SRPM URL: http://www.kobold.org/~wart/fedora/sage-0.1.2-1.src.rpm Description: Sage is an OpenGL extensions library using SDL. It aims to simplify the use of checking for and loading OpenGL extensions in an application. This library is used by some WorldForge clients. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198835] New: Review Request: Atlas-C++ - WorldForge message protocol library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835 Summary: Review Request: Atlas-C++ - WorldForge message protocol library Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.kobold.org/~wart/fedora/Atlas-C++.spec SRPM URL: http://www.kobold.org/~wart/fedora/Atlas-C++-0.6.0-1.src.rpm Description: Atlas-C++ is the perhaps the most important library in the entire WorldForge project, since nearly every other module requires it. Atlas-C++ provides a native implementation of the entire Atlas specification including negotiation, message encode and decode and the overlying Objects layer. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198836] New: Review Request: freetype1 compatibility FreeType 1.x
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198836 Summary: Review Request: freetype1 compatibility FreeType 1.x Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.cs.toronto.edu/~behdad/fedora/freetype1/freetype1.spec SRPM URL: http://www.cs.toronto.edu/~behdad/fedora/freetype1/freetype1-1.4-0.1.pre.src.rpm Description: I removed FreeType 1.x stuff from the freetype package in core. That happened when going from freetype-2.1.10 to freetype-2.2.1. A few Extras packages depend on FreeType 1.x, hence this package. %description The FreeType engine is a free and portable TrueType font rendering engine, developed to provide TrueType support for a variety of platforms and environments. FreeType is a library which can open and manages font files as well as efficiently load, hint and render individual glyphs. FreeType is not a font server or a complete text-rendering library. The version 1.x of FreeType is obsolete. New applications should use the more advanced FreeType 2.x library packaged as freetype. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198837] New: Review Request: eris - Client-side session layer for Atlas-C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198837 Summary: Review Request: eris - Client-side session layer for Atlas-C++ Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.kobold.org/~wart/fedora/eris.spec SRPM URL: http://www.kobold.org/~wart/fedora/eris-1.3.11-1.src.rpm Description: A client side session layer for WorldForge; Eris manages much of the generic work required to communicate with an Atlas server. Client developers can extend Eris in a number of ways to rapidly add game and client specific functions, and quickly tie game objects to whatever outpu representation they are using. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Atlas-C++ - WorldForge message protocol library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198837 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198832] Review Request: skstream - C++ I/O library for WorldForge apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: skstream - C++ I/O library for WorldForge apps https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198832 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198837 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198829] Review Request: wfmath - WorldForge math libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wfmath - WorldForge math libraries https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198829 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198837 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198839] New: Review Request: sear - WorldForge client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198839 Summary: Review Request: sear - WorldForge client Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: fedora-package-review@redhat.com Spec URL: http://www.kobold.org/~wart/fedora/sear.spec SRPM URL: http://www.kobold.org/~wart/fedora/sear-0.6.2-1.src.rpm Description: Sear is a 3D client for the WorldForge roleplaying environment. WorldForge can be viewed as a MMORPG construction kit, providing a working 3D environment in which quests and full games can be built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198833] Review Request: mercator - Terrain library for WorldForge client/server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mercator - Terrain library for WorldForge client/server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198833 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198839 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198830] Review Request: libmodelfile - library for accessing WorldForge model files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libmodelfile - library for accessing WorldForge model files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198830 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198839 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198837] Review Request: eris - Client-side session layer for Atlas-C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eris - Client-side session layer for Atlas-C++ https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198837 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198839 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198831] Review Request: varconf - Configuration library used by WorldForge apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: varconf - Configuration library used by WorldForge apps https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198831 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198839 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198834] Review Request: sage - OpenGL extensions library using SDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sage - OpenGL extensions library using SDL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198834 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||198839 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196146] Review Request: mod_nss
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mod_nss
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196146
--- Additional Comments From [EMAIL PROTECTED] 2006-07-13 19:15 EST ---
Based on my initial tour through the spec and rpmlint'ing:
1) Source: should be a URL if possible:
http://directory.fedora.redhat.com/sources/%{name}-%{version}.tar.gz
2) BuildRequires: for make and perl should both be removed, per
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions
3) Please explain why AutoReq: 0 is necessary
4) Quotes around $RPM_OPT_FLAGS are recommended
5) Use %configure instead of ./configure
6) Should be smp_mflags instead of smp_flags
7) I believe DESTDIR is only relevant for make install (rpmlint complains).
8) Use macros for things like /etc (%{_sysconfdir}), /usr/sbin (%{_sbindir}),
etc.
9) Watch out for lib/lib64 issues, you have a hard-coded /usr/lib in there,
*must* be %{_libdir} so that its properly set to /usr/lib64 on 64-bit platforms.
10) don't use install -s, let rpm do the stripping so we get a valid debuginfo
package.
11) don't create directories in %post, create them in the package, or they
aren't owned by the package, which violates FE packaging policy
12) the %ifarch stuff around copying libnssckbi.so should be removed, this is
another case where %{_libdir} is your friend. However, copying a file into place
in %post is also a no-no. Just duplicate it within the package if you absolutely
must, otherwise the file isn't owned by the package.
13) Oy. Just realized the file being copied in %post is from another package.
That's also a no-no. I think a relative symlink (while still ugly) is okay
though, and at least it would be owned by the package.
14) secmod.db (and cert8.db, key3.db) can be created in the build and marked
%config(noreplace) instead of creating unowned files in %post. Note that this
does add a BuildRequires: on nss-tools though. Of course, it also means the
buildhost name winds up in the file instead of the target host. This one may
need some more thought... I suppose doing it the way you have it may be best,
given that mod_ssl does essentially the same. Ah! Just had an idea... I think
creating dummy files in the buildroot and including them in the package itself
and then creating actual files in %post may be the sanest thing.
15) Need to add to %files some to account for the above (and switch to using
macros)
Okay, all of the above are addressed (I believe) by the following spec diff,
including the tweak to let mod_nss own the .db files:
--
--- mod_nss-orig.spec 2006-07-13 17:38:26.0 -0400
+++ mod_nss.spec2006-07-13 19:12:45.0 -0400
@@ -1,13 +1,12 @@
Name: mod_nss
Version: 1.0.3
-Release: 1
+Release: 1%{?dist}
Summary: SSL/TLS module for the Apache HTTP server
Group: System Environment/Daemons
License: Apache Software License
URL: http://directory.fedora.redhat.com/wiki/Mod_nss
-Source: %{name}-%{version}.tar.gz
+Source: http://directory.fedora.redhat.com/sources/%{name}-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildRequires: make, perl
BuildRequires: nspr-devel = 4.6, nss-devel = 3.11
BuildRequires: httpd-devel = 0:2.0.52, apr-devel, apr-util-devel
Requires: httpd = 0:2.0.52
@@ -36,7 +35,7 @@
# regenerate configure scripts
autoconf || exit 1
-CFLAGS=$RPM_OPT_FLAGS
+CFLAGS=$RPM_OPT_FLAGS
export CFLAGS
NSPR_INCLUDE_DIR=`/usr/bin/pkg-config --variable=includedir nspr`
@@ -47,24 +46,35 @@
NSS_BIN=`/usr/bin/pkg-config --variable=exec_prefix nss`
-./configure --with-nss-lib=$NSS_LIB_DIR --with-nss-inc=$NSS_INCLUDE_DIR
--with-nspr-lib=$NSPR_LIB_DIR --with-nspr-inc=$NSPR_INCLUDE_DIR
--with-apr-config --enable-ecc
+%configure \
+--with-nss-lib=$NSS_LIB_DIR \
+--with-nss-inc=$NSS_INCLUDE_DIR \
+--with-nspr-lib=$NSPR_LIB_DIR \
+--with-nspr-inc=$NSPR_INCLUDE_DIR \
+--with-apr-config --enable-ecc
+#./configure --with-nss-lib=$NSS_LIB_DIR --with-nss-inc=$NSS_INCLUDE_DIR
--with-nspr-lib=$NSPR_LIB_DIR --with-nspr-inc=$NSPR_INCLUDE_DIR
--with-apr-config --enable-ecc
make %{?_smp_flags} DESTDIR=$RPM_BUILD_ROOT all
%install
rm -rf $RPM_BUILD_ROOT
-mkdir -p $RPM_BUILD_ROOT/etc/httpd/conf
-mkdir -p $RPM_BUILD_ROOT/etc/httpd/conf.d
-mkdir -p $RPM_BUILD_ROOT/usr/lib/httpd/modules
-mkdir -p $RPM_BUILD_ROOT/usr/sbin
-
-install -m 644 nss.conf $RPM_BUILD_ROOT/etc/httpd/conf.d
-install -s -m 755 .libs/libmodnss.so $RPM_BUILD_ROOT/usr/lib/httpd/modules
-install -s -m 755 nss_pcache $RPM_BUILD_ROOT/usr/sbin
-install -m 755 gencert $RPM_BUILD_ROOT/usr/sbin
+mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/httpd/conf
+mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/httpd/conf.d
+mkdir -p $RPM_BUILD_ROOT%{_libdir}/httpd/modules
+mkdir -p $RPM_BUILD_ROOT%{_sbindir}
+mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/httpd/alias
+
+install -m 644 nss.conf
[Bug 195412] Review Request: obconf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: obconf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195412 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189322] Review Request: rosegarden4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rosegarden4 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189322 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189322] Review Request: rosegarden4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rosegarden4 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189322 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn|183912, 189892 | OtherBugsDependingO|163776 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 19:38 EST --- Ok, I'm in fedorabugs. This package is ACCEPTED! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189892] Review Request: dssi - Disposable Soft Synth Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dssi - Disposable Soft Synth Interface https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189892 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|189322 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 183912] Review Request: jack-audio-connection-kit - The Jack Audio Connection Kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jack-audio-connection-kit - The Jack Audio Connection Kit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183912 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|189322 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193894] Review Request: ant-contrib - A collection of tasks for Ant
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ant-contrib - A collection of tasks for Ant https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193894 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 19:54 EST --- (In reply to comment #6) Sorry for not responding for long, New files: http://people.redhat.com/ifoox/extras/ant-contrib.spec http://people.redhat.com/ifoox/extras/ant-contrib-1.0-0.1.b2.src.rpm Is this file corrupt? I get the following why I try to install.. error: unpacking of archive failed on file /usr/src/redhat/SOURCES/ant-contrib-1.0b2-src.tar.gz;44b6deeb: cpio: read -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 176697] Review Request: i386-rtems4.7-binutils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: i386-rtems4.7-binutils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176697 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 19:59 EST --- I was thinking of contributing a cross toolchain for me treo. Rather than fill Extras with independent GNU ports, does it make sense to collaborate on a cross-(binutils|gcc|etc) SRPM that builds various binary toolchains from the single set of sources? I think that would be nice. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198836] Review Request: freetype1 compatibility FreeType 1.x
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freetype1 compatibility FreeType 1.x https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198836 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 20:04 EST --- Where does freetype-1.4pre come from? The latest I can find is 1.3.1: http://sourceforge.net/project/showfiles.php?group_id=3157package_id=3068 I guess we would know how/where to find it, if you used a full URL in the Source: field. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198836] Review Request: freetype1 compatibility FreeType 1.x
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: freetype1 compatibility FreeType 1.x
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198836
--- Additional Comments From [EMAIL PROTECTED] 2006-07-13 20:06 EST ---
And you should omit static libs (%_libdir/lib*.a) and %{_libdir}/lib*.la files.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198829] Review Request: wfmath - WorldForge math libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wfmath - WorldForge math libraries Alias: wfmath https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198829 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Alias||wfmath -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198829] Review Request: wfmath - WorldForge math libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: wfmath - WorldForge math libraries
Alias: wfmath
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198829
--- Additional Comments From [EMAIL PROTECTED] 2006-07-13 21:36 EST ---
- rpmlint output clean
- package named according to package naming guidelines
- spec filename matches base package %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license in spec file matches actual license
- license contained in %doc
- spec file written in American english
- spec file legible
- sources match upstream
6a14f7de9d467d7b72b37da5ca5f92c5 wfmath-0.3.4.tar.gz
- package successfully compiles and builds on x86_64 FC-5
- All BuildRequires listed
- no locales
- ldconfig called in %post/%postun
- package is not relocatable
- package owns all directories it creates
- package contains no duplicate files
- file permissions set properly
- contains proper %clean section
- macro usage is consistant
- package contains permissible content
- no large documentation
- %doc does not affect runtime of application
- header files are in devel package
- pkgconfig .pc file in devel
- .so files w/o suffix in devel
- devel package requires base package
- package does not contain .la files
- not a GUI app needing a .desktop file
- package does not own files or directories owned by other packages
MUST
- Add Requires: pkgconfg to devel package
- package does not contain a %check section
- make check fails on 1 test, investigate why (FAIL: intstring_test)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Atlas-C++ - WorldForge message protocol library Alias: Atlas-C++ https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Alias||Atlas-C++ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Atlas-C++ - WorldForge message protocol library Alias: Atlas-C++ https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 22:19 EST --- -rpmlint output: W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZNK5Atlas9Exception4whatEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZTIN5Atlas9ExceptionE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZTVN5Atlas9ExceptionE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase11streamBeginEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase13streamMessageEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase9streamEndEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase10mapMapItemERKSs W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase11mapListItemERKSs W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase10mapIntItemERKSsl W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase12mapFloatItemERKSsd W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase13mapStringItemERKSsS3_ W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase6mapEndEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase11listMapItemEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase12listListItemEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase11listIntItemEl W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase13listFloatItemEd W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase14listStringItemERKSs W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBase7listEndEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZTIN5Atlas7Message11DecoderBaseE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBaseC2Ev W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message7ElementC1ERKS1_ W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message11DecoderBaseD2Ev W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message7Element5clearENS1_4TypeE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message7Encoder14mapElementItemERKSsRKNS0_7ElementE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message7EncoderD1Ev W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message7ElementaSERKS1_ W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas6Codecs3XMLC1ERSdRNS_6BridgeE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas7Message7EncoderC1ERNS_6BridgeE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 _ZN5Atlas9ExceptionD2Ev W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0 _ZTIN5Atlas9ExceptionE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0 _ZNK5Atlas9Exception4whatEv W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0 _ZTIN5Atlas6BridgeE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0 _ZTVN5Atlas9ExceptionE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0 _ZN5Atlas6BridgeD2Ev W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0 _ZN5Atlas9ExceptionD2Ev W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0 _ZTIN5Atlas9NegotiateE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0 _ZTIN5Atlas6BridgeE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0 _ZN5Atlas9NegotiateD2Ev W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0 _ZN5Atlas6Codecs6PackedC1ERSdRNS_6BridgeE W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0 _ZN5Atlas6Codecs4BachC1ERSdRNS_6BridgeE
[Bug 198832] Review Request: skstream - C++ I/O library for WorldForge apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: skstream - C++ I/O library for WorldForge apps Alias: skstream https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198832 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Alias||skstream -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198829] Review Request: wfmath - WorldForge math libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wfmath - WorldForge math libraries Alias: wfmath https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198829 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Atlas-C++ - WorldForge message protocol library Alias: Atlas-C++ https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195412] Review Request: obconf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: obconf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195412 --- Additional Comments From [EMAIL PROTECTED] 2006-07-13 22:24 EST --- Built for Devel. Once it's been branched to FC-4 and FC-5, I'll build for those and close this as NEXTRELEASE. Jorge: I have contacted the author about it. Thanks for your review. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198832] Review Request: skstream - C++ I/O library for WorldForge apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: skstream - C++ I/O library for WorldForge apps Alias: skstream https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198832 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198832] Review Request: skstream - C++ I/O library for WorldForge apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: skstream - C++ I/O library for WorldForge apps
Alias: skstream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198832
--- Additional Comments From [EMAIL PROTECTED] 2006-07-13 22:56 EST ---
- rpmlint output:
W: skstream-devel no-documentation
okay to ignore, I don't see any documentation which should go in devel
- package is named according to package naming guidelines
- spec filename matches package %{name}
- package meets package naming guidelines
- package licensed with open source compatible license
- license field matches actual license
- license included in %doc
- spec file written in American english
- spec file is legible
- sources match upstream
0c5ec89551bc0900b2e708992f321794 skstream-0.3.5.tar.gz
- package successfully compiles and builds on x86_64 FC-5
- All build dependencies listed in BuildRequires, optional dependencies not
listed (zlib)
- package does not contain locales
- ldconfig properly called in %post/%postun
- package is not relocatable
- package owns all directories it creates
- package does not contain any duplicate files
- permissions on files is set properly
- package contains proper %clean section
- macro usage is consistant
- package contains permissible content
- package does not contain large documentation
- files in %doc do not affect runtime
- header files are contained in devel package
- pkgconfig files are in devel package
- library files w/o suffix are in devel
- devel package requires base package
- package does not contain .la files
- package does not own files or directories owned by other packages
MUST
- Add Requires: pkgconfig to devel package
- Explain why this is not compiled with optional zlib library
- contact upstream about make docs error
NOTES
- make check has some failures, but these are okay, they require the echo
service to be enabled or be run as root. I enabled echo on my system and ran
make check as root and these tests pass.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198837] Review Request: eris - Client-side session layer for Atlas-C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eris - Client-side session layer for Atlas-C++ Alias: eris https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198837 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| Alias||eris -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193897] Review Request: mysql-connector-java - Official JDBC driver for MySQL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mysql-connector-java - Official JDBC driver for MySQL
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193897
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-07-13 23:32 EST ---
Some initial feedback
rpmlint output is:
W: mysql-connector-java non-standard-group Development/Libraries/Java
We just use Development/Libraries in Fedora. Perhaps there's an argument to be
made for Development/Libraries/Java, but let's use the standard for now. I'll
send a note to fedora-devel
W: mysql-connector-java wrong-file-end-of-line-encoding
/usr/share/doc/mysql-connector-java-3.1.12/docs/README.txt
W: mysql-connector-java wrong-file-end-of-line-encoding
/usr/share/doc/mysql-connector-java-3.1.12/README.txt
W: mysql-connector-java wrong-file-end-of-line-encoding
/usr/share/doc/mysql-connector-java-3.1.12/EXCEPTIONS-CONNECTOR-J
Fix these with sed in the %prep section like so:
%{__sed} -i 's/\r//' README.txt
The spec file includes:
# remove all binary libs
find . \( -name *.jar -o -name *.class \) | xargs -t rm -f
I would rather that we strip the .jar files from the tarball prior to packaging.
This will ensure that we don't accidentally ship binaries sans sources or
binaries with unfriendly licensing - even if they only show up in the SRPM.
Can you explain this part of the spec file?..
Provides: mm.mysql
Obsoletes: mm.mysql
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: FluidSynth - Real-time software synthesizer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886
--- Additional Comments From [EMAIL PROTECTED] 2006-07-14 00:09 EST ---
(In reply to comment #3)
0 rpmlint output is:
E: fluidsynth obsolete-not-provided iiwusynth
E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
Fixed.
0 License (LGPL) ok, but license file not included!
Fixed.
0 no %doc
Fixed.
0 .la files packaged, bad!
Fixed.
* Alphanumeric parts of the version should be in the Release field, as per:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines
Then you can drop the -n fluidsynth-1.0.7 to %setup too
Fixed.
* Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora
package use %package libs same goes for the devel package.
Fixed.
* The following rpmlint output:
E: fluidsynth obsolete-not-provided iiwusynth
E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
* Don't package .la files, remove them under %install or %exclude them in
%files
* Add a %doc including atleast COPYING, but mosty likely also other candidates
Fixed, as above.
Thanks for your effort. Sorry for the delay.
Updates bits here:
Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7-5.a.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198830] Review Request: libmodelfile - library for accessing WorldForge model files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libmodelfile - library for accessing WorldForge model files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198830 --- Additional Comments From [EMAIL PROTECTED] 2006-07-14 00:18 EST --- Some comments: *-devel is missing Requires: pkgconfig But ... I am having a problem with this package's licence. You spec says GPL, the tarball contains a copy of the GPL's COPYING, but the sources say: * Permission is granted to anyone to use this software for any purpose, * including commercial applications, and to alter it and redistribute it * freely, subject to the following restrictions: * * 1. The origin of this software must not be misrepresented; you must not *claim that you wrote the original software. If you use this software *in a product, an acknowledgment in the product documentation would be *appreciated but is not required. * 2. Altered source versions must be plainly marked as such, and must not be *misrepresented as being the original software. * 3. This notice may not be removed or altered from any source distribution. In my understanding, §1 and §3 are non critical, but §2 could be read a imposing additional constraits, i.e. as violation of the GPL, which would render shipping this package under the GPL impossible. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198837] Review Request: eris - Client-side session layer for Atlas-C++
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: eris - Client-side session layer for Atlas-C++
Alias: eris
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198837
--- Additional Comments From [EMAIL PROTECTED] 2006-07-14 01:23 EST ---
- rpmlint output:
W: eris incoherent-version-in-changelog 1.3.11-0.1 1.3.11-1.fc5
Must fix changelog version number
- package name meets package naming guidelines
- spec file name matches package %{name}
- package meets packaging guidelines
- package is licensed with open source compatible license
- license matches actual upstream license
- license file included in %doc
- spec file written in American english
- spec file is legible
- source file matches upstream
632bb5ad0e8cbcf59c8f26c50c320b7d eris-1.3.11.tar.gz
- package successfully compiles and builds on x86_64 FC-5
O package does not list all build dependencies, configure checks for glib-2.0
which is not provided
- package does not contain locales
- package contains proper %post/%postun ldconfig calls
- package is not relocatable
- package owns all directories it creates
- package does not contain duplicate files
- file permissions are set properly
- package contains proper %clean section
- macro usage is consistent
- package contains permissible content
- package does not contain large documentation
- files in %doc do not affect runtime
- header files are in devel package
- pkgconfig files are in devel
- libraries w/o suffix are in devel
- devel package requires base package
- package does not contain any .la files
- package is not a GUI needing a .desktop file
- package does not own files or directories owned by other packages
MUST
- Remove pkgconfig from BuildRequries, this should be picked up by the devel
packages
- Fix changelog version number
- outpu in description should be output
- Why is glib-2.0 not added in BuildRequires?
- Add a %check section
- %doc in devel should be docs/html/*
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198830] Review Request: libmodelfile - library for accessing WorldForge model files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libmodelfile - library for accessing WorldForge model files Alias: libmodelfile https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198830 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| Alias||libmodelfile -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
