[Bug 202006] Review Request: fmio - FM radio card manipulation utility

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fmio - FM radio card manipulation utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202006





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 03:13 EST ---
I've fixed python issue.

Updated file here:
ftp://andriy.asplinux.com.ua/pub/people/andy/extras/fmio-2.0.8-4.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 188974] Review Request: libGLw

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libGLw


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188974





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 03:35 EST ---
If we do item 1 (name it mesa-libGLw) then is should have a virtual provides
libGLw-devel, just like mesa-libGL-devel provides libGL-devel, etc.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: gcin -  |Review Request: gcin -
   |Chinese input method server |Chinese input method for
   |for Traditional Chinese |Traditional Chinese
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 03:56 EST ---
Thanks for all your work on this.  I just tested it on my x86_64
and it seems to work ok (though I'm not very familiar with TC).

A couple of comments:

Is the -devel subpackage really necessary?  Are there any extensions to gcin
that would use the include file it contains?

Probably it would be clearer to rename the xinput file from gcin to
xinput-gcin say.

I will attach a patch for the spec file to improve it further.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 04:03 EST ---
Created an attachment (id=134501)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134501&action=view)
gcin.spec-3.patch

More necessary improvements.

- don't use configure macro
- add .conf suffix to xinput.d file and update install scripts for fc6
- move lib to libdir and drop ld.so.conf.d file
- other minor cleanup

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 04:35 EST ---
[I forgot to thanks all the earlier reviewers for their work on this too.:)]

Also you buildrequire desktop-file-utils but don't use it I think.
You probably should to install the .desktop file with it or else remove it 
entirely.
See .

Once all these things are fixed I think the package can be accepted.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 04:40 EST ---
Note the changes I made in %post/%preun are only for fc6.
Since like you had is needed for fc5 and earlier btw.
It is hope to you how you want to handle that: either using
%{fedora} and different .spec files on branches say.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 05:19 EST ---
Petersen, thanks for your spec patch
These days I have read all http://fedoraproject.org/wiki/Packaging/* documents.
I merge your spec patch and create a new version, and mock build cleanly for 
fc6 and fc5.

The New files:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 06:46 EST ---
Thanks.

What do you think about removing the -devel package?

You still need to install the desktop file in %install:
check some other spec files for examples, and then you can 
restore the desktop-file-utils buildrequires.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 06:47 EST ---
Created an attachment (id=134505)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134505&action=view)
gcin-5.patch

a few more fixes

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 07:10 EST ---
I had email to the upstream author and ask him about the header file is 
necessary?
I am waiting for his reply.
If the header file is not necessay, then the -devel package can be removed.
About desktop file:
"make install" already install "%{_datadir}/applications/gcin-setup.desktop"
What should I do?
Remove gcin-setup.desktop and then use "desktop-file-install" in %install?
Another question, should I use gcin.desktop rather than gcin-setup.desktop?
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 192049] Review Request: gnash - GNU Flash player

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnash - GNU Flash player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192049





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 07:30 EST ---
Browsing to sites with flash 9 causes my X session/server to restart on my
x86_64 running rawhide.  I'm not sure if it's because of flash 9 but it happens
on sites like gap.com & myspace.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 196281] Review Request: php-manual-en - English language PHP manual

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-manual-en - English language PHP manual
Alias: php-manual-en

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196281


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 07:32 EST ---
Imported & built - job #14355. Thanks for all the input!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 188974] Review Request: libGLw

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libGLw


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188974





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 08:55 EST ---
Hans' suggestion makes sense:
6.  after 1, main pkg SHOULD 
Provides: libGLw 
and -devel SHOULD 
Provides: libGLw-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 09:20 EST ---
I fixed with the gcin-5.patch and use desktop-file-install in %install (ref. 
from scim's spec file) 

The New files:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 13:12 EST ---
Jens, while it's great that you're reviewing this (as I don't really have the
expertise to review it properly) the fact remains that because this is a
FE-NEEDSPONSOR ticket, and according to the current rules for contributorship
the review must be done by a sponsor.  This does sort of put us in a bit of a
quandary, however, as there might not be an available sponsor.  Might you be
willing to co-maintain this package?  (Assuming of course that Chang would 
agree.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 196177] Review Request: kdmtheme - Theme Manager for KDM

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdmtheme - Theme Manager for KDM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196177


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]|
   |au) |




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 14:54 EST ---
Updated:
SRPM: http://chitlesh.funpic.de/rpm/kdmtheme-1.1.2-2.src.rpm
SPEC: http://chitlesh.funpic.de/rpm/kdmtheme.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 196003] Review Request: Kmenu-gnome

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Kmenu-gnome


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196003


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]|
   |au) |




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 14:55 EST ---
I'm back :)

Updated:
SRPM: http://chitlesh.funpic.de/rpm/kmenu-gnome-0.6-3.src.rpm
SPEC: http://chitlesh.funpic.de/rpm/kmenu-gnome.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 203249] New: Review Request: kpolynome

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203249

   Summary: Review Request: kpolynome
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://chitlesh.funpic.de/rpm/kpolynome.spec
SRPM URL: http://chitlesh.funpic.de/rpm/kpolynome-0.1.2-1.src.rpm
Description: KPolynome is a program to calculate mathematical polynomes based 
on given data coordinates.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 200630] Review Request: postgresql_autodoc - PostgreSQL AutoDoc Utility

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql_autodoc - PostgreSQL AutoDoc Utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200630


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 15:54 EST ---
MD5Sums:
ef45084bb065b11def33ef7885ee694b  postgresql_autodoc-1.25-3.src.rpm
f61071a23f6b34f948bbf799de91e8e4  postgresql_autodoc-1.25.tar.gz
72f9c48a19b9a0d2999f1274e0e4398d  postgresql_autodoc.spec

Blockers:
* Package installs to %{_datadir}/pgsql but it neither owns the directory nor
  depends on anything which requires it.  This may be a bug in the postgresql
  packaging.  Care to ask Tom Lane if the postgresql package rather than
  postgresql-server should own %{_datadir}/pgsql?  I don't know the purpose of
  the directories well enough to judge.
* Package does not own %{_datadir}/pgsql/postgresql_autodoc

Cosmetic:
* Perl packages typically have virtual provides detailing what perl
  dependencies they are providing.  The prefered way to Require perl modules
  is through this virtual provide method.  So instead of
BuildRequires: perl-HTML-Template
BuildRequires: perl-Pg-DBD
  you want to have:
BuildRequire: perl(DBD::Pg)
BuildRequires: perl(HTML::Template)
* Using %{?dist} in the release makes upgrades across Fedora Core releases
  work more or less seamlessly.  Consider adding %{?dist} to the end of your
  Release: tag.
* The package does not come with a detached license file.  You should ask
  upstream to include one next time they release a tarball.  (Since the license
  is included as part of the source code and this is a script so it is in the
  installed package, this is not a blocker.  But it is convenient for end-users
  to have this.)
* When manually installing files in the spec file you should try to preserve
  the file timestamps.  This can be done with cp -p in your

Questions:
* If I'm reading the source correctly, this package will only work with
  postgresql, not other db's that use the perl DBI interface.  But the
  Requires picked up by rpm do not include perl(DBD::Pg).  Should there
  be a Requires: perl(DBD:Pg) in the spec?
* Running the program just errors for me.  Any clues?
$ postgresql_autodoc  -d orchard --password='X'
Can't call method "finish" on an undefined value at
/usr/bin/postgresql_autodoc line 1203.
* It appears that the only method for providing a password to use when
  connecting to the database is via the commandline.  This is insecure as it
  allows another user to see the password with something as simple as the
  "ps" command.  It would be a very good idea to ask upstream for other methods
  of sending the password: prompt, config file, etc.

Good:
* Source matches upstream
* Package follows naming guidelines. (The _ comes from the upstream project).
* spec file name matches the package name.
* The license is original BSD and matches in SOURCE and spec file.
* The spec file is readable.
* No locales so %find_lang is not present.
* Not a library package.
* Not relocatable.
* Does not contain duplicate files.
* Package has a proper %clean section.
* Code, not content.
* Macros are used consistently.
* No %doc affects the application runtime.
* Not a GUI application.
* Does not own directories or files owned by someone else.
* No scriptlets.
* Builds in mock.
* Permissions are okay.

Notes:
* rpmlint outputs:
$ rpmlint postgresql_autodoc-1.25-3.*
W: postgresql_autodoc no-documentation
  Which is ignorable because the package doesn't provide any documentation
  at this time.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 203249] Review Request: kpolynome

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpolynome


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203249


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: kpolynome   |Review Request: kpolynome




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 15:58 EST ---
Quick, not-official review:

 * mock build fails. You have to add autoconf and automake BRs.
 * rpmlint gives a lot of output:
E: kpolynome script-without-shellbang /usr/share/doc/kpolynome-0.1.2/AUTHORS
W: kpolynome dangling-symlink /usr/share/doc/HTML/en/kpolynome/common /usr/
share/doc/HTML/en/common
W: kpolynome symlink-should-be-relative /usr/share/doc/HTML/en/kpolynome/common 
/usr/share/doc/HTML/en/common
E: kpolynome zero-length /usr/share/doc/kpolynome-0.1.2/README
E: kpolynome script-without-shellbang /usr/share/doc/kpolynome-0.1.2/NEWS
W: kpolynome dangling-symlink /usr/share/doc/HTML/hu/kpolynome/common /usr/
share/doc/HTML/hu/common
W: kpolynome symlink-should-be-relative /usr/share/doc/HTML/hu/kpolynome/common 
/usr/share/doc/HTML/hu/common
E: kpolynome script-without-shellbang /usr/share/doc/kpolynome-0.1.2/COPYING
E: kpolynome script-without-shellbang /usr/share/doc/kpolynome-0.1.2/ChangeLog

You should change doc files permissions in %%prep section and probably remove
README file.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 202032] Review Request: efont-unicode-bdf: Unicode font by Electronic Font Open Laboratory

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efont-unicode-bdf: Unicode font by Electronic Font 
Open Laboratory


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202032


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 16:04 EST ---
Okay, with that fix, it's good to go. I can't spot anything which breaks any of
the guidelines.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 203249] Review Request: kpolynome

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kpolynome


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203249





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 16:13 EST ---
I forgot to look into %%files section in your spec file. There is a few things
you have to correct. Your package doesn't own directories that it creates.
For example, RPM creates %{_datadir}/apps/%{name} directory, but during
uninstall, it won't be deleted. Why? Because it is refering to file 
(%{name}ui.rc), not directory. Idem with HTML-doc files. You have to refer
to whole directory, not to particular files. So, your %%files section should
look like:
%{_datadir}/apps/%{name}
%{_docdir}/HTML/en/%{name}
etc.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 200630] Review Request: postgresql_autodoc - PostgreSQL AutoDoc Utility

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql_autodoc - PostgreSQL AutoDoc Utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200630





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 16:25 EST ---
Hello,

> Blockers:
> * Package installs to %{_datadir}/pgsql but it neither owns the directory nor
>   depends on anything which requires it.  This may be a bug in the postgresql
>   packaging.  Care to ask Tom Lane if the postgresql package rather than
>   postgresql-server should own %{_datadir}/pgsql?  I don't know the purpose of
>   the directories well enough to judge.

After thinking a bit, I realized that it is my bad: I've changed the dependency.

> * Package does not own %{_datadir}/pgsql/postgresql_autodoc

Fixed.

> Cosmetic:
> * Perl packages typically have virtual provides detailing what perl
>   dependencies they are providing.  The prefered way to Require perl modules
>   is through this virtual provide method.  So instead of
> BuildRequires: perl-HTML-Template
> BuildRequires: perl-Pg-DBD
>   you want to have:
> BuildRequire: perl(DBD::Pg)
> BuildRequires: perl(HTML::Template)

Fixed.

> * Using %{?dist} in the release makes upgrades across Fedora Core releases
>   work more or less seamlessly.  Consider adding %{?dist} to the end of your
>   Release: tag.

Fixed.

> * The package does not come with a detached license file.  You should ask
>   upstream to include one next time they release a tarball.  (Since the 
> license
>   is included as part of the source code and this is a script so it is in the
>   installed package, this is not a blocker.  But it is convenient for
> end-users to have this.)

Ok, let's keep it for the future.

> * When manually installing files in the spec file you should try to preserve
>   the file timestamps.  This can be done with cp -p in your

Done.

> Questions:
> * If I'm reading the source correctly, this package will only work with
>   postgresql, not other db's that use the perl DBI interface.  But the
>   Requires picked up by rpm do not include perl(DBD::Pg).  Should there
>   be a Requires: perl(DBD:Pg) in the spec?

Yeah, fixed.

> * Running the program just errors for me.  Any clues?
> $ postgresql_autodoc  -d orchard --password='X'
> Can't call method "finish" on an undefined value at
> /usr/bin/postgresql_autodoc line 1203.

Works for me:

# postgresql_autodoc -d test -u postgres --password test  -l
/usr/share/pgsql/postgresql_autodoc/
(in cleanup) dbd_st_destroy called twice! at /usr/bin/postgresql_autodoc
line 199.
DBI handle 0x9bad4c4 has uncleared implementors data at
/usr/bin/postgresql_autodoc line 199.
dbih_clearcom (sth 0x9bad4c4, com 0x9e2ec38, imp DBD::Pg::st):
   FLAGS 0x100113: COMSET IMPSET Warn PrintError PrintWarn
   PARENT DBI::db=HASH(0x9baca20)
   KIDS 0 (0 Active)
   IMP_DATA undef
   NUM_OF_FIELDS -1
   NUM_OF_PARAMS 0
Producing test.dia from /usr/share/pgsql/postgresql_autodoc//dia.tmpl
Producing test.dot from /usr/share/pgsql/postgresql_autodoc//dot.tmpl
Producing test.html from /usr/share/pgsql/postgresql_autodoc//html.tmpl
Producing test.neato from /usr/share/pgsql/postgresql_autodoc//neato.tmpl
Producing test.xml from /usr/share/pgsql/postgresql_autodoc//xml.tmpl
Producing test.zigzag.dia from 
/usr/share/pgsql/postgresql_autodoc//zigzag.dia.tmpl

> * It appears that the only method for providing a password to use when
>   connecting to the database is via the commandline.  This is insecure as it
>   allows another user to see the password with something as simple as the
>   "ps" command.  It would be a very good idea to ask upstream for other 
> methods
>   of sending the password: prompt, config file, etc.

AFAIK it can use environmental variable for the password stuff.

Thanks for the review. The new spec and srpm will be up shortly.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 200630] Review Request: postgresql_autodoc - PostgreSQL AutoDoc Utility

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql_autodoc - PostgreSQL AutoDoc Utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200630





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 16:26 EST ---
Hello.

Spec URL:
http://developer.postgresql.org/~devrim/rpms/other/postgresql_autodoc/postgresql_autodoc.spec
SRPM URL:
http://developer.postgresql.org/~devrim/rpms/other/postgresql_autodoc/postgresql_autodoc-1.25-4.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 200600] Review Request: phpPgAdmin - web based PostgreSQL administration

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: phpPgAdmin - web based PostgreSQL administration


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200600





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 16:33 EST ---
Hello. New spec and SRPM:
Spec URL:
http://developer.postgresql.org/~devrim/rpms/other/phpPgAdmin/phpPgAdmin.spec
SRPM URL:
http://developer.postgresql.org/~devrim/rpms/other/phpPgAdmin/phpPgAdmin-4.0.1-3.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pgpool - Connection pooling/replication server for 
PostgreSQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 16:36 EST ---
New spec:

http://developer.postgresql.org/~devrim/rpms/other/pgpool/pgpool.spec

New SRPM:
http://developer.postgresql.org/~devrim/rpms/other/pgpool/pgpool-3.1.1-3.src.rpm

Regards, Devrim

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201656] Review Request: gstm-1.2

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gstm-1.2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201656


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 18:01 EST ---
Added openssh-clients and repackaged.

SRPM : http://glive.tuxfamily.org/fedora/gstm/gstm-1.2-3.src.rpm
SPEC : http://glive.tuxfamily.org/fedora/gstm/gstm.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 202032] Review Request: efont-unicode-bdf: Unicode font by Electronic Font Open Laboratory

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efont-unicode-bdf: Unicode font by Electronic Font 
Open Laboratory


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202032





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 19:13 EST ---
(In reply to comment #17)
> Okay, with that fix, it's good to go. I can't spot anything which breaks any 
> of
> the guidelines.
> 
> APPROVED

Thank you.
Then I will try to upload this package.
Please check jfbterm, too.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 203265] New: Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265

   Summary: Review Request: nqc - Programming environment for Lego's
RCX (Mindstorms) bricks
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://miskatonic.cs.nmsu.edu/pub/nqc.spec

SRPM URL: 
http://miskatonic.cs.nmsu.edu/pub/fedora/5/srpms/nqc-3.1.4-1.src.rpm

Description:

Not Quite C is a simple language with a C-like syntax that can be used to
program Lego's RCX programmable brick (from the Mindstorms set).

Notes:
This is built on Simon Perreault's work, which is a closed duplicate of this 
bug report.

About the warnings:
I don't know of any other app using the lego group.
The udev/group rules are based on fuse's spec, so if this is wrong at least 
I've got company.   :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 185205] Review Request: nqc

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185205





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 21:07 EST ---
(In reply to comment #8)
> Rick, go ahead and make a new submission for your package.  You can close this
> as a duplicate of the new bug.

Bug #203265 is the new submission. I don't have permissions to close this bug
though; someone else will have to.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 21:09 EST ---
Simon's original submission is here:
 http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185205

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 192049] Review Request: gnash - GNU Flash player

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnash - GNU Flash player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192049





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 22:25 EST ---
(In reply to comment #31)
> Browsing to sites with flash 9 causes my X session/server to restart on my
> x86_64 running rawhide.

This sounds like the problem in comment 26, but I agree this blocks acceptance.
As I noted in comment 29 it seems to be fixed in cvs.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 22:44 EST ---
I agree.
Jens will you like to co-maintain this package?
And Tibbitts can you sponsor this package?

Another information about -devel subpackage, it seems the gcin-im-client.h only 
need for rxvt/mrxvt.
If the rxvt/mrxvt was patched with gcin IM client support, then it is need 
gcin-im-client.h to build rxvt/
mrxvt.
http://www.csie.nctu.edu.tw/~cp76/linux/mrxvt-gcin-0.4.1.tar.bz2 is a mrxvt 
with gcin IM client 
patched
http://www.csie.nctu.edu.tw/~cp76/linux/rxvt-gcin.tbz is a rxvt with gcin IM 
client patched
But both mrxvt-gcin-0.4.1.tar.bz2 and rxvt-gcin.tbz are a little bit 
out-of-date, so I think the -devel 
subpackage is not necessary now.
So now I remove the -devel subpackage.
The New files with no -devel subpackage:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 23:18 EST ---
Created an attachment (id=134521)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134521&action=view)
gcin-7.patch

Fix changelog. ;)

Otherwise looks good to me.  IMHO the package could now be approved,
but unfortunately as Jason pointed out I don't have Sponsor status either...

I don't really feel qualified or motivated to maintain this package
in the long term, but if there is a strong demand to have it in Extras
asap then I suppose I could take it for now.  Though I'd really rather
we try to find a sponsor for Chung-Yen Chang.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 23:30 EST ---
Fix changelog:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-8.src.rpm

Now I still need to find a sponsor for this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 202032] Review Request: efont-unicode-bdf: Unicode font by Electronic Font Open Laboratory

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efont-unicode-bdf: Unicode font by Electronic Font 
Open Laboratory


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202032


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 23:51 EST ---
Okay.

* Build queue for devel requested as id 14365 succeeded.
http://buildsys.fedoraproject.org/logs/fedora-development-extras/14365-efont-unicode-bdf-0.4.2-6.fc6/
* SyncNeeded is requested for FE-5 branch.

Now I close this as CLOSED NEXTRELEASE. Thank you for
reviewing this package!!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201170] Review Request: jfbterm - Japanese Console for Linux Frame Buffer Device

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jfbterm - Japanese Console for Linux Frame Buffer 
Device


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201170


Bug 201170 depends on bug 202032, which changed state.

Bug 202032 Summary: Review Request: efont-unicode-bdf: Unicode font by 
Electronic Font Open Laboratory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202032

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 00:51 EST ---
Chung-Yen Chang, have you done any pre-reviews of any other packages?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 01:02 EST ---
Jens, no, I am new to FE bugzilla.
But I will try to do some pre-reviews of other packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 202439] Review Request: frozen-bubble - Frozen Bubble arcade gam

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: frozen-bubble - Frozen Bubble arcade gam


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202439





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 01:12 EST ---
Created an attachment (id=134522)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134522&action=view)
Move per libs to app directory

This is a patch to the spec file to move the application-specific perl
libraries out of the global perl library tree and into %{_libdir}/%{name}

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 202439] Review Request: frozen-bubble - Frozen Bubble arcade gam

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: frozen-bubble - Frozen Bubble arcade gam


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202439





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 01:43 EST ---
Thanks!

Applied and I've also fixed the inconsistent RPM_BUILD_ROOT usage, new version 
here:
Spec URL: http://people.atrpms.net/~hdegoede/frozen-bubble.spec
SRPM URL: http://people.atrpms.net/~hdegoede/frozen-bubble-1.0.0-8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 202439] Review Request: frozen-bubble - Frozen Bubble arcade gam

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: frozen-bubble - Frozen Bubble arcade gam


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202439


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 02:34 EST ---
All necessary items addressed.  Game still functions as expected.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 179040] Review Request: socat

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: socat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179040





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 02:39 EST ---
Thanks for the information! glad to see it builds with mock now.

I've fixed the documentation execute bits in the example shellscripts. I added a
few more examples that i hadn't noticed were added. New specfile and rpms
available at:

ftp://ftp.xelerance.com/socat/binaries/fedora/4/SRPMS/socat-1.5.0.0-2.src.rpm
ftp://ftp.xelerance.com/socat/binaries/fedora/4/SRPMS/socat.spec

Thanks again!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review