[Bug 167147] Review Request: Aqsis - 3D Rendering system

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Aqsis - 3D Rendering system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 04:41 EST ---
Well, would you provide both spec/srpm of this package
for convenience? Also, each you modify spec/srpm, you must
change (increment) release number because only changing
srpm/spec without release number confuses people who
check it.

Only from I viewed the spec file in comment #25 (I have not
tried to rebuild this, please provide srpm),
* Don't write redundant Requires which are required automatically
  by libraries' dependencies.
* Don't write redundant BuildRequires which are included in
  minimal. Check:
  http://fedoraproject.org/wiki/Extras/FullExceptionList

* Please explain why -devel package should include static 
  archives
  Check Exclusion of Static Libraries of
  http://fedoraproject.org/wiki/Packaging/Guidelines

%{_libdir}/%{name}/*.a


* 

%{_bindir}/mpanalyse.py
%exclude %{_bindir}/mpanalyse.pyo
%exclude %{_bindir}/mpanalyse.pyc

  Would you consider to rename this python script to mpanalyse?
  Generally, putting a script named *.py is regarded to be avioded.
  Unnecessary Byte compilation of
  http://fedoraproject.org/wiki/Packaging/Python

* Requires: %{name} = %{version}
  Why not require release dependency? 
---
- MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
---
  from http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

* %config %{_sysconfdir}/aqsisrc
  Please explain why this is not marked as %config(noreplace).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 167147] Review Request: Aqsis - 3D Rendering system

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Aqsis - 3D Rendering system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 08:00 EST ---
I fixed the release number chaos and uploaded the new spec ans srpm.
http://www.cgtobi.de/aqsis/aqsis.fedora.spec
http://www.cgtobi.de/aqsis/aqsis-1.2.0-0.3.alpha1.src.rpm

I also cleaned up the BuildRequires and Requires and fixed the dependency issue.

  Please explain why -devel package should include static archives
We want to deliver two useful developer libraries, libri2rib, and libslxargs. 
Both rely on libaqsistypes, if 
we deliver them both with libaqsistypes embedded, there will be clashes if 
anyone wants to use both of 
them, which means we'll be delivering a whole load more libraries, and to 
compile a simple program 
that relies on libri2rib would mean linking with libri2rib, and libaqsistypes, 
which is messy.

  Would you consider to rename this python script to mpanalyse?
I could do it, but I'd prefere to leave it a .py because it would be in line 
with other platforms we support 
and it showes the user that it is a python script.

  Please explain why this is not marked as %config(noreplace).
We discussed that and came to the conclusion that it's more important to 
provide a working version 
rather keeping the users modifications. This will definitly change in future 
releases.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 207685] Review Request: gstreamer-plugins-farsight - GStreamer plug-ins for farsight protocol

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gstreamer-plugins-farsight - GStreamer plug-ins for 
farsight protocol


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207685


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 11:36 EST ---
Jef, thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218020] Review Request: postgrey - Postfix Greylisting Policy Server

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgrey - Postfix Greylisting Policy Server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218020





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 11:39 EST ---
Two other minor points that were brought up in the other postgrey review by
Michael Fleming:

1) The preferred BuildRoot tag is
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

I'm sure there are some folks that would be bothered by this.  I'm not, but it
can't hurt to follow the guidelines.

2) The empty postgrey_whitelist_clients.local.  I noticed this in the rpmlint
output and thought it seemed okay to ignore, but perhaps a better solution is to
add a comment to the file instead of just creating an empty file.

echo # Local clients that should not be greylisted.  See postgrey(8). \
 %{buildroot}%{confdir}/postgrey_whitelist_clients.local

A note on this file in README-rpm might also be warranted.

Sorry for not mentioning these things on the first pass.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 167147] Review Request: Aqsis - 3D Rendering system

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Aqsis - 3D Rendering system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 12:40 EST ---
(In reply to comment #27)
   Please explain why -devel package should include static archives
 We want to deliver two useful developer libraries, libri2rib, and libslxargs.
Well, I rebuilt this, however I cannot understand what you want
to do...
Build log says that all files used in these archives are included
in libaqsis.so.1, so including libaqsis.so in -devel package 
should be enough.
And including _static_ archive into _shared_ dynamic library is
wrong because rpmlint complains:

E: aqsis shlib-with-non-pic-code /usr/lib/libaqsis.so.1.2

shlib-with-non-pic-code :
The listed shared libraries contain object code that was compiled
without -fPIC. All object code in shared libraries should be
recompiled separately from the static libraries with the -fPIC option.

.. You should
* compile all files used in libaqsis.so.1.2 with -fPIC. libaqsis.so.1.2
  uses compiled objects in static archives without -fPIC used, which
  is wrong.
* After it is modified so as all files used in libaqsis.so.1.2
  are compiled with -fPIC, providing static archives should not be
  necessary as all files are included in libaqsis.so.1.2.

 Both rely on libaqsistypes, if 
 we deliver them both with libaqsistypes embedded, there will 
 be clashes if anyone wants to use both of 
 them, 
  This should be fixed when libaqsis compilation is fixed.  

   Would you consider to rename this python script to mpanalyse?
 I could do it, but I'd prefere to leave it a .py because 
 it would be in line with other platforms we support 
 and it showes the user that it is a python script.
  IMO that it showes the user that it is a python script is not
  a enough reason. Many (in my environment, almost all) python
  scripts in /usr/bin has a name without .py suffix.
  Generally,
  * Executables used in users directly (which are under normal path)
should not have suffix as possible.
  * If a executable is normally considered to be used from other
executables and not to be used directly by user, the executable
may have a suffix like .py or .sh, however, generally it should
not under normal path and should be under %{_libexecdir}.
(For second one, check Filesystem Layout of
 http://fedoraproject.org/wiki/Packaging/Guidelines).

   IMO, if no special reason exists, the filename should be renamed
   also on other platforms (however, I don't care about them).

==
And.. aqsis related packages make lots of rpmlint complaint.

--
1. E: aqsis shlib-with-non-pic-code /usr/lib/libaqsis.so.1.2
2. W: aqsis conffile-without-noreplace-flag /etc/aqsisrc
3. E: aqsis invalid-spec-name aqsis.fedora.spec
4. W: aqsis rpm-buildroot-usage %build scons %{?_smp_mflags}
destdir=$RPM_BUILD_ROOT \
5. W: aqsis mixed-use-of-spaces-and-tabs (spaces: line 89, tab: line 6)
6. E: aqsis-data summary-too-long Example content for the open source
RenderMan-compliant Aqsis 3D rendering solution
7. W: aqsis-data no-documentation
8. E: aqsis-data non-executable-script
/usr/share/aqsis/content/ribs/features/layeredshaders/render.sh 0644
9. E: aqsis-data non-executable-script
/usr/share/aqsis/content/ribs/scenes/vase/render.sh 0644
10. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/shadercompiler/slparse/scanner.ll
11. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/texturing/plugins/png2tif/png2tif.c
12. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/displays/d_sdcBMP/d_sdcBMP.cpp
13. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/thirdparty/dbo_plane/implicit.h
14. E: aqsis-debuginfo wrong-script-end-of-line-encoding
/usr/src/debug/aqsis-1.2.0/build/thirdparty/dbo_plane/implicit.h
15. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/thirdparty/dbo_plane/dbo_plane.c
16. E: aqsis-debuginfo wrong-script-end-of-line-encoding
/usr/src/debug/aqsis-1.2.0/build/thirdparty/dbo_plane/dbo_plane.c
17. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/aqsistypes/pool.h
18. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/displays/d_exr/dspyhlpr.c
19. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/aqsistypes/noise1234.cpp
20. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/aqsistypes/noise1234.h
21. E: aqsis-debuginfo script-without-shebang
/usr/src/debug/aqsis-1.2.0/build/rib/rib2/scanner.ll

[Bug 167147] Review Request: Aqsis - 3D Rendering system

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Aqsis - 3D Rendering system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 12:45 EST ---
(In reply to comment #28)
 (In reply to comment #27)
 .. You should
 * compile all files used in libaqsis.so.1.2 with -fPIC. libaqsis.so.1.2
   uses compiled objects in static archives without -fPIC used, which
   is wrong.

Or, you should change all static archives to shared dynamic libraries
with -fPIC used correctly, and have libaqsis.so linked against them.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220703] New: Review Request: libgtksourceviewmm - A C++ wrapper for the gtksourceview widget library

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220703

   Summary: Review Request: libgtksourceviewmm - A C++ wrapper for
the gtksourceview widget library
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec 
URL:http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm.spec
SRPM URL: 
http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm-0.2.0-1.src.rpm
Description: libgtksourceviewmm is a C++ wrapper for the gtksourceview widget 
library. It offers all the power of gtksourceview with an interface 
familiar to c++ developers, including users of the gtkmm library

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 207846] Review Request: perl-Finance-YahooQuote - Perl interface to get stock quotes from Yahoo! Finance

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Finance-YahooQuote - Perl interface to get stock 
quotes from Yahoo! Finance
Alias: finance-YahooQuote

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207846


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 13:08 EST ---
Imported and branched on FC5 and FC6.  (mod_perl while problematic was a
non-issue for this.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220703] Review Request: libgtksourceviewmm - A C++ wrapper for the gtksourceview widget library

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgtksourceviewmm - A C++ wrapper for the 
gtksourceview widget library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220703





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 13:37 EST ---
Oops.. Also:
* COPYING must be in main package. I think AUTHORS should also
  be in main package (and also README?)
* ChangeLog, NEWS should be added in -devel package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220704] New: Review Request: perl-GPS - Perl interface to a GPS receiver that implements the Garmin protocol

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220704

   Summary: Review Request: perl-GPS - Perl interface to a GPS
receiver that implements the Garmin protocol
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-GPS.spec

SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-GPS-0.15-1.src.rpm

Description:
This is a perl interface to a GPS receiver that implements the Garmin
protocol.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 186452] Review Request: kdebluetooth: The KDE Bluetooth Framework

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdebluetooth: The KDE Bluetooth Framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186452





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 13:51 EST ---
Some progress here:
http://cachalot.mine.nu/6/SRPMS/kdebluetooth.spec
http://cachalot.mine.nu/6/SRPMS/kdebluetooth-1.0-0.15.beta2.cmn6.src.rpm

I can't get a PIN dialog, nor do I know how that stuff is supposed to work with
bluez 3.x (FC6) which I hear no longer supports pin helpers.  SELinux is
disabled, I suppose kbluepin is never executed, bluez-pin --dbus doesn't seem
to do anything either.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219036] Review Request: perl-Roman - Roman module from CPAN

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Roman - Roman module from CPAN


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219036





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 14:14 EST ---
ping!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220703] Review Request: libgtksourceviewmm - A C++ wrapper for the gtksourceview widget library

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgtksourceviewmm - A C++ wrapper for the 
gtksourceview widget library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220703





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 14:14 EST ---
New Spec file :
http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm.spec
New SRPM file :
http://glive.tuxfamily.org/fedora/libgtksourceviewmm/libgtksourceviewmm-0.2.0-2.src.rpm

- add libdir/gtksourceviewmm-1.0 in devel package
- add Changelog and NEWS in devel package
- add gtkmm24-devel and gtksourceview-devel in devel package

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220706] New: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, man page

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220706

   Summary: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with
wacomcpl tool, man page
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://meverhagen.nl/fc6/linuxwacom.spec
SRPM URL: http://meverhagen.nl/fc6/linuxwacom-devel-0.7.6_3-3.1.i386.rpm
Debug URL: http://meverhagen.nl/fc6/linuxwacom-debuginfo-0.7.6_3-3.1.i386.rpm
RPM URL: http://meverhagen.nl/fc6/linuxwacom-0.7.6_3-3.1.i386.rpm
Description:
This is my first rpm,
it is lunixwacom 0.7.6 wich updates lunixwacom 0.7.4 
It includes the wacomcpl (wacomcpl-exec) tool, wich is used for adjusting the 
pressure of the stylus and the buttons on the drawing tablet.
And a manpage for the xorg.conf editing: man wacom

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220707] New: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, man page

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220707

   Summary: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with
wacomcpl tool, man page
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://meverhagen.nl/fc6/i386/linuxwacom.spec
SRPM URL: http://meverhagen.nl/fc6/i386/linuxwacom-devel-0.7.6_3-3.1.i386.rpm
Debug URL: 
http://meverhagen.nl/fc6/i386/linuxwacom-debuginfo-0.7.6_3-3.1.i386.rpm
RPM URL: http://meverhagen.nl/fc6/i386/linuxwacom-0.7.6_3-3.1.i386.rpm
Description:
This is my first rpm,
it is lunixwacom 0.7.6 wich updates lunixwacom 0.7.4 
It includes the wacomcpl (wacomcpl-exec) tool, wich is used for adjusting the 
pressure of the stylus and the buttons on the drawing tablet.
And a manpage for the xorg.conf editing: man wacom

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220703] Review Request: libgtksourceviewmm - A C++ wrapper for the gtksourceview widget library

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgtksourceviewmm - A C++ wrapper for the 
gtksourceview widget library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220703





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 14:33 EST ---
Well,
* I think adding pkgconfig to Requires for -devel package is
  safe for .pc file
* I didn't notice it, however, this is licensed under LGPL, not
  GPL...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220707] Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, man page

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, 
man page


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220707


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 14:43 EST ---


*** This bug has been marked as a duplicate of 220706 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220706] Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, man page

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, 
man page


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220706





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 14:43 EST ---
*** Bug 220707 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220706] Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, man page

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, 
man page


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220706


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 14:45 EST ---
Maybe it's just me, but I get a spinning globe GIF image for each of those URLs
with text orbiting it. Hotlink protection of some sort, perhaps? Though
refreshing the page (hence having my Referrer header that of your domain) does
not fix it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220704] Review Request: perl-GPS - Perl interface to a GPS receiver that implements the Garmin protocol

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-GPS - Perl interface to a GPS receiver that 
implements the Garmin protocol


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220704


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220704] Review Request: perl-GPS - Perl interface to a GPS receiver that implements the Garmin protocol

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-GPS - Perl interface to a GPS receiver that 
implements the Garmin protocol


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220704





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 16:04 EST ---
Review:
- no rpmlint output on any package
- package name OK
- spec file name OK, is in English and is legible
- package meets the Packaging Guidelines
- license OK (GPL) and is included
- source matches upstream
9569057d491c73cd597057de85472673  perl-GPS-0.15.tar.gz
9569057d491c73cd597057de85472673  perl-GPS-0.15.tar.gz.1
- builds on i386/x86_64 (FC6 and devel)
- BuildRequires and Requires are correct
- no localized files
- has no shared lib
- owns created directories
- no duplicates files, permissions are set properly, uses %defattr
- has %clean section
- consistent use of macros
- contains code
- no large docs, %doc is not required during runtime
- no devel subpackage required, no pkgconfig file
- no .la libtool archives
- not a GUI application

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220704] Review Request: perl-GPS - Perl interface to a GPS receiver that implements the Garmin protocol

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-GPS - Perl interface to a GPS receiver that 
implements the Garmin protocol


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220704


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220710] New: Review Request: glade3 - Gnome RAD library

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220710

   Summary: Review Request: glade3 - Gnome RAD library
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://nodoid.homelinux.org/fedora/glade3.spec
SRPM URL: http://nodoid.homelinux.org/fedora/glade3-3.1.4-1.src.rpm
Description:

Glade is a RAD tool to enable quick  easy development of user interfaces for 
the GTK+ toolkit and the GNOME desktop environment, released under the GNU GPL 
License.

The user interfaces designed in Glade are saved as XML, and by using the 
libglade library these can be loaded by applications dynamically as needed.

By using libglade, Glade XML files can be used in numerous programming 
languages including C, C++, Java, Perl, Python, C#, Pike, Ruby, Haskell, 
Objective Caml and Scheme. Adding support for other languages is easy too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220706] Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, man page

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linuxwacom-0.7.6_3-3.1.i386.rpm - with wacomcpl tool, 
man page


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220706





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 17:04 EST ---
there was a subdir missing

Spec URL: http://meverhagen.nl/fc6/i386/linuxwacom.spec
SRPM URL: http://meverhagen.nl/fc6/i386/linuxwacom-devel-0.7.6_3-3.1.i386.rpm
Debug URL: 
http://meverhagen.nl/fc6/i386/linuxwacom-debuginfo-0.7.6_3-3.1.i386.rpm
RPM URL: http://meverhagen.nl/fc6/i386/linuxwacom-0.7.6_3-3.1.i386.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 210823] Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wxsvg - wxSVG is C++ library to create, manipulate and 
render SVG files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210823





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 17:08 EST ---
on FC6 the compilation fails with the following error message:

g++ -DPACKAGE_NAME=\wxsvgtest\ -DPACKAGE_TARNAME=\wxsvgtest\
-DPACKAGE_VERSION=\1.0\ -DPACKAGE_STRING=\wxsvgtest 1.0\
-DPACKAGE_BUGREPORT=\[EMAIL PROTECTED]
-DPACKAGE=\wxsvgtest\ -DVERSION=\1.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
-DHAVE_DLFCN_H=1 -I. -I. -I../../include -I../../include/wxSVG
-I/usr/include/freetype2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -DUSE_RENDER_LIBART -I/usr/include/pango-1.0
-I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/libart-2.0 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
-mtune=generic -fasynchronous-unwind-tables -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -DUSE_RENDER_LIBART
-I/usr/lib/wx/include/gtk2-unicode-release-2.6 -I/usr/include/wx-2.6
-DGTK_NO_CHECK_CASTS -D__WXGTK__ -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES
-DNO_GCC_PRAGMA -MT SVGCanvasTextFreetype.lo -MD -MP -MF
.deps/SVGCanvasTextFreetype.Tpo -c SVGCanvasTextFreetype.cpp  -fPIC -DPIC -o
.libs/SVGCanvasTextFreetype.o
/usr/include/wx-2.6/wx/hashmap.h: In member function
'wxLongToLongHashMap_wxImplementation_HashTable::Node**
wxLongToLongHashMap_wxImplementation_HashTable::GetNodePtr(const long int) 
const':
/usr/include/wx-2.6/wx/hashmap.h:705: warning: dereferencing type-punned pointer
will break strict-aliasing rules
../../include/wxXML/xml.h: In member function
'wxXmlAttrHashBase_wxImplementation_HashTable::Node**
wxXmlAttrHashBase_wxImplementation_HashTable::GetNodePtr(const wxString) 
const':
../../include/wxXML/xml.h:83: warning: dereferencing type-punned pointer will
break strict-aliasing rules
/usr/include/wx-2.6/wx/gdicmn.h: In member function
'wxStringToColourHashMap_wxImplementation_HashTable::Node**
wxStringToColourHashMap_wxImplementation_HashTable::GetNodePtr(const wxString)
const':
/usr/include/wx-2.6/wx/gdicmn.h:476: warning: dereferencing type-punned pointer
will break strict-aliasing rules
../../include/wxSVG/CSSStyleDeclaration.h: In member function
'wxHashMapCSSValue_wxImplementation_HashTable::Node**
wxHashMapCSSValue_wxImplementation_HashTable::GetNodePtr(const wxCSS_PROPERTY)
const':
../../include/wxSVG/CSSStyleDeclaration.h:81: warning: dereferencing type-punned
pointer will break strict-aliasing rules
/usr/include/wx-2.6/wx/image.h: In member function
'wxImageHistogramBase_wxImplementation_HashTable::Node**
wxImageHistogramBase_wxImplementation_HashTable::GetNodePtr(const long unsigned
int) const':
/usr/include/wx-2.6/wx/image.h:123: warning: dereferencing type-punned pointer
will break strict-aliasing rules
SVGCanvasTextFreetype.cpp: At global scope:
SVGCanvasTextFreetype.cpp:231: error: invalid conversion from 'gint
(*)(FT_Vector*, void*)' to 'int (*)(const FT_Vector*, void*)'
SVGCanvasTextFreetype.cpp:231: error: invalid conversion from 'gint
(*)(FT_Vector*, void*)' to 'int (*)(const FT_Vector*, void*)'
SVGCanvasTextFreetype.cpp:231: error: invalid conversion from 'gint
(*)(FT_Vector*, FT_Vector*, void*)' to 'int (*)(const FT_Vector*, const
FT_Vector*, void*)'
SVGCanvasTextFreetype.cpp:231: error: invalid conversion from 'gint
(*)(FT_Vector*, FT_Vector*, FT_Vector*, void*)' to 'int (*)(const FT_Vector*,
const FT_Vector*, const FT_Vector*, void*)'
make[2]: *** [SVGCanvasTextFreetype.lo] Error 1
make[2]: Leaving directory `/usr/src/redhat/BUILD/wxsvg-1.0b7/src/freetype'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/redhat/BUILD/wxsvg-1.0b7/src'
make: *** [all-recursive] Error 1
Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.55997 (%build)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 210823] Review Request: wxsvg - wxSVG is C++ library to create, manipulate and render SVG files

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wxsvg - wxSVG is C++ library to create, manipulate and 
render SVG files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210823





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 17:16 EST ---
Are you building against rawhide wx or FC6?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217557] Review Request: keurocalc - KEuroCalc is a universal currency converter and calculator

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: keurocalc - KEuroCalc is a universal currency 
converter and calculator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217557


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 18:57 EST ---
Yes, I have

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217557] Review Request: keurocalc - KEuroCalc is a universal currency converter and calculator

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: keurocalc - KEuroCalc is a universal currency 
converter and calculator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217557





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 21:27 EST ---
thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 21:56 EST ---
(In reply to comment #8)
 Yes, this was on purpose since the sequence diagrams generation support isn't
 complete yet.

Does the configure script let you explicitly disable imagemagik,gs, and
plotutils support?  It would be best if these features were explicitly disabled
so we can get consistent rebuilds of the srpm even in build environments where
these exist.
I'm not sure this should count as a blocker or not, but I think Mamoru has a
point concerning binary reproducibility.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217





--- Additional Comments From [EMAIL PROTECTED]  2006-12-23 22:36 EST ---
(In reply to comment #10)
 Does the configure script let you explicitly disable imagemagik,gs, and
 plotutils support?  It would be best if these features were explicitly 
 disabled
 so we can get consistent rebuilds of the srpm even in build environments where
 these exist.

I believe there is a '--enable-sequence-diagrams=no' option we can add to
disable the building of this.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review