[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-stream-engine - Telepathy client to handle 
media streaming


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 04:46 EST ---
Approved,
just add --enable-sequencec-diagrams=no  to the %configure before you build.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209214] Review Request: libprelude - Prelude library collection

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libprelude - Prelude library collection


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209214


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 05:03 EST ---
Well,

Compared to http://fedoraproject.org/wiki/Packaging/Guidelines :

* Requires
  - Check the requirement for -devel package.
--
[EMAIL PROTECTED] bin]$ ./libprelude-config --libs
-L/usr/lib -lprelude -lgnutls -lgcrypt -lgpg-error -lrt -ldl
--
This usually means that -devel package should require
gnutls-devel.

* Beware of Rpath
  - This package fails on rpath checking.
---
+ /usr/lib/rpm/find-debuginfo.sh /home/tasaka1/rpmbuild/BUILD/libprelude-0.9.12
extracting debug info from
/var/tmp/libprelude-0.9.12-2-root-tasaka1/usr/bin/prelude-adduser
extracting debug info from
/var/tmp/libprelude-0.9.12-2-root-tasaka1/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Prelude/Prelude.so
extracting debug info from
/var/tmp/libprelude-0.9.12-2-root-tasaka1/usr/lib/libprelude.so.2.9.0
extracting debug info from
/var/tmp/libprelude-0.9.12-2-root-tasaka1/usr/lib/python2.5/site-packages/_prelude.so
10681 blocks
+ /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot
***
*
* WARNING: 'check-rpaths' detected a broken RPATH and will cause 'rpmbuild'
*  to fail. To ignore these errors, you can set the '$QA_RPATHS'
*  environment variable which is a bitmask allowing the values
*  below. The current value of QA_RPATHS is 0x.
*
*0x0001 ... standard RPATHs (e.g. /usr/lib); such RPATHs are a minor
*   issue but are introducing redundant searchpaths without
*   providing a benefit. They can also cause errors in multilib
*   environments.
*0x0002 ... invalid RPATHs; these are RPATHs which are neither absolute
*   nor relative filenames and can therefore be a SECURITY risk
*0x0004 ... insecure RPATHs; these are relative RPATHs which are a
*   SECURITY risk
*0x0008 ... the special '$ORIGIN' RPATHs are appearing after other
*   RPATHs; this is just a minor issue but usually unwanted
*0x0010 ... the RPATH is empty; there is no reason for such RPATHs
*   and they cause unneeded work while loading libraries
*0x0020 ... an RPATH references '..' of an absolute path; this will break
*   the functionality when the path before '..' is a symlink
*  
*
* Examples:
* - to ignore standard and empty RPATHs, execute 'rpmbuild' like
*   $ QA_RPATHS=$[ 0x0001|0x0010 ] rpmbuild my-package.src.rpm
* - to check existing files, set $RPM_BUILD_ROOT and execute check-rpaths like
*   $ RPM_BUILD_ROOT=top-dir /usr/lib/rpm/check-rpaths
*  
* 'check-rpaths' is part of 'rpmdevtools'.
*
***
ERROR   0010: file
'/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Prelude/Prelude.so'
contains an empty rpath in []
error: Bad exit status from /var/tmp/rpm-tmp.71892 (%install)

---
Prelude.so contains empty rpath and this should be removed.

* Timestamps
  - Please consider to keep timestamps on installed files,
especially on text files because
* timestamps can show when the files are created and
  if vendor (like you) have modified the files.
This package contain many HTML documents and header files,
so keeping timestamps on those files are preferable.

For this package, this can be done by

make install DESTDIR=%{buildroot} INSTALL=%{__install} -c -p
cp -p AUTHORS ChangeLog README INSTALL LICENSE.README HACKING.README \


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220703] Review Request: libgtksourceviewmm - A C++ wrapper for the gtksourceview widget library

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgtksourceviewmm - A C++ wrapper for the 
gtksourceview widget library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220703





--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 05:07 EST ---
Additional comment:
Inclusion of m4 file usually means that -devel package
should require automake.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 177747] Review Request: glade3

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glade3


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177747


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 05:42 EST ---
Okay, this is a dup of something I've submitted for FE.

The problem with libgladeui is the potential for clash with the current
libgladeui (okay, different version I know)...

As it's Christmas day, I'm doing nothing today other than with my family, so
I'll hack on with this tomorrow. In the meantime, my version of the spec and
srpm are available at

http://nodoid.homelinux.org/fedora/glade3-3.1.4-1.src.rpm
http://nodoid.homelinux.org/fedora/glade3.spec

Personally, I'd rather not separate out the libgladeui from the main package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220710] Review Request: glade3 - Gnome RAD library

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glade3 - Gnome RAD library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220710


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 05:43 EST ---


*** This bug has been marked as a duplicate of 177747 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 177747] Review Request: glade3

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glade3


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177747


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 05:43 EST ---
*** Bug 220710 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 177747] Review Request: glade3

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glade3


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177747


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 210424] Review Request: fail2ban - scan log files and ban IPs with too many password failures

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fail2ban - scan log files and ban IPs with too many 
password failures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210424


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 05:55 EST ---
Mamoru, do you want to continue on this package as a new submitter? I would
review it if you like to.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 210424] Review Request: fail2ban - scan log files and ban IPs with too many password failures

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fail2ban - scan log files and ban IPs with too many 
password failures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210424





--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 06:04 EST ---
(In reply to comment #8)
 Mamoru, do you want to continue on this package as a new submitter? I would
 review it if you like to.

No, I don't.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220710] Review Request: glade3 - Gnome RAD library

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glade3 - Gnome RAD library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220710


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163776  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 210424] Review Request: fail2ban - scan log files and ban IPs with too many password failures

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fail2ban - scan log files and ban IPs with too many 
password failures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210424





--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 07:03 EST ---
I took a look at the package submitted in comment 0. This is just the upstream
provided package with the changelog trimmed and the Packager field replaced,
this isn't quite what it considered packaging for Fedora. ;)

I'll submit a new package, then - Mamoru, hope you haven't lost your patience on
fail2ban and will be willing to review :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 210424] Review Request: fail2ban - scan log files and ban IPs with too many password failures

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fail2ban - scan log files and ban IPs with too many 
password failures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210424





--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 07:33 EST ---
(In reply to comment #10)
 I'll submit a new package, then - Mamoru, hope 
 you haven't lost your patience on
 fail2ban and will be willing to review :)

Well, when you submit a new package, I will review your
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 209214] Review Request: libprelude - Prelude library collection

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libprelude - Prelude library collection


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209214





--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 07:41 EST ---
More comments:

Please check the permissions of files:
-
E: libprelude-perl non-standard-executable-perm
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Prelude/Prelude.so
0555
-
Also, check if 0444 permission of
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Prelude.pm
is correct.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220743] New: Review Request: postgis - Geographic Information Systems Extensions to PostgreSQL

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220743

   Summary: Review Request: postgis - Geographic Information Systems
Extensions to PostgreSQL
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: 
http://developer.postgresql.org/~devrim/rpms/other/postgis/postgis.spec
SRPM URL: 
http://developer.postgresql.org/~devrim/rpms/other/postgis/postgis-1.2.0-1.src.rpm
Description: 
PostGIS adds support for geographic objects to the PostgreSQL object-relational
database. In effect, PostGIS spatially enables the PostgreSQL server,
allowing it to be used as a backend spatial database for geographic information
systems (GIS), much like ESRI's SDE or Oracle's Spatial extension. PostGIS
follows the OpenGIS Simple Features Specification for SQL and has been
certified as compliant with the Types and Functions profile.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220635] Review Request: livecd-tools - Tools for creating Live CD's

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: livecd-tools - Tools for creating Live CD's


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220635


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 13:07 EST ---
It fails to build on x86_64:
Nie znaleziono pliku: /var/tmp/livecd-tools-001-1-root/usr/lib64/livecd-
creator/mayflower
Nie znaleziono pliku: /var/tmp/livecd-tools-001-1-root/usr/lib64/livecd-
creator/run-init
Nie znaleziono pliku: File not found

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220759] New: Review Request: pdfcube - PDF viewer with a spinning cube

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220759

   Summary: Review Request: pdfcube - PDF viewer with a spinning
cube
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: http://krakoa.dk/fedora/pdfcube.spec
SRPM URL: http://krakoa.dk/fedora/pdfcube-0.0.2-1.src.rpm
Description: PDF Cube is an OpenGL API-based PDF viewer that adds a
compiz/Keynote-like spinning cube trasition effect to your PDF
presentations (including Latex, Beamer and Prosper). You can also zoom
on 5 predefined areas of any presentation page with a smooth zooming
effect.


rpmlint gives no errors. However I am not entirely happy about explicitly 
stating /usr/bin/pdfcube in the files section. Is that the right way to do it?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220759] Review Request: pdfcube - PDF viewer with a spinning cube

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pdfcube - PDF viewer with a spinning cube


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220759





--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 19:03 EST ---
Normally, you would use

  %{_bindir}/pdfcube

or

  %{_bindir}/*

instead of hardcoding /usr/bin.

$ rpm --eval %_bindir
/usr/bin

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220759] Review Request: pdfcube - PDF viewer with a spinning cube

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pdfcube - PDF viewer with a spinning cube


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220759





--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 19:17 EST ---
By the way this is my first package.

I have uploaded a new version which uses %{_bindir}.

New SRPM: http://krakoa.dk/fedora/pdfcube-0.0.2-2.src.rpm

The new spec file has the same url as the old one.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220759] Review Request: pdfcube - PDF viewer with a spinning cube

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pdfcube - PDF viewer with a spinning cube


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220759


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 19:20 EST ---
Adding FE-NEEDSSPONSOR as per
http://fedoraproject.org/wiki/Extras/Contributors#head-350f978b25c60398e0d16100bb3da317c1fd18c3

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219610] Review Request: uncrustify-0.30 - code beautifier

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: uncrustify-0.30 - code beautifier


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219610


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-25 23:19 EST ---
$ sha1sum uncrustify-0.30-1.fc6.src.rpm  
d4a0326889cd994e29422723fd9be1517e41edc8  uncrustify-0.30-1.fc6.src.rpm

good:
 + builds in mock for FC6 i386
 + rpmlint is silent
 + license is OK and correctly included
 + spec is very simple and clean
 + no shared libs and no *.la
 + perms and dir ownership OK
 + %clean OK

could be improved:
 - the Summary: Reformat source line is a little ambiguous and it
   might be more helpful to say Tool for source code reformatting
   or similar -- but that's just a suggestion, not a blocker

Its unfortunate how the config files are handled but I agree that it 
is an upstream problem.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219114] Review Request: flac123 - Command-line program for playing FLAC audio files

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: flac123 - Command-line program for playing FLAC audio 
files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219114


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 00:09 EST ---
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files md5sum. No upstream is available.
1614e1d1fe5b427ffd5988ea766abcf4  flac123-0.0.9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel or any subpackages exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220185] Review Request: kvm - Kernel Based Virtual Machine

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kvm - Kernel Based Virtual Machine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220185


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 01:03 EST ---
Suggest calling the binary 'kvm' instead of qemu-kvm, and adding a softlink to 
the qemu manual page.

Alternatively, merge it to the qemu package.  That's perhaps a little 
premature at this moment.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219872] Review Request: curlftpfs - user-space FTP filesystem using libcurl and FUSE

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: curlftpfs - user-space FTP filesystem using libcurl 
and FUSE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219872


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 02:09 EST ---
Interesting package. I will review this later.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 219071] Review Request: pyfribidi - A Python binding for GNU FriBidi

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyfribidi - A Python binding for GNU FriBidi


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219071


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 02:12 EST ---
I will review this later

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220393] Review Request: Synopsis - Source-code Introspection Tool

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Synopsis - Source-code Introspection Tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220393





--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 02:19 EST ---
I have to say that the spec file included in source tarball 
is far from ones which can be accepted into Fedora Extras.

Please write spec file of this package by yourself according to

http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 220766] New: Review Request: ScientificPython - a collection of Python modules that are useful for scientific computing

2006-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220766

   Summary: Review Request: ScientificPython -  a collection of
Python modules that are useful for scientific computing
   Product: Fedora Extras
   Version: devel
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: normal
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: fedora-package-review@redhat.com


Spec URL: 
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/ScientificPython/ScientificPython.spec

SRPM URL: 
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/ScientificPython/ScientificPython-2.6-2.src.rpm

Description:
ScientificPython is a collection of Python modules that are useful for 
scientific computing. In this collection you will find modules that cover basic 
geometry (vectors, tensors, transformations, vector and tensor fields), 
quaternions, automatic derivatives, (linear) interpolation, polynomials, 
elementary statistics, nonlinear least-squares fits, unit calculations, 
Fortran-compatible text formatting, 3D visualization via VRML, and two Tk 
widgets for simple line plots and 3D wireframe models. There are also 
interfaces to the netCDF library (portable structured binary files), to MPI 
(Message Passing Interface, message-based parallel programming), and to BSPlib 
(Bulk Synchronous Parallel programming)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review