[Bug 248231] Review Request: ustr - String library, very low memory overhead, simple to import
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ustr - String library, very low memory overhead, simple to import https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:02 EST --- The core behind this is: A package's CFLAGS must not use a different ABI. Your definition of ABI is vastly different to mine, apparently. -O* flags imply many other flags and have many side-effects (such as inlining, certain optimizations, certain arch-dependent optimizations etc.), which implicitly gradually change over time. Indeed they do, none of those change the Application Binary Interface though. And, as I would normally presume you'd know, they do affect things like hampering debugging of code (which, being the -debug package might be kind of the point). You are requiring making the debugging worse in Fedora, for no good reason that I can see. If you are going to hold to that line, due to it being policy, I'd like to know how I can go about getting this policy fixed. In this case, I am going to be hard - Fix the package. As I said I can make the package worse so it passes review (I'll upload a 0.7 package tomorrow), but again I'd like to know how I get this problem with policy fixed ... so at some point in the future I can unbreak the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225767] Merge Review: fonts-korean
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-korean https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225767 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |) | --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:10 EST --- (In reply to comment #15) Seems to me the version numbering is a bit strange, no? I think it should reflect the upstream version which is 2.2 now. yes. it should be changed to 2.2 version. else package looks ok. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225767] Merge Review: fonts-korean
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-korean https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225767 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:14 EST --- 1.0.11-10 is fonts-korean's version. 2.2 is baekmuk's version. IMHO, if one day fonts-korean be renamed to baekmuk-fonts, then we could change to 2.2 then. BTW FYI, a renaming will redirect all the previous fonts-korean history to baekmuk-fonts, and it might be lots of work to do if there is a meta package fonts-korean reintroduced in future. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244597] Review Request: rkward - Graphical frontend for R language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rkward - Graphical frontend for R language https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244597 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:20 EST --- I am back from hollidays, and you ?? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225767] Merge Review: fonts-korean
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-korean https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225767 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:27 EST --- (In reply to comment #17) 1.0.11-10 is fonts-korean's version. 2.2 is baekmuk's version. Yes, but fonts-korean is just a collection of baekmuk fonts, so it should follow the upstream version number. renaming will redirect all the previous fonts-korean history to baekmuk-fonts, and it might be lots of work to do if there is a meta package fonts-korean reintroduced in future. Yes it will be some work to rename the package but I think it is a meaningful and correct change to make. change. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248231] Review Request: ustr - String library, very low memory overhead, simple to import
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ustr - String library, very low memory overhead, simple to import https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:31 EST --- (In reply to comment #21) -O* flags imply many other flags and have many side-effects (such as inlining, certain optimizations, certain arch-dependent optimizations etc.), which implicitly gradually change over time. Indeed they do, none of those change the Application Binary Interface though. * -ggdb3 does. If GCC doesn't support it, your package won't build nor will it be usable. And, as I would normally presume you'd know, they do affect things like hampering debugging of code (which, being the -debug package might be kind of the point). Yes, -O2 always reduces debug-ability of the code, so what is the problem you are trying to solve? You are requiring making the debugging worse in Fedora, for no good reason that I can see. If you are going to hold to that line, due to it being policy, I'd like to know how I can go about getting this policy fixed. In this case, I am going to be hard - Fix the package. As I said I can make the package worse so it passes review (I'll upload a 0.7 package tomorrow), but again I'd like to know how I get this problem with policy fixed ... so at some point in the future I can unbreak the package. I guess you will understand, that I consider your answer to be non-acceptable and inappropriate. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225767] Merge Review: fonts-korean
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-korean https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225767 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:44 EST --- Changed: http://hiro.brisbane.redhat.com/~cchance/20070731_f-k/fonts-korean.spec http://hiro.brisbane.redhat.com/~cchance/20070731_f-k/fonts-korean-2.2-1.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244597] Review Request: rkward - Graphical frontend for R language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rkward - Graphical frontend for R language https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244597 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:44 EST --- Based on this list it seems that you have been sponsored so you should be able to approve the package: https://admin.fedoraproject.org/accounts/dump-group.cgi?group=cvsextrasrole_type=userformat=html You can have a look there http://fedoraproject.org/wiki/Packaging/ReviewGuidelines and there http://fedoraproject.org/wiki/PackageReviewProcess -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225767] Merge Review: fonts-korean
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-korean https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225767 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 02:58 EST --- Looks ok to me and ready for review. will post formal review now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225767] Merge Review: fonts-korean
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-korean https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225767 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 03:02 EST --- can't find source url tag -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: dynagen - Dynamips Hypervisor Client
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929
--- Additional Comments From [EMAIL PROTECTED] 2007-07-31 03:05 EST ---
Hi
This is my first review so I will do my best but I might need help :-)
At a first look:
you should use install rather than cp to install the files
you can change %{_mandir}/man1/dynagen.1.gz by %{name}.1.gz
I am surprise by your %{_bindir}/* in the %files section
I will have a further look later on.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dynagen - Dynamips Hypervisor Client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dynagen - Dynamips Hypervisor Client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225767] Merge Review: fonts-korean
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-korean https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225767 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 03:22 EST --- Created an attachment (id=160296) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160296action=view) Spec file. Spec file with URL tag. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249034] Review Request: sundials - nonlinear differential/algebraic solvers from LLNL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sundials - nonlinear differential/algebraic solvers from LLNL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249034 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 03:45 EST --- Well, (In reply to comment #19) Mamoru, feel free to let me know if I have slipped up somewhere. Since this is my first review, your help might be useful. Okay, I will check your review later (I have to check other person's package first..), but: (In reply to comment #20) * added %post and %postun for -devel pkg (not sure about this, as the shared libraries contained in the -devel package are only symlinks and contain no new SONAMEs. But have done as requested). Acutally this is not needed. I will check if there is something else to fix anyway -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225767] Merge Review: fonts-korean
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-korean https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225767 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 04:18 EST --- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 48c0405ffbdf45e1311a978b65b47f4c baekmuk-bdf-2.2.tar.gz a6f4349179cbe3557641782cefba4d70 baekmuk-ttf-2.2.tar.gz e8f61c1ad118bc0f22e9373864866c60 cidfmap.ko 53056f07c8eefbcc63a3f14cb3faa724 FAPIcidfmap.ko + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: dynagen - Dynamips Hypervisor Client
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929
--- Additional Comments From [EMAIL PROTECTED] 2007-07-31 04:49 EST ---
(In reply to comment #1)
Hi
This is my first review so I will do my best but I might need help :-)
At a first look:
you should use install rather than cp to install the files
As there is no make, it doesn't _really_ matter, and there isn't really any
advantages either way that I'm aware of (although I'll most likely change it
later on).
you can change %{_mandir}/man1/dynagen.1.gz by %{name}.1.gz
I won't do this, as it breaks the logical layout of the files section, (i.e. by
removing all the context), plus it's not consistent with other packages
(nothing personal, just a style thing).
I am surprise by your %{_bindir}/* in the %files section
As there isn't a make install (where by the contents of bindir may change
without warning), and instead I'm explicatly copying the two executable
scripts, it's not too much of an issue in comparison to other packages, I will
look at changing if there is anything major wrong.
I will have a further look later on.
Please look at bug 246150 (dynamips which dynagen depends on) before reviewing
this package.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244704] Review Request: bontmia - Backup over network to multiple incremental archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bontmia - Backup over network to multiple incremental archives https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244704 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 05:09 EST --- ping? Do you still want this package to be in Fedora? Summer vacation... Thanks for the review! New Package CVS Request === Package Name: bontmia Short Description: Backup over network to multiple incremental archives Owners: [EMAIL PROTECTED] Branches: FC-6 F-7 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250240] New: Review Request: linkage - Lightweight bittorent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240 Summary: Review Request: linkage - Lightweight bittorent client Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://tgmweb.at/gadllah/linkage.spec SRPM URL: http://tgmweb.at/gadllah/linkage-0.1.2-1.fc7.src.rpm Description: Linkage a bittorent lightweight client, it includes most common features found in other BitTorrent clients. Features include DHT, PEX, UPnP, desktop notifications and torrent creation -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189250] Review Request: python-lxml - ElementTree-like python bindings for libxml2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-lxml - ElementTree-like python bindings for libxml2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189250 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 07:27 EST --- Package Change Request == Package Name: python-lxml New Branches: EL-4 EL-5 Updated EPEL Owners: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250240] Review Request: linkage - Lightweight bittorent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linkage - Lightweight bittorent client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 07:58 EST --- Fixed the plugin location in a better/cleaner way: http://tgmweb.at/gadllah/linkage.spec http://tgmweb.at/gadllah/linkage-0.1.2-2.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250240] Review Request: linkage - Lightweight bittorent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linkage - Lightweight bittorent client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 08:01 EST --- Remove the .la files in the new location: http://tgmweb.at/gadllah/linkage.spec http://tgmweb.at/gadllah/linkage-0.1.2-3.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245515] Review Request: pv - A tool for monitoring the progress of data through a pipeline
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pv - A tool for monitoring the progress of data through a pipeline https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245515 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 08:56 EST --- New Package CVS Request === Package Name: pv Short Description: A tool for monitoring the progress of data through a pipeline Owners: [EMAIL PROTECTED] Branches: FC-6 F-7 EL-4 EL-5 InitialCC: N/A -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245515] Review Request: pv - A tool for monitoring the progress of data through a pipeline
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pv - A tool for monitoring the progress of data through a pipeline https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245515 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 09:10 EST --- Thanks for reviewing my package, Kevin! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250240] Review Request: linkage - Lightweight bittorent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linkage - Lightweight bittorent client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 09:32 EST --- mock build ends with: mkdir .libs g++ -DHAVE_CONFIG_H -I. -I.. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp- buffer-size=4 -m64 -mtune=generic -I/usr/include/gtkmm-2.4 -I/usr/lib64/gtkmm-2.4/include -I/usr/include/glibmm-2.4 -I/usr/lib64/glibmm-2.4/include -I/usr/include/gdkmm-2.4 -I/usr/lib64/gdkmm-2.4/include -I/usr/include/pangomm-1.4 - I/usr/include/atkmm-1.6 -I/usr/include/gtk-2.0 -I/usr/include/sigc++-2.0 -I/usr/lib64/sigc++-2.0/include -I/usr/incl ude/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/gtk-2.0/include -I/usr/include/cairomm-1.0 -I/usr/include/pa ngo-1.0 -I/usr/include/cairo -I/usr/include/atk-1.0 -I/usr/include/libtorrent -I/usr/include/dbus-1.0 -I/usr/lib64/d bus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DPLUGIN_DIR=\/usr/lib64/linkage/plugins\ -O 2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generi c -MT liblinkage_1_la-keyfile.lo -MD -MP -MF .deps/liblinkage_1_la-keyfile.Tpo -c gtkmm_extra/keyfile.cc -fPIC -DPI C -o .libs/liblinkage_1_la-keyfile.o gtkmm_extra/keyfile.cc:28: error: redefinition of 'struct Glib::Container_Helpers::TypeTraitsbool' /usr/include/glibmm-2.4/glibmm/containerhandle_shared.h:322: error: previous definition of 'struct Glib::Container_H elpers::TypeTraitsbool' make[3]: *** [liblinkage_1_la-keyfile.lo] Error 1 make[3]: Leaving directory `/builddir/build/BUILD/linkage-0.1.2/lib' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/builddir/build/BUILD/linkage-0.1.2/lib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/linkage-0.1.2' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.76956 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.76956 (%build) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250240] Review Request: linkage - Lightweight bittorent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linkage - Lightweight bittorent client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 09:46 EST --- works fine here (F7 x86_64 in mock) can you attach your build.log file? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249992] Review Request: glglobe - OpenGl Globe - Earth simulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glglobe - OpenGl Globe - Earth simulation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249992 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 09:54 EST --- Current spec: http://members.iinet.net.au/~timmsy/glglobe/glglobe.spec Updated src.rpm: http://members.iinet.net.au/~timmsy/glglobe/glglobe-0.2-3.fc7.src.rpm It didn't build in mock due to desktop-file-install not being available: - add BuildRequires: desktop-file-utils so that it build in mock -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241834] Review Request: online-desktop - Desktop built around web sites and online services
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: online-desktop - Desktop built around web sites and online services https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241834 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250150] Review Request: rarian - a replacement for scrollkeeper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rarian - a replacement for scrollkeeper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250150 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 10:13 EST --- Trivia: - please use a full source url - devel package needs to require pkgconfig - compat needs to Requires(post): rarian, I think - mock build fails with make[3]: Entering directory `/builddir/build/BUILD/rarian-0.5.4/util' Moving Files if needed mkdir: cannot create directory `/var/lib/rarian': Permission denied make[3]: *** [install-exec-hook] Error 1 I guess there is some DESTDIR missing somewhere -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250150] Review Request: rarian - a replacement for scrollkeeper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rarian - a replacement for scrollkeeper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250150 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250240] Review Request: linkage - Lightweight bittorent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linkage - Lightweight bittorent client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 10:20 EST --- Created an attachment (id=160324) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160324action=view) failed build log This is the log after trying to build in devel/x86_64 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199405] Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199405 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 10:21 EST --- Problems in building octaviz too. There are some relative paths in /usr/lib/vtk-5.0/vtkCommonKit.cmake that shouldn't be there. There are already patches to solve the problem at http://tinyurl.com/3auz54. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 171993] Review Request: mpich2 - An implementation of MPI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mpich2 - An implementation of MPI https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171993 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 10:30 EST --- There is still a clash between LAM and MPICH in that the manual files are the same between packages. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250240] Review Request: linkage - Lightweight bittorent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linkage - Lightweight bittorent client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 10:39 EST --- Created an attachment (id=160325) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160325action=view) mock root log for mock buildroot when build failed -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250240] Review Request: linkage - Lightweight bittorent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linkage - Lightweight bittorent client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 10:47 EST --- ok, thx for the log. seems that it does not build against the gtkmm24 version in rawhide. added maintainer to CC... any ideas? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 171993] Review Request: mpich2 - An implementation of MPI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mpich2 - An implementation of MPI https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171993 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 11:10 EST --- (In reply to comment #40) There is still a clash between LAM and MPICH in that the manual files are the same between packages. Thanks! I've had an idea of splitting out a mpi-manpages subpackage from the main package to contain these manuals (they are MPI routines manuals and are the same for mpich2, lam and openmpi). For the split to be effective, both lam and openmpi will need to create similar subpackage and have it conflict each other. I have a package with this split at ftp://czar.eas.yorku.ca/pub/mpich2/mpich2-1.0.5p4-4.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245515] Review Request: pv - A tool for monitoring the progress of data through a pipeline
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pv - A tool for monitoring the progress of data through a pipeline https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245515 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 11:14 EST --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244704] Review Request: bontmia - Backup over network to multiple incremental archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bontmia - Backup over network to multiple incremental archives https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244704 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 11:16 EST --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239385] Review Request: peless - Text Browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: peless - Text Browser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239385 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 11:52 EST --- Much better!! For -2: * Desktop file - Catetory Application is deprecated and should be removed (use --remove-category Application) - Use fedora as vendir_id. i.e. desktop-file-install --vendor fedora and this will create fedora-peless.desktop (and this case, use --remove-original: please check the section Desktop files of http://fedoraproject.org/wiki/Packaging/Guidelines ) * Packager/URL - Please remove the line Packager. This is automatically set on Fedora side - And use https://developer.berlios.de/projects/peless/ as URL. * Documents - Why do you want to include philo.txt as documents? * Changelog - Please also add the EVR (Epoch-Version-Release) to %changelog entry. For example: * Sat Jul 28 2007 Paul Elliott [EMAIL PROTECTED] - 1.156-2 - implement changes requested by Mamoru Tasakaon 2007-07-26 Okay, this package will be (almost?) okay if you fix the issues above. However, as this is a sponsor requested ticket, please read below: NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to show that you have an understanding of the process and of the packaging guidelines as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a pre-review of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose Merge Review) Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235203] Review Request: kdebluetooth: The KDE Bluetooth Framework (take/2)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdebluetooth: The KDE Bluetooth Framework (take/2) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235203 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 11:54 EST --- Thanks for the link(s). Build 31 only excludes PPC64. Missing PPC64 BZ [1] added to PPC64 tracker. [2]. - Gilboa [1] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250260 [2] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=FE-ExcludeArch-ppc64 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249352] Review Request: popt - C library for parsing command line parameters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: popt - C library for parsing command line parameters https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249352 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 12:00 EST --- *** Bug 203538 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226377] Merge Review: rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: rpm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226377 Bug 226377 depends on bug 203538, which changed state. Bug 203538 Summary: a popt-devel package should be split out of popt https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203538 What|Old Value |New Value Resolution||DUPLICATE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249352] Review Request: popt - C library for parsing command line parameters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: popt - C library for parsing command line parameters https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249352 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 12:03 EST --- Also popt-devel will have to be added to a lot of BR, unless my rough analysis in Bug 203538 is incorrect. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226487] Merge Review: texi2html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: texi2html https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226487 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 11:57 EST --- Do you agree with my proposals, such that I can provide you with a patch or are you disagreeing? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245649] Review Request: gnome-password-generator - Graphical secure password generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-password-generator - Graphical secure password generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245649 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 12:07 EST --- Ah, I forgot to write (although I noticed: ) - Desktop file Category Application is deprecated and should be removed. Everything else is okay. - This package (gnome-password-generator) is APPROVED by me - -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234581] Review Request: Mapnik cartography library - first package, need sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Mapnik cartography library - first package, need sponsor. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234581 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 12:12 EST --- Some files have Windows-style end-of-file encodings. Please fix them to Unix-style encodings Files removed in upstream SVN. Summary should not end with dot. Fixed. QUESTION How is libmapnik.so used? - Is this library used only by this package? - Or can this library be linked from other software? Still waiting on upstream. - In %changelog, please use %%_prefix. Otherwise %_prefix is expanded in %changelog. Fixed. * compilation flags - Fedora specific compilation flags are not honored. - -O3 flag is generally forbidden (this make debugging difficult) Fixed in SPEC file / patches. Upstream did not want to change. * Fonts - Fedora has dejavu-fonts, dejavu-fonts-experimental and shipping duplicate dejavu fonts in this package is not allowed. Fixed in SPEC file / patches. Still needed in upstream to build on other platforms (eg Windows). * sitelib vs sitearch - This package installs /usr/lib/python2.5/site-packages/mapnik/_mapnik.so , which is arch dependent. python related files must be installed under %python_sitearch. not under %python_sitelib. Fixed. I am still waiting on upstream to fix the soversion and then to make a release. I have not published an updated version of my SPEC file as I have switched to building from SVN prior to the upstream release. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249522] Review Request: sepostgresql - Security-Enhanced PostgreSQL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: sepostgresql - Security-Enhanced PostgreSQL
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249522
--- Additional Comments From [EMAIL PROTECTED] 2007-07-31 12:12 EST ---
Thanks for your reviewing. The packages are updated based on them.
http://code.google.com/p/sepgsql/downloads/list
Spec URL: http://sepgsql.googlecode.com/files/sepostgresql.spec
SRPM URL: http://sepgsql.googlecode.com/files/sepostgresql-8.2.4-
0.407.beta.fc8.src.rpm
(1).
I could not build your package.
What is selinux-policy-devel = 2.6.4-26.sepgsql.fc7?
It it included in fedora?
It is a modified selinux-policy package.
Several Definitions for database related object classes and access vectores are
added. Because these definitons are currently included in the default selinux-
policy package, we also have to submit the additional definitions into the
default selinux-policy package.
You can obtain the additional definitions from here:
http://sepgsql.googlecode.com/svn/policy/refpolicy-add-sepgsql-
definitions.fedora8.patch
(2)
You have to use more macros throughout spec file.
Such as:
sepostgresql - %{name}
/usr/share/selinux/devel/Makefile - %{__datadir}/selinux/devel/Makefile
and also /usr/sbin etc, you can replace them with macros.
Several standard paths are replaced by the macros.
/etc/rc.d/init.d - %{_initrddir}
/usr/share - %{_datadir}
However, I kept a part using /usr/sbin as a path of commands, like semodule,
because these are not changed when %{_prefix} of sepostgresql is over-written.
In addition, this manner follows the Packaging SELinux Policy Modules (draft).
http://fedoraproject.org/wiki/PackagingDrafts/SELinux/PolicyModules
(3)
Your package does not include documentation.
The following line was added.
%doc COPYRIGHT README HISTORY
SE-PostgreSQL is distributed under BSD license, as PostgreSQL.
(4)
I can not find download url for source files.
Source0 got a full location to indicate full location, as follows:
Source0: ftp://ftp.postgresql.org/pub/source/v%{version}/postgresql-%
{version}.tar.gz
Thanks,
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226557] Merge Review: xfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xfig https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226557 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Bug 226557 depends on bug 211796, which changed state. Bug 211796 Summary: update to newer release of xfig https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211796 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248858] Review Request: cupsddk - CUPS Driver Development Kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cupsddk - CUPS Driver Development Kit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248858 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 12:33 EST --- New Package CVS Request === Package Name: cupsddk Short Description: CUPS Driver Development Kit Owners: [EMAIL PROTECTED] Branches: FC-6 F-7 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248858] Review Request: cupsddk - CUPS Driver Development Kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cupsddk - CUPS Driver Development Kit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248858 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 12:47 EST --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247417] Review Request: bouml - UML2 tool box to specify and generate code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bouml - UML2 tool box to specify and generate code https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247417 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 12:50 EST --- Hi, I am Bruno Pagès, author of Bouml I see you have many problems to compile Bouml and this is a big surprise : the other distributions made images without problem nor changes from the source distribution I give, except changing definition of BOUML_LIB and other variables in the toplevel Makefile. Note : in all the cases qmake is used to produce the Makefiles (except the toplevel one written by hand) like the toplevel Makefile ask for I am also able to compile Bouml without any changes under a (old !) red hat 2.6.9-42 (i686 athlon) using Qt 3.3 On the download page of the site (http://bouml.free.fr/download.html) I point to several Bouml distributions, can I add a pointer to yours ? Do you have a page associated to Bouml, or a constant link to the rpm (http://rishi.fedorapeople.org/bouml-2.29.1-1.fc8.src.rpm depend on the release and may be more because I don't know the meaning of 'fc8'), or a way to find it through a query (like for FreeBSD) ? Best regards and thank you to compile Bouml for Fedora users Bruno -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249761] Review Request: funionfs - Union filesystem in userspace using FUSE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: funionfs - Union filesystem in userspace using FUSE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249761 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 13:04 EST --- New Package CVS Request === Package Name: funionfs Short Description: Union filesystem in user space Owners: Jeff Law Branches: F7 InitialCC: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248858] Review Request: cupsddk - CUPS Driver Development Kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cupsddk - CUPS Driver Development Kit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248858 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250150] Review Request: rarian - a replacement for scrollkeeper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rarian - a replacement for scrollkeeper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250150 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 13:44 EST --- Posted an update with your suggestions. SRPM URL: http://baloo.boston.redhat.com/~mbarnes/rarian/rarian-0.5.4-2.fc7.src.rpm Still investigating what's causing the mock failure. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249352] Review Request: popt - C library for parsing command line parameters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: popt - C library for parsing command line parameters https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249352 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 13:53 EST --- Correct, initscripts and mkinitrd (nash) would be two important ones except rpm. IIRC static linking is required for initscripts, maybe I'm wrong, just what my brain thinks to know ;) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248991] Review Request: python-iniparse - A better INI parser for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-iniparse - A better INI parser for Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248991 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 14:21 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249761] Review Request: funionfs - Union filesystem in userspace using FUSE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: funionfs - Union filesystem in userspace using FUSE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249761 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 14:24 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249949] Review Request: beldi - Belug Linux Distribution Burner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beldi - Belug Linux Distribution Burner https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249949 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 14:26 EST --- The desktop file is no big deal, but what troubles me is that we need write access to /var/lib/beldi [¹], so we have two possibilities: 1. make /var/lib/beldi writable for a special beldi group and require the user to be added to this group 2. install beldi to /usr/sbin and call it through consolehelper for normal users Robert, what do you prefer? [¹] Have you tested what happens when everything is downloaded? Do we still need special permissions for burning the CDs? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245649] Review Request: gnome-password-generator - Graphical secure password generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-password-generator - Graphical secure password generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245649 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 14:27 EST --- Spec: http://rishi.fedorapeople.org/gnome-password-generator-5.spec SRPM: http://rishi.fedorapeople.org/gnome-password-generator-1.4-5.fc8.src.rpm Koji info: http://koji.fedoraproject.org/koji/taskinfo?taskID=83573 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245649] Review Request: gnome-password-generator - Graphical secure password generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-password-generator - Graphical secure password generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245649 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249034] Review Request: sundials - nonlinear differential/algebraic solvers from LLNL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: sundials - nonlinear differential/algebraic solvers
from LLNL
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249034
--- Additional Comments From [EMAIL PROTECTED] 2007-07-31 14:38 EST ---
Well,
* /sbin/ldconfig call
- calling /sbin/ldconfig is not needed for -devel package
* static archive
- split static archives from -devel package, move them to -static
subpackage and make -static subpackage require -devel subpackge
(check: Packaging Static Libraries of
http://fedoraproject.org/wiki/Packaging/Guidelines )
* dependency for main/subpackage
- Usually the dependency for main/subpackage must be version-release
specific
i.e. -devel package must have:
Requires: %{name} = %{version}-%{release}
* defattr
- We recommend %defattr(-,root,root,-)
- Also this must be added to all subpackages.
(In reply to comment #19)
Mamoru, feel free to let me know if I have slipped up somewhere.
Since this is
my first review, your help might be useful.
Well, when you want to review in this style, please also write the
summary of where to fix so that your review can be read easily.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245649] Review Request: gnome-password-generator - Graphical secure password generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-password-generator - Graphical secure password generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245649 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 14:45 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245649] Review Request: gnome-password-generator - Graphical secure password generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-password-generator - Graphical secure password generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245649 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245515] Review Request: pv - A tool for monitoring the progress of data through a pipeline
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pv - A tool for monitoring the progress of data through a pipeline https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245515 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 15:45 EST --- The package has been successfully built for the devel branch: http://koji.fedoraproject.org/koji/taskinfo?taskID=83662 I'm closing this review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250315] New: Review Request: Linux-Complete-Backup-and-Recovery-HOWTO - bare metal recovery scripts docs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250315 Summary: Review Request: Linux-Complete-Backup-and-Recovery- HOWTO - bare metal recovery scripts docs Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.charlescurley.com/Linux-Complete-Backup-and-Recovery-HOWTO/Linux-Complete-Backup-and-Recovery-HOWTO.spec SRPM URL: http://www.charlescurley.com/Linux-Complete-Backup-and-Recovery-HOWTO/Linux-Complete-Backup-and-Recovery-HOWTO-2.3-1.fc7.src.rpm Description: A set of scripts to back up and restore a mimimal system for bare metal restoration. They are useful on i386 systems. Patches for others are welcome. Install this package on clients, and the documentation package where you want it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245015] PolicyKit package review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: PolicyKit package review https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245015 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 15:54 EST --- Built in pkg cvs. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245016] PolicyKit-gnome package review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: PolicyKit-gnome package review https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245016 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 15:54 EST --- Built in pkg cvs. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248301] Review Request: lzma - lzma compression tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lzma - lzma compression tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248301 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO Flag||needinfo?(patrice.bouchand.f ||[EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 15:57 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211319] Review Request: andutteye-client - Andutteye Software Suite Monitoring agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: andutteye-client - Andutteye Software Suite Monitoring agent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211319 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|CLOSED Resolution||NOTABUG OtherBugsDependingO|163776, 177841 |201449 nThis|| Flag|needinfo?(andreas.utterberg@| |thundera.se)| --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 15:59 EST --- CLOSING If someone wants to import this package into Fedora, please file a new review request, thank you. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dynagen - Dynamips Hypervisor Client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 16:40 EST --- First complains here : $ rpmlint ../RPMS/noarch/dynagen-0.9.3-1.fc6.noarch.rpm E: dynagen non-executable-script /usr/lib/python2.4/site-packages/console.py 0644 W: dynagen spurious-executable-perm /usr/share/doc/dynagen-0.9.3/sample_labs/all_config_options.txt W: dynagen wrong-file-end-of-line-encoding /usr/share/doc/dynagen-0.9.3/README.txt E: dynagen non-executable-script /usr/lib/python2.4/site-packages/dynamips_lib.py 0644 E: dynagen wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/dynamips_lib.py W: dynagen hidden-file-or-dir /usr/share/doc/dynagen-0.9.3/sample_labs/.DS_Store E: dynagen script-without-shebang /usr/bin/configspec W: dynagen wrong-file-end-of-line-encoding /usr/share/doc/dynagen-0.9.3/COPYING W: dynagen wrong-file-end-of-line-encoding /usr/share/doc/dynagen-0.9.3/docs/tutorial.htm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234612] Review Request: Ice - The Internet Communications Engine (Object middleware)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Ice - The Internet Communications Engine (Object middleware) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234612 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |) | --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 17:04 EST --- Okay, I've now put everything into one big SRPM. I'm not sure this is the way to go -- non-noarch Java and C# packages are sort of weird -- but this does make things neater. http://www6.informatik.tu-muenchen.de/~foster/extras/ice/ice.spec http://www6.informatik.tu-muenchen.de/~foster/extras/ice/ice-3.2.0-6.fc7.lcg.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249949] Review Request: beldi - Belug Linux Distribution Burner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beldi - Belug Linux Distribution Burner https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249949 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 17:21 EST --- Good question. I don't know what's better and I also don't know whether we need special permissions for burning the CDs. Option 1 IMHO requires an upstream modification while second could be downstream only, right? Otherwise we would have to maintain a patch for beldi or am I wrong? Second has the issue, that userhelper involves root permissions for beldi which are maybe not required and which could be a security issue?! I'll talk with Andy about it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246150] Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246150
--- Additional Comments From [EMAIL PROTECTED] 2007-07-31 17:37 EST ---
Hi
MUST: rpmlint must be run on every package. The output should be posted in the
review.
$ rpmlint ../SRPMS/dynamips-0.2.7-1.fc6.src.rpm
../RPMS/i386/dynamips-0.2.7-1.fc6.i386.rpm
../RPMS/i386/dynamips-debuginfo-0.2.7-1.fc6.i386.rpm
= clean
MUST: The package must be named according to the Package Naming Guidelines.
Ok
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming
Guidelines.
Ok
MUST: The package must meet the Packaging Guidelines.
License Text = absent whereas the COPYING is present in the original tarball
(I think README can also be included)
MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines.
Ok
MUST: The License field in the package spec file must match the actual license.
Ok
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc
No (see above)
MUST: The spec file must be written in American English
Ok
MUST: The spec file for the package MUST be legible. If the reviewer is unable
to read the spec file, it will be impossible to perform a review.
Ok
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
Ok
MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
Built Ok on i386
MUST: All build dependencies must be listed in BuildRequires
Ok
MUST: The spec file MUST handle locales properly.
There is no so
Ok
MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
Ok
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package.
Ok
MUST: A package must own all directories that it creates.
I would prefer a more detailled one [ie {%_mandir}/man1/ is not owned by the
software as it contains other files (that would lead to a confusion on rpm -qf I
think)]
%{_bindir}/%{name}
%{_bindir}/nvram_export
%{_mandir}/man1/%{name}.1.gz
%{_mandir}/man1/nvram_export.1.gz
%{_mandir}/man7/hypervisor_mode.7.gz
MUST: A package must not contain any duplicate files in the %files listing.
Ok
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
Ok
MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
Ok
MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
Ok
MUST: The package must contain code, or permissable content. This is described
in detail in the code vs. content section of Packaging Guidelines.
Ok
MUST: Large documentation files should go in a -doc subpackage.
Ok
MUST: If a package includes something as %doc, it must not affect the runtime
of the application.
Ok
MUST: Header files must be in a -devel package
Ok
MUST: Static libraries must be in a -static package.
Ok
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability)
Ok
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package.
Ok
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
Ok
MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
Ok
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
Ok
MUST: Packages must not own files or directories already owned by other
packages.
This is why I would prefer a more detailed %files section
MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT)
Ok
MUST: All filenames in rpm packages must be valid UTF-8.
Ok
I did not find any big issue with the SHOULD condition.
Regards,
P.Y.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
[Bug 246150] Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246150 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248314] Review Request: cheese - A cheesy program to take pictures and videos from your web cam
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cheese - A cheesy program to take pictures and videos from your web cam https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248314 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 17:50 EST --- ping ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226275] Merge Review: perl-PDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-PDL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226275 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 17:55 EST --- rpmlint: W: perl-PDL macro-in-%changelog description - can be ignored W: perl-PDL mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) - Fixed in patch I think the Summary should be changed to something like The Perl Data Language. - package meets naming guidelines - package meets packaging guidelines - license (GPL/Artistic) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Consider including some more files in %doc: BUGS Changes Known_problems Release_Notes A number of PDL modules are not being built that could be. I'll be attaching a number of patches that enable them as well as getting PDL to build for devel again. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226275] Merge Review: perl-PDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-PDL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226275 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 17:58 EST --- Created an attachment (id=160366) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160366action=view) patch to devel Patch to spec and perl-PDL-settings.patch that: - turns on 3D/GL - turns on IO Browser - changes tabs to spaces - adds a bunch of BRs to enable more modules - removes unneeded Provides -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226275] Merge Review: perl-PDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-PDL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226275 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 17:59 EST --- Created an attachment (id=160367) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160367action=view) patch to look for hdf devel files in the right place -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226275] Merge Review: perl-PDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-PDL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226275 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 17:59 EST --- Created an attachment (id=160368) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160368action=view) patch to fix some tests -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226275] Merge Review: perl-PDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-PDL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226275 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:00 EST --- Created an attachment (id=160369) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160369action=view) patch to find 64-bit libraries for certain modules -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226631] Merge Review: xorg-x11-drv-vesa
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xorg-x11-drv-vesa https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226631 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:05 EST --- Abbreviated mass review of xorg-x11-drv-* packages. b96c80ae81f5123ecef344dac4c734b2e281143d3ab7a7e633d6bf04c893e203 xf86-video-vesa-1.3.0.tar.bz2 rpmlint says: W: xorg-x11-drv-vesa mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 3) which is OK. * File and directory ownership looks good. * debuginfo package looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250340] New: Review Request: perl-ExtUtils-F77 - Simple interface to F77 libs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250340 Summary: Review Request: perl-ExtUtils-F77 - Simple interface to F77 libs Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.cora.nwra.com/~orion/fedora/perl-ExtUtils-F77.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/perl-ExtUtils-F77-1.16-1.src.rpm Description: This module tries to figure out how to link C programs with Fortran subroutines on your system. Basically one must add a list of Fortran runtime libraries. The problem is their location and name varies with each OS/compiler combination! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226632] Merge Review: xorg-x11-drv-vga
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: xorg-x11-drv-vga
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226632
[EMAIL PROTECTED] changed:
What|Removed |Added
Severity|normal |medium
Priority|normal |medium
Product|Fedora Extras |Fedora
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:09 EST ---
Abbreviated mass review of xorg-x11-drv-* packages.
ca25f4c0f706688cbc2dcd03ffaf6a57a17290290257f0cc1b1f1bb261f95b41
xf86-video-vga-4.1.0.tar.bz2
rpmlint says:
W: xorg-x11-drv-vga invalid-license MIT/X11
This needs fixing.
W: xorg-x11-drv-vga mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 3)
This is OK.
%{moduledir} and %{driverdir} shouldn't be owned.
I can fix these minor issues if you like.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dynagen - Dynamips Hypervisor Client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248231] Review Request: ustr - String library, very low memory overhead, simple to import
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ustr - String library, very low memory overhead, simple to import https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:13 EST --- * -ggdb3 does. If GCC doesn't support it, your package won't build nor will it be usable You are saying -ggdb3 Changes the ABI? I don't think so. Yes, that is somewhat of a GCC specific option. As are all the -W flags. If that's the only objection, I'm not that bothered about droping that. Yes, -O2 always reduces debug-ability of the code, so what is the problem you are trying to solve? Ok, so explaining again: . The srpm currently produces 6 packages, the most relevant to this are the two main ones: ustr-1.0.1-0.7.fc7.x86_64.rpm ustr-debug-1.0.1-0.7.fc7.x86_64.rpm ...the first is the library built for production, and is what all the people using a program that uses the library will see. The second is _the same code_ built using as much debugging as possible, so (expensive) internal consistency checks are called often; optimizations are turned down; etc. The idea being that anyone developing code using the library can use the debugging version while doing development and it will actively alert them to errors. Forcing build flags that make debugging harder when using this package is not doing to help anyone. I guess you will understand, that I consider your answer to be non-acceptable and inappropriate. Actually I didn't, and still don't, understand that ... I said I would do what you wanted to follow policy, even though it was wrong, and I repeatedly asked how I could fix policy. Is one not allowed to point out that policy is wrong? I can't imagine what I said that was inappropriate. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246150] Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246150 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:15 EST --- I realize looking at the official website that I will not be able to test the package. I am sorry but I can not do the review for the two packages. Sorry again Regards, P.Y. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246150] Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246150 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226633] Merge Review: xorg-x11-drv-via
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xorg-x11-drv-via https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226633 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:33 EST --- Abbreviated mass review of xorg-x11-drv-* packages. 5026bdaf644178fee66a26190453b0dddb99558b8c97c4a592a482a2434dc862 xf86-video-via-0.2.2.tar.bz2 rpmlint says: E: xorg-x11-drv-via library-without-ldconfig-postin /usr/lib64/libviaXvMC.so.1.0.0 E: xorg-x11-drv-via library-without-ldconfig-postun /usr/lib64/libviaXvMC.so.1.0.0 E: xorg-x11-drv-via library-without-ldconfig-postin /usr/lib64/libviaXvMCPro.so.1.0.0 E: xorg-x11-drv-via library-without-ldconfig-postun /usr/lib64/libviaXvMCPro.so.1.0.0 I think these are problematic. Or is there some reason an ldconfig pass isn't needed here? W: xorg-x11-drv-via-devel no-documentation W: xorg-x11-drv-via mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 3) Not problematic. Plus 56 undefined-non-weak-symbol complaints in /usr/lib64/libviaXvMC.so.1.0.0 and /usr/lib64/libviaXvMCPro.so.1.0.0. I note that the same issues are present in the XvMC libs from the i810 driver. Maybe there's something special about XvMC libraries? * File and directory ownership looks good. * debuginfo package looks good. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250342] New: Review Request: perl-Astro-FITS-CFITSIO - Perl extension for using the cfitsio library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250342 Summary: Review Request: perl-Astro-FITS-CFITSIO - Perl extension for using the cfitsio library Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.cora.nwra.com/~orion/fedora/perl-Astro-FITS-CFITSIO.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/perl-Astro-FITS-CFITSIO-1.05-1.src.rpm Description: Perl interface to William Pence's cfitsio subroutine library. For more information on cfitsio, see http://heasarc.gsfc.nasa.gov/fitsio. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226634] Merge Review: xorg-x11-drv-vmmouse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xorg-x11-drv-vmmouse https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226634 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:40 EST --- Abbreviated mass review of xorg-x11-drv-* packages. 383e0973aad0e96812fc019cb579abaf016f97427fc07466b150fe15739ba63c xf86-input-vmmouse-12.4.0.tar.bz2 rpmlint says: W: xorg-x11-drv-vmmouse mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 3) which is OK. * File and directory ownership looks good. * debuginfo package looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226635] Merge Review: xorg-x11-drv-vmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xorg-x11-drv-vmware https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226635 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:43 EST --- Abbreviated mass review of xorg-x11-drv-* packages. 1971fd356ba54204c3611edb9144c43c25c21167a5fa5ee725d3f2e3f9864fa9 xf86-video-vmware-10.14.1.tar.bz2 rpmlint says: W: xorg-x11-drv-vmware mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 3) which is OK. * File and directory ownership looks good. * debuginfo package looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249590] Review Request: and - Auto nice daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: and - Auto nice daemon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:51 EST --- and-1.2.2-3.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226636] Merge Review: xorg-x11-drv-void
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: xorg-x11-drv-void
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226636
[EMAIL PROTECTED] changed:
What|Removed |Added
Severity|normal |medium
Priority|normal |medium
Product|Fedora Extras |Fedora
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:51 EST ---
Abbreviated mass review of xorg-x11-drv-* packages.
b43c5d920821bd06b6a1a131dd071ab838bf024c3cb092c6d1f10d57b648b0e4
xf86-input-void-1.1.0.tar.bz2
rpmlint says:
W: xorg-x11-drv-void mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 3)
which is OK
E: xorg-x11-drv-void standard-dir-owned-by-package /usr/share/man
which is quite problematic.
The only real issue is that this package shouldn't own %{_mandir}. I can fix it
for you if you like.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226637] Merge Review: xorg-x11-drv-voodoo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xorg-x11-drv-voodoo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226637 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 18:54 EST --- Abbreviated mass review of xorg-x11-drv-* packages. f6f606698a5d635daa4a4cba8dc42ad2ef77bda5e5fe2086cdaf7b3b63e5f376 xf86-video-voodoo-1.1.0.tar.bz2 rpmlint says: W: xorg-x11-drv-voodoo mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 3) which is OK. * File and directory ownership looks good. * debuginfo package looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226576] Merge Review: xorg-x11-drv-amd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xorg-x11-drv-amd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226576 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 19:01 EST --- Looks like there's been an update since my last comment, so I'll do an abbreviated review. There's no URL for the upstream tarball; it seems to be from a git checkout. Some basic instructions on how to fetch the source are needed. The URL tag seems to be invalid; I get 403 Forbidden - No such project. rpmlint says: W: xorg-x11-drv-amd invalid-license MIT/X11 Should be MIT. W: xorg-x11-drv-amd mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 3) W: xorg-x11-drv-amd no-documentation These are OK. * File and directory ownership looks good. * debuginfo package looks good. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226587] Merge Review: xorg-x11-drv-dmc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xorg-x11-drv-dmc https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226587 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 19:17 EST --- Currently failing to build in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226589] Merge Review: xorg-x11-drv-dynapro
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xorg-x11-drv-dynapro https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226589 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 19:18 EST --- Currently fails to start building due to a missing patch: error: File /home/tibbs/work/extras-cvs/xorg-x11-drv-dynapro/devel/dynapro-1.1.0-calibration.patch: No such file or directory -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249522] Review Request: sepostgresql - Security-Enhanced PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sepostgresql - Security-Enhanced PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249522 --- Additional Comments From [EMAIL PROTECTED] 2007-07-31 21:40 EST --- Oops, some fix in my comments: OLD:(1) Because these definitons are currently included in ... NEW:(1)' Because these definitons are NOT currently included in ... OLD:(4) Source0 got a full location to indicate full location, as follows: NEW:(4)' Source0 got a full location to indicate, as follows: (In reply to comment #3) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247513] Review Request: junit4 - java regression testing framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: junit4 - java regression testing framework
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247513
--- Additional Comments From [EMAIL PROTECTED] 2007-08-01 01:08 EST ---
Created an attachment (id=160393)
-- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160393action=view)
Detailed review
Overview of things that need attention:
X * skim the summary and description for typos, etc.
# The summary is outdated - references EPL which may confuse people. See
patch
# for fix from http://www.junit.org/index.htm
X * correct buildroot
- should be:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
# Needs to be fixed
X * license text included in package and marked with %doc
# cpl-v10.html should be included in %doc
X * rpmlint on this package.srpm gives no output
# tab and space mixing issues: see patch
X * run rpmlint on the binary RPMs
XNote: group warnings can be ignored.
# Results from binary rpm rpmlint-ing
#$ rpmlint -v /var/lib/mock/fedora-7-x86_64/root/builddir/build/RPMS/junit4-*
#I: junit4 checking
#W: junit4 wrong-file-end-of-line-encoding
/usr/share/doc/junit4-4.3.1/README.html
#I: junit4-debuginfo checking
#I: junit4-demo checking
#W: junit4-demo no-documentation
#I: junit4-javadoc checking
#I: junit4-manual checking
#W: junit4-manual wrong-file-end-of-line-encoding
/usr/share/doc/junit4-manual-4.3.1/faq/faq.htm
#W: junit4-manual wrong-file-end-of-line-encoding
/usr/share/doc/junit4-manual-4.3.1/testinfected/testing.htm
#W: junit4-manual wrong-file-end-of-line-encoding
/usr/share/doc/junit4-manual-4.3.1/index.htm
#W: junit4-manual wrong-file-end-of-line-encoding
/usr/share/doc/junit4-manual-4.3.1/cookbook/cookbook.htm
#W: junit4-manual wrong-file-end-of-line-encoding
/usr/share/doc/junit4-manual-4.3.1/cookstour/cookstour.htm
SHOULD:
X * package should include license text in the package and mark it with %doc
# See above, might need fixing
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 247513] Review Request: junit4 - java regression testing framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: junit4 - java regression testing framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247513 --- Additional Comments From [EMAIL PROTECTED] 2007-08-01 01:22 EST --- Created an attachment (id=160394) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160394action=view) Suggested fixes for some of the issues NEEDSWORK: See above summary -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
