[Bug 420431] Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes https://bugzilla.redhat.com/show_bug.cgi?id=420431 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 351361] Review Request: ghc-X11-extras - Haskell X11-extras library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ghc-X11-extras - Haskell X11-extras library Alias: ghc-X11-extras https://bugzilla.redhat.com/show_bug.cgi?id=351361 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 04:06 EST --- Running rpmlint on the packages built from ghc-X11-extras-0.4-4.tillf7.src.rpm: ghc681-X11-extras.i386: W: devel-file-in-non-devel-package /usr/lib/X11-extras-0.4/ghc-6.8.1/libHSX11-extras-0.4.a ghc681-X11-extras.i386: E: script-without-shebang /usr/lib/X11-extras-0.4/ghc-6.8.1/X11-extras.pkg ghc681-X11-extras.i386: W: devel-file-in-non-devel-package /usr/lib/X11-extras-0.4/ghc-6.8.1/include/XlibExtras.h ghc-X11-extras.i386: W: no-documentation ghc-X11-extras.i386: E: no-binary -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420431] Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes https://bugzilla.redhat.com/show_bug.cgi?id=420431 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 04:03 EST --- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 9699f4068a63202643b15a75232e69d8 gkrelltop_2.2.10.orig.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct but good to have it as defattr(-,root,root,-) + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package gkrellm-top-2.2.10-1.fc9 Provides: gkrelltop.so gkrelltopd.so Requires: gkrellm = 2.2.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libglib-2.0.so.0 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 357661] Review Request: sunbird - Mozilla Sunbird Calendar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sunbird - Mozilla Sunbird Calendar https://bugzilla.redhat.com/show_bug.cgi?id=357661 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 04:52 EST --- I've fixed the debuginfo problem with the suggested find. I've also switched to the official tarball, which is now available on the FTP. http://gauret.free.fr/fichiers/rpms/fedora/sunbird/sunbird-0.7-5.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 409401] Review Request: extragear-plasma - Additional plasmoids for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: extragear-plasma - Additional plasmoids for KDE https://bugzilla.redhat.com/show_bug.cgi?id=409401 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 05:00 EST --- Ok now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 409401] Review Request: extragear-plasma - Additional plasmoids for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: extragear-plasma - Additional plasmoids for KDE https://bugzilla.redhat.com/show_bug.cgi?id=409401 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 05:12 EST --- (In reply to comment #18) Ok now. Thx! New Package CVS Request === Package Name: extragear-plasma Short Description: Additional plasmoids for KDE Owners: than,rdieter,kkofler,svahl Branches: InitialCC: Cvsextras Commits: no -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 393421] Review Request: kdebase-workspace - K Desktop Environment - Workspace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdebase-workspace - K Desktop Environment - Workspace https://bugzilla.redhat.com/show_bug.cgi?id=393421 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 05:13 EST --- (In reply to comment #11) cvs done. Package imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 416471] Review Request: xsel -- manipulate the X selection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsel -- manipulate the X selection https://bugzilla.redhat.com/show_bug.cgi?id=416471 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 05:20 EST --- Nothing wrong in using a svn version if this is needed, but if doing so the script (or at least of a command) needed to recreate the tarball should be included in the spec. For instance something along #use svn co http://svn.kfish.org/xsel/trunk/; to download this branch mv trunk xsel-0.9.6 tar cjf xsel-0.9.6.tar.bz2 xsel-0.9.6 to recreate the archive.Note that this is the only existing branch, there is no additional revision information available. However using xsel-0.9.6 as name for the tarball (as you have done ) is a bit confusing, since one might believe this is the stable version (which - on the URL page - has the same name). It would be better in my opinion to name the tarball xsel-0.9.6-svnsomething, as you have done for the src.rpm itself. It would also be useful to explain why are you packing the development version instead of the stable one listed on the project page, especially since the Changelog and NEWS files are identical in the two versions. And maybe poke upstream to update the stable version, 6 years for a devel version is long enough... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 416471] Review Request: xsel -- manipulate the X selection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsel -- manipulate the X selection https://bugzilla.redhat.com/show_bug.cgi?id=416471 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 05:35 EST --- How url should look like is also explained on: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 375871] Review Request: libdvdnav - A library for reading DVD video discs based on Ogle code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libdvdnav - A library for reading DVD video discs based on Ogle code Alias: libdvdnav https://bugzilla.redhat.com/show_bug.cgi?id=375871 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 05:57 EST --- Package Change Request == Package Name: libdvdnav New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 216300] Review Request: chemtool - A program for 2D drawing organic molecules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: chemtool - A program for 2D drawing organic molecules https://bugzilla.redhat.com/show_bug.cgi?id=216300 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 05:54 EST --- Package Change Request == Package Name: chemtool New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 351361] Review Request: ghc-X11-extras - Haskell X11-extras library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ghc-X11-extras - Haskell X11-extras library Alias: ghc-X11-extras https://bugzilla.redhat.com/show_bug.cgi?id=351361 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 05:53 EST --- (In reply to comment #10) ghc681-X11-extras.i386: W: devel-file-in-non-devel-package /usr/lib/X11-extras-0.4/ghc-6.8.1/libHSX11-extras-0.4.a The complete package is a haskell devel package afaik. ghc681-X11-extras.i386: E: script-without-shebang /usr/lib/X11-extras-0.4/ghc-6.8.1/X11-extras.pkg Is this file executable? I will check this later. ghc681-X11-extras.i386: W: devel-file-in-non-devel-package /usr/lib/X11-extras-0.4/ghc-6.8.1/include/XlibExtras.h see above. ghc-X11-extras.i386: W: no-documentation ghc-X11-extras.i386: E: no-binary This is also intended, because the package is only there to make it easier to get the latest package. Nevertheless, it seem that ghc-X11-extras is not needed anymore, at least the latest release of xmonad does not need it, but a newer version of ghc-X11, but I need to do some more research here - or does someone else know more about this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254142] Review Request: OpenSER - Open Source SIP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: OpenSER - Open Source SIP Server https://bugzilla.redhat.com/show_bug.cgi?id=254142 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 06:10 EST --- New prerelease snapshot - 1.3.0pre1 http://peter.fedorapeople.org/openser.spec http://peter.fedorapeople.org/openser-1.3.0-0.1.pre1.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 383271] Review Request: b43-firmware - V4 firmware for Broadcom wireless devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: b43-firmware - V4 firmware for Broadcom wireless devices https://bugzilla.redhat.com/show_bug.cgi?id=383271 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 06:25 EST --- Any news? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421231] New: Review Request: kde-l10n - Internationalization support for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=421231 Summary: Review Request: kde-l10n - Internationalization support for KDE Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://than.fedorapeople.org/kde-l10n.spec SRPM URL: kde-l10m srpm is huge, cannot be uploaded on fedorapeople Description: Internationalization support for KDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 412001] Review Request: ufoai - UFO: Alien Invasion strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ufoai - UFO: Alien Invasion strategy game https://bugzilla.redhat.com/show_bug.cgi?id=412001 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||182235 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 06:48 EST --- - I've noticed that the license file for music states that the author does not wish it to be used in other projects, but no separate licensing is mentioned on the project page or anywhere else so that the same as the whole project, GPLv2+, should be used, imho ... or should I consult [EMAIL PROTECTED] (I'm not a member) You have to use the license of the code itself -- look into source. Consulting with legal team is a good idea, setting FE-legal. - I do not understand why dash-EOF syntax does not work as expected within the wrapper generation ... not a big deal, though :-) - rpmlint complains about missing %build for the data and music packages ... is that mandatory to have this section even if empty? Yes, leaving it empty does not harm. - afaik, rpm does not support optional dependencies, how to suggest installation of ufoai-music together with ufoai without depending on it hard? I don't know of any way to do that. Maybe anyone else? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421241] New: Review Request: php-ZendFramework - Leading open-source PHP framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=421241 Summary: Review Request: php-ZendFramework - Leading open-source PHP framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/8/SPECS/php-ZendFramework.spec SRPM URL: http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/8/SRPMS/php-ZendFramework-1.0.3-1.fc8.src.rpm Description: Extending the art spirit of PHP, Zend Framework is based on simplicity, object-oriented best practices, corporate friendly licensing, and a rigorously tested agile codebase. Zend Framework is focused on building more secure, reliable, and modern Web 2.0 applications web services, and consuming widely available APIs from leading vendors like Google, Amazon, Yahoo!, Flickr, as well as API providers and catalogers like StrikeIron and ProgrammableWeb. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250971] Review Request: ivtv - An iTVC15/16 and CX23415/16 driver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ivtv - An iTVC15/16 and CX23415/16 driver https://bugzilla.redhat.com/show_bug.cgi?id=250971 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||net) --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 07:29 EST --- ping ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250970] Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series https://bugzilla.redhat.com/show_bug.cgi?id=250970 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||net) --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 07:23 EST --- ping ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249212] Review Request: inchi - The IUPAC International Chemical Identifier library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inchi - The IUPAC International Chemical Identifier library https://bugzilla.redhat.com/show_bug.cgi?id=249212 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 08:02 EST --- Package Change Request == Package Name: inchi New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201485] Review Request: openbabel - Chemistry software file format converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openbabel - Chemistry software file format converter https://bugzilla.redhat.com/show_bug.cgi?id=201485 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 08:02 EST --- Package Change Request == Package Name: openbabel New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 08:32 EST --- Mingo isn't the only one (although I'm getting hold of him as well). Of the three places you have noted the possibility of a GPLv2+ option: 2 are not code at all, but rather man pages, documentation no different from a COPYING file. These are not written by Ingo, but rather the project author, Alex Larson, who is no longer here. Of these two man pages, the netdump.8 man page is no longer relevant to the package and should be removed (given that the functionality it documents is no longer present) 1 header file , whos contents are borrowed from the kernel netdump.h header file, which is covered strictly by GPLv2. Clearly this issue is not as cut and dry as you would like to make it out to be. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 09:21 EST --- The header file in question is CLEARLY marked as GPLv2 or later. The GPLv2 or later license is the ONLY license that appears in the source. The text of the GPL says that if a version is specified, then that is the version of the license to be used. The version specified is GPLv2 or later. COPYING does NOT trump this. I honestly still cannot believe we're having this conversation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226467] Merge Review: system-config-rootpassword
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-rootpassword https://bugzilla.redhat.com/show_bug.cgi?id=226467 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||m) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226471] Merge Review: system-config-soundcard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-soundcard https://bugzilla.redhat.com/show_bug.cgi?id=226471 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 09:37 EST --- Ok. I assume you will take care of above problem in next release. I will now approve this. In case anyone find above problem is not fixed in next release of this package, kindly open new bug or mail to fedora-devel list. I don't want to wait more on this review now. Will wait for another week for any update otherwise will CLOSE this then. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 399941] Review Request: amanith - Crossplatform framework for 2d/3d vector graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amanith - Crossplatform framework for 2d/3d vector graphics https://bugzilla.redhat.com/show_bug.cgi?id=399941 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 403911] Review Request: aspell-ml - Malayalam wordlist for GNU Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aspell-ml - Malayalam wordlist for GNU Aspell https://bugzilla.redhat.com/show_bug.cgi?id=403911 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 09:42 EST --- Rajeesh, I would like to sponsor you provided you will start posting preliminary (unofficial) reviews to other new package review requests. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 09:57 EST --- The version specified is GPLv2 or later. COPYING does NOT trump this. So I've copied you on the email I sent to red hat legal regarding this, as well as on the note to Ingo requesting clarification on his license (given that its included in a project listed as GPLv2 only). I'll wait to see what they say. If you can point me to a documentation from some legal authority that clearly states the COPYING file is irrelevant when a conflicting statement is contained in a piece of code, I'll consider changing it. You had mentioned that you had discussed this at length with Mark W., I imagine thats written down somewhere. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 399941] Review Request: amanith - Crossplatform framework for 2d/3d vector graphics
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: amanith - Crossplatform framework for 2d/3d vector
graphics
https://bugzilla.redhat.com/show_bug.cgi?id=399941
--- Additional Comments From [EMAIL PROTECTED] 2007-12-12 10:06 EST ---
For 0.3-2
* Dependency for -devel package
- Please check the dependency (Requires) for -devel subpackage.
For example, %_includedir/%name/gopenglext.h contains:
32 #include GL/glew.h
33 // this inclusion to make glew linking working with some platforms (ex:
Mac)
34 #include amanith/gelement.h
35 #ifdef G_OS_WIN
36 #include GL/wglew.h
37 #endif
This means amanith-devel should have Requires: glew-devel.
* SourceURL
- I recommend to use %{version} tag so that you probably don't have to
change SourceURL when the new version is released.
! Some misc
-
export AMANITHDIR=${RPM_BUILD_DIR}/%{name}
-
- I like: export AMANITHDIR=$(pwd) (not a blocker)
* Documents
- Usually the file INSTALL is needed for people who want to build
and install the package by themselves and is not needed for people
who install the package using rpm.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250970] Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series https://bugzilla.redhat.com/show_bug.cgi?id=250970 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |net)| --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 09:59 EST --- Note that the timestamps are not original. When I wrote the license on Haupauge's behalf I also asked if I could pick the original files and that is not possible due to internal reasons. So the timestamps that the files have on both of my sites, ivtvdriver.org and atrpms.net are the ones from the extraction time, not any upstream time. Despite of that I agree it is better for people learning by reading specfiles to keep timestamps otherwise they will be copying wrong idioms. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 338681] Review Request: eboard - ICS chess board interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eboard - ICS chess board interface https://bugzilla.redhat.com/show_bug.cgi?id=338681 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|CLOSED Resolution||NOTABUG Flag|needinfo?([EMAIL PROTECTED])| --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 10:17 EST --- Once closing as NOTABUG. If someone wants to import this package into Fedora, please file a new review request, thanks!! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 323441] Review Request: trousers - The open-source TCG software stack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trousers - The open-source TCG software stack https://bugzilla.redhat.com/show_bug.cgi?id=323441 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO Flag||needinfo?([EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 10:18 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: PyAmanith - Python bindings for Amanith https://bugzilla.redhat.com/show_bug.cgi?id=399951 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||399941 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 399941] Review Request: amanith - Crossplatform framework for 2d/3d vector graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amanith - Crossplatform framework for 2d/3d vector graphics https://bugzilla.redhat.com/show_bug.cgi?id=399941 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||399951 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226471] Merge Review: system-config-soundcard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-soundcard https://bugzilla.redhat.com/show_bug.cgi?id=226471 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 10:16 EST --- *ANY* version of redhat-config-soundcard is really obsoleted. redhat-config-soundcard just should not be shipped in Fedora. /usr/share/system-config-soundcard/system-config-soundcard.logger - it's just a cosmetic error and i'll fix it someday. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 323441] Review Request: trousers - The open-source TCG software stack
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: trousers - The open-source TCG software stack
https://bugzilla.redhat.com/show_bug.cgi?id=323441
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEEDINFO|NEW
Flag|needinfo?([EMAIL PROTECTED])|
--- Additional Comments From [EMAIL PROTECTED] 2007-12-12 11:07 EST ---
(In reply to comment #22)
Well, I just tried to rebuild 3.3.1-2, however it again failed.
http://koji.fedoraproject.org/koji/taskinfo?taskID=267051
You have to patch against Makefile.in. Patching against Makefile.am
does not change anything (unless you call automake or so, however
please avoid to use autotools when possible).
Ok, I'll patch Makefile.in...
* By the way:
- Not a big problem, however your comments
--
%build
%configure
make %{?_smp_mflags}
# - FROM THIS LINE
# $1 is the number of entries in the RPM database for the package after the
step is
# executed. So in the post step, if $1 is 1, then this is the first time we've
been
# installed. If its 2, we're upgrading.
# - TO THIS LINE
%post
/sbin/ldconfig
-
is in %build section.
Do I need to fix this then?
- And I usually write in the order of %prep, %build, %install, %clean,
%pre, %post, %preun, and %postun (I am only saying my habit).
Ok, do I need to change it then?
By the way, where is %clean section?
I removed it in response to your comment #13:
- Please remove unneeded
[ ${RPM_BUILD_ROOT} != / ] [ -d ${RPM_BUILD_ROOT} ]
Should I put it back in the %clean section?
- calling ldconfig for -devel package is not needed.
Yep, I'll take this out.
- I recomment to use http://trousers.sourceforge.net/
for URL.
Ok, I'll change this when I update for Makefile.in.
Kent
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 323441] Review Request: trousers - The open-source TCG software stack
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: trousers - The open-source TCG software stack
https://bugzilla.redhat.com/show_bug.cgi?id=323441
--- Additional Comments From [EMAIL PROTECTED] 2007-12-12 11:21 EST ---
(In reply to comment #24)
(In reply to comment #22)
* By the way:
- Not a big problem, however your comments
--
%build
%configure
make %{?_smp_mflags}
# - FROM THIS LINE
# $1 is the number of entries in the RPM database for the package after the
step is
# executed. So in the post step, if $1 is 1, then this is the first time
we've
been
# installed. If its 2, we're upgrading.
# - TO THIS LINE
%post
/sbin/ldconfig
-
is in %build section.
Do I need to fix this then?
I recomment to fix this.
- And I usually write in the order of %prep, %build, %install, %clean,
%pre, %post, %preun, and %postun (I am only saying my habit).
Ok, do I need to change it then?
I recomment to fix this, as this order is what rpm actually does.
By the way, where is %clean section?
I removed it in response to your comment #13:
- Please remove unneeded
[ ${RPM_BUILD_ROOT} != / ] [ -d ${RPM_BUILD_ROOT} ]
What I said is exactly
--
[ ${RPM_BUILD_ROOT} != / ] [ -d ${RPM_BUILD_ROOT} ]
--
should be removed and I didn't say that %clean section should
be removed :)
Should I put it back in the %clean section?
Absolutely.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421871] New: Review Request: libvirt-cim - A CIM provider for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=421871 Summary: Review Request: libvirt-cim - A CIM provider for libvirt Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://static.danplanet.com/pkg/fedora-9/libvirt-cim.spec SRPM URL: http://static.danplanet.com/pkg/fedora-9/libvirt-cim-0.1-1.fc9.src.rpm Description: libvirt-cim is a CIM provider for virtualization platforms supported by libvirt. It enables remote enterprise-class management of virtual machines. Note: We have not made a formal code release yet. We will do so soon and will update the spec with a URL at that point. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=289649 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226471] Merge Review: system-config-soundcard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-soundcard https://bugzilla.redhat.com/show_bug.cgi?id=226471 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 11:13 EST --- Thanks for your quick reply. unversioned-explicit-obsoletes is ok to ignore. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248277] Review Request: mt-daapd - An iTunes-compatible media server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mt-daapd - An iTunes-compatible media server https://bugzilla.redhat.com/show_bug.cgi?id=248277 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 11:42 EST --- Hello, I have tried to build it in koji, but it fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=289680 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|201449 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 11:29 EST --- Spec URL: http://people.redhat.com/nhorman/rpms/netdump-server.spec SRPM URL: http://people.redhat.com/nhorman/rpms/netdump-server-0.7.16-20.fc8.src.rpm As per the legal response to this issue, I've posted an update to this rpm. Same as previous, with additions to all the files to make them unambiguously GPLv2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 357661] Review Request: sunbird - Mozilla Sunbird Calendar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sunbird - Mozilla Sunbird Calendar https://bugzilla.redhat.com/show_bug.cgi?id=357661 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 11:54 EST --- (In reply to comment #12) *** Bug 312901 has been marked as a duplicate of this bug. *** Ehh.. That bug is about a hardware problem, black screen when returning from suspend on certain laptops... Number typo? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||182235, 235705 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 11:42 EST --- Blocking FE-LEGAL: need third-party opinion on whether the code and licensing mash-up upstream uses is OK with us (and if not how should upstream fix it) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|248013 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] New: Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=421921 Summary: Review Request: argyllcms - ICC compatible color management system Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://nim.fedorapeople.org/argyllcms/argyllcms.spec SRPM URL: http://nim.fedorapeople.org/argyllcms/argyllcms-0.70-0.1.Beta7.fc9.src.rpm Description: The Argyll color management system supports accurate ICC profile creation for scanners, CMYK printers, film recorders and calibration and profiling of displays. Spectral sample data is supported, allowing a selection of illuminants observer types, and paper fluorescent whitener additive compensation. Profiles can also incorporate source specific gamut mappings for perceptual and saturation intents. Gamut mapping and profile linking uses the CIECAM02 appearance model, a unique gamut mapping algorithm, and a wide selection of rendering intents. It also includes code for the fastest portable 8 bit raster color conversion engine available anywhere, as well as support for fast, fully accurate 16 bit conversion. Device color gamuts can also be viewed and compared using a VRML viewer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 234667] Review Request: dwarves - DWARF Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dwarves - DWARF Tools https://bugzilla.redhat.com/show_bug.cgi?id=234667 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 11:57 EST --- Latest specfile is at: http://oops.ghostprotocols.net:81/acme/dwarves/rpm/SPECS/dwarves.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 12:50 EST --- I concurr. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review- |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 12:46 EST --- License matches the code now. Setting this review to +. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 13:34 EST --- Created an attachment (id=285991) -- (https://bugzilla.redhat.com/attachment.cgi?id=285991action=view) Patch to fix buffer overflow The 'dispread' program aborts at startup due to a buffer overflow being detected by GLibc. The attached patch fixes it to use strlen() instead of sizeof() -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 285351] Review Request: xcalib - Tiny monitor calibration loader for X.org Review Request: xcalib - Tiny monitor calibration loader for X.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcalib - Tiny monitor calibration loader for X.org Review Request: xcalib - Tiny monitor calibration loader for X.org https://bugzilla.redhat.com/show_bug.cgi?id=285351 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 13:48 EST --- I'm not sure I understand the legal blocker here... can you be more specific? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 412001] Review Request: ufoai - UFO: Alien Invasion strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ufoai - UFO: Alien Invasion strategy game https://bugzilla.redhat.com/show_bug.cgi?id=412001 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 13:41 EST --- That music use restriction would conflict with the GPL, so I suspect that this is not the correct license for the music files. Ask upstream, see if they can clarify the license on the music files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 299171] Review Request: eclipse-slide - SELinux Polciy IDE Eclipse Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-slide - SELinux Polciy IDE Eclipse Plugin https://bugzilla.redhat.com/show_bug.cgi?id=299171 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|182235 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 13:39 EST --- Looks ok to me. Lifting FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:03 EST --- Created an attachment (id=286051) -- (https://bugzilla.redhat.com/attachment.cgi?id=286051action=view) Fix buffer overflow in ICC code The iccdump program abrts with a buffer overflow detected by glibc in the ICC formatting routines. The attached patch fixes this bug in icc code -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netdump-server - netdump crash recovery capture server https://bugzilla.redhat.com/show_bug.cgi?id=378791 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||248013 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420931] Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter https://bugzilla.redhat.com/show_bug.cgi?id=420931 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:09 EST --- Picking up for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420931] Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter https://bugzilla.redhat.com/show_bug.cgi?id=420931 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:24 EST --- Spec URL: http://ausil.us/packages/libertas-usb8388-firmware.spec SRPM URL: http://ausil.us/packages/libertas-usb8388-firmware-5.110.20.p47-2.fc8.src.rpm fix typo in install -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420431] Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes https://bugzilla.redhat.com/show_bug.cgi?id=420431 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:19 EST --- New Package CVS Request === Package Name: gkrellm-top Short Description: GKrellM plugin which shows 3 most CPU intensive processes Owners: robert Branches: F-7 F-8 EL-4 EL-5 InitialCC: Cvsextras Commits: no -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 249212] Review Request: inchi - The IUPAC International Chemical Identifier library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inchi - The IUPAC International Chemical Identifier library https://bugzilla.redhat.com/show_bug.cgi?id=249212 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:33 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 375871] Review Request: libdvdnav - A library for reading DVD video discs based on Ogle code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libdvdnav - A library for reading DVD video discs based on Ogle code Alias: libdvdnav https://bugzilla.redhat.com/show_bug.cgi?id=375871 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:33 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 216300] Review Request: chemtool - A program for 2D drawing organic molecules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: chemtool - A program for 2D drawing organic molecules https://bugzilla.redhat.com/show_bug.cgi?id=216300 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:32 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420431] Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes https://bugzilla.redhat.com/show_bug.cgi?id=420431 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:37 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420931] Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter https://bugzilla.redhat.com/show_bug.cgi?id=420931 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:38 EST --- This will be brief, since there's not really that much to review. :-) - MD5SUM matches upstream, as well as the self-contained .md5 file. - LICENSE looks reasonable enough. - Driver is in kernel RPM, so binary-only firmware is permitted. - Package builds in mock. - rpmlint has no complaints. I don't have hardware to test, but I'm sure you've verified that side of things. By the power vested in me by my sponsor, I now pronounce this package APPROVED. You may now request CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:55 EST --- I'm on the i386 so the 'sizeof(buf)' flaw would have come out at '4' for me, but '8' for you on x86_64. The '8' bytes was probably large enough to hide the bug. The iccdump bug is variable depending on the data in the ICC file it is run against -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: argyllcms - ICC compatible color management system
https://bugzilla.redhat.com/show_bug.cgi?id=421921
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |NEEDINFO
Flag||needinfo?([EMAIL PROTECTED]
||poste.net)
--- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:57 EST ---
Review based on official guideline list:
MUST: rpmlint must be run on every package.
$ rpmlint rpm/RPMS/i386/argyllcms-0.70-*
$ rpmlint argyllcms-0.70-0.1.Beta7.fc9.src.rpm
argyllcms.src: E: unknown-key GPG#3b29f20d
- PASS GPG error is harmless
MUST: The package must be named according to the Package Naming Guidelines.
- PASS
MUST: The spec file name must match the base package %{name}
- PASS
MUST: The package must meet the Packaging Guidelines.
- PASS
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
cgats/License.txt - BSD-like
doc/License.txt - GPLv3+
gamut/License.txt - GPLv3+
icc/License.txt - BSD-like
imdi/License.txt- GPLv3+
License.txt - GPLv3+
link/License.txt- GPLv3+
numlib/License.txt - GPLv3+
plot/License.txt- GPLv3+
profile/License.txt - GPLv3+
render/License.txt - GPLv3+
rspl/License.txt- GPLv3+
scanin/License.txt - GPLv3+
spectro/License.txt - GPLv3+
target/License.txt - GPLv3+
tweak/License.txt - GPLv3+
xicc/License.txt- GPLv3+
Links against libtiff (libtiff license - BSD-like) and libusb (LGPLv2+)
- VERIFY - Legal should verify text of the cgats/License.txt icc/License.txt
BSD-like files
MUST: The License field in the package spec file must match the actual license.
- FAIL - Should be 'GPLv3+ and BSD-like' instead of merely 'GPLv3+'
MUST: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
- FAIL - %doc should include the cgats/License.txt and icc/License.txt files
too
MUST: The spec file must be written in American English.
- PASS
MUST: The spec file for the package MUST be legible.
- PASS
MUST: The sources used to build the package must match the upstream source
- PASS md5sum = cfcfb4d4cd1663ae7b87a68e5f957cee
MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
- PASS built on i686 x86_64
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
- PASS N/A
MUST: All build dependencies must be listed in BuildRequires
- PASS
MUST: The spec file MUST handle locales properly
- PASS N/A
MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
- PASS N/A
MUST: If the package is designed to be relocatable, the packager must state this
fact in the request for review
- PASS N/A
MUST: A package must own all directories that it creates.
- PASS - recommend changing to use an explicit %dir though, eg
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*
MUST: A package must not contain any duplicate files in the %files listing.
- PASS
MUST: Permissions on files must be set properly.
- PASS
MUST: Each package must have a %clean section
- PASS
MUST: Each package must consistently use macros
- PASS
MUST: The package must contain code, or permissable content
- PASS
MUST: Large documentation files should go in a -doc subpackage
- PASS
MUST: If a package includes something as %doc, it must not affect the runtime of
the application
- PASS
MUST: Header files must be in a -devel package.
- PASS N/A
MUST: Static libraries must be in a -static package.
- PASS N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
- PASS N/A
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package.
- PASS N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
- PASS N/A
MUST: Packages must NOT contain any .la libtool archives
- PASS N/A
MUST: Packages containing GUI applications must include a %{name}.desktop file
- PASS N/A
MUST: Packages must not own files or directories already owned by other packages
- PASS For the icclink clash I
[Bug 383271] Review Request: b43-firmware - V4 firmware for Broadcom wireless devices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: b43-firmware - V4 firmware for Broadcom wireless
devices
https://bugzilla.redhat.com/show_bug.cgi?id=383271
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:42 EST ---
(In reply to comment #8)
(In reply to comment #7)
Is ExclusiveArch appropriate for a noarch package?
We use ExcludeArch to avoid shipping firmware packages on arches where they
don't make sense. For example, iwl3945-firmware has:
# This is so that the noarch packages don't appear for these archs
ExcludeArch: ppc ppc64
The b43{,legacy} driver is available for ppc, ppc64, sparc64, alpha...you can
get a Broadcom chipset into anything with PCI. Why should we limit where this
package is available? With hardlinks it's not really any more burden to
mirrors.
(Great, now I need to go see if it actually works in any of those...)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 415211] Review Request: WebKit - Web content engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: WebKit - Web content engine library Alias: WebKit https://bugzilla.redhat.com/show_bug.cgi?id=415211 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:53 EST --- WebKit-1.0.0-0.3.svn28482.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 415211] Review Request: WebKit - Web content engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: WebKit - Web content engine library Alias: WebKit https://bugzilla.redhat.com/show_bug.cgi?id=415211 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||ERRATA Fixed In Version||1.0.0-0.3.svn28482.fc7 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201485] Review Request: openbabel - Chemistry software file format converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openbabel - Chemistry software file format converter https://bugzilla.redhat.com/show_bug.cgi?id=201485 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:31 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:44 EST --- Many thanks for the patches. As I wrote in my mail, there are probably several such problems in upstream's codebase, since it has not been widely built (Mandriva hid them by disabling FORTIFY_SOURCE), and I'm probably not the best qualified to fix them. The few utilities I tested didn't segfault on x86_64, are you building for another arch or was I incredibly lucky? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 415211] Review Request: WebKit - Web content engine library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: WebKit - Web content engine library Alias: WebKit https://bugzilla.redhat.com/show_bug.cgi?id=415211 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 14:57 EST --- WebKit-1.0.0-0.3.svn28482.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 320421] Review Request: cwrite - console editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cwrite - console editor https://bugzilla.redhat.com/show_bug.cgi?id=320421 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:16 EST --- (In reply to comment #24) I've read thoroughly several approved packages, I will try to assist in a package pre-review, following the: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines I will try to co-operate in bug 248678 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 422381] New: Review Request: vdr-tvonscreen - The tvonscreen plugin for VDR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=422381 Summary: Review Request: vdr-tvonscreen - The tvonscreen plugin for VDR Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://vpv.fedorapeople.org/packages/vdr-tvonscreen.spec SRPM URL: http://vpv.fedorapeople.org/packages/vdr-tvonscreen-1.0.141-0.1.fc8.src.rpm Description: This plugin shows the EPG data in the typical way a TV magazine does. The channels are shown from left to right, 3 on one screen. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 323441] Review Request: trousers - The open-source TCG software stack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trousers - The open-source TCG software stack https://bugzilla.redhat.com/show_bug.cgi?id=323441 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:28 EST --- Latest fixes here: http://trousers.sourceforge.net/fedora_submit6/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420931] Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter https://bugzilla.redhat.com/show_bug.cgi?id=420931 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:27 EST --- New Package CVS Request === Package Name: libertas-usb8388-firmware Short Description: Firmware for Marvell Libertas USB 8388 Network Adapter Owners: ausil Branches: F-7 F-8 InitialCC: Cvsextras Commits: cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 422381] Review Request: vdr-tvonscreen - The tvonscreen plugin for VDR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vdr-tvonscreen - The tvonscreen plugin for VDR https://bugzilla.redhat.com/show_bug.cgi?id=422381 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:32 EST --- I'm adding Ville Skyttä's email as CC here, because he is the VDR package maintainer. Ville, if you have the time, could you review this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 416471] Review Request: xsel -- manipulate the X selection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsel -- manipulate the X selection https://bugzilla.redhat.com/show_bug.cgi?id=416471 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:27 EST --- Yes, there is a reason to build from svn. The release tarball has man in /usr/man instead of /usr/share/man error: Installed (but unpackaged) file(s) found: /usr/man/man1/xsel.1x.gz ls /usr/man ls: cannot access /usr/man: No such file or directory I will re-write the spec file and change tarball name today. Thanks. Contacting the author re. this bug report and differences in /usr/man and /usr/share/man and maybe he can poke upstream since I don't have access. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420931] Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter https://bugzilla.redhat.com/show_bug.cgi?id=420931 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:27 EST --- thanks for the review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 248678] Review Request: R-BSgenome.Dmelanogaster.FlyBase.r51 - osophila melanogaster genome (FlyBase r5.1)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: R-BSgenome.Dmelanogaster.FlyBase.r51 - osophila melanogaster genome (FlyBase r5.1) https://bugzilla.redhat.com/show_bug.cgi?id=248678 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:15 EST --- (In reply to comment #1) I am not a sponsor, I would like to assist in a pre-review. Please supplly correct spec/srpm URL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 323441] Review Request: trousers - The open-source TCG software stack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trousers - The open-source TCG software stack https://bugzilla.redhat.com/show_bug.cgi?id=323441 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:47 EST --- I just built this as a user in my private sandbox and had no problems with that (related to the tss user/group). I also noticed that when I installed the built rpms the tcsd service was no longer started automatically. I don't see any blocking issues, but I wonder if there is a use for the trousers-static rpm that gets built? I know static libraries need to be packaged separately, but I was wondering if there were any users of these static libraries or if they could be omitted? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 16:26 EST --- The only GPLv2 file i see is spectro/filmread.c and this merely says * This material is licenced under the GNU GENERAL PUBLIC LICENSE :- * see the License2.txt file for licencing details. According to the licensing guidelines http://fedoraproject.org/wiki/Licensing A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include. So, IMHO, spectro/filmread.c is under *any* version of the GPL and thus trivially compatible with the GPLv3 used by the rest of the code. Even if it can be argued that it is GPLv2+, then that is still compatible with GPLv3+ As for the cgats / icc directory stuff, I'd recommend mailing the [EMAIL PROTECTED] with text of the license to confirm whether it can be classed as 'BSD'. Yes, BSD-Like is not valid - I should have just said GPLv3+ and BSD for the License: tag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|NEW Flag|needinfo?([EMAIL PROTECTED]| |poste.net) | --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 15:47 EST --- - VERIFY - Legal should verify text of the cgats/License.txt icc/License.txt BSD-like files Those bits are not linked against anything else, and not exported by Argyll since it's all statically linked. So the only compatibility problem we may have would be between the GPLv3 and Argyll, and since their common author judges it's ok, exposing those licenses to users seems rather useless to me. But for legal to judge. The bits I'm actually worried against are the GPLv2 files in spectro linked against all this GPLv3 codebase, since they are *not* written by the same author. It's rather unclear to me if they're GPLv2+ and Graeme W. Gill is pedantic in exposing their license, or not. MUST: The License field in the package spec file must match the actual license. - FAIL - Should be 'GPLv3+ and BSD-like' instead of merely 'GPLv3+' If you want but BSD-like is not a valid license - FAIL - %doc should include the cgats/License.txt and icc/License.txt files too OK - PASS - recommend changing to use an explicit %dir My preference usually too, must have been exposed to too many line counters to not have done it this way from the beginning - PASS For the icclink clash I recommend changing 'argyllcms-icclink' to instead be 'icclink-argyll' so it tab-completes under shell Good idea - FAIL Needs 2 aforementioned buffer overflow patches More patches like that welcome :p - the %changelog section contains a number of unusual UTF-8 characters SPECS are UTF-8, and changelog in particular can contain UTF-8 names (which is the case there), so asciifying presents no interest Thanks a lot for this timely review! New files at the same place as previously -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239474] Review Request: libkdcraw - A library for decoding RAW picture files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libkdcraw - A library for decoding RAW picture files https://bugzilla.redhat.com/show_bug.cgi?id=239474 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 16:14 EST --- Package Change Request == Package Name: libkdcraw New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 285351] Review Request: xcalib - Tiny monitor calibration loader for X.org Review Request: xcalib - Tiny monitor calibration loader for X.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcalib - Tiny monitor calibration loader for X.org Review Request: xcalib - Tiny monitor calibration loader for X.org https://bugzilla.redhat.com/show_bug.cgi?id=285351 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 16:35 EST --- Tom - The same problem is more described in https://bugzilla.redhat.com/show_bug.cgi?id=239936#c16 In one world I wonder if we can allow ICC profiles? Some icc profiles are Copyrighted but even Adobe standard icc profiles which is commonly used may be a problem. Instead we may need to use a compatible with Adobe icc sRGB profile that will follow the same specification. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 421921] Review Request: argyllcms - ICC compatible color management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 16:43 EST --- (In reply to comment #8) I'd recommend mailing the [EMAIL PROTECTED] There should be no need I blocked FE-LEGAL already So, you agree the there are only legal aspects left to do in the review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 412531] Review Request: Kitsune - Mathematical game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Kitsune - Mathematical game https://bugzilla.redhat.com/show_bug.cgi?id=412531 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 16:49 EST --- All issues fixed (just a little bit problem with the encoding, after the sed script, Firefox doesn't want to open the html files). Thanks to tibbs on fedora-devel to fix source issue. Spec URL: http://home.scarlet.be/~tsi30161/kitsune.spec SRPM URL: http://home.scarlet.be/~tsi30161/kitsune-2.0-3.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222338] Review Request: initng-conf-gtk - InitNG configuration and control utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility https://bugzilla.redhat.com/show_bug.cgi?id=222338 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 416471] Review Request: xsel -- manipulate the X selection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xsel -- manipulate the X selection https://bugzilla.redhat.com/show_bug.cgi?id=416471 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 17:38 EST --- Revised files are in http://thenerdshow.com/rpm/ %changelog * Wed Dec 12 2007 Henry Kroll nospam[AT]thenerdshow.com - 0.9.6-svn20071212 - Version upgrade svn due to differing man dir locations in configure script (and missing autogen.sh). Fix duplicate BuildRequires. Parallel make. User Comment: I find xsel to be extremely handy when used with simple scripts that are bound to hot keys or mouse gestures. ctrlaltshiftd dictionary lookup on highlighted word(s) ctrlaltshifts search the web for highlighted word(s) ctrlaltshiftt festival -tts (text to speech) on highlighted word(s)... I have been using it for 2 months with no problems that I am aware of. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 188623] Review Request: SOAPpy - Full-featured SOAP library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SOAPpy - Full-featured SOAP library for Python https://bugzilla.redhat.com/show_bug.cgi?id=188623 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 18:02 EST --- Package Change Request == Package Name: SOAPpy New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252257] Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed filesystem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed filesystem https://bugzilla.redhat.com/show_bug.cgi?id=252257 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 18:25 EST --- I would also like to see this added. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222338] Review Request: initng-conf-gtk - InitNG configuration and control utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: initng-conf-gtk - InitNG configuration and control
utility
https://bugzilla.redhat.com/show_bug.cgi?id=222338
--- Additional Comments From [EMAIL PROTECTED] 2007-12-12 18:23 EST ---
Sorry for taking so long, Daniel.
You haven't posted a link to a new srpm file but I assume the old location is
still valid, hence I'm using
http://download.initng.org/initng-gui/initng-conf-gtk/initng-conf-gtk-0.5.1-1.fc8.src.rpm
for the continued review.
Following issues remain or are new:
* rpmlint (on srpm):
- initng-conf-gtk.src: W: strange-permission initng-conf-gtk.spec 0755
Please remove the executable bit from the spec file.
* The sources used to build the package matches the upstream source
28b43e0dc8e5525a9c12c7f597f6e5829223f57d initng-conf-gtk-0.5.1.tar.gz
E Consistent use of macros:
Please use %{__rm} for rm and %{__ln_s} for 'ln -s', %{__mkdir} for mkdir,
%{__make} for make, ${_bindir} for /usr/bin
E Timestamps:
To preserve timestamps on files upon copying, always add the -p option to both
cp and install, additionally change the 'make install' to
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=%{__install} -p
* No header files
* No static libs
* No library files
E Scriptlets are NOT sane (yet):
- gtk-update-icon-cache must be executed with '|| :' at the end (instead of ';')
so %post doesn't fail completely if something goes wrong
- update-desktop-database is missing in %post
E Desktop file handled properly (vendor id):
If a package specifies no vendor, use fedora as vendor id, see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6
Thus what Yuichi wrote in Comment #2 is wrong.
E Whitespace in spec file:
Although rpmlint doesn't complain about this, you're mixing up spaces and tabs
in your spec file scripts. Please use one of them consistently.
* Package does not own files or directories already owned by other packages
E Packages owns all directories that it creates:
file /usr/share/initng-conf-gtk is not owned by any package
Please replace
{_datadir}/%{name}/%{name}.glade
with
{_datadir}/%{name}
Aside from the issues left, the new source package in fact produces a working
program.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420431] Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gkrellm-top - GKrellM plugin which shows 3 most CPU intensive processes https://bugzilla.redhat.com/show_bug.cgi?id=420431 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||422691 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 18:38 EST --- 37407 (gkrellm-top): Build on target fedora-5-epel succeeded. Package: gkrellm-top-2.2.10-1.fc7 Tag: dist-fc7-updates-candidate Status: complete Package: gkrellm-top-2.2.10-1.fc8 Tag: dist-f8-updates-candidate Status: complete Package: gkrellm-top-2.2.10-1.fc9 Tag: dist-f9 Status: complete -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 285351] Review Request: xcalib - Tiny monitor calibration loader for X.org Review Request: xcalib - Tiny monitor calibration loader for X.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcalib - Tiny monitor calibration loader for X.org Review Request: xcalib - Tiny monitor calibration loader for X.org https://bugzilla.redhat.com/show_bug.cgi?id=285351 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 20:35 EST --- Any ICC profiles which are under this license: http://www.adobe.com/support/downloads/iccprofiles/icc_eula_unix_end.html Cannot be distributed in Fedora, as it explicitly says: Adobe also grants you the rights to distribute the Software only (a) as embedded within digital image files and (b) on a standalone basis. No other distribution of the Software is allowed; including, without limitation, distribution of the Software when incorporated into or bundled with any application software. You may not modify the Software. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 285351] Review Request: xcalib - Tiny monitor calibration loader for X.org Review Request: xcalib - Tiny monitor calibration loader for X.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xcalib - Tiny monitor calibration loader for X.org Review Request: xcalib - Tiny monitor calibration loader for X.org https://bugzilla.redhat.com/show_bug.cgi?id=285351 --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 21:11 EST --- There is also a : http://www.adobe.com/support/downloads/iccprofiles/icc_eula_unix_dist.html I'm not sure I understand very well. Does that mean we need to bundle the adobe icc profile alone (b) ? The profile seems redistributable from the adobe point of view but maybe the problem is with: You may not modify the Software. So we cannot consider this as FOSS. But actually modifying the software is pointless because, this does not make sense for the modified profile to have the same name. Instead we can generate (I don't know how to do yet.) an icc profile with the same spec as Adobe icc. Then it can be named compatible with Adobe sRGB and it will not come from Adobe.inc (which is the only way to have the original Adobe sRGB icc profile)... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 188623] Review Request: SOAPpy - Full-featured SOAP library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SOAPpy - Full-featured SOAP library for Python https://bugzilla.redhat.com/show_bug.cgi?id=188623 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 21:10 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 420931] Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libertas-usb8388-firmware - firmware for libertas usb8388 wireless adapter https://bugzilla.redhat.com/show_bug.cgi?id=420931 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 299171] Review Request: eclipse-slide - SELinux Polciy IDE Eclipse Plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: eclipse-slide - SELinux Polciy IDE Eclipse Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=299171
--- Additional Comments From [EMAIL PROTECTED] 2007-12-12 21:51 EST ---
Well,
For 1.3.5-0.1.svn2022:
* Release number
- Please use 0.X.svn%{?dist} to avoid EVR
(Epoch-Version-Release) path problem between different branches.
Okay.
This package (eclipse-slide) is APPROVED by me
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 299171] Review Request: eclipse-slide - SELinux Polciy IDE Eclipse Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-slide - SELinux Polciy IDE Eclipse Plugin https://bugzilla.redhat.com/show_bug.cgi?id=299171 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239474] Review Request: libkdcraw - A library for decoding RAW picture files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libkdcraw - A library for decoding RAW picture files https://bugzilla.redhat.com/show_bug.cgi?id=239474 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-12 22:04 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
