[Bug 292121] Review Request: boxes - Draw any kind of box around some given text

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boxes - Draw any kind of box around some given text


https://bugzilla.redhat.com/show_bug.cgi?id=292121


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 03:07 EST ---
New Package CVS Request
===
Package Name: boxes
Short Description: Draw any kind of box around some given text
Owners: jhrozek
Branches: F-7 F-8
InitialCC: none
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427481] Review Request: documentation-devel - Documentation tool chain

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: documentation-devel - Documentation tool chain


https://bugzilla.redhat.com/show_bug.cgi?id=427481





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 03:26 EST ---
The upstream name is not right to begin with. I don't know about
a precedent, but I myself ask upstream to change their name when it is
to short or too generic (I did that for g2lib, so far they haven't 
acted, but I did what I could). I also made that recommendation for ht.

But here it is easily done since you are also upstream. The name
of the package is part of the 'quality' of the package and having
a name too generic seems to be to me a good enough reason not to
include it in fedora. There are no precise guidelines about what
makes a package unsuitable for inclusion in fedora (except for license
guidelines), but having a package that abuses the shared 
namespaces (package name, library name, binary in /usr/bin name)
is in my opinion a reason sufficient to block a release if upstream is
under the fedora umbrella.

In any case please try to think at your software name from the 
perspective of free software community (other developers and 
users) and ask yourself, is my package rightly named?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - PowerTOP is a Linux tool that helps you 
find those programs that are misbehaving while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] New: Review Request: powertop - PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=428103

   Summary: Review Request: powertop - PowerTOP is a Linux tool that
helps you find those programs that are misbehaving while
your computer is idle.
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://huzaifas.fedorapeople.org/spec/powertop.spec
SRPM URL: http://huzaifas.fedorapeople.org/srpms/powertop-1.9-0.fc8.src.rpm
Description: 

Computer programs can make your computer use more power.
PowerTOP is a Linux tool that helps you find those programs that are 
misbehaving while your computer is idle.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 292121] Review Request: boxes - Draw any kind of box around some given text

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boxes - Draw any kind of box around some given text


https://bugzilla.redhat.com/show_bug.cgi?id=292121





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 03:06 EST ---
Thanks for all the work done on this review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - PowerTOP is a Linux tool that helps you 
find those programs that are misbehaving while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427273] Review Request: firstaidkit - System Rescue Tool

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firstaidkit - System Rescue Tool


https://bugzilla.redhat.com/show_bug.cgi?id=427273





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 03:47 EST ---
I did some SPEC modifications. I am attaching modified SPEC below. I have not
added plugins subpackage yet. 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427273] Review Request: firstaidkit - System Rescue Tool

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firstaidkit - System Rescue Tool


https://bugzilla.redhat.com/show_bug.cgi?id=427273





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 03:48 EST ---
Created an attachment (id=291123)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=291123action=view)
Modified SPEC


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - PowerTOP is a Linux tool that helps you 
find those programs that are misbehaving while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 03:49 EST ---
All the changes have been mode as required.

Spec URL: http://huzaifas.fedorapeople.org/spec/powertop.spec
SRPM URL: http://huzaifas.fedorapeople.org/srpms/powertop-1.9-0.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428007] Package review: vixie-cron-ng

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: vixie-cron-ng


https://bugzilla.redhat.com/show_bug.cgi?id=428007





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 03:53 EST ---
to [3] because I can't say selinux and pam in fcron is ok. I didn't test many
other features and the main reason is the vixie-cron-ng will support inotify,
which is needed for battery saving. I don't see anything ancient on using
inotify ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - PowerTOP is a Linux tool that helps you 
find those programs that are misbehaving while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 04:01 EST ---
Make the habit of increasing release tag for each newly posted SRPM otherwise it
may confuse reviewer.

Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
7e2cd799941350a45586edac43760ac9  powertop-1.9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - PowerTOP is a Linux tool that helps you 
find those programs that are misbehaving while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 03:41 EST ---
Suggestions
1) change Source URL look like to
 http://www.lesswatts.org/projects/powertop/download/%{name}-%{version}.tar.gz
 
2) rpmlint gave me
 powertop.i386: E: description-line-too-long PowerTOP is a Linux tool that helps
you find those programs that are misbehaving while your computer is idle.
 == Your description lines must not exceed 79 characters. If a line is 
exceeding
this number, cut it to fit in two lines.

3) you don't need
  find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - tool that helps you find misbehaving programs while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - tool that helps you find misbehaving 
programs while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: powertop -  |Review Request: powertop -
   |PowerTOP is a Linux tool|tool that helps you find
   |that helps you find those   |misbehaving programs while
   |programs that are   |your computer is idle.
   |misbehaving while your  |
   |computer is idle.   |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - tool that helps you find misbehaving programs while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - tool that helps you find misbehaving 
programs while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 04:21 EST ---
Why is powertop being reviewed?

powertop is already in Fedora
http://koji.fedoraproject.org/koji/packageinfo?packageID=4369


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - tool that helps you find misbehaving programs while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - tool that helps you find misbehaving 
programs while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NOTABUG




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 04:27 EST ---
damn! How come I miss this to check?
Thanks for replying here before cvs request placed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - tool that helps you find misbehaving programs while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - tool that helps you find misbehaving 
programs while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 04:30 EST ---
Sorry for the trouble, i seem to have missed it to.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428007] Package review: vixie-cron-ng

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: vixie-cron-ng


https://bugzilla.redhat.com/show_bug.cgi?id=428007





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:04 EST ---
to [4] I'm sorry that takes so long. I was thought about auto tools and I've
finally attached ./configure into source code. Also CHANGES were generated from
git-log.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - tool that helps you find misbehaving programs while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - tool that helps you find misbehaving 
programs while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:03 EST ---
I am glad to help. :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426643] Review Request: perl-Linux-Pid - Get the native PID and the PPID on Linux

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Linux-Pid - Get the native PID and the PPID on 
Linux


https://bugzilla.redhat.com/show_bug.cgi?id=426643





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:12 EST ---
Not sure what you call 'Author/Developer tests'. Anyway, I'm asking some perl
devs here to take a look at the issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426830] Review Request: perl-XML-Xerces - Perl API to Xerces XML parser

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-Xerces - Perl API to Xerces XML parser


https://bugzilla.redhat.com/show_bug.cgi?id=426830





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:18 EST ---
Thanks Parag, I've fixed the URL.
Thanks for your comments Ville. I've added the more strict BR on xerces-c-devel.
Changing LANG doesn't change the tests results, though. I'm asking some perl
devs here to look at the issues.

New version : 
http://washington.kelkoo.net/fedora/SPECS/perl-XML-Xerces.spec
http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Xerces-2.7.0_0-3.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427706] Review Request: python-urwid - console user interface for python

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-urwid - console user interface for python


https://bugzilla.redhat.com/show_bug.cgi?id=427706


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:19 EST ---
Hi, 
I cannot sponsor your package, I can just review it:

[EMAIL PROTECTED] ~]# rpmlint python-urwid-0.9.8.1-1.fc8.src.rpm
python-urwid.src: W: summary-not-capitalized console user interface for python
python-urwid.src: W: invalid-license LGPL

See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines


Also tmpl_tutorial.html should have gone to doc i guess

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:23 EST ---
Taking for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426827] Review Request: perl-DateTime-Precise - Perform common time and date operations with additional GPS operations

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Precise - Perform common time and date 
operations with additional GPS operations


https://bugzilla.redhat.com/show_bug.cgi?id=426827





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 04:55 EST ---
yup, this is rather confusing. I can't find anything about license for this code
anywhere.
I've submitted a bug upstream :
http://rt.cpan.org/Ticket/Display.html?id=32186

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427706] Review Request: python-urwid - console user interface for python

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-urwid - console user interface for python


https://bugzilla.redhat.com/show_bug.cgi?id=427706





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:35 EST ---
Also this package does not build for me, using rpmbuild:


running build_ext
error: invalid Python installation: unable to open
/usr/lib/python2.5/config/Makefile (No such file or directory)
error: Bad exit status from /var/tmp/rpm-tmp.56412 (%build)



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428103] Review Request: powertop - tool that helps you find misbehaving programs while your computer is idle.

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: powertop - tool that helps you find misbehaving 
programs while your computer is idle.


https://bugzilla.redhat.com/show_bug.cgi?id=428103


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review+  |




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:50 EST ---
Thanks for that. I wish someone please write a script and/or add it to commit
button on new package process submission that will check newly introducing
package name on koji build server and in existing bugzilla review requests.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428114] New: Review Request: perl-User - API for locating user information regardless of OS

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=428114

   Summary: Review Request: perl-User - API for locating user
information regardless of OS
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-User.spec
SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-User-1.8-1.fc8.src.rpm
Description: This module allows applications to retrieve per-user 
characteristics.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428112] New: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=428112

   Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice
HTML files from HTML syntax trees
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-HTML-PrettyPrinter.spec
SRPM URL: 
http://washington.kelkoo.net/fedora/SRPMS/perl-HTML-PrettyPrinter-0.03-1.fc8.src.rpm
Description: HTML::PrettyPrinter produces nicely formatted HTML code from a 
HTML syntax tree. It is especially useful if the produced HTML file shall be 
read or edited manually afterwards. Various parameters let you adapt the output 
to different styles and requirements.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427706] Review Request: python-urwid - console user interface for python

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-urwid - console user interface for python


https://bugzilla.redhat.com/show_bug.cgi?id=427706





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:51 EST ---
I guess this means you add python-devel as BuildRoot if i am not wrong

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428113] New: Review Request: perl-Net-eBay - Perl Interface to XML based eBay API

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=428113

   Summary: Review Request: perl-Net-eBay - Perl Interface to XML
based eBay API
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-Net-eBay.spec
SRPM URL: 
http://washington.kelkoo.net/fedora/SRPMS/perl-Net-eBay-0.45-1.fc8.src.rpm
Description: This module helps user to easily execute queries against eBay's 
XML API.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:49 EST ---
 - Package meets naming and packaging guidelines
 - Spec file matches base package name.
 - Spec has consistant macro usage.
 - Meets Packaging Guidelines.
 - License: (GPLv2 and GPLv2+ and LGPLv2+)
 - License field in spec matches
 - License file included in package
Only GPL included, LGPL also needed?
 - Spec in American English
 - Spec is legible.
 - Sources match upstream md5sum: yes
 - Package needs ExcludeArch
 - BuildRequires correct
 - Spec handles locales/find_lang
 - Package has %defattr and permissions on files is good.
 - Package has a correct %clean section.
 - Package has correct buildroot
 - Package is code or permissible content.
 - Doc subpackage not needed
 - Packages %doc files don't affect runtime.
 - Headers/static libs in -devel subpackage.
 - Spec has needed ldconfig in post and postun
 - .pc files in -devel subpackage/requires pkgconfig
 - .so files in -devel subpackage.
 - -devel package Requires: %{name} = %{version}-%{release}
 - .la files are removed.
 - Package compiles and builds on at least one arch.
 - Package has no duplicate files in %files.
 - Package doesn't own any directories other packages own.
 - Package owns all the directories it creates.
 - No rpmlint output.
 - final provides and requires are sane
 - Obsoletes seem sane:

Provides:   anjuta-gdl = %{version}-%{release}
Obsoletes:  anjuta-gdl  0.7.7-1
Provides:   anjuta-gdl-devel = %{version}-%{release}
Obsoletes:  anjuta-gdl-devel  0.7.7-1

SHOULD Items:

 - Builds in koji using rawhide tag on all supported archs
 - Sane scriptlets.
 - Subpackages require base package with fully versioned depend.
 - Has dist tag

Issues:

1. Minor:  add: Requires(post): /sbin/ldconfig
2. Minor:  Only GPL included, LGPL also needed?

Outstanding issues are minor, can be fixed after import:

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428115] Review Request: perl-WWW-Search - Virtual base class for WWW searches

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-WWW-Search - Virtual base class for WWW searches


https://bugzilla.redhat.com/show_bug.cgi?id=428115


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||428114




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428113] Review Request: perl-Net-eBay - Perl Interface to XML based eBay API

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-eBay - Perl Interface to XML based eBay API


https://bugzilla.redhat.com/show_bug.cgi?id=428113


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||426827, 428112




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 389971] Review Request: diveintopython - The html book

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: diveintopython - The html book


https://bugzilla.redhat.com/show_bug.cgi?id=389971





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:57 EST ---
Fixed. The CSS file is not an issue it still functions fine.

http://mwiriadi.fedorapeople.org/packages/diveintopython/diveintopython.spec
http://mwiriadi.fedorapeople.org/packages/diveintopython/diveintopython-5.4-6.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428114] Review Request: perl-User - API for locating user information regardless of OS

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User - API for locating user information 
regardless of OS


https://bugzilla.redhat.com/show_bug.cgi?id=428114


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||428115
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428112] Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files 
from HTML syntax trees


https://bugzilla.redhat.com/show_bug.cgi?id=428112


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||428113
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426827] Review Request: perl-DateTime-Precise - Perform common time and date operations with additional GPS operations

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Precise - Perform common time and date 
operations with additional GPS operations


https://bugzilla.redhat.com/show_bug.cgi?id=426827


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||428113
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 05:58 EST ---
It also occurred to me that perhaps gnome-gdl might also work as a name, to make
it clear that it is for GNOME related build tools.  libgdl might be confused as
a library that gdl is dependent on, but I'm happy to be persuaded otherwise.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428115] New: Review Request: perl-WWW-Search - Virtual base class for WWW searches

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=428115

   Summary: Review Request: perl-WWW-Search - Virtual base class for
WWW searches
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-WWW-Search.spec
SRPM URL: 
http://washington.kelkoo.net/fedora/SRPMS/perl-WWW-Search-2.496-2.fc8.src.rpm
Description: This class is the parent for all access methods supported by the 
WWW::Search
library. This library implements a Perl API to web-based search engines. See 
README for a list of search engines currently supported, and for a lot of 
interesting high-level information about this distribution. Search results can 
be limited, and there is a pause between each request to avoid overloading 
either the client or the server.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428112] Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files 
from HTML syntax trees


https://bugzilla.redhat.com/show_bug.cgi?id=428112





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 06:06 EST ---
Just one small thing i saw that is:
i would replace 
%{__perl} Makefile.PL INSTALLDIRS=vendor
with
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE=$RPM_OPT_FLAGS

I am also not sure if we need  || : after check

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428112] Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files 
from HTML syntax trees


https://bugzilla.redhat.com/show_bug.cgi?id=428112





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 06:21 EST ---
(In reply to comment #1)
 Just one small thing i saw that is:
 i would replace 
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 with
 %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE=$RPM_OPT_FLAGS
 
This is a noarch package, so OPTIMIZE is not needed.

 I am also not sure if we need  || : after check

You're right, it is not in the template, I'll remove it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 06:40 EST ---
(In reply to comment #4)
 It also occurred to me that perhaps gnome-gdl might also work as a name, to 
 make
 it clear that it is for GNOME related build tools.

I chose libgdl since that is what Debian and Ubuntu calls it, and I thought it
would be a good idea to have consistent naming across distributions.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 06:54 EST ---
(In reply to comment #3)
 Issues:
 
 1. Minor:  add: Requires(post): /sbin/ldconfig

The following notation automatically mentions the Requires(post): ...:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

 2. Minor:  Only GPL included, LGPL also needed?

The upstream tarball does not provide the text of the LGPL. According to
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-90d644ce2c5db60bad3ba8773fe11653c7629dc3
we should only include a license file as documentation if upstream provided it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428115] Review Request: perl-WWW-Search - Virtual base class for WWW searches

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-WWW-Search - Virtual base class for WWW searches


https://bugzilla.redhat.com/show_bug.cgi?id=428115


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 06:58 EST ---
(In reply to comment #6)

  1. Minor:  add: Requires(post): /sbin/ldconfig
 
 The following notation automatically mentions the Requires(post): ...:
 %post -p /sbin/ldconfig
 %postun -p /sbin/ldconfig

OK, didn't know that, great.
 
  2. Minor:  Only GPL included, LGPL also needed?
 
 The upstream tarball does not provide the text of the LGPL. According to
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-90d644ce2c5db60bad3ba8773fe11653c7629dc3
 we should only include a license file as documentation if upstream provided 
 it.

sure, but we are supposed to pester upstream to ask them to include it.

Anyway, none of these are blockers, so go ahead and import...


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 06:58 EST ---
New Package CVS Request
===
Package Name: libgdl
Short Description: Components and library for GNOME development tools
Owners: rishi
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes

NB: I inherited anjuta-gdl and renaming it to libgdl. So anjuta-gdl should be
deleted from CVS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428112] Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files 
from HTML syntax trees


https://bugzilla.redhat.com/show_bug.cgi?id=428112


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 07:07 EST ---
As this package is not compiling anything in build stage no need of
OPTIMIZE=$RPM_OPT_FLAGS

I don't think you need to set -x and set +x

Don't think you need %check ||:



Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
4d3f84ba4e35cb7fac863b828b7f2b68  HTML-PrettyPrinter-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
PERL_DL_NONLAZY=1 /usr/bin/perl -Iblib/lib -Iblib/arch test.pl
1..3
# Running under perl version 5.008008 for linux
# Current time local: Wed Jan  9 06:55:34 2008
# Current time GMT:   Wed Jan  9 11:55:34 2008
# Using Test.pm version 1.25
ok 1
ok 1
ok 2
ok 3
exit 0
+ Package perl-HTML-PrettyPrinter-0.03-1.fc9 -
  Provides: perl(HTML::PrettyPrinter) = 0.03
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(strict)
perl(vars)
APPROVED.

  

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428114] Review Request: perl-User - API for locating user information regardless of OS

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User - API for locating user information 
regardless of OS


https://bugzilla.redhat.com/show_bug.cgi?id=428114


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428114] Review Request: perl-User - API for locating user information regardless of OS

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User - API for locating user information 
regardless of OS


https://bugzilla.redhat.com/show_bug.cgi?id=428114


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 06:56 EST ---
I don't think you need 
%check ||:
make it 
%check only.


Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
b8b2c677dc4ef08e84b5b4f8cb021540  User-1.8.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
PERL_DL_NONLAZY=1 /usr/bin/perl -Iblib/lib -Iblib/arch test.pl
1..3
# Running under perl version 5.008008 for linux
# Current time local: Wed Jan  9 06:21:40 2008
# Current time GMT:   Wed Jan  9 11:21:40 2008
# Using Test.pm version 1.25
ok 1
ok 2
ok 3
+ Package perl-User-1.8-1.fc9 -
  Provides: perl(User) = 1.8
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(strict) perl(vars)
APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 372161] Review Request: gnome-themes-extras - extra themes for gnome

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-themes-extras - extra themes for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=372161





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 07:23 EST ---
You watch to see they actually update SVN here:

http://svn.gnome.org/viewvc/gnome-themes-extras/trunk/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 372161] Review Request: gnome-themes-extras - extra themes for gnome

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-themes-extras - extra themes for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=372161





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 07:18 EST ---
Also put a link to the upstream GNOME bugzilla link in a comment in the spec
file with a note saying upstream clarified the license on the bug and are
(hopefully) working to include it in the next release.  Please keep checking to
see whether they mean GPLv2+ (which they probably do) rather than GPLv2 and
update spec accordingly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426827] Review Request: perl-DateTime-Precise - Perform common time and date operations with additional GPS operations

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Precise - Perform common time and date 
operations with additional GPS operations


https://bugzilla.redhat.com/show_bug.cgi?id=426827





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 07:11 EST ---
thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428113] Review Request: perl-Net-eBay - Perl Interface to XML based eBay API

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-eBay - Perl Interface to XML based eBay API


https://bugzilla.redhat.com/show_bug.cgi?id=428113


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 07:09 EST ---
will review this once its dependent packages will be built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 372161] Review Request: gnome-themes-extras - extra themes for gnome

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-themes-extras - extra themes for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=372161





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 07:16 EST ---
MUST FIX items:

1) OK, I think that we should go back to the monolithic package for the moment,
to avoid duplication of docs and to make sure upgrades from the old
gnome-themes-extras goes smoothly.

The good news is that I did a koji build on rawhide that worked:

http://koji.fedoraproject.org/koji/taskinfo?taskID=336678

Also there are some (mostly) small issues with running rpmlint on the packages

$ rpmlint *.rpm

gnome-themes-extras.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 20)
gnome-themes-extras-darklooks.noarch: W: summary-not-capitalized darklooks theme
gnome-themes-extras-darklooks.noarch: E: description-line-too-long Darklooks is
a meta-theme that is part of the gnome-themes-extras package. This package
gnome-themes-extras-foxtrot.noarch: E: description-line-too-long Foxtrot is a
meta-theme that is part of the gnome-themes-extras package. This package
gnome-themes-extras-gion.noarch: E: description-line-too-long Gion is a
meta-theme that is part of the gnome-themes-extras package.  This package
gnome-themes-extras-neu.noarch: W: spelling-error-in-description pacakge package
gnome-themes-extras-neu.noarch: E: description-line-too-long Neu is a meta-theme
that is part of the gnome-themes-extras pacakge. This package

2) Remember, Description lines should be no longer than 80 chars, and that
Summary should start with a capital letter.

3) You are also mixing tabs and spaces in the spec file which makes the spec
file look odd in different editors, for example in Emacs it looks like this:

%packagefoxtrot
Requires:   gnome-icon-theme, gnome-themes
Group:  User Interface/Desktops
Summary:Foxtrot metatheme
%descriptionfoxtrot
Foxtrot is a meta-theme that is part of the gnome-themes-extras package. This
package requires that you use a Gnome 2.2 release or newer.

4) * Mon Jan 7 2008 Marc Wiriadisastra [EMAIL PROTECTED] - 2.20-3
- Added patches to remove non-licensed themes

isn't true any more, so should be removed/updated.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 191492] Review Request: unuran-0.7.2

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unuran-0.7.2


https://bugzilla.redhat.com/show_bug.cgi?id=191492





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 07:31 EST ---
OK I have:
* split into devel package
* install -p
* add examples
* fix pre,post stuff

I don't think adding the gsl, etc stuff is useful (at least not for me).  Does 
anyone want it?

rpmlint is (almost) silent - only complaint is:
 rpmlint RPM/RPMS/x86_64/unuran-devel-1.1.0-4.fc8.x86_64.rpm 
unuran-devel.x86_64: W: 
hidden-file-or-dir /usr/share/doc/unuran-devel-1.1.0/examples/.deps
unuran-devel.x86_64: W: 
hidden-file-or-dir /usr/share/doc/unuran-devel-1.1.0/examples/.deps

I think this is ignorable - I suspect the examples are not too useful without 
this.

Please try:

https://nbecker.dyndns.org/RPM/unuran.spec
https://nbecker.dyndns.org/RPM/unuran-1.1.0-4.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428113] Review Request: perl-Net-eBay - Perl Interface to XML based eBay API

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-eBay - Perl Interface to XML based eBay API


https://bugzilla.redhat.com/show_bug.cgi?id=428113





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 08:07 EST ---
Thanks Parag.
Btw, please note this one have a missing BR: on perl(Test::Pod::Coverage). Some
functions are not documented, thus the test fails. I've filled a bug upstream 
http://rt.cpan.org/Ticket/Display.html?id=32184 and documented this in the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428114] Review Request: perl-User - API for locating user information regardless of OS

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User - API for locating user information 
regardless of OS


https://bugzilla.redhat.com/show_bug.cgi?id=428114


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 08:38 EST ---
Thx Parag.

%make check fixed in :
http://washington.kelkoo.net/fedora/SPECS/perl-User.spec
http://washington.kelkoo.net/fedora/SRPMS/perl-User-1.8-2.fc8.src.rpm

New Package CVS Request
===
Package Name: perl-User
Short Description: API for locating user information regardless of OS
Owners: xavierb
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428112] Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files 
from HTML syntax trees


https://bugzilla.redhat.com/show_bug.cgi?id=428112


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 08:45 EST ---
Thx Parag.
%check and set -x/set +x fixed in :
http://washington.kelkoo.net/fedora/SPECS/perl-HTML-PrettyPrinter.spec
http://washington.kelkoo.net/fedora/SRPMS/perl-HTML-PrettyPrinter-0.03-2.fc8.src.rpm

New Package CVS Request
===
Package Name: perl-HTML-PrettyPrinter
Short Description: Generate nice HTML files from HTML syntax trees
Owners: xavierb
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428138] New: Review Request: system-summary - A quick summary of system hardware

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=428138

   Summary: Review Request: system-summary - A quick summary of
system hardware
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://jbowes.fedorapeople.org/tmp/system-summary.spec
SRPM URL: http://jbowes.fedorapeople.org/tmp/system-summary-0.0.2-2.fc8.src.rpm
Description:
A simple About this computer screen that summarizes your system's hardware
and software.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427380] Review Request: efibootmgr - EFI Boot Manager

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efibootmgr - EFI Boot Manager


https://bugzilla.redhat.com/show_bug.cgi?id=427380


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED]
   ||om)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427380] Review Request: efibootmgr - EFI Boot Manager

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efibootmgr - EFI Boot Manager


https://bugzilla.redhat.com/show_bug.cgi?id=427380


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC|[EMAIL PROTECTED]  |
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 09:47 EST ---
rpmlint runs cleanly.

 URL: http://linux.dell.com/%{name}/

I don't see efibootmgr-0.5.4 (the version out of %{version}) available so I
can't check that the sources in the package match the upstream source.

 Conflicts: elilo  3.6-5
 Obsoletes: elilo  3.6-5

I believe the Obsoletes should be enough to make sure that elilo gets replaced.

 touch -r src/man/man8/%{name}.8 src/man/man8/%{name}.8.gz

Not sure what the point of that in the %install section is, unless you need to
fake out install somehow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427373] Review Request: dbxml-perl - Perl bindings for Oracle DB XML

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dbxml-perl - Perl bindings for Oracle DB XML


https://bugzilla.redhat.com/show_bug.cgi?id=427373





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 09:25 EST ---
Please close this bug when rebuild and request on koji is done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428138] Review Request: system-summary - A quick summary of system hardware

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: system-summary - A quick summary of system hardware


https://bugzilla.redhat.com/show_bug.cgi?id=428138


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:00 EST ---
1)If direct download link of tarball is not available then add some text in
comments on how tarball can be created?

2)for desktop file installation you should use desktop-file-install command.
see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6
here, you may like to add --vendor=fedora

3) rpmlint output on srpm gave me
system-summary.src: W: strange-permission system-summary.spec 0600
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 307891] Review Request: libvpd - C++ library for system vpd access

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libvpd - C++ library for system vpd access


https://bugzilla.redhat.com/show_bug.cgi?id=307891





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:14 EST ---
Well:

$ ls -al old/*gz *gz
-rw--- 1 tasaka1 tasaka1 356118 2008-01-08 03:05 libvpd-1.5.0.tar.gz
-rw--- 1 tasaka1 tasaka1 351239 2007-12-28 16:56 old/libvpd-1.5.0.tar.gz

The tarball in sourceforge.net changed What happened??

It seems that you are one of the upstream developers so:
Please don't change the tarball which is once formally released.
It surely confuses people who want to use the tarball (and actually
did...) So would you retrieve the original 1.5.0 tarball and
release the new tarball if you want to modify the original tarball
itself?

Anyway:
-
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to show that you have an understanding 
of the process and of the packaging guidelines as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a pre-review of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose Merge Review)


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 378791] Review Request: netdump-server - netdump crash recovery capture server

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: netdump-server - netdump crash recovery capture server


https://bugzilla.redhat.com/show_bug.cgi?id=378791


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 09:35 EST ---
yep, all done.  Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 416761] Review Request cppad - A Package for Differentiation of C++ Algorithms

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request cppad - A Package for Differentiation of C++ Algorithms


https://bugzilla.redhat.com/show_bug.cgi?id=416761





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:20 EST ---
Would you try to rebuild cppad on koji? If some troubles
still exist, please tell me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426885] Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: odccm - Connection daemon for Pocket PC devices for 
Windows Mobile 5


https://bugzilla.redhat.com/show_bug.cgi?id=426885





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:26 EST ---
http://fedora.lowlatency.de/review/odccm-0.11-1.fc9.x86_64.rpm

Final version + I removed synce-gnome. I will submit it as a separate package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=291741





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:20 EST ---
I will close this bug if no response from the reporter is
received within ONE WEEK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 403741] Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL


https://bugzilla.redhat.com/show_bug.cgi?id=403741





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:03 EST ---
I'd highly recommend leaving out the capitalization, stick with openexr_ctl 
here.  In a perfect world, I'd also rename OpenEXR - openexr , but I've been 
to lazy to do that (yet).

Hmm... I thought there was some non-free license issue (non commercial?) with 
this, but that's only going off of foggy/vague recollection from past openexr 
mailing list dicussions.  ??

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 246793] Review Request: postgresql-plruby - PostgreSQL Ruby Procedural Language

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-plruby - PostgreSQL Ruby Procedural Language


https://bugzilla.redhat.com/show_bug.cgi?id=246793


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED]
   ||pt.com)




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:27 EST ---
Would you check the spec file attached on comment 22?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 403741] Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL


https://bugzilla.redhat.com/show_bug.cgi?id=403741





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:20 EST ---
ok, nevermind, I think it was only gpl-incompatible, but still free 
(enough). :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 403741] Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL


https://bugzilla.redhat.com/show_bug.cgi?id=403741





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:44 EST ---
good point about the pkg name vs pkgconfig, I hadn't considered that.  either
way works.

your pkgconfig patch here looks like a very good start, send that upstream. :)

re: unused-direct-shlib-dependencies  : good point, I could/should hack in
-Wl,-unused like you did here.

Re: OpenEXR-1.6.x for F-8, I'm definitely ok with that, just need to be careful
about the soname changes.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 403741] Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL


https://bugzilla.redhat.com/show_bug.cgi?id=403741





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:00 EST ---
Rebuilt failed in mock at the OpenEXR test (with gcc43 but went fine with gcc
4.1.2)... 
I Will investigate this: I can disable the OpenEXR test (like i did for fixing
OpenEXR_CTL for gcc43) or fix the test, but maybe that's related to
OpenEXR-devel not fixed for gcc43... I will have a look...



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428007] Package review: vixie-cron-ng

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: vixie-cron-ng


https://bugzilla.redhat.com/show_bug.cgi?id=428007


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427273] Review Request: firstaidkit - System Rescue Tool

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firstaidkit - System Rescue Tool


https://bugzilla.redhat.com/show_bug.cgi?id=427273





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:07 EST ---
 Any specific reason to let user install all plugins when he try to install 
 only
 firstaidkit rpm?
 

I want to be friendly to our end user.  I would hate the user to have to hunt
down the plugins that he needs.  A more automated approach would be the install
all relevant plugins.  The idea of the firstaidkit-plugins-all is excellent,
This would look at the system for stuff and according to what it finds it will
install the relative plugin. (For example, if the system is using lvm, the
install-all script would install the firstaidkit-plugin-lvm)
So this package would not bring all the plugins but the relative ones.  I would
run some test scripts at install time that return true/false and make the
decision from there.  Any comments,  maybe you know an simpler way of achieving
this?
thx.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428007] Package review: vixie-cron-ng

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: vixie-cron-ng


https://bugzilla.redhat.com/show_bug.cgi?id=428007


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||427660
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427996] Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, built on top of Xerces-C

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, 
built on top of Xerces-C


https://bugzilla.redhat.com/show_bug.cgi?id=427996


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427273] Review Request: firstaidkit - System Rescue Tool

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firstaidkit - System Rescue Tool


https://bugzilla.redhat.com/show_bug.cgi?id=427273





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:13 EST ---
Sorry for the double reply.  just wanted to address that install-all issue
separately.

(In reply to comment #15)
 your packaging should work like this.
 
 firstaidkit developer when installs firstaidkit-devel, he will get firstaidkit
 and firstaidkit-devel gets installed on his system.
 

Yep thats the way I left it :)

 
 when a developer creates new plugins he will create new
 firstaidkit-plugins-pluginNAME package and submit it. Newly developed plugin
 should go to %{_libdir}/firstaidkit-plugins/pluginNAME/

yes this is correct, but the plugin doesn't necessarily have to be a dir.

 
 Now you can either create a empty firstaidkit-plugins-all which will pull all
 newly added plugins packages. 
 (See nagios-plugins SPEC)

I'll take a peak.

 Or let end user install it separately only with no -all subpackage.

I would maybe like the liberty to do both.  The user might want to just install
one plugin, so he will use `yum install firstaidkit-plugin-lvm` but if he wants
a system wide rescue/check he will do a `yum install firstaidkit-plugin-all`.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428007] Package review: vixie-cron-ng

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: vixie-cron-ng


https://bugzilla.redhat.com/show_bug.cgi?id=428007





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:24 EST ---
(In reply to comment #5)
 to [3] because I can't say selinux and pam in fcron is ok. I didn't test many
 other features and the main reason is the vixie-cron-ng will support inotify,
 which is needed for battery saving. I don't see anything ancient on using
 inotify ;-)

Sure, but I think it might be better to work with an existing upstream project
on these features if possible (akin to using/extending rsyslog rather than
forking ourselves.) Do we have other distros interested in picking up our fork?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 246793] Review Request: postgresql-plruby - PostgreSQL Ruby Procedural Language

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-plruby - PostgreSQL Ruby Procedural Language


https://bugzilla.redhat.com/show_bug.cgi?id=246793


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]|
   |pt.com) |




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:24 EST ---
Oh yes. Thanks for that -- it works on my test servers, too...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427380] Review Request: efibootmgr - EFI Boot Manager

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efibootmgr - EFI Boot Manager


https://bugzilla.redhat.com/show_bug.cgi?id=427380


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]|
   |om) |




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:25 EST ---
Chris, thanks for the quick review.

I'll post 0.5.4 as soon as this passes review, I just wanted to wait to roll 
any critical found changes from this review into the release.

I was told on IRC that the Conflicts is necessary too.  notting, advice?

the touch statement is just to get the timestamp to match the file from the 
tarball, so that it doesn't get set to a newer timestamp unnecessarily just 
because it got compressed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428007] Package review: vixie-cron-ng

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: vixie-cron-ng


https://bugzilla.redhat.com/show_bug.cgi?id=428007


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 416761] Review Request cppad - A Package for Differentiation of C++ Algorithms

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request cppad - A Package for Differentiation of C++ Algorithms


https://bugzilla.redhat.com/show_bug.cgi?id=416761





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 10:52 EST ---
My trouble is related to my DSL modem at home. It seems to connect fine through
Windows, but I am having trouble connecting through Fedora. I think I have found
someone I know who may be capable of solving the problem. In the meantime, I am
using cygwin to access Fedora's cvs repository and  Kevin has been helping me by
submitting my builds and reporting back the results; see the changelog in
http://cvs.fedoraproject.org/viewcvs/rpms/cppad/devel/cppad.spec?rev=1.3view=auto

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 403741] Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OpenEXR_CTL - A simplified OpenEXR interface to CTL


https://bugzilla.redhat.com/show_bug.cgi?id=403741





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:25 EST ---
Ok that's fixed with a configure test fix
conftest.cc:32: error: 'system' was not declared in this scope
added %patch2 (without bumping release)...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428007] Package review: vixie-cron-ng

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: vixie-cron-ng


https://bugzilla.redhat.com/show_bug.cgi?id=428007





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:36 EST ---
[7] I hope that they will. I was looking in other distribution, which cron they
are using and they have some fork of vixie-cron. I think on the servers everyone
is using some vixie-cron with patches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427380] Review Request: efibootmgr - EFI Boot Manager

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efibootmgr - EFI Boot Manager


https://bugzilla.redhat.com/show_bug.cgi?id=427380





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:34 EST ---
Thinking... the conflicts might help ensure the right thing happens if someone
just does 'yum install efibootmgr' on a system that already has elilo. But I
don't think it's absolutely necessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 378951] Review Request: eclipse-photran - Eclipse Fortran Development Tools (Photran) plugin

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-photran - Eclipse Fortran Development Tools 
(Photran) plugin


https://bugzilla.redhat.com/show_bug.cgi?id=378951





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:50 EST ---
Well, I was waiting for the final release of 4.0.0 before releasing for F-8. 
Can't release for F-7 because photran requires CDT 4.0.1.  I'm building photran
for F-8 now and will push to updates-testing if it succeeds.  I think I'll still
wait for 4.0.0 final before pushing to updates.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427273] Review Request: firstaidkit - System Rescue Tool

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firstaidkit - System Rescue Tool


https://bugzilla.redhat.com/show_bug.cgi?id=427273





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:54 EST ---
(In reply to comment #17)
 As, -devel only provides examples. I will suggest to create examples directory
 under %{_libdir}/firstaidkit-plugins and install example files there.
 so you just need to change following line in %install
 %{__cp} -rf plugins/ $RPM_BUILD_ROOT/%{_libdir}/firstaidkit-plugins
 to
 %{__install} -d $RPM_BUILD_ROOT/%{_libdir}/firstaidkit-plugins/examples
 %{__cp} -rf plugins/* $RPM_BUILD_ROOT/%{_libdir}/firstaidkit-plugins/examples

Was looking through your posted spec file, and you change this issue slightly by
putting the examples in %{_datadir} instead of %{_libdir}.  I would want them in
libdir and for sample3plugin/plugin to be executable so the plugin developer can
run the examples by calling firstaidkit `-execute=example1`.  What do you think?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 378951] Review Request: eclipse-photran - Eclipse Fortran Development Tools (Photran) plugin

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-photran - Eclipse Fortran Development Tools 
(Photran) plugin


https://bugzilla.redhat.com/show_bug.cgi?id=378951





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 11:36 EST ---
Any plans of building for F-8 and F-7?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 246793] Review Request: postgresql-plruby - PostgreSQL Ruby Procedural Language

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-plruby - PostgreSQL Ruby Procedural Language


https://bugzilla.redhat.com/show_bug.cgi?id=246793


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 12:25 EST ---
Thanks. I will check this package again later.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427380] Review Request: efibootmgr - EFI Boot Manager

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: efibootmgr - EFI Boot Manager


https://bugzilla.redhat.com/show_bug.cgi?id=427380





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 12:26 EST ---
Thanks Bill.  Seeing as how elilo will hopefully be disapperaing in favor of 
grub w/ EFI capability, the comps file will list efibootmgr but not elilo.  So 
upgrades from a distro version which used the combo elilo package, to a distro 
version that doesn't, needs that line in the efibootmgr package (as efibootmgr 
will be listed in comps).

Chris, with this addressed, any remaining concerns?

Thanks,
Matt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427996] Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, built on top of Xerces-C

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, 
built on top of Xerces-C


https://bugzilla.redhat.com/show_bug.cgi?id=427996





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 12:28 EST ---
Before checking this package, would you confirm the license of
the following file(s) to upstream developer?
I guess the upstream forgot to change the license.

---
src/mapm/mapm_mt.cpp
---

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427996] Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, built on top of Xerces-C

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, 
built on top of Xerces-C


https://bugzilla.redhat.com/show_bug.cgi?id=427996





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 12:31 EST ---
(In reply to comment #2)
 would you confirm the license of
 the following file(s) to upstream developer?

Umm.. I used a strange English... Anyway please ask the
license of the files above to upstream.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427996] Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, built on top of Xerces-C

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xqilla - XQilla is an XQuery and XPath 2.0 library, 
built on top of Xerces-C


https://bugzilla.redhat.com/show_bug.cgi?id=427996





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 12:39 EST ---
For 2.0.0-0:

* Source
  - XQilla 2.0.0 source coincides, however for xerces_c source file,
the tarball in your srpm is different from what I downloaded from
the URL written as Source0:
--
7760004 2005-09-08 23:14 xerces-c-src_2_7_0.tar.gz
8031146 2007-11-11 06:03 xqilla-2.0.0-0.fc9/xerces-c-src_2_7_0.tar.gz
--

* Parallel make
  - If this is parallel make unsafe, please write a comment on
the spec file.

Other things are okay, except for license issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427955] Review Request: gnome2-globalmenu-applet - Menu Server panel applet for gtk2-aqd

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome2-globalmenu-applet - Menu Server panel applet 
for gtk2-aqd


https://bugzilla.redhat.com/show_bug.cgi?id=427955





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 13:10 EST ---
Please include the description given here in your spec file under the
Description section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 292121] Review Request: boxes - Draw any kind of box around some given text

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boxes - Draw any kind of box around some given text


https://bugzilla.redhat.com/show_bug.cgi?id=292121


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 13:13 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428112] Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files 
from HTML syntax trees


https://bugzilla.redhat.com/show_bug.cgi?id=428112


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 13:22 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426599] Review Request: libgdl - Components and library for GNOME development tools

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgdl - Components and library for GNOME development 
tools


https://bugzilla.redhat.com/show_bug.cgi?id=426599


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 13:18 EST ---
cvs done. 

For anjuta-gdl, please follow the package end of life page at: 
http://fedoraproject.org/wiki/PackageMaintainers/PackageEndOfLife

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 428114] Review Request: perl-User - API for locating user information regardless of OS

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User - API for locating user information 
regardless of OS


https://bugzilla.redhat.com/show_bug.cgi?id=428114


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 13:25 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 427273] Review Request: firstaidkit - System Rescue Tool

2008-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firstaidkit - System Rescue Tool


https://bugzilla.redhat.com/show_bug.cgi?id=427273





--- Additional Comments From [EMAIL PROTECTED]  2008-01-09 13:30 EST ---
I generated new spec and srpm.  I included most of the changes to the spec file.
comments:  currently rpmling has two issues:
firstaidkit-devel.noarch: E: only-non-binary-in-usr-lib
firstaidkit-plugin-all.noarch: W: no-documentation
FYI, these issues are also present in nagios-plugins packages.

srpm : http://jgranado.fedorapeople.org/firstaidkit-0.1.0-6.fc8.src.rpm
spec : http://jgranado.fedorapeople.org/firstaidkit.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >