[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files https://bugzilla.redhat.com/show_bug.cgi?id=434704 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 03:23 EST --- Review: + package builds in mock (rawhide i386). koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=483521 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 9651d6afb204c0b22cd69be8a847e1d4 ocamldsort-0.14.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434706] Review Request: ocaml-type-conv - OCaml base library for type conversion
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-type-conv - OCaml base library for type conversion https://bugzilla.redhat.com/show_bug.cgi?id=434706 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 03:28 EST --- Review: + package builds in mock (rawhide i386). koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=483525 + rpmlint is NOT silent for SRPM and for RPM. ocaml-type-conv.i386: W: invalid-license LGPLv2+ with exceptions ocaml-type-conv.i386: E: no-binary ocaml-type-conv.i386: E: only-non-binary-in-usr-lib ocaml-type-conv.src: W: invalid-license LGPLv2+ with exceptions == Ok to accept as per fixed in bug 434690 and bug 433783 + source files match upstream. 07658454c84d24b07083dea6af2b3e18 type-conv-1.3.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Package ocaml-type-conv-1.3.0-2.fc9 = Provides: ocaml(Pa_type_conv) = 432cfbcca727c79fd9a65c602aa4eb34 Requires: ocaml(Arg) = 03e86a4154064ea900dc32c05f53e364 ocaml(Array) = aa8e3cd5824f9bb40b93fcd38d0c95b5 ocaml(Buffer) = f6cef633ea14963b84b79c4095c63dc3 ocaml(Camlp4) = 1e46a133b8062d1571640f7fa36f32c4 ocaml(Camlp4_config) = cb716b4361f43326c6ad695c7a1bb5c0 ocaml(Camlp4_import) = 0134ca95282ef6821081c0c11802cea0 ocaml(Char) = e98bc9c9e918a84b3c1a5a122d42fac1 ocaml(Filename) = 633a1e7f590ff5e95124293dbef3b476 ocaml(Format) = 35fe566f7a37d8991a5c822bd1463949 ocaml(Hashtbl) = 083f2c94b44ff4e0b3220aaea6a783b4 ocaml(Int32) = 711321870c949bd3bbdd092d9bae92e4 ocaml(Int64) = f8f7e2e4c0667ead94596040b12e732d ocaml(Lexing) = b1793496643444d3762dd42bebe2cfe3 ocaml(List) = da1ce9168f0408ff26158af757456948 ocaml(Map) = dedde7683d54ae7db1eb97cc868dd047 ocaml(Nativeint) = e79cdc4d3575c2ed044955cb7ef49aca ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d ocaml(Parsing) = 62cca107e4e88af303516459a87c3e9a ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(Printf) = 5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(Queue) = caa3a209bfc63d23a30f573541a88fec ocaml(Set) = 7da14e671a035f12386ace3890018ef3 ocaml(Stream) = 21a833e12efd34ea0c87d8d9da959809 ocaml(String) = 2c162ab314b2f0a2cfd22d471b2e21ab ocaml(Sys) = 0da495f5a80f31899139359805318f28 ocaml(runtime) = 3.10.1 - Not followed ocaml packaging guildelines by packaging *.cmo files SHOULD: 1) Either follow guidelines and remove *.cmo or Specify reason to accept it or as you said in other review (https://bugzilla.redhat.com/show_bug.cgi?id=435293#c2), I will wait till this gets approved as official packaging guidelines. 2) You can use following to silent rpmlint for no-binary BuildArch: noarch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435593] New: Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=435593 Summary: Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://remi.fedorapeople.org/ocsinventory-agent.spec SRPM URL: http://remi.fedorapeople.org/ocsinventory-agent-0.0.8.2-0.1.20080302.fc8.remi.src.rpm Mock log: http://remi.fedorapeople.org/ocsinventory-agent-build.log Description: Open Computer and Software Inventory Next Generation is an application designed to help a network or system administrator keep track of computer configuration and software installed on the network. It also allows deploying softwares, commands or files on Windows and Linux client computers. ocsinventory-agent provide the client for Linux (Unified Unix Agent). --- rpmlint is silent build in mock (rawhide) Note : i submit the SVN version because I need some new option for packaging (--wait and --lazy). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435593] Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/show_bug.cgi?id=435593 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 04:06 EST --- Patrice, i put you in CC as you have reviewed ocsinventory-client which is obsoleted by this new package (#217275). I used this new agent in production for more than 1 year and I like to push this official OCS new client in Fedora and EPEL. It will be great to have it on the repo at the same time than official annoucement on OCS web site. Regards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435593] Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/show_bug.cgi?id=435593 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 05:38 EST --- Shouldn't postinst.pl be installed under _sbindir (with a better name)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435593] Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ocsinventory-agent - Open Computer and Software
Inventory Next Generation client
https://bugzilla.redhat.com/show_bug.cgi?id=435593
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 05:34 EST ---
Missing BR perl(Digest::MD5) and perl(File::Temp).
You should not use fedora in the README file names, but instead
something that can be in any derived package, so something like
distribution (and in my opinion it is better to avoid writing
Fedora as much as possible because of potential trademark issues).
Obsoletes: ocsinventory-client = 1.01
is right, but
Provides: ocsinventory-client = %{version}-%{release}
is wrong since version is 0.0.8.2, so it provides a version older
than the obsoleted version. I am not completly sure what to do in
that case. I see 2 possibilities
* have
Provides: ocsinventory-client = 1.02
# use the following line when version is strictly above 1.01
# ocsinventory-client = %{version}-%{release}
* no uncommented Provides but the following comment:
# as soon as version is strictly above 1.01 uncomment the following line
# ocsinventory-client = %{version}-%{release}
The cvs -z3 co command should use a date or a tag such that the
same code is checked out in the future.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433199] Review Request: anjuta - A GNOME development IDE for C/C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: anjuta - A GNOME development IDE for C/C++ https://bugzilla.redhat.com/show_bug.cgi?id=433199 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 05:44 EST --- According to upstream, the plugins are loaded using GModule's g_module_open and the path is constructed using the corresponding *.plugin file and $(libdir). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434706] Review Request: ocaml-type-conv - OCaml base library for type conversion
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-type-conv - OCaml base library for type conversion https://bugzilla.redhat.com/show_bug.cgi?id=434706 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 05:52 EST --- The .cmo file is the program so not distributing the .cmo file would defeat the purpose of packaging this. I've started a round of discussion on new packaging guidelines to clarify this. See fedora-packaging mailing list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files https://bugzilla.redhat.com/show_bug.cgi?id=434704 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 05:54 EST --- New Package CVS Request === Package Name: ocamldsort Short Description: Dependency sorter for OCaml source files Owners: rjones Branches: F-8 InitialCC: rjones Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435593] Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ocsinventory-agent - Open Computer and Software
Inventory Next Generation client
https://bugzilla.redhat.com/show_bug.cgi?id=435593
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:04 EST ---
Yes i forget postinst.pl
I think i should simply remove it as .cfg is provided and the use of this script
may conflict with rpm stuff (mainly the cron.d != cron.hourly).
About ocsinventory-client, i'm thinking of using epoch (i must check if this is
ok)
ocsinventory-client = 1:%{version}-%{release}
I haven't add perl(Digest::MD5) and perl(File::Temp) because provided by perl
main packages, but i will add it (in case of a package split).
Thank's for the quick feedback.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241487] Review Request: cduce - An XML-oriented functional language (ocaml)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cduce - An XML-oriented functional language (ocaml) https://bugzilla.redhat.com/show_bug.cgi?id=241487 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:09 EST --- ocaml-pxp is built now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241475] Review Request: ocaml-ulex - OCaml lexer generator for Unicode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-ulex - OCaml lexer generator for Unicode https://bugzilla.redhat.com/show_bug.cgi?id=241475 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 240557] Review Request: ocaml-findlib - Objective CAML package manager and build helper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-findlib - Objective CAML package manager and build helper https://bugzilla.redhat.com/show_bug.cgi?id=240557 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241476] Review Request: ocaml-pxp - Validating XML parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-pxp - Validating XML parser https://bugzilla.redhat.com/show_bug.cgi?id=241476 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:09 EST --- built in F-8: http://koji.fedoraproject.org/koji/taskinfo?taskID=483755 built in Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=483771 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241487] Review Request: cduce - An XML-oriented functional language (ocaml)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cduce - An XML-oriented functional language (ocaml) https://bugzilla.redhat.com/show_bug.cgi?id=241487 Bug 241487 depends on bug 241476, which changed state. Bug 241476 Summary: Review Request: ocaml-pxp - Validating XML parser https://bugzilla.redhat.com/show_bug.cgi?id=241476 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434691] Review Request: ocaml-postgresql - OCaml library for accessing PostreSQL databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-postgresql - OCaml library for accessing PostreSQL databases https://bugzilla.redhat.com/show_bug.cgi?id=434691 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:37 EST --- You can add examples directory as %doc Add LICENSE AUTHORS Changes to %doc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434699] Review Request: ocaml-mysql - OCaml library for accessing MySQL databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-mysql - OCaml library for accessing MySQL databases https://bugzilla.redhat.com/show_bug.cgi?id=434699 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:39 EST --- build failed with log at http://koji.fedoraproject.org/koji/getfile?taskID=483889name=build.log === ocamlc -c -pp camlp4o mysql.ml sh: camlp4o: command not found Preprocessor error make[1]: *** [mysql.cmo] Error 2 make[1]: Leaving directory `/builddir/build/BUILD/ocaml-mysql-1.0.4' === -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 417511] Review Request: jruby - Pure Java implementation of the Ruby interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jruby - Pure Java implementation of the Ruby interpreter https://bugzilla.redhat.com/show_bug.cgi?id=417511 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:44 EST --- I packaged joni last night and submitted a review request (bug# 435598). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 417511] Review Request: jruby - Pure Java implementation of the Ruby interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jruby - Pure Java implementation of the Ruby interpreter https://bugzilla.redhat.com/show_bug.cgi?id=417511 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||435598 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435598] Review Request: joni - Java regexp library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: joni - Java regexp library https://bugzilla.redhat.com/show_bug.cgi?id=435598 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||417511 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435598] New: Review Request: joni - Java regexp library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=435598 Summary: Review Request: joni - Java regexp library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://konrad.sobertillnoon.com/fedora/joni.spec SRPM URL: http://konrad.sobertillnoon.com/fedora/joni-1.0.1-1.fc8.src.rpm Description: joni is a port of Oniguruma, a regular expressions library, to java. It is used by jruby. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434633] Review Request: ocaml-xmlrpc-light - OCaml library for writing XML-RPC clients and servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-xmlrpc-light - OCaml library for writing XML-RPC clients and servers https://bugzilla.redhat.com/show_bug.cgi?id=434633 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:49 EST --- koji build failed at http://koji.fedoraproject.org/koji/taskinfo?taskID=483916 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431188] Review Request: minbar - Athan call and prayer times notification software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: minbar - Athan call and prayer times notification software https://bugzilla.redhat.com/show_bug.cgi?id=431188 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:49 EST --- Thanks, I have updated the package - fixed gtk-update-icon-cache scriplet - changed sed to use -i - removed %doc from man files http://izhar.fedorapeople.org/itl/minbar.spec http://izhar.fedorapeople.org/itl/minbar-0.2.1-4.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431188] Review Request: minbar - Athan call and prayer times notification software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: minbar - Athan call and prayer times notification software https://bugzilla.redhat.com/show_bug.cgi?id=431188 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 06:51 EST --- oops SRPM: http://izhar.fedorapeople.org/itl/minbar-0.2.1-5.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 07:22 EST --- Andrea, do you want to swap reviews with one of these? : * lbrickbuster2 - popular brickbusting arcadegame from lgames - bug 435514 * lure - Lure of the Temptress - Adventure Game - bug 435564 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434633] Review Request: ocaml-xmlrpc-light - OCaml library for writing XML-RPC clients and servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-xmlrpc-light - OCaml library for writing XML-RPC clients and servers https://bugzilla.redhat.com/show_bug.cgi?id=434633 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 417511] Review Request: jruby - Pure Java implementation of the Ruby interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jruby - Pure Java implementation of the Ruby interpreter https://bugzilla.redhat.com/show_bug.cgi?id=417511 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 07:42 EST --- I also packaged asm3 and submitted a review request (bug# 435601). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 417511] Review Request: jruby - Pure Java implementation of the Ruby interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jruby - Pure Java implementation of the Ruby interpreter https://bugzilla.redhat.com/show_bug.cgi?id=417511 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||435601 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435601] Review Request: asm3 - A code manipulation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm3 - A code manipulation tool https://bugzilla.redhat.com/show_bug.cgi?id=435601 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||417511 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435601] New: Review Request: asm3 - A code manipulation tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=435601 Summary: Review Request: asm3 - A code manipulation tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://konrad.sobertillnoon.com/fedora/asm3.spec SRPM URL: http://konrad.sobertillnoon.com/fedora/asm3-3.1-1.fc8.src.rpm Description: ASM is a code manipulation tool to implement adaptable systems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435593] Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ocsinventory-agent - Open Computer and Software
Inventory Next Generation client
https://bugzilla.redhat.com/show_bug.cgi?id=435593
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 08:14 EST ---
(In reply to comment #4)
Yes i forget postinst.pl
I think i should simply remove it as .cfg is provided and the use of this
script
may conflict with rpm stuff (mainly the cron.d != cron.hourly).
Indeed. Or patch it if it is worth it.
About ocsinventory-client, i'm thinking of using epoch (i must check if this
is ok)
ocsinventory-client = 1:%{version}-%{release}
It is possible, but it would be better, in my opinion to avoid
epochs.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435514] Review Request: lbrickbuster2 - Brickbuster arcade game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lbrickbuster2 - Brickbuster arcade game https://bugzilla.redhat.com/show_bug.cgi?id=435514 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 417511] Review Request: jruby - Pure Java implementation of the Ruby interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jruby - Pure Java implementation of the Ruby interpreter https://bugzilla.redhat.com/show_bug.cgi?id=417511 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 07:51 EST --- retroweaver is something we don't need, so strike it off the list. GCJ claims to support Java 1.5.0, and Icedtea is the 1.7.0 devel branch, so something that provides support for 1.4.0 JVMs can easily be ommitted. Here is the current list: BRs in Fedora: * jline (old version) * junit BRs awaiting review: * asm3 (bug# 435601) * emma (bug# 227052) * jarjar (bug# 252082) * joda-time (bug# 227073) * joni (bug# 435598) BRs that are not in Fedora nor awaiting review: * jna (I hope to get this a review request soon) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435564] Review Request: lure - Lure of the Temptress - Adventure Game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lure - Lure of the Temptress - Adventure Game https://bugzilla.redhat.com/show_bug.cgi?id=435564 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 08:35 EST --- Trivial to review noarch packaging. But: * Package lure needs scummvm = 0.11.1, this is not available. With both Rawhide and F8. With the one from F8 it is incomplete (desktop file fails). With the one from Rawhide, it starts, but complains about an incorrect lure.dat version (1.28, expected 1.29) and drops back into X at 640x480 plus a frozen mouse-pointer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435514] Review Request: lbrickbuster2 - Brickbuster arcade game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: lbrickbuster2 - Brickbuster arcade game
https://bugzilla.redhat.com/show_bug.cgi?id=435514
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 08:43 EST ---
+ for good, - for bad, ? for questionable
MUST Items:
? rpmlint:
lbrickbuster2.x86_64: E: non-standard-executable-perm /usr/bin/lbrickbuster2
02551
lbrickbuster2.x86_64: E: non-standard-executable-perm /usr/bin/lbrickbuster2
02551
+ package named according to naming guidelines
+ spec file name matches base package name
+ packaging guidelines
+ license (GPLv2+)
+ license matches source files (I just checked game.c, assumed the rest are the
same)
+ COPYING included in RPM
+ spec is in en_US
+ spec is quite legible
+ sources match upstream
+ compiles/builds on x86_64
+ build dependencies listed in BR (tested on koji)
+ locales handled properly
+ if shared libraries, must call ldconfig (don't have any)
+ no Prefix: /usr
+ don't hostile takeover other packages' directories
+ no duplicate %files
? proper permissions on files (see rpmlint output above)
+ %clean section
- consistent use of macros (you mix $VARIABLES and %{variables})
+ package contains code and permissible content
+ no need for -doc
+ %doc doesn't affect runtime
+ no header files
+ no static libraries
+ no pkgconfig
+ no library files with suffixes
+ no devel package
+ no .la libtool archives
+ %{name}.desktop installed
+ package doesn't attempt to own other packages' files
+ %install cleans up build root
+ filenames are valid UTF8
SHOULD Items:
+ source includes license texts from upstream
? descriptions/summary don't contain non-English translations, but I doubt they
are available
+ package builds in mock
(http://koji.fedoraproject.org/koji/taskinfo?taskID=484020)
+ package compiles into binary RPMs on all archs (see above)
+ package functions as described (it's fun :))
+ no file dependencies
Clean up the macros and assure me that the permissions are OK and I'll set
fedora-review to +.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431186] Review Request: itools - Command line tools for The Islamic Tools and Libraries Project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: itools - Command line tools for The Islamic Tools and Libraries Project https://bugzilla.redhat.com/show_bug.cgi?id=431186 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 08:45 EST --- Thanks, Yeah, seems like it does not check at /usr/lib64. Patched configure.in and included a pre-generated configure script together to remove dependency from autotools. http://izhar.fedorapeople.org/itl/itools.spec http://izhar.fedorapeople.org/itl/itools-0.6.2-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435540] Review Request: lpsk31 - A ncurses application for ham radio communications using PSK31 digital mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lpsk31 - A ncurses application for ham radio communications using PSK31 digital mode https://bugzilla.redhat.com/show_bug.cgi?id=435540 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 09:41 EST --- RPM Lint: OK Package name: OK Spec file: OK License: OK (GPLv2+) Actual License: OK (GPLv2+ from source) %doc License: OK Spec file language: OK Spec file readable: OK Upstream source vs. used tarball: OK (md5sum match) Compile and Build: - F-7: OK - F-8: OK - rawhide: OK - EL-5: OK Applicable Package Guidelines: - -debuginfo package: OK (~68K) Locales: N/A Shared libs: N/A Relocatable: N/A Directory and file ownership: OK No duplicate files in %files: OK File Permissions: OK Macro usage: OK Code vs. Content: OK (Large) Documentation: OK %doc affecting runtime: OK Header files in -devel package: N/A Static Libraries in -static package: N/A pkgconfig Requires: N/A Library files: N/A Devel requires base package: N/A .la libtool archives: N/A Duplicate ownership of files/directories: OK Remove BuildRoot: OK UTF-8 filenames: OK Koji build --scratch dist-f9 succeeds: http://koji.fedoraproject.org/koji/taskinfo?taskID=484120 APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435234] Review Request: xdx - DX-cluster tcp/ip client for amateur radio
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio
https://bugzilla.redhat.com/show_bug.cgi?id=435234
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 09:55 EST ---
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK (GPLv2+)
Actual License: OK (GPLv2+ from source)
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
- F-7: FAILED (not targeted)
- F-8: OK
- rawhide: OK
- EL-5: FAILED (not targeted)
Applicable Package Guidelines:
- -debuginfo package: OK (~136K)
Locales: OK
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: N/A, OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: OK
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK
In the spec file you have:
#don't include backup file in package
rm -f `find $RPM_BUILD_ROOT -name *~`
which might result in a 'argument list too long' at some point, especially
larger packages. Consider using:
find $RPM_BUILD_ROOT -name *~ -exec rm -f {} \;
Quoting the -name *~ ensures it doesn't match against a file in $CWD
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xpsk31 - GTK+ graphical version of lpsk31 https://bugzilla.redhat.com/show_bug.cgi?id=435227 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 10:02 EST --- Koji build on dist-f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=484167 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435058] Review Request: splat - Analyze point-to-point terrestrial RF communication links
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: splat - Analyze point-to-point terrestrial RF communication links https://bugzilla.redhat.com/show_bug.cgi?id=435058 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 10:04 EST --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xpsk31 - GTK+ graphical version of lpsk31 https://bugzilla.redhat.com/show_bug.cgi?id=435227 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 10:03 EST --- Fails on missing po/Makefile.in.in: == configure: creating ./config.status config.status: creating Makefile config.status: creating src/Makefile config.status: error: cannot find input file: po/Makefile.in.in error: Bad exit status from /var/tmp/rpm-tmp.91780 (%build) == -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435540] Review Request: lpsk31 - A ncurses application for ham radio communications using PSK31 digital mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lpsk31 - A ncurses application for ham radio communications using PSK31 digital mode https://bugzilla.redhat.com/show_bug.cgi?id=435540 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 10:30 EST --- New Package CVS Request === Package Name: lpsk31 Short Description: A ncurses application for ham radio communications using PSK31 Owners: bjensen,sconklin Branches: F-7 F-8 InitialCC: sindgepb Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435234] Review Request: xdx - DX-cluster tcp/ip client for amateur radio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio https://bugzilla.redhat.com/show_bug.cgi?id=435234 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 10:25 EST --- New Package CVS Request === Package Name: xdx Short Description: DX-cluster tcp/ip client for amateur radio Owners: bjensen,sconklin Branches: F-7 F-8 InitialCC: sindgepb Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-hearts - Hearts game for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=435572 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:01 EST --- *** Bug 291741 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434911] Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio https://bugzilla.redhat.com/show_bug.cgi?id=434911 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:02 EST --- http://koji.fedoraproject.org/koji/taskinfo?taskID=484267 APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome https://bugzilla.redhat.com/show_bug.cgi?id=291741 [EMAIL PROTECTED] changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:01 EST --- *** This bug has been marked as a duplicate of 435572 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434911] Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio https://bugzilla.redhat.com/show_bug.cgi?id=434911 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:05 EST --- New Package CVS Request === Package Name: gmfsk Short Description: A Gnome Multimode HF Terminal for Ham Radio Owners: bjensen,sconklin Branches: F-7 F-8 InitialCC: sindgepb Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 314871] Review Request: gimp-lqr-plugin - GIMP LiquidRescale Plug-In
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gimp-lqr-plugin - GIMP LiquidRescale Plug-In https://bugzilla.redhat.com/show_bug.cgi?id=314871 Bug 314871 depends on bug 429202, which changed state. Bug 429202 Summary: Review Request: liblqr-1 - LiquidRescale library https://bugzilla.redhat.com/show_bug.cgi?id=429202 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431188] Review Request: minbar - Athan call and prayer times notification software
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification
software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:27 EST ---
For 0.2.1-5:
* GConf scriptlet
- I didn't notice before, but Requires(pre): GConf is
missing.
* sed usage
sed -i s|\(Utility;)\1|\1| %{name}.desktop.in
- The correct one is:
sed -i s|\(Utility;\)\1|\1| %{name}.desktop.in
Other things are okay.
--
This package (minbar) is APPROVED by me.
--
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432607] Review Request: kmid - A midi/karaoke player for KDE 4
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kmid - A midi/karaoke player for KDE 4
https://bugzilla.redhat.com/show_bug.cgi?id=432607
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:25 EST ---
MUST Items:
+ rpmlint output: as quoted by submitter, all harmless
! not entirely named and versioned according to the Package Naming Guidelines:
Release should be 0.2.%{svn_date}svn%{?dist} instead of 0.2.
%{svn_date}%{?dist}
+ spec file name matches base package name
+ Packaging Guidelines:
+ License GPLv2+ OK, matches actual license
+ No known patent problems
+ No emulator, no firmware, no binary-only or prebuilt components
+ Complies with the FHS
+ proper changelog, tags, BuildRoot, Requires, BuildRequires, Summary,
Description
+ no non-UTF-8 characters
+ relevant documentation included
+ RPM_OPT_FLAGS are used (%{cmake_kde4} macro)
+ debuginfo package is valid
+ no static libraries nor .la files
+ no duplicated system libraries
+ no rpaths on i386 and x86_64
+ no configuration files, so %config guideline doesn't apply
+ no init scripts, so init script guideline doesn't apply
+ GUI executable has .desktop file
+ .desktop file installed according to the guidelines (uses
desktop-file-install)
+ no timestamp-clobbering file commands
+ _smp_mflags used
+ scriptlets are valid
+ not a web application, so web application guideline doesn't apply
+ no conflicts
+ complies with all the legal guidelines
+ license included as %doc
+ complies with all the legal guidelines
* skipping source matches upstream test because this is a SVN checkout
+ builds on at least one arch (F9 all arches Koji scratch build)
+ no non-working arches, so no ExcludeArch needed
+ all build dependencies listed in CMakeLists.txt as well as cmake itself are
listed in BuildRequires
+ translations packaged according to the guidelines (%find_lang)
+ ldconfig correctly called in %post and %postun
+ package not relocatable
+ ownership correct (owns package-specific directories, doesn't own directories
owned by another package)
+ no duplicate files in %files
! permissions: -devel package missing %defattr(-,root,root,-)
+ %clean section present and correct
+ macros used where possible
! non-code content: examples (examples/*.kar) have suspicious copyright status
* DiesIrae.kar: Mozart, sequencing (c) 1996 V. Palleschi, may or may not be
OK, depending on whether V. Palleschi allowed this
* Guantanamera.kar: JoseÃto Fernández (1908-1979), almost certainly a
copyright violation
* MariaDeLasMercedes.kar: Concha Piquer (1908-1990), almost certainly a
copyright violation
* OFortuna.kar: from the Carmina Burana, music by Carl Orff (1895-1982),
almost certainly a copyright violation
IMHO we should probably remove the examples entirely (even from the tarball).
+ no large documentation files, so no -doc package needed
+ %doc files not required at runtime
+ all header files in -devel
+ no static libraries, so no -static package needed
+ no .pc files, so no Requires: pkgconfig needed
+ devel symlinks correctly in -devel
+ /usr/lib/kde4/*.so plugins (NOT symlinks) are correctly NOT in -devel
+ -devel Requires: %{name} = %{version}-%{release}
+ no .la files
+ GUI executable has .desktop file
+ buildroot is deleted at the beginning of %install
+ all filenames are valid UTF-8
SHOULD Items:
+ license included as %doc
+ no translations for description and summary provided by upstream
+ package builds in mock (Koji scratch build)
+ package builds on all architectures (Koji scratch build)
+ basic functionality tested on F8, works fine
+ scriptlets are sane
+ no subpackages other than -devel, so Usually, subpackages other than devel
should require the base package using a fully versioned dependency. is
irrelevant
+ no .pc files, so placement of .pc files is irrelevant
+ no file dependencies
MUST FIX:
* add svn to the Release tag (after the date)
* add missing %defattr(-,root,root,-) in %files devel
* remove examples (suspicious copyright status)
Fix these and I'll approve this. One thing I'm not sure is how much sense it
makes to provide kmid-devel, I don't think anything other than kmid itself
actually uses the kmid libs.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files https://bugzilla.redhat.com/show_bug.cgi?id=434704 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:47 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431188] Review Request: minbar - Athan call and prayer times notification software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: minbar - Athan call and prayer times notification software https://bugzilla.redhat.com/show_bug.cgi?id=431188 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:45 EST --- Thanks tasaka-san New Package CVS Request === Package Name: minbar Short Description: Athan call and prayer times notification software Owners: izhar Branches: F-7 F-8 InitialCC: izhar Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429202] Review Request: liblqr-1 - LiquidRescale library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: liblqr-1 - LiquidRescale library https://bugzilla.redhat.com/show_bug.cgi?id=429202 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429202] Review Request: liblqr-1 - LiquidRescale library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: liblqr-1 - LiquidRescale library https://bugzilla.redhat.com/show_bug.cgi?id=429202 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:34 EST --- Please don't forget to rebuild this package also on F-7/8. Also, for F-7/8, please request the rebuilt packages to push to stable on: https://admin.fedoraproject.org/updates/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xfhell - GTK based Ham Radio application for the
Hellschreiber communications mode
https://bugzilla.redhat.com/show_bug.cgi?id=435541
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|ASSIGNED|NEEDINFO
Flag||needinfo?([EMAIL PROTECTED]
||g)
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:49 EST ---
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK (GPLv2+)
Actual License: OK (GPLv2+ from source code)
%doc License: OK (COPYING file included)
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match after figuring out the exact
location of the upstream tarball)
Compile and Build:
- F-7: OK
- F-8: OK
- rawhide: OK
- EL-5: OK
- koji scratch dist-f9: OK
Applicable Package Guidelines:
- -debuginfo package: OK (~136K)
Locales: N/A
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK
Please adjust Source0 location to
http://5b4az.chronos.org.uk/pkg/%{name}/%{name}-%{version}.tar.gz please
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435058] Review Request: splat - Analyze point-to-point terrestrial RF communication links
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: splat - Analyze point-to-point terrestrial RF communication links https://bugzilla.redhat.com/show_bug.cgi?id=435058 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:06 EST --- New Package CVS Request === Package Name: splat Short Description: Analyze point-to-point terrestrial RF communication links Owners: sconklin, bjensen Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431188] Review Request: minbar - Athan call and prayer times notification software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: minbar - Athan call and prayer times notification software https://bugzilla.redhat.com/show_bug.cgi?id=431188 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:09 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434911] Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio https://bugzilla.redhat.com/show_bug.cgi?id=434911 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:12 EST --- Per the conversation on irc, do fix the versioning here before importing... cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431188] Review Request: minbar - Athan call and prayer times notification software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: minbar - Athan call and prayer times notification software https://bugzilla.redhat.com/show_bug.cgi?id=431188 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:16 EST --- thanks all -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429107] Review Request: couchdb - Couchdb is a document database server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: couchdb - Couchdb is a document database server https://bugzilla.redhat.com/show_bug.cgi?id=429107 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||) --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 11:59 EST --- @ditesh no update about this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435234] Review Request: xdx - DX-cluster tcp/ip client for amateur radio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio https://bugzilla.redhat.com/show_bug.cgi?id=435234 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:15 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 431098] Review Request: gambas2 - IDE based on a basic interpreter with object extensions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gambas2 - IDE based on a basic interpreter with object
extensions
https://bugzilla.redhat.com/show_bug.cgi?id=431098
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:44 EST ---
Created an attachment (id=296517)
-- (https://bugzilla.redhat.com/attachment.cgi?id=296517action=view)
rpmlint for gambase
For 2.2.1-2:
* rpmlint
- First of all, would would shut up rpmlint warnings/errors
as much as possible? (rpmlint results attached)
* Duplicate file entry
-
[EMAIL PROTECTED] gambas2]$ rpm -qlp *i386*rpm | sort | uniq -d
/usr/bin/gambas2
/usr/bin/gambas2.gambas
/usr/share/mime/packages
-
- Please resolve this.
* Compilation flags
-
5700 make[4]: Entering directory
`/builddir/build/BUILD/gambas2-2.2.1/main/gbx'
5701 /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
-I.. -I../share-I../libltdl -I/usr/lib/libffi-3.0.1/include -DGBX_INFO
-O2 -g -pipe -Wall -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -pipe -Wall
-Wno-unused-value -fvisibility=hidden -g -Os -O0 -MT gb_la-gbx_c_class.lo -MD
-MP -MF .deps/gb_la-gbx_c_class.Tpo -c -o gb_la-gbx_c_class.lo `test -f
'gbx_c_class.c' || echo './'`gbx_c_class.c
-
- -O2 option is finally replaced by -O0.
-
6430 make[4]: Entering directory
`/builddir/build/BUILD/gambas2-2.2.1/gb.db.sqlite3/src'
6431 /bin/sh ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I.
-I..-pipe -Wall -fno-exceptions -Wno-unused-value -fvisibility=hidden -g
-Os -fno-omit-frame-pointer -MT main.lo -MD -MP -MF .deps/main.Tpo -c -o
main.lo main.cpp
( and many lines below this line )
--
- Here Fedora specific compilation flags are ignored.
* Timestamps
- I guess for this package
--
make DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p install
--
works to keep timestamps on installed files.
- When using install or cp commands, please add -p option
to keep timestamps.
* Directory ownership issue
- From my directory ownership check,
--
Owned by directory
shared-mime-info-0.23-3.fc9 /usr/share/mime/packages
gambas2-runtime-2.2.1-2.fc9
gambas2-script-2.2.1-2.fc9
--
* Macros
- Use macros correctly. For example, /usr/bin must be %{_bindir}.
* Scriptlet
- Calling update-desktop-database is not needed because
fedora-gambas2.desktop does not contain any MimeType key.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434911] Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio https://bugzilla.redhat.com/show_bug.cgi?id=434911 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:46 EST --- Fixed NVR New srpm: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/gmfsk-0.7-0.5.pre1.fc9.src.rpm New spec: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/gmfsk.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435540] Review Request: lpsk31 - A ncurses application for ham radio communications using PSK31 digital mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lpsk31 - A ncurses application for ham radio communications using PSK31 digital mode https://bugzilla.redhat.com/show_bug.cgi?id=435540 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:17 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435042] Review Request: gpsman - GPS data manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gpsman - GPS data manager https://bugzilla.redhat.com/show_bug.cgi?id=435042 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435058] Review Request: splat - Analyze point-to-point terrestrial RF communication links
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: splat - Analyze point-to-point terrestrial RF communication links https://bugzilla.redhat.com/show_bug.cgi?id=435058 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:23 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433892] Review Request: xfce4-gsynaptics-mcs-plugin - GSynaptics icon for the Xfce Settings Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-gsynaptics-mcs-plugin - GSynaptics icon for the Xfce Settings Manager https://bugzilla.redhat.com/show_bug.cgi?id=433892 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:13 EST --- I'd be happy to review this package. Look for a full review in a bit here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode https://bugzilla.redhat.com/show_bug.cgi?id=435541 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |g) | --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:18 EST --- New Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xfhell.spec New SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xfhell-1.4-4.fc8.src.rpm Scratch built in koji for devel URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=484636 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435514] Review Request: lbrickbuster2 - Brickbuster arcade game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lbrickbuster2 - Brickbuster arcade game https://bugzilla.redhat.com/show_bug.cgi?id=435514 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:48 EST --- The executable should probably have 02755 perms rather than 02551. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 426026] Review Request: gnome-menu-extended - Gnome Menu with KDE directory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-menu-extended - Gnome Menu with KDE directory https://bugzilla.redhat.com/show_bug.cgi?id=426026 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 12:54 EST --- IMO submitting a RFE is the best idea for now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 434630] Review Request: ocaml-perl4caml - OCaml library for calling Perl libraries and code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-perl4caml - OCaml library for calling Perl libraries and code https://bugzilla.redhat.com/show_bug.cgi?id=434630 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:43 EST --- rpmlint has grown complaints about the license: W: invalid-license LGPLv2+ with exceptions but that's bogus. This package seems fine to me now. I guess you could just delete the block of commended out dependencies, and you should probably take the rpath thing to the committee because my understanding was always that the issue was an rpath containing one of the standard directories (like /usr/lib64) that caused the main issue. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435370] Review Request: cpdup - Filesystem mirroring utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cpdup - Filesystem mirroring utility https://bugzilla.redhat.com/show_bug.cgi?id=435370 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:41 EST --- Please don't file non review requests in package review. ;) New packages will not have bugzilla entries during the review process, so they should put this description in the comment until the package is approved, then file the bugzilla entry, and replace the long explanation with the bug number. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430931] Review Request: kate-ctags-plugin - Plugin for Kate editor to use ctags
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kate-ctags-plugin - Plugin for Kate editor to use ctags https://bugzilla.redhat.com/show_bug.cgi?id=430931 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||) --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:46 EST --- No response to comments in a month; setting needinfo. I will close in one week if there is no response. http://fedoraproject.org/wiki/PackageMaintainers/Policy/StalledReviews -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435623] New: Review Request: php-pdb - PHP classes for manipulating Palm OS databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=435623 Summary: Review Request: php-pdb - PHP classes for manipulating Palm OS databases Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://richardfearn.co.uk/files/fedora/php-pdb-1.3.4-1/php-pdb.spec SRPM URL: http://richardfearn.co.uk/files/fedora/php-pdb-1.3.4-1/php-pdb-1.3.4-1.fc8.src.rpm Description: Hello, I'm looking for a sponsor for my second package, php-pdb. PHP-PDB is a set of PHP classes that manipulate Palm OS databases. It lets you read, write, alter, and easily use data that is meant to be sent to or retrieved from a handheld. The SRPM builds using mock against Fedora 8 and development. The resulting RPMs are both rpmlint clean. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 314871] Review Request: gimp-lqr-plugin - GIMP LiquidRescale Plug-In
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gimp-lqr-plugin - GIMP LiquidRescale Plug-In
https://bugzilla.redhat.com/show_bug.cgi?id=314871
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:26 EST ---
For 0.4.0.4-1:
* Requires
- Requires: liblqr-1 = 0.1.0 is not needed. Library dependencies
like these are automatically checked and added by rpmbuild itself.
- Requires: perl(XML::Parser) is not needed. This is used only
for BuildRequires.
* BuildRequires
- BuildRequres: gimp is not needed (BuildRequires: gimp-devel
is needed)
* Directoy ownership issue
- The directory %{_datadir}/gimp-lqr-plugin is not owned by
any package.
* %changelog
- It is preferable you write %changelog as:
-
* Wed Feb 20 2008 Alexandru Ciobanu [EMAIL PROTECTED] - 0.4.0.4-1
- Remode hyphen from versioning.
* Tue Feb 19 2008 Alexandru Ciobanu [EMAIL PROTECTED] - 0.4.0-3
- Fixed licensing issue.
* Mon Feb 4 2008 Alexandru Ciobanu [EMAIL PROTECTED] - 0.4.0-2
-
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435623] Review Request: php-pdb - PHP classes for manipulating Palm OS databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pdb - PHP classes for manipulating Palm OS databases https://bugzilla.redhat.com/show_bug.cgi?id=435623 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433892] Review Request: xfce4-gsynaptics-mcs-plugin - GSynaptics icon for the Xfce Settings Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-gsynaptics-mcs-plugin - GSynaptics icon for the Xfce Settings Manager https://bugzilla.redhat.com/show_bug.cgi?id=433892 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:26 EST --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 57ecdd4983ab55614019d4b5a581398e gsynaptics-mcs-plugin-1.0.0.tar.bz2 57ecdd4983ab55614019d4b5a581398e gsynaptics-mcs-plugin-1.0.0.tar.bz2.spec OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. rpmlint says: xfce4-gsynaptics-mcs-plugin-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package xfce4-gsynaptics-mcs-plugin. Just due to the length of package name I guess. Ignore. No other issues that I see here, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435231] Review Request: xlog - Logging program for Ham Radio Operators
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xlog - Logging program for Ham Radio Operators https://bugzilla.redhat.com/show_bug.cgi?id=435231 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433422] Review Request: perl-IP-Country - Fast lookup of country codes from IP addresses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-IP-Country - Fast lookup of country codes from IP addresses https://bugzilla.redhat.com/show_bug.cgi?id=433422 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||182235 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:51 EST --- I guess I forgot to set the legal blocker here; I'll do that now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226119] Merge Review: MAKEDEV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: MAKEDEV https://bugzilla.redhat.com/show_bug.cgi?id=226119 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:55 EST --- Todd: Are you reviewing this package? Please set the fedora-review flag to ? if you are, and if not, you might want to move it back to being assigned to [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432310] Review Request: compat-guichan06 - compatibility package for older guichan release
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: compat-guichan06 - compatibility package for older guichan release https://bugzilla.redhat.com/show_bug.cgi?id=432310 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:54 EST --- I think it should stick around, but for F-8 only. For F-9 we can upgrade to guichan-0.7.1 and rebuild the affected packages. I'd also still like to upgrade guichan for F-8 to help fix a lingering manaworld bug, but think that at least the .so bits from guichan 0.6 should remain in case any users have locally built packages that need them. The guichan 0.6.1 -devel bits can be dropped, however. I'll update this package in the next day or so, and let you know in the same timeframe when I'm about to push guichan-0.7.1 to rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435593] Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/show_bug.cgi?id=435593 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:59 EST --- Spec URL: http://remi.fedorapeople.org/ocsinventory-agent.spec SRPM URL: http://remi.fedorapeople.org/ocsinventory-agent-0.0.8.2-0.2.20080302.fc8.src.rpm - Fix CVS command in comment - Fix BR - Provides: ocsinventory-client = 1.02 - rename to README.RPM (as it provides information for RPM customisation) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433488] Review Request: dayplanner - An easy and clean Day Planner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dayplanner - An easy and clean Day Planner https://bugzilla.redhat.com/show_bug.cgi?id=433488 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433488] Review Request: dayplanner - An easy and clean Day Planner
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: dayplanner - An easy and clean Day Planner
https://bugzilla.redhat.com/show_bug.cgi?id=433488
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 14:08 EST ---
Created an attachment (id=296520)
-- (https://bugzilla.redhat.com/attachment.cgi?id=296520action=view)
Current holidays in Japan
For quick glance:
- Please avoid to use %makeinstall if possible.
- Japanese current holidays are attached.
- The line chmod a-x must be dealt with more preferable way.
* One can easy imagine that the installed files list changes in the
next version.
find $RPM_BUILD_ROOT%{_datadir}/%{name} -name \*.pm -exec chmod 0644 {} \;
can replace the current line, I guess.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433488] Review Request: dayplanner - An easy and clean Day Planner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dayplanner - An easy and clean Day Planner https://bugzilla.redhat.com/show_bug.cgi?id=433488 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #296520|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 14:12 EST --- Created an attachment (id=296522) -- (https://bugzilla.redhat.com/attachment.cgi?id=296522action=view) Current holidays in Japan (spell fixed) NAOJ = National Astronomy Observatory of Japan... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225301] Merge Review: automake17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: automake17 https://bugzilla.redhat.com/show_bug.cgi?id=225301 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 13:45 EST --- Patrice: Are you reviewing this? It seems so, so I am setting fedora-review: ? If not, feel free to reset and unassign. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432205] Review Request: exe - eXe eLearning XHTML editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: exe - eXe eLearning XHTML editor https://bugzilla.redhat.com/show_bug.cgi?id=432205 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 14:35 EST --- Taking this for review. (In reply to comment #0) Note to reviewers, exe uses an included (older) copy of twisted and nevow (which builds on top of twisted). I've tried making exe use the system version of both, but it will not work with the system version. What did it fail for -- isn't it easily fixable? Do you by chance still have the build logs? Did you communicate that upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226119] Merge Review: MAKEDEV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: MAKEDEV https://bugzilla.redhat.com/show_bug.cgi?id=226119 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:11 EST --- Sorry for not getting to this one sooner Kevin. I'll finish up a full review shortly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:17 EST --- This all looks good to me. I guess the bad test could be troublesome but if you don't have a problem with then I won't worry about it. I guess if you're not going to need the commented-out scriptlets you could remove them so the spec looks cleaner, but that's really minor. Which name did you think was too generic? I guess typesizes.mod might be, but I don't know how many .mod files we're going to end up seeing. Everything else seemed to me to be prefixed, in a subdirectory or simply named such that conflicts would be improbable. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:29 EST --- (In reply to comment #3) This all looks good to me. I guess the bad test could be troublesome but if you don't have a problem with then I won't worry about it. According to upstream it is fixed, but upstream also asked me to wait for the next release to make a release. I guess if you're not going to need the commented-out scriptlets you could remove them so the spec looks cleaner, but that's really minor. I am discussing adding shared libs with the debian maintainer (upstream agreed), so I'll prefer to keep them. Which name did you think was too generic? I guess typesizes.mod might be, but I don't know how many .mod files we're going to end up seeing. Everything else seemed to me to be prefixed, in a subdirectory or simply named such that conflicts would be improbable. It is because I prefixed 2 of them... .mod files should really not be generic, I hope that we end up with a lof of .mod files... Thanks for the review! New Package CVS Request === Package Name: grib_api Short Description: ECMWF encoding/decoding GRIB software Owners: pertusus Branches: InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435564] Review Request: lure - Lure of the Temptress - Adventure Game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lure - Lure of the Temptress - Adventure Game https://bugzilla.redhat.com/show_bug.cgi?id=435564 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:46 EST --- (In reply to comment #1) Trivial to review noarch packaging. But: Thanks! * Package lure needs scummvm = 0.11.1, this is not available. With both Rawhide and F8. Oops, I prepared a scummvm-0.11.1, but somehow forgot to commit, tag and build it. Its on its way to rawhide now. I plan to build and release it for F-8 together with lure as one update. With the one from F8 it is incomplete (desktop file fails). Thats expected its to old. With the one from Rawhide, it starts, but complains about an incorrect lure.dat version (1.28, expected 1.29) and drops back into X at 640x480 plus a frozen mouse-pointer. The incorrect lure.dat message is expected, thats why it needs 0.11.1 not 0.11.0, the X being in the low resolution and frozen mouse pointer isn't. I had the same error with 0.11.1 the other way around (too old lure.dat) and there after the error the resolution and mouse were restored properly, so I guess this is fixed with 0.11.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 314871] Review Request: gimp-lqr-plugin - GIMP LiquidRescale Plug-In
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gimp-lqr-plugin - GIMP LiquidRescale Plug-In https://bugzilla.redhat.com/show_bug.cgi?id=314871 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:25 EST --- Spec URL: http://tvtransilvania.ro/ics/Fedora/devel/gimp-lqr-plugin.spec SRPM URL: http://tvtransilvania.ro/ics/Fedora/devel/gimp-lqr-plugin-0.4.0.4-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225301] Merge Review: automake17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: automake17 https://bugzilla.redhat.com/show_bug.cgi?id=225301 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag|fedora-review? | --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:22 EST --- Resetting and unnassigning since I am in disagreement with the packager and I won't approve the Obsoletes 1.8. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 245688] Review Request: python-pywbem - Python WBEM client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-pywbem - Python WBEM client https://bugzilla.redhat.com/show_bug.cgi?id=245688 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|NEW Flag|needinfo?([EMAIL PROTECTED]) | --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:22 EST --- Hi Jason and Yaakov. I'll address the review points and update the package. Thanks, Tim. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226119] Merge Review: MAKEDEV
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: MAKEDEV
https://bugzilla.redhat.com/show_bug.cgi?id=226119
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:48 EST ---
Greetings Chris and Nalin,
Here be a merge review for MAKEDEV.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
See below - Meets Packaging Guidelines.
See below - License = GPLv2+
See below - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch. (see koji :)
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
See below - final provides and requires are sane:
MAKEDEV-3.23-3.i386.rpm
Provides:
-
config(MAKEDEV) = 3.23-3
MAKEDEV = 3.23-3
Requires:
-
/bin/sh
/usr/sbin/groupadd
/usr/sbin/useradd
config(MAKEDEV) = 3.23-3
grep
libc.so.6
libselinux.so.1
mktemp
rtld(GNU_HASH)
MAKEDEV-3.23-3.src.rpm
Provides:
-
(none)
Requires:
-
libselinux-devel
SHOULD Items:
OK - Should build in mock. (again see koji for proof :)
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have sane scriptlets.
OK - Should package latest version
See below - Outstanding bugs on package.
Issues:
1. http://fedoraproject.org/wiki/Packaging/SourceURL suggests adding a comment
above Source0 when we are upstream. Would there be any value in setting up a
fedorahosted project for the sources to MAKEDEV?
2. The License tag needs to be updated. However, the source package license
also needs adjusted to meet Red Hat policy. The license should be GPLv2 only
(no or any later version) according to CopyrightGuidelines on the Red Hat
intranet (so I am told). MAKEDEV.c, mksock.c, and sel.h all include the or any
later version in the header. This should be fixed and the License tag then
changed to GPLv2.
3. The buildroot tag must be one of the following, according to
http://fedoraproject.org/wiki/Packaging/Guidelines#line-181:
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
%{_tmppath}/%{name}-%{version}-%{release}-root
4. rpmlint output:
$ rpmlint MAKEDEV-3.23-3.src.rpm
MAKEDEV.src:10: W: buildprereq-use libselinux-devel
MAKEDEV.src:12: W: prereq-use /usr/sbin/groupadd, /usr/sbin/useradd, grep,
mktemp
MAKEDEV.src:465: W: macro-in-%changelog post
MAKEDEV.src:494: W: macro-in-%changelog _sysconfdir
MAKEDEV.src: W: summary-ended-with-dot A program used for creating device files
in /dev.
MAKEDEV.src: W: invalid-license GPL
$ rpmlint MAKEDEV-3.23-3.i386.rpm
MAKEDEV.i386: W: summary-ended-with-dot A program used for creating device files
in /dev.
MAKEDEV.i386: W: invalid-license GPL
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/00macros
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01alsa
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01cciss
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01cdrom
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01console
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01dac960
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01ftape
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01generic
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01ia64
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01ibcs
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01ida
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01ide
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01ipfilter
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01isdn
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01linux-2.6.x
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01linux1394
MAKEDEV.i386: W: conffile-without-noreplace-flag /etc/makedev.d/01mouse
MAKEDEV.i386: W:
[Bug 226119] Merge Review: MAKEDEV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: MAKEDEV https://bugzilla.redhat.com/show_bug.cgi?id=226119 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:51 EST --- Created an attachment (id=296525) -- (https://bugzilla.redhat.com/attachment.cgi?id=296525action=view) Patch cleaning up most of the rpmlint complaints and other minor issues for merge review Feel free to use some/all/none of this, with or without attribution. I seek neither fame nor fortune in the MAKEDEV changelog. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432205] Review Request: exe - eXe eLearning XHTML editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: exe - eXe eLearning XHTML editor https://bugzilla.redhat.com/show_bug.cgi?id=432205 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:50 EST --- (In reply to comment #1) Taking this for review. (In reply to comment #0) Note to reviewers, exe uses an included (older) copy of twisted and nevow (which builds on top of twisted). I've tried making exe use the system version of both, but it will not work with the system version. What did it fail for -- isn't it easily fixable? It builds and runs, but doesn't work. With some python warnings thrown to the console. Since I'm a bit of a python noob, it isn't easily fixable for me. Notice that it will only run with the newer bits when replacing both twisted and nevow, replacing only one is a recipe for even bigger disaster. Did you communicate that upstream? Erm, no, will do. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435234] Review Request: xdx - DX-cluster tcp/ip client for amateur radio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio https://bugzilla.redhat.com/show_bug.cgi?id=435234 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 16:57 EST --- xdx-2.4-2.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435058] Review Request: splat - Analyze point-to-point terrestrial RF communication links
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: splat - Analyze point-to-point terrestrial RF communication links https://bugzilla.redhat.com/show_bug.cgi?id=435058 --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 17:02 EST --- splat-1.2.1-6.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
