[Bug 438293] Review Request: monosim- Manage your SIM Card contacts with pcsc readers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: monosim- Manage your SIM Card contacts with pcsc readers https://bugzilla.redhat.com/show_bug.cgi?id=438293 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 02:42 EST --- New Package CVS Request === Package Name: monosim Short Description: Manage your SIM Card contacts with pcsc readers Owners: hman-it Branches: F-7 F-8 InitialCC: [EMAIL PROTECTED] Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429882] Review Request: python-Levenshtein - Levenshtein distance measurement library in C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-Levenshtein - Levenshtein distance measurement library in C https://bugzilla.redhat.com/show_bug.cgi?id=429882 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||439140 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226216] Merge Review: openoffice.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: openoffice.org https://bugzilla.redhat.com/show_bug.cgi?id=226216 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 05:55 EST --- Package Change Request == Package Name: openoffice.org New Branches: F-9 I'd like an early branch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429882] Review Request: python-Levenshtein - Levenshtein distance measurement library in C
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-Levenshtein - Levenshtein distance measurement
library in C
https://bugzilla.redhat.com/show_bug.cgi?id=429882
--- Additional Comments From [EMAIL PROTECTED] 2008-03-27 06:00 EST ---
Thanks David,
(In reply to comment #5)
(In reply to comment #4)
[!] Rpmlint output:
source RPM: python-Levenshtein.src:26: E: use-of-RPM_SOURCE_DIR
binary RPM: empty
You should rather use %SOURCE1 to refer to the location of the source file.
Also, this source file should be pointed to a URL from whence it can be
downloaded. It may be good to make a package for genextdoc, and then you can
just say BuildRequires and run it normally
Fixed - not worth packaging genextdoc separately.
[?] Sources used to build the package matches the upstream source, as
provided
in the spec URL.
This is hard to check because the original website has disappeared, and the
spec
URL provided points to the translate package download copy. Either taking over
maintenance of the project, or getting the author to resurrect it would solve
this.
I did check against versions from the web archive successfully:
SHA1SUM of tar.bz2:d630141e003f47a43e0f8eacdcbf593bf9d15ed6
http://web.archive.org/web/20070305015113/trific.ath.cx/Ftp/python/levenshtein/python-Levenshtein-0.10.1.tar.bz2
Have left/tried to leave comment on the new blog.
Also as noted above, genextdoc.py should be placed on a public URL
Not that critical I think. Its as valuable as a patch
Also, it would be good to use %{version} for the version in the source URL
Fixed.
[?] Reviewer should test that the package builds in mock.
Tested on: devel/x86_64
[?] Package should compile and build into binary rpms on all supported
architectures.
Tested on: i386
Not sure myself how to do a mock build
Will upload new SRPM and SPEC
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439141] New: Review Request: python-demjson - Python JSON module and lint checker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439141 Summary: Review Request: python-demjson - Python JSON module and lint checker Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://thm.fedorapeople.org/python-demjson.spec SRPM URL: http://thm.fedorapeople.org/python-demjson-1.3-1.fc8.src.rpm Description: This module provides classes and functions for encoding or decoding data represented in the language-neutral JSON format (which is often used as a simpler substitute for XML in Ajax web applications). This implementation tries to be as compliant to the JSON specification (RFC 4627) as possible, while still providing many optional extensions to allow less restrictive JavaScript syntax. It includes complete Unicode support, including UTF-32, BOM, and surrogate pair processing. It can also support JavaScript's NaN and Infinity numeric types as well as it's 'undefined' type. It also includes a lint-like JSON syntax validator which tests JSON text for strict compliance to the standard. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429882] Review Request: python-Levenshtein - Levenshtein distance measurement library in C
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-Levenshtein - Levenshtein distance measurement
library in C
https://bugzilla.redhat.com/show_bug.cgi?id=429882
--- Additional Comments From [EMAIL PROTECTED] 2008-03-27 06:16 EST ---
Spec URL:
http://translate.sourceforge.net/releases/testing/fedora/python-Levenshtein-0.10.1-5.spec
SRPM URL:
http://translate.sourceforge.net/releases/testing/fedora/python-Levenshtein-0.10.1-5.fc8.src.rpm
New SRPM and SPEC to address the last issue of using Source1 instead of Patch.
$RPM_SOURCE_DIR - fixed
%{version} - fixed
Busy checking out mock
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439142] New: Review Request: main package name here - short summary here
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439142 Summary: Review Request: main package name here - short summary here Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Model-LDAP.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Model-LDAP-0.16-1.fc9.src.rpm Description: This is the Net::LDAP model class for Catalyst. It is nothing more than a simple wrapper for Net::LDAP. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439142] Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst https://bugzilla.redhat.com/show_bug.cgi?id=439142 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: main |Review Request: perl- |package name here - short |Catalyst-Model-LDAP - LDAP |summary here |model class for Catalyst -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439147] New: Review Request: hunspell-gd - Scots Gaelic hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439147 Summary: Review Request: hunspell-gd - Scots Gaelic hunspell dictionaries Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-gd.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-gd-0.1.1-1.fc9.src.rpm Description: Provide Scots Gaelic spell checking dictionaries for hunspell (OOo, firefox, etc) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439147] Review Request: hunspell-gd - Scots Gaelic hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-gd - Scots Gaelic hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439147 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 07:08 EST --- Review: + package builds in mock. koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=533952 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 339ef31ff72f55cdb951d06f58a87257 ispell-gd-0.1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439142] Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst https://bugzilla.redhat.com/show_bug.cgi?id=439142 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 07:12 EST --- you need BuildRequires: perl(Test::Pod) = 1.14 BuildRequires: perl(Test::Pod::Coverage) = 1.04 as make test need them. see t/02pod...skipped all skipped: Test::Pod 1.14 required t/03podcoverage...skipped all skipped: Test::Pod::Coverage 1.04 required -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439152] New: Review Request: perl-Catalyst-Plugin-StackTrace - Display a stack trace on the Catalyst debug screen
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439152 Summary: Review Request: perl-Catalyst-Plugin-StackTrace - Display a stack trace on the Catalyst debug screen Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Plugin-StackTrace.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Plugin-StackTrace-0.07-1.fc9.src.rpm Description: This plugin will enhance the standard Catalyst debug screen by including a stack trace of your appliation up to the point where the error occurred. Each stack frame is displayed along with the package name, line number, file name, and code context surrounding the line number. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439142] Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst https://bugzilla.redhat.com/show_bug.cgi?id=439142 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 07:26 EST --- Fixed in http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Model-LDAP-0.16-2.fc9.src.rpm The build process still ignores these, as TEST_POD isn't set - should the specfile be enabling these optional tests, or not, though? Upstream presumably has a reason for not running them by default. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439147] Review Request: hunspell-gd - Scots Gaelic hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-gd - Scots Gaelic hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439147 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 07:29 EST --- New Package CVS Request === Package Name: hunspell-gd Short Description: Scots Gaelic Hunspell Dictionary Owners: caolanm Branches: InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439152] Review Request: perl-Catalyst-Plugin-StackTrace - Display a stack trace on the Catalyst debug screen
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-StackTrace - Display a stack trace on the Catalyst debug screen https://bugzilla.redhat.com/show_bug.cgi?id=439152 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 07:36 EST --- panemade pointed out a problem with another of my packages, that's also in this one - it needs to BuildRequire Test::Pod and Test::Pod::Coverage. I've done a pre-review respin to address this. SPEC URL as above, new SRPM is http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Plugin-StackTrace- 0.07-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439141] Review Request: python-demjson - Python JSON module and lint checker
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2008-03-27 07:38 EST ---
Not needed now following as per python packaging guidelines
%if 0%{?fedora} = 8
BuildRequires: python-setuptools-devel
%else
BuildRequires: python-setuptools
%endif
But add only
BuildRequires: python-setuptools-devel
also, drop INSTALL.txt from %doc
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439155] New: Review Request: hunspell-fo - Faroese hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439155 Summary: Review Request: hunspell-fo - Faroese hunspell dictionaries Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-fo.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-fo-0.2.32-1.fc9.noarch.rpm Description: Faroese hunspell dictionaries for use with OOo, firefox, etc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439157] New: Review Request: perl-Catalyst-View-JSON - JSON view for your Catalyst data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439157 Summary: Review Request: perl-Catalyst-View-JSON - JSON view for your Catalyst data Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-View-JSON.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-View-JSON-0.24-1.fc9.src.rpm Description: Catalyst::View::JSON is a Catalyst View handler that returns stash data in JSON format. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439142] Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst https://bugzilla.redhat.com/show_bug.cgi?id=439142 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:06 EST --- Review: + package builds in mock. Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=534006 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0ccbf7239d3bed85fe3f588a28a5c268 Catalyst-Model-LDAP-0.16.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful, 7 tests skipped. Files=9, Tests=8, 2 wallclock secs ( 1.25 cusr + 0.05 csys = 1.30 CPU) + Package perl-Catalyst-Model-LDAP-0.16-2.fc9 = Provides: perl(Catalyst::Helper::Model::LDAP) perl(Catalyst::Model::LDAP) = 0.16 perl(Catalyst::Model::LDAP::Connection) perl(Catalyst::Model::LDAP::Entry) perl(Catalyst::Model::LDAP::Search) Requires: perl(Carp) perl(Catalyst::Model::LDAP::Search) perl(Class::C3) perl(Data::Page) perl(Net::LDAP::Constant) perl(Net::LDAP::Control::Sort) perl(Net::LDAP::Control::VLV) perl(base) perl(strict) perl(warnings) SHOULD: Try adding line to enable tests in %check export TEST_POD=1 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439152] Review Request: perl-Catalyst-Plugin-StackTrace - Display a stack trace on the Catalyst debug screen
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-StackTrace - Display a stack trace on the Catalyst debug screen https://bugzilla.redhat.com/show_bug.cgi?id=439152 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:12 EST --- Review: + package builds in mock. Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=534017 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4bd2dc12f9b6f6bb310c1fe07a8321f1 Catalyst-Plugin-StackTrace-0.07.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful, 3 tests skipped. Files=9, Tests=24, 2 wallclock secs ( 1.88 cusr + 0.13 csys = 2.01 CPU) +Package perl-Catalyst-Plugin-StackTrace-0.07-2.fc9 = Provides: perl(Catalyst::Plugin::StackTrace) = 0.07 Requires: perl = 0:5.008001 perl(Devel::StackTrace) perl(HTML::Entities) perl(NEXT) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) SHOULD: 1)Try adding line to enable tests in %check export TEST_POD=1 MUST: 1) Drop redundant BR BuildRequires: perl = 1:5.8.1 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439141] Review Request: python-demjson - Python JSON module and lint checker
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
--- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:18 EST ---
(In reply to comment #1)
Not needed now following as per python packaging guidelines
%if 0%{?fedora} = 8
BuildRequires: python-setuptools-devel
%else
BuildRequires: python-setuptools
%endif
Isn't this necessary to successfully build for F-7?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439155] Review Request: hunspell-fo - Faroese hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-fo - Faroese hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439155 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:23 EST --- can you provide source rpm url? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439155] Review Request: hunspell-fo - Faroese hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-fo - Faroese hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439155 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439155] Review Request: hunspell-fo - Faroese hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-fo - Faroese hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439155 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:29 EST --- oops, indeed, that the output rpm. SPRM URL: http://people.redhat.com/caolanm/hunspell/hunspell-fo-0.2.32-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439157] Review Request: perl-Catalyst-View-JSON - JSON view for your Catalyst data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-View-JSON - JSON view for your Catalyst data https://bugzilla.redhat.com/show_bug.cgi?id=439157 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:33 EST --- Review: + package builds in mock. Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=534049 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 65cfb99bc13dd59f4be3aa6ff1cb718b Catalyst-View-JSON-0.24.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=41, 0 wallclock secs ( 0.68 cusr + 0.03 csys = 0.71 CPU) + Package perl-Catalyst-View-JSON-0.24-1.fc9 = Provides: perl(Catalyst::Helper::View::JSON) perl(Catalyst::View::JSON) = 0.24 Requires: perl(Catalyst::Exception) perl(Encode) perl(NEXT) perl(base) perl(strict) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438024] Review Request: freeimage - Multi-format image decoder library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freeimage - Multi-format image decoder library https://bugzilla.redhat.com/show_bug.cgi?id=438024 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:39 EST --- Imported and build, closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427706] Review Request: python-urwid - console user interface for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-urwid - console user interface for python https://bugzilla.redhat.com/show_bug.cgi?id=427706 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:48 EST --- 1. it's not noarch: gcc -pthread -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -D_G NU_SOURCE -fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fPIC -I/u sr/include/python2.5 -c source/str_util.c -o build/temp.linux-x86_64-2.5/source/str_util.o 2. ncurses does not seem to be needed at all, the package builds fine locally in mock -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439163] New: Review Request: perl-HTML-Prototype - Generate HTML and Javascript for the Prototype library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439163 Summary: Review Request: perl-HTML-Prototype - Generate HTML and Javascript for the Prototype library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-HTML-Prototype.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-HTML-Prototype-1.48-1.fc9.src.rpm Description: The module contains some code generators for Prototype, the famous JavaScript OO library and the script.aculous extensions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438452] Review Request: java-gnome: Java GNOME bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: java-gnome: Java GNOME bindings https://bugzilla.redhat.com/show_bug.cgi?id=438452 [EMAIL PROTECTED] changed: What|Removed |Added Summary|java-gnome: Java GNOME |Review Request: java-gnome: |bindings|Java GNOME bindings -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433778] Review Request: fsvs - full system versioning using subversion repositories
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fsvs - full system versioning using subversion repositories https://bugzilla.redhat.com/show_bug.cgi?id=433778 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 08:55 EST --- Fair enough, I'll sponsor you. Please apply for cvsextras group membership as described under http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b and let me know your FAS username. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 241487] Review Request: cduce - An XML-oriented functional language (ocaml)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cduce - An XML-oriented functional language (ocaml) https://bugzilla.redhat.com/show_bug.cgi?id=241487 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 09:26 EST --- test pass. This package is ** Approved **. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225622] Merge Review: boost
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: boost https://bugzilla.redhat.com/show_bug.cgi?id=225622 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 09:29 EST --- While fixing #437032, I addressed following concerns: * in the %doc of the main package there should certainly be LICENSE_1_0.txt README, and many html files from the source directory, for example the faq, but also many others. [We currently distribute lib, doc and more directories.] From Patrice's patch: * BuildRequires/Requires/Provides cleanups * %prep and %check cleanups * rename to boost-static, which requires that boost-static obsoletes and provides old boost-devel-static in addition to mere rename. Moreover, I revamped %install section so that it doesn't launch one install per file, but chains installs together via xargs where possible. This simple change actually improves overall build time considerably. Some of these changes are in not-yet-built -14 release of the package, some of them are already in -13 which was built yesterday. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439155] Review Request: hunspell-fo - Faroese hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-fo - Faroese hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439155 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 10:20 EST --- koji build =http://koji.fedoraproject.org/koji/taskinfo?taskID=534070 rpmlint is silent verified upstream source url 94a9dc4d62337b12ba41960301f69cfa myspell-fo-0.2.32.tar.gz followed packaging guidelines. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433778] Review Request: fsvs - full system versioning using subversion repositories
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fsvs - full system versioning using subversion repositories https://bugzilla.redhat.com/show_bug.cgi?id=433778 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 10:20 EST --- (In reply to comment #24) Fair enough, I'll sponsor you. Please apply for cvsextras group membership as described under http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b and let me know your FAS username. Thanks! Done - my FAS username is davidf -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226414] Merge Review: sg3_utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: sg3_utils https://bugzilla.redhat.com/show_bug.cgi?id=226414 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||g) --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 10:30 EST --- Ok, did some final cleanups to the specfile and removed the static libraries. The remaining rpmlint warnings are either not fixable or plainly wrong for this package (libs package doesn't contain any documentation and sg3_utils-devel only needs the sg3_utils-libs package to work properly). Building sg3_utils-1.25-3 in rawhide as i write this, so should land in the next couple of days in the tree. Let me know if there is anything else you see that should be changed. Thanks, Read ya, Phil -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439155] Review Request: hunspell-fo - Faroese hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-fo - Faroese hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439155 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 10:37 EST --- New Package CVS Request === Package Name: hunspell-fo Short Description: Faroese hunspell dictionary Owners: caolanm Branches: InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439195] New: Review Request: perl-Task-Weaken - Ensure that a platform has weaken support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439195 Summary: Review Request: perl-Task-Weaken - Ensure that a platform has weaken support Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-Task-Weaken.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-Task-Weaken-1.02-1.fc9.src.rpm Description: One recurring problem in modules that use Scalar::Util's weaken function is that it is not present in the pure-perl variant. This restores the functionality testing to a dependency you do once in your Makefile.PL, rather than something you have to write extra tests for each time you write a module. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438293] Review Request: monosim- Manage your SIM Card contacts with pcsc readers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: monosim- Manage your SIM Card contacts with pcsc readers https://bugzilla.redhat.com/show_bug.cgi?id=438293 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 10:54 EST --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439155] Review Request: hunspell-fo - Faroese hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-fo - Faroese hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439155 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 10:58 EST --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439147] Review Request: hunspell-gd - Scots Gaelic hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-gd - Scots Gaelic hunspell dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=439147 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 10:57 EST --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226216] Merge Review: openoffice.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: openoffice.org https://bugzilla.redhat.com/show_bug.cgi?id=226216 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 11:03 EST --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 436704] Review Request: mapnik - a Free toolkit for developing mapping applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mapnik - a Free toolkit for developing mapping
applications
https://bugzilla.redhat.com/show_bug.cgi?id=436704
--- Additional Comments From [EMAIL PROTECTED] 2008-03-27 12:23 EST ---
For 0.5.0-0.2
* License
- The license of mapnik is LGPLv2+.
* Release number
- If this tarball is created from svn repo, IMO it is better
to include not date but svn revision number for Release tag.
* Explicit library dependency
---
Requires: boost
Requires: zlib
Requires: freetype
Requires: proj
Requires: gdal
Requires: cairo
Requires: cairomm
---
- These library related requires should be catched by
find_require.sh and these type of explicit Requries must be
removed (except for some cases such as mono/java related
packages)
---
Requires: python
---
- This requires is not needed and must be removed.
* Requires for subpackages
- Requires for -devel subpackage are not added automatically
and you have to find out and add proper Requires.
* Example:
%_includedir/%name/jpeg_io.hpp contains
---
25 extern C
26 {
27 #include jpeglib.h
28 }
---
This means that mapnik-devel should have
Requires: libjpeg-devel.
The following command is useful for detecting such dependency.
---
$ rpm -ql mapnik-devel | grep /usr/include | xargs grep -h 'include ' | sort |
uniq
---
- Similarly, please check the dependency for -python subpackage
by
---
$ rpm -ql mapnik-python | grep python | xargs grep -h 'import ' | sort | uniq
---
* Fedora specific compilation flags
- This is not yet correctly honored.
* Use of system wide libraries
- build.log shows
---
76 g++ -o agg/src/agg_vcgen_dash.o -c -O3 -fPIC -DNDEBUG -Iagg/include
agg/src/agg_vcgen_dash.cpp
101 ar rc agg/libagg.a agg/src/agg_line_profile_aa.o ..
190 g++ -o src/libmapnik.so -L/usr/local/lib -lagg -lfreetype
---
Here libmapnik.so uses internal libagg.a, not libagg.so provided
by agg-devel.
Please apply patches so that libmapnik.so uses system-wide
libagg.so
- Also
166 g++ -o tinyxml/tinystr.os tinyxml/tinystr.cpp
190 g++ -o src/libmapnik.so tinyxml/tinystr.os ...
Here libmapnik.so uses internal tinyxml, however Fedora has
tinyxml-devel so please use system-wide tinyxml.
- By the way Fedora's optimation level is -O2 and -O3 is not
allowed.
* Macros
- Please use macros. For example, /usr must be %{_prefix}.
* Fonts
- Patch1 shows
-
19 datasource_cache::instance()-register_datasources(mapnik_dir +
/lib/mapnik/input/);
20 -freetype_engine::register_font(mapnik_dir +
/lib/mapnik/fonts/DejaVuSans.ttf);
21 +freetype_engine::register_font(mapnik_dir +
/usr/share/fonts/dejavu/DejaVuSans.ttf);
-
However /usr/share/fonts/dejavu/DejaVuSans.ttf does not exist on
my system.
* By the way is 'mapnik_dir + /usr/' correct?
- Also if you want to use dejavu fonts, it must be added to
Requires (I am not talking about BuildRequires here).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 409361] Review Request: dkim-milter - DomainKeys Identified Mail sender authentication sendmail milter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dkim-milter - DomainKeys Identified Mail sender authentication sendmail milter https://bugzilla.redhat.com/show_bug.cgi?id=409361 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 13:14 EST --- For 2.5.1-1: * SourceURL - For Sourceforge source, please refer to http://fedoraproject.org/wiki/Packaging/SourceURL * Scriptlets to add groups/users - has changed. Please refer to http://fedoraproject.org/wiki/Packaging/UsersAndGroups * Compilation flags - Fedora specific compilation flags are not correctly honored. When gcc/g++ and so on are used, %optflags must be used as compilation flags (you can check what %optflags actually is by $ rpm --eval %optflags : check the section Compiler flags of http://fedoraproject.org/wiki/Packaging/Guidelines ) * Timestamps - When using cp or install commands, add -p option to keep timestamps on installed files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430377] Review Request: atop - An advanced interactive monitor to view the load on system and process level
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: atop - An advanced interactive monitor to view the load on system and process level https://bugzilla.redhat.com/show_bug.cgi?id=430377 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 13:25 EST --- - Update to 1.23 - bug on atop.init corrected http://kairo.freeshell.org/devel/fedora/atop/atop.spec http://kairo.freeshell.org/devel/fedora/atop/atop-1.23-1.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439240] New: Review Request: perl-Cache-FastMmap - Uses an mmap'ed file to act as a shared memory interprocess cache
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439240 Summary: Review Request: perl-Cache-FastMmap - Uses an mmap'ed file to act as a shared memory interprocess cache Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-Cache-FastMmap.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-Cache-FastMmap-1.25-1.fc9.src.rpm Description: In multi-process environments (eg mod_perl, forking daemons, etc), it's common to want to cache information, but have that cache shared between processes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430070] Review Request: evolution-rss - Evolution RSS Reader Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-rss - Evolution RSS Reader Plugin https://bugzilla.redhat.com/show_bug.cgi?id=430070 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 14:01 EST --- Package Change Request == Package Name: evolution-rss New Branches: F-9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433199] Review Request: anjuta - A GNOME development IDE for C/C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: anjuta - A GNOME development IDE for C/C++ https://bugzilla.redhat.com/show_bug.cgi?id=433199 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433199] Review Request: anjuta - A GNOME development IDE for C/C++
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: anjuta - A GNOME development IDE for C/C++
https://bugzilla.redhat.com/show_bug.cgi?id=433199
--- Additional Comments From [EMAIL PROTECTED] 2008-03-27 14:10 EST ---
For 2.2.4-5:
* License
---
-License: GPLv2+
+Release: 5%{?dist}
+# The Scintilla editor plugin is under MIT.
+License: GPLv2+ and MIT
---
- Well, libanjuta-scintilla.la is only used by
libanjuta-editor.so, which is polluted by GPLv2+ from
libanjuta.so so the license tag should still be
GPLv2+ only (there is no libanjuta-scintilla.so in rpm).
* PKGCONFIG
---
+export PKG_CONFIG_PATH=./PKGCONFIG
%configure --disable-static --enable-gtk-doc --enable-devhelp \
--enable-plugin-glade --enable-graphviz --enable-plugin-sourceview \
--disable-plugin-valgrind --enable-plugin-subversion \
- --with-svn-lib=%{_libdir}
+ --with-svn-lib=%{_libdir} PKG_CONFIG_PATH=./PKGCONFIG
- Perhaps the last PKG_CONFIG_PATH=./PKGCONFIG (as configure
option) is not needed.
(In reply to comment #24)
* rpath issue
You seem to have left out /lib. I added it but that leads to the following
rpmlint error:
anjuta.src:103: E: hardcoded-library-path in /lib
Can't we use /%{lib} or %{_libdir} instead of hardcoding the paths?
- This is very intentional and here we must ignore this rpmlint
error.
Other things are okay.
---
This package (anjuta) is APPROVED by me (again)
---
ref:
I once reviewed anjuta however at that time I didn't care about
rpath issue or license issue or so :)
https://bugzilla.redhat.com/show_bug.cgi?id=210464
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254060] Review Request: e16-epplets - Epplets for Enlightenment, DR16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16-epplets - Epplets for Enlightenment, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254060 Bug 254060 depends on bug 254056, which changed state. Bug 254056 Summary: Review Request: e16 - The Enlightenment window manager, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254056 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254058] Review Request: e16-themes - Themes for Enlightenment, DR16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16-themes - Themes for Enlightenment, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254058 Bug 254058 depends on bug 254056, which changed state. Bug 254056 Summary: Review Request: e16 - The Enlightenment window manager, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254056 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254057] Review Request: e16-docs - Dcumentation for Enlightenment, DR16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16-docs - Dcumentation for Enlightenment, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254057 Bug 254057 depends on bug 254056, which changed state. Bug 254056 Summary: Review Request: e16 - The Enlightenment window manager, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254056 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254056] Review Request: e16 - The Enlightenment window manager, DR16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16 - The Enlightenment window manager, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254056 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 14:38 EST --- (In reply to comment #18) Weird. Might just be a bug in the build/configure output... might mention that upstream as well? dbus is experimental (info from upstream), cvs done. Thanks. Now imported. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439015] Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libzend-framework-php - A simple, straightforward,
open-source software framework for PHP 5
https://bugzilla.redhat.com/show_bug.cgi?id=439015
--- Additional Comments From [EMAIL PROTECTED] 2008-03-27 14:44 EST ---
(In reply to comment #2)
oh and should it really just be dropping the files in /usr/share?
Yes. These are just PHP files. The user should add the frame dir to his
include_path and he can start working with it.
I must confess, I wasn't sure whether it should install onto /usr/share or
/usr/lib. Perl and Python modules usually go to /usr/lib and that always seemed
like good practice to me, do you think it's better to place the
libzend-framework-php there instead?
Replaced %{buildroot} with $RPM_BUILD_ROOT.
Dropped the #%setup comment, it got in there by mistake in the first place.
Spaced the sections.
The updated version can be downloaded from the same URL.
Thank you for reviewing.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254057] Review Request: e16-docs - Dcumentation for Enlightenment, DR16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16-docs - Dcumentation for Enlightenment, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254057 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 15:02 EST --- #254056 is now resolved and we can continue, updated package (see #254056 for license): spec: http://terjeros.fedorapeople.org/e16/e16-docs.spec srpm: http://terjeros.fedorapeople.org/e16/e16-docs-0.16.8.0.1-1.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439263] New: Review Request: javahelp2 - needed for NetBeans Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439263 Summary: Review Request: javahelp2 - needed for NetBeans Platform Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.xelfi.cz/download/dev/SRPMS/javahelp2.spec SRPM URL: http://www.xelfi.cz/download/dev/SRPMS/javahelp2-2.0.05-2.rpm Description: JavaHelp software is a full-featured, platform-independent, extensible help system that enables developers and authors to incorporate online help in applets, components, applications, operating systems, and devices. Authors can also use the JavaHelp software to deliver online documentation for the Web and corporate Intranet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439262] New: Review Request: swing-layour - needed for NetBeans Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439262 Summary: Review Request: swing-layour - needed for NetBeans Platform Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout.spec SRPM URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout-1.0.3-0.src.rpm Description: Swing Layout Extensions goal is to make it easy to create professional cross platform layouts with Swing. This project will consist of extensions to Swing and possibly a new LayoutManager. The long term goal is to roll these changes back into Swing proper. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0 https://bugzilla.redhat.com/show_bug.cgi?id=439265 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||439262, 439263 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439262] Review Request: swing-layour - needed for NetBeans Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: swing-layour - needed for NetBeans Platform https://bugzilla.redhat.com/show_bug.cgi?id=439262 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||439265 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439263] Review Request: javahelp2 - needed for NetBeans Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: javahelp2 - needed for NetBeans Platform https://bugzilla.redhat.com/show_bug.cgi?id=439263 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||439265 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439265] New: Review Request: libnb-platform7 - NetBeans Platform 6.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439265 Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://www.xelfi.cz/download/dev/SRPMS/netbeans-platform.spec SRPM URL: http://www.xelfi.cz/download/dev/SRPMS/libnb-platform7-6.0.1-2.src.rpm Description: NetBeans Platform is a framework for development of rich client Swing applications. It contains powerful module system and a set of modules providing various functionalities needed for simplification of development of modular desktop applications. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254058] Review Request: e16-themes - Themes for Enlightenment, DR16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16-themes - Themes for Enlightenment, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254058 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 15:06 EST --- #254056 fixed, we want more (see #254056 for license): spec: http://terjeros.fedorapeople.org/e16/e16-themes.spec srpm: http://terjeros.fedorapeople.org/e16/e16-themes-0.16.8.0.2-1.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439262] Review Request: swing-layout - needed for NetBeans Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: swing-layout - needed for NetBeans Platform https://bugzilla.redhat.com/show_bug.cgi?id=439262 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: swing-layour|Review Request: swing-layout |- needed for NetBeans |- needed for NetBeans |Platform|Platform -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430377] Review Request: atop - An advanced interactive monitor to view the load on system and process level
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: atop - An advanced interactive monitor to view the load on system and process level https://bugzilla.redhat.com/show_bug.cgi?id=430377 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 15:23 EST --- There are a couple of small errors which need fixing a) in atop.spec: please do not start atop in %post. Fedora policy mandates to leave services stopped. It's up to the user to decide if the service should be started b) cron.daily should exit after checking if atop is started and finding out that it is not. Your script checks if atop is running, takes a last sample if it is and procedes with starting atop even if it is was not running I suggest: PID=`cat $PIDFILE` if [ -e $PIDFILE ] ps -p $PID | grep 'atop$' /dev/null then kill -USR1 $PID # take final sample sleep 3 kill -TERM $PID rm $PIDFILE sleep 1 else exit 1 fi A nice touch would be to use /etc/sysconfig/atop for storing all variables which now are defined at the start of atop.init and atop.crondaily (CURDAY, INTERVAL, PATHes etc) and source /etc/sysconfig/atop where ever it is needed. b) in atop.init: - you cannot use daemon to start a cron script, it's purpose is to daemonize a program - there is a typo error, CURDAY lacks the C -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 409361] Review Request: dkim-milter - DomainKeys Identified Mail sender authentication sendmail milter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dkim-milter - DomainKeys Identified Mail sender authentication sendmail milter https://bugzilla.redhat.com/show_bug.cgi?id=409361 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 15:19 EST --- Thanks for the review. I made the changes that you suggested plus I moved the key directory from /var/db/dkim-milter to /etc/mail/dkim-milter/keys (since it's never written to by the program). Spec URL: http://blackbean.org/review/dkim-milter-2.5.1-2.spec SRPM URL: http://blackbean.org/review/dkim-milter-2.5.1-2.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0
https://bugzilla.redhat.com/show_bug.cgi?id=439265
--- Additional Comments From [EMAIL PROTECTED] 2008-03-27 15:27 EST ---
On an overall level, does Fedora really have all the current Netbeans
dependencies? The Build-Depends is pretty short. Does Netbeans ship a copy of
any libraries in source form even, not necessarily jar?
%setup -q -c
find . -type d | xargs -t chmod 755
find . -type f -exec chmod 644 {} ;
find . -type f \( -iname *.jar -o -iname *.zip \) | xargs -t %{__rm} -f
Longer term, I'd try to have netbeans generate a clean source tarball/zip rather
than relying on this.
LNS=%{__ln_s}
MKDIRP=%{__mkdir_p}
JAVADIR=%{_javadir}
JAVADOCDIR=$RPM_BUILD_ROOT/%{_javadocdir}/netbeans-platform7
RMF=%{__rm} -rf
INS=%{__cp} -r
NBDIR=$RPM_BUILD_ROOT/%{clusterdir}
JHJAR=javahelp2.jar
export LNS MKDIRP JAVADIR JAVADOCDIR RMF INS NBDIR JHJAR
A lot of this stuff seems like it could be put into the upstream build system.
%files
%defattr(644,root,root,755)
%dir %{clusterdir}/platform7/
%{clusterdir}/platform7/*
That's it? There's no /usr/bin/netbeans? You need to have a .desktop file at
least too.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0 https://bugzilla.redhat.com/show_bug.cgi?id=439265 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 15:35 EST --- Oh, I missed that this is just the -plaftorm. Ignore the last comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254060] Review Request: e16-epplets - Epplets for Enlightenment, DR16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16-epplets - Epplets for Enlightenment, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254060 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 15:53 EST --- #254056 resolved, updated package: spec: http://terjeros.fedorapeople.org/e16/e16-epplets.spec srpm: http://terjeros.fedorapeople.org/e16/e16-epplets-0.10-2.fc8.src.rpm koji scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=534782 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0 https://bugzilla.redhat.com/show_bug.cgi?id=439265 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 15:58 EST --- The dependencies for the platform are java 1.6.0, javahelp2 and swing-layout A lot of this stuff seems like... - is it a blocker? If it builds, then it builds, and that is the most important goal, imho. Btw. The reason you see these tricks with environment variables is that we want to share as much as possible with the debian packages and these variables represent differences between the scripts for RPM based distros and debian. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0 https://bugzilla.redhat.com/show_bug.cgi?id=439265 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 16:08 EST --- A lot of this stuff seems like... - is it a blocker? Nope, not a blocker; we have plenty of spec files with much hairier rules. Just a suggestion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 254059] Review Request: e16-keyedit - GUI for editing keybindings for Enlightenment, DR16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e16-keyedit - GUI for editing keybindings for Enlightenment, DR16 https://bugzilla.redhat.com/show_bug.cgi?id=254059 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 16:08 EST --- e16 is in fedora now and license of e16 stuff is ok, see #254056. Updates package: spec: http://terjeros.fedorapeople.org/e16/e16-keyedit.spec srpm: http://terjeros.fedorapeople.org/e16/e16-keyedit-0.5-2.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438138] Review Request: tzdata-java - Time zone data for Java language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tzdata-java - Time zone data for Java language Alias: tzdata-java-epel https://bugzilla.redhat.com/show_bug.cgi?id=438138 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 16:30 EST --- New Package CVS Request === Package Name: tzdata-java Short Description: Time zone data for Java language Owners: lkundrak Branches: EL-4 EL-5 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0 https://bugzilla.redhat.com/show_bug.cgi?id=439265 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 16:26 EST --- Looking at the upstream source, I see a lot of empty directories with names of other projects: drwxr-xr-x mslama/mslama 0 2008-01-29 11:46 netbeans-platform-6.0.1/libs/jsr223/ -rw-r--r-- mslama/mslama2169 2007-09-26 16:48 netbeans-platform-6.0.1/libs/lucene/ etc. Do any these get downloaded and built during 'make build'? Be aware that the Fedora build system (koji) has no Internet access. The right thing to do is get everything packaged as separate RPM components - this ensures that we only need to ship one new package when there is a security or reliability issue, as well as helping reduce duplication of code upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438293] Review Request: monosim- Manage your SIM Card contacts with pcsc readers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: monosim- Manage your SIM Card contacts with pcsc readers https://bugzilla.redhat.com/show_bug.cgi?id=438293 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225243] Merge Review: amanda
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: amanda https://bugzilla.redhat.com/show_bug.cgi?id=225243 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 17:00 EST --- (In reply to comment #5) (In reply to comment #4) But isn't your new -pie patch missing some configure.in stuff? I'd rather let it there... The old pie patch had some stuff for configure.in, but it didn't do anything. It checked whether the compiler had pie support and set PIE_LDFLAGS (and some others) if so, but none of those variables were used anywhere. Now if upstream were to ever support this, they would require a working check in configure.in and proper modifying of the Makefile.am files. I have also noticed these things: * The -lib patch, is it really needed? The package compiles just fine without it. And after patching configure.in with -pie (see above), this gets overriden by autogen. It fixes a problem that occurs when you try to build the amanda package on a machine with an older amanda-devel installed (because it ended up putting -L/usr/lib before the locally built lib path). Not going to happen in the fedora build system, but nice to not have others trip up on it. I've updated it to patch the sources. * Why did the examples disappear from /usr/share/doc? I though it was good place for such thing, people may be looking for it there... Seemed like duplication to have in /etc/amanda/DailySet1 and there, but may make sense to keep. * Thu Mar 27 2008 Orion Poplawski [EMAIL PROTECTED] 2.6.0-0.b3_20080314.1 - Update to 2.6.0b3_20080314 - New -lib patch that patches the autotool source files http://www.cora.nwra.com/~orion/fedora/amanda-2.6.0-0.b3_20080314.1.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438892] Review Request: pyPdf - PDF toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pyPdf - PDF toolkit https://bugzilla.redhat.com/show_bug.cgi?id=438892 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 17:13 EST --- New version: - removed unnecessary python_sitearch macro declaration http://www.felix-schwarz.name/files/misc/2008/pypdf/1.10-3/pyPdf-1.10-3.fc8.src.rpm http://www.felix-schwarz.name/files/misc/2008/pypdf/1.10-3/pyPdf.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439285] New: Review Request: php-openid - The PHP OpenID Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439285 Summary: Review Request: php-openid - The PHP OpenID Library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Request from Infrastructure team. Spec URL: http://ianweller.fedorapeople.org/SRPMS/php-openid/2.0.1-1/php-openid.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/php-openid/2.0.1-1/php-openid-2.0.1-1.fc8.src.rpm Description: The PHP OpenID library lets you enable OpenID authentication on sites built using PHP. It features the OpenID consumer, Store implementations, and an OpenID server. Features of the 2.x.x series include: * Runs on a wide range of PHP versions: from 4.3.0 and up (tested on 5.2.4) * Licensed under the Apache Software License. * Includes extensive documentation, working example code, and a test suite * Attempts to use PHP extensions such as Curl, but does not depend on them * Includes extension modules for Attribute Exchange, Simple Registration, and PAPE * Supports i-names * Tested on Windows and Linux * Versions 2.x.x support both major OpenID protocol versions transparently -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 428368] Review Request: fedora-ds: Meta-package for Fedora Directory Server Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fedora-ds: Meta-package for Fedora Directory Server Suite Alias: fedora-ds https://bugzilla.redhat.com/show_bug.cgi?id=428368 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 19:01 EST --- comment #11) (In reply to comment #10) Well, under the current setup, you would get both, with the x86_64 binaries taking precedence. Looks like current plan is to fix yum so that you would only get the preferred architecture. Ok. I guess at that point I can then make fedora-ds noarch? You could make it noarch now. Why is fedora-ds-base multilib at the moment anyway? Is there any reason why you would want to run the 32-bit version on x86_64? Is it multilib? What makes it multilib? I don't think there is any reason to run the 32-bit version on x86_64. fedora-ds-base is multilib because it has a -devel sub-package. I believe you can black list it by sending a request to [EMAIL PROTECTED](In reply to -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 409361] Review Request: dkim-milter - DomainKeys Identified Mail sender authentication sendmail milter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dkim-milter - DomainKeys Identified Mail sender authentication sendmail milter https://bugzilla.redhat.com/show_bug.cgi?id=409361 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 19:11 EST --- Updated to handle a change in the way the socket is specified. Spec URL: http://blackbean.org/review/dkim-milter-2.5.1-3.spec SRPM URL: http://blackbean.org/review/dkim-milter-2.5.1-3.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439141] Review Request: python-demjson - Python JSON module and lint checker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-demjson - Python JSON module and lint checker https://bugzilla.redhat.com/show_bug.cgi?id=439141 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 19:19 EST --- (In reply to comment #1) Not needed now following as per python packaging guidelines Ok, seems indeed not to be necessary anymore. But add only BuildRequires: python-setuptools-devel Done. also, drop INSTALL.txt from %doc Done. Spec file and srpm updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0 https://bugzilla.redhat.com/show_bug.cgi?id=439265 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 19:43 EST --- Yes, we use separate RPMs for each component (like javahelp2, lucene2 - only for the IDE, atd.). No, we do not need internet connection. This is experimentally verified, these SRPMS were successfully built on Mandriva's cooker and I expect their build system to have similar restrictions. Btw. if we resolve issues with the platform and manage to build it on koji, I'll provide SRPMS for IDE and other libraries. This platform case is here to estimate how much work that will be. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439310] New: Review Request: gnue-common - GNU Enterprise Common Base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439310 Summary: Review Request: gnue-common - GNU Enterprise Common Base Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: https://agave.garden.org/~aaronh/rpm/gnue-common.spec SRPM URL: https://agave.garden.org/~aaronh/rpm/gnue-common-0.6.9-1.src.rpm Description: GNU Enterprise Common Library for use with the GNUe tools GNUe-Common provides a set of images and classes that GNUe-Forms, GNUe-Reports, GNUe-Appserver and GNUe-Designer and others are dependent upon. It implements a database-abstraction layer that provides support for most major databases. A builtin XML-to-Object parser and Object-to-XML marshaller are used by Forms, Reports, and Designer to save and read Forms/Report definitions to and from an XML file. It also defines and implements an RPC abstraction layer that will allow server processes to define their public methods once and have them available to CORBA, XML-RPC, SOAP, and DCOM clients. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433678] Review Request: ricci - cluster and systems management agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ricci - cluster and systems management agent https://bugzilla.redhat.com/show_bug.cgi?id=433678 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|MODIFIED Flag|needinfo?([EMAIL PROTECTED]| |) | --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 21:22 EST --- Thanks. Made those changes and posted an updated src.rpm and spec file. Spec URL: http://people.redhat.com/rmccabe/conga/ricci.spec SRPM URL: http://people.redhat.com/rmccabe/conga/ricci-0.13.0-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197974] Tracking bug for reviews stalled pending the adoption of guidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Tracking bug for reviews stalled pending the adoption of guidelines Alias: F-GUIDELINES https://bugzilla.redhat.com/show_bug.cgi?id=197974 [EMAIL PROTECTED] changed: What|Removed |Added Keywords||Tracking --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 21:45 EST --- Adding Tracking keyword -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439310] Review Request: gnue-common - GNU Enterprise Common Base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnue-common - GNU Enterprise Common Base https://bugzilla.redhat.com/show_bug.cgi?id=439310 --- Additional Comments From [EMAIL PROTECTED] 2008-03-27 22:19 EST --- You may want to fix the cert on your web server... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439338] New: Review Request: mediawiki-StubManager - An extension meant to address 'rare events' handling
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439338 Summary: Review Request: mediawiki-StubManager - An extension meant to address 'rare events' handling Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://ianweller.fedorapeople.org/SRPMS/mediawiki-StubManager/1.2.0-1/mediawiki-StubManager.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/mediawiki-StubManager/1.2.0-1/mediawiki-StubManager-1.2.0-1.fc8.src.rpm Description: mediawiki-StubManager is an extension for the mediawiki package. It is required by mediawiki-HNP, which I plan to build soon. mediawiki-HNP is requested by Fedora Infrastructure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439195] Review Request: perl-Task-Weaken - Ensure that a platform has weaken support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Task-Weaken - Ensure that a platform has weaken support https://bugzilla.redhat.com/show_bug.cgi?id=439195 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-28 00:08 EST --- Review: + package builds in mock. Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=535496 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 684c2bd2a76f320679fd2df938467e01 Task-Weaken-1.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave t/01_compileok t/02_weaken.ok t/98_podskipped all skipped: Author tests not required for installation t/99_pmvskipped all skipped: Author tests not required for installation All tests successful, 2 tests skipped. Files=4, Tests=21, 1 wallclock secs ( 0.10 cusr + 0.02 csys = 0.12 CPU) + Package perl-Task-Weaken-1.02-1.fc9= Provides: perl(Task::Weaken) = 1.02 Requires: perl = 0:5.005 perl(strict) perl(vars) SHOULD: License tag MUST be GPL+ or Artistic update new SRPM and will APPROVE this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438110] Review Request: xmountains - A fractal terrain generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xmountains - A fractal terrain generator https://bugzilla.redhat.com/show_bug.cgi?id=438110 [EMAIL PROTECTED] changed: What|Removed |Added Fixed In Version||2.7-3 Resolution|NEXTRELEASE |CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439163] Review Request: perl-HTML-Prototype - Generate HTML and Javascript for the Prototype library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTML-Prototype - Generate HTML and Javascript for the Prototype library https://bugzilla.redhat.com/show_bug.cgi?id=439163 --- Additional Comments From [EMAIL PROTECTED] 2008-03-28 00:32 EST --- (In reply to comment #1) rpmlint is silent oops I mean to say rpmlint output is NOT silent :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439240] Review Request: perl-Cache-FastMmap - Uses an mmap'ed file to act as a shared memory interprocess cache
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Cache-FastMmap - Uses an mmap'ed file to act as a shared memory interprocess cache https://bugzilla.redhat.com/show_bug.cgi?id=439240 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-03-28 00:34 EST --- Failed to build for x86_64 on koji see http://koji.fedoraproject.org/koji/taskinfo?taskID=535494 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439163] Review Request: perl-HTML-Prototype - Generate HTML and Javascript for the Prototype library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTML-Prototype - Generate HTML and Javascript for the Prototype library https://bugzilla.redhat.com/show_bug.cgi?id=439163 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-03-28 00:31 EST --- rpmlint is silent perl-HTML-Prototype.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-HTML-Prototype-1.48/README This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. perl-HTML-Prototype.noarch: W: file-not-utf8 /usr/share/doc/perl-HTML-Prototype-1.48/README The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). 2) License tag MUST be GPL+ or Artistic -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439340] New: Review Request: mediawiki-OpenID - An extension for OpenID integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439340 Summary: Review Request: mediawiki-OpenID - An extension for OpenID integration Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://ianweller.fedorapeople.org/SRPMS/mediawiki-OpenID/0.8.2-1/mediawiki-OpenID.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/mediawiki-OpenID/0.8.2-1/mediawiki-OpenID-0.8.2-1.fc8.src.rpm Description: The OpenID extension for mediawiki. Depends on php-openid which is still in review, bug 439285. Requested by Infrastructure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439285] Review Request: php-openid - The PHP OpenID Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-openid - The PHP OpenID Library https://bugzilla.redhat.com/show_bug.cgi?id=439285 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||439340 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439340] Review Request: mediawiki-OpenID - An extension for OpenID integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mediawiki-OpenID - An extension for OpenID integration https://bugzilla.redhat.com/show_bug.cgi?id=439340 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||439285 --- Additional Comments From [EMAIL PROTECTED] 2008-03-28 00:59 EST --- added dependency on bug 439285. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439345] New: Review Request: mediawiki-HNP - An extension to provide a hierarchical namespace permissions system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=439345 Summary: Review Request: mediawiki-HNP - An extension to provide a hierarchical namespace permissions system Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://ianweller.fedorapeople.org/SRPMS/mediawiki-HNP/1.1.2-1/mediawiki-HNP.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/mediawiki-HNP/1.1.2-1/mediawiki-HNP-1.1.2-1.fc8.src.rpm Description: An extension to provide a hierarchical namespace permissions system. Requested by Infrastructure. Depends on bug 439338. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439338] Review Request: mediawiki-StubManager - An extension meant to address 'rare events' handling
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mediawiki-StubManager - An extension meant to address 'rare events' handling https://bugzilla.redhat.com/show_bug.cgi?id=439338 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||439345 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439345] Review Request: mediawiki-HNP - An extension to provide a hierarchical namespace permissions system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mediawiki-HNP - An extension to provide a hierarchical namespace permissions system https://bugzilla.redhat.com/show_bug.cgi?id=439345 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||439338 --- Additional Comments From [EMAIL PROTECTED] 2008-03-28 01:27 EST --- added depends on bug 439338 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
