[Bug 433219] Review Request: ganyremote - GTK frontend for anyremote

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ganyremote - GTK frontend for anyremote


https://bugzilla.redhat.com/show_bug.cgi?id=433219





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 02:08 EST ---
If you want to re-tag, just bump release number.
If build is okay,
- For F-8 visit https://admin.fedoraproject.org/updates/
  and request to push your package to repository
- For F-9 visit https://admin.fedoraproject.org/updates/
  _later_. We cannot request to push  packages for now.

and close this bug as NEXTRELEASE.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441072] Review Request: cwiid - Library and tools for comunicating with a wiimote

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwiid - Library and tools for comunicating with a 
wiimote


https://bugzilla.redhat.com/show_bug.cgi?id=441072


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 02:02 EST ---
Okay.
- This package is now clean
- Your another review request seems good to some extent (some
  fix seems needed although)

-
 This package (cwiid) is APPROVED by me
-

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account".
At a point a mail should be sent to sponsor members which notifies
that you need a sponsor. At the stage, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 7/8, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438543] Review Request: Synopsis - Source-code introspection tool.

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Synopsis - Source-code introspection tool.


https://bugzilla.redhat.com/show_bug.cgi?id=438543





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 01:55 EST ---
Does not build even on i386
- At least "flex byacc" are missing from BuildRequires
- Even if "flex byacc" are added to BuildRequires, build
  still fails
  http://koji.fedoraproject.org/koji/taskinfo?taskID=584014

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444257] New: Review Request: nted - Musical score editor

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444257

   Summary: Review Request: nted - Musical score editor
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://salimma.fedorapeople.org/for_review/music/nted.spec
SRPM URL: 
http://salimma.fedorapeople.org/for_review/music/nted-0.22.3-1.fc9.src.rpm
Description:
NtEd is a GTK score editor. It intends to be really WYSIWYG: what you
see on the screen is exactly what you get on printer output. It
supports up to 4 voices per staff, drum notes, 5 lyrics lines,
N-Tuplets, context changes, repeats with alternatives, configurable
music instruments per staff, MIDI and Postscript export, MusicXML
import. Scores can be played through the ALSA sequencer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430307] Review Request: Falcon - The Falcon Programming Language

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Falcon - The Falcon Programming Language


https://bugzilla.redhat.com/show_bug.cgi?id=430307





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 22:39 EST ---
Perhaps you also want to request F-9 branch?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430307] Review Request: Falcon - The Falcon Programming Language

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Falcon - The Falcon Programming Language


https://bugzilla.redhat.com/show_bug.cgi?id=430307


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 22:33 EST ---
Thanks everyone!

New Package CVS Request
===
Package Name: Falcon
Short Description: The Falcon Programming Language
Owners: salimma
Branches: F-7 F-8 EL-5
InitialCC: 
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 439265] Review Request: libnb-platform7 - NetBeans Platform 6.0

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnb-platform7 - NetBeans Platform 6.0


https://bugzilla.redhat.com/show_bug.cgi?id=439265


Bug 439265 depends on bug 439262, which changed state.

Bug 439262 Summary: Review Request: swing-layout - needed for NetBeans Platform
https://bugzilla.redhat.com/show_bug.cgi?id=439262

   What|Old Value   |New Value

 Status|NEW |CLOSED
 Resolution||DUPLICATE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 433497] Review Request: swing-layout - Natural layout for Swing panels

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swing-layout - Natural layout for Swing panels
Alias: swing-layout-review

https://bugzilla.redhat.com/show_bug.cgi?id=433497


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 21:35 EST ---
*** Bug 439262 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 439262] Review Request: swing-layout - needed for NetBeans Platform

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swing-layout - needed for NetBeans Platform


https://bugzilla.redhat.com/show_bug.cgi?id=439262


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 21:35 EST ---


*** This bug has been marked as a duplicate of 433497 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444245] New: Review Request: whatsup - Node up/down detection utility

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444245

   Summary: Review Request: whatsup - Node up/down detection utility
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://ruben.fedorapeople.org/whatsup.spec
SRPM URL: http://ruben.fedorapeople.org/whatsup-1.7-1.fc9.src.rpm
Description:
Whatsup is a cluster node up/down detection utility.

Whatsup can quickly calculate and output the up and down nodes of a cluster.
Whatsup allows some tools, such as Pdsh, to operate more quickly by
not operating on down nodes. Whatsup calculates the up and down nodes of a
cluster through one of several possible backend tools
and several optional cluster node databases.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 20:34 EST ---
Yeah, looks fine now, basically. For rpm groups, I would just pick something 
like
Development/Libraries, since the demo is about showing how to use the geoclue
libraries.

I'll do a formal review sometime this weekend.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442867] Review Request: ocaml-gettext - OCaml library for i18n

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gettext - OCaml library for i18n


https://bugzilla.redhat.com/show_bug.cgi?id=442867





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 19:53 EST ---
See below - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (LGPLv2+ with exceptions)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
4e95d69e6910c4c0dcafb7e2f8dc5491  ocaml-gettext-0.2.0.tar.gz
4e95d69e6910c4c0dcafb7e2f8dc5491  ocaml-gettext-0.2.0.tar.gz.orig
OK - Package needs ExcludeArch
See below - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Headers/static libs in -devel subpackage.
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}

OK - Package compiles and builds on at least one arch.
See below - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Whats with the odd release naming?
If you need a snapshot release, see:

http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-cfd71146dbb6f00cec9fe3623ea619f843394837

and

http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49

2. I see in the build output:
checking for fop... no
configure: WARNING: Cannot find fop."
Missing buildrequires?

3. Looks like the camomile-devel and devel subpackages duplicate all the docs...
That doesn't seem very ideal.
%doc README CHANGELOG TODO build/share/doc/html/*
on both of them.

4. rpmlint says:
ocaml-gettext-camomile.x86_64: E: only-non-binary-in-usr-lib

This can be ignored as you can't make just a subpackage noarch.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442867] Review Request: ocaml-gettext - OCaml library for i18n

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gettext - OCaml library for i18n


https://bugzilla.redhat.com/show_bug.cgi?id=442867


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 19:45 EST ---
I'd be happy to review this... look for a full review in a bit. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 19:40 EST ---
OK, I think I've fixed all of those errors. I've put the main library rpm in the
"System Environment/Libraries" but not sure what group the test gui should go
in. Maybe its just late but I can't see anything in the packaging guidelines
about groups.

SPEC: http://fedora.roving-it.com/rawhide/geoclue.spec
SRPM: http://fedora.roving-it.com/rawhide/geoclue-0.11.1-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 19:00 EST ---
After adding 

BuildRequires: gtk2-devel 
BuildRequires: NetworkManager-devel

I was able to build this in mock, so we are getting somewhere. rpmlint has some
complaints: 

geoclue.i386: E: zero-length /usr/share/doc/geoclue-0.11.1/ChangeLog
geoclue.i386: E: library-without-ldconfig-postin /usr/lib/libgeoclue.so.0.0.0
geoclue.i386: E: library-without-ldconfig-postun /usr/lib/libgeoclue.so.0.0.0
geoclue.i386: E: zero-length /usr/share/doc/geoclue-0.11.1/NEWS
geoclue.i386: E: description-line-too-long Geoclue is a modular geoinformation
service built on top of the D-Bus messaging system. The goal of the Geoclue
project is to make creating location-aware applications as simple as possible.
geoclue.i386: W: non-standard-group System
geoclue.i386: W: invalid-license LGPL

all of these are easy fixes, thankfully. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426883] Review Request: brazil - Extremely small footprint Java HTTP stack

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: brazil - Extremely small footprint Java HTTP stack


https://bugzilla.redhat.com/show_bug.cgi?id=426883


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 18:52 EST ---
New Package CVS Request
===
Package Name: brazil
Short Description: Extremely small footprint Java HTTP stack
Owners: mbooth
Branches: F-9
InitialCC: 
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426883] Review Request: brazil - Extremely small footprint Java HTTP stack

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: brazil - Extremely small footprint Java HTTP stack


https://bugzilla.redhat.com/show_bug.cgi?id=426883





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 18:50 EST ---
Thanks Tom and Andrew for all your help.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438039] Review Request: GMT-coastlines - Coastline data for GMT

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GMT-coastlines - Coastline data for GMT


https://bugzilla.redhat.com/show_bug.cgi?id=438039


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 18:50 EST ---
Spec URL: http://www.cora.nwra.com/~orion/fedora/GMT-coastlines.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/GMT-coastlines-1.9-3.src.rpm

* Fri Apr 25 2008 Orion Poplawski <[EMAIL PROTECTED]> 1.9-3
- Add lowercase provides
- Fix URLs and timestamps
- Add comment about source

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444235] Review Request: djview4 - DjVu viewer

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: djview4 - DjVu viewer


https://bugzilla.redhat.com/show_bug.cgi?id=444235


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: djview4 -   |Review Request: djview4 -
   |DjVu viewer |DjVu viewer




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 18:09 EST ---
Sure, take it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435576] Review Request: ncdu - Ncurses disk usage

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ncdu - Ncurses disk usage


https://bugzilla.redhat.com/show_bug.cgi?id=435576





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 18:03 EST ---
I've made a new package available:

Spec URL: http://richardfearn.co.uk/files/fedora/ncdu-1.3-2/ncdu.spec
SRPM URL: 
http://richardfearn.co.uk/files/fedora/ncdu-1.3-2/ncdu-1.3-2.fc8.src.rpm

This incorporates the suggestions made by Michael in comment 1. It builds
against Fedora 9 using mock. The resulting RPMs are rpmlint clean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444235] New: Review Request: djview4 - DjVu viewer

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444235

   Summary: Review Request: djview4 - DjVu viewer
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://terjeros.fedorapeople.org/djview4/djview4.spec
SRPM URL: http://terjeros.fedorapeople.org/djview4/djview4-4.3-1.fc9.src.rpm
Description:

DjView4 is a DjVu document viewer with the following features:
 o continuous scrolling of pages
 o side-by-side display of pages
 o display thumbnails as a grid
 o display outlines
 o page names supported
 o metadata dialog

It's based on DjVuLibre and Qt4.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 17:37 EST ---
the .la files are removed in the last spec file so I think I've got the
requirements now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 17:27 EST ---
with static libraries, do you mean .la files ? those are actually libtool
archives, and yes, rm is the right treatment for them. Actual static libaries
are .a files, but you are configuring with --disable-static, so those should not
be produced in the first place. I they are, then again rm is the easiest 
solution.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 17:24 EST ---
OK new version

SPEC: http://fedora.roving-it.com/rawhide/geoclue.spec
SRPM: http://fedora.roving-it.com/rawhide/geoclue-0.11.1-1.fc9.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 433219] Review Request: ganyremote - GTK frontend for anyremote

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ganyremote - GTK frontend for anyremote


https://bugzilla.redhat.com/show_bug.cgi?id=433219





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 17:08 EST ---
But anyway "make build" works OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435576] Review Request: ncdu - Ncurses disk usage

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ncdu - Ncurses disk usage


https://bugzilla.redhat.com/show_bug.cgi?id=435576





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 17:00 EST ---
Thanks for your comments on this package, too, Michael - I'll be updating the
package over the weekend.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 436637] Review Request: disktype - Detect the content format of a disk or disk image

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: disktype - Detect the content format of a disk or disk 
image


https://bugzilla.redhat.com/show_bug.cgi?id=436637





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 16:55 EST ---
Thanks again to Michael and Nicolas for your comments. I've addressed the issues
raised by Michael and included EWF support. The new spec file and SRPM can be
found here:

Spec URL: http://richardfearn.co.uk/files/fedora/disktype-9-2/disktype.spec
SRPM URL:
http://richardfearn.co.uk/files/fedora/disktype-9-2/disktype-9-2.fc8.src.rpm

The SRPM builds using mock against Fedora 9. The resulting RPMs are rpmlint 
clean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 16:57 EST ---
No problems. Been looking for some packages to maintain for a while to get
involved :)

geoclue has just done another release so the autogen.sh stuff can disappear, but
there's a missing file from the tar ball as far as I can tell so I'll upload a
new version once I can get it to build.

For the static libraries do I just rm them from the build?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 433219] Review Request: ganyremote - GTK frontend for anyremote

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ganyremote - GTK frontend for anyremote


https://bugzilla.redhat.com/show_bug.cgi?id=433219





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 16:45 EST ---
I tried to run build ...
but something goes wrong (seems i made "make tag" several times)
Now i got:
--
make tag
cvs tag  -c ganyremote-2_8-2_fc10
ERROR: Tag ganyremote-2_8-2_fc10 has been already created.
The following tags have been created so far
ganyremote-2_8-1_fc10:devel:anyremote:1209152554
ganyremote-2_8-1_fc9:F-9:anyremote:1209153297
ganyremote-2_8-2_fc9:F-9:anyremote:1209153884
ganyremote-2_8-2_fc10:devel:anyremote:1209154025
ganyremote-2_8-2_fc10:devel:anyremote:1209155226
cvs tag: Pre-tag check failed
cvs [tag aborted]: correct the above errors first!
make: *** [tag] Error 1
--

How to clean-up all the tags ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426883] Review Request: brazil - Extremely small footprint Java HTTP stack

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: brazil - Extremely small footprint Java HTTP stack


https://bugzilla.redhat.com/show_bug.cgi?id=426883


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]|
   |m)  |




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 16:39 EST ---
Script is fine, sorry it took so long. :) 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444225] New: Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444225

   Summary: Review Request: simcoupe - SAM Coupe emulator (spectrum
compatible)
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://people.atrpms.net/~hdegoede/simcoupe.spec
SRPM URL: http://people.atrpms.net/~hdegoede/simcoupe-1.0-4.fc9.src.rpm
Description:
SimCoupe emulates an 8bit Z80 based home computer, released in 1989 by Miles
Gordon Technology. The SAM Coupe was largely spectrum compatible, with much
improved hardware

Note this package Requires SAASound and samcoupe-rom, both of which are still 
under review, see bug 444223 and bug 444224.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444224] Review Request: samcoupe-rom - SAM Coupé (Spectrum compatible homecomputer ) ROM file

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: samcoupe-rom - SAM Coupé (Spectrum compatible 
homecomputer) ROM file


https://bugzilla.redhat.com/show_bug.cgi?id=444224


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||444225
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444224] New: Review Request: samcoup e-rom - SAM Coupé (Spectrum compatible homec omputer) ROM file

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444224

   Summary: Review Request: samcoupe-rom - SAM Coupé (Spectrum
compatible homecomputer) ROM file
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://people.atrpms.net/~hdegoede/samcoupe-rom.spec
SRPM URL: http://people.atrpms.net/~hdegoede/samcoupe-rom-3.0-1.fc9.src.rpm
Description:
SAM Coupé (Spectrum compatible homecomputer) ROM file, for use with the
simcoupe SAM Coupé emulator.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444223] Review Request: SAASound - Phillips SAA 1099 sound chip emulator library

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SAASound - Phillips SAA 1099 sound chip emulator 
library


https://bugzilla.redhat.com/show_bug.cgi?id=444223


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||444225
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444225] Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)


https://bugzilla.redhat.com/show_bug.cgi?id=444225


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||444223, 444224




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444223] New: Review Request: SAASound - Phillips SAA 1099 sound chip emulator library

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444223

   Summary: Review Request: SAASound - Phillips SAA 1099 sound chip
emulator library
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://people.atrpms.net/~hdegoede/SAASound.spec
SRPM URL: http://people.atrpms.net/~hdegoede/SAASound-3.2-5.fc9.src.rpm
Description:
Phillips SAA 1099 sound chip emulator library.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 440697] Review Request: AcetoneISO2 - CD/DVD Image Manipulator

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: AcetoneISO2 - CD/DVD Image Manipulator


https://bugzilla.redhat.com/show_bug.cgi?id=440697


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 16:34 EST ---
In rawhide, thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442787] Review Request: hamster-applet - Time tracking applet

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hamster-applet - Time tracking applet


https://bugzilla.redhat.com/show_bug.cgi?id=442787


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 16:22 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442787] Review Request: hamster-applet - Time tracking applet

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hamster-applet - Time tracking applet


https://bugzilla.redhat.com/show_bug.cgi?id=442787


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 16:01 EST ---
New Package CVS Request
===
Package Name: hamster-applet
Short Description: Time tracking applet
Owners: maxx
Branches: F-9
InitialCC: maxx
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437659] Review Request: pyke - Knowledge-based inference engine

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyke - Knowledge-based inference engine


https://bugzilla.redhat.com/show_bug.cgi?id=437659


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 15:50 EST ---
... and it is built in rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225863] Merge Review: gsl

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gsl


https://bugzilla.redhat.com/show_bug.cgi?id=225863


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225863] Merge Review: gsl

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gsl


https://bugzilla.redhat.com/show_bug.cgi?id=225863


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|devel   |rawhide




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 15:19 EST ---
[Note: This is to support ocaml-gsl, requested for EPEL-4, see bug 435983]

Package Change Request
==
Package Name: gsl
New Branches: EL-4


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435983] Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) for OCaml

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) 
for OCaml


https://bugzilla.redhat.com/show_bug.cgi?id=435983


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 15:08 EST ---
Building for all 5 branches now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435983] Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) for OCaml

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) 
for OCaml


https://bugzilla.redhat.com/show_bug.cgi?id=435983


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:54 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437659] Review Request: pyke - Knowledge-based inference engine

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyke - Knowledge-based inference engine


https://bugzilla.redhat.com/show_bug.cgi?id=437659


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:57 EST ---
cvs done. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443375] Review Request: python-openhpi - Python interface for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-openhpi - Python interface for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443375


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:54 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443374] Review Request: openhpi-subagent - SNMP subagent for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443374


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:54 EST ---
cvs done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437659] Review Request: pyke - Knowledge-based inference engine

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyke - Knowledge-based inference engine


https://bugzilla.redhat.com/show_bug.cgi?id=437659


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:55 EST ---
New Package CVS Request
===
Package Name: pyke
Short Description: Knowledge-based inference engine 
Owners: spot
Branches: F-7 F-8 F-9 EL-4 EL-5
InitialCC: 
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441072] Review Request: cwiid - Library and tools for comunicating with a wiimote

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwiid - Library and tools for comunicating with a 
wiimote


https://bugzilla.redhat.com/show_bug.cgi?id=441072





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:34 EST ---
There alteration made. New specs and rpms : 

http://bogado.net/rpm/cwiid.spec
http://bogado.net/rpm/cwiid-0.6.00-6.bog8.src.rpm

I ran rpmlint against the newly made rpm as that : 

$ rpmlint /home/bogado/rpmbuild/RPMS/x86_64/cwiid-*
cwiid.x86_64: W: incoherent-version-in-changelog 0.6.00-6 0.6.00-6.bog8
cwiid-devel.x86_64: W: no-documentation
cwiid-python2.x86_64: W: no-documentation




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441411] Review Request: adonthell - A 2D graphical RPG game

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: adonthell - A 2D graphical RPG game


https://bugzilla.redhat.com/show_bug.cgi?id=441411


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:06 EST ---
Some comments:
* As far as I checked the tarball, the license tag should be "GPLv2+".
* The explicit Requires:
-
Requires:   SDL
Requires:   python
Requires:   zlib
Requires:   freetype
Requires:   SDL_mixer
--
   should all be removed. These library related Reqires are automatically
   checked and added to binary rpms by rpmbuild itself.
* Fedora specific compilation flags (you can check this by
 $ rpm --eval %optflags) are not correctly honored:
   the section "Compiler flags" of
   http://fedoraproject.org/wiki/Packaging/Guidelines
* Please check directory ownership issue
--
[EMAIL PROTECTED] ~]# LANG=C rpm -qf /usr/share/adonthell/modules/adonthell.pyc 
adonthell-0.3.4-0.7.fc9.i386
[EMAIL PROTECTED] ~]# LANG=C rpm -qf /usr/share/adonthell
file /usr/share/adonthell is not owned by any package
[EMAIL PROTECTED] ~]# LANG=C rpm -qf /usr/share/adonthell/modules/
file /usr/share/adonthell/modules is not owned by any package
--
  Note:
  When you write
--
%files
%{_datadir}/%{name}/
--
  This contains the directory %_datadir/%name itself and
  all files/directories/etc under the directory, while
--
%files
%dir %{_datadir}/%{name}
--
  contains the directory %{_datadir}/%name only.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444158] Review Request: sugar-journal - Journal activity for sugar

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sugar-journal - Journal activity for sugar


https://bugzilla.redhat.com/show_bug.cgi?id=444158


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:05 EST ---
Review
=
Good:

- rpmlint checks return:

* sugar-journal.noarch: W: non-standard-group Sugar/Activities
* sugar-journal.src: W: non-standard-group Sugar/Activities
* sugar-journal.src: W: strange-permission sugar-journal-checkout.sh 0775

All safe to ignore.

- package meets Sugar naming guidelines
- package meets Sugar packaging guidelines
- license (GPLv2+) OK, copy of license not in source, matches source code
- spec file legible, in am. english
- source generated with included script
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED (please make sure the new sugar-toolkit package is tagged and in the
repodata before rebuilding)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443374] Review Request: openhpi-subagent - SNMP subagent for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443374


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 14:00 EST ---
New Package CVS Request
===
Package Name: openhpi-subagent
Short Description: SNMP subagent for OpenHPI
Owners: sharkcz
Branches: F-9
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441072] Review Request: cwiid - Library and tools for comunicating with a wiimote

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwiid - Library and tools for comunicating with a 
wiimote


https://bugzilla.redhat.com/show_bug.cgi?id=441072





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 13:55 EST ---
It is
--
find $RPM_BUILD_ROOT%{_sysconfdir} -type f -exec chmod 0644 {} ';'
--
... sorry...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443897] Review Request: ocaml-omake - OCaml build system with automated dependency analysis

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-omake - OCaml build system with automated 
dependency analysis


https://bugzilla.redhat.com/show_bug.cgi?id=443897


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 13:46 EST ---
Building for all 5 branches now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441072] Review Request: cwiid - Library and tools for comunicating with a wiimote

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwiid - Library and tools for comunicating with a 
wiimote


https://bugzilla.redhat.com/show_bug.cgi?id=441072





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 13:43 EST ---
should it be: 
--
find $RPM_BUILD_ROOT%{_sysconfdir} -type d -exec chmod 0755 {} ';'
--

?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435983] Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) for OCaml

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) 
for OCaml


https://bugzilla.redhat.com/show_bug.cgi?id=435983


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 13:21 EST ---
New Package CVS Request
===
Package Name: ocaml-gsl
Short Description: Interface to GSL (GNU scientific library) for OCaml
Owners: rjones
Branches: F-8 F-9 EL-4 EL-5
InitialCC: rjones
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443374] Review Request: openhpi-subagent - SNMP subagent for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443374


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 13:17 EST ---
Yes, that looks fine.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 434973] Review Request: scidavis

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scidavis


https://bugzilla.redhat.com/show_bug.cgi?id=434973


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437659] Review Request: pyke - Knowledge-based inference engine

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyke - Knowledge-based inference engine


https://bugzilla.redhat.com/show_bug.cgi?id=437659


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:44 EST ---
builds fine in mock

rpmlint is quiet 

spec is clean 

source matches upstream 
sha1sum pyke-0.2.tar.gz SOURCES/pyke-0.2.tar.gz
6ef06efb2696cca82b85d8dc1951bcb0be169ee4  pyke-0.2.tar.gz
6ef06efb2696cca82b85d8dc1951bcb0be169ee4  SOURCES/pyke-0.2.tar.gz

Approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444158] Review Request: sugar-journal - Journal activity for sugar

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sugar-journal - Journal activity for sugar


https://bugzilla.redhat.com/show_bug.cgi?id=444158





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:42 EST ---
Spec looks good to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442914] Review Request: eg - Git for mere mortals

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eg - Git for mere mortals


https://bugzilla.redhat.com/show_bug.cgi?id=442914


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:37 EST ---
Thanks Dan, I completely forgot.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443375] Review Request: python-openhpi - Python interface for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-openhpi - Python interface for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443375


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: py-openhpi -|Review Request: python-
   |Python interface for OpenHPI|openhpi - Python interface
   ||for OpenHPI




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435983] Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) for OCaml

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) 
for OCaml


https://bugzilla.redhat.com/show_bug.cgi?id=435983


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:18 EST ---
all issues fixed, so this package is APPROVED now

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 439262] Review Request: swing-layout - needed for NetBeans Platform

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swing-layout - needed for NetBeans Platform


https://bugzilla.redhat.com/show_bug.cgi?id=439262





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:18 EST ---
Hi Jaroslav,

Yep, it looks like your account is active.  Now you can set the "fedora-cvs?"
flag in this bugzilla entry, and that will request a module to be created in
CVS.  By the way, you should also get a F-9 branch now (add F-9 to the Branches:
list).

After that's done, you'll have a CVS module from which you can import your SRPM
and then start making a build.

http://fedoraproject.org/wiki/PackageMaintainers/Join#head-d6a6db5509ce8ac73b4a8306e59aa2eaaa6f30dc


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443375] Review Request: py-openhpi - Python interface for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: py-openhpi - Python interface for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443375


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:12 EST ---
New Package CVS Request
===
Package Name: python-openhpi
Short Description: Python interface for OpenHPI
Owners: sharkcz
Branches: F-9
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444158] Review Request: sugar-journal - Journal activity for sugar

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sugar-journal - Journal activity for sugar


https://bugzilla.redhat.com/show_bug.cgi?id=444158


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443375] Review Request: py-openhpi - Python interface for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: py-openhpi - Python interface for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443375





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:08 EST ---
The package name was a question for me too. So I will rename it and when
somebody will require the upstream name, it can be easily added as Provides.

Thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444158] Review Request: sugar-journal - Journal activity for sugar

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sugar-journal - Journal activity for sugar


https://bugzilla.redhat.com/show_bug.cgi?id=444158


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444158] Review Request: sugar-journal - Journal activity for sugar

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sugar-journal - Journal activity for sugar


https://bugzilla.redhat.com/show_bug.cgi?id=444158





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:09 EST ---
If that spec looks ok to you, let me know, and I'll finish the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444158] Review Request: sugar-journal - Journal activity for sugar

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sugar-journal - Journal activity for sugar


https://bugzilla.redhat.com/show_bug.cgi?id=444158





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 12:08 EST ---
Created an attachment (id=303796)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=303796&action=view)
updated spec

OK, I made a few changes:

- Since the locale files aren't in /usr/share/locale, you can't use find_lang
to pick up the mo files, you're going to have to manually split them out. This
will make the %files section a bit more complex for sugar packages, you might
consider making a modified find_lang script that finds these and generates a
proper file list (%find_sugar_lang).

- I set chmod +x on setup.py (not sure why that gets installed, but whatever)
to silence rpmlint

- You don't need to double package NEWS, the installer puts it in the activity
directory, so just mark it as %%doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438543] Review Request: Synopsis - Source-code introspection tool.

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Synopsis - Source-code introspection tool.


https://bugzilla.redhat.com/show_bug.cgi?id=438543





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 11:56 EST ---
I just uploaded what I hope may become synopsis 0.11, as srpm:

http://synopsis.fresco.org/download/srpm/synopsis-0.11-1.fc8.src.rpm

Please note that this is not an official release yet, as I'd rather like to
incorporate any changes you may suggest in order to make this acceptable for
inclusion into Fedora.
Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443374] Review Request: openhpi-subagent - SNMP subagent for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]) |




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 11:54 EST ---
Spec URL: http://fedora.danny.cz/openhpi-subagent.spec
SRPM URL: http://fedora.danny.cz/openhpi-subagent-2.3.4-2.fc9.src.rpm

%changelog
* Fri Apr 25 2008 Dan Horak  - 2.3.4-2
- initscript is not a config file
- added missing R(postun)
- update the initd script


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444165] New: Review Request: -

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444165

   Summary: Review Request:  - 
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://jsteffan.fedorapeople.org/SRPMS/mkrdns.spec
SRPM URL: http://jsteffan.fedorapeople.org/SRPMS/mkrdns-3.3-1.fc8.src.rpm
Description: An automatic reverse DNS zone generator

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444165] Review Request: mkrdns - automatic reverse DNS zone generator

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mkrdns - automatic reverse DNS zone generator


https://bugzilla.redhat.com/show_bug.cgi?id=444165


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request:  -|generator




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 441072] Review Request: cwiid - Library and tools for comunicating with a wiimote

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwiid - Library and tools for comunicating with a 
wiimote


https://bugzilla.redhat.com/show_bug.cgi?id=441072





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 11:45 EST ---
Almost okay.
For 0.6.00-5:

* Directory permission issue
  - rpmlint shows:
--
cwiid-wminput.i386: E: non-standard-dir-perm /etc/cwiid 0644
cwiid-wminput.i386: E: non-standard-dir-perm /etc/cwiid/wminput 0644
--
These directories should have 0755 permission.

When you write
--
97  %files wminput
98  %config(noreplace) %attr(0644,root,root) %{_sysconfdir}/cwiid
--
this actually sets all permissions of files/directories/etc
under %_sysconfdir/cwiid ant itself to 0644.

To avoid this, I recommend to write just:
--
%config(noreplace) %{_sysconfdir}/cwiid/
--
(I usually add slash to the end intentionally if it is a
 directory) and change the permissions beforehand at %install like:
--
find $RPM_BUILD_ROOT%{_sysconfdir} -type d -exec chmod 0644 {} ';'
--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437659] Review Request: pyke - Knowledge-based inference engine

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyke - Knowledge-based inference engine


https://bugzilla.redhat.com/show_bug.cgi?id=437659


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 11:38 EST ---
I will review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442787] Review Request: hamster-applet - Time tracking applet

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hamster-applet - Time tracking applet


https://bugzilla.redhat.com/show_bug.cgi?id=442787


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 11:21 EST ---
Sorry for the delay, switching from a minimal F8 to something in which gnome
works was a PIA.

Package Review
==

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format 
%{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM: empty
binary RPM:hamster-applet.i386: W: non-conffile-in-etc
/etc/gconf/schemas/hamster-applet.schemas
=> acceptable, per comment #5
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 License type:GPLv3+
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
 SHA1SUM of package:886bc42157cb21fa4f9a5bc6ec50c3b489438e94 
hamster-applet-0.1.7.4.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
=> it is an applet, so it is a GUI but should not be launched via a desktop file
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
 Tested on: all archs supported by koji scratch build
 [x] Package should compile and build into binary rpms on all supported
architectures.
 Tested on:F8/i386
 [x] Package functions as described.
 [x] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.



*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443807] Review Request: NetworkManager-pptp - PPTP support for NetworkManager

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: NetworkManager-pptp - PPTP support for NetworkManager
Alias: nm-pptp-review

https://bugzilla.redhat.com/show_bug.cgi?id=443807


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 11:14 EST ---
yes, devel is required. You can just dead.package the devel branch explaining
that this is a EL-5 only package?

cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443897] Review Request: ocaml-omake - OCaml build system with automated dependency analysis

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-omake - OCaml build system with automated 
dependency analysis


https://bugzilla.redhat.com/show_bug.cgi?id=443897


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 11:15 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 187243] Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lazarus : IDE and RAD tool for the free pascal 
compiler (fpc)


https://bugzilla.redhat.com/show_bug.cgi?id=187243





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 11:05 EST ---
Well, F9 is frozen now.  If you have something that you think really needs to
get into the F9 release, you can contact [EMAIL PROTECTED] and ask that
your build be tagged.  Otherwise it will go out as an update once F9 is 
released.

Rawhide doesn't start moving again for another week or so.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444134] Review Request: spe - Python IDE editor

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: spe - Python IDE editor


https://bugzilla.redhat.com/show_bug.cgi?id=444134


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435983] Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) for OCaml

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) 
for OCaml


https://bugzilla.redhat.com/show_bug.cgi?id=435983





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 10:49 EST ---
Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-gsl.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-gsl-0.6.0-3.fc9.src.rpm

* Fri Apr 25 2008 Richard W.M. Jones <[EMAIL PROTECTED]> - 0.6.0-3
- Fixed typo in description.
- Mixed use of buildroot macro / RPM_BUILD_ROOT variable fixed.
- Remove BR gsl (brought in by gsl-devel, so unnecessary).


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443897] Review Request: ocaml-omake - OCaml build system with automated dependency analysis

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-omake - OCaml build system with automated 
dependency analysis


https://bugzilla.redhat.com/show_bug.cgi?id=443897


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 10:44 EST ---
New Package CVS Request
===
Package Name: ocaml-omake
Short Description: OCaml build system with automated dependency analysis
Owners: rjones
Branches: F-8 F-9 EL-4 EL-5
InitialCC: rjones
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444158] New: Review Request: sugar-journal - Journal activity for sugar

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444158

   Summary: Review Request: sugar-journal - Journal activity for
sugar
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://ausil.us/packages/sugar-journal.spec
SRPM URL: http://ausil.us/packages/sugar-journal-79-1.fc9.src.rpm
Description: Journal activity for sugar.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443375] Review Request: py-openhpi - Python interface for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: py-openhpi - Python interface for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443375


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 10:41 EST ---
+ rpmlint output
  no output
? package name satisfies the packaging naming guidelines

  I'm dubious about naming the package 'py-openhpi' even though
  strictly speaking this doesn't violate any Python guideline.
  I would rename it python-openhpi instead just for consistency
  with other Python packages in Fedora.

+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
  i386
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
n/a does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if 
available
- reviewer should build the package in mock
  (but ok coz built in koji)
+ the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
n/a scriptlets should be sane
n/a pkgconfig files should go in -devel
n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or 
/usr/sbin

===

APPROVED

However please consider renaming the package to python-openhpi.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443374] Review Request: openhpi-subagent - SNMP subagent for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443374





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 10:33 EST ---
- rpmlint output

openhpi-subagent.i386: E: executable-marked-as-config-file
/etc/rc.d/init.d/openhpi-subagent
openhpi-subagent.i386: W: conffile-without-noreplace-flag
/etc/rc.d/init.d/openhpi-subagent
openhpi-subagent.i386: W: service-default-enabled 
/etc/rc.d/init.d/openhpi-subagent
openhpi-subagent.i386: W: service-default-enabled 
/etc/rc.d/init.d/openhpi-subagent

Apparently init scripts shouldn't be marked as %config, so just
remove that annotation.  If the init script is intended to be
edited, then you should create a config file under /etc/sysconfig
and have the init file source that config file.

The service should be disabled by default.
http://fedoraproject.org/wiki/Packaging/SysVInitScript#head-c074b6a78b42c4c797d978750719ebcf262b4e61

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
  i386
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if 
available
- reviewer should build the package in mock
  (but koji build, so no need)
+ the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
+ scriptlets should be sane
  but see above
n/a pkgconfig files should go in -devel
n/a shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or 
/usr/sbin

--

The only issues are those problems found by rpmlint.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443374] Review Request: openhpi-subagent - SNMP subagent for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED])




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442705] Review Request: ocaml-bitmatch - OCaml library for matching and constructing bitstrings

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-bitmatch - OCaml library for matching and 
constructing bitstrings


https://bugzilla.redhat.com/show_bug.cgi?id=442705





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 10:15 EST ---
Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-bitmatch.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-bitmatch-0.5-1.fc8.src.rpm

New upstream version (0.5).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 10:04 EST ---
As expected, trying to build your srpm in mock fails with

which: no libtoolize in
(/usr/lib/ccache:/usr/local/sbin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/root/bin:/builddir/bin)
libtoolize not found. Please install it.

due to the missing BuildRequires for the autogen.sh call

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443588] Review Request: fig2sxd - fig to sxd converter

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fig2sxd - fig to sxd converter


https://bugzilla.redhat.com/show_bug.cgi?id=443588





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 09:57 EST ---
Package doesn't build:
* Missing deps:
...
In file included from zipwrite.cpp:21
: zipwrite.h:29:18: error: zlib.h: No such file or directory  
...
Likely a missing dep on zlib-devel.


* Package doesn't honor RPM_OPT_FLAGS:

g++ -Wall -W -O2 -g  -o fig2sxd.o -c fig2sxd.cpp  
g++ -Wall -W -O2 -g  -o xfig_arc.o -c xfig_arc.cpp


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443675] Review Request: sip-redirect - Tiny IPv4 and IPv6 SIP redirect server written in Perl

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sip-redirect - Tiny IPv4 and IPv6 SIP redirect server 
written in Perl


https://bugzilla.redhat.com/show_bug.cgi?id=443675





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 09:53 EST ---
Peter, that's a thing which can be changed. If changed, will it switch to a 
"yes go"? ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 09:44 EST ---
Hey, thanks for picking this up, it was on my list of things to look at...


Some preliminary comments on the spec file:


This looks wrong, only devel packages should require devel packages:

Requires: gtk2-devel 


These will almost certainly be pulled in automatically be library dependencies,
so no need to list them explicitly:
 
Requires: glib2
Requires: libxml2
Requires: GConf2


The devel package must require pkgconfig, since it contains a pc file.


The description is misleading, since the devel package should _not_ contain
static libraries. It should contain the unversioned symlinks (.so) for shared
libraries.


Running autogen.sh should only be necessary when building from a checkout. Even
if this package is based on a git snapshot right now, the tarball should be
produced by 'make dist' and the autogen.sh call should be unnecessary. If it
were necessary for some reason, then you are missing the necessary BuildRequires
for automake, autoconf, etc


missing from the file list:
%dir %{_datadir}/geoclue-providers
%dir %{_includedir}/geoclue




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443675] Review Request: sip-redirect - Tiny IPv4 and IPv6 SIP redirect server written in Perl

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sip-redirect - Tiny IPv4 and IPv6 SIP redirect server 
written in Perl


https://bugzilla.redhat.com/show_bug.cgi?id=443675





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 09:41 EST ---
Can't download sources from your main site w/o registration. It's no go for 
Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435983] Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) for OCaml

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) 
for OCaml


https://bugzilla.redhat.com/show_bug.cgi?id=435983





--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 09:06 EST ---
OK  source files match upstream:
819d2f95f44cc4c331a4aa644f8d23704477de05  ocamlgsl-0.6.0.tar.gz
OK  package meets naming and versioning guidelines.
BAD specfile is properly named, is cleanly written and uses macros 
consistently.
OK  dist tag is present.
OK  build root is correct.
OK  license field matches the actual license.
OK  license is open source-compatible (GPLv2). License text included in 
package.
OK  latest version is being packaged.
BAD BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (Rawhide/x86_64).
N/A debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires look sane.
N/A %check is present and all tests pass.
OK  no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  scriptlets are present.
OK  code, not content.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no libtool .la droppings.
OK  not a GUI app.

notes
- typo on %description - langage => language
- mixed usage of $RPM_BUILD_ROOT and %{buildroot} in %install (info files)
- BR: gsl >= 1.9 should be removed as it will brought by gsl-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435983] Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) for OCaml

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gsl - Interface to GSL (GNU scientific library) 
for OCaml


https://bugzilla.redhat.com/show_bug.cgi?id=435983


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443897] Review Request: ocaml-omake - OCaml build system with automated dependency analysis

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-omake - OCaml build system with automated 
dependency analysis


https://bugzilla.redhat.com/show_bug.cgi?id=443897


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 08:37 EST ---
OK  source files match upstream:
e78c9d8858749f5e234cba303637980e24085cbc  omake-0.9.8.5-3.tar.gz
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros 
consistently.
OK  dist tag is present.
OK  build root is correct.
OK  license field matches the actual license.
OK  license is open source-compatible. License text included in package.
OK  latest version is being packaged.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (Rawhide/X86_64).
N/A debuginfo package looks complete.
OK  rpmlint output can be ignored.
OK  final provides and requires look sane.
N/A %check is present and all tests pass.
OK  no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  no scriptlets present.
OK  code, not content.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no libtool .la droppings.
OK  not a GUI app.


notes
- remove the exec bit from the patch

this package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443375] Review Request: py-openhpi - Python interface for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: py-openhpi - Python interface for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443375


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443374] Review Request: openhpi-subagent - SNMP subagent for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 443374] Review Request: openhpi-subagent - SNMP subagent for OpenHPI

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openhpi-subagent - SNMP subagent for OpenHPI


https://bugzilla.redhat.com/show_bug.cgi?id=443374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226428] Merge Review: speex

2008-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: speex


https://bugzilla.redhat.com/show_bug.cgi?id=226428


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED
   Flag|needinfo?([EMAIL PROTECTED]|
   |net)|




--- Additional Comments From [EMAIL PROTECTED]  2008-04-25 07:05 EST ---
OK, one last minor thing : The %{_defaultdocdir}/speex line isn't needed. I see
this was supposed to fix bug #439284 but I think it's wrong as the
/usr/share/doc/speex directory isn't included in the package. Also, you should
escape the macro in the %changelog by putting %%{_defaultdocdir}/speex so that
it doesn't get expanded to the value in there.

The rest looks all good, modulo some weird (yet very minor) tabs and spaces
mixing inside the spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >