[Bug 444223] Review Request: SAASound - Phillips SAA 1099 sound chip emulator library

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SAASound - Phillips SAA 1099 sound chip emulator 
library


https://bugzilla.redhat.com/show_bug.cgi?id=444223


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444223] Review Request: SAASound - Phillips SAA 1099 sound chip emulator library

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SAASound - Phillips SAA 1099 sound chip emulator 
library


https://bugzilla.redhat.com/show_bug.cgi?id=444223


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 03:15 EST ---
OK  source files match upstream:
2c9824b67a09bdbb99ac11ea319b705bf6c09dd2  SAASound-3.2.tar.gz
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros 
consistently.
OK  dist tag is present.
OK  build root is correct.
OK  license field matches the actual license.
OK  license is open source-compatible (BSD). License text included in 
package.
OK  latest version is being packaged.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (Rawhide/x86_64).
OK  debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires look sane.
N/A %check is present and all tests pass.
OK  shared libraries are added to the regular linker search paths, ldconfig 
call
present
N/A owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  correct scriptlets present.
OK  code, not content.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  headers in -devel.
OK  no pkgconfig files.
OK  no libtool .la droppings.
OK  not a GUI app.

this package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442867] Review Request: ocaml-gettext - OCaml library for i18n

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gettext - OCaml library for i18n


https://bugzilla.redhat.com/show_bug.cgi?id=442867





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 03:21 EST ---
Thanks for looking at this.  The story with naming is that I've patched
this to work with OCaml 3.10 and contributed the patch upstream.
Coincidentally the author blogged about this yesterday:

http://le-gall.net/sylvain+violaine/blog/index.php?2008/04/24/43-ocaml-gettext-on-going-progress-to-version-030

BTW, I wouldn't believe that release date .. seen too many release dates
come and go already, although it'd be nice if it happens.

Anyway, I changed the naming to conform with guidelines.

Fop - this is a saga: If enabled, it causes a giant Java backtrace / error,
and there seems to be no way to disable just fop (I even tried patching
aclocal.m4).  So in the meantime I've disabled the documentation.

Here's a new version that should fix everything:

Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-gettext.spec
SRPM URL:
http://www.annexia.org/tmp/ocaml/ocaml-gettext-0.2.0-3.20080321patch.fc9.src.rpm

Koji build:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=584043


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444223] Review Request: SAASound - Phillips SAA 1099 sound chip emulator library

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SAASound - Phillips SAA 1099 sound chip emulator 
library


https://bugzilla.redhat.com/show_bug.cgi?id=444223


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 03:29 EST ---
Thanks for the review!

New Package CVS Request
===
Package Name:  SAASound
Short Description: Phillips SAA 1099 sound chip emulator library
Owners:jwrdegoede
Branches:  F-8 F-9
InitialCC:
Cvsextras Commits: Yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444264] Review Request: usb_modeswitch - brings umts / 4g cards into operational mode

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: usb_modeswitch - brings umts / 4g cards into 
operational mode


https://bugzilla.redhat.com/show_bug.cgi?id=444264





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 04:03 EST ---
This is my first rpm, so it may be horrible :-O

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444264] New: Review Request: usb_modeswitch - brings umts / 4g cards into operational mode

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444264

   Summary: Review Request: usb_modeswitch - brings umts / 4g cards
into operational mode
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


Spec URL: http://www.romal.de/files/usb_modeswitch.spec
SRPM URL: http://www.romal.de/files/usb_modeswitch-0.9.4beta2-1.fc9.src.rpm
Description: USB Modeswitch brings up your datacard into operational mode. When 
plugged in they identify themself as cdrom and present some non-Linux 
compatible installation files. This tool deactivates this cdrom-devices and 
enables the real communication device. It supports most devices built and sold 
by Huawei, T-Mobile, Vodafone, Option, ZTE, Novatel.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444224] Review Request: samcoupe-rom - SAM Coupé (Spectrum compatible homecomputer ) ROM file

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: samcoupe-rom - SAM Coupé (Spectrum compatible 
homecomputer) ROM file


https://bugzilla.redhat.com/show_bug.cgi?id=444224


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 04:23 EST ---
Looks good, per
http://lists.rpmfusion.org/pipermail/rpmfusion-developers/2008-April/000471.html
the content (ROM) was ACKed by Spot.


APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444225] Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)


https://bugzilla.redhat.com/show_bug.cgi?id=444225


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 04:45 EST ---
OK  source files match upstream:
16b0a06e47d344ea75d64f350d3f9f0bee2d2b7e  SimCoupe-1.0.tar.gz
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros 
consistently.
OK  dist tag is present.
OK  build root is correct.
OK  license field matches the actual license.
OK  license is open source-compatible. License text included in package.
OK  latest version is being packaged.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (Rawhide/x86_64).
OK  debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires look sane.
N/A %check is present and all tests pass.
OK  no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  correct scriptlets present.
OK  code, not content.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no libtool .la droppings.
OK  is a GUI app, desktop file correctly installed

this package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 04:47 EST ---
Fixed up the group for the test gui, also removed the gtk requirement as it
should get it automatically.

SPEC: http://fedora.roving-it.com/rawhide/geoclue.spec
SRPM: http://fedora.roving-it.com/rawhide/geoclue-0.11.1-3.fc9.src.rpm

Thanks for the feedback.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444225] Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)


https://bugzilla.redhat.com/show_bug.cgi?id=444225


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 05:02 EST ---
New Package CVS Request
===
Package Name:  simcoupe
Short Description: SAM Coupé emulator (spectrum compatible)
Owners:jwrdegoede
Branches:  F-8 F-9
InitialCC:
Cvsextras Commits: Yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444224] Review Request: samcoupe-rom - SAM Coupé (Spectrum compatible homecomputer ) ROM file

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: samcoupe-rom - SAM Coupé (Spectrum compatible 
homecomputer) ROM file


https://bugzilla.redhat.com/show_bug.cgi?id=444224


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 05:02 EST ---
Thanks for the review!

New Package CVS Request
===
Package Name:  samcoupe-rom
Short Description: SAM Coupé (Spectrum compatible homecomputer) ROM file
Owners:jwrdegoede
Branches:  F-8 F-9
InitialCC:
Cvsextras Commits: Yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426985] Review Request: php-suhosin - Suhosin extension for the php language

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-suhosin - Suhosin extension for the php language


https://bugzilla.redhat.com/show_bug.cgi?id=426985


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 08:33 EST ---
As i'm not a sponsor, only a few comments.

- lastest version is 0.9.23
- you should requires php(zend-abi) (not php(zend-api))
- use %setup -q -n suhosin-%{version}   (which simplify other part)
- no need to requires php-common as the php(zend-abi) assure ABI compatibility
of extension.

It will be great to provides a config file with some recommended value (for 
ex : suhosin.log.sapi=S_ALL, and probably others)

Do you succeed to run the test suite ?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 437667] Review Request: dvipdfm - A DVI to PDF converter

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvipdfm - A DVI to PDF converter


https://bugzilla.redhat.com/show_bug.cgi?id=437667





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 11:27 EST ---
Spec URL: http://jgu.fedorapeople.org/dvipdfm.spec
SRPM URL: http://jgu.fedorapeople.org/dvipdfm-0.13.2d-37.fc9.src.rpm

* Sat Apr 26 2008 Jonathan G. Underwood <[EMAIL PROTECTED]> - 0.13.2d-37
- Fix comment about texlive-texmf [tex(tex)] BuildRequires
- Rename config file tp dvipdfm-config in SRPM
- Add INSTALL='install -p' to makeinstall
- Run mktexlsr on install


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225863] Merge Review: gsl

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gsl


https://bugzilla.redhat.com/show_bug.cgi?id=225863


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 12:35 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 430307] Review Request: Falcon - The Falcon Programming Language

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Falcon - The Falcon Programming Language


https://bugzilla.redhat.com/show_bug.cgi?id=430307


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 12:41 EST ---
cvs done. 

(I also did a F-9 branch as it makes little sense not to at this point). 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426883] Review Request: brazil - Extremely small footprint Java HTTP stack

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: brazil - Extremely small footprint Java HTTP stack


https://bugzilla.redhat.com/show_bug.cgi?id=426883


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||
   Flag|fedora-review?, fedora-cvs? |fedora-review+, fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 12:39 EST ---
I assume from comment #10 this is approved, so setting the fedora-review flag to
+. ;) 

cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444223] Review Request: SAASound - Phillips SAA 1099 sound chip emulator library

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SAASound - Phillips SAA 1099 sound chip emulator 
library


https://bugzilla.redhat.com/show_bug.cgi?id=444223


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 12:42 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444224] Review Request: samcoupe-rom - SAM Coupé (Spectrum compatible homecomputer ) ROM file

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: samcoupe-rom - SAM Coupé (Spectrum compatible 
homecomputer) ROM file


https://bugzilla.redhat.com/show_bug.cgi?id=444224


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 12:44 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444225] Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: simcoupe - SAM Coupe emulator (spectrum compatible)


https://bugzilla.redhat.com/show_bug.cgi?id=444225


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 12:46 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 434906] Review Request: xosview - OS resource viewer

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xosview - OS resource viewer


https://bugzilla.redhat.com/show_bug.cgi?id=434906





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 13:23 EST ---
All right.  Please see the following updated SPEC file and SRC rpm:

Spec: http://optics.csufresno.edu/fedora/extras/8/SPECS/xosview.spec
SRPM:
http://optics.csufresno.edu/fedora/extras/8/SRPMS/xosview-1.8.3.20080425cvs-8.fc8.src.rpm

The following things have been fixed:

- License Issue & COPYING.BSD file (see comments)

- Pulling directly source

- Removed corresponding cvs patch (diff) file

- Fixed Post-Release Naming Guidelines

- Fixed Categories section in Desktop file


I believe... ...everything is fixed.  rpmlint is silent.

Thanks for your patience in this!

I will probably start the process of uploading new spec files for other
applications and tighten up the spec files based upon the feedback here.

Greg

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438543] Review Request: Synopsis - Source-code introspection tool.

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Synopsis - Source-code introspection tool.


https://bugzilla.redhat.com/show_bug.cgi?id=438543





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 14:00 EST ---
Thanks for the feedback. Is there any particular reason to prefer byacc over 
bison ?

As to the build failure, unfortunately I'm unable to reproduce it. I'm now
trying to build via 'mock', so may be things will look different there.

One thing I noticed is an error in your build.log is this:

ln: 
creating symbolic link
`/builddir/build/BUILD/synopsis-0.11/src/Synopsis/gc/atomic_ops.c'
: File exists

The appropriate line in configure.ac is:

 test -e ${srcdir}/atomic_ops.c \
|| ln -s ${srcdir}/libatomic_ops/src/atomic_ops.c \
 ${srcdir}/atomic_ops.c

which means the link command should only be executed if the link target doesn't
exist yet. I wonder why this doesn't work for you. Is your version of the shell
buggy ? (This may be unrelated to the final error, I'm merely trying to find any
hints in the build.log that could explain why I can't reproduce the problem.)

Thanks !

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 439262] Review Request: swing-layout - needed for NetBeans Platform

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swing-layout - needed for NetBeans Platform


https://bugzilla.redhat.com/show_bug.cgi?id=439262





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 14:17 EST ---
Thanks for hint, but I've just tried to change the fedora-cvs flag and this is 
the reply:

You tried to grant fedora-cvs. Only an authorized user can make this change. 
 Please press Back and try again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 439262] Review Request: swing-layout - needed for NetBeans Platform

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: swing-layout - needed for NetBeans Platform


https://bugzilla.redhat.com/show_bug.cgi?id=439262





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 14:35 EST ---
Jaroslav: I still don't see you in the cvsextras group. 

Take a look at: 
http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b

(step 4 of that link)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442867] Review Request: ocaml-gettext - OCaml library for i18n

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gettext - OCaml library for i18n


https://bugzilla.redhat.com/show_bug.cgi?id=442867


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 15:18 EST ---
Excellent. That solves all the issues I see...so this package is APPROVED. 

You might wait a day or two to import on the chance that 0.3.0 comes out. ;) 



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442867] Review Request: ocaml-gettext - OCaml library for i18n

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gettext - OCaml library for i18n


https://bugzilla.redhat.com/show_bug.cgi?id=442867





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 16:43 EST ---
Heh, I've been waiting for this one too long. Thanks for doing it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442867] Review Request: ocaml-gettext - OCaml library for i18n

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-gettext - OCaml library for i18n


https://bugzilla.redhat.com/show_bug.cgi?id=442867


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 16:44 EST ---
New Package CVS Request
===
Package Name: ocaml-gettext
Short Description: OCaml library for i18n
Owners: rjones
Branches: F-8 F-9
InitialCC: rjones
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438543] Review Request: Synopsis - Source-code introspection tool.

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Synopsis - Source-code introspection tool.


https://bugzilla.redhat.com/show_bug.cgi?id=438543





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 17:17 EST ---
(Just a little note to let you know that I can reproduce the error when building
via mock. I'll thus be  able to track the problem down on my own, thanks.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188542] Review Request: hylafax

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/show_bug.cgi?id=188542





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 18:36 EST ---
Okay, I'm now testing with Fedora 9 Preview.  The patch for configure does work.

I sympathize with the dislike for the non-standard configure script and
Makefiles.  They can be quite cumbersome at times.  Due to other projects with
which I am involved I am familiar with autotools, and in my opinion, the score
between them really is par.  autotools, itself, can be quite cumbersome... not
only for developers, but also for users who may have to hunt down specific
versions of autotools to make things work right.  I am in no way against looking
for a better way, even if that does mean autotools, but for now it's probably
best to address the issues in the existing configure script and wait for such a
time as someone passionate about this issue comes along - or until an undeniable
advantage manifests itself in making a conversion.

1) "The test trying to check for -O -g must have failed."

Indeed.  This has now been fixed.

2) Traditionally HylaFAX configure used --with-GCOPTS= and --with-GCXXOPTS
instead of CFLAGS and CXXFLAGS.  I've now made configure use CFLAGS and CXXFLAGS
instead if GCOPTS and GCXXOPTS are not given.

3) I'm not having a problem with PAM detection:

Checking for PAM (Pluggable Authentication Module) support
... found. Enabling PAM support

I get this both with the source build (from tarball) and with rpmbuild.  Are you
sure that you have pam-devel installed?  Please check again with the SRPM that
I'll link below.

4) "Using ZLIB include files from"

This can be ignored.  I've made configure not print this message if $ZLIBINC is
empty.

5) "./configure: line 3274: 28995 Segmentation fault  $TIFFBIN/tiffcp -c g4
misc/jbig.tif misc/foo.tif > /dev/null 2>&1"

Here configure is checking to see if your libtiff supports JBIG or not, and it
doesn't, and in fact your libtiff segfaults when trying to process
JBIG-compressed TIFF files.  configure correctly interprets this, however, the
output is, indeed, annoying, and so I've made configure now silence this.

6) I'm not sure how to resolve this one.  configure takes efforts to find the
needed library headers in non-standard locations and then uses -I for them. 
Assuming it finds them in /usr/include then that's what you're seeing.  When
should -I be used or not?

7) From the spec file comments:

# FAXUSER, FAXGROUP, SYSUSER and SYSGROUP are set to the current user to
# avoid warnings about chown/chgrp if the user building the SRPM is not root;
# they are set to the correct values with the RPM attr macro

Thanks.

SPEC: http://osdn.dl.sourceforge.net/sourceforge/hylafax/hylafax.spec
SRPM: http://osdn.dl.sourceforge.net/sourceforge/hylafax/hylafax-5.2.4-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 444315] New: mousetweaks - Mouse accessibility support for the GNOME desktop

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=444315

   Summary: mousetweaks - Mouse accessibility support for the GNOME
desktop
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: low
  Priority: low
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: fedora-package-review@redhat.com,[EMAIL PROTECTED]


The Mousetweaks package provides mouse accessibility enhancements for
the GNOME desktop, such as performing various clicks without using any
hardware button. The options can be accessed through the Accessibility
tab of the Mouse Preferences of GNOME Control Center or through command-line.

http://people.redhat.com/mclasen/mousetweaks.spec
http://people.redhat.com/mclasen/mousetweaks-2.22.1-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438543] Review Request: Synopsis - Source-code introspection tool.

2008-04-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Synopsis - Source-code introspection tool.


https://bugzilla.redhat.com/show_bug.cgi?id=438543





--- Additional Comments From [EMAIL PROTECTED]  2008-04-26 20:55 EST ---
I have updated the srpm at
http://synopsis.fresco.org/download/srpm/synopsis-0.11-1.fc8.src.rpm to
circumvent the compilation error, by using a pre-installed libgc / libgc-devel
package.
Compilation now succeeds with i368 as well as x86_64, and I see the packaging
error I mentioned earlier:

%{_libdir} is set to /usr/lib64, but Synopsis installed its library into 
/usr/lib. 
Where does rpmbuild get its _libdir value from ? I can't find any way to
establish on what platforms to install in /usr/lib64, and where to install into
/usr/lib.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review