[Bug 226079] Merge Review: libxml2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libxml2 https://bugzilla.redhat.com/show_bug.cgi?id=226079 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 02:25 EST --- About the text files encoding discussion. Although I fully agree with Daniel that blindly converting text-ish files which actually specify an encoding in their headers is both wrong and dangerous as that actually breaks stuff, normal text files, esp. ones in %doc should be in UTF-8, so that when opened they display correctly. Indeed the changelog is a perfect example of why all plain text files must be UTF-8, had it always been UTF-8 the problems between part being in west-european encoding and parts in east-european encoding would not exist. Also I think its worth noting that Fedora is not the only distro doing this, Debian for example also tries to have all text files in the distro in UTF-8. Now I can understand when Daniel says that he has higher priority things to fix. So Daniel, as upstream, will you take a patch changing the encoding of all files which end up in %doc, which changes them to UTF-8? and even fix the changelog to be UTF-8 (split it in pieces, iconv pieces, put back together) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433925] Review Request: libyahoo2 - Library for the Yahoo! Messenger Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libyahoo2 - Library for the Yahoo! Messenger Protocol https://bugzilla.redhat.com/show_bug.cgi?id=433925 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 02:32 EST --- New Package CVS Request === Package Name: libyahoo2 Short Description: Library for the Yahoo! Messenger Protocol Owners: rayvd Branches: F-8 F-9 EL-4 EL-5 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444760] Review Request: obm - Open Business Management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: obm - Open Business Management https://bugzilla.redhat.com/show_bug.cgi?id=444760 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:09 EST --- First comments From rpmlint : obm.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 32) = minor and easy to fix obm.noarch: E: non-standard-uid /var/www/obm apache obm.noarch: E: non-standard-gid /var/www/obm apache = seems ok, but could probably be /var/lib/obm ? obm.noarch: E: non-standard-uid /usr/share/obm apache obm.noarch: E: non-standard-gid /usr/share/obm apache = really need to be fixed. Apache shouldn't have write acces here From obm-httpd.conf ErrorLog CustomLog AddDefaultCharset should be in comment (for vhost use only) From obm documentation, some php_flag/value missing php_value include_path .:/usr/share/pear:/usr/share/php:/usr/share/obm php_flag session.bug_compat_42 Off php_flag session.bug_compat_warn Off php_flag magic_quotes_gpc On Config should go to /etc/obm (probably an simple link in /usr/share/obm/conf) A working obm_conf.inc obm_conf.ini should be provided -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448311] Review Request: lostlabyrinth - Lost Labyrinth is a coffeebreak dungeon crawling game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lostlabyrinth - Lost Labyrinth is a coffeebreak dungeon crawling game https://bugzilla.redhat.com/show_bug.cgi?id=448311 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:16 EST --- As the licensing statement in the readme wasn't very clear, esp not if the graphics and sounds where GPL too, I've mailed upstream about this. Here is a new version which includes a copy of upstream's answer (which says all parts are GPL, except for the music which we (currently) do not package). Spec URL: http://people.atrpms.net/~hdegoede/lostlabyrinth.spec SRPM URL: http://people.atrpms.net/~hdegoede/lostlabyrinth-2.9.2-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448313] Review Request: lostlabyrinth-graphics - Lost Labyrinth graphics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lostlabyrinth-graphics - Lost Labyrinth graphics https://bugzilla.redhat.com/show_bug.cgi?id=448313 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:21 EST --- As the licensing statement in the readme wasn't very clear, esp not if the graphics and sounds where GPL too, I've mailed upstream about this. Here is a new version which includes a copy of upstream's answer (which says all parts are GPL, except for the music which we (currently) do not package). Spec URL: http://people.atrpms.net/~hdegoede/lostlabyrinth-graphics.spec SRPM URL: http://people.atrpms.net/~hdegoede/lostlabyrinth-graphics-2.9.0-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448312] Review Request: lostlabyrinth-sounds - Lost Labyrinth sounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lostlabyrinth-sounds - Lost Labyrinth sounds https://bugzilla.redhat.com/show_bug.cgi?id=448312 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:21 EST --- As the licensing statement in the readme wasn't very clear, esp not if the graphics and sounds where GPL too, I've mailed upstream about this. Here is a new version which includes a copy of upstream's answer (which says all parts are GPL, except for the music which we (currently) do not package). Spec URL: http://people.atrpms.net/~hdegoede/lostlabyrinth-sounds.spec SRPM URL: http://people.atrpms.net/~hdegoede/lostlabyrinth-sounds-2.5.2-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:29 EST --- Wanna swap reviews? : * elice - Elice is a PureBasic to c++ translator / compiler https://bugzilla.redhat.com/show_bug.cgi?id=448310 * lostlabyrinth - Lost Labyrinth is a coffeebreak dungeon crawling game https://bugzilla.redhat.com/show_bug.cgi?id=448311 * lostlabyrinth-sounds - Lost Labyrinth sounds https://bugzilla.redhat.com/show_bug.cgi?id=448312 * lostlabyrinth-graphics - Lost Labyrinth graphics https://bugzilla.redhat.com/show_bug.cgi?id=448313 * trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447639] Review Request: typespeed - Test your typing speed and get your fingers' CPS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: typespeed - Test your typing speed and get your fingers' CPS https://bugzilla.redhat.com/show_bug.cgi?id=447639 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:29 EST --- Wanna swap reviews? : * elice - Elice is a PureBasic to c++ translator / compiler https://bugzilla.redhat.com/show_bug.cgi?id=448310 * lostlabyrinth - Lost Labyrinth is a coffeebreak dungeon crawling game https://bugzilla.redhat.com/show_bug.cgi?id=448311 * lostlabyrinth-sounds - Lost Labyrinth sounds https://bugzilla.redhat.com/show_bug.cgi?id=448312 * lostlabyrinth-graphics - Lost Labyrinth graphics https://bugzilla.redhat.com/show_bug.cgi?id=448313 * trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444760] Review Request: obm - Open Business Management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: obm - Open Business Management https://bugzilla.redhat.com/show_bug.cgi?id=444760 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:32 EST --- Alias /images could potentialy conflict with other apps. You can change it to obmimages as this can be configured in obm_conf.inc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 273701] Review Request: gnome-main-menu - Gnome Main Menu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-main-menu - Gnome Main Menu https://bugzilla.redhat.com/show_bug.cgi?id=273701 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:40 EST --- Updated to latest SVN Added build requirements Added a fedora specific patch for menu items/schemas Added a temporary patch to reverse recent changes to network status agent preventing broken build on fedora, patch can be removed when network manager in fedora is updated. spec: http://www.wine-doors.org/rpm/gnome-main-menu.spec rpm: http://www.wine-doors.org/rpm/gnome-main-menu-0.9.11-1.i386.rpm src: http://www.wine-doors.org/rpm/gnome-main-menu-0.9.11-1.src.rpm dev: http://www.wine-doors.org/rpm/gnome-main-menu-devel-0.9.11-1.i386.rpm dbg: http://www.wine-doors.org/rpm/gnome-main-menu-debuginfo-0.9.11-1.i386.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427121] Review Request: grib_api - ECMWF encoding/decoding GRIB software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:55 EST --- Yes, I am waiting for upstream for the next release to build the package, as they asked, and as it isn't built I don't close the bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442280] Review Request: squirrel - high level imperative/OO programming language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: squirrel - high level imperative/OO programming language https://bugzilla.redhat.com/show_bug.cgi?id=442280 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:59 EST --- I'll review this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448310] Review Request: elice - Elice is a PureBasic to c++ translator / compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: elice - Elice is a PureBasic to c++ translator / compiler https://bugzilla.redhat.com/show_bug.cgi?id=448310 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 05:35 EST --- formal review: OK source files match upstream: 11fbf36691e4db909d7a641daa8e5983431ce6f0 trophy-1.1.5.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPL). License text included in package. OK latest version is being packaged. BAD BuildRequires are proper - ClanLib-devel is missing OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64) OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets for updating the icon cache are present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app, desktop file is installed = only the BR: needs fixing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448310] Review Request: elice - Elice is a PureBasic to c++ translator / compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: elice - Elice is a PureBasic to c++ translator / compiler https://bugzilla.redhat.com/show_bug.cgi?id=448310 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 05:34 EST --- - Summary: A partial PureBasic to C++ cross-compiler ? Generation commands should use svn export instead - The ruby BR is covered by ruby-racc ? C++ case in %description ? make: bzr: Command not found - not a blocker, but it is ugly (I thought it was pulled from svn...) - I don't like that the lostlaby patches are in here instead of the lostlabyrinth SRPM . Noted that 2 lostlabyrinth-specific executables are included ??? HOLY CRAP! Is that really all the font data from Vera.ttf included in the script?! ? No license reference in many of the source files ? Tests aren't run in %check -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429809] Review Request: mumble - low-latency, high quality voice chat software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mumble - low-latency, high quality voice chat software https://bugzilla.redhat.com/show_bug.cgi?id=429809 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 06:07 EST --- Speex is bundled because Mumble needs a newer version of speex than what is packaged. The resource problem is due to files that are copied in the Makefile, the actual problem is your permission denied for lrelease. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226079] Merge Review: libxml2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libxml2 https://bugzilla.redhat.com/show_bug.cgi?id=226079 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 06:19 EST --- Okay, I will drop ChangeLog and News from the package, after reading this and the thread it looks apparently more important to the Fedora Packaging guys to follow blindly a This has to be UTF-8 rule than understanding that people may have preferences set in their viewing and editing tools. I would think it is more important to be able to read the ChangeLog missing some characters than not seeing anything. Not a big deal they will go look upstream if they really need this. For the extended review from comment #11, thanks, I will look at those, best is probably to drop anything which gives problems. For the spec file specifics if you have time to derive a patch I will take it. For the DESTDIR stuff over the years libxml2 had to support it, sometime it broke, I think other OSes rely on it (BSDs) but I don't have a 100% guaranteed answer to this. W.r.t. comment #13 , the ChangeLog is 19000+ lines how would you make sure you actually guessed the encoding of characters in a name correctly ? IMHO you just can't unless chasing each people name and making sure it matches. That's history, I prefer to keep it that way. If the history annoys Fedora I will just drop it from the package. The argument for it having to be UTF-8 just doesn't hold, you're picking one encoding while, the problem is that 1/ you can't garantee there is only one encoding in a text file 2/ even if it's the case you have no metadata to indicate what encoding was used for authoring. Blindly assuming this has to be UTF-8 is a wrong and lost battle, even the Unicode consortium would never try to suggest something that radical, and sorry if I were to write a README.cn I would use a BIG5 encoding in it, not UTF-8, because that's not what the concerned people would expect. Get yourself a filesystem with metadata if you really want to solve the problem, forcing upstream into UTF-8 or converting on the fly are both wrong IMHO. For the NEWS file it's actually generated via XSLT when the package is released xsl:output method=text encoding=ISO-8859-1/ it could be switched to UTF-8 without problem but converting at rpm generation time is just the Wrong Way of doing it. Still w.r.t. #13 it's not so much that I think I have higher priorities to do, it's that I see things imposed like a dogma, that they look broken to me, and that I feel that trying to change the minds of people around about this is a lost battle. It's getting a religious thing, and my belief is that changing files coming from upstream is fundamentally wrong %doc or not. Your religion v.s. my religion, we will go nowhere, and I prefer to do something else. Daniel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444574] Review Request: pidgin-lastfm - Display informaiton form Last.fm profile in Pidgin status message
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pidgin-lastfm - Display informaiton form Last.fm profile in Pidgin status message https://bugzilla.redhat.com/show_bug.cgi?id=444574 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226079] Merge Review: libxml2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libxml2 https://bugzilla.redhat.com/show_bug.cgi?id=226079 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 06:36 EST --- (In reply to comment #14) Okay, I will drop ChangeLog and News from the package, after reading this and the thread it looks apparently more important to the Fedora Packaging guys to follow blindly a This has to be UTF-8 rule than understanding that people may have preferences set in their viewing and editing tools. It should not be done blindly. But utf8 is the default for fedora since some time for locales, so, for example, the file will look better in less if it is encoded in utf8. That being said I think that it is perfectly right to use other locales, and that things should also work in these locales. But since utf8 is the default, it is more likely to be correct for text files that don't carry over the encoding. I would think it is more important to be able to read the ChangeLog missing some characters than not seeing anything. Not a big deal they will go look upstream if they really need this. In this case, with multiple encoding, the best may indeed be to keep it as is. If the history annoys Fedora I will just drop it from the package. It is not the point. The argument for it having to be UTF-8 just doesn't hold, you're picking one encoding while, the problem is that 1/ you can't garantee there is only one encoding in a text file 2/ even if it's the case you have no metadata to indicate what encoding was used for authoring. Blindly assuming this has to be UTF-8 is a wrong and lost battle, even the Unicode consortium would never try to suggest something that radical, Fedora is not bound to the Unicode consortium. Default encoding is utf8 so text files are more likely to be have correct rendering of characters if dile is utf8. and sorry if I were to write a README.cn I would use a BIG5 encoding in it, not UTF-8, because that's not what the concerned people would expect. This could be a good reason not to change the encoding for this file. Get yourself a filesystem with metadata if you really want to solve the problem, forcing upstream into UTF-8 or converting on the fly are both wrong IMHO. Doing it blindly is wrong. But doing it when it makes sense is right. For the NEWS file it's actually generated via XSLT when the package is released xsl:output method=text encoding=ISO-8859-1/ it could be switched to UTF-8 without problem but converting at rpm generation time is just the Wrong Way of doing it. If the text file is ISO-8859-1 encoded for sure, converting it on the fly seems acceptable and even preferrable to me. Still w.r.t. #13 it's not so much that I think I have higher priorities to do, it's that I see things imposed like a dogma, that they look broken to me, and It is not a dogma. There are reasons to prefer utf8 for text files in fedora. Now if you don't like it, you are perfectly right, but you'll have to find another packager who agree with you to review your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449207] New: Review Request: notify-sharp - A C# implementation for Desktop Notifications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=449207 Summary: Review Request: notify-sharp - A C# implementation for Desktop Notifications Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] Spec URL: http://dev.nigelj.com/SRPMS/notify-sharp.spec SRPM URL: http://dev.nigelj.com/SRPMS/notify-sharp-0.4.0-0.1.20080531svn.fc9.src.rpm Description: notify-sharp is a C# client implementation for Desktop Notifications, i.e. notification-daemon. It is inspired by the libnotify API. Desktop Notifications provide a standard way of doing passive pop-up notifications on the Linux desktop. These are designed to notify the user of something without interrupting their work with a dialog box that they must close. Passive popups can automatically disappear after a short period of time. N.B. I know this fails on Rawhide (http://koji.fedoraproject.org/koji/taskinfo?taskID=637862), it's not my fault check out Bug #449205 for why... It does however build on F9 (http://koji.fedoraproject.org/koji/taskinfo?taskID=637866) F8 (http://koji.fedoraproject.org/koji/taskinfo?taskID=637872) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429809] Review Request: mumble - low-latency, high quality voice chat software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mumble - low-latency, high quality voice chat software https://bugzilla.redhat.com/show_bug.cgi?id=429809 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 07:27 EST --- See http://sourceforge.net/tracker/index.php?func=detailaid=1796184group_id=147372atid=768008, also, I do not know if it applies now though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433223] Review Request: gstreamermm - C++ wrapper for GStreamer library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gstreamermm - C++ wrapper for GStreamer library https://bugzilla.redhat.com/show_bug.cgi?id=433223 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 07:37 EST --- New Package CVS Request === Package Name: gstreamermm Short Description: C++ wrapper for GStreamer library Owners: denis Branches: F-8 F-9 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226079] Merge Review: libxml2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libxml2 https://bugzilla.redhat.com/show_bug.cgi?id=226079 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 07:40 EST --- (In reply to comment #14) Okay, I will drop ChangeLog and News from the package, after reading this and the thread it looks apparently more important to the Fedora Packaging guys to follow blindly a This has to be UTF-8 rule than understanding that people may have preferences set in their viewing and editing tools. I'm sorry, my prefered viewing and editing tools (less and joe) don't have any encoding settings, and even if I were to use tools which do, they default to the system locale and system locale's are UTF-8 on Fedora (and many other modern distros). ISO-8859-X is dead, not as dead as it should be but it is dead, this is not a dogma, we want files to show up correctly using the default locale's, thus they should be encoded usings the default locale settings. I'm especially disappointed in you staying to your stance that UTF-8 is wrong, given that I have offered todo the work for you. I would think it is more important to be able to read the ChangeLog missing some characters than not seeing anything. I agree, but it would be even better to see the full changelog including those chars! W.r.t. comment #13 , the ChangeLog is 19000+ lines how would you make sure you actually guessed the encoding of characters in a name correctly ? I'm european and as such know many european names / dialects, atleast enough to have a high chance of guessing correctly, then again in some cases I might guess wrong, but then again to quote you: I would think it is more important to be able to read the ChangeLog missing some characters than not seeing anything. Well my intend is to make the number of missing / wrong characters smaller, preferably 0 but atleast much much smaller, I might get one are two names wrong, bad luck atleast the other names will be correct. IMHO you just can't unless chasing each people name and making sure it matches. That's history, I prefer to keep it that way. If the history annoys Fedora I will just drop it from the package. This is not history, this is just plain wrong, as is the file will not look correct in any encoding. This file is the perfect example of why UTF-8 has become the default and why UTF-8 is a blessing (allowing both special western and east european chars in one file, and even more exotic chars in the same file). The argument for it having to be UTF-8 just doesn't hold, you're picking one encoding while, I'm not picking one encoding, Fedora has picked one encoding, and I believe they have made a good choice the problem is that 1/ you can't garantee there is only one encoding in a text file If there is more then one encoding in a plain text, then the file is broken, we have a name for things like this, we call it a bug and usually we fix those were we can (and have the resources). 2/ even if it's the case you have no metadata to indicate what encoding was used for authoring. Actually, if its in English, but there are some names of people in there which are French and those names are the only one containing non ascii codes, then I can make a pretty good bet. After that I can check if the resulting name is a valid French name. You know I maintain close to 200 packages in Fedora, and as such I've even written a script to locate any non ascii chars in text files for me (used when rpmlint complains about them not being non utf-8. Did you know that in the libxml2 changelog there are only 48 lines which contain non ascii code, after replacing St\?phane Bidoul with Stephane Bidoul (I will fix this to the proper UTF-8 name later) I've only 16 non-ascii containing lines left. Really this is fixable just _fine_, the problem is you being unwilling to accept a fix for it. if I were to write a README.cn I would use a BIG5 encoding in it, not UTF-8, because that's not what the concerned people would expect Ofcourse there will always be exceptions to the rule, but were not talking about Chinese files here, ChangeLog is an English file, with some non English person names in there which use chars beyond ascii . Get yourself a filesystem with metadata if you really want to solve the problem Well thats not going to help with multiple encodings in one file, like you have with ChangeLog now is it, or are we going to put en encoding per line in the metadata, or maybe an encoding per char? Still w.r.t. #13 it's not so much that I think I have higher priorities to do, it's that I see things imposed like a dogma, that they look broken to me, and that I feel that trying to change the minds of people around about this is a lost battle. It's getting a religious thing, and my belief is that changing files coming from upstream is fundamentally wrong. So fixing bugs,
[Bug 444760] Review Request: obm - Open Business Management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: obm - Open Business Management https://bugzilla.redhat.com/show_bug.cgi?id=444760 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 07:44 EST --- yeah, i actually did a better merge of this webapp, will upload it asap. I had some talk with upstream to fix some of this issues directly into the source. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448606] Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD https://bugzilla.redhat.com/show_bug.cgi?id=448606 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 08:01 EST --- subtitleeditor-0.21.1-3.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448606] Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD https://bugzilla.redhat.com/show_bug.cgi?id=448606 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 08:02 EST --- subtitleeditor-0.21.1-3.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448606] Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD https://bugzilla.redhat.com/show_bug.cgi?id=448606 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226079] Merge Review: libxml2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libxml2 https://bugzilla.redhat.com/show_bug.cgi?id=226079 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 08:28 EST --- Created an attachment (id=307276) -- (https://bugzilla.redhat.com/attachment.cgi?id=307276action=view) unified diff between orig Changelog and UTF-8 Changelog Look as this with your browsers encoding (view menu) set to UTF-8 and notice how _everyones_ name is spelled correct in the new version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226079] Merge Review: libxml2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libxml2 https://bugzilla.redhat.com/show_bug.cgi?id=226079 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 08:26 EST --- Created an attachment (id=307275) -- (https://bugzilla.redhat.com/attachment.cgi?id=307275action=view) libxml current svn ChangeLog in UTF-8 Show me the code ... Can we now please get over this and have this _bug_ of a ChangeLog with different parts in different encodings fixed please? The only remaining problem AFAIK is NEWS then, which can be converted on the fly during the rpmbuild just fine, so that it matches Fedora's _default_ encoding. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442280] Review Request: squirrel - high level imperative/OO programming language
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: squirrel - high level imperative/OO programming
language
https://bugzilla.redhat.com/show_bug.cgi?id=442280
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag||fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2008-05-31 09:15 EST ---
Full review done:
SHOULD FIX
--
* Use standard (and actually working, unlike the current) sf.net download url
of:
http://downloads.sourceforge.net/squirrel/squirrel_%{version}.stable.tar.gz
* You currently give README HISTORY and COPYRIGHT the timestamp of the COMPILE
for
for HISTORY this is different from the original timestamp of HISTORY and in
future upstream releases chances are good the timestamps differ even more.
Instead you should make backups while sed-ing using sed -i.orig and then
use the .orig files as source for restoring the timestamps.
No blockers, approved!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446412] Review Request: perl-Event-RPC - Event based transparent Client/Server RPC framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Event-RPC - Event based transparent Client/Server RPC framework https://bugzilla.redhat.com/show_bug.cgi?id=446412 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446410] Review Request: perl-BDB - Asynchronous Berkeley DB access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-BDB - Asynchronous Berkeley DB access https://bugzilla.redhat.com/show_bug.cgi?id=446410 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444755] Review Request: perl-Lingua-EN-Numbers-Ordinate - Perl functions for giving the ordinal form of a number given its cardinal value
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Lingua-EN-Numbers-Ordinate - Perl functions for giving the ordinal form of a number given its cardinal value https://bugzilla.redhat.com/show_bug.cgi?id=444755 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442280] Review Request: squirrel - high level imperative/OO programming language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: squirrel - high level imperative/OO programming language https://bugzilla.redhat.com/show_bug.cgi?id=442280 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 09:50 EST --- Thanks for the review. ad 1 - my mistake - the releases are squirrel_X.Y.stable.tar.gz and squirrel_X.Y.Z_stable.tar.gz (and the spec in fact originated in version 2.1.1) ad 2 - thanks for the hint -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442280] Review Request: squirrel - high level imperative/OO programming language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: squirrel - high level imperative/OO programming language https://bugzilla.redhat.com/show_bug.cgi?id=442280 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 09:52 EST --- New Package CVS Request === Package Name: squirrel Short Description: High level imperative/OO programming language Owners: sharkcz Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448901] Review Request: nled - Simple curses-based text editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nled - Simple curses-based text editor https://bugzilla.redhat.com/show_bug.cgi?id=448901 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445980] Review Request: odpdom - Oversized Document Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: odpdom - Oversized Document Parser https://bugzilla.redhat.com/show_bug.cgi?id=445980 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 12:17 EST --- Well, I decided to scrap the whole idea. This library would be used by only one application which doesn't even work properly with anything newer than EL-4 (some Python incompatibility). Thanks for all your comments and sorry for wasting your time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 444763] Review Request: vaspview - VASP Data Viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vaspview - VASP Data Viewer https://bugzilla.redhat.com/show_bug.cgi?id=444763 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 12:26 EST --- http://rathann.fedorapeople.org/review/vaspview.spec http://rathann.fedorapeople.org/review/vaspview-1.05-2.src.rpm Fixed all issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438804] Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP https://bugzilla.redhat.com/show_bug.cgi?id=438804 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 13:40 EST --- I was planning on sponsoring David, but I'm not getting any results. I've asked David to redo the spec file with additional requirements, but I've not seen anything yet. I suppose we can give it one more week, then just close out these bugs. Dave?? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196531] Review Request: perl-MP3-Info - Manipulate / fetch info from MP3 audio files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-MP3-Info - Manipulate / fetch info from MP3 audio files https://bugzilla.redhat.com/show_bug.cgi?id=196531 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 13:43 EST --- Package Change Request == Package Name: perl-MP3-Info New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438804] Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP https://bugzilla.redhat.com/show_bug.cgi?id=438804 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 14:20 EST --- My only real concern with breaking out into subpackages is the additional dependencies that will be created that aren't currently in Fedora, some of which may never be. For example, the Kerberos, SAP, vpopmail and MDB (not MDB2) containers. The required plugins for these may FOSS, maybe not. In any case, I don't have the time nor personal need to package those pieces adequately for inclusion and if that holds up the package from being included for others, that doesn't seem like a great trade-off. The pieces that can be sub-packaged so as to satisfy their requirements can be handled easily, though those sub-pkgs will only have 1-2 files each but those containers that can't be resolved are the real issue for me. I can simply include them in the main package and it's left as an exercise for the user to fill in the missing pieces as required, or they can be neutered out of the package entirely and require end-users to make their own sub-packages or to pull in the missing files to satisfy their needs. Those two options seem rather silly to me. Whats the preference? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438808] Review Request: php-pear-DB-ldap - A DB compliant interface to LDAP servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-DB-ldap - A DB compliant interface to LDAP servers https://bugzilla.redhat.com/show_bug.cgi?id=438808 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438810] Review Request: php-pear-HTTP-Download - PHP Class for handling file downloads
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-HTTP-Download - PHP Class for handling file downloads https://bugzilla.redhat.com/show_bug.cgi?id=438810 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 436677] Review Request: xxdiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xxdiff https://bugzilla.redhat.com/show_bug.cgi?id=436677 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 14:53 EST --- Do we need to pull them from the original tarball? so that we are not shipping the images as part of the source RPM. Or can we simply exclude them from the binary RPM? note: I have not received a response from the author. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 14:59 EST --- (In reply to comment #1) formal review: Thanks! = only the BR: needs fixing Duh / oops, fixed version here: Spec URL: http://people.atrpms.net/~hdegoede/trophy.spec SRPM URL: http://people.atrpms.net/~hdegoede/trophy-1.1.5-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448871] Review Request: perl-Template-Provider-Encoding - Explicitly declare encodings of your templates
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Template-Provider-Encoding - Explicitly declare encodings of your templates https://bugzilla.redhat.com/show_bug.cgi?id=448871 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 15:03 EST --- Imported and building. Thanks for the review! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] New: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=449234 Summary: Review Request: perl-Catalyst-Plugin-Session-State- Cookie - Maintain session IDs using cookies Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/Catalyst-Plugin-Session- State-Cookie/ OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Session-State-Cookie-0.09-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Session-State-Cookie.spec Description: In order for Catalyst::Plugin::Session to work the session ID needs to be stored on the client, and the session data needs to be stored on the server. This plugin provides a way to store the session ID on the client, through a cookie. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 15:14 EST --- http://koji.fedoraproject.org/koji/taskinfo?taskID=638376 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 15:25 EST --- Upstream released a new version and basically used my path patch, so no patching is needed anymore. Updated spec: http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko.spec New SRPM: http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko-0.9.4.1.3-0.1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448310] Review Request: elice - Elice is a PureBasic to c++ translator / compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: elice - Elice is a PureBasic to c++ translator / compiler https://bugzilla.redhat.com/show_bug.cgi?id=448310 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 15:37 EST --- (In reply to comment #1) - Summary: A partial PureBasic to C++ cross-compiler ? Generation commands should use svn export instead I don't use svn that often, but indeed export is much better in this case - The ruby BR is covered by ruby-racc Only implicit not (through /usr/bin/ruby and ruby(abi) = 1.8) not explicit and the ruby guidelines: http://fedoraproject.org/wiki/Packaging/Ruby say: Ruby packages must require ruby at build time with a BuildRequires: ruby ? C++ case in %description Fixed ? make: bzr: Command not found - not a blocker, but it is ugly (I thought it was pulled from svn...) I know, I guess the elice author uses bzr for its own internal version tracker and then from time to time submits his work to Lost Labyrinths svn. Nothing I can do here really. - I don't like that the lostlaby patches are in here instead of the lostlabyrinth SRPM Oh, those are no longer needed, they have been integrated into Lost Labyrinth 2.9.2 - dropped. . Noted that 2 lostlabyrinth-specific executables are included Yip, as said in the description, this really is only meant for building Lost Labyrinth ??? HOLY CRAP! Is that really all the font data from Vera.ttf included in the script?! Erm, yes it would seem so, I will contact upstream about this asking them to just use a file instead. ? No license reference in many of the source files The licensing for all relevant files (including a file list) is explained in the file titled COPYING (no this is not just a copy of the GPL). ? Tests aren't run in %check Good catch! Fixed. Here is a new version with most issues fixed: Spec URL: http://people.atrpms.net/~hdegoede/elice.spec SRPM URL: http://people.atrpms.net/~hdegoede/elice-0.0-0.2.svn257.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441411] Review Request: adonthell - A 2D graphical RPG game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adonthell - A 2D graphical RPG game https://bugzilla.redhat.com/show_bug.cgi?id=441411 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 15:37 EST --- It's been a long time, but here it is. I worked some time with upstreal dev and we managed to fix some issues in adonthell, as well as some issues in my own spec. The result is the 0.3.5 release (which also includes lots of bugfixes for non Fedora-related issues). I think it should now cover what you remarked above. Here is the spec file: ftp://91.121.156.173/pub/adonthell.spec Here is the SRPM: ftp://91.121.156.173/pub/adonthell-0.3.5-0.1.fc9.src.rpm PS: I now have my own host, so you will not have to click through the ads to find the files ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448250] Review Request: nautilus-sound-converter - nautilus extension to convert audio files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-sound-converter - nautilus extension to
convert audio files
https://bugzilla.redhat.com/show_bug.cgi?id=448250
--- Additional Comments From [EMAIL PROTECTED] 2008-05-31 15:51 EST ---
MUST Items:
xx - rpmlint is unclean on SRPM
+ [EMAIL PROTECTED] SRPMS]$ rpmlint
nautilus-sound-converter-0.5.0-1.fc9.src.rpm
nautilus-sound-converter.src:24: W: unversioned-explicit-obsoletes
nautilus-flac-converter
nautilus-sound-converter.src: W: mixed-use-of-spaces-and-tabs (spaces:
line 1, tab: line 13)
[EMAIL PROTECTED] SRPMS]$
xx - does not follow Naming Guidelines
+ According to
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages
there should be a versioned Obsoletes, which would also take care of one of the
rpmlint warnings.
OK - spec file is named as %{name}.spec
OK - package meets Packaging Guidelines
+ To preserve timestamps you could consider using:
make install INSTALL=%{__install} -p DESTDIR=$RPM_BUILD_ROOT
+ Why not include the AUTHORS, ChangeLog and TODO in %doc?
OK - license meets Licensing Guidelines
OK - License field meets actual license
OK - upstream license file included in %doc
OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources
OK - package builds successfully
OK - ExcludeArch not needed
OK - build dependencies correctly listed
OK - no locales
OK - no shared libraries in any of the dynamic linker's default paths
OK - package is not relocatable
OK - file and directory ownership
OK - no duplicates in %file
OK - file permissions set properly
OK - %clean present
OK - macros used consistently
OK - contains code and permissable content
OK - -doc is not needed
OK - contents of %doc does not affect the runtime
OK - no header files
OK - no static libraries
OK - no pkgconfig files
OK - no library files with sonames
OK - -devel is not needed
OK - libtool archives removed in the spec
OK - %{name}.desktop file not needed
OK - does not own files or directories owned by other packages
OK - buildroot correctly prepped
OK - all file names valid UTF-8
SHOULD Items:
OK - upstream provides license text
xx - no translations for description and summary
OK - package builds in mock successfully
OK - package builds on all supported architectures
OK - package functions as expected
OK - scriptlets are not needed
OK - subpackages are not needed
OK - no pkgconfig files
OK - no file dependencies
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 188542] Review Request: hylafax
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: hylafax
https://bugzilla.redhat.com/show_bug.cgi?id=188542
--- Additional Comments From [EMAIL PROTECTED] 2008-05-31 16:05 EST ---
I can confirm that /usr/lib/debug is making it into
the package, but not on x86_64 where I usually build.
On x86_64 %_libdir is /usr/lib64, so /usr/lib/debug is not matched
by %{_libdir}/* in the %files section.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226115] Merge Review: m4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: m4 https://bugzilla.redhat.com/show_bug.cgi?id=226115 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems https://bugzilla.redhat.com/show_bug.cgi?id=448745 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 16:12 EST --- ext3grep-0.6.0-1.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252946] Review Request: xmms2 - X-platform Music Multiplexing System 2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xmms2 - X-platform Music Multiplexing System 2 https://bugzilla.redhat.com/show_bug.cgi?id=252946 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 16:18 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems https://bugzilla.redhat.com/show_bug.cgi?id=448745 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 16:14 EST --- ext3grep-0.6.0-1.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441411] Review Request: adonthell - A 2D graphical RPG game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adonthell - A 2D graphical RPG game https://bugzilla.redhat.com/show_bug.cgi?id=441411 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 16:16 EST --- Looks good, I've done a full review, here are the results: Must Fix * Currently you do: sed -i 's|^CFLAGS|^#CFLAGS|g' configure.in Make that: sed -i 's|^CFLAGS|^#CFLAGS|g' configure By modifying configure.in instead of configure, you are causing all the autoxxx files to be regenerated and configure being run twice once you've changed the sed, you can also drop the BuildRequires libtool. as that then won't be needed anymore either. * Currently in the description you say: inspired by good old console RPGs from the SNES like Secret of Mana or Chrono Trigger. This contains several references to protected Trademarks, please don't do that instaed just write (for example): inspired by good old console RPGs from the 16 bit console gaming era Should Fix: --- * The following BuildRequires are redundant and thus should be removed: zlib-devel, SDL-devel So all in all the package is almost good to go, what remains is really easy to fix. So the next step is to update your wastesedge candidate package to 0.3.5 (I assume that together with adonthell 0.3.5 there also has been a 0.3.5 wastesedge release) and then I'll review that next. Also it would help if that could happen somewhat faster then the times between steps taken in this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448250] Review Request: nautilus-sound-converter - nautilus extension to convert audio files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nautilus-sound-converter - nautilus extension to convert audio files https://bugzilla.redhat.com/show_bug.cgi?id=448250 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:11 EST --- Spec URL: http://bpepple.fedorapeople.org/rpms/nautilus-sound-converter.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/nautilus-sound-converter-0.5.0-2.fc9.src.rpm Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=638449 * Sat May 24 2008 Brian Pepple [EMAIL PROTECTED] - 0.5.0-2 - Fix obsoletes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445020] Review Request: python-mako - The Mako template system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-mako - The Mako template system https://bugzilla.redhat.com/show_bug.cgi?id=445020 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445028] Review Request: python-pylons - A python web application toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-pylons - A python web application toolkit https://bugzilla.redhat.com/show_bug.cgi?id=445028 Bug 445028 depends on bug 445020, which changed state. Bug 445020 Summary: Review Request: python-mako - The Mako template system https://bugzilla.redhat.com/show_bug.cgi?id=445020 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445021] Review Request: python-routes - A RoR-like routes library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-routes - A RoR-like routes library for python https://bugzilla.redhat.com/show_bug.cgi?id=445021 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445028] Review Request: python-pylons - A python web application toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-pylons - A python web application toolkit https://bugzilla.redhat.com/show_bug.cgi?id=445028 Bug 445028 depends on bug 445021, which changed state. Bug 445021 Summary: Review Request: python-routes - A RoR-like routes library for python https://bugzilla.redhat.com/show_bug.cgi?id=445021 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445024] Review Request: python-webhelpers - Helper routines for writing web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-webhelpers - Helper routines for writing web applications https://bugzilla.redhat.com/show_bug.cgi?id=445024 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445028] Review Request: python-pylons - A python web application toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-pylons - A python web application toolkit https://bugzilla.redhat.com/show_bug.cgi?id=445028 Bug 445028 depends on bug 445024, which changed state. Bug 445024 Summary: Review Request: python-webhelpers - Helper routines for writing web applications https://bugzilla.redhat.com/show_bug.cgi?id=445024 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445020] Review Request: python-mako - The Mako template system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-mako - The Mako template system https://bugzilla.redhat.com/show_bug.cgi?id=445020 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:40 EST --- python-mako-0.1.10-2.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445020] Review Request: python-mako - The Mako template system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-mako - The Mako template system https://bugzilla.redhat.com/show_bug.cgi?id=445020 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:39 EST --- python-mako-0.1.10-2.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445021] Review Request: python-routes - A RoR-like routes library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-routes - A RoR-like routes library for python https://bugzilla.redhat.com/show_bug.cgi?id=445021 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:41 EST --- python-routes-1.8-2.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445021] Review Request: python-routes - A RoR-like routes library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-routes - A RoR-like routes library for python https://bugzilla.redhat.com/show_bug.cgi?id=445021 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:41 EST --- python-routes-1.8-2.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445024] Review Request: python-webhelpers - Helper routines for writing web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-webhelpers - Helper routines for writing web applications https://bugzilla.redhat.com/show_bug.cgi?id=445024 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:44 EST --- python-webhelpers-0.3.4-2.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445024] Review Request: python-webhelpers - Helper routines for writing web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-webhelpers - Helper routines for writing web applications https://bugzilla.redhat.com/show_bug.cgi?id=445024 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:44 EST --- python-webhelpers-0.3.4-2.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441411] Review Request: adonthell - A 2D graphical RPG game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adonthell - A 2D graphical RPG game https://bugzilla.redhat.com/show_bug.cgi?id=441411 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:41 EST --- By modifying configure.in instead of configure, you are causing all the autoxxx files to be regenerated and configure being run twice Wow! It's been bugging me a lot and I couldn't understand why it was running twice. Anyway, fixed the 3 issues. SPEC: ftp://91.121.156.173/pub/adonthell.spec SRPM: ftp://91.121.156.173/pub/adonthell-0.3.5-0.2.fc9.src.rpm About wastesedge, it was not yet released in 0.3.5 but it doesn't matter as it remains fully compatible (only minor version changing). Translations are being worked on for Waste's Edge, and upstream wants to wait for those before releasing it. I am currently applying all the comments you made here to wastesedge.rpm, so you might want to wait a little before reviewing it so I can upload new versions of SPEC and SRPM ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441411] Review Request: adonthell - A 2D graphical RPG game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adonthell - A 2D graphical RPG game https://bugzilla.redhat.com/show_bug.cgi?id=441411 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 17:49 EST --- (In reply to comment #15) By modifying configure.in instead of configure, you are causing all the autoxxx files to be regenerated and configure being run twice Wow! It's been bugging me a lot and I couldn't understand why it was running twice. Anyway, fixed the 3 issues. SPEC: ftp://91.121.156.173/pub/adonthell.spec SRPM: ftp://91.121.156.173/pub/adonthell-0.3.5-0.2.fc9.src.rpm Looks fine now! About wastesedge, it was not yet released in 0.3.5 but it doesn't matter as it remains fully compatible (only minor version changing). Translations are being worked on for Waste's Edge, and upstream wants to wait for those before releasing it. Ok. I am currently applying all the comments you made here to wastesedge.rpm, so you might want to wait a little before reviewing it so I can upload new versions of SPEC and SRPM ;) Ok, let me know when you've got a version of wastesedge ready for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196531] Review Request: perl-MP3-Info - Manipulate / fetch info from MP3 audio files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-MP3-Info - Manipulate / fetch info from MP3 audio files https://bugzilla.redhat.com/show_bug.cgi?id=196531 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 19:07 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438804] Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP https://bugzilla.redhat.com/show_bug.cgi?id=438804 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 19:09 EST --- Dave I think you have not been following the discussion very closely. Nobody is asking you to package Kerberos, SAP, etc. Ofcouse this would be *impossible*. What we *do* need to do is add requirements for those packages which *are* in Fedora. Also, please note that we do not want separate packages for each requirement, please re-read comment #7 more carefully. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433925] Review Request: libyahoo2 - Library for the Yahoo! Messenger Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libyahoo2 - Library for the Yahoo! Messenger Protocol https://bugzilla.redhat.com/show_bug.cgi?id=433925 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 19:16 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442280] Review Request: squirrel - high level imperative/OO programming language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: squirrel - high level imperative/OO programming language https://bugzilla.redhat.com/show_bug.cgi?id=442280 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 19:18 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448901] Review Request: nled - Simple curses-based text editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nled - Simple curses-based text editor https://bugzilla.redhat.com/show_bug.cgi?id=448901 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 19:20 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433223] Review Request: gstreamermm - C++ wrapper for GStreamer library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gstreamermm - C++ wrapper for GStreamer library https://bugzilla.redhat.com/show_bug.cgi?id=433223 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 19:22 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449251] New: Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin for the Catalyst authentication framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=449251 Summary: Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin for the Catalyst authentication framework Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/Catalyst-Plugin- Authentication/ OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: fedora-package-review@redhat.com,[EMAIL PROTECTED] SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication-0.10006-1.fc9.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication.spec Description: The authentication plugin provides generic user support for Catalyst apps. It is the basis for both authentication (checking the user is who they claim to be), and authorization (allowing the user to do what the system authorises them to do). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441415] Review Request: wastesedge - Official game package for Adonthell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wastesedge - Official game package for Adonthell https://bugzilla.redhat.com/show_bug.cgi?id=441415 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 20:01 EST --- I reworked it a little, trying to take into accounts remarks that were made to me in adonthell review. SPEC: ftp://91.121.156.173/pub/wastesedge.spec SRPM: ftp://91.121.156.173/pub/wastesedge-0.3.4-0.5.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||449251 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441415] Review Request: wastesedge - Official game package for Adonthell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wastesedge - Official game package for Adonthell https://bugzilla.redhat.com/show_bug.cgi?id=441415 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 21:03 EST --- My bad, I uploaded the old SRPM. Here is the good one: SRPM: ftp://91.121.156.173/pub/wastesedge-0.3.4-0.6.fc9.src.rpm Spec file was right though, but it's always better to have the two of them in the same comment: SPEC: ftp://91.121.156.173/pub/wastesedge.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449251] Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin for the Catalyst authentication framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin for the Catalyst authentication framework https://bugzilla.redhat.com/show_bug.cgi?id=449251 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448949] Review Request: guidance-power-manager - KDE Power Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: guidance-power-manager - KDE Power Manager https://bugzilla.redhat.com/show_bug.cgi?id=448949 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 22:48 EST --- (In reply to comment #3) targetted for F9+ (requires kdebindings version 4) I'll keep this in mind First glance looks good :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447567] Review Request: msort - Sort files in sophisticated ways
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: msort - Sort files in sophisticated ways https://bugzilla.redhat.com/show_bug.cgi?id=447567 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 22:54 EST --- Review: + package builds in mock (rawhide i386). koji build =http://koji.fedoraproject.org/koji/taskinfo?taskID=638847 + rpmlint is silent for SRPM andfor RPM. + source files match upstream url aa84730eae0691341919db244f821c68 msort-8.46.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + No desktop file installed. + GUI interface is available. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448949] Review Request: guidance-power-manager - KDE Power Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: guidance-power-manager - KDE Power Manager https://bugzilla.redhat.com/show_bug.cgi?id=448949 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 23:31 EST --- Y/N/- MUST: Y: rpmlint on each package --- guidance-power-manager.x86_64: W: no-documentation guidance-power-manager.x86_64: E: non-executable-script /usr/share/kde4/apps/guidance-power-manager/powermanage.py 0644 guidance-power-manager.x86_64: W: symlink-should-be-relative /usr/bin/guidance-power-manager /usr/share/kde4/apps/guidance-power-manager/guidance-power-manager.py guidance-power-manager.x86_64: E: non-executable-script /usr/lib64/python2.5/site-packages/xf86misc.py 0644 guidance-power-manager.x86_64: W: incoherent-version-in-changelog 0.0-0.1.20080529svn 0.1-0.1.20080529svn.fc9 guidance-power-manager-debuginfo.x86_64: W: filename-too-long-for-joliet guidance-power-manager-debuginfo-0.1-0.1.20080529svn.fc9.x86_64.rpm --- Y: Meets Package Naming Guidelines Y: Spec file name matches base package name Y: License field is valid Y: Meets Packaging Guidelines -: License included in package (if included in source) Y: Spec file written in en_US Y: Spec file is legible -: Sources match upstream source Y: Source URL 'sane' Y: Compiles successfully - [F9 - x86_64, Rawhide(koji) - *] -: ExcludeArch required? Y: All Build Dependencies Listed -: Handles locales sanely -: Library packages run ldconfig Y: Package is not relocatable Y: Package owns all directories created Y: No duplicate file listings Y: defattr set correctly Y: %clean is used Y: Macro use conisistant Y: Contains Code/Content that is allowed -: Large Documentation in -doc subpackage Y: %doc must not affect package runtime -: Header files in -devel -: Static libraries in -static -: pkgconfig files require pkgconfig -: Library files are located in correct package -: -devel requires base package w/ fully versioned dependency Y: Packages do not contain .la (libtool) archives -: GUI Apps have .desktop files Y: No duplicate directory ownerships Y: %install cleans buildroot Y: Filenames are valid UTF-8 SHOULD: -: Description/Summary sections contain translations Y: Builds in mock/koji Y: Builds on all architectures -: Scriptlets are sane -: Subpackages require base package -: pkgconfig.pc files in -devel -: File dependencies should only be in /etc /bin /sbin /usr/bin /usr/sbin Looking at the rpmlint errors: README should at the very least be included in %doc, you should ask upstream to include a copy of GPLv2 as well. Version in ChangeLog should be 0.2-0.1.20080529svn debuginfo pkg name is very long, should be safe to ignore, I don't think many make CDs of debuginfo packages :) I'm stamping this with the big green APPROVED stamp on the basis that %doc gets sorted out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 00:00 EST --- New Package CVS Request === Package Name: perl-Catalyst-Plugin-Session-State-Cookie Short Description: Maintain session IDs using cookies Owners: cweyl Branches: F-7, F-8, F-9, devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain
session IDs using cookies
https://bugzilla.redhat.com/show_bug.cgi?id=449234
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2008-05-31 22:39 EST ---
Review:
+ package builds in mock (rawhide i386).
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=638376
+ rpmlint is silent for SRPM but NOT for RPM.
perl-Catalyst-Plugin-Session-State-Cookie.src:38: W: rpm-buildroot-usage %prep
FOO=`perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.
== I think this will not be a problem.
+ source files match upstream url
0eb184e081051ca284c2952ba6db59f7
Catalyst-Plugin-Session-State-Cookie-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=5, Tests=32, 3 wallclock secs ( 1.16 cusr + 0.21 csys = 1.37 CPU)
+ Package perl-Catalyst-Plugin-Session-State-Cookie-0.09-1.fc10 =
Provides: perl(Catalyst::Plugin::Session::State::Cookie) = 0.09
Requires: perl(:MODULE_COMPAT_5.10.0) perl(Catalyst::Plugin::Session) = 0.19
perl(Catalyst::Utils) perl(NEXT) perl(base) perl(strict) perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441098] Review Request: python-dictclient - Python client for DICT protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-dictclient - Python client for DICT protocol https://bugzilla.redhat.com/show_bug.cgi?id=441098 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 00:24 EST --- (In reply to comment #4) Package Name: dictclient Package Change Request == Package Name: dictclient Argh, I'm really sorry, that should have been python-dictclient, not dictclient. I haven't committed/built anything yet, so hopefully, it can be renamed. Sorry for the trouble. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448901] Review Request: nled - Simple curses-based text editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nled - Simple curses-based text editor https://bugzilla.redhat.com/show_bug.cgi?id=448901 --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 00:11 EST --- nled-2.52-3.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448949] Review Request: guidance-power-manager - KDE Power Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: guidance-power-manager - KDE Power Manager https://bugzilla.redhat.com/show_bug.cgi?id=448949 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 01:45 EST --- thanks! Yeah, the doc situation is due to this really being pre-release software atm, but I'll make sure to include README (duh, can't believe I missed that). New Package CVS Request === Package Name: guidance-power-manager Short Description: KDE Power Manager Owners: rdieter Branches: F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
