[Bug 225855] Merge Review: gphoto2

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gphoto2


https://bugzilla.redhat.com/show_bug.cgi?id=225855


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|MODIFIED
   Flag|needinfo?([EMAIL PROTECTED]) |




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 03:35 EST ---
Sorry, I was in Africa for 3 weeks with no  internet access.

I applied all your points except:
+ Why not include contrib/simple-mtpupload in %doc?
reason:
It contains perl script that could pull in a perl dependency, which shouldn't be
otherwise needed. The questin is whether /usr/share/doc is a good place for
scripts anyway.

IIRC the s390(x) excluding is because it simply doesn't have USB support.

Thanks for review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445153] Review Request: libacpi - General purpose library for ACPI

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libacpi - General purpose library for ACPI


https://bugzilla.redhat.com/show_bug.cgi?id=445153





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 04:53 EST ---
New SRPM: http://sven.lank.es/Fedora/SRPM/libacpi-0.2-11.fc10.src.rpm
SPEC: http://sven.lank.es/Fedora/SPECS/libacpi.spec

I changed 'just run' to 'only run' and redid the patch to apply without fuzz.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435231] Review Request: xlog - Logging program for Ham Radio Operators

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xlog - Logging program for Ham Radio Operators


https://bugzilla.redhat.com/show_bug.cgi?id=435231


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 05:35 EST ---
Very well, package approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpsk31 - GTK+ graphical version of lpsk31


https://bugzilla.redhat.com/show_bug.cgi?id=435227


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 05:33 EST ---
The source tarball is a 404, again, and it seems upstream has a new version 1.2
that builds with the same spec and patches

RPM Lint: OK, silent
Package name: OK
Spec file: OK
License: OK, GPLv2+
Actual License: OK, no license file but code says GPLv2+
%doc License: No, license is in the code
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: Upstream tarball disappears when new version
is released. Newer version 1.2 builds with the same spec and the same patches,
so no problem. Might wanna contact upstream to make them have the tarballs
around a little longer though.

Compile and Build:
- F-7: OK
- F-8: OK
- rawhide: OK
- EL-5: OK

Applicable Package Guidelines:

Locales: N/A
Shared libs: N/A

Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

package approved in principle, but you might want to bump the version and
contact upstream about the disappearing tarballs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457030] Review Request: rubygem-attributes - Attributes for Ruby (GEM)

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rubygem-attributes - Attributes for Ruby (GEM)


https://bugzilla.redhat.com/show_bug.cgi?id=457030


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 05:38 EST ---
New Package CVS Request
===
Package Name: rubygem-attributes
Short Description: Attributes for Ruby (Gem)
Owners: kanarip
Branches: EL-5, F-8, F-9, devel
InitialCC: kanarip
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445152] Review Request: yacpi - ncurses based acpi viewer

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yacpi - ncurses based acpi viewer


https://bugzilla.redhat.com/show_bug.cgi?id=445152





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 05:48 EST ---
forgot the new URLs:

Spec URL: http://sven.lank.es/Fedora/SPECS/yacpi.spec
SRPM URL: http://sven.lank.es/Fedora/SRPM/yacpi-3.0.1-10.fc10.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 445152] Review Request: yacpi - ncurses based acpi viewer

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yacpi - ncurses based acpi viewer


https://bugzilla.redhat.com/show_bug.cgi?id=445152





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 05:47 EST ---
 Due to the stricter checking implemented now in rpm, you'll have to replace
 %patch -p1 with %patch0 -p1, otherwise the patch is not applied.

fixed

- Neither rpm_opt_flags 

Wow - good catch. Fixed. I've also notified upstream.

- nor parallel build flags are taken into consideration

Fixed

- the created debuginfo rpm is empty

... because the makefile was stripping the binary. Fixed.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435231] Review Request: xlog - Logging program for Ham Radio Operators

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xlog - Logging program for Ham Radio Operators


https://bugzilla.redhat.com/show_bug.cgi?id=435231


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 05:47 EST ---
New Package CVS Request
===
Package Name: xlog
Short Description: Logging program for Hamradio Operators
Owners: lucilanga,bjensen
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpsk31 - GTK+ graphical version of lpsk31


https://bugzilla.redhat.com/show_bug.cgi?id=435227





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 06:01 EST ---
 The source tarball is a 404, again, and it seems upstream has a new version 
 1.2
 that builds with the same spec and patches

Verified building with 1.2, I will initial import the newer version and contact
upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpsk31 - GTK+ graphical version of lpsk31


https://bugzilla.redhat.com/show_bug.cgi?id=435227


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 06:02 EST ---
New Package CVS Request
===
Package Name: xpsk31
Short Description: GTK+ graphical version of lpsk31 for Ham Radio
Owners: lucilanga,bjensen
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457492] Review Request: procbench - Multiplatform information tool and CPU benchmark for x86 procs

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: procbench - Multiplatform information tool and CPU 
benchmark for x86 procs


https://bugzilla.redhat.com/show_bug.cgi?id=457492


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 06:19 EST ---
Package looks fine now.

= APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225855] Merge Review: gphoto2

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gphoto2


https://bugzilla.redhat.com/show_bug.cgi?id=225855





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 06:18 EST ---
Just chmod -x simple-mtpupload  and rpm will no longer pull perl as dependency

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455165] Review-Request: maatkit - Essential command-line utilities for MySQL

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review-Request: maatkit - Essential command-line utilities for MySQL


https://bugzilla.redhat.com/show_bug.cgi?id=455165


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
Summary|Review-Request: maatkit -   |Review-Request: maatkit -
   |Essential command-line  |Essential command-line
   |utilities for MySQL |utilities for MySQL
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 06:22 EST ---
rpmlint doesn't like the license GPLv2 or Artistic. As this seems to be a 
missing license in rpmlint / the Fedora license page I have opened bz #457486 
against rpmlint.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpsk31 - GTK+ graphical version of lpsk31


https://bugzilla.redhat.com/show_bug.cgi?id=435227





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 06:29 EST ---
New Package CVS Request
===
Package Name: xpsk31
Short Description: GTK+ graphical version of lpsk31 for Ham Radio
Owners: lucilanga,bjensen
Branches: F-8 F-9 EL-5
InitialCC: 
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457035] Review Request: libproxy - A library handling all the details of proxy configuration

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libproxy - A library handling all the details of proxy 
configuration


https://bugzilla.redhat.com/show_bug.cgi?id=457035





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 06:41 EST ---
Requires: gecko-libs = 1.9 for f9+ 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457035] Review Request: libproxy - A library handling all the details of proxy configuration

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libproxy - A library handling all the details of proxy 
configuration


https://bugzilla.redhat.com/show_bug.cgi?id=457035


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 06:39 EST ---
Review
=

[+] source files match upstream:
2b2b00a179740548035a1145bbae600db9b0a2ce
[-] package meets naming and versioning guidelines:
please use libproxy-python instead of libproxy-binding-python
[+] specfile is properly named, is cleanly written and uses macros 
consistently.
[+] dist tag is present.
[+] build root is correct.
[+] license field matches the actual license.
[+] license is open source-compatible.

[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[-] Requires are proper:
xulrunner does not use soname's so please add 
Requires: gecko-libs = 1.9 to the plugin-mozjs
package.
[+] compiler flags are appropriate.
[+] %clean is present.
[+] package builds in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=745038
[+] package installs properly.
[+] debuginfo package looks complete.
[+] rpmlint is silent:
It isn't:
---
libproxy-binding-python.x86_64: W: no-documentation
libproxy-devel.x86_64: W: no-documentation
libproxy-plugin-gnome.x86_64: W: no-documentation
libproxy-plugin-kde.x86_64: W: no-documentation
libproxy-plugin-mozjs.x86_64: W: no-documentation
libproxy-plugin-networkmanager.x86_64: W: no-documentation
8 packages and 0 specfiles checked; 0 errors, 6 warnings.

But this warnings can be ignored.

[+] ldconfig is used in %post and %postun
[+] owns the directories it creates.
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] code, not content.
[+] documentation is small, so no -docs subpackage is necessary.
[+] %docs are not necessary for the proper functioning of the package.

===

Summary  Comments:

1) Please use libproxy-python instead of libproxy-binding-python
1.1) Any reason why the java and C# bindings aren't packaged?
2) Fix the gecko-libs requires
3) Consider submitting the patch to upstream (if not done already).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454967] Review Request: darkgarden-fonts - Dark Garden is a decorative outline font of unusual shape.

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: darkgarden-fonts - Dark Garden is a decorative outline 
font of unusual shape.


https://bugzilla.redhat.com/show_bug.cgi?id=454967





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 07:23 EST ---
darkgarden-fonts-1.1-1.fc8 has been submitted as an update for Fedora 8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454967] Review Request: darkgarden-fonts - Dark Garden is a decorative outline font of unusual shape.

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: darkgarden-fonts - Dark Garden is a decorative outline 
font of unusual shape.


https://bugzilla.redhat.com/show_bug.cgi?id=454967





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 07:24 EST ---
darkgarden-fonts-1.1-1.fc9 has been submitted as an update for Fedora 9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454128] Review Request: thibault-fonts - Collection of fonts from thibault.org

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: thibault-fonts - Collection of fonts from thibault.org


https://bugzilla.redhat.com/show_bug.cgi?id=454128





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 07:27 EST ---
thibault-fonts-0.1-1.fc8 has been submitted as an update for Fedora 8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454128] Review Request: thibault-fonts - Collection of fonts from thibault.org

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: thibault-fonts - Collection of fonts from thibault.org


https://bugzilla.redhat.com/show_bug.cgi?id=454128





--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 07:28 EST ---
thibault-fonts-0.1-1.fc9 has been submitted as an update for Fedora 9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: root - The CERN analyzer for high to medium energy 
physics


https://bugzilla.redhat.com/show_bug.cgi?id=451744


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-08-02 07:42 EST ---
Juan  Patrice,

thanks for picking this up! It already looks quite good (submission and review).

Wrt the name: don't change it please, the HEP community is very familiar with
the root name.

Patrice, if we identify the non-free dependencies, maybe we can contact
upstreams and make them adapt their licensing like it happened for ARPACK. It's
is very slow (so this review should not wait for them), but it seems to work.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457212] Review Request: gadmin-squid - graphical configuration tool for squid

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


http://bugzilla.redhat.com/show_bug.cgi?id=457212





--- Comment #3 from S.A. Hartsuiker [EMAIL PROTECTED]  2008-08-02 19:53:36 
EDT ---
I updated the spec file to reflect the issues raised by Kevin:

SPEC: http://www.kanarip.com/custom/SPECS/gadmin-squid.spec
SRPM:
http://www.kanarip.com/custom/el5/SRPMS/gadmin-squid-0.1.0-0.3.el5.src.rpm

point 1: I don't know if the URL I updated to is a good one, but it is better
than the previously used one, I'm sure.
point 2: although the license included is GPLv3, the src/* indicates indeed
GPLv3+, so changed in the spec.
point 3: files added
point 4: although no problem, changed anyway :)
point 5: missed that one, upstream does it that way, changed in a patch and
will contact upstream about it.

-- 
Configure bugmail: http://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457492] Review Request: procbench - Multiplatform information tool and CPU benchmark for x86 procs

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457492





--- Comment #6 from Kairo Francisco de Araujo [EMAIL PROTECTED]  2008-08-02 
20:02:58 EDT ---
New Package CVS Request
===
Package Name: procbench 
Short Description: Multiplatform information tool and CPU benchmark for x86
procs
Owners: kairo
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226276] Merge Review: perl

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226276


Tom spot Callaway [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
Customer Facing|NO  |---
 Resolution||RAWHIDE




--- Comment #38 from Tom spot Callaway [EMAIL PROTECTED]  2008-08-02 
21:35:21 EDT ---
This one has been done for some time now. Setting the review flag to + and
closing this bug out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456398] Review Request: why - Why software verification platform

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456398





--- Comment #13 from David A. Wheeler [EMAIL PROTECTED]  2008-08-02 22:18:12 
EDT ---
Excellent!

I checked and confirmed that you've fixed the blocker (not including the
license file).  rpmlint is now 100% silent (which is good; that means the
buffer overflow protection, etc., will now work properly).

I started up the graphical gwhy and confirmed that (1) you can now navigate
the filesystem using the GUI, and that (2) you can work with files not in the
current directory.  Looks good.  I did a try with binary_search.c, and
confirmed that it now works with Zenon (which already has a Fedora package). 
Zenon doesn't do a _great_ job, but it does prove some verification conditions.
 Reducing the number of default columns is a big help; new users will be
overwhelmed enough.

I think it's ready for release. Congrats!

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457212] Review Request: gadmin-squid - graphical configuration tool for squid

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457212





--- Comment #4 from Kevin Fenzi [EMAIL PROTECTED]  2008-08-02 23:59:49 EDT ---
Humm... all the issues I saw appear to be solved, but you made an additional
change I am unclear on:

Why add:

BuildRequires: autoconf
BuildRequires: automake

and change the configure line to use
%GNUconfigure

?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435231] Review Request: xlog - Logging program for Ham Radio Operators

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435231


Kevin Fenzi [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #5 from Kevin Fenzi [EMAIL PROTECTED]  2008-08-03 00:05:30 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435227


Kevin Fenzi [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #14 from Kevin Fenzi [EMAIL PROTECTED]  2008-08-03 00:07:07 EDT 
---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457492] Review Request: procbench - Multiplatform information tool and CPU benchmark for x86 procs

2008-08-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457492


Kevin Fenzi [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #7 from Kevin Fenzi [EMAIL PROTECTED]  2008-08-03 00:08:50 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review