[Bug 455555] Review Request: libhocr - A Hebrew optical character recognition library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=45
--- Comment #6 from Oron Peled [EMAIL PROTECTED] 2008-08-03 06:08:23 EDT ---
(In reply to comment #5)
Well, for 0.10.13-1:
First, thanks for the excellent and detailed comments.
Since I'm working with upstream about some other small
issues, I'm merging the fixes and hope to upload an updated
package within a day or two.
A short checklist:
* Explicit library dependency
---
On main package:
Requires: fftw, hspell
fftw - removed (yes it should be delegated to RPM)
hspell - move to hocr-gtk subpackage. This package
uses gtktextbuffer (python bindings) which uses
gtkspell which test at *runtime* for backend spellcheckers.
Added a comment about that in the .spec file
On -gtk subpackage:
Requires: gtk2
fixed.
** Requires
* Requires for -devel subpackage
* Every package which ships pkgconfig .pc files must have
Requires: pkgconfig
Fixed. I didn't check .pc files at all. Looks like I should write
a small script to test these things (supplement rpmlint...)
* Also please pkgconfig files themselfs to check dependencies for
-devel subpackage
A. %_libdir/pkgconfig/libhocr-gtk.pc contains:
---
Requires: gtk+-2.0
Fixed.
---
This means that libhocr-devel subpackage must have Requires:
gtk2-devel
B. %_libdir/pkgconfig/libhocr.pc contains:
---
Libs: -lhocr -lhspell -lz -ltiff -lm
---
This means that libhocr-devel must have
Requires: hspell-devel zlib-devel libtiff-devel (because of
-lhspell -lz -ltiff)
However all these 3 linkage seem unneeded, because none of the
header files in libhocr-devel needs header files from
fftw-devel, hspell-devel, libtiff-devel.
I guess @ld_hspell@ @ld_tiff@ in libhocr.pc.in should be removed.
Their inclusion in the .pc file is correct since they are used
by the applications, either explicitly (tiffio.h and fftw3.h) or
implicitly (hspell via gtkspell). However, I'll have to digg deeper
to make sure *which* subpackage requires *what* (TODO)
* Requires for -gtk subpackage
* Please recheck the dependency for -gtk subpackage.
For example, /usr/bin/hocr-gtk contains
28 import pygtk
29 pygtk.require('2.0')
This means that libhocr-gtk must have Requires: pygtk2.
Fixed.
* Timestamps
- To keep timestamps on installed files, please consider to use
make install \
INSTALL=install -p \
DESTDIR=%{buildroot}\
.
-
This method usually works for based Makefiles based on recent
autotools
Hmmm... first time I see this consideration. It seems logical
but are these any guideline about it?
If it's a general problem maybe I can use your method as a solution
for this package, but it seems better to fix the AC_PROG_INSTALL
macro upstream (if they accept the same logic).
* Desktop files
- Category X-Fedora is deprecated and should be removed.
Done. I must have got its addition from some obsolete guide
somewhere but I cannot find any reference to it now, nevermind.
* %doc %_mandir
- Files under %_mandir are automatically marked under %doc
Removed the %doc.
* Directory ownership issue
- Please make it sure that all directories created when installing a
rpm are correctly created by the rpm
For example, %_datadir/hocr-gtk is not owned by any packages.
Fixed. Will recheck other ownerships as well.
* %files entry on -python subpackage
- On i386/ppc %{python_sitelib} and %{python_sitearch} are the same,
so on these archs %files entries are duplicate as:
-
1131 warning: File listed twice: /usr/lib/python2.5/site-packages/_hocr.so
1132 warning: File listed twice: /usr/lib/python2.5/site-packages/hocr.py
1133 warning: File listed twice: /usr/lib/python2.5/site-packages/hocr.pyc
1134 warning: File listed twice: /usr/lib/python2.5/site-packages/hocr.pyo
-
Writing %files entry a bit more verbosely can resolve this issue.
TODO. I need to check it again.
* 64 bits issue
- libhocr{-gtk}.pc.in contains:
-
[Bug 457213] Review Request: html2text - HTML-to-text converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457213 Rahul Sundaram [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457213] Review Request: html2text - HTML-to-text converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457213 --- Comment #30 from Rahul Sundaram [EMAIL PROTECTED] 2008-08-03 07:14:41 EDT --- Approved. You will still need a sponsor before you can request cvs access and commit anything however. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457213] Review Request: html2text - HTML-to-text converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457213 Jason Tibbitts [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #31 from Jason Tibbitts [EMAIL PROTECTED] 2008-08-03 07:28:40 EDT --- You shouldn't be approving NEEDSPONSOR tickets if you're not a sponsor. Approval of the review ticket should include an offer to sponsor the person: https://fedoraproject.org/wiki/Package_Review_Process (You can, of course, do as much pre-review work as you like on such tickets.) Alternately, you could consider requesting that you be made a sponsor: https://fedoraproject.org/wiki/PackageMaintainers/SponsorProcess -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457212] Review Request: gadmin-squid - graphical configuration tool for squid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457212 --- Comment #5 from S.A. Hartsuiker [EMAIL PROTECTED] 2008-08-03 07:54:44 EDT --- Kevin, the BuildRequires and %GNUconfigure were neccesary to have it build for epel-5. The source tarball contains an Makefile.in that borks the build for epel-5. Including above statements ensures that Makefile.in is regenerated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456303] Review Request: bcrypt - File encryption utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456303 --- Comment #5 from Rahul Sundaram [EMAIL PROTECTED] 2008-08-03 08:05:13 EDT --- New Package CVS Request === Package Name: bcrypt Short Description: File encryption utility Owners: sundaram Branches: F-8 F-9 EL-4 EL-5 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452842] Review Request: monotorrent - a bit torrent client for mono
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452842 --- Comment #8 from David Nielsen [EMAIL PROTECTED] 2008-08-03 08:39:29 EDT --- Paul do you plan to ever build this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454166] Review Request: griv - a gtk rivchat
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454166 --- Comment #23 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 08:57:18 EDT --- Please close this bug as NEXTRELEASE when you rebuilt this package on devel/F-9/F-8 and request on bodhi is done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454208] Review Request: florence - Florence is an extensible scalable on-screen virtual keyboard for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454208 --- Comment #24 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 08:56:02 EDT --- Please close this bug as NEXTRELEASE when you rebuilt this package on devel/F-9/F-8 and request on bodhi is done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454166] Review Request: griv - a gtk rivchat
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454166 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #24 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 09:13:23 EDT --- Closing as rebuild is done and request on bodhi is done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454208] Review Request: florence - Florence is an extensible scalable on-screen virtual keyboard for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454208 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #25 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 09:13:56 EDT --- Closing as rebuild and request on bodhi is done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454220] Review Request: germanium - a download manager for eMusic.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454220 --- Comment #20 from Adam Huffman [EMAIL PROTECTED] 2008-08-03 10:54:49 EDT --- Matt, Before I make a package for 0.2.2, I should point out that the emusic format seems to have changed. The file extension is now .emx, which is an XML format, replacing the previous encrypted one. Some details are here: http://code.google.com/p/emusicremote/wiki/EMX_File_Format -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456398] Review Request: why - Why software verification platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456398 --- Comment #14 from Alan Dunn [EMAIL PROTECTED] 2008-08-03 10:58:36 EDT --- New Package CVS Request === Package Name: why Short Description: Why software verification platform Owners: amdunn Branches: F-8 F-9 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435227 --- Comment #15 from Fedora Update System [EMAIL PROTECTED] 2008-08-03 11:03:02 EDT --- xpsk31-1.2-1.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435227 Lucian Langa [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435227 --- Comment #16 from Fedora Update System [EMAIL PROTECTED] 2008-08-03 11:09:39 EDT --- xpsk31-1.2-1.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445224] Review Request: stapitrace - user space instruction trace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445224 --- Comment #17 from Dave Nomura [EMAIL PROTECTED] 2008-08-03 11:24:39 EDT --- Created an attachment (id=313294) -- (https://bugzilla.redhat.com/attachment.cgi?id=313294) updates for Roland McGraths upgrade to utrace Roland McGrath is upgrading utrace in Fedora10. The attached tar file contains a src rpm, spec file, and patch file to upgrade Dpiperf/src/stap/usr_itrace.stp This is based on a preliminary version of Roland's changes and has only had limited testing due to the need for uprobes (which also must be adapted for the new utrace) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 429486] Review Request: screenlets - A widget system for Compiz-fusion and Beryl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=429486 leigh scott [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] ||m --- Comment #30 from leigh scott [EMAIL PROTECTED] 2008-08-03 11:26:14 EDT --- Are you still stuck ? ( does this help? ) http://www.linux-ati-drivers.homecall.co.uk/screenlets.spec http://www.linux-ati-drivers.homecall.co.uk/screenlets-0.1.2-5.fc9.src.rpm If you have given up perhaps someone could review my attempt ! rpm doesn't seem to find the library dependencies by itself!! rpmlint output screenlets.noarch: I: checking screenlets.noarch: E: explicit-lib-dependency libnotify You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445224] Review Request: stapitrace - user space instruction trace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445224 Josh Boyer [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #18 from Josh Boyer [EMAIL PROTECTED] 2008-08-03 11:33:50 EDT --- (In reply to comment #17) Created an attachment (id=313294) -- (https://bugzilla.redhat.com/attachment.cgi?id=313294) [details] updates for Roland McGraths upgrade to utrace Roland McGrath is upgrading utrace in Fedora10. The attached tar file contains a src rpm, spec file, and patch file to upgrade Dpiperf/src/stap/usr_itrace.stp This is based on a preliminary version of Roland's changes and has only had limited testing due to the need for uprobes (which also must be adapted for the new utrace) Just handle this in CVS at your leisure, or open a different bug for it. The review is done and this bug should be closed out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450409] Review Request: rcssserver3d - Robocup Soccer Simulation Server 3D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450409 --- Comment #29 from Hedayat Vatankhah [EMAIL PROTECTED] 2008-08-03 11:39:30 EDT --- New Package CVS Request === Package Name: rcssserver3d Short Description: Robocup Soccer Simulation Server 3D Owners: hedayat Branches: F-8 F-9 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453465] Review Request: transbot - An irc bot designed to translate between languages on separate channels
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453465 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #6 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 12:03:44 EDT --- For 1.0-3: * License - (As you seem to be the upstream developer) unless you mention in the tarball that this package is licensed under GPLv2+, we regard the license of this package to be GPL+ (from section 9) * Source - The tarball which can be downloaded from the URL differs from the one in the tarball. When you modify the tarball itself, please change the version number and upload the new one. * %defattr - We now recommend %defattr(-,root,root,-) * General rpmlint issue -- transbot.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/trans/transbot.py 0644 transbot.noarch: E: standard-dir-owned-by-package /usr/share/man/man1 -- - If the permission of transbot.py is correct (as 0644), then this script should not have shebang. - This package must not own /usr/share/man/man1 (owned by filesystem) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435231] Review Request: xlog - Logging program for Ham Radio Operators
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435231 --- Comment #6 from Fedora Update System [EMAIL PROTECTED] 2008-08-03 12:14:08 EDT --- xlog-1.7-2.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435231] Review Request: xlog - Logging program for Ham Radio Operators
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435231 --- Comment #7 from Fedora Update System [EMAIL PROTECTED] 2008-08-03 12:14:32 EDT --- xlog-1.7-2.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435231] Review Request: xlog - Logging program for Ham Radio Operators
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=435231 Lucian Langa [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455555] Review Request: libhocr - A Hebrew optical character recognition library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=45
--- Comment #7 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 12:25:01 EDT
---
(In reply to comment #6)
(In reply to comment #5)
** Requires
* Requires for -devel subpackage
---
This means that libhocr-devel subpackage must have Requires:
gtk2-devel
B. %_libdir/pkgconfig/libhocr.pc contains:
---
Libs: -lhocr -lhspell -lz -ltiff -lm
---
This means that libhocr-devel must have
Requires: hspell-devel zlib-devel libtiff-devel (because of
-lhspell -lz -ltiff)
However all these 3 linkage seem unneeded, because none of the
header files in libhocr-devel needs header files from
fftw-devel, hspell-devel, libtiff-devel.
I guess @ld_hspell@ @ld_tiff@ in libhocr.pc.in should be removed.
Their inclusion in the .pc file is correct since they are used
by the applications, either explicitly (tiffio.h and fftw3.h) or
implicitly (hspell via gtkspell).
I guess currently I don't understand what you want to say correctly.
libhocr-devel itself does not need tiffio.h or fftw3.h.
* Timestamps
- To keep timestamps on installed files, please consider to use
make install \
INSTALL=install -p \
DESTDIR=%{buildroot}\
.
-
This method usually works for based Makefiles based on recent
autotools
Hmmm... first time I see this consideration. It seems logical
but are these any guideline about it?
Although in PackagingDrafts, I usually recommend this:
https://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks#Timestamps
* Desktop files
- Category X-Fedora is deprecated and should be removed.
Done. I must have got its addition from some obsolete guide
somewhere but I cannot find any reference to it now, nevermind.
Perhaps this is difficult to find:
http://www.redhat.com/archives/fedora-extras-list/2006-October/msg00725.html
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455555] Review Request: libhocr - A Hebrew optical character recognition library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=45 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454025] Review Request: libixp - stand-alone client/server 9P library including ixpc client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454025 --- Comment #3 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 12:47:11 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454207] Review Request: Terminator - Multiple terminals in one window
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454207 --- Comment #23 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 12:59:28 EDT --- To Wolfy: It seems that Mathieu has another review requests, bug 456774 and bug 456783 . To Mathieu: Please post to this bug entry that you have already submitted some other review requests. This is needed for sponsoring process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: pokegen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #9 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-03 13:39:24 EDT --- I just tried to rebuild your latest srpm but it failed as below. http://koji.fedoraproject.org/koji/taskinfo?taskID=755698 Note: Please make build.log more verbose. The output like: -- Building CXX object pokemod/CMakeFiles/pokemod.dir/MapTrainerTeamMember.o [ 9%] Building CXX object pokemod/CMakeFiles/pokemod.dir/MapWarp.o -- is not useful. We want to check if Fedora compiler flags are correcly honored, for example. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454462] Review Request: ksplice - Patching a Linux kernel without reboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454462 --- Comment #14 from Jochen Schmitt [EMAIL PROTECTED] 2008-08-03 14:40:36 EDT --- I have add some enhancements to the kspliceprep schript which I have renamed to fedora-ksplice-prepare. The ksplace-extras subpackage is renamed into fedora-ksplice to signal that the content is fedora specific. The uploaded stuff may be find at: Spec URL: http://www.herr-schmitt.de/pub/ksplice/ksplice.spec SRPM URL: http://www.herr-schmitt.de/pub/ksplice/ksplice-0.8.7-8.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=432195 Pavel Alexeev [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #15 from Pavel Alexeev [EMAIL PROTECTED] 2008-08-03 15:03:10 EDT --- http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec is 404 error: Not Found. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457690] New: Review Request: python-flickrapi - python module for flickr api
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-flickrapi - python module for flickr api https://bugzilla.redhat.com/show_bug.cgi?id=457690 Summary: Review Request: python-flickrapi - python module for flickr api Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kushal.fedorapeople.org/python-flickrapi.spec SRPM URL: http://kushal.fedorapeople.org/python-flickrapi-1.1-1.fc9.src.rpm Description: A python module for flickr api -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454940] Review Request: rcssbase - Base libraries for Robocup Soccer Server (2D)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454940 --- Comment #11 from Hedayat Vatankhah [EMAIL PROTECTED] 2008-08-03 15:52:41 EDT --- Updated package: SPEC:http://www.assembla.com/spaces/hedayat/documents/dZnKuQtSOr3An4ab7jnrAJ/download/rcssbase.spec SRPM: http://www.assembla.com/spaces/hedayat/documents/c-GdeKyzqr3yzEab7jnrAJ/download/rcssbase-12.1.1-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 436568] Review Request: supybot - Cross-platform IRC bot written in Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=436568 --- Comment #40 from Ricky Zhou [EMAIL PROTECTED] 2008-08-03 16:33:13 EDT --- Package Change Request == Package Name: supybot New Branches: EL-4 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457690] Review Request: python-flickrapi - python module for flickr api
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457690 Marek Mahut [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Customer Facing||--- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455555] Review Request: libhocr - A Hebrew optical character recognition library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=45
--- Comment #8 from Oron Peled [EMAIL PROTECTED] 2008-08-03 17:31:15 EDT ---
(In reply to comment #7)
(In reply to comment #6)
(In reply to comment #5)
** Requires
* Requires for -devel subpackage
---
This means that libhocr-devel subpackage must have Requires:
gtk2-devel
B. %_libdir/pkgconfig/libhocr.pc contains:
---
Libs: -lhocr -lhspell -lz -ltiff -lm
---
This means that libhocr-devel must have
Requires: hspell-devel zlib-devel libtiff-devel (because of
-lhspell -lz -ltiff)
However all these 3 linkage seem unneeded, because none of the
header files in libhocr-devel needs header files from
fftw-devel, hspell-devel, libtiff-devel.
I guess @ld_hspell@ @ld_tiff@ in libhocr.pc.in should be
removed.
Their inclusion in the .pc file is correct since they are used
by the applications, either explicitly (tiffio.h and fftw3.h) or
implicitly (hspell via gtkspell).
I guess currently I don't understand what you want to say correctly.
libhocr-devel itself does not need tiffio.h or fftw3.h.
Sorry, my previous reply wasn't clear enough:
1. You are correct that fftw-devel and libtiff-devel should not be
required by libhocr, since only libhocr *implementation* uses them.
(fixed, they are only mentioned in BuildRequires).
2. However, I think that we still need them listed in the .pc files
for other (future) applications that may want to link against
libhocr. Such applications would probably have in their build
something like:
libhocr_LIBS=`pkgconfig --libs libhocr`
So the linker would add '-lfftw -ltiff'
3. TODO: libz is also mentioned in libhocr.pc, but I want to fix it
first with upstream, since the author forgot to check
for it in its configure.ac (actually, it's a dependency of
hspell which don't come with pkgconfig file of its own).
4. TODO: hspell should be removed from libhocr.pc (IMO) since its not
linked explicitly, but rather loaded during runtime
by gtkspell. I'll discuss it with upstream as well.
5. I added Requires: hspell to the gtk subpackage because rpmbuild
would not find this dependency automatically (as mentioned it is
detected by gtkspell during runtime).
* Timestamps
- To keep timestamps on installed files, please consider to use
make install \
INSTALL=install -p \
DESTDIR=%{buildroot}\
.
-
This method usually works for based Makefiles based on recent
autotools
Hmmm... first time I see this consideration. It seems logical
but are these any guideline about it?
Although in PackagingDrafts, I usually recommend this:
https://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks#Timestamps
Fixed. [added the link to my bookmarks, as it does not appear in
https://fedoraproject.org/wiki/PackagingDrafts].
* Desktop files
- Category X-Fedora is deprecated and should be removed.
Done. I must have got its addition from some obsolete guide
somewhere but I cannot find any reference to it now, nevermind.
Perhaps this is difficult to find:
http://www.redhat.com/archives/fedora-extras-list/2006-October/msg00725.html
Thanks,
I also noticed we are blocked on rawhide by bug 457502
So now libhocr can be used as a debugging tool as well ;-)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453519] Review Request: libUnihan-data - The Unihan character database in 5NF
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453519 Ding-Yi Chen [EMAIL PROTECTED] changed: What|Removed |Added Customer Facing||--- --- Comment #5 from Ding-Yi Chen [EMAIL PROTECTED] 2008-08-03 20:46:15 EDT --- I've changed the name of this package from libUnihan-data to UnihanDb. The reason I change the name is to aviod the end-user confusion. To me, the name libUnihan-data implies that it is optional and does not need to be install by default. However, database file of UnihanDb is compulsory for the whole package to work. In addition, it has its own versioning from Unicode upstream, so it should be a separate package. UnihanDd now BuildDepends and Depends on libUnihan, as it is generate by libUnihan. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453519] Review Request: libUnihan-data - The Unihan character database in 5NF
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453519 --- Comment #6 from Ding-Yi Chen [EMAIL PROTECTED] 2008-08-03 20:48:34 EDT --- BTW, the new SPEC and SRPM is available at: SPEC: http://downloads.sourceforge.net/libunihan/UnihanDb.spec?use_mirror=voxelfilesize=2225 SRPM: http://downloads.sourceforge.net/libunihan/UnihanDb-5.1-2.fc9.src.rpm?use_mirror=voxelfilesize=6207199 Regards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453520] Review Request: libUnihan - C library for Unihan character database in 5NF
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453520 Ding-Yi Chen [EMAIL PROTECTED] changed: What|Removed |Added Customer Facing||--- --- Comment #4 from Ding-Yi Chen [EMAIL PROTECTED] 2008-08-03 20:51:38 EDT --- New SPEC and SRPM for libUnihan 0.4.0 are at: SPEC: http://downloads.sourceforge.net/libunihan/libUnihan.spec?use_mirror=voxelfilesize=3062 SRPM: http://downloads.sourceforge.net/libunihan/libUnihan-0.4.0-0.fc9.src.rpm?use_mirror=voxelfilesize=72990 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453519] Review Request: UnihanDb - The Unihan character database in 5NF
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453519 Jens Petersen [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: |Review Request: UnihanDb - |libUnihan-data - The Unihan |The Unihan character |character database in 5NF |database in 5NF Alias||UnihanDb -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: pokegen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #10 from [EMAIL PROTECTED] 2008-08-03 22:17:43 EDT --- (In reply to comment #9) I just tried to rebuild your latest srpm but it failed as below. http://koji.fedoraproject.org/koji/taskinfo?taskID=755698 This is due to the new position of the phonon libraries (they are no longer in the KDE packages). I will update with my latest package which should be less dependent on whether the latest Phonon is with Qt or KDE. Note: Please make build.log more verbose. The output like: -- Building CXX object pokemod/CMakeFiles/pokemod.dir/MapTrainerTeamMember.o [ 9%] Building CXX object pokemod/CMakeFiles/pokemod.dir/MapWarp.o -- is not useful. We want to check if Fedora compiler flags are correcly honored, for example. I'm using the cmake_kde4 macro, which is what the KDE packaging uses. I'd assume that the flags are set correctly there, but I will update it to use CMAKE_VERBOSE_MAKEFILE. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: pokegen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #11 from [EMAIL PROTECTED] 2008-08-03 23:35:29 EDT --- Fixed those problems. New specs can be found at: http://benboeckel.net/pokegen/pokegen.spec http://benboeckel.net/pokegen/pokegen-0.0.2-0.10.20080804svn233.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457709] New: Review Request: perizia-fonts - English asymmetric font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perizia-fonts - English asymmetric font https://bugzilla.redhat.com/show_bug.cgi?id=457709 Summary: Review Request: perizia-fonts - English asymmetric font Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://mintojoseph.fedorapeople.org/packages/perizia-fonts.spec SRPM URL: http://mintojoseph.fedorapeople.org/packages/perizia-fonts-2008803-1.fc8.src.rpm Description: perizia is an asymmetric English font. See also http://fedoraproject.org/wiki/Perizia_fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457546] Review Request: perl-Net-RawIP - A Perl extension for manipulating raw ip packets using libpcap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457546 Parag AN(पराग) [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Parag AN(पराग) [EMAIL PROTECTED] 2008-08-04 00:36:14 EDT --- Review: + package builds in mock (rawhide i386). koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=756354 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f3b365136ccf88c79167ac3b1292e5b3 Net-RawIP-0.23.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=7, Tests=104, 4 wallclock secs ( 0.04 usr 0.01 sys + 4.38 cusr 0.08 csys = 4.51 CPU) + Package perl-Net-RawIP-0.23-1.fc10= Provides: RawIP.so perl(Net::RawIP) = 0.23 perl(Net::RawIP::ethhdr) = 0.23 perl(Net::RawIP::generichdr) = 0.23 perl(Net::RawIP::icmphdr) = 0.23 perl(Net::RawIP::iphdr) = 0.23 perl(Net::RawIP::opt) = 0.23 perl(Net::RawIP::tcphdr) = 0.23 perl(Net::RawIP::udphdr) = 0.23 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libpcap.so.0.9 perl(AutoLoader) perl(Carp) perl(Class::Struct) perl(DynaLoader) perl(English) perl(Exporter) perl(Net::RawIP::ethhdr) perl(Net::RawIP::generichdr) perl(Net::RawIP::icmphdr) perl(Net::RawIP::iphdr) perl(Net::RawIP::opt) perl(Net::RawIP::tcphdr) perl(Net::RawIP::udphdr) perl(strict) perl(subs) perl(vars) perl(warnings) rtld(GNU_HASH) Suggestions:- You can include examples directory in %doc. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450371] Review Request: pokegen - Strategy/RPG game engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450371 --- Comment #12 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-04 00:42:52 EDT --- Again just tried to rebuild and this time rebuild failed seemingly by some obvious reason: http://koji.fedoraproject.org/koji/taskinfo?taskID=756321 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457546] Review Request: perl-Net-RawIP - A Perl extension for manipulating raw ip packets using libpcap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457546 Parag AN(पराग) [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457545] Review Request: perl-Net-Ping-External - Cross-platform interface to ICMP ping utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457545 Parag AN(पराग) [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #1 from Parag AN(पराग) [EMAIL PROTECTED] 2008-08-04 00:40:56 EDT --- Review: + package builds in mock (rawhide i386). koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=756359 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 29c6cd74081861f4bffe1f83943f5792 Net-Ping-External-0.12.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package perl-Net-Ping-External-0.12-1.fc10 = Provides: perl(Net::Ping::External) = 0.12 Requires: perl(Carp) perl(Exporter) perl(Socket) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457509] Review Request: scim-thai - Thai IMEngine for SCIM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457509 Parag AN(पराग) [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #1 from Parag AN(पराग) [EMAIL PROTECTED] 2008-08-04 00:47:04 EDT --- rpmlint gave me = scim-thai.i386: E: description-line-too-long Currently, it supports 3 keyboard layouts: Ketmanee, TIS-820.2538, and Pattachote. Your description lines must not exceed 79 characters. If a line is exceeding this number, cut it to fit in two lines. scim-thai.i386: E: description-line-too-long In addition to keyboard layout supports, it also validate input sequences in 3 levels of strictness: Passthrough (no check), Basic Check, and Strict Check. Your description lines must not exceed 79 characters. If a line is exceeding this number, cut it to fit in two lines. scim-thai.i386: E: description-line-too-long For applications that support surrounding text retrieval/deleting, it also corrects the invalid input sequences. Your description lines must not exceed 79 characters. If a line is exceeding this number, cut it to fit in two lines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457544] Review Request: perl-IPTables-ChainMgr - A Perl extension for manipulating iptables policies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457544 Parag AN(पराग) [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457543] Review Request: perl-IPTables-Parse - A Perl extension for parsing iptables firewall rulesets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457543 Parag AN(पराग) [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #1 from Parag AN(पराग) [EMAIL PROTECTED] 2008-08-04 00:59:44 EDT --- Review: + package builds in mock (rawhide i386). koji Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=756386 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 03fcd2d010db1b7190f7e257124cb278 IPTables-Parse-0.6.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.01 cusr 0.00 csys = 0.01 CPU) + Package perl-IPTables-Parse-0.6-1.fc10 = Provides: perl(IPTables::Parse) = 0.5 Requires: perl = 0:5.006 perl(Carp) perl(strict) perl(vars) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450013] Review Request: testopia - bugzilla extended to add test case management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450013 Greg DeKoenigsberg [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Customer Facing||--- --- Comment #26 from Greg DeKoenigsberg [EMAIL PROTECTED] 2008-08-04 01:14:57 EDT --- Any chance that the current situation can be clarified here? Are we simply waiting for the draft document here: http://extjs.com/products/floss-exception.php ...to become final? What's the status? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457509] Review Request: scim-thai - Thai IMEngine for SCIM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457509 Jens Petersen [EMAIL PROTECTED] changed: What|Removed |Added Customer Facing||--- --- Comment #2 from Jens Petersen [EMAIL PROTECTED] 2008-08-04 01:41:58 EDT --- Thanks - fixed: Spec URL: http://petersen.fedorapeople.org/scim-thai/scim-thai.spec SRPM URL: http://petersen.fedorapeople.org/scim-thai/scim-thai-0.1.1-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453016] Review Request: un-core-fonts - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453016 Jens Petersen [EMAIL PROTECTED] changed: What|Removed |Added Attachment #312229|4 to 5 patch|updated spec file description|| Attachment #312229|un-core-fonts.spec-5.1.patc |un-core-fonts.spec-5.1 filename|h | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457123] Review Request: pyevent - Python bindings for libevent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457123 Parag AN(पराग) [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #1 from Parag AN(पराग) [EMAIL PROTECTED] 2008-08-04 01:46:09 EDT --- Review: + package builds in mock. Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=756467 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 584912c92d08bf005283fb29a47a6e4d pyevent-0.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Package pyevent-0.3-3.fc10 = Provides: event.so Requires: libc.so.6 libc.so.6(GLIBC_2.1.3) libevent-1.4.so.2 libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457690] Review Request: python-flickrapi - python module for flickr api
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457690
Parag AN(पराग) [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
--- Comment #1 from Parag AN(पराग) [EMAIL PROTECTED] 2008-08-04 01:57:34 EDT
---
1)you don't need again {%_docdir} remove it from %files
2) Add BuildRequires: python-setuptools
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
