[Bug 458624] Review Request: teseq - An utility for rendering terminal typescripts human readable
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458624 --- Comment #13 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-30 01:58:33 EDT --- Well, adding the reviewer (or sponsor) to InitialCC member is not required. Anyway you can feel free to ask me on this bug (for this review request) or by mailing to me if you have some questions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458624] Review Request: teseq - An utility for rendering terminal typescripts human readable
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458624 --- Comment #14 from vivek shah [EMAIL PROTECTED] 2008-08-30 02:17:46 EDT --- New Package CVS Request === Package Name: teseq Short Description: An utility for rendering terminal typescripts human readable Owners: bonii Branches: F-8 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460724] Review Request: vhdl-mode - VHDL Mode in Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460724 Rakesh Pandit [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: vhdl-mode - |Review Request: vhdl-mode - |VHDL Mode is Emacs |VHDL Mode in Emacs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460724] New: Review Request: vhdl-mode - VHDL Mode is Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: vhdl-mode - VHDL Mode is Emacs https://bugzilla.redhat.com/show_bug.cgi?id=460724 Summary: Review Request: vhdl-mode - VHDL Mode is Emacs Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Description: VHDL Mode is an Emacs major mode for editing VHDL code. SPEC: http://rakesh.fedorapeople.org/spec/vhdl-mode.spec SRPM: http://rakesh.fedorapeople.org/srpm/vhdl-mode-3.33.26-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452211] Review Request: spu-binutils - Binutils for the SPU on IBM Cell processors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452211 --- Comment #5 from Aidan Delaney [EMAIL PROTECTED] 2008-08-30 05:29:41 EDT --- I should have said Internationalisation is disabled because otherwise spu-binutils would overwrite the .mo files provided by binutils. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452211] Review Request: spu-binutils - Binutils for the SPU on IBM Cell processors
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452211
--- Comment #4 from Aidan Delaney [EMAIL PROTECTED] 2008-08-30 05:26:12 EDT
---
This is my first package review. I've read both the maintainers guide and the
reviewers guide.
Following the reviewer guide verbatim I find the following issues
• rpmlint reports the creation of non-standard /usr/spu directory
• BuildRequires should include gcc
• internationalisation is disabled
• ${RPM_BUILD_ROOT} used instead of %{buildroot}
I also proffer the opinion that
• ExclusiveArch may be a little restrictive, it /should/ work on x86_64
I think I can argue against some of my strict reading of the reviewers
guidelines. A non-standard /usr/spu directory is created as this is what was
agreed for Fedora cross compilers. Furthermore, internationalisation is
disabled because otherwise spu-binutils would overwrite the .mo files.
I believe that BuildRequires must include gcc and I suspect that the
${RPM_BUILD_ROOT} and ExclusiveArch issues are because of the style employed by
the packager, something I'm unqualified to critique.
I find the spec file easy to read and have been using binaries built from this
spec file on my own systems.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460727] New: Review Request: gnujump - A jumping game which is a clone of xjump
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gnujump - A jumping game which is a clone of xjump https://bugzilla.redhat.com/show_bug.cgi?id=460727 Summary: Review Request: gnujump - A jumping game which is a clone of xjump Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://bonii.fedorapeople.org/spec/gnujump.spec SRPM URL: http://bonii.fedorapeople.org/srpms/gnujump-1.0.5-1.fc9.src.rpm Description: GNUjump is a clone of the simple yet addictive game Xjump, adding new features like multiplaying, unlimited FPS, smooth floor falling, themable graphics, sounds,replays, etc. The goal in this game is to jump to the next floor trying not to fall down. As you go upper in the Falling Tower the floors will fall faster. Try to survive longer get upper than anyone. It might seem too simple but once you've tried you'll realize how addictive this is. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #29 from Devrim GUNDUZ [EMAIL PROTECTED] 2008-08-30 08:54:44 EDT --- Hi Mamoru, http://developer.postgresql.org/~devrim/rpms/other/pgbouncer/pgbouncer.spec http://developer.postgresql.org/~devrim/rpms/other/pgbouncer/pgbouncer-1.2.3-3.f9.src.rpm Applied the two changes you suggested. Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447457] Review Request: gupnp-av - UPnP-AV is a collection of helpers for building AV upnp apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447457 --- Comment #6 from Peter Robinson [EMAIL PROTECTED] 2008-08-30 09:19:58 EDT --- gupnp that this depends on is now built and should hit rawhide tomorrow. Along with the srpm above all should be good to go now. I tested a scratch build in koji just now http://koji.fedoraproject.org/koji/taskinfo?taskID=795141 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #13 from Peter Robinson [EMAIL PROTECTED] 2008-08-30 09:44:24 EDT --- Songbird now has a tracking bug in upstream Mozilla BZ to track their xulrunner issues. https://bugzilla.mozilla.org/show_bug.cgi?id=357052 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460732] New: Review Request: ocaml-reins - Library of OCaml persistent data structures
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: ocaml-reins - Library of OCaml persistent data
structures
https://bugzilla.redhat.com/show_bug.cgi?id=460732
Summary: Review Request: ocaml-reins - Library of OCaml
persistent data structures
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-reins.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-reins-0.1-0.1.a.fc10.src.rpm
Description: Library of OCaml persistent data structures
This is a very simple package -- just a library containing a very
big collection of purely functional data structures.
rpmlint has this to say about the package:
ocaml-reins.src:89: W: rpm-buildroot-usage %build export
OCAMLFIND_DESTDIR=$RPM_BUILD_ROOT%{_libdir}/ocaml
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will
break short circuiting.
I can't see a way to build this package without setting OCAMLFIND_DESTDIR
in the %build stage. The package seems to stash this somewhere, and just
setting it later during %install doesn't work. I don't know what
short circuiting is and whether it's a problem that we break it.
ocaml-reins.i386: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.
This is a well-known problem with OCaml packages and can be ignored
(for now). RPM are promising to add a feature which will allow us
to build this as noarch, but it's not there yet.
Files in the main package:
/usr/lib/ocaml/reins
/usr/lib/ocaml/reins/META
/usr/lib/ocaml/reins/reins.cma
/usr/lib/ocaml/reins/reins.cmi
/usr/share/doc/ocaml-reins-0.1
/usr/share/doc/ocaml-reins-0.1/COPYING
/usr/share/doc/ocaml-reins-0.1/LGPL-2.1
Requires:
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(VersionedDependencies) = 3.0.3-1
ocaml(Big_int) = 992d682669507b99e689b5a2188c0b9a
ocaml(Buffer) = f6cef633ea14963b84b79c4095c63dc3
ocaml(Char) = e98bc9c9e918a84b3c1a5a122d42fac1
ocaml(Complex) = bb333e8e4cda78107ccf27048ca40492
ocaml(Hashtbl) = 083f2c94b44ff4e0b3220aaea6a783b4
ocaml(Int32) = 711321870c949bd3bbdd092d9bae92e4
ocaml(Int64) = f8f7e2e4c0667ead94596040b12e732d
ocaml(Lazy) = 8a4b5e7f0bdc6316df9264fd73cde981
ocaml(List) = da1ce9168f0408ff26158af757456948
ocaml(Map) = dedde7683d54ae7db1eb97cc868dd047
ocaml(Nat) = 0ea20dd1cc4533fd519b5542a89feb87
ocaml(Nativeint) = e79cdc4d3575c2ed044955cb7ef49aca
ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d
ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57
ocaml(Printexc) = 82717999a586ede6925c0aa18d6562ac
ocaml(Printf) = 5dbbf45a03b54e6dbfcf39178d0d6341
ocaml(Random) = 9936935480b36bcbc716ee513f37876c
ocaml(Ratio) = 7067125cce206dd2bbe93918ba7bdfe9
ocaml(String) = 2c162ab314b2f0a2cfd22d471b2e21ab
ocaml(Sys) = 0da495f5a80f31899139359805318f28
ocaml(Unix) = 9a46a8db115947409e54686ada118599
ocaml(runtime) = 3.10.2
Provides:
ocaml(Reins) = 80e0049b95f5867ce642993dddbe7e76
ocaml-reins = 0.1-0.1.a.fc10
ocaml-reins(x86-32) = 0.1-0.1.a.fc10
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460289] Review Request: vldocking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460289 --- Comment #3 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-30 12:33:38 EDT --- For -2 (In reply to comment #2) (In reply to comment #1) For 2.0.6e-1: * SourceURL - Please write how you can download the tarball you use. I've tried the url too but it's clear there is some magic in the website to not let that. - Well, my comment was unclear. What I meant is that you should write as comments how we can download the tarball. So * The URL tag can be http://www.vlsolutions.com/en/download/ * And please write as a comment that the tarball you are using can be downloaded from the redirect from http://www.vlsolutions.com/en/download/downloader2_0.php One cosmetic issue: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) - You are using both tabs and spaces for indentation. Please choose one and not using both (for cosmetic issue) Please fix the issues above when importing to Fedora CVS. Well, * This package itself is okay * Usually a new contributor who needs to get sponsored has to show that you have an understanding of the process and of the packaging guidelines as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored One of the way to show this is to submit another review request with enough quality. For your case I already know your other works which I can admit is enough for sponsoring process. -- This package (vldocking) is APPROVED by mtasaka -- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from Get a Fedora Account. At a point a mail should be sent to sponsor members which notifies that you need a sponsor. At the stage, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you. If you want to import this package into Fedora 8/9, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460287] Review Request: htmlparser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460287
--- Comment #3 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-30 12:45:41 EDT
---
Well,
* I cannot find any notes from the source codes which shows that this software
can be
licensed also under CPL. Are there any explicit declaration?
* I forgot to say in my previous comment, howver for unzip command would you
use
unzip -qq foo.zip to suppress output? (for tar archive, rpmbuild uses tar
xf and
does not show the file list in the archive by default).
* Also I forgot to say in my previous comment, however for cosmetic issue
please unify macro usage like %{__unzip} (not %__unzip) if you use
%{_javadir} (not %_javadir) and so on.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 250971] Review Request: ivtv-utils - userspace tools for iTVC15/16 and CX23415/16 driven devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=250971 Axel Thimm [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: ivtv - |Review Request: ivtv-utils |userspace tools for |- userspace tools for |iTVC15/16 and CX23415/16|iTVC15/16 and CX23415/16 |driven devices |driven devices --- Comment #42 from Axel Thimm [EMAIL PROTECTED] 2008-08-30 12:55:56 EDT --- Dropping epochs is sexy! :) http://dl.atrpms.net/all/ivtv-utils.spec http://dl.atrpms.net/all/ivtv-utils-1.2.0-6.src.rpm This is what will be committed for F-8/F-9, F10 is similar, e.g. dropping a fix and upping the Version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #30 from Mamoru Tasaka [EMAIL PROTECTED] 2008-08-30 13:23:04 EDT --- Okay. This package (pgbouncer) is APPROVED by mtasaka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #31 from Devrim GUNDUZ [EMAIL PROTECTED] 2008-08-30 13:41:16 EDT --- BTW, I just added = 1.3b to libevent-devel dependency -- this version explicitly asks for that (which is available in F-8 + -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #32 from Devrim GUNDUZ [EMAIL PROTECTED] 2008-08-30 13:43:57 EDT --- New Package CVS Request === Package Name: pgbouncer Short Description: Lightweight connection pooler for PostgreSQL Owners: devrim Branches: F-8 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454120] Review Request: vdr-streamdev - Streaming client/server package for VDR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454120 --- Comment #4 from Felix Kaechele [EMAIL PROTECTED] 2008-08-30 14:13:57 EDT --- I've incorporated the suggestions. See: Spec URL: http://felix.fetzig.org/rpms/review/vdr-streamdev.spec SRPM URL: http://felix.fetzig.org/rpms/review/vdr-streamdev-0.3.4-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226813] Merge Review: zsh
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226813 Daniel Qarras [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #12 from Daniel Qarras [EMAIL PROTECTED] 2008-08-30 14:53:07 EDT --- I still see the offending tetris function with latest zsh available for F9. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460538] Review Request: ircd-ratbox - Ircd-ratbox is an advanced, stable and fast ircd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460538 --- Comment #7 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 16:47:17 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460615] Review Request: bti - Bash Twitter Idiocy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460615 --- Comment #5 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 16:46:14 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455187] Review Request: erlang-pgsql - Erlang PostgreSQL interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455187 --- Comment #8 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 16:49:05 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430429] Review Request: python-storm - An object-relational mapper (ORM) for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=430429 --- Comment #13 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 16:51:38 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 427411] Review Request: common-lisp-controller - Common Lisp source and compiler manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427411 --- Comment #8 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 16:58:35 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #33 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 17:00:25 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450243] Review Request: google-gadgets - Google Gadgets for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450243 --- Comment #22 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 17:02:58 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458624] Review Request: teseq - An utility for rendering terminal typescripts human readable
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458624 --- Comment #15 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 17:04:26 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458655] Review Request: perl-Text-Table - Organize Data in Tables
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458655 --- Comment #5 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 17:06:03 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460629 --- Comment #7 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-30 17:07:35 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=441378
manuel wolfshant [EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
--- Comment #9 from manuel wolfshant [EMAIL PROTECTED] 2008-08-30 19:23:42
EDT ---
What's the reasoning behind using
%attr(2775, root, apache) %{_localstatedir}/lib/%{name}/images
and not
%attr(755, apache, root) %{_localstatedir}/lib/%{name}/images
?
This will allow apache to write in the images directory (as required by the
cgi) and avoid using any suid.
Look for a full review soon.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460615] Review Request: bti - Bash Twitter Idiocy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460615 --- Comment #6 from Fedora Update System [EMAIL PROTECTED] 2008-08-30 19:48:11 EDT --- bti-005-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/bti-005-1.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460615] Review Request: bti - Bash Twitter Idiocy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460615 --- Comment #7 from Fedora Update System [EMAIL PROTECTED] 2008-08-30 19:49:11 EDT --- bti-005-1.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/bti-005-1.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=441378
--- Comment #10 from manuel wolfshant [EMAIL PROTECTED] 2008-08-30 19:54:29
EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM:E: unknown-key GPG#7666df64
-- ignoreable
binary RPM:
smokeping.noarch: W: non-standard-gid /var/lib/smokeping/images apache
- needed, the cgi provided by smokeping must be able to create apache readable
images
smokeping.noarch: E: non-standard-dir-perm /var/lib/smokeping/images 02775
-- needed, in order to have the provided CGI create images, but avoidable by
changing the owner/group settings
smokeping.noarch: E: non-readable /etc/smokeping/smokeping_secrets 0640
-- needed, the file contains passwords
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[!] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
-- see issue 1
[!] License field in the package spec file matches the actual license.
License type: see issue 1
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
SHA1SUM of package: 055d65c7e3c49cd0d6e8f96242131fe69dc3110e
/tmp/smokeping-2.4.2.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[!] Permissions on files are set properly.
-- see issue 2
[x] Package has a %clean section, which contains rm -rf %{buildroot}.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: all archs suported by koji scratch build
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: all archs suported by koji scratch build
[x] Package functions as described.
[x] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
=== Issues ===
1. Smokeping itself is GPLv2+ but it relies and includes several modules which
either have no license specified
(/usr/share/smokeping/lib/Smokeping/probes/FPing.pm,
/usr/share/smokeping/lib/Smokeping/probes/EchoPingSmtp.pm and many many others)
or claim to be under the artistic license (/usr/share/smokeping/lib/BER.pm,
/usr/share/smokeping/lib/SNMP_Session.pm,
/usr/share/smokeping/lib/SNMP_util.pm). Unfortunately, despite the fact the
sources claim that the Artistic License is included, the tar file does not
really included it. AFAIK the original Artistic license is not acceptable in
Fedora, so I must ask you to verify that all the included modules do have an
acceptable license.
2. The permissions/ownership as proposed are functional and acceptable, but I
see no reason to use 2775 for the folder where smokeping writes the images. I
think that using apache.root as owner/group and 755 as modes will
[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=441378 --- Comment #11 from Yanko Kaneti [EMAIL PROTECTED] 2008-08-30 20:16:00 EDT --- The original tarball includes a private copy/version of files from at least perl-CGI-Session, perl-SNMP_Session, perl-JSON. And it seems the rpm produced with this spec does too. This should not be allowed without a really good reason. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460182] Review Request: python-virtualenv - Tool to create isolated Python environments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460182 --- Comment #5 from Steve Milner [EMAIL PROTECTED] 2008-08-30 20:20:46 EDT --- Updated for upstream release. http://www.stevemilner.org/tmp/python-virtualenv-1.2-1.fc9.src.rpm http://www.stevemilner.org/tmp/python-virtualenv.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450243] Review Request: google-gadgets - Google Gadgets for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450243 --- Comment #23 from Fedora Update System [EMAIL PROTECTED] 2008-08-30 21:40:41 EDT --- google-gadgets-0.10.1-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/google-gadgets-0.10.1-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459881] Review Request: rubygem-sqlite3-ruby - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459881 --- Comment #2 from Jeroen van Meeuwen [EMAIL PROTECTED] 2008-08-30 21:50:15 EDT --- New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-sqlite3-ruby.spec New SRPM: http://www.kanarip.com/custom/f10/SRPMS/rubygem-sqlite3-ruby-1.2.2-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=441378 --- Comment #12 from manuel wolfshant [EMAIL PROTECTED] 2008-08-30 23:11:10 EDT --- Good catch, Yanko! I've re-analyzed the perl modules that are included and the following ones are private copies of CPAN modules and should no be included: - CGI::Session - Digest:HMAC,Digest:HMAC_MD5, Digest::HMAC_SHA1 - JSON + submodules (note that the latest version available in CPAN is 2.12, while smokeping includes 1.14; according to it's documentation, 2.12 includes incompatibilities towards the older version) - qooxdoo is included in the binary rpm, but qooxdoo/README.txt from the source files claims it is only needed for development, not for runtime SNMP_Session and SNMP_Util seem to be own implementations, not the CPAN versions. I could not find their author, Simon Leinen, in http://search.cpan.org/search?m=authorq=+Simon+Leinen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430429] Review Request: python-storm - An object-relational mapper (ORM) for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=430429 --- Comment #14 from Fedora Update System [EMAIL PROTECTED] 2008-08-31 00:39:54 EDT --- python-storm-0.13-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/python-storm-0.13-1.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 430429] Review Request: python-storm - An object-relational mapper (ORM) for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=430429 --- Comment #15 from Fedora Update System [EMAIL PROTECTED] 2008-08-31 00:40:42 EDT --- python-storm-0.13-1.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/python-storm-0.13-1.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458346] Review Request: gflags - Library for commandline flag processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458346 --- Comment #8 from Rakesh Pandit [EMAIL PROTECTED] 2008-08-31 01:48:10 EDT --- @Till ping Waiting impatiently ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
