[Bug 448072] Review Request: spin-kickstarts - Kickstarts and templates for creating custom Fedora Spins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448072 --- Comment #8 from Jens Petersen <[EMAIL PROTECTED]> 2008-09-01 02:45:37 EDT --- Ok :) I just found this: https://www.redhat.com/archives/fedora-livecd-list/2008-August/msg00095.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448072] Review Request: spin-kickstarts - Kickstarts and templates for creating custom Fedora Spins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448072 --- Comment #7 from Jeroen van Meeuwen <[EMAIL PROTECTED]> 2008-09-01 02:40:48 EDT --- We can build it now for rawhide I suppose. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458653] Review Request: perl-Devel-PerlySense - Perl IDE backend with Emacs frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458653 Bug 458653 depends on bug 458655, which changed state. Bug 458655 Summary: Review Request: perl-Text-Table - Organize Data in Tables https://bugzilla.redhat.com/show_bug.cgi?id=458655 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458655] Review Request: perl-Text-Table - Organize Data in Tables
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458655 Marcela Maslanova <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448072] Review Request: spin-kickstarts - Kickstarts and templates for creating custom Fedora Spins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448072 Jens Petersen <[EMAIL PROTECTED]> changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED CC||[EMAIL PROTECTED] Resolution|NEXTRELEASE | --- Comment #6 from Jens Petersen <[EMAIL PROTECTED]> 2008-09-01 01:56:42 EDT --- When is this going to be built? (Reopening for now:) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454250] Review Request: tangoGPS - tangoGPS is a lightweight and fast mapping application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454250
--- Comment #12 from Debarshi Ray <[EMAIL PROTECTED]> 2008-09-01 00:19:30 EDT
---
Created an attachment (id=315455)
--> (https://bugzilla.redhat.com/attachment.cgi?id=315455)
tangogps.desktop fix
MUST Items:
xx - rpmlint is unclean on RPM
+ [EMAIL PROTECTED] x86_64]$ rpmlint tangogps-0.9.3-2.fc9.x86_64.rpm
tangogps.x86_64: W: summary-not-capitalized tangoGPS is a lightweight and
fast mapping application
tangogps.x86_64: E: invalid-desktopfile
/usr/share/applications/tangogps.desktop
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
[EMAIL PROTECTED] x86_64]$
+ rpmlint is unclean on SRPM
[EMAIL PROTECTED] SRPMS]$ rpmlint tangogps-0.9.3-2.fc9.src.rpm
tangogps.src: W: summary-not-capitalized tangoGPS is a lightweight and
fast mapping application
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[EMAIL PROTECTED] SRPMS]$
OK - follows Naming Guidelines
OK - spec file is named as %{name}.spec
xx - package does not meet Packaging Guidelines
+ To work around the rpmlint warnings you could consider borrowing the
summary used by Debian (http://packages.debian.org/lenny/tangogps):
"GTK+ mapping and GPS application"
+ Even though Fedora does not use the Group tag, please consider a more
suitable value for the sake of perfection.
+ To preserve timestamps you could consider using:
make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT
OK - license meets Licensing Guidelines
OK - license field meets actual license
OK - upstream license file included in %doc
OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources
OK - package builds successfully
OK - ExcludeArch not needed
OK - build dependencies correctly listed
+ The 'BuildRequires: glib2-devel' is redundant since
'BuildRequires: gtk2-devel' will drag it in as well.
OK - locales handled properly
OK - no shared libraries
OK - package is not relocatable
OK - file and directory ownership
OK - no duplicates in %file
OK - file permissions set properly
OK - %clean present
OK - macros used consistently
OK - contains code and permissable content
OK - -doc is not needed
OK - contents of %doc does not affect the runtime
OK - no header files
OK - no static libraries
OK - no pkgconfig files
OK - no library files
OK - -devel is not needed
OK - no libtool archives
xx - %{name}.desktop file is invalid and not properly installed
+ The .desktop file does not meet the specification. You can use
desktop-file-validate to have a look at the problems. Please consider the
attached patch as a fix for these issues.
+ If the package installs a .desktop file, then desktop-file-install must
be run. See
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Since
upstream does not provide a vendor ID, you should use "fedora" as the
value.
OK - does not own files or directories owned by other packages
OK - buildroot correctly prepped
OK - all file names valid UTF-8
SHOULD Items:
OK - upstream provides license text
xx - no translations for description and summary
OK - package builds in mock successfully
OK - package builds on all supported architectures
xx - package will not function as expected
+ Looking at the GUI, it seems that a GPS daemon is necessary during
runtime. Please add 'Requires: gpsd' to take care of this.
OK - scriptlets are not needed
OK - subpackages are not needed
OK - no pkgconfig files
OK - no file dependencies
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460786] Review Request: mediawiki-Cite - An extension to provide Citation tools for Mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460786 Ian Weller <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #1 from Ian Weller <[EMAIL PROTECTED]> 2008-08-31 20:48:37 EDT --- I'll review this shortly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460786] New: Review Request: mediawiki-Cite - An extension to provide Citation tools for Mediawiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mediawiki-Cite - An extension to provide Citation tools for Mediawiki https://bugzilla.redhat.com/show_bug.cgi?id=460786 Summary: Review Request: mediawiki-Cite - An extension to provide Citation tools for Mediawiki Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://dev.nigelj.com/SRPMS/mediawiki-Cite.spec SRPM URL: http://dev.nigelj.com/SRPMS/mediawiki-Cite-0-0.2.20080901svn.src.rpm Description: Citation extension allowing the placing and viewing of footnotes and references articles stored in Mediawiki -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=441378
--- Comment #14 from manuel wolfshant <[EMAIL PROTECTED]> 2008-08-31 20:20:10
EDT ---
Could you please add to the README.fedora file a couple of lines indicating how
to configure the system to allow for smoketrace usage?
a) the traceroute binary must be suid (chmod u+s ), otherwise the cgi will
display an errror message ("The specified type of tracerouting is allowed for
superuser only") and bail out.
b) selinux might also complain with errors similar to:
Sep 1 03:11:52 wolfy setroubleshoot: SELinux is preventing
/bin/traceroute (httpd_t) "net_raw" to (httpd_t). For complete
SELinux messages. run sealert -l 5e473b24-c127-4c3f-903d-510ead101bec
Sep 1 03:11:52 wolfy setroubleshoot: SELinux is preventing
/bin/traceroute (httpd_t) "connect" to (httpd_t). For complete
SELinux messages. run sealert -l e9b14398-4979-43c9-8ea3-9ca46bae5034
Sep 1 03:11:52 wolfy setroubleshoot: SELinux is preventing
/bin/traceroute (httpd_t) "rawip_send" to (node_t). For complete
SELinux messages. run sealert -l 1185b418-256b-4340-983c-e5a071804fe8
Sep 1 03:11:52 wolfy setroubleshoot: SELinux is preventing
/bin/traceroute (httpd_t) "node_bind" to (inaddr_any_node_t).
For complete SELinux messages. run sealert -l
2c034994-cf52-4993-aa97-c6d28bba3562
Sep 1 03:11:52 wolfy setroubleshoot: SELinux is preventing
/bin/traceroute (httpd_t) "setopt" to (httpd_t). For complete
SELinux messages. run sealert -l 3ca926de-8227-4473-81c3-3d50dce61550
Sep 1 03:11:52 wolfy setroubleshoot: SELinux is preventing
/bin/traceroute (httpd_t) "read" to (httpd_t). For complete
SELinux messages. run sealert -l 56c93fca-006d-40e6-88b6-72492f474042
Sep 1 03:11:52 wolfy setroubleshoot: SELinux is preventing
setroubleshootd (httpd_t) "rawip_recv" to (node_t). For complete
SELinux messages. run sealert -l ab9af5f0-874d-4521-9d2b-3a314af3f8dd
However the selinux messages suddenly disappeared, only that I am not yet sure
what I did to fix...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460690] Review Request: echo-artist - Automation tools for echo-icon-theme artists
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460690
--- Comment #2 from Luya Tshimbalanga <[EMAIL PROTECTED]> 2008-08-31 20:15:02
EDT ---
Here is a summary:
$ rpmlint rpmbuild/SRPMS/echo-artist-0.1-1.fc9.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings
$ rpmlint rpmbuild/RPMS/noarch/echo-artist-0.1-1.fc9.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
The package is correctly named according to Package Naming Guidelines
https://fedoraproject.org/wiki/Packaging/NamingGuidelines
Name of spec files matches the %{name}
Package complies to Packaging Guidelines
https://fedoraproject.org/wiki/Packaging/Guidelines
Package is licensed under LGPLv2
Package is upstream and legible.
Source URL matches upstream
(https://fedorahosted.org/releases/e/c/echo-icon-theme/)
Package does not use BuuldRequires because of scripts and uses Requires only.
Package successfully compiled using koji.
spec file contains %clean session.
Permission is set correctly %defattr(-,root,root,-)
Package is a set of script thus does not need .desktop.
Uses of macros is consistent. %{buildroot} would be favorite considering the
internal change of rpm itself in Fedora 10.
filename are in validated UTF-8 format.
This package has passed all reviews thus ready to be accepted.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=441378 --- Comment #13 from manuel wolfshant <[EMAIL PROTECTED]> 2008-08-31 19:46:52 EDT --- The qooxdoo/README.txt seems to be misleading. SmokeTrace contains the following lines: use Qooxdoo::JSONRPC; Qooxdoo::JSONRPC::handle_request ($cgi, $session); So it seems that /usr/share/smokeping/lib/Qooxdoo /usr/share/smokeping/lib/Qooxdoo/JSONRPC.pm /usr/share/smokeping/lib/Qooxdoo/Services /usr/share/smokeping/lib/Qooxdoo/Services/Tr.pm should be made available, but I think that is should exist as a separate package. Fortunately it is licensed as LGPL so it is compatible with the GPLv2+ of smokeping. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448337] Review Request: enlightenment - a next generation desktop shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448337 Pavel Shevchuk <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|needinfo?([EMAIL PROTECTED]) | --- Comment #12 from Pavel Shevchuk <[EMAIL PROTECTED]> 2008-08-31 18:26:10 EDT --- Sorry for huge delay =( * Sat Aug 30 2008 Pavel "Stalwart" Shevchuk <[EMAIL PROTECTED]> - 0.16.999.043-3 - One more directory ownership fix - Backported enlightenment.pc.in from trunk - Strip unneeded config.h include from e.h Spec: http://rpm.scwlab.com/fedora/e17/9/i386/enlightenment-0.16.999.043-3/enlightenment.spec SRPM: http://rpm.scwlab.com/fedora/e17/9/i386/enlightenment-0.16.999.043-3/enlightenment-0.16.999.043-3.fc9.src.rpm YUM repository for f9, i386 and x86_64: [scwlab-f-e17] name=Stalwart Fedora - E17 baseurl=http://rpm.scwlab.com/fedora/e17/$releasever/$basearch gpgcheck=0 enabled=1 --- I hacked up patch for config.h just to realize that config.h isn't actually needed to build stuff that depends on e17. =( So i just strip config.h out of e.h now. I'm not sure deriving from upstream enlightenment-config is really needed, so i didn't in -3. If you insist, i could do -4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454980] Review Request: axel - Download accelerator, wget replacement
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454980 --- Comment #12 from Michael Schwendt <[EMAIL PROTECTED]> 2008-08-31 17:17:25 EDT --- > ./configure See comment 1. One can argue that non-fatal errors like that are acceptable, but they can be avoided. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454980] Review Request: axel - Download accelerator, wget replacement
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454980
--- Comment #11 from Pavel Alexeev <[EMAIL PROTECTED]> 2008-08-31 15:28:31 EDT
---
Ankur Shrivastava, do you make any decision accordingly this package? Do you
want continue working on this package? Or do you want co-maintain it?
(In reply to comment #10)
> Don't use %configure but ./configure with proper arguments,
> because this configure script is a custom one.
Custom? Koji build successfully on any architectures, so, this macros expanded.
What is a reason why I should provide manually all this parameters like PREFIX
and others standard?
> The proper way to include these files is the %find_lang macro:
Yes. I'm known it now.
Well, let them be so.
>
> > %{_mandir}/man1/axel.1.gz
>
> Currently, it really is automatic .gz compression. Better use a
> wildcard, so the package keeps building whenever the underlying
> compression method changes:
Ok.
http://hubbitus.net.ru/rpm/Fedora9/axel/axel-1.1-2.fc9.src.rpm
http://hubbitus.net.ru/rpm/Fedora9/axel/axel.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460780] New: Review Request: haxe - Web programming language targeting Flash, Javascript, PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: haxe - Web programming language targeting Flash, Javascript, PHP https://bugzilla.redhat.com/show_bug.cgi?id=460780 Summary: Review Request: haxe - Web programming language targeting Flash, Javascript, PHP Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.annexia.org/tmp/ocaml/haxe.spec SRPM URL: http://www.annexia.org/tmp/ocaml/haxe-2.0-1.fc10.src.rpm Description: Web programming language targeting Flash, Javascript, PHP rpmlint says: haxe.i386: W: unstripped-binary-or-object /usr/bin/haxe haxe.i386: W: executable-stack /usr/bin/haxe Yes indeed, we cannot strip the binaries because strip damages them. The upstream "build system" (I use the term advisedly) is crazy. It consists of a lengthy script which downloads the sources from several CVS repositories and then issues a series of commands to compile it. So this spec file has to build by hand (mostly copied from what Debian is doing). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460779] New: Review Request: nekovm - Neko embedded scripting language and virtual machine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nekovm - Neko embedded scripting language and virtual machine https://bugzilla.redhat.com/show_bug.cgi?id=460779 Summary: Review Request: nekovm - Neko embedded scripting language and virtual machine Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.annexia.org/tmp/ocaml/nekovm.spec SRPM URL: http://www.annexia.org/tmp/ocaml/nekovm-1.7.1-2.fc10.src.rpm Description: Neko embedded scripting language and virtual machine (This isn't really an OCaml package .. It's pure C, but used by another OCaml package called haXe which is coming along in a minute). rpmlint says: nekovm.i386: W: no-soname /usr/lib/libneko.so -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458204] Review Request: coredumper - Library to help applications create core dumps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458204 --- Comment #4 from Rakesh Pandit <[EMAIL PROTECTED]> 2008-08-31 14:53:49 EDT --- http://code.google.com/p/google-coredumper/source/detail?r=31 <-- Fixed upstream I have applied the same upstream patch to package(removing old patch). As soon as next version is released patch will be removed. Build successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=797003 SPEC: http://rakesh.fedorapeople.org/spec/coredumper.spec SRPM: http://rakesh.fedorapeople.org/srpm/coredumper-1.2.1-5.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459455] Review Request: fmit - Free Music Instrument Tuner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459455 --- Comment #5 from Kevin Fenzi <[EMAIL PROTECTED]> 2008-08-31 14:41:53 EDT --- Sorry for the delay here... OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: d8ec5246602b8933839fa8ec0d37df05 fmit-0.97.7.tar.bz2 d8ec5246602b8933839fa8ec0d37df05 fmit-0.97.7.tar.bz2.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. See below - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. The files here are all LGPLv2+ and GPLv2+ (they all have the 'or later' clause). So, the entire package as a whole would be 'GPLv2+' I think. Do you agree? 2. You need a rm -rf $RPM_BUILD_ROOT at the top of your %install section. 3. Any reason you are shipping your own desktop file instead of using the one provided by upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460724] Review Request: vhdl-mode - VHDL Mode in Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460724 Rakesh Pandit <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG --- Comment #1 from Rakesh Pandit <[EMAIL PROTECTED]> 2008-08-31 14:29:49 EDT --- It is already available. Wishlist had a wrong entry and without investigating I packaged it. :-/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 Devrim GUNDUZ <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #34 from Devrim GUNDUZ <[EMAIL PROTECTED]> 2008-08-31 14:25:38 EDT --- Thanks. Pushed package to repositories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460632] Review Request: ratbox-services - Service package for ircd-ratbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460632 --- Comment #4 from Lubomir Rintel <[EMAIL PROTECTED]> 2008-08-31 12:57:14 EDT --- Seems well, marek; Thanks! APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458440] Review Request: bluemindo - Simple audio player in python/GTK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458440 --- Comment #1 from Florent le Coz <[EMAIL PROTECTED]> 2008-08-31 12:47:25 EDT --- bump, nobody for a review ? ... note that python-tag problem is not a problem anymore for version 0.94 is now included in fedora repos. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460632] Review Request: ratbox-services - Service package for ircd-ratbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460632 Bug 460632 depends on bug 460538, which changed state. Bug 460538 Summary: Review Request: ircd-ratbox - Ircd-ratbox is an advanced, stable and fast ircd https://bugzilla.redhat.com/show_bug.cgi?id=460538 What|Old Value |New Value Status|NEW |CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458457] Review Request: grc - GUI for GNURadio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458457 Marek Mahut <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #14 from Marek Mahut <[EMAIL PROTECTED]> 2008-08-31 11:38:54 EDT --- Thank you both! Built and waiting in bodhi! \o/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460538] Review Request: ircd-ratbox - Ircd-ratbox is an advanced, stable and fast ircd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460538 Marek Mahut <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE --- Comment #8 from Marek Mahut <[EMAIL PROTECTED]> 2008-08-31 11:39:07 EDT --- Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460287] Review Request: htmlparser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460287 --- Comment #6 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-08-31 11:33:18 EDT --- (In reply to comment #4) > (In reply to comment #3) > > Well, > > * I cannot find any notes from the source codes which shows that this > > software > > can be > > licensed also under CPL. Are there any explicit declaration? > > Yes, it's in their website: http://htmlparser.sourceforge.net/license.html > > I've just investigated into the sources of the 2.0 snapshot and it includes > only the CPL. Seems they have changed for the new version. > > I'll remove the reference of CPL on 1.6. Well, this will cause problem as OmegaT is licensed under GPLv2+ while CPL is incompatible with GPL: http://fedoraproject.org/wiki/Licensing Currently htmlparser 1.6 is licensed under GPLv2+ so there is no problem, however for OmegaT you cannot use svn snapshot of htmlparser. Would you ask the upstream to change the license? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460287] Review Request: htmlparser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460287 --- Comment #5 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-08-31 11:04:59 EDT --- I could not find -3?? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460583] Review Request: up-imapproxy - University of Pittsburgh IMAP Proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460583 Rakesh Pandit <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE --- Comment #6 from Rakesh Pandit <[EMAIL PROTECTED]> 2008-08-31 10:13:30 EDT --- Build -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460583] Review Request: up-imapproxy - University of Pittsburgh IMAP Proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460583 --- Comment #5 from Rakesh Pandit <[EMAIL PROTECTED]> 2008-08-31 09:56:53 EDT --- SRPM: http://rakesh.fedorapeople.org/srpm/up-imapproxy-1.2.6-2.fc9.src.rpm SPEC: http://rakesh.fedorapeople.org/spec/up-imapproxy.spec Fixed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459878] Review Request: genome - Package for the Genome Project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459878 --- Comment #1 from Jeroen van Meeuwen <[EMAIL PROTECTED]> 2008-08-31 09:57:11 EDT --- All errors are eliminated, 6 warnings remain. New SPEC: http://www.kanarip.com/custom/SPECS/genome.spec New SRPM: http://www.kanarip.com/custom/f10/SRPMS/genome-1.1.0-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450243] Review Request: google-gadgets - Google Gadgets for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450243 Mamoru Tasaka <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #24 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-08-31 07:25:32 EDT --- Thanks. Now closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459148] Review Request: txt2rss - Convert from txt to rss
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459148 --- Comment #4 from Rakesh Pandit <[EMAIL PROTECTED]> 2008-08-31 07:23:27 EDT --- My patch for license block has been applied upstream: http://code.google.com/p/txt2rss/source/detail?r=6 http://code.google.com/p/txt2rss/source/browse/trunk/txt2rss Updated SPEC: http://rakesh.fedorapeople.org/spec/txt2rss.spec SRPM: http://rakesh.fedorapeople.org/srpm/txt2rss-0.1-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455187] Review Request: erlang-pgsql - Erlang PostgreSQL interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455187 --- Comment #12 from Fedora Update System <[EMAIL PROTECTED]> 2008-08-31 07:18:13 EDT --- erlang-pgsql-0-2.20080825svn.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/erlang-pgsql-0-2.20080825svn.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455187] Review Request: erlang-pgsql - Erlang PostgreSQL interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455187 --- Comment #13 from Fedora Update System <[EMAIL PROTECTED]> 2008-08-31 07:18:39 EDT --- erlang-pgsql-0-2.20080825svn.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/erlang-pgsql-0-2.20080825svn.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455187] Review Request: erlang-pgsql - Erlang PostgreSQL interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455187 Robert Scheck <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |CLOSED Fixed In Version||0-1.20080825svn Resolution||NEXTRELEASE --- Comment #9 from Robert Scheck <[EMAIL PROTECTED]> 2008-08-31 06:35:08 EDT --- Thanks for CVS. Peter, I can't see any missing/orphaned directories, even after installing the package and looking twice. Package: erlang-pgsql-0-1.20080825svn.fc8 Tag: dist-f8-updates-candidate Status: complete Package: erlang-pgsql-0-1.20080825svn.fc9 Tag: dist-f9-updates-candidate Status: complete Package: erlang-pgsql-0-1.20080825svn.fc10 Tag: dist-f10 Status: complete 81 (erlang-pgsql): Build on target fedora-5-epel succeeded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455187] Review Request: erlang-pgsql - Erlang PostgreSQL interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455187 --- Comment #10 from Fedora Update System <[EMAIL PROTECTED]> 2008-08-31 06:35:54 EDT --- erlang-pgsql-0-1.20080825svn.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/erlang-pgsql-0-1.20080825svn.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455187] Review Request: erlang-pgsql - Erlang PostgreSQL interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455187 --- Comment #11 from Fedora Update System <[EMAIL PROTECTED]> 2008-08-31 06:36:00 EDT --- erlang-pgsql-0-1.20080825svn.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/erlang-pgsql-0-1.20080825svn.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460287] Review Request: htmlparser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460287
--- Comment #4 from Ismael Olea <[EMAIL PROTECTED]> 2008-08-31 06:27:56 EDT ---
(In reply to comment #3)
> Well,
> * I cannot find any notes from the source codes which shows that this software
> can be
> licensed also under CPL. Are there any explicit declaration?
Yes, it's in their website: http://htmlparser.sourceforge.net/license.html
I've just investigated into the sources of the 2.0 snapshot and it includes
only the CPL. Seems they have changed for the new version.
I'll remove the reference of CPL on 1.6.
>
> * I forgot to say in my previous comment, howver for "unzip" command would you
> use
> "unzip -qq foo.zip" to suppress output? (for tar archive, rpmbuild uses "tar
> xf" and
>does not show the file list in the archive by default).
>
> * Also I forgot to say in my previous comment, however for cosmetic issue
> please unify macro usage like %{__unzip} (not %__unzip) if you use
> %{_javadir} (not %_javadir) and so on.
done
http://olea.org/tmp/htmlparser.spec
http://olea.org/paquetes-rpm/fedora-9/htmlparser-1.6-3olea.src.rpm
http://olea.org/paquetes-rpm/fedora-9/htmlparser-1.6-3olea.noarch.rpm
http://olea.org/paquetes-rpm/fedora-9/htmlparser-javadoc-1.6-3olea.noarch.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460690] Review Request: echo-artist - Automation tools for echo-icon-theme artists
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460690 --- Comment #1 from Luya Tshimbalanga <[EMAIL PROTECTED]> 2008-08-31 06:21:44 EDT --- Taking over that package for review that will come soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460690] Review Request: echo-artist - Automation tools for echo-icon-theme artists
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460690 Luya Tshimbalanga <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460629 Lubomir Rintel <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460629 --- Comment #8 from Lubomir Rintel <[EMAIL PROTECTED]> 2008-08-31 06:11:33 EDT --- Thanks; Imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454980] Review Request: axel - Download accelerator, wget replacement
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454980
--- Comment #10 from Michael Schwendt <[EMAIL PROTECTED]> 2008-08-31 05:22:30
EDT ---
> http://hubbitus.net.ru/rpm/Fedora9/axel/axel.spec
Don't use %configure but ./configure with proper arguments,
because this configure script is a custom one.
> %lang(de) %{_datadir}/locale/de/LC_MESSAGES/%{name}.mo
> %lang(nl) %{_datadir}/locale/nl/LC_MESSAGES/%{name}.mo
The proper way to include these files is the %find_lang macro:
%find_lang %{name}
somewhere at end of %install plus a change in the %files section,
%files -f %{name}.lang
and then don't include the .mo files manually.
> %{_mandir}/man1/axel.1.gz
Currently, it really is automatic .gz compression. Better use a
wildcard, so the package keeps building whenever the underlying
compression method changes:
%{_mandir}/man1/axel.1*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 460182] Review Request: python-virtualenv - Tool to create isolated Python environments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460182 --- Comment #6 from Parag AN(पराग) <[EMAIL PROTECTED]> 2008-08-31 04:47:02 EDT --- koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=796292 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439772] Review Request: x11vnc - VNC server for the current X11 session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439772 --- Comment #21 from Axel Thimm <[EMAIL PROTECTED]> 2008-08-31 03:47:08 EDT --- I think the choice to make minilzo a shared lib is probably not really what the authors of lzo or the consumer software intended. The idea was to have a one file statically swallowed in build procedures w/o any further ties to the lzo project. Now if the API/ABI of minilzo changes the other software is dependent on being patched up to work with it. Just looking at how this issue is holding up a useful package for 6 months (!) and the amount of patching one needs to remove the internal minilzo. I hardly think that upstream will accept any of this patching (did anyone try to send them upstream). Next updates of libvncserver/x11vnc will probably need to adjust/extend the minilzo patching again. And all that for blindly adhering to guidelines? I'm sure if presented to the FPC they would probably ack the use of minilzo as is. Fedora is currently even more upstream closer than 6 months before, so chances are that upstream proximity will win over other guidelines. And yes, I did have a check on how to remove minilzo in x11vnc and just see the work involved. Trivial OTOH, but not a small workload to maintain on the other. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
