[Bug 461757] Review Request: libdwarf - library for producing and consuming DWARF debugging information

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461757


Parag AN(पराग) [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #14 from Parag AN(पराग) [EMAIL PROTECTED]  2008-09-24 02:15:31 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=841274
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
180e1264b77070b4814882671c4e57ba  libdwarf-20080818.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libdwarf-0.20080818-4.fc10 =
  Provides: libdwarf.so.0
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) 
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) rtld(GNU_HASH)
+ Package libdwarf-devel-0.20080818-4.fc10 =
   Requires: libdwarf.so.0
+ Package libdwarf-dwarfdump-0.20080818-4.fc10 =
  Provides: config(libdwarf-dwarfdump) = 0.20080818-4.fc10
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdwarf.so.0
libelf.so.1 libelf.so.1(ELFUTILS_1.0) rtld(GNU_HASH)

Suggestions:-
  Good to see soname patch also applied in upstream.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459281] Review Request: corosync - The Corosync Cluster Engine

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459281


Steven Dake [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459281] Review Request: corosync - The Corosync Cluster Engine

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459281





--- Comment #9 from Steven Dake [EMAIL PROTECTED]  2008-09-24 02:37:34 EDT ---
New Package CVS Request
===
Package Name: corosync
Short Description: The Corosync Cluster Engine
Owners: sdake
Branches: F-10 Rawhide
InitialCC: sdake

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461899] Review Request: thebridge - ILink/EchoLink compatible conference bridge

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461899


Lucian Langa [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #1 from Lucian Langa [EMAIL PROTECTED]  2008-09-24 02:50:07 EDT 
---
*** Bug 463590 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463590] Review Request: thebridge - Echolink Ham Radio conference server

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463590


Lucian Langa [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||[EMAIL PROTECTED]
 Resolution||DUPLICATE




--- Comment #1 from Lucian Langa [EMAIL PROTECTED]  2008-09-24 02:50:07 EDT 
---
There's already a request for this package:

https://bugzilla.redhat.com/show_bug.cgi?id=461899


please read https://fedoraproject.org/wiki/PackageMaintainers/Join before
submitting package for review !!!

*** This bug has been marked as a duplicate of 461899 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459915] Review Request: freedink-data - Adventure and role-playing game (data)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459915





--- Comment #7 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 02:52:47 EDT 
---
Please change the release number every time you modify your spec file
to avoid confusion.

https://fedoraproject.org/wiki/Packaging/FrequentlyMadeMistakes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459908] Review Request: freedink - Adventure and role-playing game (engine)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459908





--- Comment #24 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 02:52:51 EDT 
---
Please change the release number every time you modify your spec file
to avoid confusion.

https://fedoraproject.org/wiki/Packaging/FrequentlyMadeMistakes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463570] Review Request: hunspell-ro - Romanian hunspell dictionaries

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463570


Caolan McNamara [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Caolan McNamara [EMAIL PROTECTED]  2008-09-24 02:57:53 
EDT ---
New Package CVS Request
===
Package Name: hunspell-ro
Short Description: Romanian hunspell dictionaries
Owners: caolanm
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459915] Review Request: freedink-data - Adventure and role-playing game (data)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459915





--- Comment #8 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 03:02:18 EDT 
---
Also please write in %changelog what you modified even during review request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463571] Review Request: hunspell-oc - Occitan hunspell dictionary

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463571





--- Comment #2 from Caolan McNamara [EMAIL PROTECTED]  2008-09-24 03:04:17 
EDT ---
Through the URL: field. Visit
https://addons.mozilla.org/en-US/firefox/addon/8235 and choose add and it
will EULA-style present the GPLv3 for agreement

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459908] Review Request: freedink - Adventure and role-playing game (engine)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459908





--- Comment #25 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 03:02:38 EDT 
---
Also please write in %changelog what you modified even during review request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 458449] Review Request: perl-Log-TraceMessages - Perl extension for trace messages used in debugging

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458449





--- Comment #5 from Parag AN(पराग) [EMAIL PROTECTED]  2008-09-24 03:16:07 EDT 
---
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459915] Review Request: freedink-data - Adventure and role-playing game (data)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459915





--- Comment #9 from Sylvain Beucler [EMAIL PROTECTED]  2008-09-24 03:34:54 
EDT ---
http://www.freedink.org/snapshots/fedora-review/freedink-data.spec
http://www.freedink.org/snapshots/fedora-review/freedink-data-1.08.20080920-3.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459908] Review Request: freedink - Adventure and role-playing game (engine)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459908





--- Comment #26 from Sylvain Beucler [EMAIL PROTECTED]  2008-09-24 03:38:58 
EDT ---
http://www.freedink.org/snapshots/fedora-review/freedink.spec
http://www.freedink.org/snapshots/fedora-review/freedink-1.08.20080920-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 458449] Review Request: perl-Log-TraceMessages - Perl extension for trace messages used in debugging

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458449


Parag AN(पराग) [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463571] Review Request: hunspell-oc - Occitan hunspell dictionary

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463571


Parag AN(पराग) [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Parag AN(पराग) [EMAIL PROTECTED]  2008-09-24 03:43:48 EDT 
---
Thanks. I got it now.

Review:
+ package builds in mock.
 Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=841272
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
5840555e0793484df26a340a6906e6b5  occitan-languedocien-0.5-fx+tb+sm.xpi
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459281] Review Request: corosync - The Corosync Cluster Engine

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459281





--- Comment #10 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED]  2008-09-24 
03:56:04 EDT ---
(In reply to comment #9)
 New Package CVS Request
 ===
 Package Name: corosync
 Short Description: The Corosync Cluster Engine
 Owners: sdake
 Branches: F-10 Rawhide
there is no F-10 Rawhide branch, the rawhide branch is called devel do you
want me to go ahead with this?

 InitialCC: sdake

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459916] Review Request: freedink-dfarc - Frontend and .dmod installer for GNU FreeDink

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459916


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #19 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 04:00:14 EDT 
---
(In reply to comment #18)
 By the way, under F9 and mock, I keep getting rpmlint errors about g+w
 directories:
 freedink-dfarc.i386: E: non-standard-dir-perm
 /usr/share/doc/freedink-dfarc-3.2.1 02755

I don't get such strange behavoir...

For 3.2.1-1:

* scriptlet
---
%post
#
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
update-desktop-database  /dev/null || :
#
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
  %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
# http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo
!!! update-mime-database %{_datadir}/mime  /dev/null || :
fi
---
The line marked as !!! is inside of if-fi structure (same for %postun)

* macros in comment
---
# Don't install desktop files, use %post instead
---
  - In the comment (and %changelog), use %% instead of % to avoid
unwanted macros expansion.

* %changelog
  - Please keep the old %changelog entry

Fix the issues above, all others are good.

-
This package (freedink-dfarc) is APPROVED by mtasaka
-

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from Get a Fedora Account.
After you request for sponsorship a mail will be sent to sponsor 
members automatically (which is invisible for you) which notifies 
that you need a sponsor. After that, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 8/9, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459281] Review Request: corosync - The Corosync Cluster Engine

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459281





--- Comment #11 from Steven Dake [EMAIL PROTECTED]  2008-09-24 04:02:44 EDT 
---
yes please.  I apologize for the confusion.  I didn't relize the trunk was
called devel.

Thanks
-steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 458449] Review Request: perl-Log-TraceMessages - Perl extension for trace messages used in debugging

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458449


Nicolas Chauvet (kwizart) [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #6 from Nicolas Chauvet (kwizart) [EMAIL PROTECTED]  2008-09-24 
04:06:07 EDT ---
New Package CVS Request
===
Package Name: perl-Log-TraceMessages
Short Description: Perl extension for trace messages used in debugging
Owners: kwizart
Branches: F-8 F-9 EL-4 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459908] Review Request: freedink - Adventure and role-playing game (engine)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459908





--- Comment #27 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 04:17:59 EDT 
---
Rebuild failed:
http://koji.fedoraproject.org/koji/taskinfo?taskID=841506

! build.log shows some stange error comment:
  http://koji.fedoraproject.org/koji/getfile?taskID=841508name=build.log
--
ENTER do(['bash', '--login', '-c', 'rpmbuild -bs --target x86_64 --nodeps
builddir/build/SPECS/freedink.spec'], False,
'/var/lib/mock/dist-f10-build-261193-47237/root/', None, 86400, True, 0, 101,
102, None, logger=mock.trace_decorator.getLog object at 0x2b90b825bf90)
Executing command: ['bash', '--login', '-c', 'rpmbuild -bs --target x86_64
--nodeps builddir/build/SPECS/freedink.spec']
/etc/profile: line 42: /bin/hostname: No such file or directory
error: line 67: second %install
--
  Perhaps this is because %install in comment is not protected by %% properly
  (see my comment: bug 459916 comment 19)

Some quick note (I have not checked yet because the srpm does not build)

* EVR dependency
--
Requires: freedink-engine=%{version}-%{release} freedink-dfarc
--
  - This will make freedink require the rpm named
freedink-engine=1.08.20080920-2.fc10
(then cannot be installed), i.e. spaces needed between equality.

* update-desktop-database
  - is needed when desktop files contains MimeType information (i.e.
MimeType=application/x-dmod;
like freedink-dfarc.desktop).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459281] Review Request: corosync - The Corosync Cluster Engine

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459281





--- Comment #12 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED]  2008-09-24 
04:23:57 EDT ---
cvs is done
Please check if everything is ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459281] Review Request: corosync - The Corosync Cluster Engine

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459281


Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451189] Review Request: rancid - Really Awesome New Cisco confIg Differ

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451189


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

 Depends on||455713




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463217] Review Request: gnuplot-py - Python interface to Gnuplot

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463217





--- Comment #3 from Sergio Pascual [EMAIL PROTECTED]  2008-09-24 04:31:22 EDT 
---
(In reply to comment #1)

Thanks for your ccomments!

 Your spec file is missing at least:
 
 BuildRequires: numpy
 

The package builds ok as it is in mock. I think the dependency I have to add is 
Requires: numpy


 The way you've elected to remove the shebang from various files updates the
 timestamps on those files.  It is (arguably) better to use a method that
 retains the original timestamps.  E.g.:
 
 for F in demo.py utils.py __init__.py test.py funcutils.py; do
   %{__sed} -i.orig -e 1d ${F}
   touch -r ${F}.orig ${F}
   rm ${F}.orig
 done
 
 You should ask upstream to remove the shebangs from the files in question, and
 note in the spec file that you have done so.  See:
 
 https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

I see, I will tell upstream and submit a new specfile

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459908] Review Request: freedink - Adventure and role-playing game (engine)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459908





--- Comment #28 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 04:37:27 EDT 
---
(In reply to comment #23)
 I have a question: the 'freedink' package is built as 'i386' instead of
 'noarch' (E: no-binary). I couldn't find a way to use a different BuildArch 
 for
 the 2 packages though.

Please ignore this rpmlint for this case.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 458686] Review Request: bluez - Bluetooth libraries and utilities

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458686


Bastien Nocera [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #12 from Bastien Nocera [EMAIL PROTECTED]  2008-09-24 04:46:55 
EDT ---
Uploaded and built 2 weeks ago, closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463570] Review Request: hunspell-ro - Romanian hunspell dictionaries

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463570





--- Comment #3 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED]  2008-09-24 
04:51:39 EDT ---
cvs done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461131] Review Request: sim - Simple Instant Messenger

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461131





--- Comment #19 from Marcela Maslanova [EMAIL PROTECTED]  2008-09-24 04:54:14 
EDT ---
Please attach the final srpm for another check. 

If noone other will be interested in review, I can do it. I'm really looking
forward to have sim in repo instead of building it myself ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463570] Review Request: hunspell-ro - Romanian hunspell dictionaries

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463570


Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 458449] Review Request: perl-Log-TraceMessages - Perl extension for trace messages used in debugging

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458449





--- Comment #7 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED]  2008-09-24 
04:56:19 EDT ---
cvs done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 458449] Review Request: perl-Log-TraceMessages - Perl extension for trace messages used in debugging

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458449


Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454102] Review Request: perl-Catalyst-Model-XMLRPC - XMLRPC model class for Catalyst

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454102





--- Comment #10 from Miroslav Suchy [EMAIL PROTECTED]  2008-09-24 05:07:04 
EDT ---
But why you include t/ in %doc in first place? There is no documentation in
that test. And test alone should not be packed (however no policy define it -
it is just common habit). 
And if you do not include t/ = you will not get the false provides = you must
not do that magic with %{__perl_provides} = you will get rid of that warning
propper way.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461131] Review Request: sim - Simple Instant Messenger

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461131





--- Comment #20 from Pavel Alexeev [EMAIL PROTECTED]  2008-09-24 05:16:26 EDT 
---
An(In reply to comment #19)
 Please attach the final srpm for another check. 

I have been mistaked what original src.rpm also available from koji. Sory.

http://hubbitus.net.ru/rpm/Fedora9/sim/sim-0.9.5-0.3.20080923svn2261rev.src.rpm

Separate spec url is old ( http://hubbitus.net.ru/rpm/Fedora9/sim/sim.spec )

 If noone other will be interested in review, I can do it. I'm really looking
 forward to have sim in repo instead of building it myself ;-)
As I can see, none of fedora‑review flag set on this request, so, I think you
can review it if you want.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 455165] Review-Request: maatkit - Essential command-line utilities for MySQL

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455165





--- Comment #3 from Lubomir Rintel [EMAIL PROTECTED]  2008-09-24 05:47:43 EDT 
---
(In reply to comment #2)
 Two issues so far:
 
 1. the backticks in perl(:MODULE_COMPAT... should be replaced by code/code
to make it more readable (and compliant to the perl packaging guidelines).

That certainly won't work, and seems to me like an issue with wiki formatting
conversion when replacing moin with mediawiki. I've told spot to fix it.

 2. the resulting package doesn't install under r9/f10 - the requires needs to
 be changed to perl(DBD::mysql)

Thanks for pointing that out!
Fixed package:

SRPM: http://netbsd.sk/~lkundrak/SRPMS/maatkit-1972-3.el5.src.rpm
SPEC: http://netbsd.sk/~lkundrak/SPECS/maatkit.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463570] Review Request: hunspell-ro - Romanian hunspell dictionaries

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463570


Caolan McNamara [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463571] Review Request: hunspell-oc - Occitan hunspell dictionary

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463571


Caolan McNamara [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Caolan McNamara [EMAIL PROTECTED]  2008-09-24 05:56:30 
EDT ---
New Package CVS Request
===
Package Name: hunspell-oc
Short Description: Occitan hunspell dictionary
Owners: caolanm
Branches:
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463571] Review Request: hunspell-oc - Occitan hunspell dictionary

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463571





--- Comment #5 from Huzaifa S. Sidhpurwala [EMAIL PROTECTED]  2008-09-24 
06:32:23 EDT ---
cvs done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463571] Review Request: hunspell-oc - Occitan hunspell dictionary

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463571


Huzaifa S. Sidhpurwala [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461131] Review Request: sim - Simple Instant Messenger

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461131


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




--- Comment #21 from Marcela Maslanova [EMAIL PROTECTED]  2008-09-24 07:43:31 
EDT ---
rpmlint find some problems:
sim.i386: E: zero-length /usr/share/doc/sim-0.9.5/AUTHORS
You can remove AUTHORS from rpm, before packaging.

sim.i386: W: incoherent-version-in-changelog 0.9.5-0.4.20080923svn2261rev
0.9.5-0.3.20080923svn2261rev
You've forgotten change release macron in the head of specfile.

sim.src:131: W: macro-in-%changelog _datadir
sim.src:134: W: macro-in-%changelog _libdir
The macro in changelog shouldn't be used.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463571] Review Request: hunspell-oc - Occitan hunspell dictionary

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463571


Caolan McNamara [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459883] Review Request: rubygem-git - A package for using Git in Ruby code

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459883





--- Comment #7 from Jeroen van Meeuwen [EMAIL PROTECTED]  2008-09-24 07:57:34 
EDT ---
The ruby build requires is implicit in the BuildRequires: rubygems, and as such
has been accepted before.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461131] Review Request: sim - Simple Instant Messenger

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461131





--- Comment #22 from Marcela Maslanova [EMAIL PROTECTED]  2008-09-24 08:07:22 
EDT ---
- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (GPLv2+ ) OK, text in %doc, matches source OK
- spec file legible, in am. english OK probably
- source matches upstream OK
- package compiles on devel (x86) OK
- no missing BR OK
- no unnecessary BR OK
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- no need for -docs OK
- nothing in %doc affects runtime OK

Source should be changed on something which could be downloaded from home page
of project.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 213662] Review Request: openmpi - Upstream MPI package with native InfiniBand support

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=213662


Jussi Lehtola [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #2 from Jussi Lehtola [EMAIL PROTECTED]  2008-09-24 08:54:15 EDT 
---
Now that OpenMPI includes InfiniBand support, I think it should be switched
off. The IB stack adds unnecessary overhead, since 99.9% of users don't have
InfiniBand hardware. And the people who *do* have InfiniBand often don't use
Fedora/RHEL, but some specialized cluster distribution instead. (Who would want
to reinstall the cluster OS every year or so?)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 213662] Review Request: openmpi - Upstream MPI package with native InfiniBand support

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=213662





--- Comment #3 from Doug Ledford [EMAIL PROTECTED]  2008-09-24 09:20:24 EDT 
---
The transport portion of the openmpi package is completely modular.  When you
aren't using IB, the IB module isn't even loaded, and hence doesn't slow
anything down.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463226] Review Request: Appliance Configuration Engine

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463226





--- Comment #3 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:25:13 EDT 
---
Thank you both for the comments. I have made the changes and uploaded the new
files. 

Spec URL: http://bkearney.fedorapeople.org/ace.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-0.0.3-3.fc9.src.rpm

rmlint clean
builds clean in koji for f9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463231] Review Request: ACE Basic Site Module

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463231





--- Comment #1 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:29:33 EDT 
---
Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-basic-site.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-basic-site-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463232] Review Request: ACE Console Module

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463232





--- Comment #1 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:30:23 EDT 
---
Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-console.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-console-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463227] Review Request: ACE Apache module

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463227





--- Comment #1 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:27:25 EDT 
---
Updated files based on review of the ace package. 

Spec URL: http://bkearney.fedorapeople.org/ace-apache.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-apache-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463229] Review Request: ACE Banners Module

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463229





--- Comment #4 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:28:55 EDT 
---
Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-banners.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-banners-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463236] Review Request: ACE PHP module

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463236





--- Comment #1 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:31:18 EDT 
---
Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-php.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-php-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463436] Review Request: purple-facebookchat - libpurple plug-in supporting facebook IM

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463436





--- Comment #2 from Dan Horák [EMAIL PROTECTED]  2008-09-24 09:31:23 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
 4cfe2c464158b6418889d22e2035a0f8ad15b527 
pidgin-facebookchat-source-1.35.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
BAD compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- you are not passing the CFLAGS=$RPM_OPT_FLAGS as a parameter to make
- you should remove the source archive creation from the all target in your
makefile
- I would not compress the updated makefile

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463235] Review Request: ACE Mysql module

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463235





--- Comment #1 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:30:51 EDT 
---
Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-mysql.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-mysql-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463241] Review Request: ACE Postgres module

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463241





--- Comment #1 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:31:51 EDT 
---
Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-postgres.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-postgres-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463242] Review Request: ACE ssh module

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463242





--- Comment #1 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:32:38 EDT 
---
Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-ssh.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-ssh-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463233] Review Request: Web App for Appliance Management

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463233





--- Comment #1 from Bryan Kearney [EMAIL PROTECTED]  2008-09-24 09:35:38 EDT 
---
Updated the packages per the review of the ace pakacge

Spec URL: http://bkearney.fedorapeople.org/ace-console-wui.spec
SRPM URL: http://bkearney.fedorapeople.org/ace-console-wui-0.0.3-3.fc9.src.rpm

rpmlint clean
koji build clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463744] New: Review Request: screenruler - GNOME screen ruler

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: screenruler - GNOME screen ruler

https://bugzilla.redhat.com/show_bug.cgi?id=463744

   Summary: Review Request: screenruler - GNOME screen ruler
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: ftp://czar.eas.yorku.ca/pub/gruler/screenruler.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/gruler/screenruler-0.85-1.fc10.src.rpm
Description: Screenruler is a small GNOME based utility that allows you to
measure objects 
on your desktop. It can be used to take both horizontal and vertical
measurement
in 6 different metrics: pixels, centimeters, inches, picas, points, and as a
percentage of the ruler’s length.

NOTE: This is not really a new package, it is a rename of the current gruler
package (upstream just settled on a new name).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225706] Merge Review: dos2unix

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225706


Tim Waugh [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #9 from Tim Waugh [EMAIL PROTECTED]  2008-09-24 10:57:53 EDT ---
Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463211] Review Request: notify-sharp - A C# implementation for Desktop Notifications

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463211





--- Comment #4 from Sindre Pedersen Bjørdal [EMAIL PROTECTED]  2008-09-24 
11:18:34 EDT ---
Here's the updated package, all rpmlint issues resolved. Haven't done anything
against the gnome-do build issue, I'm waiting on clarification on policy for
this one. 

Updated packages:

Spec URL: http://sindrepb.fedorapeople.org/packages/notify-sharp.spec
SRPM URL:
http://sindrepb.fedorapeople.org/packages/notify-sharp-0.4.0-0.2.20080912svn.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454462] Review Request: ksplice - Patching a Linux kernel without reboot

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454462


Thomas Moschny [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #23 from Thomas Moschny [EMAIL PROTECTED]  2008-09-24 11:17:31 
EDT ---
In addition to the review done earlier:

[x] latest version is packaged (0.9.0)

[x] source files match upstream
md5sum: 33934d125cdc050cd68f8ea34f1f4f23

[x] package builds at least on one architecture
tested on: f9/i386, f9/x86_64, f10/all

[!] final provides/requires look sane
- the rsync dependency can be dropped
- the perl module has been renamed (capitalized), please filter
  perl(Ksplice) now

[!] patches should have a comment about upstream status
- did you sent the zlib patch upstream? please add a note
  explaining the status

The package is APPROVED, iff you fix these three (minor) issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459883] Review Request: rubygem-git - A package for using Git in Ruby code

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459883





--- Comment #8 from Jonathan Roberts [EMAIL PROTECTED]  2008-09-24 11:30:57 
EDT ---
OK, cool with me then. But like I said, I don't have the ability to set + tag
on fedora-review, so someone else will need to look into that. In the meantime,
I'll look into getting the ability to set + tags!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463211] Review Request: notify-sharp - A C# implementation for Desktop Notifications

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463211





--- Comment #5 from Michel Alexandre Salim [EMAIL PROTECTED]  2008-09-24 
11:47:29 EDT ---
Well, just mentioning gnome-do because it's one way to test that notify-sharp
works. Actually, my build of gnome-do works, but applications are not
displayed. Anyway, not for here.

You still need to patch notify-sharp.pc.in -- right now it's expanding libdir
to %{prefix}/lib rather than %{libdir}, so applications compiling against
notify-sharp that uses pkgconfig to find the installed libraries would fail to
compile on lib64 systems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463761] New: Package review: perl-File-Find-Rule-VCS

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-File-Find-Rule-VCS

https://bugzilla.redhat.com/show_bug.cgi?id=463761

   Summary: Package review: perl-File-Find-Rule-VCS
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: low
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Description:
Many tools need to be equally useful both on ordinary files, and on code
that has been checked out from revision control systems.

http://mmaslano.fedorapeople.org/perl-File-Find-Rule-VCS/perl-File-Find-Rule-VCS-1.04-1.fc9.src.rpm
http://mmaslano.fedorapeople.org/perl-File-Find-Rule-VCS/perl-File-Find-Rule-VCS.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463762] New: Package review: perl-Module-Extract

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-Module-Extract

https://bugzilla.redhat.com/show_bug.cgi?id=463762

   Summary: Package review: perl-Module-Extract
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Description:
Module::Extract is a convenience base class for creating module that work
with Perl distributions.

http://mmaslano.fedorapeople.org/perl-Module-Extract/perl-Module-Extract-0.01-1.fc9.src.rpm
http://mmaslano.fedorapeople.org/perl-Module-Extract/perl-Module-Extract.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463764] New: Package review: perl-Module-Manifest

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-Module-Manifest

https://bugzilla.redhat.com/show_bug.cgi?id=463764

   Summary: Package review: perl-Module-Manifest
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


description
Module::Manifest is a simple utility module created originally for use in
Module::Inspector.

http://mmaslano.fedorapeople.org/perl-Module-Manifest/perl-Module-Manifest.spec
http://mmaslano.fedorapeople.org/perl-Module-Manifest/perl-Module-Manifest-0.03-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463763] New: Package review: perl-Module-Inspector

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-Module-Inspector

https://bugzilla.redhat.com/show_bug.cgi?id=463763

   Summary: Package review: perl-Module-Inspector
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


description
An entire ecosystem of CPAN modules exist around the files and formats
relating to the CPAN itself. Parsers and object models for various
different types of files have been created over the years by various people
for various projects.
http://mmaslano.fedorapeople.org/perl-Module-Inspector/perl-Module-Inspector.spec
http://mmaslano.fedorapeople.org/perl-Module-Inspector/perl-Module-Inspector-1.05-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463766] New: Package review: perl-Wx-Perl-Dialog

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-Wx-Perl-Dialog

https://bugzilla.redhat.com/show_bug.cgi?id=463766

   Summary: Package review: perl-Wx-Perl-Dialog
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


description
Alien::WxWidgets Wx Wx::Perl::Dialog

http://mmaslano.fedorapeople.org/perl-Wx-Perl-Dialog/perl-Wx-Perl-Dialog.spec
http://mmaslano.fedorapeople.org/perl-Wx-Perl-Dialog/perl-Wx-Perl-Dialog-0.01-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463767] New: Review Request: cloog - The Chunky Loop Generator

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: cloog - The Chunky Loop Generator

https://bugzilla.redhat.com/show_bug.cgi?id=463767

   Summary: Review Request: cloog - The Chunky Loop Generator
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.seketeli.org/dodji/rpms/cloog/cloog.spec
SRPM URL:
http://www.seketeli.org/dodji/rpms/cloog/cloog-0.15-0.1.git95753.fc9.src.rpm

Description:

CLooG is a software which generates loops for scanning Z-polyhedra. That is,
CLooG finds the code or pseudo-code where each integral point of one or more
parametrized polyhedron or parametrized polyhedra union is reached. CLooG is
designed to avoid control overhead and to produce a very efficient code.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463436] Review Request: purple-facebookchat - libpurple plug-in supporting facebook IM

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463436





--- Comment #3 from Matej Cepl [EMAIL PROTECTED]  2008-09-24 12:12:00 EDT ---
SRPMS:
http://mcepl.fedorapeople.org/rpms/purple-facebookchat-1.35-4.fc10.src.rpm
with the reviewr's changes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463771] New: Package review: perl-Probe-Perl

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-Probe-Perl

https://bugzilla.redhat.com/show_bug.cgi?id=463771

   Summary: Package review: perl-Probe-Perl
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


description
This module provides methods for obtaining information about the currently
running perl interpreter. It originally began life as code in the
Module::Build project, but has been externalized here for general use.

http://mmaslano.fedorapeople.org/perl-Probe-Perl/perl-Probe-Perl.spec
http://mmaslano.fedorapeople.org/perl-Probe-Perl/perl-Probe-Perl-0.01-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463767] Review Request: cloog - The Chunky Loop Generator

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463767


Dodji Seketeli [EMAIL PROTECTED] changed:

   What|Removed |Added

 Depends on||463742




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463770] New: Package review: perl-Module-Math-Depends

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-Module-Math-Depends

https://bugzilla.redhat.com/show_bug.cgi?id=463770

   Summary: Package review: perl-Module-Math-Depends
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


description
This is a small convenience module created originally as part of
Module::Inspector but released seperately, in the hope that people might
find it useful in other contexts.

http://mmaslano.fedorapeople.org/perl-Module-Math-Depends/perl-Module-Math-Depends.spec
http://mmaslano.fedorapeople.org/perl-Module-Math-Depends/perl-Module-Math-Depends-0.02-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463768] New: Package review: perl-PAR

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-PAR

https://bugzilla.redhat.com/show_bug.cgi?id=463768

   Summary: Package review: perl-PAR
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


description
This module lets you use special zip files, called Perl Archives, as
libraries from which Perl modules can be loaded.

http://mmaslano.fedorapeople.org/perl-PAR/perl-PAR.spec
http://mmaslano.fedorapeople.org/perl-PAR/perl-PAR-0.983-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463769] New: Package review: perl-PAR-Dist

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: perl-PAR-Dist

https://bugzilla.redhat.com/show_bug.cgi?id=463769

   Summary: Package review: perl-PAR-Dist
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
 QAContact: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED], fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


description
This module creates and manipulates PAR distributions. They are architecture-
specific PAR files, containing everything under blib/ of CPAN distributions
after their make or Build stage, a META.yml describing metadata of the
original CPAN distribution, and a MANIFEST detailing all files within it.
Digitally signed PAR distributions will also contain a SIGNATURE file.

http://mmaslano.fedorapeople.org/perl-PAR-Dist/perl-PAR-Dist.spec
http://mmaslano.fedorapeople.org/perl-PAR-Dist/perl-PAR-Dist-0.33-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463767] Review Request: cloog - The Chunky Loop Generator

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463767


Petr Machata [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 Blocks||177841




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463436] Review Request: purple-facebookchat - libpurple plug-in supporting facebook IM

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463436


Dan Horák [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Dan Horák [EMAIL PROTECTED]  2008-09-24 12:24:57 EDT ---
All issues are fixed, so this package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463770] Package review: perl-Module-Math-Depends

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463770


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||463763




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463762] Package review: perl-Module-Extract

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463762


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||463763




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463764] Package review: perl-Module-Manifest

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463764


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||463763




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463761] Package review: perl-File-Find-Rule-VCS

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463761


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||457517




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463763] Package review: perl-Module-Inspector

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463763


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Depends on||463762, 463764, 463770




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457517


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Depends on||463761, 463763




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463763] Package review: perl-Module-Inspector

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463763


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||457517




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463211] Review Request: notify-sharp - A C# implementation for Desktop Notifications

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463211





--- Comment #6 from Sindre Pedersen Bjørdal [EMAIL PROTECTED]  2008-09-24 
12:20:35 EDT ---
Added patch:

Updated packages:

Spec URL: http://sindrepb.fedorapeople.org/packages/notify-sharp.spec
SRPM URL:
http://sindrepb.fedorapeople.org/packages/notify-sharp-0.4.0-0.3.20080912svn.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463768] Package review: perl-PAR

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463768


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||457517




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463766] Package review: perl-Wx-Perl-Dialog

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463766


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||457517




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463771] Package review: perl-Probe-Perl

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463771


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||457517




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457517


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Depends on||463768, 463771, 463766




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463769] Package review: perl-PAR-Dist

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463769


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Blocks||463768




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463768] Package review: perl-PAR

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463768


Marcela Maslanova [EMAIL PROTECTED] changed:

   What|Removed |Added

 Depends on||463769




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463769] Package review: perl-PAR-Dist

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463769


Dan Horák [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||[EMAIL PROTECTED]
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 459915] Review Request: freedink-data - Adventure and role-playing game (data)

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459915


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #10 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 12:44:01 EDT 
---
Okay, good.

(In reply to comment #6)
  * Also adding files under licenses/ to %doc is necessary.
 
 Is it OK to add the licenses/ directory directly?
   - Sure. Now please also fix licenses/oal-1-0-1.txt CRLF line terminators

-
   This package (freedink-data) is APPROVED by mtasaka
-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454025] Review Request: libixp - stand-alone client/server 9P library including ixpc client

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454025


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks|177841  |201449
 Resolution||NOTABUG
   Flag|fedora-review?, |
   |needinfo?([EMAIL PROTECTED] |
   |oject.org)  |




--- Comment #11 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 12:47:43 EDT 
---
Closing.

If someone wants to import this package into Fedora, please submit a new
review request and make this bug as a duplicate of the new one.

Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463769] Package review: perl-PAR-Dist

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463769





--- Comment #1 from Dan Horák [EMAIL PROTECTED]  2008-09-24 12:49:11 EDT ---
few notes
- remove the CHECK function from the value of the License tag
- probably missing BR: perl(Test-More) - test compilation is failing with
Can't locate Test/More.pm in @INC

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453519] Review Request: UnihanDb - The Unihan character database in 5NF

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453519





--- Comment #18 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 12:51:29 EDT 
---
ping again??

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460289] Review Request: vldocking

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460289


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||needinfo?([EMAIL PROTECTED])




--- Comment #11 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 12:52:56 EDT 
---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 438543] Review Request: Synopsis - Source-code introspection tool.

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=438543





--- Comment #48 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 12:52:07 EDT 
---
ping again?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461728] Review Request: fet - Open source free timetabling software

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461728


Mamoru Tasaka [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||needinfo?([EMAIL PROTECTED])




--- Comment #6 from Mamoru Tasaka [EMAIL PROTECTED]  2008-09-24 12:53:21 EDT 
---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461728] Review Request: fet - Open source free timetabling software

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461728


Balint Cristian [EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|needinfo?([EMAIL PROTECTED])   |fedora-cvs?




--- Comment #7 from Balint Cristian [EMAIL PROTECTED]  2008-09-24 13:15:20 
EDT ---
New Package CVS Request
===
Package Name: fet
Short Description: Open source free timetabling software
Owners: rezso
Branches: F-8 F-9 devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 461897] Review Request: opticalraytracer - OpticalRayTracer is a Linux utility that analyzes systems of lenses

2008-09-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461897





--- Comment #2 from Milos Jakubicek [EMAIL PROTECTED]  2008-09-24 13:16:40 
EDT ---
(In reply to comment #1)
 Please remove the leading blank line in %description, I am not sure it would
 look well in GUI tools. 

Done.

 Description probably needs some more love -- the fact
 that the package is free doesn't need to be mentioned there (redundant, see
 License tag) and X windows is correctly spelled without the trailing s and
 with w capitablized: X Window, X Window System, or just X11.

Yep, sorry for that, I've just copied and pasted it from the author's webpages.

 It's not clear what does this line do, and why does it belong to %prep. Please
 explain and add a comment:
 make -f Makefile.cvs dist

This is now not necessary anymore thanks to fast upstream reaction. Also, my
patch for 64bit systems has been merged and new version released (how nice!:).

 What's %{_datadir}/apps? Would not %{_datadir}/raytracer be more
 appropriate? In case not, please ensure you depend on the package that creates
 it or own it.
 %{_datadir}/apps/raytracer/

Look like a standard path for KDE apps. It should be ok as opticalraytracer
depends on kdelibs3 which in turn depends on kde-filesystem which owns
%{datadir}/apps. The same applies for %{docdir}/HTML/en where newly some files
are stored too.

Note: rpmlint is silent on spec file and SRPM, but not on RPMs:

rpmlint -i opticalraytracer-1.2-1.fc9.x86_64.rpm
opticalraytracer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/en/raytracer/common ../common
The relative symbolic link points nowhere.

I don't know whether I can avoid this somehow, the pointed directory is owned
by kdelibs-common which is also a dependency of kdelibs3, hence this shouldn't
be IMHO a problem.

New SPEC file:
http://mjakubicek.fedorapeople.org/opticalraytracer/opticalraytracer.spec
New SRPM:
http://mjakubicek.fedorapeople.org/opticalraytracer/opticalraytracer-1.2-1.fc9.src.rpm
(there are also x68_64 RPMs in the same dir)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   3   >