[Bug 464050] Package Review Request for projectM-libvisual
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464050 --- Comment #11 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-15 02:23:53 EDT --- projectM-libvisual-1.2.0-4.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/projectM-libvisual-1.2.0-4.fc8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471522] Review Request: OTL - OTL library for database connections and queries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471522 --- Comment #3 from Hayden James <[EMAIL PROTECTED]> 2008-11-15 02:00:20 EDT --- Ok, fixed above: http://hayden.doesntexist.com/~hjames/otl-devel.spec http://hayden.doesntexist.com/~hjames/otl-devel-4.0.176-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468128] Review Request: python-flickrapi - Python module for interfacing with the Flickr API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468128 Ian Weller <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Ian Weller <[EMAIL PROTECTED]> 2008-11-15 00:06:20 EDT --- CVS Admin: So this should be interesting, since Kushal has gotten this package approved and CVS branched but has effectively given up maintaining the package (see bug 457690). I'll consider it a change request. Package Change Request == Package Name: python-flickrapi Updated Description: Python module for interfacing with the Flickr API Owners: ianweller -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455581 --- Comment #5 from Itamar Reis Peixoto <[EMAIL PROTECTED]> 2008-11-14 19:26:02 EDT --- I am now sponsored, this package is now only waiting for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455581 Itamar Reis Peixoto <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|177841 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466953] Review Request: perl-NOCpulse-Utils - NOCpulse utility packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466953 Chris Weyl <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Chris Weyl <[EMAIL PROTECTED]> 2008-11-14 17:32:52 EDT --- Hmm, interesting. Since we (Fedora) appear to be upstream, why not include a Makefile.PL setup? This would allow this package to be consistent with the zillions of other Perl package out there, and make everyone's tasks way easier over the long run :-) (See, e.g., Module::Install for a quick, easy, modern way to setup the standard Perl module build/test/install framework.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466953] Review Request: perl-NOCpulse-Utils - NOCpulse utility packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466953 Chris Weyl <[EMAIL PROTECTED]> changed: What|Removed |Added Alias||perl-NOCpulse-Utils -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471509] Review Request: extjs - Ext JS is a cross-browser JavaScript library for building rich internet applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471509 Tom "spot" Callaway <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Blocks|182235 | --- Comment #2 from Tom "spot" Callaway <[EMAIL PROTECTED]> 2008-11-14 16:56:49 EDT --- Okay, so let me explain this. The latest version of ExtJS claims to be under GPLv3 with an exception, documented here: http://extjs.com/products/floss-exception.php RH Legal is firm that this exception clause isn't valid. One of the conditions for the exception is: the Derivative Work can reasonably be considered independent and separate work that is intended for use by end-users and not as a library for software development purposes. This doesn't make sense. "Independent and separate" from what? By definition the Derivative Work is formed by combining Ext with some FLOSS work, so it can't be "independent and separate" from those. Moreover, how do you determine whether a Derivative Work is "intended for use by end-users and not as a library for software development purposes"? Well, to some degree you might be able to, but it raises disturbing questions. This sounds very much like a field-of-use limitation. If any such work actually were declared to be "intended for use solely by end-users" surely that would make such a work non-free. (Non-open-source, even.) Does "not as a library for software development purposes" suggest that the Derivative Work must be under terms that prohibit modification? At best this is disturbingly unclear. There are a couple of other points one could make as well. The sum conclusion here is that Fedora and its users are not safe to use the exception clause in ExtJS. However, there is no barrier to using it under GPLv3. This means unfortunately that items like Testopia are right out, due to license incompatibility with GPLv3, but it doesn't prevent ExtJS from inclusion in Fedora on its own merit. BE SURE that anything you use with ExtJS is compatible with GPLv3! All of this text needs to go in a file in the package called "README-Fedora-Licensing", and the spec needs to reflect it like this: # The FLOSS Exception is NOT VALID for this package, see: # README-Fedora-Licensing License: GPLv3 ... Lifting FE-Legal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471662] New: Review Request: qlandkartegt - GPS device mapping tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: qlandkartegt - GPS device mapping tool https://bugzilla.redhat.com/show_bug.cgi?id=471662 Summary: Review Request: qlandkartegt - GPS device mapping tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedora.danny.cz/qlandkartegt.spec SRPM URL: http://fedora.danny.cz/qlandkartegt-0.8.1-1.fc10.src.rpm Description: QLandkarte GT is the ultimate outdoor aficionado's tool for GPS maps in GeoTiff format as well as Garmin's img vector map format. Additional it is the PC side frontend to QLandkarte M, a moving map application for mobile devices. And it fills the gap Garmin leaves in refusing to support Linux. QLandkarte GT is the proof that writing portable applications for Unix, Windows and OSX is feasible with a minimum of overhead. No excuses! QLandkarte GT does replace the original QLandkarte with a much more flexible architecture. It's not limited to a map format or device. Thus if you think your Magellan GPS or other should be supported, join the team. Additionally it is a front end to the GDAL tools, to make georeferencing scanned maps feasible for the normal user. Compared to similar tools like QGis, it's target users are more on the consumer side than on the scientific one. QLandkarte GT might not let you select every possible feature of the GDAL tools, but it will simplify their use to the demands of most users. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467791] Review Request: vtun - Virtual tunnel over TCP/IP networks
X-Bugzilla-Flags:
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
In-Reply-To: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467791
--- Comment #2 from Gabriel Somlo <[EMAIL PROTECTED]> 2008-11-14 16:01:20 EDT
---
Spec URL: http://www.contrib.andrew.cmu.edu/~somlo/vtun.spec
SRPM URL: http://www.contrib.andrew.cmu.edu/~somlo/vtun-3.0.1-2.fc8.src.rpm
Fixed %defattr
Added -p flag to %{__install} and %{__make} install
I did consider adding a logrotate script before I submitted the review request,
but decided against it. vtund does not currently play nicely with having its
per-connection traffic counter "log" files rotated (i.e., will not listen to a
signal or otherwise detect that the files have been rotated, and will keep
writing to the old files until completely restarted). Besides, the real vtund
log entries go to syslog. I am considering submitting a feature request (or a
patch) to upstream re. rotating connection stats files in /var/log/vtun, but a
logrotate script won't help us at this time.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469627] Review Request: perl-MooseX-Types-Path-Class - A Path::Class type library for Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469627 --- Comment #6 from Chris Weyl <[EMAIL PROTECTED]> 2008-11-14 15:37:17 EDT --- (In reply to comment #4) > It's sad to add all of that cruft to the specfile just so you can include some > test files which are simply not even remotely useful as documentation. > Priorities, right? But, hey, it's your package. Yeah, and consistency. I've been working on a feature proposal[1] to automagically package test suites, so I'm actually going to discontinue packaging them in %doc after these last few already-submitted package... [1] https://fedoraproject.org/wiki/Features/FullyTestablePerl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469816] Review Request: perl-App-Cmd - Write command line apps with less suffering
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469816 --- Comment #2 from Chris Weyl <[EMAIL PROTECTED]> 2008-11-14 15:37:56 EDT --- New Package CVS Request === Package Name: perl-App-Cmd Short Description: write command line apps with less suffering Owners: cweyl Branches: F-8 F-9 F-10 devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469816] Review Request: perl-App-Cmd - Write command line apps with less suffering
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469816 Chris Weyl <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470070] Review Request: perl-URI-FromHash - Build a URI from a set of named parameters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470070 Chris Weyl <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469627] Review Request: perl-MooseX-Types-Path-Class - A Path::Class type library for Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469627 --- Comment #5 from Chris Weyl <[EMAIL PROTECTED]> 2008-11-14 15:34:08 EDT --- New Package CVS Request === Package Name: perl-MooseX-Types-Path-Class Short Description: A Path::Class type library for Moose Owners: cweyl Branches: F-8 F-9 F-10 devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470177] Review Request: perl-Module-Util - Module name tools and transformations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470177 --- Comment #2 from Chris Weyl <[EMAIL PROTECTED]> 2008-11-14 15:33:24 EDT --- New Package CVS Request === Package Name: perl-Module-Util Short Description: Module name tools and transformations Owners: cweyl Branches: F-8 F-9 F-10 devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469627] Review Request: perl-MooseX-Types-Path-Class - A Path::Class type library for Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469627 Chris Weyl <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470177] Review Request: perl-Module-Util - Module name tools and transformations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470177 Chris Weyl <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 425882] Review Request: ghc-zlib - zlib bindings for ghc
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=425882
--- Comment #37 from Jason Tibbitts <[EMAIL PROTECTED]> 2008-11-14 15:18:04
EDT ---
That is a bit confusing; I didn't realize that haddock was moving into ghc, and
unfortunately "rawhide" won't actually be rawhide for some time and while I can
do build testing in koji its tough to do any actual install testing unless I
work against static-repos. Unfortunately download speeds from there are so
terribly slow that it takes me hours to init a buildroot. Let me see what I
can come up with.
So if I understand correctly, for ghc-6.10.1 the scriptlet dependencies should
just be:
Requires(pre): ghc = %{ghc_version}
Requires(preun): ghc = %{ghc_version}
Requires(post): ghc = %{ghc_version}
Requires(postun): ghc = %{ghc_version}
And the "Requires(post): haddock09" bit can go.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457035] Review Request: libproxy - A library handling all the details of proxy configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457035 --- Comment #22 from Matthias Clasen <[EMAIL PROTECTED]> 2008-11-14 14:27:48 EDT --- GConf doesn't really enter the picture. NetworkManager should certainly play some role in dynamic network configuration (including proxies). But those things should certainly be developed upstream and do not have any direct bearing on the packaging of libproxy, afaics. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435018] Review Request: clipper - crystallographic object oriented library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435018
--- Comment #18 from Tim Fenn <[EMAIL PROTECTED]> 2008-11-14 14:27:48 EDT ---
(In reply to comment #17)
> For -18:
>
> (In reply to comment #16)
> > (In reply to comment #15)
>
> > > * Directory ownership issue
> > > - %_includedir/clipper is not owned by any packages
> > > ref:
> >
> > Ah, thanks! fixed.
>
> - This time build.log says:
>
> 2116 + exit 0
> 2117 warning: File listed twice: /usr/include/clipper/ccp4
> 2118 warning: File listed twice: /usr/include/clipper/ccp4/ccp4_map_io.h
> 2119 warning: File listed twice: /usr/include/clipper/ccp4/ccp4_mtz_io.h
> 2120 warning: File listed twice: /usr/include/clipper/ccp4/ccp4_mtz_types.h
> 2121 warning: File listed twice: /usr/include/clipper/ccp4/ccp4_utils.h
> 2122 warning: File listed twice: /usr/include/clipper/cif
>
> As written on the wiki I quoted on my comment 15,
> %files entry
>
> %files
> %{_includedir}/clipper
>
> contains the directory %_includedir/clipper _and_ all
> files/directories/etc under %_includedir/clipper.
>
Sorry, I was rushing a bit - removed the extraneous entries.
> ? Static linkage
> - The following command
>
> $ rpm -ql clipper | grep /usr/bin | xargs ldd -r
>
> shows no binaries in clipper rpm under %_bindir do not depend
> on libclipper.so. This seems rather strange.
>
fixed Makefile.am for the examples
new spec: http://www.stanford.edu/~fenn/packs/clipper.spec
new srpm: http://www.stanford.edu/~fenn/packs/clipper-2.0-19.f8.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470177] Review Request: perl-Module-Util - Module name tools and transformations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470177 Jason Tibbitts <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Jason Tibbitts <[EMAIL PROTECTED]> 2008-11-14 14:12:17 EDT --- I note that 1.05 came out the day after you submitted this package. It doesn't look like there's any significant differences between that and 1.04, so I'll go ahead and approve this package and if you like you can update when you check in. * source files match upstream. sha256sum: e3c556064dcf8fad412ddcf151bce5a23975f4e9ca966d02b55bd1bd1f1cbfc6 Module-Util-1.04.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Module::Util) = 1.04 perl-Module-Util = 1.04-1.fc10 = /usr/bin/perl perl(:MODULE_COMPAT_5.10.0) perl(Exporter) perl(ExtUtils::MakeMaker) perl(File::Spec::Functions) perl(Getopt::Long) perl(List::Util) perl(Module::Util) perl(Pod::Usage) perl(strict) perl(warnings) * %check is present and all tests pass: Files=2, Tests=45, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.05 cusr 0.01 csys = 0.08 CPU) Result: PASS * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225897] Merge Review: ImageMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225897 --- Comment #13 from Orcan 'oget' Ogetbil <[EMAIL PROTECTED]> 2008-11-14 13:09:35 EDT --- Thanks for the update! > > * Packages must NOT contain any .la libtool archives, these should be > > removed > > in the spec. In my mock build the current ImageMagick rpm contains .la > > files in > >/usr/lib64/ImageMagick-6.4.0/modules-Q16/coders/ > > > > > The .la files are still needed, see bug 185237, also as these are not in the > standard library path, so they can do no harm. > I realized that. I have got confused because when I built and installed ImageMagick without .la files, it worked. But I was sloppy enough to forget to remove the old .la files from a previous installation. So keeping them is *required*. > > * Is there a particular reason why you don't Require: > > libpng-devel,libtiff-devel,libwmf-devel,libxml2-devel in the -devel package? > > > > Because non of the ImageMagick headers use headers from these packages, it > would be nice if you would check such things yourself before making comments > like this in a review. Usually the reviewer does this the other way around he > checks which headers from other packages the headers need, and if they are all > Required by the -devel package. > I apologize. It was towards the end of a long review... I had to be careful and shouldn't make assumptions. > > * You might want to use the "--enable_static=no" flag for faster > > compilation. > > This might also save some lines (from the SPEC) file dedicated to removing > > the > > static libraries. > > I assume you mean --disable-static, done. > ./configure --help doesn't tell a --disable-static flag. If it works one way or the other, it's fine. > > * Adding djvu and jbig supports will be nice (although not necessary). > > > > jbig is patented and thus not included in Fedora Ok. What about djvu? All you need to do is add a BR: djvulibre-devel . It is enabled by the default ./configure Two more things: * There are two items (a directory and a file) that are in the source but do not end up in any of the packages: *** The files inside www/source/ are referenced in the docs. See, for example: file:///usr/share/doc/ImageMagick-6.4.5/www/magick-wand.html file:///usr/share/doc/ImageMagick-6.4.5/www/magick-core.html But the directory www/source isn't included in the -doc subpackage. I think it is a flaw of the Makefile script. Could you manually insert that directory into the -doc subpackage? *** Similarly, the file www/Magick++/COPYING doesn't end up in any subpackage. I think this file should go to the %doc of ImageMagick-c++ . * rpmlint says now: ImageMagick.x86_64: W: shared-lib-calls-exit /usr/lib64/libMagickWand.so.1.0.0 [EMAIL PROTECTED] This seems rather annoying. It is hard (or more appropriately, time-consuming) to check the entire code to see when these calls are made. Shall we ask the upstream if these calls would break anything or have you investigated the situation already? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450050] Review Request: cgilib - A C library for creating Common Gateway Interface ("CGI") programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450050 Lucian Langa <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #3 from Lucian Langa <[EMAIL PROTECTED]> 2008-11-14 12:34:43 EDT --- %files for the -devel package has no %defattr cgilib.x86_64: W: file-not-utf8 /usr/share/doc/cgilib-0.6/readme The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). please also consider preserve installed and/or modified files timestamps: - above iconv operation - make install target please explain why do you need to use autotools patch. You need to contact upstream for such modifications, anyway it should not be handled in the spec file. As I see it radically changes the source package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462254] Review Request: perl-Catalyst-Plugin-Session-Store-FastMmap - FastMmap session storage backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462254 --- Comment #6 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 12:23:35 EDT --- perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462254] Review Request: perl-Catalyst-Plugin-Session-Store-FastMmap - FastMmap session storage backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462254 --- Comment #7 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 12:23:38 EDT --- perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459944] Review Request: pfstools - Programs for handling high-dynamic range images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459944 Lucian Langa <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||459945 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459945] Review Request: pfstmo - PFS tone mapping operators
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459945 Lucian Langa <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Depends on||459944 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471527] Review Request: SNMP++ - SNMP C++ library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471527
Mamoru Tasaka <[EMAIL PROTECTED]> changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-11-14 11:50:54 EDT
---
Well:
* License
- License is MIT.
* %{version} tag in SourceURL
- I recommend to use %{version} tag in SourceURL. With
this you probably won't have to modify the SourceURL
when version is upgraded.
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D
* Requires
- "Requires: openssl" is redundant. This type of library dependency related
Requires are automatically detected by rpmbuild itself
(but see below)
* General rpmlint issue
- Please check your srpm/binary rpms with rpmlint (in rpmlint
rpm) to detect some general packaging issues.
--
snmp++.src: W: summary-ended-with-dot
snmp++.src: E: summary-too-long ...
snmp++.src: E: description-line-too-long ...
--
The meaning of the above errors/warnings can be shown
by "$ rpmlint -I summary-ended-with-dot", for example.
- Summary should not end with dot.
- Summary must not exceed 79 characters
- One line in %description must not exceed 79 characters
* CFLAGS
- Fedora specific compilation flags are not correctly honored.
You can check what flags are used on Fedora by
"$ rpm --eval %optflags".
Passing 'USEROPTS="%{optflags}"' to "make" works for
this package.
* Macors
- Use macros for standard directories. /usr should be
%{_prefix}:
https://fedoraproject.org/wiki/Packaging/RPMMacros
* "shared library" with no soname
- Well, the rebuilt "shared library" libsnmp++.so has no soname
(-Wl,-soname is not used).
In this case, ABI of this library may change in the future
silently, and then all applications linking against this library
silently.
In such case I think we should not provide this "broken"
"shared library" and only ship static archive.
Would you follow this and the link below of
"Static libraries only" case?
- In this case the main package "snmp++" package becomes
empty, so only -devel package must be created (and main
"snmp++" package should not be created).
-devel subpackage contains static archive, header files
and some document files in this case. "Requires: %{name} =
%{version}-%{release}" should be removed and "Provides:
%{name}-%{version}" should be added.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469816] Review Request: perl-App-Cmd - Write command line apps with less suffering
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469816 Jason Tibbitts <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Jason Tibbitts <[EMAIL PROTECTED]> 2008-11-14 11:13:53 EDT --- Gah, this still doesn't build on rawhide becaise IO::TieCombine isn't there. And it doesn't build on F9 either; the tests fail from lack of Test::More. I went ahead and added the Test::More build dep and built on F9. The inclusion of the test suite makes the doc directory larger than the rest of the package, but the package is small so I don't see that it makes much difference in the end. I'll go ahead and approve this but of course you'll need to fix the dependencies in order to build it. * source files match upstream: a3a240fb8e680417e9610790112ee80129cfec65a259f97cf77832009f3a06a4 App-Cmd-0.202.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. X BuildRequires are proper (needs Test::More) Note: added BuildRequires: perl(Test::More) to complete this review: * %clean is present. * package builds in mock (F9, x86_64) after adding build dep. * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(App::Cmd) = 0.202 perl(App::Cmd::ArgProcessor) = 0.202 perl(App::Cmd::Command) = 0.202 perl(App::Cmd::Command::commands) = 0.202 perl(App::Cmd::Command::help) = 0.202 perl(App::Cmd::Plugin) perl(App::Cmd::Setup) perl(App::Cmd::Simple) = 0.202 perl(App::Cmd::Subdispatch) = 0.202 perl(App::Cmd::Subdispatch::DashedStyle) = 0.202 perl(App::Cmd::Tester) perl(App::Cmd::Tester::Result) perl-App-Cmd = 0.202-1.fc9 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(App::Cmd) perl(App::Cmd::ArgProcessor) perl(App::Cmd::Command) perl(App::Cmd::Plugin) perl(App::Cmd::Subdispatch) perl(Carp) perl(Data::OptList) perl(File::Basename) perl(Module::Pluggable::Object) perl(Sub::Exporter) perl(Sub::Exporter::Util) perl(Sub::Install) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=6, Tests=42, 1 wallclock secs ( 0.34 cusr + 0.04 csys = 0.38 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is larger than the library, but still small so no subpackage is needed. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464430] Review Request: ltsp-server-livesetupdocs - Doc describing how to enable LTSP on Fedora Live LTSP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464430 --- Comment #14 from Peter Scheie <[EMAIL PROTECTED]> 2008-11-14 10:08:08 EDT --- New version at http://petre.homedns.org/k12linux/ltsp-server-livesetupdocs-0.0.2-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225897] Merge Review: ImageMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225897 --- Comment #12 from Hans de Goede <[EMAIL PROTECTED]> 2008-11-14 09:56:55 EDT --- (In reply to comment #1) > I reviewed ImageMagick. It needs some work to yield the guidelines: > Thanks, Below is my response to items which I did not address the rest is fixed in the latest release which you can find here: http://koji.fedoraproject.org/koji/taskinfo?taskID=933562 > * Packages must NOT contain any .la libtool archives, these should be removed > in the spec. In my mock build the current ImageMagick rpm contains .la files > in >/usr/lib64/ImageMagick-6.4.0/modules-Q16/coders/ > The .la files are still needed, see bug 185237, also as these are not in the standard library path, so they can do no harm. > Afaik, this one is not supported anymore, can be removed: >BuildRequires: libungif-devel > That is not true, libungif was a patent free *drop in* replacement for giflib, now that the patent is no longer valid we use giflib again, and giflib-devel provides libungif-devel, so this BR drags in giflib-devel, I've changed it to directly BR giflib-devel > * Is there a particular reason why you don't Require: > libpng-devel,libtiff-devel,libwmf-devel,libxml2-devel in the -devel package? > Because non of the ImageMagick headers use headers from these packages, it would be nice if you would check such things yourself before making comments like this in a review. Usually the reviewer does this the other way around he checks which headers from other packages the headers need, and if they are all Required by the -devel package. > * You might want to use the "--enable_static=no" flag for faster compilation. > This might also save some lines (from the SPEC) file dedicated to removing the > static libraries. I assume you mean --disable-static, done. > * Adding djvu and jbig supports will be nice (although not necessary). > jbig is patented and thus not included in Fedora -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471026] Review Request: chrony - An NTP client/server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471026 --- Comment #2 from Miroslav Lichvar <[EMAIL PROTECTED]> 2008-11-14 09:21:30 EDT --- chrony doesn't rotate the logs, but there is a small problem that it keeps the files open. It needs to be told to release them by cyclelogs command which requires authorization which requires a valid commandkey in chrony.keys file. I'll try to fix both issues and post an update. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469627] Review Request: perl-MooseX-Types-Path-Class - A Path::Class type library for Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469627 Jason Tibbitts <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Jason Tibbitts <[EMAIL PROTECTED]> 2008-11-14 09:20:04 EDT --- It's sad to add all of that cruft to the specfile just so you can include some test files which are simply not even remotely useful as documentation. Priorities, right? But, hey, it's your package. * source files match upstream: a80c5dc845a38867242edd2668db7ee8baa6126cd284b666ce2ed26fce30d5cd MooseX-Types-Path-Class-0.05.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(MooseX::Types::Path::Class) = 0.05 perl-MooseX-Types-Path-Class = 0.05-2.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(MooseX::Types::Moose) perl(Path::Class) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=8, Tests=37, 3 wallclock secs ( 0.02 usr 0.02 sys + 1.03 cusr 0.11 csys = 1.18 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226285] Merge Review: perl-XML-Grove
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226285 Stepan Kasal <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471026] Review Request: chrony - An NTP client/server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471026 --- Comment #1 from Dan Horák <[EMAIL PROTECTED]> 2008-11-14 08:41:34 EDT --- formal review is here, see the notes below: OK source files match upstream: f0c6b32099329f358dbdb4f62753d2c7cbc13c79 chrony-1.23.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPLv2). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. ?? rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. ?? correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - rpmlint complains a bit chrony.src:52: W: configure-without-libdir-spec hand-crafted configure script, can be ignored chrony.x86_64: W: non-standard-uid /var/lib/chrony chrony chrony.x86_64: W: non-standard-gid /var/lib/chrony chrony chrony.x86_64: W: non-standard-uid /var/log/chrony chrony chrony.x86_64: W: non-standard-gid /var/log/chrony chrony chrony.x86_64: W: non-standard-uid /var/lib/chrony/rtc chrony chrony.x86_64: W: non-standard-gid /var/lib/chrony/rtc chrony chrony.x86_64: W: non-standard-uid /var/lib/chrony/drift chrony chrony.x86_64: W: non-standard-gid /var/lib/chrony/drift chrony OK chrony.x86_64: E: non-readable /etc/chrony.keys 0600 OK chrony.x86_64: W: log-files-without-logrotate /var/log/chrony does chrony rotate the logs itself or ...? - the texinfo postun scriptlet is called at wrong occasion (https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468539] Review Request: sugar-jukebox - Media player activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468539 --- Comment #4 from Sebastian Dziallas <[EMAIL PROTECTED]> 2008-11-14 08:28:54 EDT --- I updated the files for release 5... Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-5-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471509] Review Request: extjs - Ext JS is a cross-browser JavaScript library for building rich internet applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471509 Jason Tibbitts <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||182235 Summary|Review Request: Ext JS -|Review Request: extjs - Ext |Ext JS is a cross-browser |JS is a cross-browser |JavaScript library for |JavaScript library for |building rich internet |building rich internet |applications. |applications. --- Comment #1 from Jason Tibbitts <[EMAIL PROTECTED]> 2008-11-14 08:24:42 EDT --- I don't see any names matching yours in the account system; what's your FAS ID? Do you require a sponsor? I recall that extjs has some licensing issues; please see bug 455474. If you can, please indicate how things have changed since that ticket (if indeed they have). I'll go ahead and ask the legal folks to have a look. Please also note that a few folks are trying to develop packaging guidelines for javascript, but there are many issues. Please see https://fedoraproject.org/wiki/PackagingDrafts/JavaScript and perhaps become involved in the process if you want to package javascript libraries. I don't think we'll be approving any javascript packages until the guidelines progress a bit further. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470502] Review Request: kde-plasma-runcommand - Simple plasmoid to run commands without using terminal or KRunner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470502 Fedora Update System <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #9 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:54:27 EDT --- kde-plasma-runcommand-0.6-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kde-plasma-runcommand'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9681 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469583] Review Request: me-tv - Digital television viewer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469583 Dan Horák <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG --- Comment #3 from Dan Horák <[EMAIL PROTECTED]> 2008-11-14 08:11:58 EDT --- (In reply to comment #2) > There is dependency on xine-lib and this is part of Fedora for a long time, > because it doesn't contain any problematic stuff. ignore this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465750] Review Request: R-GeneR - R for genes and sequences analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465750 --- Comment #14 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:53:49 EDT --- R-GeneR-2.11.1-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465750] Review Request: R-GeneR - R for genes and sequences analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465750 --- Comment #13 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:52:52 EDT --- R-GeneR-2.11.1-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445604] Review Request: tennix - A funny 2D tennis game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445604 --- Comment #22 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:53:03 EDT --- tennix-0.6.1-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469494] Review Request: xlcrack - Recover lost and forgotten passwords from XLS files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469494 Fedora Update System <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #8 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:53:15 EDT --- xlcrack-1.2-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xlcrack'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9673 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465750] Review Request: R-GeneR - R for genes and sequences analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465750 Fedora Update System <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467958] Review Request: barry - BlackBerry(tm) Desktop for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467958 --- Comment #25 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:48:16 EDT --- barry-0.14-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467958] Review Request: barry - BlackBerry(tm) Desktop for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467958 --- Comment #24 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:48:06 EDT --- barry-0.14-4.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469583] Review Request: me-tv - Digital television viewer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469583 --- Comment #2 from Dan Horák <[EMAIL PROTECTED]> 2008-11-14 07:51:57 EDT --- There is dependency on xine-lib and this is part of Fedora for a long time, because it doesn't contain any problematic stuff. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454441] Review Request: R-bigmemory - Manage massive matrices in R using C++, with support for shared memory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454441 Fedora Update System <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467958] Review Request: barry - BlackBerry(tm) Desktop for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467958 Fedora Update System <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454441] Review Request: R-bigmemory - Manage massive matrices in R using C++, with support for shared memory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454441 --- Comment #11 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:47:57 EDT --- R-bigmemory-2.3-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464054] Package Review Request for projectM-pulseaudio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464054 Fedora Update System <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468562] Review Request: basket - Taking care of your ideas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468562 Fedora Update System <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 445604] Review Request: tennix - A funny 2D tennis game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445604 --- Comment #21 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:46:29 EDT --- tennix-0.6.1-4.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464054] Package Review Request for projectM-pulseaudio
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464054 --- Comment #12 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:46:43 EDT --- projectM-pulseaudio-1.2.0-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468562] Review Request: basket - Taking care of your ideas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468562 --- Comment #14 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:47:31 EDT --- basket-1.0.3.1-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465382] Review Request: bouncycastle-mail - SMIME/CMS packages for Bouncy Castle
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465382 --- Comment #14 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:46:06 EDT --- bouncycastle-mail-1.41-3.fc9, bouncycastle-1.41-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454441] Review Request: R-bigmemory - Manage massive matrices in R using C++, with support for shared memory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454441 --- Comment #10 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:46:56 EDT --- R-bigmemory-2.3-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 438750] Review Request: qtoctave - fronted for octave written using qt4 widgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=438750 --- Comment #43 from Fedora Update System <[EMAIL PROTECTED]> 2008-11-14 07:44:29 EDT --- qtoctave-0.8.1-0.20080823.svn165.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469583] Review Request: me-tv - Digital television viewer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469583 Miroslav Lichvar <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|NEW AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review? | --- Comment #1 from Miroslav Lichvar <[EMAIL PROTECTED]> 2008-11-14 07:35:05 EDT --- Looks like this package depends on xine which can't be packaged in Fedora due to patent issues, so I'm not sure adding me-tv to Fedora is a good idea. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471575] New: Review Request: libnautilus-vcards - Nautilus vcard context menu extension
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libnautilus-vcards - Nautilus vcard context menu extension https://bugzilla.redhat.com/show_bug.cgi?id=471575 Summary: Review Request: libnautilus-vcards - Nautilus vcard context menu extension Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] CC: [EMAIL PROTECTED], fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: ftp://mumin.dnsalias.net/pub/libnautilus-vcards.spec SRPM URL: ftp://mumin.dnsalias.net/pub//libnautilus-vcards-0.1-23:26M.x86_64.src.rpm Description: A Nautilus Vcard extension adding context menu items for sending email, call, send SMS or take a Tomboy note for users represented by a vcard. The different applications are command line apps configured through gconf. Some more info at http://sourceforge.net/projects/dt-contacts. This is one of two subprojects within this project. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470626] Review Request: balance - TCP load-balancing proxy server with round robin and failover mechanisms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470626 Fabian Affolter <[EMAIL PROTECTED]> changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470626] Review Request: balance - TCP load-balancing proxy server with round robin and failover mechanisms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470626 Fabian Affolter <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470626] Review Request: balance - TCP load-balancing proxy server with round robin and failover mechanisms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470626 Fabian Affolter <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471026] Review Request: chrony - An NTP client/server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471026 Dan Horák <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468579] Review Request: PyQuante - Python Quantum Chemistry
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468579
--- Comment #5 from Fabian Affolter <[EMAIL PROTECTED]> 2008-11-14 06:20:59
EDT ---
(In reply to comment #4)
> (In reply to comment #1)
> > Name: PyQuante
> > - The name of your package should be lower case
> >
> > https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Case_Sensitivity
>
> The author refers to the software as PyQuante, also the python modules are
> called PyQuante. Refer to ORBit in Naming Guidelines.
OK
> > BuildRequires
> > - 'BuildRequires: python' is missing
>
> It is already required by python-setuptools-devel (and numpy too?).
python is no longer in the default packageset.
https://fedoraproject.org/wiki/Packaging/Python#BuildRequires
> > % files
> > - Please follow the guidelines
> > https://fedoraproject.org/wiki/Packaging/Python#System_Architecture
>
> Hmm, I thought I already was following them. I can't find anything wrong with
> using %{python_sitearch} as defined in the Python guidelines. PyQuante
> contains
> compiled C code in the modules..
I guess that I have had %{python_sitearch}/* in my mind. But I can remember if
I thought about %{python_sitearch}/modulename/*
> >> PyQuante.x86_64: E: non-executable-script
> >> /usr/lib64/python2.5/site-packages/PyQuante/Minimizers.py 0644
> >
> >You can add something like 'find *.py -type f | xargs chmod a+x' to fix
> >this.
>
> If I do that then I get script-without-shebang errors.
> Besides, the files in site-packages don't need to be executable, since they
> just contain modules used by the frontend software.
>
> Check your python-sitelib directory, only a small minority of the .py files
> are
> executable. rpmlint shouldn't complain about this.
I will take a look at it.
> > > PyQuante.x86_64: W: invalid-license Modified BSD
> > > PyQuante-debuginfo.x86_64: W: invalid-license Modified BSD
> >
> > For a valid license for Fedora, please take a look at
> > https://fedoraproject.org/wiki/Licensing
>
> Yeah, but the license is not word-for-word BSD.
The license looks like MIT 'Old Style with legal disclaimer 3'
http://fedoraproject.org/wiki/Licensing/MIT
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471026] Review Request: chrony - An NTP client/server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471026 Dan Horák <[EMAIL PROTECTED]> changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471522] Review Request: OTL - OTL library for database connections and queries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471522
--- Comment #2 from Peter Lemenkov <[EMAIL PROTECTED]> 2008-11-14 06:12:17 EDT
---
Notes:
* You forgot to add %prep section to your spec-file (where rpmbuild should
unzip sources). Please add
%prep
%setup -q -c
This means that rpmbuild will create default directory in BUILD
(%{name}-%{version}), cd into it and will quietly unzip %{SOURCE0}
* Add empty %build section (just to make rpmlint happy)
* You should use mighty power of 'install' command instead of creating
directory my hands :). E.g. instead of
mkdir -p $RPM_BUILD_ROOT%{_includedir}/otl
cp -a otlv4.h $RPM_BUILD_ROOT%{_includedir}/otl
you may use
install -D -p -m 644 otlv4.h $RPM_BUILD_ROOT%{_includedir}/%{name}/otlv4.h
* Please split %description in shorter lines (to silent rpmlint):
otl.src: E: description-line-too-long OTL 4.0 was designed as a combination of
a C++ template framework and OTL-adapters.
otl.src: E: description-line-too-long The framework is a generic implementation
of the concept of OTL streams. The OTL-adapters
otl.src: E: description-line-too-long are thin wrappers around the database
APIs and are used as class type parameters
Other things looks sane.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469583] Review Request: me-tv - Digital television viewer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469583 Miroslav Lichvar <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471522] Review Request: OTL - OTL library for database connections and queries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471522 Peter Lemenkov <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Comment #1 from Peter Lemenkov <[EMAIL PROTECTED]> 2008-11-14 05:57:48 EDT --- I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 462835] Review Request: perl-Math-Calc-Units - Human-readable unit-aware calculator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462835 --- Comment #6 from Fabian Affolter <[EMAIL PROTECTED]> 2008-11-14 05:42:21 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468823 Akira TAGOH <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-cvs? --- Comment #17 from Akira TAGOH <[EMAIL PROTECTED]> 2008-11-14 05:37:26 EDT --- Thanks for the review, Nicolas. New Package CVS Request === Package Name: hanazono-fonts Short Description: Japanese Mincho-typeface TrueType font Owners: tagoh Branches: devel F-10 F-9 F-8 InitialCC: fonts-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457035] Review Request: libproxy - A library handling all the details of proxy configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457035 --- Comment #21 from Nicolas Chauvet (kwizart) <[EMAIL PROTECTED]> 2008-11-14 05:34:34 EDT --- @Matthias. The package itself have been formally approved already. There is still few questions remaining that prevent to import. So for the gnome side, is there any plan to add libproxy support via Gconf-2 ? In which case I will import the last version in F-11. I think a NetworkManager advice would be needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468823 Nicolas Mailhot <[EMAIL PROTECTED]> changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review? |fedora-review+ --- Comment #16 from Nicolas Mailhot <[EMAIL PROTECTED]> 2008-11-14 04:42:11 EDT --- This one looks good, thank you for your persistence. You can now continue the font package integration process, starting here: http://fedoraproject.org/wiki/Font_package_lifecycle#3.a Please do not forget the comps and wiki parts. Reassigning the bug to you since my part is done. APPROVED PS Do not forget to subscribe to the low-traffic fedora-fonts-list, since Fedora 11 packaging changes are being discussed there right now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468539] Review Request: sugar-jukebox - Media player activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468539 --- Comment #3 from Kushal Das <[EMAIL PROTECTED]> 2008-11-14 04:24:40 EDT --- Please use the latest source http://kushaldas.in/tmp/Jukebox-5.tar.bz2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471480] Review Request: sfxr - Sound effect generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471480 Hans de Goede <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Hans de Goede <[EMAIL PROTECTED]> 2008-11-14 03:52:36 EDT --- New Package CVS Request === Package Name: sfxr Short Description: Sound effect generator Owners: jwrdegoede Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 471480] Review Request: sfxr - Sound effect generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471480 --- Comment #4 from Hans de Goede <[EMAIL PROTECTED]> 2008-11-14 03:50:44 EDT --- (In reply to comment #2) > Would have been nice if the spec URL above would have been valid :) Sorry. > Anyway, here we go, using only the src.rpm : Thanks! > === Final Notes === > 1. Please try to push usptream your relevant patches. At least one of them > seems to deal with an unitialized field in SDL. I've been discussing my improvements with upstream and as upstream only does windows, I've prepared a new release for upstream, note this currently is a proposed new release, but I expect upstream to pick it up: http://people.atrpms.net/~hdegoede/sfxr-sdl-1.1.tar.gz Quoting from the ChangeLog: sfxr-sdl-1.1 * Various small improvements and 1 bugfix by Hans de Goede <[EMAIL PROTECTED]>: * Fix a small bug in the audio setup which could cause a quite noticable delay between pressing a button and hearing the sound * Add an icon and a .desktop file (applications menu entry) * Add a make install target, note: hardcoded to /usr but it does understand the DESTDIR make parameter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469972] Review Request: glfw - A portable framework for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469972 David Nielsen <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|fedora-review+ |fedora-review? --- Comment #9 from David Nielsen <[EMAIL PROTECTED]> 2008-11-14 03:39:42 EDT --- dear Einstein I hate the new bugzilla, it's confusing layout keeps letting me forget these details. die die die.. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469972] Review Request: glfw - A portable framework for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469972 David Nielsen <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 435018] Review Request: clipper - crystallographic object oriented library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=435018
--- Comment #17 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-11-14 03:31:35 EDT
---
For -18:
(In reply to comment #16)
> (In reply to comment #15)
> > * Directory ownership issue
> > - %_includedir/clipper is not owned by any packages
> > ref:
>
> Ah, thanks! fixed.
- This time build.log says:
2116 + exit 0
2117 warning: File listed twice: /usr/include/clipper/ccp4
2118 warning: File listed twice: /usr/include/clipper/ccp4/ccp4_map_io.h
2119 warning: File listed twice: /usr/include/clipper/ccp4/ccp4_mtz_io.h
2120 warning: File listed twice: /usr/include/clipper/ccp4/ccp4_mtz_types.h
2121 warning: File listed twice: /usr/include/clipper/ccp4/ccp4_utils.h
2122 warning: File listed twice: /usr/include/clipper/cif
As written on the wiki I quoted on my comment 15,
%files entry
%files
%{_includedir}/clipper
contains the directory %_includedir/clipper _and_ all
files/directories/etc under %_includedir/clipper.
? Static linkage
- The following command
$ rpm -ql clipper | grep /usr/bin | xargs ldd -r
shows no binaries in clipper rpm under %_bindir do not depend
on libclipper.so. This seems rather strange.
For example, caniso binaries are created like:
1842 g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -fno-strict-aliasing -o caniso caniso.o
../clipper/mmdb/.libs/libclippermmdb.a ../clipper/cif/.libs/libclippercif.a
../clipper/cns/.libs/libclippercns.a
../clipper/minimol/.libs/libclipperminimol.a
../clipper/phs/.libs/libclipperphs.a ../clipper/ccp4/.libs/libclipperccp4.a
-lgpp4 -lmmdb ../clipper/contrib/.libs/libclippercontrib.a
../clipper/core/.libs/libclippercore.a -lsrfftw -lsfftw -lm
So these binaries use static libclipper.a. I guess these
binaries should use system wide libclipper.so.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
