[Bug 466906] Review Request: perl-NOCpulse-SetID - Provides api for correctly changing user identity
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466906 Ralf Corsepius changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #6 from Ralf Corsepius 2009-01-29 03:03:41 EDT --- (In reply to comment #4) > sane Requires/Provides Not quite :( Requires(pre): perl(Class::MethodMaker) This is very likely wrong. Furthermore: - Package is noarch => OPTIMIZE doesn't make any sense - Please add perl-sig to InitialCC like most perl-packagers do. - "make test" is claimed to require "root". I recommend to add an rpm option to run this testsuite (rpmbuild --with tests or similar). Better: Make the testsuite degrade gracefully if not being run as "root". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479835] Review Request: log4c - an application message logging library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479835 Alex Hudson (Fedora Address) changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Alex Hudson (Fedora Address) 2009-01-29 03:04:04 EDT --- New Package CVS Request === Package Name: log4c Short Description: flexible application message logging library Owners: alexh Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482880] Review Request: perl-Sane - Access SANE-compatible scanners with perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=482880
Parag AN(पराग) changed:
What|Removed |Added
CC||panem...@gmail.com
--- Comment #1 from Parag AN(पराग) 2009-01-29 03:04:08
EDT ---
Perl package source generally includes license test in its perl module source
text files(.pm here say) only.
Suggestions:
1) SRPM when extracted got SPEC with License as "Unknown" whereas SPEC file
link shows correct license as "GPL+ or Artistic"
2) Summary should be
"Perl extension for the SANE (Scanner Access Now Easy) Project"
3) %files should be
%files
%defattr(-,root,root,-)
%doc Changes README examples
%{perl_vendorarch}/auto/*
%{perl_vendorarch}/Sane*
%{_mandir}/man3/*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482880] Review Request: perl-Sane - Access SANE-compatible scanners with perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=482880
Parag AN(पराग) changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
Flag||fedora-review?
--- Comment #2 from Parag AN(पराग) 2009-01-29 03:07:11
EDT ---
(In reply to comment #1)
> Perl package source generally includes license test in its perl module source
> text files(.pm here say) only.
>
s/test/text/
> Suggestions:
> 1) SRPM when extracted got SPEC with License as "Unknown" whereas SPEC file
> link shows correct license as "GPL+ or Artistic"
>
> 2) Summary should be
> "Perl extension for the SANE (Scanner Access Now Easy) Project"
>
> 3) %files should be
> %files
> %defattr(-,root,root,-)
> %doc Changes README examples
> %{perl_vendorarch}/auto/*
> %{perl_vendorarch}/Sane*
> %{_mandir}/man3/*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481725] Review Request: python-setupdocs - Setuptools plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481725 --- Comment #6 from Rakesh Pandit 2009-01-29 03:26:01 EDT --- Thanks Jochen and Jose: Updated: http://rakesh.fedorapeople.org/spec/python-setupdocs.spec http://rakesh.fedorapeople.org/srpm/python-setupdocs-1.0.1-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482993] Renaming review: doulos-fonts to sil-doulos-fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482993 Roozbeh Pournader changed: What|Removed |Added Summary|Renaming review:|Renaming review: |gentium-fonts to|doulos-fonts to |sil-gentium-fonts |sil-doulos-fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 181994] Review Request: doulos-fonts - Doulos SIL fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=181994 Roozbeh Pournader changed: What|Removed |Added Blocks||482993 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482993] New: Renaming review: gentium-fonts to sil-gentium-fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Renaming review: gentium-fonts to sil-gentium-fonts https://bugzilla.redhat.com/show_bug.cgi?id=482993 Summary: Renaming review: gentium-fonts to sil-gentium-fonts Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rooz...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com, fedora-fonts-bugs-l...@redhat.com Depends on: 181994 Blocks: 477335 Estimated Hours: 0.0 Classification: Fedora Renaming of doulos-fonts to sil-doulos-fonts to comply with http://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming New package: http://roozbeh.fedorapeople.org/sil-doulos-fonts.spec http://roozbeh.fedorapeople.org/sil-doulos-fonts-4.104-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481725] Review Request: python-setupdocs - Setuptools plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481725 Rakesh Pandit changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Rakesh Pandit 2009-01-29 03:35:07 EDT --- It seems even if I donn't remove eggs folder setuptools takes care of it by creating it from source: log snippet when it was not removed: = running egg_info writing setupdocs.egg-info/PKG-INFO writing top-level names to setupdocs.egg-info/top_level.txt writing dependency_links to setupdocs.egg-info/dependency_links.txt writing entry points to setupdocs.egg-info/entry_points.txt reading manifest file 'setupdocs.egg-info/SOURCES.txt' writing manifest file 'setupdocs.egg-info/SOURCES.txt' Copying setupdocs.egg-info to /home/redhat/rpm/BUILDROOT/python-setupdocs-1.0.1-3.fc10.i386/usr/lib/python2.5/site-packages/setupdocs-1.0.1-py2.5.egg-info running install_scripts + /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot = -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481725] Review Request: python-setupdocs - Setuptools plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481725 --- Comment #8 from Rakesh Pandit 2009-01-29 03:39:08 EDT --- New Package CVS Request === Package Name: python-setupdocs Short Description: Setuptools plugin Owners: rakesh Branches: F-9 F-10 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 433678] Review Request: ricci - cluster and systems management agent
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=433678
--- Comment #16 from Mamoru Tasaka 2009-01-29
04:03:38 EDT ---
(In reply to comment #15)
> Isn't stuff in %{_docdir} automatically marked %doc by RPM?
This is correct:
http://www.redhat.com/archives/fedora-maintainers/2005-May/msg00118.html
Currently there are more directories under which all files/directories
are automatically marked as %doc
Note that I have not checked the spec file of this package at all.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225707] Merge Review: dosfstools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225707 --- Comment #8 from Parag AN(पराग) 2009-01-29 04:15:53 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #12 from Parag AN(पराग) 2009-01-29 04:27:28 EDT --- from build.log you can see warning: File listed twice: /tftpboot/linux-install/msgs warning: File listed twice: /tftpboot/linux-install/msgs/boot.msg warning: File listed twice: /tftpboot/linux-install/msgs/expert.msg warning: File listed twice: /tftpboot/linux-install/msgs/general.msg warning: File listed twice: /tftpboot/linux-install/msgs/param.msg warning: File listed twice: /tftpboot/linux-install/msgs/rescue.msg warning: File listed twice: /tftpboot/linux-install/msgs/snake.msg warning: File listed twice: /tftpboot/linux-install/pxelinux.0 warning: File listed twice: /tftpboot/linux-install/pxelinux.cfg Please see http://fedoraproject.org/wiki/PackagingGuidelines#Duplicate_Files ===> You want to have in %files of -cmd as only %config(noreplace) /tftpboot/linux-install/ This will make all files under this /tftpboot/linux-install/ directory as configuration files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226463
--- Comment #13 from Parag AN(पराग) 2009-01-29 04:35:41
EDT ---
2) also, gtk-update-icon-cache scriptlet should be
%post
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%postun
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
3) Buildroot should be one of values from
http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481759] Review Request: python-Apptools - Enthough Tool Suite Application Tools
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481759
--- Comment #3 from Rakesh Pandit 2009-01-29
04:43:23 EDT ---
Questions:
* Does it may sense to pacakge the %{python_sitelib}/integrationtest directory?
I assume it's only require for testing the built package, so we should remove
this directory from the package.
Yeo .. will remove.
Bad:
- Cant find python-setupdocs in the Fedora repository
Yeah in addition to adding as depends tag I should have mentioned in comments.
- Please remove the AppTools.egg-info directory from the sources
in the %setup stanza to make sure, that the err-info files are built
from sources
>From build log of python-setupdocs it looked like even if I don't remove this
folder setuptools takes care of recreating it. Will very even before importing
python-setupdocs and do the fix accordingly. May you also check in meantime? :)
TODO:
- Not all source files have a proper copyright note
(Please notify the upstream maintainer to fix this issue in the next release)
Yeah I have been in constant touch with upstream and this would be fixed in
next release for sure. They have already started doing the process.
- A refview shows, that mostly all files which have a copyrith note
are licensed under the terms of the BSD license. So why there are references
agains the LGPLv2+?
Actually few images are in LGPLv2+ -- confirmed from upstream. image_
LICENSE.txt has details.
Once python-setupdocs is done and build available will update.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466906] Review Request: perl-NOCpulse-SetID - Provides api for correctly changing user identity
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466906 --- Comment #7 from Miroslav Suchy 2009-01-29 05:04:34 EDT --- > Requires(pre): perl(Class::MethodMaker) > This is very likely wrong. OK. There it seems that pure Requires: perl(Class::MethodMaker) Should be ok. > Package is noarch => OPTIMIZE doesn't make any sense OK. Will remove it. > Please add perl-sig to InitialCC like most perl-packagers do. I did not know it. I overlooked it in guidelines. Will do next time. > - "make test" is claimed to require "root". > I recommend to add an rpm option to run this testsuite All the test in this package require root. So making them optional will be the same as skipping it entirely. IMHO. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480050] Review Request: libchamplain - Map view for Clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480050 Denis Leroy changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #13 from Denis Leroy 2009-01-29 05:11:18 EDT --- Great. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472794] Review Request: onemind-commons-java - A common library used to support other onemind libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472794 Mary Ellen Foster changed: What|Removed |Added Status|NEW |CLOSED Resolution||DEFERRED --- Comment #4 from Mary Ellen Foster 2009-01-29 05:14:57 EDT --- I'm withdrawing this review for the moment because it's no longer a requirement for the packages I'm currently working on. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481192] Review Request: perl-pgsql_perl5 - Pg - Perl5 extension for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481192 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com --- Comment #2 from Parag AN(पराग) 2009-01-29 05:17:31 EDT --- License should be GPL+ or Artistic -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479798] Review Request: perl-Test-HTTP-Server-Simple-StashWarnings - Catch your forked server's warnings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479798 --- Comment #6 from Parag AN(पराग) 2009-01-29 05:24:22 EDT --- is this built? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483016] New: Package Review: perl-NOCpulse-Debug - Perl debug output package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Package Review: perl-NOCpulse-Debug - Perl debug output package https://bugzilla.redhat.com/show_bug.cgi?id=483016 Summary: Package Review: perl-NOCpulse-Debug - Perl debug output package Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: msu...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-perl-devel-l...@redhat.com, fedora-package-review@redhat.com Blocks: 452450 Estimated Hours: 0.0 Classification: Fedora Target Release: --- Miroslav Suchy changed: What|Removed |Added Flag||fedora-review? SPEC: http://miroslav.suchy.cz/fedora/perl-NOCpulse-Debug/perl-NOCpulse-Debug.spec SRPM: http://miroslav.suchy.cz/fedora/perl-NOCpulse-Debug/perl-NOCpulse-Debug-1.23.13-1.src.rpm Description: NOCpulse provides application, network, systems and transaction monitoring, coupled with a comprehensive reporting system including availability, historical and trending reports in an easy-to-use browser interface. This package provides an API for generating varying levels of debugging output on various output streams. Scratch build is without problem: http://koji.fedoraproject.org/koji/taskinfo?taskID=1090760 rpmlint is silent. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482863] Review Request: perl-MooseX-Daemonize - Role for daemonizing your Moose based application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482863 --- Comment #4 from Allisson Azevedo 2009-01-29 06:19:43 EDT --- Update package: Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Daemonize/perl-MooseX-Daemonize.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Daemonize/perl-MooseX-Daemonize-0.08-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483016] Package Review: perl-NOCpulse-Debug - Perl debug output package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483016 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com Flag|fedora-review? | --- Comment #1 from Parag AN(पराग) 2009-01-29 06:20:00 EDT --- As you are package submitter you should not change fedora‑review flag. Its reviewer who want to take it for review will change it to fedora-review? and when he want to approve package he then change it from fedora-review? to fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482856 --- Comment #6 from Allisson Azevedo 2009-01-29 06:43:10 EDT --- Hi, I'll wait for perl-MooseX-Daemonize inclusion: https://bugzilla.redhat.com/show_bug.cgi?id=482863 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483020] New: Review Request: torch - Torch is a simple machine-learning library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: torch - Torch is a simple machine-learning library https://bugzilla.redhat.com/show_bug.cgi?id=483020 Summary: Review Request: torch - Torch is a simple machine-learning library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: xja...@fi.muni.cz QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://mjakubicek.fedorapeople.org/torch/torch.spec SRPM URL: http://mjakubicek.fedorapeople.org/torch/torch-3.1-1.fc10.src.rpm Description: Torch is a simple machine-learning library, among its features you can find: * A lot of things in gradient machines, that is, machines which could be learned with a gradient descent. This includes multi-layered perceptrons, radial bas is functions, mixtures of experts, convolutional networks and even time-delay neural networks. In fact a lot of "modules" are available that you can plug as you want to get what you need. * Support vector machines, in classification and regression. As fast as the old stand-alone program SVMTorch II, but with the powerful environment of the library. * Ensemble models such as bagging or adaboost. * Non-parametric models such as K-nearest-neighbors, Parzen regression and Parzen density estimator. * Distributions stuff, like Kmeans, Gaussian mixture models, hidden Markov models, input-output hidden Markov models, and Bayes classifier. * Speech recognition tools (Embedded training and large vocabulary decoding). Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1090884 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483020] Review Request: torch - Torch is a simple machine-learning library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483020 Milos Jakubicek changed: What|Removed |Added Blocks||483025 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483025] Review Request: imms - Adaptive playlist framework tracking and adapting to your listening patterns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483025 Milos Jakubicek changed: What|Removed |Added Blocks||182235 Depends on||483020 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] New: Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: hatools - Improved shell scripting in High Availability environment https://bugzilla.redhat.com/show_bug.cgi?id=483026 Summary: Review Request: hatools - Improved shell scripting in High Availability environment Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: oli...@linux-kernel.at QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://filelister.linux-kernel.at/downloads/share/hatools.spec SRPM URL: http://filelister.linux-kernel.at/downloads/share/hatools-2.00-1.fc10.src.rpm Description: The HA-Tools provide some programs to improve shell scripting in a High Availability environment. The halockrun program provides a simple and reliable way to implement a locking in shell scripts. A typical usage for halockrun is to prevent cronjobs to run simultanously. halockrun uses a lock on a file via fcntl(2) which ensures the release of the lock even if the process gets killed via SIGKILL. The hatimerun program provides a time-out mechanism which can be used from shell scripts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483025] New: Review Request: imms - Adaptive playlist framework tracking and adapting to your listening patterns
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: imms - Adaptive playlist framework tracking and adapting to your listening patterns https://bugzilla.redhat.com/show_bug.cgi?id=483025 Summary: Review Request: imms - Adaptive playlist framework tracking and adapting to your listening patterns Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: xja...@fi.muni.cz QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://mjakubicek.fedorapeople.org/imms/imms.spec SRPM URL: http://mjakubicek.fedorapeople.org/imms/imms-3.1.0-0.1.rc6.fc10.src.rpm Description: IMMS is an adaptive playlist framework that tracks your listening patterns and dynamically adapts to your taste. Currently we ship only the XMMS plugin. Its major features include: * IMMS is easy to install. It is purely a plugin - no XMMS patch required. A very lightweight embedded SQL database is used, so there's no need to setup a RDBMS. * IMMS is easy to use. Song rating is done completely transparently to the user. It does not get in your way. * IMMS does a much better job of shuffling than most players. It keeps track of when a song was last played, and makes sure same songs are not repeated too often. It is even able to recognise different versions of the same song (eg. remixes) and treat them as one song! * IMMS uses a variety of techniques to figure out which songs should be played together, and which should not. It studies your listening habits, as well as using acoustic properties of the songs themselves, such as BPM and frequency spectrum. * IMMS is fair. Even unfavoured songs have a (small) chance of being played. There are some outstanding issues I have to deal with and would appreciate any help: 1) rpmlint complains about executable-stack: >rpmlint imms-3.1.0-0.1.rc6.fc10.x86_64.rpm imms.x86_64: W: executable-stack /usr/bin/immsd imms.x86_64: W: executable-stack /usr/bin/immstool imms.x86_64: W: xmms-naming-policy-not-applied /usr/lib64/xmms/General/libxmmsimms.so The naming policy is not a problem imho, but I don't know how to get rid of the executable-stack warning. 2) Licensing issues The project claims to be GPL, but this license is not specified in source file. Moreover it includes some (modified) third-party code (see AUTHORS) -- this is mostly ok (better than own source files, it includes the license) except of: immscore/xidle.c model/emd.c immscore/normal.h These files and those written by the imms upstream need definitely a license specified -- I'm going to contact the author and setting FE-LEGAL for now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 --- Comment #1 from Oliver Falk 2009-01-29 07:20:12 EDT --- I'm not sure about the GPL license... Maybe with more knowledge about licensing should take that this review... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480050] Review Request: libchamplain - Map view for Clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480050 Debarshi Ray changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Debarshi Ray 2009-01-29 08:01:01 EDT --- New Package CVS Request === Package Name: libchamplain Short Description: Map view for Clutter Owners: rishi Branches: F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481389] Review Request: beesu - Beesu is a wrapper around su
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481389 --- Comment #6 from bee 2009-01-29 08:30:36 EDT --- Thank you!! I took one account there ( https://admin.fedoraproject.org/accounts/user/view/honeybee ). But now what have i to do? Because BEESU is the only package i want to upload in YUM. As it's the only one, you could just upload it for me!! that would be easy for me, because i don't know how to do it. I'm really looking for somebody to push beesu into YUM! My RPM is excellent, it has 0 warnings in rpmlint!! i did it with leigh on fedoraforum!!! it works very good! could you be my sponsor? if no, can you just upload beesu into yum?(this would be perfect for me!! very easy!!!) thank you again! bye! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480860] Review Request: timespan - A tool that performs date-based time calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480860 --- Comment #5 from Fabian Affolter 2009-01-29 08:39:28 EDT --- I don't need a sponsor but thanks for the review. You should mention this informal review to find a sponsor for yourself. For more details check out this page [1]. For RH employees is the 'seeking sponsor' procedure a bit different than for Fedora contributors. [1] https://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Fabian Affolter changed: What|Removed |Added CC||fab...@bernewireless.net AssignedTo|nob...@fedoraproject.org|panem...@gmail.com --- Comment #14 from Fabian Affolter 2009-01-29 08:49:54 EDT --- Added Parag as 'Assignee' because the review is in progress. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476471] Review Request: fedora-security-guide - A security guide for Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476471
--- Comment #42 from Eric Christensen 2009-01-29
08:48:45 EDT ---
(In reply to comment #41)
Well, it looks something like this in the code:
%if %{HTMLVIEW}
Requires: htmlview
%else
Requires: xdg-utils
%endif
(In reply to comment #38)
Apparently the .desktop file is "retarded stuff" and won't be fixed. I'm not
sure what information goes into the file so I can't build one myself. Will
need some help with this one.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225852] Merge Review: gok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225852 --- Comment #7 from Debarshi Ray 2009-01-29 08:51:04 EDT --- (In reply to comment #6) >> You have missed this one. > No, I haven't. I didn't feel it was worth it. There's only so much time I can > justify spending on irrelevant details of a spec file that make no difference > whatsoever to the resulting package. The guidelines recommend the use of parallel builds and there is a rationale behind it: http://www.redhat.com/archives/fedora-packaging/2007-July/msg4.html Can I make the change on your behalf? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227933] Review Request: libproj4 - Cartographic projection library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=227933 Fabian Affolter changed: What|Removed |Added CC||fab...@bernewireless.net Flag||needinfo?(or...@cora.nwra.c ||om) --- Comment #7 from Fabian Affolter 2009-01-29 08:53:49 EDT --- Why is the "fedora-review" flag set on this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479798] Review Request: perl-Test-HTTP-Server-Simple-StashWarnings - Catch your forked server's warnings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479798 --- Comment #7 from Ralf Corsepius 2009-01-29 08:59:46 EDT --- Yes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482863] Review Request: perl-MooseX-Daemonize - Role for daemonizing your Moose based application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482863 Allisson Azevedo changed: What|Removed |Added Blocks||482856 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482856] Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482856 Allisson Azevedo changed: What|Removed |Added Depends on||482863 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] New: Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies https://bugzilla.redhat.com/show_bug.cgi?id=483045 Summary: Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: allis...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://allisson.fedorapeople.org/packages/perl-Test-Unit-Lite/perl-Test-Unit-Lite.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-Test-Unit-Lite/perl-Test-Unit-Lite-0.1101-1.fc10.src.rpm Description: This framework provides lighter version of Test::Unit framework. It implements some of the Test::Unit classes and methods needed to run test units. The Test::Unit::Lite tries to be compatible with public API of Test::Unit. It doesn't implement all classes and methods at 100% and only those necessary to run tests are available. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225744] Merge Review: fbset
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225744 Fabian Affolter changed: What|Removed |Added CC||fab...@bernewireless.net, ||zprik...@redhat.com --- Comment #2 from Fabian Affolter 2009-01-29 09:29:33 EDT --- Zdenek Prikryl is the owner according the PackageDB. Added as cc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466906] Review Request: perl-NOCpulse-SetID - Provides api for correctly changing user identity
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466906 --- Comment #8 from Ralf Corsepius 2009-01-29 09:48:29 EDT --- (In reply to comment #7) > > Requires(pre): perl(Class::MethodMaker) > > This is very likely wrong. > > OK. There it seems that pure > Requires: perl(Class::MethodMaker) > Should be ok. No, it's entirely superfluous, rpm adds it automatically. You can completely remove it. > > Please add perl-sig to InitialCC like most perl-packagers do. > I did not know it. I overlooked it in guidelines. Will do next time. > > > - "make test" is claimed to require "root". > > I recommend to add an rpm option to run this testsuite > All the test in this package require root. Hmm, sounds like a pretty severe design problem with this package to me. > So making them optional will be the > same as skipping it entirely. IMHO. Not at all. It would enable those who want to build rpms as "root" (likely you) to test your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225852] Merge Review: gok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225852 --- Comment #8 from Matthias Clasen 2009-01-29 09:52:53 EDT --- Thats not a rationale. Thats just spot saying "it should work". Do you know that it works in this case ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #8 from Petr Sklenar 2009-01-29 09:56:18 EDT --- Hi, I made informal review at https://bugzilla.redhat.com/show_bug.cgi?id=480860#c4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481272] Review Request: python-webunit - it test your websites with code that acts like a web browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481272 --- Comment #7 from Petr Sklenar 2009-01-29 09:56:45 EDT --- Hi, I made informal review at https://bugzilla.redhat.com/show_bug.cgi?id=480860#c4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483020] Review Request: torch - Torch is a simple machine-learning library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483020 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com Flag||fedora-review+ --- Comment #1 from Tom "spot" Callaway 2009-01-29 10:23:25 EDT --- Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (BSD) OK, text in %doc, matches source - spec file legible, in am. english - sources match upstream (e107eec98402b9fe85a273a45152cb8d7b8a277e & 59a2b0e6319dfdea5133687c232a4de501855738) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Beautiful package, approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225852] Merge Review: gok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225852 --- Comment #9 from Mamoru Tasaka 2009-01-29 10:31:23 EDT --- (In reply to comment #8) > Do you know that it works in this case ? http://koji.fedoraproject.org/koji/taskinfo?taskID=1090498 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481527] Review Request: bucardo - asynchronous PostgreSQL replication system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481527 --- Comment #1 from Itamar Reis Peixoto 2009-01-29 10:36:34 EDT --- http://ispbrasil.com.br/bucardo/bucardo.spec http://ispbrasil.com.br/bucardo/bucardo-3.0.9-1.fc10.src.rpm - koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=1091363 - I am able to replicate master-master and master-slave with this RPM bucardo is one of the best replication solution for pgsql. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225852] Merge Review: gok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225852 --- Comment #10 from Matthias Clasen 2009-01-29 10:39:21 EDT --- So, if it makes you happy, commit it. Obsessing over trivia like this is what makes merge reviews so resented... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482902] Review Request: gsh - aggregate several remote shells into one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482902 --- Comment #3 from Jochen Schmitt 2009-01-29 10:44:59 EDT --- Created an attachment (id=330368) --> (https://bugzilla.redhat.com/attachment.cgi?id=330368) Propose cleanup SPEC file for gsh Good: + Defining python_sitelib macro + Packaged tar ball matches with upstream (md5sum: 6b925fe21bb84606b47a9a29d1eb88fb) + Local build works fine + Local install works fine + Simple call without argument rans without crash + Local uninstall works fine + Koji build works fine Bad: - '-n ' flag occurs twice in the %setup macro - You should remove the gsh.egg-info directory - %files stanza has a long list of duplicate files entries I have attached a clenup SPEC file as a proposal for this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199154] Review Request: Slony-1 (postgresql-slony-engine)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=199154 --- Comment #53 from Itamar Reis Peixoto 2009-01-29 10:46:02 EDT --- I belive you need to add docbook-utils into Build Requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481192] Review Request: perl-pgsql_perl5 - Pg - Perl5 extension for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481192 --- Comment #3 from Itamar Reis Peixoto 2009-01-29 10:42:05 EDT --- ok, I will fix this later. is possible to leave this package on hold and take a look in this another https://bugzilla.redhat.com/show_bug.cgi?id=481531 ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482827 Jochen Schmitt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Jochen Schmitt 2009-01-29 10:48:27 EDT --- OK, It's look nice for me, The package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481034] Review Request: coccinelle - Semantic patching for Linux (spatch)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481034 --- Comment #13 from Michal Schmidt 2009-01-29 10:52:10 EDT --- Created an attachment (id=330369) --> (https://bugzilla.redhat.com/attachment.cgi?id=330369) use python_sitelib Please use the correct way to find Python's site-packages path described in http://fedoraproject.org/wiki/Packaging/Python See the attached patch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225852] Merge Review: gok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225852 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com --- Comment #11 from Parag AN(पराग) 2009-01-29 10:59:03 EDT --- Merge-reviews are always topic of debate on fedora lists. If we have approved spec template as given in /etc/rpmdevtools/spectemplate-minimal.spec then why not megre-review packages simply follow them? Merge-review packages should not be considered a special case and exempted from what FESCo approved Packaging Guidelines say. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483045 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com --- Comment #1 from Parag AN(पराग) 2009-01-29 11:03:21 EDT --- Not needed BuildRequires: perl >= 0:5.006 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199154] Review Request: Slony-1 (postgresql-slony-engine)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=199154 --- Comment #54 from Itamar Reis Peixoto 2009-01-29 11:11:38 EDT --- (In reply to comment #52) Devrim please build in koji first and make sure you have posted a working spec file for review. http://koji.fedoraproject.org/koji/taskinfo?taskID=1091454 look at Comment #53 and try to build in koji again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483074] New: Review Request: perl-Exception-Base - Lightweight exceptions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Exception-Base - Lightweight exceptions https://bugzilla.redhat.com/show_bug.cgi?id=483074 Summary: Review Request: perl-Exception-Base - Lightweight exceptions Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: allis...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://allisson.fedorapeople.org/packages/perl-Exception-Base/perl-Exception-Base.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-Exception-Base/perl-Exception-Base-0.21-1.fc10.src.rpm Description: This class implements a fully OO exception mechanism similar to Exception::Class or Class::Throwable. It provides a simple interface allowing programmers to declare exception classes. These classes can be thrown and caught. Each uncaught exception prints full stack trace if the default verbosity is uppered for debugging purposes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481531 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? --- Comment #3 from Parag AN(पराग) 2009-01-29 11:11:43 EDT --- 1)I see working Source URL should be http://search.cpan.org/CPAN/authors/id/T/TU/TURNSTEP/Test-Dynamic-1.3.3.tar.gz 2) Enable make test 3) I see LICENSE is BSD. Also, This can be seen at http://search.cpan.org/dist/Test-Dynamic/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481717] Review Request: ugene - genome analysis suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481717 --- Comment #4 from Fabian Affolter 2009-01-29 10:46:32 EDT --- (In reply to comment #3) > (In reply to comment #2) > > - Please place the changelog section at the end of the file. It's not wrong > > just unusual. > > done Again 'changelog', if you make any changes on the spec file, you must bump the release of the package. More details at https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs . > > > - This application has a GUI. You need to install the .desktop file. > > https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files > > desktop file is part of the upstream tarball and is installed during 'make > install' If 'make install' is taking care of the .desktop file installation, then 'validate' is the right way if the categories match the 'Desktop Entry Specification'. https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage Without any further investigations I think that 'Requires: qt' is not necessary, for me it looks like that rpm will pick this automatically. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483079] New: Review Request: perl-constant-boolean - Define TRUE and FALSE constants
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-constant-boolean - Define TRUE and FALSE constants https://bugzilla.redhat.com/show_bug.cgi?id=483079 Summary: Review Request: perl-constant-boolean - Define TRUE and FALSE constants Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: allis...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://allisson.fedorapeople.org/packages/perl-constant-boolean/perl-constant-boolean.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-constant-boolean/perl-constant-boolean-0.01-1.fc10.src.rpm Description: Defines TRUE and FALSE constants in caller's namespace. You could use simple values like empty string or zero for false, or any non-empty and non- zero string value as true, but the TRUE and FALSE constants are more descriptive. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 Jochen Schmitt changed: What|Removed |Added Status|NEW |ASSIGNED CC||joc...@herr-schmitt.de AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de Flag||fedora-review? --- Comment #2 from Jochen Schmitt 2009-01-29 11:22:55 EDT --- Good: + Basename of the SPEC files matches with package name + Package contains the most current release + SPEC file is written in English + Could download source via spectool -g + Packaged tar ball matches with upstream (md5sum: ba137a37f6725076c7d2c729cbccf4a5) + Package contains no patches + Package contains a license tag + Package contains a verbatin copy of the license text + Package contains proper BuildRoot specification + Consistently use of rpm macros + Package contains no patches + Package doesn't need any BRs or Reqs. + Package use parallel make + Buildroot will be cleaned at the beginning of %clean and %install + Local build works fine + Build honors $RPM_OPT_FLAGS + Koji build works fine + Debuginfo package contains source files + Local install works fine + Start of command without arguments doesn't crashed + Local uninstall works fine + Package doesn't have subpackages + Default files permission are ok. + Files have proper file permission + %files stanza doesn't have duplicated entries + All packaged files are owned by the package + No packaged file has a conflict with ohter packages + %doc stanza is small, so we don't need a separate subpackage + %changelog is in a proper format Bad: - License tag says GPL as license. It's necessary to specified the version of the used GPL. A look on the source files says, that GPLv2+ may the right specification for the license tag. TODO: * I thing a blank line beetween the paragraph of the description will incerease the readability of it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473537] Review Request: jcodings - Java Libraries for Ruby String Encodings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473537 Conrad Meyer changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Conrad Meyer 2009-01-29 11:55:12 EDT --- New Package CVS Request === Package Name: jcodings Short Description: Java Libraries for Ruby String Encodings Owners: konradm Branches: F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481564 --- Comment #17 from Tim Jackson 2009-01-29 12:08:06 EDT --- (In reply to comment #16) > > Final point: I am intending to only import this on the EL-5 branch so if > > anyone wants to co-maintain in devel/F-10/F-9 then let me know. > Can I do this ? Sure, that would be great - thanks. I don't seem to be able to change the owner from the pkgdb, but just drop the CVS admin request in here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225852] Merge Review: gok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225852 --- Comment #12 from Matthias Clasen 2009-01-29 12:14:02 EDT --- No need to jump on this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482827 David Nielsen changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from David Nielsen 2009-01-29 12:15:03 EDT --- Thank you for the review New Package CVS Request === Package Name: banshee-mirage Short Description: An Automatic Playlist Generation Extension for Banshee Owners: dnielsen Branches: F9, F10, devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476460] Review Request: pymilter - Python interface to sendmail milter API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476460
--- Comment #17 from Mamoru Tasaka 2009-01-29
12:34:33 EDT ---
For 0.9.0-4
* Unused macros
- It seems that %python_sitelib is not used.
* Fedora/RHEL conditional
- There are some useful macros, see:
https://fedoraproject.org/wiki/Packaging/DistTag#Conditionals
For example:
-
%if 0%{?el3} || 0%{?el4}
%define __python python2.4
%endif
-
* About version dependency
- If you are to support both RHEL and Fedora by one spec file,
then
--
Requires: %{pythonbase} >= 2.4, sendmail >= 8.13
BuildRequires: ed, %{pythonbase}-devel >= 2.4, sendmail-devel >= 8.13
--
is sufficient
(The reason I wrote that version dependency is redundant was
that it is redundant just to support Fedora)
* python module dependency
- Would you check if all needed dependencies related to python
modules are included in Requires:
For example, Milter/dns.py contains:
--
3 import DNS
4 from DNS import DNSError
--
It seems this package should have "Requires: python-pydns".
Also python-spf may be needed.
* Macros in %changelog
- $ rpm -q --changelog pymilter shows:
--
* Thu Jan 08 2009 Stuart Gathman 0.9.0-4
- Stop using INSTALLED_FILES to make Fedora happy
- Remove config flag from start.sh glue
- Own /var/log/milter
- Use /var <
--
that macros are expanded in %changelog. To prevent this,
use %% (instead of %) in %changelog.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482902] Review Request: gsh - aggregate several remote shells into one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482902 --- Comment #4 from Adam Miller 2009-01-29 12:42:47 EDT --- Spec URL: http://maxamillion.fedorapeople.org/gsh.spec SRPM URL: http://maxamillion.fedorapeople.org/gsh-0.3-4.src.rpm Only thing I edited from your proposed SPEC was remove the extra -n entry since that was on your "Bad:" list. Thank you very much for your SPEC proposal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481531 --- Comment #4 from Itamar Reis Peixoto 2009-01-29 12:48:52 EDT --- fixed. - Include make test in %%check section, fixed license, the correct is BSD - fixed sumary and descripton of this package - fixed source url http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic.spec http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic-1.3.3-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483108] New: Review Request: chordii - Print songbooks (lyrics + chords)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: chordii - Print songbooks (lyrics + chords) https://bugzilla.redhat.com/show_bug.cgi?id=483108 Summary: Review Request: chordii - Print songbooks (lyrics + chords) Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jvrom...@squirrel.nl QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.squirrel.nl/pub/xfer/chordii.spec SRPM URL: http://www.squirrel.nl/pub/xfer/chordii-4.2-1.src.rpm Description: This is a description of a utility called chordii. It's purpose is to provide guitar players with a tool to produce good looking, self-descriptive music sheets from text files. chordii reads text files containing the lyrics of songs, the chords to be played, their descriptions and some other optional data to produce a PostScript document that includes: Centered titles Chord names above the words Graphical representation of the chords at the end of the songs chordii also provides support for Multiple columns on a page Index of a songbook Multiple logical pages per physical pages (1, 2 or 4) Configurable fonts for the lyrics and the chord names Multiple songs inside one file The complete ISO 8859-1 character set Chorus marking This is my first package, so I'm looking for a sponsor. The spec and srpm are rpmlint free of warnings and errors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481732
--- Comment #9 from Lubomir Rintel 2009-01-29 12:58:28 EDT ---
(In reply to comment #8)
> Hi,
> I made informal review at
> https://bugzilla.redhat.com/show_bug.cgi?id=480860#c4
I like it. I'd still like to se at least a couple more, this one was pretty
easy :)
A review of this package:
1.) Package name.
To be consistent with other existing practice applied to other stardict
dictionary packages I suggest you rename the package to "stardict-dic-cs" or
"stardict-dic-cs_CZ".
You may still want to add a Provides: for the upstream name.
2.) Package version.
%define dicdate 20081201
Version: 1.0.0
Source0:
ftp://dl.cihar.com/slovnik/stable/stardict-english-czech-%{dicdate}.tar.gz
Is 1.0.0 made up? Why not use 20081201 as version?
3.) URL tag.
URL: ftp://dl.cihar.com/slovnik/stable/stardict-english-czech-%{dicdate}.tar.gz
Purpose of the URL tag is to address the package's home page, with general
information about it -- it definitely should not be the same as Source tag.
4.) BuildArchitectures tag.
This is fairly minor, but: it is commonly spelled "BuildArch:"
5.) Setup
%setup -c -T -n %{name}-%{version}
%setup -q -n %{name}-%{version} -D -T -a 0
This could be written as:
%setup -q -c -n %{name}-%{version}
6.) No need to rename the README file
install -p -m 0644 %{name}-%{dicdate}/README LICENSE
Especially when it does not contain the license text.
7.) Your %description is not informative
Description is not meant to contain information about history of the package or
its build process, but rather contents of the package. The latter URL belongs
to the Url: tag and rest should be replaced with something like:
"Czech-English and English-Czech translation dictionaries for StarDict, a
GUI-based dictionary software."
8.) Group.
I guess Applications/Text would be a far better pick than Applications/System.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483108] Review Request: chordii - Print songbooks (lyrics + chords)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483108 Johan Vromans changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480860] Review Request: timespan - A tool that performs date-based time calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480860 Lubomir Rintel changed: What|Removed |Added CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review+ --- Comment #6 from Lubomir Rintel 2009-01-29 13:03:33 EDT --- (In reply to comment #5) > I don't need a sponsor but thanks for the review. You should mention this > informal review to find a sponsor for yourself. For more details check out > this page [1]. For RH employees is the 'seeking sponsor' procedure a bit > different than for Fedora contributors. > > [1] > https://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account I think the sponsoring procedure is the same, just the CLA signing part is different. I think Peter's review was fairly exhaustive and package simple and correct as well. Thank you both! APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481667] Review Request: xmlenc - XML output library for java.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481667 Mamoru Tasaka changed: What|Removed |Added Blocks|177841 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475097] Review Request: gimp-fourier-plugin - A fourier transformation plugin for GIMP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475097 Mamoru Tasaka changed: What|Removed |Added Blocks|177841 | Flag|fedora-review? |fedora-review+ --- Comment #11 from Mamoru Tasaka 2009-01-29 13:08:57 EDT --- Now I will approve this package (xmlenc is now in good shape, I am re-reviewing xmlenc now) --- This package (gimp-fourier-plugin) is APPROVED by mtasaka --- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji)". Now I am sponsoring you. If you want to import this package into Fedora 9/10, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. Removing NEEDSPONSOR. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480860] Review Request: timespan - A tool that performs date-based time calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480860 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Comment #7 from Fabian Affolter 2009-01-29 13:18:50 EDT --- New Package CVS Request === Package Name: timespan Short Description: A tool that performs date-based time calculations Owners: fab Branches: F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482902] Review Request: gsh - aggregate several remote shells into one
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=482902
--- Comment #5 from Jochen Schmitt 2009-01-29
13:21:30 EDT ---
God:
+ Duüöocated -n option was removed from %setup
+ Files stanza has no duplicated entries
+ egg-info directory was removed from source in the %setup stanza
Bad:
- the pity.py file is marked as execuatable, but all other files are not. I
think we should mark all files in %{python_sitelib}/gsh as nonexecutables. You
may remove the shebang line from the pity.py file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483115] New: Review Request: allgeyer-fonts - Musical Notation True Type Fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: allgeyer-fonts - Musical Notation True Type Fonts https://bugzilla.redhat.com/show_bug.cgi?id=483115 Summary: Review Request: allgeyer-fonts - Musical Notation True Type Fonts Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tcall...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://www.auroralinux.org/people/spot/review/new/allgeyer-fonts.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/allgeyer-fonts-5.002-1.fc11.src.rpm Description: Robert Allgeyer's MusiQwik and MusiSync are a set of original True Type fonts that depict musical notation. Each music font may be used within a word processing document without the need for special music publishing software, or embedded in PDF files. This is one of the font families from the Fedora Font Wish List: http://fedoraproject.org/wiki/Category:Font_wishlist -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483116] New: Review Request: grnotify - Google Reader Notifier
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: grnotify - Google Reader Notifier https://bugzilla.redhat.com/show_bug.cgi?id=483116 Summary: Review Request: grnotify - Google Reader Notifier Product: Fedora Version: 10 Platform: noarch URL: http://grnotify.sourceforge.net/ OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: llaum...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora GrNotify is a simple Python written tray application that will allow you to know when there are new items in the Google Reader. SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.0.2-2.fc10.noarch.rpm RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.0.2-2.fc10.src.rpm Commment: rpmlint is silent -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482880] Review Request: perl-Sane - Access SANE-compatible scanners with perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=482880
--- Comment #3 from Bernard Johnson 2009-01-29
13:53:02 EDT ---
(In reply to comment #1)
> Perl package source generally includes license test in its perl module source
> text files(.pm here say) only.
The author thinks that the information in the README is sufficient.
> Suggestions:
> 1) SRPM when extracted got SPEC with License as "Unknown" whereas SPEC file
> link shows correct license as "GPL+ or Artistic"
Someone I think I uploaded a file in progress - this has been fixed.
> 2) Summary should be
> "Perl extension for the SANE (Scanner Access Now Easy) Project"
fixed
> 3) %files should be
> %files
> %defattr(-,root,root,-)
> %doc Changes README examples
> %{perl_vendorarch}/auto/*
> %{perl_vendorarch}/Sane*
> %{_mandir}/man3/*
fixed
Spec URL: http://fedorapeople.org/~bjohnson/perl-Sane.spec
SRPM URL: http://fedorapeople.org/~bjohnson/perl-Sane-0.02-2.fc10.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481667] Review Request: xmlenc - XML output library for java.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481667
Mamoru Tasaka changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Mamoru Tasaka 2009-01-29
13:57:28 EDT ---
(In reply to comment #4)
> rpmlint also showed this non-standard-group error to me. I just looked at some
> other packages which used thos group tag. I was unsure whether non standard
> names are allowed or not.
- Unless you have some reason you want to use the previous Group
tag, I suggest to follow the suggestion from rpmint.
> Download url is fixed.
- Note that wiki suggest
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tgz
(middle "sourceforge" is not written)
> So when requiring explicitly icedtea I just use java(-devel) >= 1:1.6.0?
(please make it sure that you use epoch here)
- I guess you wanted to say "openjdk" because on F-9/10/11 icedtea
no longer exists. However, yes, with
"(Build)Requires: java-devel >= 1:1.6.0" java-1.6.0-openjdk(-devel) is
always selecteed, because "java-1.5.0-gcj(-devel)" does not satisfy
this (Build)Requires.
Now looks good (however I suggest to modify the SourceURL a bit)
--
This package (xmlenc) is APPROVED by mtasaka
--
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482902] Review Request: gsh - aggregate several remote shells into one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482902 --- Comment #6 from Adam Miller 2009-01-29 14:12:53 EDT --- Spec URL: http://maxamillion.fedorapeople.org/gsh.spec SRPM URL: http://maxamillion.fedorapeople.org/gsh-0.3-5.src.rpm Added a patch to get rid of the shebang to satisfy rpmlint instead of forcing the file to be executable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480727] Review Request: daemontools: is a collection of tools for managing UNIX services.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480727 --- Comment #33 from Itamar Reis Peixoto 2009-01-29 14:23:53 EDT --- > So, can I consider daemontools to be approved? still not, for compatibility with other djb program's you should put /services directory in some place, for example /var/run/daemontools you need to adjust svscanboot to look for services in this directory, can you write a init.d script or a upstart script to start svscanboot? >May be, I can work on packaging djbdns now. ? feel free, packaging djb programs is not easy and you can speed up working in both packages at the same time, please posts messages related to djbdns in their own BugZilla -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483115] Review Request: allgeyer-fonts - Musical Notation True Type Fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483115 Jochen Schmitt changed: What|Removed |Added Status|NEW |ASSIGNED CC||joc...@herr-schmitt.de AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de Flag||fedora-review? --- Comment #1 from Jochen Schmitt 2009-01-29 14:46:05 EDT --- Good: + Basename of the SPEC files matches with package name + Package names matches with nameing guidelines for font packages + Package zip files matches with upstream (md5sum: 25106eaf88416df3006925b8383b7f69) + Package contains valid License tag + License tag specified OFL as a valid font license for Fedora + Package contains verbatin copy of the license text + Package contains proper rpm group + Package contains proper buildroot defintion + Proper definition of BRs and Reqs. + Fonts subpackage contains Req to common subpackages + Filelist doesn't contains duplicate files + Files have proper file permissions + Package contains no files belong to other packages + All packaged file are owned by this package + Rpmlint is ok for source and binary rpms. + Local build works fine + Local install works fine + Fonts was shown on fc-list + Local uninstall works fine + Koji build works fine + %doc stanza is only in common subpackage which is required on all other packages + Package has proper %changelog stanza Bad: - I can't figure out on which base you have determinate the upstream version of the font - Fonts are not built from sources because upstream doesn't provides one -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476832] Review Request: mydns - serve DNS records directly from an SQL database
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476832
--- Comment #10 from Mamoru Tasaka 2009-01-29
14:49:35 EDT ---
Some notes:
* License
- License tag should be GPLv2+.
* %description place
- Would you move the place of %package and %description to the
upper side of %prep?
* Documents
- I guess it is better that QUICKSTART.mysql is installed
in -mysql subpackage and QUICKSTART.postgres in -pgsql subpackage.
- For HOWTO:
install -Dp -m 644 %{SOURCE1} %{_builddir}/%{name}-%{base_version}
* Move this to %prep section, if "HOWTO" file is not to be modified
at %build.
* By the way is HOWTO also needed for subpackages?
* Current working directory
make install DESTDIR=%{_builddir}/%{name}-%{base_version}/mysql
- make install DESTDIR=$(pwd)/mysql is simpler.
(at %build, %install (and %check) stage, the working directory
is %{_builddir}/%{name}-%{base_version} in this case)
For "install -Dp ", even
install -Dp ./$database%{_bindir}/mydnscheck
%{buildroot}%{_bindir}/mydnscheck-$database
can be used (for DESTDIR=, usually this should be absolute path)
* CFLAGS
make CFLAGS="%{optflags}" %{?_smp_mflags}
- Would you check if this "CFLAGS=%{optflags}" is really needed?
%configure sets CFLAGS environment variable and configure/Makefiles
created from recent autotools honor this CFLAGS.
* autotool recall
644 + make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables' -j8
645 cd . && /bin/sh /builddir/build/BUILD/mydns-1.2.8/missing --run
aclocal-1.10 -I m4
646 /builddir/build/BUILD/mydns-1.2.8/missing: line 46: aclocal-1.10:
command not found
647 WARNING: `aclocal-1.10' is missing on your system. You should only
need it if
648 you modified `acinclude.m4' or `configure.ac'. You might want
649 to install the `Automake' and `Perl' packages. Grab them from
650 any GNU archive site.
651 cd . && /bin/sh /builddir/build/BUILD/mydns-1.2.8/missing --run
autoconf
- Here autotools are called automatically after calling make.
This usually means that timestamps on some files are wrong.
Please modify the timestamps of those to prevent autotool
recall here.
* Directory structure
install -Dp -m 644 contrib/admin.php %{buildroot}%{_datadir}/admin.php
- I don't think that putting files under %_datadir (not under the
subdirectory of %_datadir) is a good idea. This should be
moved to %{_datadir}/%{name}, for example.
* gettext .po file
- This package has gettext .po files under po/ directory and
actually "make install" installs compiled .mo files.
Please include gettext .mo file in binary rpm (and use %find_lang)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476832] Review Request: mydns - serve DNS records directly from an SQL database
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476832
--- Comment #11 from Mamoru Tasaka 2009-01-29
14:55:24 EDT ---
... and follows...
* scriptlets
- For SysV initscripts handling, please refer to
https://fedoraproject.org/wiki/Packaging/SysVInitScript#InitscriptScriptlets
(Note that there are some Requires(post) or so)
- Add "Requires(post): %{_sbindir}/alternatives" (also Requires(preun))
for -mysql and -pgsql subpackages
* And please also check my comment 9.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453083 --- Comment #50 from Matthew Barnes 2009-01-29 14:54:23 EDT --- Simo and I were talking about splitting several Samba libraries (talloc, tevent, tdb and ldb) into a separate, standalone "samba-base" package to be consumed by Samba3, Samba4, OpenChange and SSSD [1]. We also think we want to disable, for the time being, any parts of Samba4 not needed by OpenChange (by means of some simple toggle settings in the spec file). Expect more churn here before a formal review can start. In the meantime I'll clean up the details Matthias pointed out. Thanks again, Matthias. [1] http://fedoraproject.org/wiki/Features/SSSD -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483115] Review Request: allgeyer-fonts - Musical Notation True Type Fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483115 --- Comment #2 from Tom "spot" Callaway 2009-01-29 15:04:09 EDT --- Versioning is in two places: * Upstream URL: http://www.icogitate.com/~ergosum/fonts/musicfonts.htm * Inside the TTF metadata The fonts themselves are editable source. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483115] Review Request: allgeyer-fonts - Musical Notation True Type Fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483115 Jochen Schmitt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Jochen Schmitt 2009-01-29 15:20:36 EDT --- O, thank you for your hint. But I have to disagree with you, that ttf files are editable sources. But because upstream doesn't provides sources I think this is not a blocker for this review, So I can APPROVEd your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482902] Review Request: gsh - aggregate several remote shells into one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482902 Jochen Schmitt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Jochen Schmitt 2009-01-29 15:25:55 EDT --- Good: + Package contains a patch + Patch seems to be reliable + Local build works fine + Rpmlint is silent on binary rpm. You are APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475097] Review Request: gimp-fourier-plugin - A fourier transformation plugin for GIMP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475097 --- Comment #12 from Fabian Deutsch 2009-01-29 15:31:25 EDT --- New Package CVS Request === Package Name: gimp-fourier-plugin Short Description: A simple plug-in to do fourier transform on your image Owners: fabiand Branches: F-10 InitialCC: fabiand mtasaka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481667] Review Request: xmlenc - XML output library for java.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481667 --- Comment #6 from Fabian Deutsch 2009-01-29 15:31:35 EDT --- New Package CVS Request === Package Name: xmlenc Short Description: Light-weight XML output library for Java Owners: fabiand Branches: F-10 InitialCC: fabiand mtasaka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481667] Review Request: xmlenc - XML output library for java.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481667 Fabian Deutsch changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 475097] Review Request: gimp-fourier-plugin - A fourier transformation plugin for GIMP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475097 Fabian Deutsch changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481667] Review Request: xmlenc - XML output library for java.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481667 --- Comment #7 from Fabian Deutsch 2009-01-29 15:37:43 EDT --- URL modified to match the guidelines. Was a mistake, I did not read acrefully enough. http://www.informatik.uni-bremen.de/~fabiand/fedora/hadoop/xmlenc.spec http://www.informatik.uni-bremen.de/~fabiand/fedora/hadoop/xmlenc-0.52-5.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483116] Review Request: grnotify - Google Reader Notifier
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483116 --- Comment #1 from Guillaume Kulakowski 2009-01-29 15:54:58 EDT --- Fredonnement… La version 1.1.1 a été libérée peu d'heures avant ma demande… Je fais aller rapidement la construction T/MN avant week-end : SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.1-1.fc10.noarch.rpm RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.1-1.fc10.src.rpm Commment: buil...@enterprise ~> rpmlint rpmbuild/RPMS/noarch/grnotify-1.1.1-1.fc10.noarch.rpm 21:45 grnotify.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/grnotify/GoogleReader.py 0644 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482902] Review Request: gsh - aggregate several remote shells into one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482902 Adam Miller changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Adam Miller 2009-01-29 16:12:49 EDT --- New Package CVS Request === Package Name: gsh Short Description: aggregate several remote shells into one Owners: maxamillion Branches: EL-5 F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480056] Review Request: libchamplain-gtk - Gtk+ widget wrapper for libchamplain
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480056
--- Comment #1 from Denis Leroy 2009-01-29 16:29:08 EDT
---
Couple of things :
- you should not put "%{version}" macro in the patch0 source filename, since
this will force you to rename it everytime you update the package. Although not
officially in the guidelines, most people hardcode the version that the patch
was derived from, and keep that version in the filename until the patch no
longer applies and has to be recreated...
- why the pkgconfig patch ? I can see the development headers indeed only need
libchamplain and gtk2 but this most likely will not stay true in the future.
Seems a bit over the top...
Otherwise this is very similar to the libchamplain review...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482985] Renaming review: gentium-fonts to sil-gentium-fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482985 --- Comment #2 from Nicolas Mailhot 2009-01-29 16:39:42 EDT --- Also the following entries in the FAQ should apply: http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#Do_I_need_to_Provide_my_old_package_names.3F http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#What_if_the_new_naming_guidelines_require_me_to_rename_my_source_package.3F -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
