[Bug 489026] Review Request: auto-buildrequires - Work out BuildRequires for rpmbuild automatically

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489026


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #16 from Kevin Fenzi   2009-03-22 01:50:19 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476720


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #18 from Kevin Fenzi   2009-03-22 01:49:21 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470702] Review Request: L-function - L-function calculator

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470702


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #10 from Kevin Fenzi   2009-03-22 01:46:50 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486584


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #7 from Kevin Fenzi   2009-03-22 01:48:09 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478365] Review Request: perl-Verilog-CodeGen - Verilog code generator

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478365


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #11 from Kevin Fenzi   2009-03-22 01:44:32 EDT ---
Strange. Try now, I think it's working... not sure what happened there. ;(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 469569] Review Request: latex2rtf - LaTeX to RTF converter that handles equations, figures, and cross-references

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469569


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Kevin Fenzi   2009-03-22 01:45:49 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486390] Review Request: simspark - Spark physical simulation system

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486390


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #13 from Kevin Fenzi   2009-03-22 01:39:27 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479799] Review Request: ghc-uniplate - Uniform type generic traversals

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479799


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #9 from Kevin Fenzi   2009-03-22 01:40:26 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491201] Review Request: ninvaders - Space Invaders clone written in ncurses for cli gaming

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491201


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Kevin Fenzi   2009-03-22 01:38:36 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488359] Review Request: dcbd - daemon and configuration tool for data center bridging

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488359


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #17 from Kevin Fenzi   2009-03-22 01:30:02 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490562] Review Request: renameutils - A set of programs to make renaming of files easier

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490562


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #9 from Kevin Fenzi   2009-03-22 01:32:18 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490580] Review Request: faust - Compiled language for real-time audio signal processing

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490580


Kevin Fenzi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Kevin Fenzi   2009-03-22 01:27:21 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491425] Review Request: R-RODBC - An ODBC database interface for R

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491425


Mattias Ellert  changed:

   What|Removed |Added

   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491497] New: Review Request: dmapd - A server that provides DAAP and DPAP shares

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: dmapd - A server that provides DAAP and DPAP shares

https://bugzilla.redhat.com/show_bug.cgi?id=491497

   Summary: Review Request: dmapd - A server that provides DAAP
and DPAP shares
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: m...@flyn.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.flyn.org/SRPMS/dmapd.spec
SRPM URL: http://www.flyn.org/SRPMS/dmapd-0.0.8-1.fc10.src.rpm
Description:
The dmapd project provides a GObject-based, Open Source implementation
of DMAP sharing with the following features:

 o Support for both DAAP and DPAP

 o Support for realtime transcoding of media formats not natively
 supported by clients

 o Support for many metadata formats, such as those associated with Ogg
 Vorbis and MP3 (e.g., ID3)

 o Detection of video streams so that clients may play them as video

 o Use of GStreamer to support a wide range of audio and video CODECs

 o Caching of photograph thumbnails to avoid regenerating them each time
 the server restarts

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491029] Review Request: perl-Data-Denter - An alternative to Data::Dumper and Storable

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491029


Chris Weyl  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #4 from Chris Weyl   2009-03-21 19:31:58 EDT 
---
Thanks for the review! :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226443] Merge Review: switchdesk

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226443





--- Comment #1 from Jussi Lehtola   2009-03-21 18:40:07 
EDT ---
rpmlint output:
switchdesk.noarch: W: summary-ended-with-dot A desktop environment switcher for
GNOME, KDE and AnotherLevel.
switchdesk.noarch: E: tag-not-utf8 %changelog
switchdesk.noarch: W: no-url-tag
switchdesk.src: E: non-utf8-spec-file
/tmp/switchdesk-4.0.9-4.fc10.1.src.rpm.25649/switchdesk.spec
switchdesk.src:31: W: unversioned-explicit-obsoletes %{name}-kde
switchdesk.src:32: W: unversioned-explicit-obsoletes %{name}-gnome
switchdesk.src:33: W: unversioned-explicit-provides %{name}-kde
switchdesk.src:34: W: unversioned-explicit-provides %{name}-gnome
switchdesk.src:187: W: macro-in-%changelog _datadir
switchdesk.src: W: summary-ended-with-dot A desktop environment switcher for
GNOME, KDE and AnotherLevel.
switchdesk.src: E: tag-not-utf8 %changelog
switchdesk.src: W: no-url-tag
switchdesk-gui.noarch: W: no-documentation
switchdesk-gui.noarch: E: script-without-shebang
/usr/share/switchdesk/backend.py
switchdesk-gui.noarch: W: summary-ended-with-dot A graphical interface for the
Desktop Switcher.
switchdesk-gui.noarch: E: tag-not-utf8 %changelog
switchdesk-gui.noarch: W: no-url-tag
3 packages and 0 specfiles checked; 5 errors, 12 warnings.

- Need to fix the above errors & warnings.
 * Summary is inexact: switchdesk also works for Fluxbox, FWVM, Icewm etc.
Maybe generalize it to "A desktop environment switcher"? Fix also description.
 * Since url is missing and we are upstream add disclaimer from
http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream

- Missing %doc: AUTHORS COPYING Changelog

- Enable smp make or add note if it doesn't work.

- Remove blank space from end of spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490462] Review Request: rpmorphan - List the orphaned rpm packages

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490462


leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@googlemail.co
   ||m




--- Comment #7 from leigh scott   2009-03-21 
18:36:34 EDT ---
Can you add  Requires: perl-Tk


[r...@localhost Desktop]# rpmorphan  -gui
WARNING can not find Tk perl module

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491491] New: Review Request: python-Jinja - A sandboxed python templating engine

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-Jinja - A sandboxed python templating engine

https://bugzilla.redhat.com/show_bug.cgi?id=491491

   Summary: Review Request: python-Jinja - A sandboxed python
templating engine
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: kon...@tylerc.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/python-Jinja.spec
SRPM URL:
http://konradm.fedorapeople.org/fedora/SRPMS/python-Jinja-1.2-1.fc10.src.rpm
Description:
Jinja is a sandboxed template engine written in pure Python licensed under
the BSD license. It provides a Django-like non-XML syntax and compiles
templates into executable python code. It's basically a combination of
Django templates and python code.

Note: This is a SAGE (https://fedoraproject.org/wiki/SIGs/SciTech/SAGE)
package.

Rpmlint output is clean.

Builds in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1252615

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744





--- Comment #23 from Joseph Smidt   2009-03-21 18:23:50 
EDT ---

> At some point I found the place where the fonts are called, and I patched the
> code so that it can call the Liberation Fonts instead. It seemed to have
> worked, and then I just removed the MS fonts from the package.

Do you still have the patch to do this?  This, and building on F11 with the
gcc-4.4 compilers is what's holding me up.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453422] Review Request: songbird - Mozilla based multimedia player

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453422





--- Comment #37 from Stephen Lau   2009-03-21 18:26:08 
EDT ---
(In reply to comment #35)
> Yes, I am aware of this and another bug. Please see the following threads:
> 
> http://bugzilla.songbirdnest.com/show_bug.cgi?id=15401
> http://bugzilla.songbirdnest.com/show_bug.cgi?id=15432
> 
> I have been using the gstreamer system library all along, and continue to do
> so. Even with the latest 0.10.22 gstreamer package the freezing issue is still
> there.
> 
> At this point we're going to have to wait on the upstreamed patches.
> 
> Stevel, comments?  

Yeah - I'll try to find out more detail this week on what exactly our
upstreamed patches are that are missing from the 0.10.22 packages, and what the
ETA is on landing them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226443] Merge Review: switchdesk

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226443


Jussi Lehtola  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jussi.leht...@iki.fi
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226376] Merge Review: rootfiles

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226376





--- Comment #1 from Jussi Lehtola   2009-03-21 18:16:02 
EDT ---
rpmlint output:
rootfiles.noarch: W: no-documentation
rootfiles.noarch: W: hidden-file-or-dir /root/.bashrc
rootfiles.noarch: W: hidden-file-or-dir /root/.cshrc
rootfiles.noarch: W: hidden-file-or-dir /root/.tcshrc
rootfiles.noarch: W: hidden-file-or-dir /root/.bash_logout
rootfiles.noarch: W: hidden-file-or-dir /root/.bash_profile
rootfiles.noarch: W: no-url-tag
rootfiles.noarch: W: non-etc-or-var-file-marked-as-conffile /root/.bash_logout
rootfiles.noarch: W: non-etc-or-var-file-marked-as-conffile /root/.bash_profile
rootfiles.noarch: W: non-etc-or-var-file-marked-as-conffile /root/.bashrc
rootfiles.noarch: W: non-etc-or-var-file-marked-as-conffile /root/.cshrc
rootfiles.noarch: W: non-etc-or-var-file-marked-as-conffile /root/.tcshrc
rootfiles.src: W: no-%build-section
rootfiles.src: W: no-url-tag
2 packages and 0 specfiles checked; 0 errors, 14 warnings.

All of these except the url tag warning are fine due to the special nature of
the package.

- For the url tag, add the disclaimer available at
http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream
to the spec file.

- Add %{?dist} to the release tag.

- Preserve time stamps with install -p.

After these are fixed the package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226376] Merge Review: rootfiles

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226376


Jussi Lehtola  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jussi.leht...@iki.fi
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485596] Review Request: phoronix-test-suite - A Comprehensive Linux Benchmarking System

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485596





--- Comment #10 from Joseph Smidt   2009-03-21 18:00:53 
EDT ---
Thanks for continuing the review.  Here are the new packages:

Spec URL: http://jsmidt.fedorapeople.org/phoronix-test-suite.spec
SRPM URL:
http://jsmidt.fedorapeople.org/phoronix-test-suite-1.6.0-3.fc10.src.rpm


Also, the upstream author had this to say:
"PHP FPDF and PHP Ming aren't external dependencies, but if either of those
packages are available in Fedora, they should be "Requires" for the PTS
package. The FPDF package allows the user to save the results to a PDF file and
the Ming package allows the user to render Adobe SWF graphs. These aren't
required unless you want to use those features, but they should be included if
available in Fedora."

I do not see either of those packages in Fedora.  If I am wrong let me know.  

Thanks again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226160] Merge Review: mpage

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226160


Jussi Lehtola  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226557] Merge Review: xfig

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226557


Jussi Lehtola  changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi




--- Comment #9 from Jussi Lehtola   2009-03-21 17:53:13 
EDT ---
(In reply to comment #8)
> should not this bug be close now ?  

No, Patrice hasn't reviewed the package yet.

Patrice: could you finish the review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491490] New: Review Request: ghmm - A library with data structures and algorithms for Hidden Markov Models

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ghmm - A library with data structures and algorithms 
for Hidden Markov Models

https://bugzilla.redhat.com/show_bug.cgi?id=491490

   Summary: Review Request: ghmm - A library with data structures
and algorithms for Hidden Markov Models
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: kon...@tylerc.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/ghmm.spec
SRPM URL:
http://konradm.fedorapeople.org/fedora/SRPMS/ghmm-0.7-1.svn2251.fc10.src.rpm
Description:
The General Hidden Markov Model library (GHMM) is a freely available
LGPL-ed C library implementing efficient data structures and algorithms
for basic and extended HMMs.

It is developed by the Algorithmics group at the Max Planck Institute
for Molecular Genetics.

Features:
  * Discrete and continuous emissions
  * Mixtures of PDFs for continuous emissions
  * Non-homogenous Markov chains
  * Pair HMMs (contributed by Genoscope)
  * Clustering and mixture modelling for HMMs
  * Graphical Editor HMMEd
  * Python bindings
  * XML-based file format



Note: This is a SAGE package
(https://fedoraproject.org/wiki/SIGs/SciTech/SAGE).

Rpmlint output:
ghmm.spec:72: W: rpm-buildroot-usage %prep -e 's|$(PYTHON) setup.py
install.*$|$(PYTHON) setup.py install -O1 --skip-build --root
${RPM_BUILD_ROOT}|' \
ghmm.src:72: W: rpm-buildroot-usage %prep -e 's|$(PYTHON) setup.py
install.*$|$(PYTHON) setup.py install -O1 --skip-build --root
${RPM_BUILD_ROOT}|' \

These are used so that when python libs are built/installed during the make
process, they use the correct flags. RPM_BUILD_ROOT is not defined here, it's
just reference when the makefile is run in %build/%install.

ghmm.x86_64: W: shared-lib-calls-exit /usr/lib64/libghmm.so.1.0.0
e...@glibc_2.2.5

Poor programming practice, not a packaging problem.

ghmm-devel.x86_64: W: no-documentation
ghmm-static.x86_64: W: no-documentation

Ignorable.

This builds in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1252576

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470703] Review Request: links 2 - text mode browser with graphics

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470703





--- Comment #18 from Lubomir Rintel   2009-03-21 16:56:35 EDT 
---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744





--- Comment #22 from Thomas Spura   2009-03-21 
16:25:45 EDT ---
(In reply to comment #21)
> So true type fonts are not allowed at all, or just not the MS ones?
> 

The MS ones have a 'Bad Licence'. They are not allowd, any other true type
fonts with a 'Good Licence' should be allowd.

> At some point I found the place where the fonts are called, and I patched the
> code so that it can call the Liberation Fonts instead. It seemed to have
> worked, and then I just removed the MS fonts from the package.

perfect ;-)

> Is this not an option, according to the legal team?

I did't tell them the context, only asked if the MS licence in the folder of
the fonts is a 'Good Licence' -> No.
After removing them, anything else should be allowed (-> completely GPLv2
AFAIK)

  Thomas

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488124] Review Request: gnubik - 3D interactive graphics puzzle

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488124





--- Comment #16 from Alexey Torkhov   2009-03-21 15:50:19 
EDT ---
(In reply to comment #15)
> gnubik desktop icon is not shown.  

Icon was put in wrong location. Thanks for catch!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 485596] Review Request: phoronix-test-suite - A Comprehensive Linux Benchmarking System

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485596





--- Comment #9 from Kevin Fenzi   2009-03-21 15:34:52 EDT ---
Joseph: Can you spin a new package with the deps again and I will look at doing
a review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488124] Review Request: gnubik - 3D interactive graphics puzzle

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488124


nucleo  changed:

   What|Removed |Added

 CC||alekc...@googlemail.com




--- Comment #15 from nucleo   2009-03-21 15:31:05 EDT 
---
gnubik desktop icon is not shown.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 489728] Review Request: kcheckers - Checkers board game

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489728


nucleo  changed:

   What|Removed |Added

 CC||alekc...@googlemail.com




--- Comment #2 from nucleo   2009-03-21 15:24:28 EDT 
---
May be it would be better to install icon in
/usr/share/icons/hicolor/32x32/apps/
and update of icon cache.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488100] Review Request: firebird - Firebird SQL database management system

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488100


Alexey Torkhov  changed:

   What|Removed |Added

 Attachment #336173|application/octet-stream|text/plain
  mime type||




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488100] Review Request: firebird - Firebird SQL database management system

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488100





--- Comment #19 from Philippe Makowski   
2009-03-21 15:03:07 EDT ---
Created an attachment (id=336173)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=336173)
new pec file

I made majors changes
please check this new version
if need, the rpms is there :
http://ibphoenix.fr/fichiers/firebird-2.1.1.17910-4.fc10.src.rpm

don't hesitate to contact me, I'm a member of the Firebird admin team
but please use pmakowski AT ibphoenix DOT com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744





--- Comment #21 from juanucl...@gmail.com   2009-03-21 
14:40:42 EDT ---
Hi,

So true type fonts are not allowed at all, or just not the MS ones?

At some point I found the place where the fonts are called, and I patched the
code so that it can call the Liberation Fonts instead. It seemed to have
worked, and then I just removed the MS fonts from the package.

Is this not an option, according to the legal team?

--Juan Carlos

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744





--- Comment #20 from Thomas Spura   2009-03-21 
14:12:23 EDT ---
I'm giving up for now...

This is my fist try to create a .spec.

Earlier, I had anything in one package, and installing and running worked.
Now to fullfil the guidelines, I had tried to create a -devel package, too.
This spec is not working anymore, but maybe you can get some usefull parts of
it...

http://www.students.uni-mainz.de/spurath/public/fedora/root.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225945] Merge Review: jfsutils

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225945





--- Comment #6 from Jussi Lehtola   2009-03-21 14:07:44 
EDT ---
While you're at it, add %{?dist} to the release tag.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476720


Ankur Sinha  changed:

   What|Removed |Added

 AssignedTo|sanjay_an...@yahoo.co.in|sanjay.an...@gmail.com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486804] Review Request: libferrisloki - customized build of Loki library from Modern C++ Design for libferris

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486804





--- Comment #4 from Michael Schwendt   2009-03-21 
13:45:05 EDT ---
Haven't had a look at the update rpms yet, so just some answers:


> If possible I'd like to continue using the same spec in Fedora
> and in the OBS to make openSUSE rpms too.

I'm not aware of any policy that disallows this. However, history has shown
that it's more convenient to keep spec files distribution-specific and clean.

Often distribution-independent spec files are expanded with many conditional
sections, which reduce readability and sometime even cause side-effects. This
can get really ugly in places where you must use Fedora-specific macros or
scriptlet fragments. And also in the %changelog.


> License: LGPLv2+, Boost, Copyright only
>
> I'm not sure how to chain them though.

https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios


> %makeinstall

https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744





--- Comment #19 from Thomas Spura   2009-03-21 
13:22:35 EDT ---
Hi,

I just asked on fedora-legal-list about the licence of the fonts within root:

It's not a 'Good Licence', so possibly there is no chance of a positive
review!!!

It could be a solution, if we use the X11 Rendering and not the truetypes.

In scientificlinux this package is called 'cernroot'. I like this name, because
there is also a cernlibs package in fedora. Consider a rename ;-)

I have tried to build my on root.spec with much more enabled features, but am
not yet ready to publish it. I'll do so, if it's finished…



ATM %dir %{_datadir}/root/fonts does not work as a result of the bad licence…

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490723





--- Comment #3 from Pierre-YvesChibon   2009-03-21 
12:56:53 EDT ---
SPEC:
http://pingou.fedorapeople.org/RPMs/R-IRanges.spec
SRPM:
http://pingou.fedorapeople.org/RPMs/R-IRanges-1.0.14-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491425] Review Request: R-RODBC - An ODBC database interface for R

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491425





--- Comment #1 from Mattias Ellert   2009-03-21 
12:56:43 EDT ---
Created an attachment (id=336169)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=336169)
Review comments

I attach my review. Package looks good except for some minor license issues
that need clarification.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490580] Review Request: faust - Compiled language for real-time audio signal processing

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490580


Orcan 'oget' Ogetbil  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Orcan 'oget' Ogetbil   2009-03-21 
12:50:40 EDT ---
I thank you for the review!

New Package CVS Request
===
Package Name: faust
Short Description: Compiled language for real-time audio signal processing
Owners: oget
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490723





--- Comment #2 from Pierre-YvesChibon   2009-03-21 
12:49:21 EDT ---
Indeed R-Matrix is needed for build, I will update the spec in that way.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490724] Review Request: R-RUnit - R Unit test framework

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490724





--- Comment #6 from Pierre-YvesChibon   2009-03-21 
12:47:22 EDT ---
Oups, thanks for pointing this out, I'll fix this.

The mail to upstream has been sent yesterday, I'm waiting for an answer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490580] Review Request: faust - Compiled language for real-time audio signal processing

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490580


Conrad Meyer  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Conrad Meyer   2009-03-21 12:39:08 EDT 
---
This looks very good, thank you for packaging it for Fedora. APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490724] Review Request: R-RUnit - R Unit test framework

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490724





--- Comment #5 from Conrad Meyer   2009-03-21 12:37:17 EDT 
---
(In reply to comment #4)
> R packaging guildlines say: "Note that other files, such as CONTENTS, INDEX,
> NAMESPACE, and help/ are not %doc, since proper R functionality depends on
> their presence."
> 
> The spec file lists CONTENTS, INDEX and NAMESPACE as %doc.  

These should be fixed, then.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491425] Review Request: R-RODBC - An ODBC database interface for R

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491425


Mattias Ellert  changed:

   What|Removed |Added

 CC||mattias.ell...@fysast.uu.se
 AssignedTo|nob...@fedoraproject.org|mattias.ell...@fysast.uu.se




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478365] Review Request: perl-Verilog-CodeGen - Verilog code generator

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478365


Chitlesh GOORAH  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?




--- Comment #10 from Chitlesh GOORAH   2009-03-21 10:58:10 
EDT ---
Kevin, were the cvs branches created ?


Checking out module: 'perl-Verilog-CodeGen'
cvs server: cannot find module `perl-Verilog-CodeGen' - ignored
cvs [checkout aborted]: cannot expand modules
ERROR: "perl-Verilog-CodeGen" module does not exist in cvs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225945] Merge Review: jfsutils

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225945





--- Comment #5 from Josh Boyer   2009-03-21 11:01:20 EDT ---
I've done most of this locally now.  Still need to look at the weird debuginfo
stuff.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476720


Ankur Sinha  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #17 from Ankur Sinha   2009-03-21 10:25:29 
EDT ---
New Package CVS Request
===
Package Name: beteckna-fonts
Short Description: Beteckna sans-serif fonts 
Owners: ankursinha
Branches: F-9 F-10
InitialCC: fonts-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225898] Merge Review: imake

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225898


Jussi Lehtola  changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi




--- Comment #2 from Jussi Lehtola   2009-03-21 09:52:29 
EDT ---
I agree.

No progress on this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225945] Merge Review: jfsutils

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225945





--- Comment #4 from Jussi Lehtola   2009-03-21 09:48:16 
EDT ---
rpmlint output:
jfsutils.src:28: W: configure-without-libdir-spec
jfsutils.src: W: summary-ended-with-dot Utilities for managing the JFS
filesystem.
jfsutils.x86_64: W: summary-ended-with-dot Utilities for managing the JFS
filesystem.
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_dtree.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_dinode.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/libfs/log_work.c
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_superblock.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/mkfs/inodes.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_dmap.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/libfs/message.c
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_unicode.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_xtree.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_types.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_btree.h
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/libfs/devices.c
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/mkfs/mkfs.c
jfsutils-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/jfsutils-1.1.13/include/jfs_imap.h
3 packages and 0 specfiles checked; 0 errors, 17 warnings.


- Change buildroot to 
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)

- Use %configure --sbindir=/sbin, and enable smp make.

- Remove
# let brp-compress handle this policy
rm -f $RPM_BUILD_ROOT/%{_mandir}/*/*.gz

- Remove buildroot check from clean phase.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225945] Merge Review: jfsutils

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225945


Jussi Lehtola  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jussi.leht...@iki.fi
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




--- Comment #3 from Jussi Lehtola   2009-03-21 09:32:52 
EDT ---
I'll take on the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225978] Merge Review: kudzu

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225978


Jussi Lehtola  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226146] Merge Review: mkinitrd

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226146


Jussi Lehtola  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490724] Review Request: R-RUnit - R Unit test framework

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490724


Mattias Ellert  changed:

   What|Removed |Added

 CC||mattias.ell...@fysast.uu.se




--- Comment #4 from Mattias Ellert   2009-03-21 
08:29:56 EDT ---
R packaging guildlines say: "Note that other files, such as CONTENTS, INDEX,
NAMESPACE, and help/ are not %doc, since proper R functionality depends on
their presence."

The spec file lists CONTENTS, INDEX and NAMESPACE as %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490723] Review Request: R-IRanges - Low-level containers for storing sets of integer ranges

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490723


Mattias Ellert  changed:

   What|Removed |Added

 CC||mattias.ell...@fysast.uu.se




--- Comment #1 from Mattias Ellert   2009-03-21 
08:22:00 EDT ---
Package does not build for me - missing BuildRequires?

** R
** inst
** preparing package for lazy loading
Error in loadNamespace(i[[1]], c(lib.loc, .libPaths())) :
  there is no package called 'Matrix'
Calls:  ... namespaceImportFrom -> asNamespace -> loadNamespace
Execution halted
ERROR: lazy loading failed for package 'IRanges'
** Removing
'/builddir/build/BUILDROOT/R-IRanges-1.0.14-1.fc10.x86_64/usr/lib64\
/R/library/IRanges'
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.9f4Ede (%install)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491430] Review Request: sslogger - A keystroke logging utility for privileged user escalation

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491430





--- Comment #8 from Ed Brand   2009-03-21 08:22:09 EDT ---
*** Bug 491464 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491464] Review Request: sslogger - A keystroke logging utility for privileged user escalation

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491464


Ed Brand  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE




--- Comment #1 from Ed Brand   2009-03-21 08:22:09 EDT ---


*** This bug has been marked as a duplicate of 491430 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491430] Review Request: sslogger - A keystroke logging utility for privileged user escalation

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491430





--- Comment #9 from Ed Brand   2009-03-21 08:24:54 EDT ---
(In reply to comment #7)
> I really don't understand why you submitted this package 6 more times total 7
> times including this??
> 
> Make sure you always reports package review request of any package only once. 
>  

Apologies, first time user of Bugzilla, I figured out what I was doing wrong

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 489117] Review Request: tulrich-tuffy-fonts - Generic sans font

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489117





--- Comment #3 from Nicolas Mailhot   2009-03-21 
08:11:04 EDT ---
(In reply to comment #2)
> I updated the existing wiki page: https://fedoraproject.org/wiki/Tuffy_fonts
> (is this level of detail ok with you? - I am still new to font packaging)

This is good enough (someday we'll figure how to create pretty font previews)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491464] New: Review Request: sslogger - A keystroke logging utility for privileged user escalation

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: sslogger - A keystroke logging utility for privileged 
user escalation

https://bugzilla.redhat.com/show_bug.cgi?id=491464

   Summary: Review Request: sslogger - A keystroke logging utility
for privileged user escalation
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: edbr...@brandint.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://sourceforge.net/project/platformdownload.php?group_id=253689
SRPM URL: http://sourceforge.net/project/platformdownload.php?group_id=253689
Description: sslogger is session keystroke logging utility that allows
permitted
users to execute commands, or open interactive shells as the  superuser
or  another  user  as specified by sudo rules in the sudoers file. When
used in interactive session mode, sslogger records keystrokes in a spe-
cial file. This file can later be reviewed by running a replay command.

sslogger  also  provides  the ability to run in command mode in which a
command can be executed as another user. This  allows  sslogger  to  be
used within a script in non-interactive script.

This is my first package and I am seeking a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476720] Review Request: beteckna-sfd-fonts - Beteckna fonts

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476720


Nicolas Mailhot  changed:

   What|Removed |Added

 AssignedTo|nicolas.mail...@laposte.net |sanjay_an...@yahoo.co.in
   Flag|fedora-review?, |fedora-review+
   |needinfo?(sanjay_an...@yaho |
   |o.co.in)|




--- Comment #16 from Nicolas Mailhot   2009-03-21 
07:56:11 EDT ---
Hi Ankur

Some nitpicking:

1. your common_desc declaration is still using define not global

2. I'm not sure doing %clean after %files is a good idea

3. rpmlint complains of
beteckna-fonts.src: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line
1)

4. rpmlint complains of
beteckna-fonts-common.noarch: W: file-not-utf8
/usr/share/doc/beteckna-fonts-common-0.3/CHANGELOG

(see the gfs font specs for examples of txt file recoding to UTF-8)

5. it seems none of those fonts have normal minuscules. Therefore it'd probably
be better to register them as "fantasy" not "sans-serif" in your fontconfig
files

However the rest of the packaging is sane and much better than some of the
stuff I've seen recently and the problems are not worth blocking import

⚶⚶⚶ APPROVED ⚶⚶⚶

Please do consider fixing the remaining small problems however


You can now continue from
https://fedoraproject.org/wiki/Font_package_lifecycle#3.a


As for the warnings emitted by fontforge during build, they unfortunately point
problems in the original upstream file. You should relay them to the font
author(s) so they get fixed.

If you're interested in learning some font creation stuff, you can try to fix
them yourself, and create a patch for upstream. eimai and moyogo on #dejavu
will usually be helpful to people discovering fontforge.

⇒ REASSIGNING now the review is done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478434] Review Request: FSMDesigner4 - A Finite State Machine design tool

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478434


Chitlesh GOORAH  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||WONTFIX




--- Comment #2 from Chitlesh GOORAH   2009-03-21 07:34:17 
EDT ---
The generated FSM is not ready for real life use. I'm closing this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486686] Review Request: tkgate - Digital Circuit Simulator

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486686


Chitlesh GOORAH  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE




--- Comment #11 from Chitlesh GOORAH   2009-03-21 07:35:24 
EDT ---
Already pushed in stable repos.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 462711] Review Request: Mothanna-fonts - Mothanna-fonts from Arabeyes.org

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462711





--- Comment #6 from Nicolas Mailhot   2009-03-21 
07:28:48 EDT ---
(In reply to comment #5)
> What is the status of this?  

The original submitter needs to take care of the review feedback, or someone
else needs to submit a competing review request

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486687] Review Request: chisholm-rubbing-fonts - Decorative Sans Serif Font

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486687





--- Comment #10 from Nicolas Mailhot   2009-03-21 
07:27:41 EDT ---
(In reply to comment #9)
> Enjoyed meeting you all too. Very worth while afternoon.
> What about the comments form Nicolas Mailhot? Presumably I need to re-do the
> fontconfig file?

If you want it to actually do something, yet

> Also forgive my ignorance but remind me what/where FAS is again?  

http://fedoraproject.org/wiki/Joining_the_Fonts_SIG

(I apologize for the long time I spent not checking if this review progressed)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480851] Review Request: ccrypt - Secure encryption and decryption of files and streams

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480851





--- Comment #9 from Dan Horák   2009-03-21 06:41:04 EDT ---
Hm, in my opinion we should insist on a positive result from the built-in
tests.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 486977] Review Request: gnu-free-fonts

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977


Nicolas Mailhot  changed:

   What|Removed |Added

   Flag||needinfo?(l...@jcomserv.net
   ||)




--- Comment #16 from Nicolas Mailhot   2009-03-21 
05:50:58 EDT ---
And now you have another kind of dangling symlink

/etc/fonts/conf.d/60-gnu-free-mono.conf ->
/usr/share/fontconfig/conf.avail/gnu-free-mono.conf

Would it be so hard to just use the pattern documented in the official spec
templates instead of exploring every possible broken alternative? This is
getting really old.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476359] Review Request: compiz-fusion-unsupported - Additional Compiz Fusion plugins for Compiz

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476359





--- Comment #3 from Felix Kaechele   2009-03-21 04:17:17 EDT 
---
Here are some things I found that should be fixed before I start the final
review:
- the package misses the BuildDependency mesa-libGL-devel
- the package obsoletes a package that has never been in Fedora
- the gnome subpackage should do a stricter Require. E.g. %{name} =
%{version}-%{release}
- fix the following rpmlint errors:
compiz-fusion-unsupported.src:25: W: unversioned-explicit-obsoletes
compiz-fusion-plugins-unsupported
compiz-fusion-unsupported.x86_64: W: obsolete-not-provided
compiz-fusion-plugins-unsupported
compiz-fusion-unsupported-gnome.x86_64: W: no-documentation
compiz-fusion-unsupported-gnome.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/compiz-atlantis.schemas
compiz-fusion-unsupported-gnome.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/compiz-snow.schemas
compiz-fusion-unsupported-gnome.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/compiz-mswitch.schemas
compiz-fusion-unsupported-gnome.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/compiz-tile.schemas
compiz-fusion-unsupported-gnome.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/compiz-fakeargb.schemas
- you could improve the legibility of the specfile by making use of indentation
but that's just an idea and not required.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 470914] Review Request: slv2 - An LV2 host library

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470914


Orcan 'oget' Ogetbil  changed:

   What|Removed |Added

   Flag|needinfo?   |




--- Comment #7 from Orcan 'oget' Ogetbil   2009-03-21 
03:21:40 EDT ---
Please backport this patch from the upstream trunk:
   http://dev.drobilla.net/changeset/1948
from
   http://dev.drobilla.net/ticket/341

The compilation of slv2 does not fail without it but some plugins which need
slv2 as a dependency need this patch, otherwise they won't compile.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490317] Review Request: rumor - Really Unintelligent Music transcriptOR

2009-03-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490317





--- Comment #2 from Orcan 'oget' Ogetbil   2009-03-21 
03:12:54 EDT ---
(In reply to comment #1)

> * rpmlint: TODO
> rpmlint SPECS/rumor.spec RPMS/i386/rumor-* SRPMS/rumor-1.0.3b-1.fc10.src.rpm
> SPECS/rumor.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line
> 1)
> rumor.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 1)
> 3 packages and 1 specfiles checked; 0 errors, 2 warnings.
> - just a very minor mixture of spaces and tabs
> 

I wonder how this rpmlint survived all my checks. Fixed!


> * optflags: TODO
> - I would delete the -O0 in the configure file completely and not substitute 
> it
> with -O2. If Fedora changes the rpmoptflags, there will be two different -Ox
> options (the one from rpmoptflags and the one from the configure) (e.g. "sed 
> -i
> 's|-O0||' configure" could be used)
> - the only uncommon gcc option is "-ggdb3", but that's no problem, it will 
> only
> add some more info to the debug infos (e.g. macros) - gdb works still fine 
> with
> rumor's debuginfo
> 

Good point. Thanks for bringing this up. 

Spec URL: http://oget.fedorapeople.org/review/rumor.spec
SRPM URL: http://oget.fedorapeople.org/review/rumor-1.0.3b-2.fc10.src.rpm

Thank you Christian, once more :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review