[Bug 491317] Review Request: mingw32-gstreamer - MinGW Windows gstreamer library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491317 --- Comment #14 from Levente Farkas lfar...@lfarkas.org 2009-06-08 03:50:02 EDT --- sorry i was a serious accident 2 weeks ago and was at the intensive care for too weeks yesterday i can come home. i've to be in my bad for another 6 weeks. may be in a few weeks i'll be do something useful. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499539] Review Request: saxpath - Simple API for xpath
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499539 --- Comment #9 from Yang Yong yy...@redhat.com 2009-06-08 04:42:02 EDT --- overholt, below is the new SPEC/SRPM/POM URLs, have fixed the warnings of wrong-file-end-of-line-encoding and mixed-use-of-spaces-and-tabs, please review again, thanks. SPEC URL: http://yyang.fedorapeople.org/saxpath/saxpath.spec SRPM URL: http://yyang.fedorapeople.org/saxpath/saxpath-1.0-1.4.fc12.src.rpm POM URL: http://yyang.fedorapeople.org/saxpath/saxpath-1.0.pom -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504430] Review Request: healpy - A python wrapper of the healpix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504430 --- Comment #7 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 05:12:24 EDT --- (In reply to comment #6) (In reply to comment #5) BuildRequires: healpix-c++ BuildRequires: cfitsio is redundant (these are pulled in by the -devel packages). I meant: Requires: healpix-c++ Requires: cfitsio so I believe this is now fixed. Nope, that is in collision with http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires Also, you really should increment the release tag every time you make a new revision. Not incrementing it makes it harder for me to keep track of what has been done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504430] Review Request: healpy - A python wrapper of the healpix library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504430 --- Comment #8 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 05:17:14 EDT --- Also, the package does not build in mock. You need at least BR: numpy, maybe you need also the other python packages as BR. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481727] Review Request: python-EnvisageCore - Extensible Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481727 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Parag AN(पराग) panem...@gmail.com 2009-06-08 05:15:57 EDT --- koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1398754 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479876] Review Request: yabasic - Small basic interpreter with simple graphics and printing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479876 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Status|NEW |CLOSED Depends on||201449(FE-DEADREVIEW) Resolution||WONTFIX Flag|needinfo?(fab...@bernewirel | |ess.net)| --- Comment #3 from Fabian Affolter fab...@bernewireless.net 2009-06-08 05:26:15 EDT --- Sorry, I was a bit short on time in the past weeks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481727] Review Request: python-EnvisageCore - Extensible Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481727 Rakesh Pandit rpan...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Rakesh Pandit rpan...@redhat.com 2009-06-08 05:31:39 EDT --- Thanks, New Package CVS Request === Package Name: python-EnvisageCore Short Description: Extensible Application Framework Owners: rakesh Branches: F-9 F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504077] Review Request: gnusim8085 - Intel 8085 assembly language simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504077 Rangeen Basu Roy Chowdhury sherry...@gmail.com changed: What|Removed |Added Priority|low |medium Flag||fedora-cvs? --- Comment #12 from Rangeen Basu Roy Chowdhury sherry...@gmail.com 2009-06-08 05:38:17 EDT --- New Package CVS Request === Package Name: gnusim8085 Short Description: A graphical simulator for Intel 8085 microprocessor Owners: sherry151 chitlesh Branches: F-10 F-11 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 496742] Review Request: elfelli - Visualisation tool for flux lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=496742 --- Comment #5 from Fabian Affolter fab...@bernewireless.net 2009-06-08 05:52:43 EDT --- It seems that upstream made some changes. Time for an update. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485652] Review Request: navit - Car navigation system with routing engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485652 --- Comment #4 from Fabian Affolter fab...@bernewireless.net 2009-06-08 05:49:42 EDT --- I'm (and was) a bit short on time. Several stuff needs to be patched. There are a lot of patches, see Debian patch tracking system [1], and these patches needs to be integrated. [1] http://patch-tracking.debian.net/package/navit/0.1.1.~svn2246-1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499993] Review Request: dvtm - Tiling window management for the console
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=43 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2009-06-08 06:50:15 EDT --- dvtm-0.5.1-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/dvtm-0.5.1-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499993] Review Request: dvtm - Tiling window management for the console
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=43 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-06-08 06:49:24 EDT --- dvtm-0.5.1-5.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/dvtm-0.5.1-5.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499993] Review Request: dvtm - Tiling window management for the console
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=43 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2009-06-08 06:50:29 EDT --- dvtm-0.5.1-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/dvtm-0.5.1-5.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483434] Review Request: argtable2 - A library for parsing GNU style command line arguments
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483434
--- Comment #19 from Michael Schwendt mschwe...@gmail.com 2009-06-08
06:50:57 EDT ---
Using macros for commands, which are supposed to be located in $PATH, doesn't
add any value.
For example, a configure script would fail, if it searched for cp in $PATH,
but an RPM build environment redefined %__cp to something outside $PATH. Same
applies to lots of other tools. Their macro values expand to absolute path, but
none of these paths are passed to the configure scripts, make, or other build
frameworks. Even with major redefinition of macro values, you could not fully
customise the rpmbuild without modifying the spec/src.rpm.
Often, macro usage adds further inconsistencies even directly in the spec
files:
%{__rm} -rf $RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name '*.la' -exec rm -f {} \;
Once %{__rm}, below plain rm. find is macro-less. /sbin/ldconfig in the
scriptlets is macro-less, too.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499579] Review Request: libxdg-basedir - Implementation of the XDG Base Directory Specifications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499579
--- Comment #3 from Michal Nowak mno...@redhat.com 2009-06-08 06:49:50 EDT
---
(In reply to comment #2)
I've reviewed the package and it looks ok. There are only some minor and
uncritical issues:
Thanks for the review, Christian. Good work.
* rpmlint: TODO
rpmlint SPECS/libxdg-basedir.spec SRPMS/libxdg-basedir-1.0.0-1.fc10.src.rpm
RPMS/i386/libxdg-basedir-*
libxdg-basedir.i386: W: no-documentation
libxdg-basedir-devel.i386: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 2 warnings.
In general it is not a problem to have no documentation if
a package doesn't provide any. ;-) However, in this specific case
the package provides a doxygen API documentation (make doxygen-all).
It would be good if it could be added to the devel package.
Now we have -docs sub-package with Doxygen generated documentation.
* naming: OK
- name matches upstream
- spec file name matches package name
* sources: TODO
- e32bcfa772fb57e8e1acdf9616a8d567 libxdg-basedir-1.0.0.tar.gz
- sources matches upstream
- Source0 tag ok
- spectool -g works
- upstream version 1.0.1 was released a couple of weeks ago, please update to
the new version (according to upstream's git repo it looks like a minor
bug fix release)
Packed.
* License: TODO
- License MIT acceptable
- License in spec file matches the actual license (MIT license header in
libxdg-basedir-1.0.0/src/basedir.c )
- No License file included, so there is no need to package it.
- It would be better if upstream would provide a license file. According to
the
Review guidelines the packager is encouraged to query upstream to include it.
However this will not block the review.
Encouraged :). You're in Cc.
* spec file written in English and legible: OK
* compilation: OK
- supports parallel build
- RPM_OPT_FLAGS are correctly used
- builds in mock (F10)
- builds in koji:
F10: https://koji.fedoraproject.org/koji/taskinfo?taskID=1394643
F11: https://koji.fedoraproject.org/koji/taskinfo?taskID=1394648
F12: https://koji.fedoraproject.org/koji/taskinfo?taskID=1397616
* BuildRequires: OK
- no build requires are necessary
* locales handling: OK (n/a)
* ldconfig in %post and %postun: OK
* package owns all directories that it creates: TODO
- %{_libdkir}/pkgconfig is created, but not owned by libxdg-basedir-devel
- please add a Requires: pkgconfig to the devel package
Added.
* no files listed twice in %files: OK
* file permissions: OK
- %defattr used
- actual permissions in packages ok
* %clean section: OK
* macro usage: OK
* code vs. content: OK (only code)
* large documentation into subpackage: OK (n/a)
* header files in -devel subpackage: OK
* static libraries in -static package: OK (n/a)
* package containing *.pc files must Requires: pkgconfig: TODO (see above)
* *.so link in -devel package: OK
* - devel package requires base package using fully versioned dependency: OK
* packages must not contain *.la files: OK
* GUI applications must provide *.desktop file: OK (n/a)
* packages must not own files/dirs already owned by other packages: OK
* rm -rf $RPM_BUILD_ROOT at the beginning of %install: OK
* all filenames UTF-8: OK
* functional test: OK
- compiling the provided test applications
tests/testfind and tests/testdump
- test apps compile successfully and the reported directory names seem to be
meaningful
Added to %make check.
* debuginfo sub-package: OK
- non-empty
- debuginfo file works together with gdb
--
http://mnowak.fedorapeople.org/libxdg-basedir/libxdg-basedir.spec
http://mnowak.fedorapeople.org/libxdg-basedir/libxdg-basedir-1.0.1-1.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491317] Review Request: mingw32-gstreamer - MinGW Windows gstreamer library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491317 --- Comment #15 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2009-06-08 06:56:29 EDT --- Thanks for the heads up. Take your time to get well first. We'll continue with the review whenever you're well enough, even if that takes a couple of weeks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499993] Review Request: dvtm - Tiling window management for the console
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=43 Rakesh Pandit rpan...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481734] Review Request: python-EnvisagePlugins - Plug-ins for the Envisage framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481734 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review+ --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2009-06-08 07:19:33 EDT --- Review: + package builds in mock (rawhide i586). koji Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=1398881 + rpmlint is silent for SRPM and for RPM. + source files match upstream url bca0c184cc3021e25b90320f53c19af3e7f4e5b2 EnvisagePlugins-3.0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1: you should use %global over %define APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481734] Review Request: python-EnvisagePlugins - Plug-ins for the Envisage framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481734 Rakesh Pandit rpan...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Rakesh Pandit rpan...@redhat.com 2009-06-08 07:25:50 EDT --- Thanks, New Package CVS Request === Package Name: python-EnvisagePlugins Short Description: Plug-ins for the Envisage framework Owners: rakesh Branches: F-9 F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 486804] Review Request: libferrisloki - customized build of Loki library from Modern C++ Design for libferris
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486804 --- Comment #7 from Michael Schwendt mschwe...@gmail.com 2009-06-08 07:25:40 EDT --- * Currently doesn't even build, because the %files section is unmaintained: error: Installed (but unpackaged) file(s) found: /usr/include/FerrisLoki/Extensions.cpp /usr/include/FerrisLoki/OrderedStatic.cpp /usr/include/FerrisLoki/SafeFormat.cpp /usr/include/FerrisLoki/Singleton.cpp /usr/include/FerrisLoki/SmallObj.cpp /usr/include/FerrisLoki/SmartPtr.cpp /usr/include/FerrisLoki/StrongPtr.cpp /usr/lib/libferrisloki.a /usr/lib/libferrisloki.la * It would be extremely helpful (not just during review) if you maintained the spec %changelog and increased the Release value with every update of your package. It's something you would need to do for future updates anyway, so early practice would be beneficial. The latest package (from April 13th) is still ferrisloki-3.0.2-50021.src.rpm with only two changelog entries from 2001 and 2004. What exactly does the 50021 release value mean? * Fedora's optflags are used, but duplicated, and an appended -O3 -DNDEBUG overrides them. https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags * https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag * https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package * https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 * https://fedoraproject.org/wiki/Packaging:ReviewGuidelines * https://fedoraproject.org/wiki/PackageMaintainers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499336] Review Request: flickcurl - C library for the Flickr API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499336 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-06-08 07:39:57 EDT --- flickcurl-1.10-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/flickcurl-1.10-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499336] Review Request: flickcurl - C library for the Flickr API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499336 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-06-08 07:39:19 EDT --- flickcurl-1.10-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/flickcurl-1.10-3.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504469] Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 --- Comment #4 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:41:12 EDT --- (In reply to comment #1) - Please check if Rakefile or install.rb are needed for binary rpm. See below. - $ gem contents term-ansicolor - expects that examples/ directory should be under %geminstdir. While we allow (don't forbid) to delete some files listed in $ gem contents gemname) if packagers think they are not needed, I don't think moving examples/ directory under %gemdir/doc is needed. I adjusted all the packages to contain all the files gem contents list (reverted the deletes). I feel that it should always be consistent with the actual contents and don't think it's worth patching the lists for any of the files I used to remove. SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-term-ansicolor.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-term-ansicolor-1.0.3-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499336] Review Request: flickcurl - C library for the Flickr API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499336 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-06-08 07:40:29 EDT --- flickcurl-1.10-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/flickcurl-1.10-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499336] Review Request: flickcurl - C library for the Flickr API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499336 Rakesh Pandit rpan...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504478] Review Request: rubygem-diff-lcs - Provide a list of changes between two sequenced collections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504478 --- Comment #2 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:45 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-diff-lcs.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-diff-lcs-1.1.2-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499336] Review Request: flickcurl - C library for the Flickr API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499336 Rakesh Pandit rpan...@redhat.com changed: What|Removed |Added Resolution|NEXTRELEASE |CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504476 --- Comment #2 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:49 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-newgem.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-newgem-1.4.1-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504472] Review Request: rubygem-shotgun - Automatic reloading version of the rackup command
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504472 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:55 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-shotgun.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-shotgun-0.3-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504474] Review Request: rubygem-rack-test - Simple testing API built on Rack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504474 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:51 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rack-test.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rack-test-0.3.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504470] Review Request: rubygem-syntax - Ruby library for performing simple syntax highlighting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504470 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:58 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-syntax.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-syntax-1.0.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504479] Review Request: rubygem-cucumber - Tool to execute plain-text documents as functional tests
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504479 --- Comment #2 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:44 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-cucumber.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-cucumber-0.3.10-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504477] Review Request: rubygem-launchy - Helper class for cross-platform launching of applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504477 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:46 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-launchy.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-launchy-0.3.3-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504481] Review Request: rubygem-builder - Provide a simple way to create XML markup and data structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504481 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:42 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-builder.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-builder-2.1.2-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504480] Review Request: rubygem-configuration - Pure Ruby scoped configuration files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504480 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:43 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-configuration.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-configuration-0.0.5-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484798] Review Request: xiphos - Bible study and research tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484798 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Nils Philippsen nphil...@redhat.com 2009-06-08 07:45:51 EDT --- Approved. One remaining minor issue: - WARNING/CHECK: rpmlint on xiphos-3.1-1.fc11.src.rpm: xiphos.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 1) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- probably trailing spaces on the first line. Please fix that when/after importing into CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504471] Review Request: rubygem-sinatra - Ruby-based web application framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504471 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:57 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-sinatra.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-sinatra-0.9.2-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504468] Review Request: rubygem-treetop - A Ruby-based text parsing and interpretation DSL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504468 --- Comment #2 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:45:01 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-treetop.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-treetop-1.2.5-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504473] Review Request: rubygem-rubigen - A framework to allow Ruby applications to generate file/folder stubs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504473 --- Comment #2 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:54 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rubigen.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rubigen-1.5.2-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504475] Review Request: rubygem-polyglot - Allow hooking of language loaders for specified extensions into require
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504475 --- Comment #1 from Lubomir Rintel lkund...@v3.sk 2009-06-08 07:44:50 EDT --- Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-polyglot.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-polyglot-0.2.5-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483434] Review Request: argtable2 - A library for parsing GNU style command line arguments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483434 --- Comment #20 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 07:52:26 EDT --- (In reply to comment #19) Using macros for commands, which are supposed to be located in $PATH, doesn't add any value. Yeah, but using them is not forbidden. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 495692] Review Request: tslib - Touchscreen Access Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495692 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mschwe...@gmail.com Flag||fedora-review+ --- Comment #8 from Michael Schwendt mschwe...@gmail.com 2009-06-08 07:52:57 EDT --- APPROVED [...] Some observations, though: * Version 1.0 of tslib uses version 0.0 in its SONAME and in the pkg-config file (libts-0.0.pc). Especially the latter is a questionable decision, because the pkg-config file doesn't do anything special and only returns the non-versioned -lts via --libs. There's no reason why upstream could not have named the file libts.pc then. Pkg-config can evaluate the internal Version field to requires specific versions or version-ranges. * The modules/plugins pollute the automatic RPM Provides (and hence the metadata) with their *.so names: $ rpm -qp --provides tslib-1.0-1.fc10.i386.rpm|grep -e so[^.] arctic2.so collie.so corgi.so dejitter.so h3600.so input.so linear.so linear_h2200.so mk712.so pthres.so ucb1x00.so variance.so Harmless, since nothing ought to depend on such symbols, but it's pollution nevertheless. * Asking upstream to run autogen.sh prior to creating the source tarball would be helpful. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483434] Review Request: argtable2 - A library for parsing GNU style command line arguments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483434 --- Comment #21 from Michael Schwendt mschwe...@gmail.com 2009-06-08 08:00:02 EDT --- Right, and I did not say they would be forbidden. I just replied to comment 13. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484798] Review Request: xiphos - Bible study and research tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484798 Deji Akingunola dakin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Deji Akingunola dakin...@gmail.com 2009-06-08 08:33:53 EDT --- (In reply to comment #10) Approved. Thanks Nils. I've fixed the trailing spaces issues. New Package CVS Request === Package Name: xiphos Short Description: Bible study and research tool Owners: deji Branches: F-9 F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489686 --- Comment #28 from Conrad Sanderson conrads...@ieee.org 2009-06-08 08:45:01 EDT --- (In reply to comment #27) Conrad, if you are still confronting with unstripped-binary-or-object rpmlint warning, would you check if you have redhat-rpm-config surely installed? Installing redhat-rpm-config appears to have fixed the problem -- many thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504283] Review Request: AGReader - Console reader for viewing AmigaGuide files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504283 --- Comment #4 from Jon Ciesla l...@jcomserv.net 2009-06-08 08:55:06 EDT --- Thanks! Builds are failing as it's still blocked. Rel-eng ticket: https://fedorahosted.org/rel-eng/ticket/1917 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=489686
--- Comment #29 from Conrad Sanderson conrads...@ieee.org 2009-06-08
09:33:03 EDT ---
(In reply to comment #26)
%doc README.txt LICENSE.txt
should only be placed once and preferably on the %{name}/main package. It is
not important that all -devel should entail documentation.
I've redone the spec file -- rpmlint now gives no warnings and no errors.
http://arma.sf.net/fedora/armadillo.spec
http://arma.sf.net/fedora/armadillo-0.6.11-4.fc10.src.rpm
The -devel package needs to contain all the original text files and
documentation, as they are referred to in the upstream README.txt file. The
documentation is included here rather than the main package, as it is only
required when developing programs that use the library.
The main package contains the library and LICENSE.txt (+ associated license
subdir). It didn't make sense to include README.txt in the main package, as it
refers to files that are only present in the -devel package.
I believe the package is now ready for inclusion into Fedora -- many thanks to
everyone for their help.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504152] Review Request: perl-Pod-Abstract - Abstract document tree for Perl POD documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504152 --- Comment #2 from Marcela Maslanova mmasl...@redhat.com 2009-06-08 09:38:52 EDT --- Thank you. Fixed: http://mmaslano.fedorapeople.org/review/perl-Pod-Abstract.spec http://mmaslano.fedorapeople.org/review/perl-Pod-Abstract-0.17-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484423] Review Request: netbook-launcher - A clutter-based desktop launcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484423 Christoph Wickert fed...@christoph-wickert.de changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|fed...@christoph-wickert.de Flag||fedora-review? --- Comment #13 from Christoph Wickert fed...@christoph-wickert.de 2009-06-08 09:56:11 EDT --- Ok, now that the lawsuit is settled, I'm going to review this. Stay tuned. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485401] Review Request: KyaPanel - Servers Manager The easy way to admin Postfix and Samba Servers.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485401 Pierre-YvesChibon pin...@pingoured.fr changed: What|Removed |Added CC||pin...@pingoured.fr --- Comment #1 from Pierre-YvesChibon pin...@pingoured.fr 2009-06-08 10:01:49 EDT --- soon ? :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503662] Review Request: saab-fonts - OTF Saab Punjabi Font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503662 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added CC||fedora-fonts-bugs-l...@redh ||at.com, ||fedora-i18n-b...@redhat.com Flag|needinfo?(nicolas.mail...@l | |aposte.net) | --- Comment #9 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-06-08 10:00:30 EDT --- (In reply to comment #8) Can you please check whether it will work or not? 1. Unless saab is derived from lohit punjabi and they have the same look and metrics I'd really not include alias binding=same familyLohit Punjabi/family accept familySaab/family /accept /alias 2. The 90 priority is safe, but very conservative. I'd discuss with the Lohit people and i18n if Saab could not be bumped a little. 3. Please cc the fonts list on fonts review so the right people get cc-ed 4. Please also check you didn't miss any step in http://fedoraproject.org/wiki/Font_package_lifecycle -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489686 --- Comment #30 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 10:14:10 EDT --- You still shouldn't duplicate LICENSE.txt and licenses in the -devel package, as they are already in the main package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489686 --- Comment #31 from Conrad Sanderson conrads...@ieee.org 2009-06-08 10:21:38 EDT --- (In reply to comment #30) You still shouldn't duplicate LICENSE.txt and licenses in the -devel package, as they are already in the main package. Not including LICENSE.txt in -devel will break the references/links from README.txt and index.html (present in the upstream .tar.gz). Including README.txt only makes sense in the -devel package. Not including LICENSE.txt in the main package will cause rpmlint to give warnings. Suggestions ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503662] Review Request: saab-fonts - OTF Saab Punjabi Font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503662 --- Comment #10 from Parag AN(पराग) panem...@gmail.com 2009-06-08 10:24:27 EDT --- thanks Nicolas for your reply. I will check what you have asked above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=489686
--- Comment #32 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 10:30:12
EDT ---
(In reply to comment #31)
(In reply to comment #30)
You still shouldn't duplicate LICENSE.txt and licenses in the -devel
package,
as they are already in the main package.
Not including LICENSE.txt in -devel will break the references/links from
README.txt and index.html (present in the upstream .tar.gz). Including
README.txt only makes sense in the -devel package.
In this case duplication may be alright, another option is to sed the link to
point to %{_datadir}/doc/%{name}-%{version}/LICENSE.txt.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476359] Review Request: compiz-fusion-unsupported - Additional Compiz Fusion plugins for Compiz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476359 --- Comment #5 from leigh scott leigh123li...@googlemail.com 2009-06-08 10:36:03 EDT --- OK, here's my latest attempt :-) Spec URL: http://leigh123linux.fedorapeople.org/pub/review/compiz-fusion-unsupported/1/compiz-fusion-unsupported.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/compiz-fusion-unsupported/1/compiz-fusion-unsupported-0.8.2-1.fc12.src.rpm The x86_64: W: non-conffile-in-etc error is also present in the packages 1. compiz-fusion 2. compiz-fusion-extras Do I need to fix this ? rpmlint -vi '/home/leigh/Desktop/compiz-fusion-unsupported-0.8.2-1.fc12.src.rpm' compiz-fusion-unsupported.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -vi '/home/leigh/Desktop/compiz-fusion-unsupported-0.8.2-1.fc12.x86_64.rpm' compiz-fusion-unsupported.x86_64: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -vi '/home/leigh/Desktop/compiz-fusion-unsupported-debuginfo-0.8.2-1.fc12.x86_64.rpm' compiz-fusion-unsupported-debuginfo.x86_64: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -vi '/home/leigh/Desktop/compiz-fusion-unsupported-devel-0.8.2-1.fc12.x86_64.rpm' compiz-fusion-unsupported-devel.x86_64: I: checking compiz-fusion-unsupported-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint -vi '/home/leigh/Desktop/compiz-fusion-unsupported-gnome-0.8.2-1.fc12.x86_64.rpm' compiz-fusion-unsupported-gnome.x86_64: I: checking compiz-fusion-unsupported-gnome.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/compiz-elements.schemas A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here compiz-fusion-unsupported-gnome.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/compiz-atlantis.schemas A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here compiz-fusion-unsupported-gnome.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/compiz-snow.schemas A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here compiz-fusion-unsupported-gnome.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/compiz-tile.schemas A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here compiz-fusion-unsupported-gnome.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/compiz-cubemodel.schemas A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here compiz-fusion-unsupported-gnome.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/compiz-mswitch.schemas A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here compiz-fusion-unsupported-gnome.x86_64: W: conffile-without-noreplace-flag /etc/gconf/schemas/compiz-fakeargb.schemas A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here compiz-fusion-unsupported-gnome.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. 1 packages and 0 specfiles checked; 0 errors, 8 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476359] Review Request: compiz-fusion-unsupported - Additional Compiz Fusion plugins for Compiz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476359 Christoph Wickert fed...@christoph-wickert.de changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476359] Review Request: compiz-fusion-unsupported - Additional Compiz Fusion plugins for Compiz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476359 Christoph Wickert fed...@christoph-wickert.de changed: What|Removed |Added CC||fed...@christoph-wickert.de --- Comment #6 from Christoph Wickert fed...@christoph-wickert.de 2009-06-08 10:50:30 EDT --- (In reply to comment #5) The x86_64: W: non-conffile-in-etc error is also present in the packages 1. compiz-fusion 2. compiz-fusion-extras and _a_lot_ more... Do I need to fix this ? No, GConf schemas are not supposed to be edited by users and are not treated as config files. The warning is save to ignore, you can even remove %config. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476359] Review Request: compiz-fusion-unsupported - Additional Compiz Fusion plugins for Compiz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476359 --- Comment #7 from leigh scott leigh123li...@googlemail.com 2009-06-08 11:02:42 EDT --- (In reply to comment #6) (In reply to comment #5) The x86_64: W: non-conffile-in-etc error is also present in the packages 1. compiz-fusion 2. compiz-fusion-extras and _a_lot_ more... Do I need to fix this ? No, GConf schemas are not supposed to be edited by users and are not treated as config files. The warning is save to ignore, you can even remove %config. Thanks. I have removed FE-NEEDSPONSOR as I'm already sponsored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476359] Review Request: compiz-fusion-unsupported - Additional Compiz Fusion plugins for Compiz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476359 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504469] Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481759] Review Request: python-AppTools - Enthought Tool Suite Application Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481759 Toshio Ernie Kuratomi a.bad...@gmail.com changed: What|Removed |Added CC||a.bad...@gmail.com --- Comment #24 from Toshio Ernie Kuratomi a.bad...@gmail.com 2009-06-08 11:23:23 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504469] Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504469
--- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-06-08
11:50:15 EDT ---
Well,
- Now build.log complains:
-
68 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/CHANGES
69 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/GPL
70 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/README.en
71 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/VERSION
--
And as you did so before %geminstdir/examples should be marked as
%doc.
So %files should be:
--
%files
%defattr(-,root,root,-)
%dir %{geminstdir}
%doc %{geminstdir}/[A-Z]*
%doc %{geminstdir}/examples/
%{geminstdir}/*.rb
%{geminstdir}/lib/
%doc %{gemdir}/doc/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
---
thoughts?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504469] Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504469
--- Comment #6 from Lubomir Rintel lkund...@v3.sk 2009-06-08 11:57:05 EDT ---
(In reply to comment #5)
Well,
- Now build.log complains:
-
68 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/CHANGES
69 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/GPL
70 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/README.en
71 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/term-ansicolor-1.0.3/VERSION
--
I am aware of this and believe that it is ok. Makes no real harm and saves me
from enumerating the contents of the directory just to avoid duplicate
listings.
And as you did so before %geminstdir/examples should be marked as
%doc.
Will fix (for other packages as well).
So %files should be:
--
%files
%defattr(-,root,root,-)
%dir %{geminstdir}
%doc %{geminstdir}/[A-Z]*
%doc %{geminstdir}/examples/
%{geminstdir}/*.rb
%{geminstdir}/lib/
%doc %{gemdir}/doc/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
---
thoughts?
I can do this (and for other packages as well) if you insist on eliminate of
listed twice warning but I'll prefer not to.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504641] New: Review Request: sendxmpp - A perl script to send xmpp messages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sendxmpp - A perl script to send xmpp messages https://bugzilla.redhat.com/show_bug.cgi?id=504641 Summary: Review Request: sendxmpp - A perl script to send xmpp messages Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ru...@rubenkerkhof.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://ruben.fedorapeople.org/sendxmpp.spec SRPM URL: http://ruben.fedorapeople.org/sendxmpp-0.0.8-1.fc11.src.rpm Description: A perl script to send xmpp messages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 495885] Review Request: perl-POE-Component-Client-SMTP - Asynchronous mail sending with POE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495885 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:18:57 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503519] Review Request: bastet - An evil falling bricks game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503519 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:19:49 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492501] Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492501 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:20:49 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498721] Review Request: php-ezc-Webdav - eZ Components Webdav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498721 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:23:40 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504524] Review Request: perl-SQL-Shell - Command interpreter for DBI shells
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504524 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:27:58 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504456] Review Request: perl-MooseX-SemiAffordanceAccessor - Name your accessors foo() and set_foo()
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504456 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:27:12 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504077] Review Request: gnusim8085 - Intel 8085 assembly language simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504077 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:32:45 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504544] Review Request: perl-Linux-Inotify2 - Scalable directory/file change notification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504544 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:28:39 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481701] Review Request: python-TraitsGUI - Traits-capable windowing framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481701 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:29:19 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481727] Review Request: python-EnvisageCore - Extensible Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481727 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:29:57 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481734] Review Request: python-EnvisagePlugins - Plug-ins for the Envisage framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481734 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:33:21 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484798] Review Request: xiphos - Bible study and research tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484798 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:42:22 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481759] Review Request: python-AppTools - Enthought Tool Suite Application Tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481759 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #25 from Jason Tibbitts ti...@math.uh.edu 2009-06-08 12:43:31 EDT --- Just setting the fedora-cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504469] Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504469
--- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-06-08
12:41:15 EDT ---
Well, I suggest to remove duplicate %files entry as
- Actually it is MUST ;)
https://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_ref-12
- And I am not sure if in this case rpmbuild marks these duplicated files
as %doc or normal files.
I actually checked the rebuilt binary rpm and it seems that
%{geminstdir}/[A-Z]* are marked as %doc, however I don't know
any references.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=489686
--- Comment #33 from Conrad Sanderson conrads...@ieee.org 2009-06-08
12:48:08 EDT ---
(In reply to comment #32)
In this case duplication may be alright, another option is to sed the link to
point to %{_datadir}/doc/%{name}-%{version}/LICENSE.txt.
We have two possible solutions:
(1) keep the spec file as is
(2) remove LICENSE.txt and licenses from -devel and add the following lines
to the spec file:
%post devel
/sbin/ldconfig
ln -s %{_docdir}/%{name}-%{version}/LICENSE.txt
%{_docdir}/%{name}-devel-%{version}/LICENSE.txt
ln -s %{_docdir}/%{name}-%{version}/licenses
%{_docdir}/%{name}-devel-%{version}/licenses
%preun devel
rm %{_docdir}/%{name}-devel-%{version}/LICENSE.txt
rm -r %{_docdir}/%{name}-devel-%{version}/licenses
Solution (2) saves about 43 Kb in disk space, but it's messier (post-install
and pre-uninstall scriptlets).
I'd vote for solution (1) as it's cleaner, but I'm also happy to go with (2) if
that's what people prefer.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=489686
--- Comment #34 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 12:56:24
EDT ---
You can also just create the symlinks in the install phase, which is a lot
neater than creating them in %post:
%install
...
mkdir symlink
ln -s %{_datadir}/doc/%{name}-%{version}/LICENSE.txt symlink/
ln -s %{_datadir}/doc/%{name}-%{version}/licenses symlink/
%files devel
%doc symlink/*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489686 --- Comment #35 from Michael Schwendt mschwe...@gmail.com 2009-06-08 13:03:14 EDT --- rm -rf symlink ; mkdir symlink as not removing an existing symlink directory would break --short-circuit builds (and especially rpmbuild -bi --short-circuit foo.spec is very helpful). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489686 --- Comment #36 from Conrad Sanderson conrads...@ieee.org 2009-06-08 13:24:49 EDT --- (In reply to comment #34) You can also just create the symlinks in the install phase, which is a lot neater than creating them in %post: ... (In reply to comment #35) rm -rf symlink ; mkdir symlink ok, spec file updated with the cleaner solution. http://arma.sf.net/fedora/armadillo.spec http://arma.sf.net/fedora/armadillo-0.6.11-5.fc10.src.rpm rpmlint now gives two warnings, but they're just a harmless byproduct: armadillo-devel.x86_64: W: dangling-symlink /usr/share/doc/armadillo-devel-0.6.11/licenses /usr/share/doc/armadillo-0.6.11/licenses armadillo-devel.x86_64: W: dangling-symlink /usr/share/doc/armadillo-devel-0.6.11/LICENSE.txt /usr/share/doc/armadillo-0.6.11/LICENSE.txt (just to make it clear to anyone puzzled: as the -devel package is dependant on the main package, the symlinks will always work). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504283] Review Request: AGReader - Console reader for viewing AmigaGuide files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504283 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||ERRATA --- Comment #5 from Jon Ciesla l...@jcomserv.net 2009-06-08 13:46:20 EDT --- Built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504489] Review Request: proguard - Java class file shrinker, optimizer, obfuscator and preverifier
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504489
--- Comment #2 from François Kooman fkoo...@tuxed.net 2009-06-08 14:14:03
EDT ---
Spec URL: http://fkooman.fedorapeople.org/proguard/proguard.spec
SRPM URL: http://fkooman.fedorapeople.org/proguard/proguard-4.3-2.fc11.src.rpm
(In reply to comment #1)
! Please explain in the specfile as comments what Sources 1-3 are for.
Done.
! Not a blocker, but in the docs/ and examples/ directories, there are html,
xml and pro files that refer to /usr/local/. You might want to fix them.
I've included a README.dist now.
? Any reason why you don't put the jar files directly in /usr/share/java/ ?
Yes, Packaging:Java says something about this:
1. If the number of provided JAR files exceeds two, you must place them
into a sub-directory.
Maybe I misread/misunderstood?
* If a package contains a GUI application, then it needs to also include a
properly installed .desktop file.
Done. The problem now is that I can't find a suitable icon for ProGuard
anywhere. For now I use the java icon.
! You need to specify a specific java version in BR and R. See:
http://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires
In your case this ought to be 1.5
This doesn't seem mandatory the way I read this? Also it is not mentioned in
the ant template I used to create this spec file. Furthermore, I tried to
compile it with -source 1.4 and that also works?
* GCJ AOT bits SHOULD be built and included in packages. Since this package
builds with java 1.5, this will bring great performance improvements on ppc*
architectures. Please follow:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
I did this now. However, rpmbuild gives some warnings now:
+ /usr/bin/aot-compile-rpm
/usr/lib/python2.6/site-packages/aotcompile.py:18: DeprecationWarning: the md5
module is deprecated; use hashlib instead
import md5
aot-compile-rpm: warning: subsetted
/home/fkooman/rpmbuild/BUILDROOT/proguard-4.3-2.fc11.x86_64/usr/share/java/proguard/proguardgui.jar
aot-compile-rpm: warning: subsetted
/home/fkooman/rpmbuild/BUILDROOT/proguard-4.3-2.fc11.x86_64/usr/share/java/proguard/retrace.jar
WARNING: Error loading security provider
org.bouncycastle.jce.provider.BouncyCastleProvider:
java.lang.ClassNotFoundException:
org.bouncycastle.jce.provider.BouncyCastleProvider not found in
gnu.gcj.runtime.SystemClassLoader{urls=[file:./],
parent=gnu.gcj.runtime.ExtensionClassLoader{urls=[], parent=null}}
WARNING: Error loading security provider
org.bouncycastle.jce.provider.BouncyCastleProvider:
java.lang.ClassNotFoundException:
org.bouncycastle.jce.provider.BouncyCastleProvider not found in
gnu.gcj.runtime.SystemClassLoader{urls=[file:./],
parent=gnu.gcj.runtime.ExtensionClassLoader{urls=[], parent=null}}
rpmlint is also not totally happy:
[fkoo...@localhost x86_64]$ rpmlint proguard-4.3-2.fc11.x86_64.rpm
proguard.x86_64: W: unstripped-binary-or-object
/usr/lib64/gcj/proguard/proguard.jar.so
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[fkoo...@localhost x86_64]$
and the one that is due to GCJ (which can be ignored):
proguard.spec:118: W: libdir-macro-in-noarch-package (main package)
%attr(-,root,root) %{_libdir}/gcj/%{name}
Can you review my package (bug #504521 )? It is java too.
It seems someone is already interested in reviewing it. I added myself to the
CC of the bug anyway and look through it soon. Thanks for your review!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504671] Review Request: pocketsphinx - Speech recognition for handheld and embedded devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504671 Jerry James loganje...@gmail.com changed: What|Removed |Added Depends on||503598 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503598] Review Request: sphinxbase - Common library for CMU Sphinx voice recognition products
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503598 Jerry James loganje...@gmail.com changed: What|Removed |Added Blocks||504671 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504671] New: Review Request: pocketsphinx - Speech recognition for handheld and embedded devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pocketsphinx - Speech recognition for handheld and embedded devices https://bugzilla.redhat.com/show_bug.cgi?id=504671 Summary: Review Request: pocketsphinx - Speech recognition for handheld and embedded devices Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: loganje...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://jjames.fedorapeople.org/pocketsphinx/pocketsphinx.spec SRPM URL: http://jjames.fedorapeople.org/pocketsphinx/pocketsphinx-0.5.1-1.fc10.src.rpm Description: PocketSphinx is a version of the open-source Sphinx-II speech recognition system which runs on handheld and embedded devices. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497310] Review Request: php-simplepie - Simple RSS Library in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497310 --- Comment #11 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 14:59:46 EDT --- ping David -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 495577] Review Request: xsw - A simple slideshow producer and viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495577 --- Comment #14 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 14:56:38 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500082] Review Request: postal - mail server benchmark
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500082 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||da...@gnsa.us --- Comment #8 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 15:01:10 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497140] Review Request: php-IDNA_Convert - Internationalized domain name to UTF-8 converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497140 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||da...@gnsa.us --- Comment #10 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 14:59:32 EDT --- ping David -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499319] Review Request: tcl-snmptools - TCL extension for SNMP support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499319 --- Comment #10 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 15:00:12 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500003] Review Request: textroom - A full screen rich text editor for writers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=53 --- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 15:00:27 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489598] Review Request: codelite - a powerful open-source, cross platform code editor for C/C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489598 --- Comment #17 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 15:03:38 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502525] Review Request: lazygal - static photo gallery generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502525 --- Comment #4 from Byron Clark by...@theclarkfamily.name 2009-06-08 15:03:55 EDT --- I made the requested changes. Spec URL: http://theclarkfamily.name/fedora/lazygal.spec SRPM URL: http://theclarkfamily.name/fedora/lazygal-0.4.1-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226365] Merge Review: redhat-rpm-config
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226365 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||a...@redhat.com --- Comment #5 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-08 15:05:29 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226365] Merge Review: redhat-rpm-config
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226365 --- Comment #6 from Jon Masters j...@redhat.com 2009-06-08 15:16:30 EDT --- Oh, I don't seem to be assigned to this properly, but anyway, ok, I'll look. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226365] Merge Review: redhat-rpm-config
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226365 Jon Masters j...@redhat.com changed: What|Removed |Added AssignedTo|jussi.leht...@iki.fi|j...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504489] Review Request: proguard - Java class file shrinker, optimizer, obfuscator and preverifier
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504489
--- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-06-08
15:18:51 EDT ---
(In reply to comment #2)
Spec URL: http://fkooman.fedorapeople.org/proguard/proguard.spec
SRPM URL: http://fkooman.fedorapeople.org/proguard/proguard-4.3-2.fc11.src.rpm
Thanks for the update!
(In reply to comment #1)
! Please explain in the specfile as comments what Sources 1-3 are for.
Done.
Can you also use cp -p with them to preserve timestamps?
! Not a blocker, but in the docs/ and examples/ directories, there are html,
xml and pro files that refer to /usr/local/. You might want to fix them.
I've included a README.dist now.
? Any reason why you don't put the jar files directly in /usr/share/java/ ?
Yes, Packaging:Java says something about this:
1. If the number of provided JAR files exceeds two, you must place them
into a sub-directory.
Maybe I misread/misunderstood?
Ah, right. Then can you
(from comment #1)
replace
%{_javadir}/%{name}*
with
%{_javadir}/%{name}/
in %files to indicate that this is a directory?
* If a package contains a GUI application, then it needs to also include a
properly installed .desktop file.
Done. The problem now is that I can't find a suitable icon for ProGuard
anywhere. For now I use the java icon.
That's fine. You could also derive something from the png files in the docs/
directory, or ask the upstream about this.
Btw,
/usr/share/icons/hicolor/*/apps/java.png
files belong to java-1.6.0-openjdk, so if you use that icon, you need to
require this version of java.
! You need to specify a specific java version in BR and R. See:
http://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires
In your case this ought to be 1.5
This doesn't seem mandatory the way I read this? Also it is not mentioned in
the ant template I used to create this spec file. Furthermore, I tried to
compile it with -source 1.4 and that also works?
Well, it's good to have it to indicate what versions of java can be used with
this software.
* GCJ AOT bits SHOULD be built and included in packages. Since this package
builds with java 1.5, this will bring great performance improvements on ppc*
architectures. Please follow:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
I did this now. However, rpmbuild gives some warnings now:
+ /usr/bin/aot-compile-rpm
/usr/lib/python2.6/site-packages/aotcompile.py:18: DeprecationWarning: the md5
module is deprecated; use hashlib instead
import md5
aot-compile-rpm: warning: subsetted
/home/fkooman/rpmbuild/BUILDROOT/proguard-4.3-2.fc11.x86_64/usr/share/java/proguard/proguardgui.jar
aot-compile-rpm: warning: subsetted
/home/fkooman/rpmbuild/BUILDROOT/proguard-4.3-2.fc11.x86_64/usr/share/java/proguard/retrace.jar
WARNING: Error loading security provider
org.bouncycastle.jce.provider.BouncyCastleProvider:
java.lang.ClassNotFoundException:
org.bouncycastle.jce.provider.BouncyCastleProvider not found in
gnu.gcj.runtime.SystemClassLoader{urls=[file:./],
parent=gnu.gcj.runtime.ExtensionClassLoader{urls=[], parent=null}}
WARNING: Error loading security provider
org.bouncycastle.jce.provider.BouncyCastleProvider:
java.lang.ClassNotFoundException:
org.bouncycastle.jce.provider.BouncyCastleProvider not found in
gnu.gcj.runtime.SystemClassLoader{urls=[file:./],
parent=gnu.gcj.runtime.ExtensionClassLoader{urls=[], parent=null}}
rpmlint is also not totally happy:
[fkoo...@localhost x86_64]$ rpmlint proguard-4.3-2.fc11.x86_64.rpm
proguard.x86_64: W: unstripped-binary-or-object
/usr/lib64/gcj/proguard/proguard.jar.so
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[fkoo...@localhost x86_64]$
Hmm, I don't get these warnings. Koji rawhide build doesn't show them either
http://koji.fedoraproject.org/koji/taskinfo?taskID=1399792
Do you use mock? If not, do you have redhat-rpm-config installed?
and the one that is due to GCJ (which can be ignored):
proguard.spec:118: W: libdir-macro-in-noarch-package (main package)
%attr(-,root,root) %{_libdir}/gcj/%{name}
Yes, this warning can be ignored (this is the only warning I got on my build).
Btw, you can just remove the %attr(-,root,root) part. I've been pinging java
folks about this and a few other things that need to be updated in the java
packaging guidelines. Things go a little slow.
Can you review my package (bug #504521 )? It is java too.
It seems someone is already interested in reviewing it. I added myself to the
CC of the bug anyway and look through it soon. Thanks for your review!
You're welcome! Yep. Rakesh took it :) It's okay.
* Also, please use macros consistently. E.g.
${RPM_BUILD_ROOT} and $RPM_BUILD_ROOT
shouldn't be in the same specfile. Also, please either use %{name} all over
