[Bug 505965] Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505965 --- Comment #10 from Fedora Update System 2009-07-07 02:48:15 EDT --- supybot-meetbot-0.1.1-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505965] Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505965 --- Comment #9 from Fedora Update System 2009-07-07 02:43:23 EDT --- supybot-meetbot-0.1.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492815] Review Request: fife - Cross platform game creation framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492815 --- Comment #15 from Simon Wesp 2009-07-07 02:34:22 EDT --- it's easier to modify source0 to meet the license requirements! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490892] Review Request: b43-openfwwf - Open FirmWare for Broadcom 43xx series WLAN chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490892 --- Comment #17 from Fedora Update System 2009-07-07 01:59:10 EDT --- b43-openfwwf-5.1-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/b43-openfwwf-5.1-3.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490892] Review Request: b43-openfwwf - Open FirmWare for Broadcom 43xx series WLAN chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490892 --- Comment #16 from Fedora Update System 2009-07-07 01:59:05 EDT --- b43-openfwwf-5.1-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/b43-openfwwf-5.1-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498846] Review Request: R-RM2 - Revenue Management and Pricing for R
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498846 --- Comment #12 from Denis Arnaud 2009-07-07 01:43:02 EDT --- Taking into account comment #10, the updated specification file and source RPM are to be found at the following URLs: - Spec URL: http://denisarnaud.fedorapeople.org/R/RM2/4/R-RM2.spec SRPM URL: http://denisarnaud.fedorapeople.org/R/RM2/4/R-RM2-0.0-4.fc11.src.rpm - If nobody vetoes, that is the version I will import in CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498846] Review Request: R-RM2 - Revenue Management and Pricing for R
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498846 Denis Arnaud changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498846] Review Request: R-RM2 - Revenue Management and Pricing for R
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498846 --- Comment #11 from Denis Arnaud 2009-07-07 01:35:06 EDT --- New Package CVS Request === Package Name: R-RM2 Short Description: Revenue Management and Pricing for R Owners: denisarnaud Branches: EL-4 EL-5 F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505965] Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505965 --- Comment #8 from Fedora Update System 2009-07-07 00:54:13 EDT --- supybot-meetbot-0.1.1-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505965] Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505965 --- Comment #7 from Fedora Update System 2009-07-07 00:50:54 EDT --- supybot-meetbot-0.1.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/supybot-meetbot-0.1.1-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508510] Review Request: python-Scriptaculous - Scriptaculous packaged as TurboGears widgets.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508510 Parag AN(पराग) changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Parag AN(पराग) 2009-07-07 00:38:28 EDT --- APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi 2009-07-07 00:26:12 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #29 from Kevin Fenzi 2009-07-07 00:25:07 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492816] Review Request: squeal - A SQL-like interface for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492816 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #17 from Kevin Fenzi 2009-07-07 00:21:38 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490892] Review Request: b43-openfwwf - Open FirmWare for Broadcom 43xx series WLAN chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490892 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #15 from Kevin Fenzi 2009-07-07 00:15:34 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509823] Review Request: hunspell-ti - Tigrigna hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509823 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi 2009-07-07 00:13:28 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509822] Review Request: hunspell-am - Amharic hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509822 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi 2009-07-07 00:11:48 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509537] Review Request: perl-CGI-Application-Plugin-ValidateRM - Help validate CGI::Application run modes using Data::FormValidator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509537 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi 2009-07-07 00:05:14 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509538] Review Request: perl-CGI-Application-Plugin-ViewCode - Allows you to view the source of a CGI::Application module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509538 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi 2009-07-07 00:07:37 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 496742] Review Request: elfelli - Visualisation tool for flux lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=496742 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi 2009-07-07 00:00:39 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505965] Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505965 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi 2009-07-07 00:02:00 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507071] Review Request: libqinfinity -
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507071 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi 2009-07-06 23:59:19 EDT --- cvs done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508483] Review Request: ewl - Enlightenment Widget Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508483
--- Comment #11 from John Guthrie 2009-07-06
23:58:50 EDT ---
(In reply to comment #10)
> > > * License: TODO
> > > - License in spec file does not match the actual license (COPYING looks
> > > like a
> > > variant of the MIT license)
> > > - however, the included spec file mentiones BSD
> > > - the enlightenment authors mentioned usually only BSD as the license of
> > > the
> > > related projects
> > > - I've asked fedora-legal for clarification and got a response that the
> > > following license field should be used:
> > > License: MIT with advertising
> > > https://www.redhat.com/archives/fedora-legal-list/2009-July/msg3.html
> > > - license file packaged
> >
> > When I looked at the license, I initially mis-identified it as being an BSD
> > license. And then, like you saw as well, I saw other components of
> > enlightenment with BSD licenses. So that led me to believe that I really
> > had
> > put in the correct license.
> >
> > Anyway, this is fixed.
>
> Sorry, not 100% - the line must be exactly as I wrote:
>
> License: MIT with advertising
Oops. Missed that detail. Fixed.
> > > * compilation: TODO
> > > - supports parallel build
> > > - RPM_OPT_FLAGS are correctly used
> > > - it would be better not to build the static libraries instead of
> > > deleting them
> > > later, please add a "--disable-static" and remove the deleting of the *.a
> > > files
> >
> > Fixed.
>
> Please remove the commented lines completely:
> # Removing .a files
> #find $RPM_BUILD_ROOT -name '*.a' -exec rm '{}' \;
Fixed.
> > > * main package should not contain development related parts: TODO
> > > /usr/lib/ewl/tests should be in -devel package
> >
> > Fixed.
>
> Unfortunately this fix has introduced a minor issue: the directory
> %{_libdir}/%{name} itself is now an orphan, since it isn't included neither in
> the main nor in the -devel package. Please add
> %dir {_libdir}/%{name}
> to the main pacakge.
Missed that one. Fixed.
Here are the new URLs:
http://www.guthrie.info/RPMS/f11/ewl.spec
http://www.guthrie.info/RPMS/f11/ewl-0.5.2.042-9.fc11.src.rpm
Thanks again for your help.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505965] Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505965 Kevin Fenzi changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Kevin Fenzi 2009-07-06 23:44:05 EDT --- ok, upstream just pushed out version 0.1.1. ;) This is what I will be importing: Spec URL: http://www.scrye.com/~kevin/fedora/supybot-meetbot/supybot-meetbot.spec SRPM URL: http://www.scrye.com/~kevin/fedora/supybot-meetbot/supybot-meetbot-0.1.1-1.fc12.src.rpm New Package CVS Request === Package Name: supybot-meetbot Short Description: Plugin for Supybot for handling IRC meetings Owners: kevin Branches: devel F-11 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498846] Review Request: R-RM2 - Revenue Management and Pricing for R
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498846 Jason Tibbitts changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Jason Tibbitts 2009-07-06 22:08:26 EDT --- Looks good; the license is fixed and Release: isn't obfuscated. In general I'd suggest removing commented lines from the %files section and simply not defining unused macros like %packrel, but these are hardly blockers. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509798] Review Request: armv5tejl-unknown-linux-gnueabi-binutils - A GNU collection of binary utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509798 Adam Goode changed: What|Removed |Added CC||a...@spicenitz.org --- Comment #2 from Adam Goode 2009-07-06 21:23:50 EDT --- Why "armv5tejl-unknown-linux-gnueabi"? I think the ARM SIG is using "armv5tel-redhat-linux-gnueabi". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492815] Review Request: fife - Cross platform game creation framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492815 --- Comment #14 from Thomas Kowaliczek 2009-07-06 21:06:23 EDT --- I´m from fife upstream and i will fix that license problem with the demo. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492203] Review Request: frinika - Music Workstation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492203 --- Comment #23 from Fedora Update System 2009-07-06 20:41:54 EDT --- frinika-0.5.1-7.551svn.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/frinika-0.5.1-7.551svn.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492203] Review Request: frinika - Music Workstation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492203 --- Comment #22 from Fedora Update System 2009-07-06 20:41:18 EDT --- frinika-0.5.1-7.551svn.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/frinika-0.5.1-7.551svn.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509936] Review Request: tortoisehg - Mercurial gui tools and nautilus plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509936 Mads Kiilerich changed: What|Removed |Added Alias||tortoisehg-review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509936] New: Review Request: tortoisehg - Mercurial gui tools and nautilus plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: tortoisehg - Mercurial gui tools and nautilus plugin https://bugzilla.redhat.com/show_bug.cgi?id=509936 Summary: Review Request: tortoisehg - Mercurial gui tools and nautilus plugin Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: m...@kiilerich.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kiilerich.com/tortoisehg.spec SRPM URL: http://kiilerich.com/tortoisehg-0.8-3.src.rpm Description: TortoiseHg is "TortoiseSVN for Hg" ... if you happen to know TortoiseSVN ... It consists of a gui layer on top of hg, available from the commandline through the hgtk command. The commands can also be made available in the context menu in Nautilus. I created the rpm package for upstream and would like to have it properly included in fedora. This is my first package, so I need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509936] Review Request: tortoisehg - Mercurial gui tools and nautilus plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509936 Mads Kiilerich changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502692] Review Request: mingw32-libatomic_ops - MinGW Windows port of the libatomic_ops library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502692 --- Comment #4 from Nicolas Chauvet (kwizart) 2009-07-06 20:10:23 EDT --- (In reply to comment #3) > gives me a 404 right now fixed, I've re-organized the review queue on my fpeople.org Note: the native Fedora package has been orphaned and remains as such until now. I think there is a plan to have it merged with gc. I may drop this package then. (And with advices from the gc native package maintainer). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509739] Review Request: daemonize - run a command as a Unix daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509739 --- Comment #20 from Gary T. Giesen 2009-07-06 19:52:45 EDT --- Submitted new package for review: Bug 509883 - Review Request: sipcalc - "advanced" console based ip subnet calculator -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503297] Review Request: panoglview - Immersive viewer for spherical panoramas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503297 Nicolas Chauvet (kwizart) changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Nicolas Chauvet (kwizart) 2009-07-06 19:13:15 EDT --- Given the license of the build dependency,(wxWidgets, zlib, libtiff) which all are GPLv3 compatible we will not have a problem to move to GPLv3+ (like if any dependency were GPLv2 only). Now nothing requires us to be GPLv3+ either (exept if we consider COPYING text matter much than source code). Quoting the guidelines, we have to: - Have a license field - If a COPYING is provided, have it bundled. - Consider the binary rpm as the license field. What we don't have to do: - Have license field to match COPYING text. So this ends to be the #3rd choice which is the one of the src.rpm All other fields from the review have been corrected. --- This package (panoglview) is APPROVED by me --- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509933] New: Review Request: chameleon - Database schema transformation tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: chameleon - Database schema transformation tool. https://bugzilla.redhat.com/show_bug.cgi?id=509933 Summary: Review Request: chameleon - Database schema transformation tool. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jor...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://svn.fedorahosted.org/svn/chameleon/trunk/chameleon.spec SRPM URL: https://fedorahosted.org/releases/c/h/chameleon/chameleon-0.1-6.fc10.src.rpm Description: Chameleon is a tool used to transform database schema (DDL/SQL) files from a common DDL/SQL to database specific schema files. Target users are projects that need to maintain schema creation/upgrade files and support multiple databases. Initially supported databases are Oracle and PostgreSQL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476527] Review Request: python-zdaemon - Python Daemon Process Control Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476527 --- Comment #10 from Fabian Affolter 2009-07-06 18:44:12 EDT --- Scratch build failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=1457973 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 496742] Review Request: elfelli - Visualisation tool for flux lines
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496742
--- Comment #9 from Fabian Affolter 2009-07-06
18:28:14 EDT ---
(In reply to comment #8)
> - I think it would be nice if the linking would use the optflags too, but it
> seems the current elfelli build scripts don't support it. Probably it's fine
> (unless -fPIC is in %{optflags} in which case the linking too needs -fPIC).
Upstream added the scons option "ccflags". I will get in touch with them and
see if there is a possibility to add support for optflags in the linking too.
> - You might use a macro for the release version to avoid the duplicates in
> release, source and build root. E.g.
> %global rel rc1
> and change all references to rc1 to %{rel}.
Upstream made the 'release candidate' release only for the package review. But
you are right that the usage of a macros would facilitate the handling.
> - You are missing the icon cache updates, see
> https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
Thanks, I missed that.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 496742] Review Request: elfelli - Visualisation tool for flux lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=496742 Fabian Affolter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Fabian Affolter 2009-07-06 18:29:02 EDT --- New Package CVS Request === Package Name: elfelli Short Description: Visualisation tool for flux lines Owners: fab Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497622 --- Comment #14 from Jussi Lehtola 2009-07-06 18:25:55 EDT --- If the releases are made along apbs, then you can just build them all in the same spec and do e.g. %package -n aqua and %package -n pmgZ and so on... Probably best to ask first upstream, though, if those are meant to be distributed as individual packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484049] Review Request: emacs-common-proofgeneral - Emacs mode for standard interaction interface for proof assistants
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484049 --- Comment #11 from Jerry James 2009-07-06 18:15:33 EDT --- Created an attachment (id=350698) --> (https://bugzilla.redhat.com/attachment.cgi?id=350698) New display-table support The problem with Rawhide XEmacs is that the implementation of char-tables, and therefore display-tables, has changed. They are no longer vectors, but objects. The vector implementation was okay for ASCII/ISO8859-1, when we could limit the length to 256 and be okay. That approach does not scale for international character sets, hence the new implementation. I'm attaching a patch that starts dealing with the problem. This isn't a complete solution, because the new file (generic/pg-display-table.el) isn't in the right place. The x-symbol code needs it, so the compile fails. If you can find a good place to put that file so it can be (require)d at need, I think it will work. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 steve changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from steve 2009-07-06 18:01:06 EDT --- Thanks for your time, Spot ! New Package CVS Request === Package Name: wmfire Short Description: WindowMaker dock app that displays cpu, memory or network load as flames Owners: lonetwin Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497622 --- Comment #13 from Tim Fenn 2009-07-06 17:50:14 EDT --- (In reply to comment #12) > Hmm, it seems that aqua is a customized version of PMG as per > http://cardon.wustl.edu/MediaWiki/index.php/APBS . > > In that case I'm really not sure what should be done. Many possibilities come > to mind > > - package aqua separately [if it has development that is clearly separate from > apbs] > - create a aqua subpackage [development as part of apbs but still other apps > might use it] > - don't package aqua at all [an incompatible fork of the PMG library that is > used nowhere else] Oh, this is getting fun. I'll go with option 2, since Nathan seems to have taken over the aqua development anyway. It looks like this will also be necessary with pmgZ, as again - it seems to primarily be developed as part of apbs, not really its own independent library. Only maloc can really be its "own" library - Mike Holst still manages that. Here's a shot at an rpm for pmgZ - I can't seem to find much in the way of guidelines for subpackages in this sort of instance - should independent package requests be made for each (with blockers added for this package)? Spec URL: http://www.stanford.edu/~fenn/packs/pmgz.spec SRPM URL: http://www.stanford.edu/~fenn/packs/apbs-pmgz-1.1.0-1.20090706svn1360.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503013] Review Request: gnaughty - Downloader for adult content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503013 Toshio Ernie Kuratomi changed: What|Removed |Added CC||a.bad...@gmail.com --- Comment #20 from Toshio Ernie Kuratomi 2009-07-06 17:45:56 EDT --- Just to clarify legal status, this is waiting first on the board to clarify whether Fedora wants to disallow software that is specifically for downloading porn. If no ban is put in effect, spot will look into the legal aspects. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492816] Review Request: squeal - A SQL-like interface for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492816 Dave Malcolm changed: What|Removed |Added Flag||fedora-cvs? --- Comment #16 from Dave Malcolm 2009-07-06 17:43:22 EDT --- New Package CVS Request === Package Name: squeal Short Description: Data manipulation tool for the command line Owners: dmalcolm Branches: EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 496742] Review Request: elfelli - Visualisation tool for flux lines
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496742
Jussi Lehtola changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #8 from Jussi Lehtola 2009-07-06 17:37:18
EDT ---
- I think it would be nice if the linking would use the optflags too, but it
seems the current elfelli build scripts don't support it. Probably it's fine
(unless -fPIC is in %{optflags} in which case the linking too needs -fPIC).
- You might use a macro for the release version to avoid the duplicates in
release, source and build root. E.g.
%global rel rc1
and change all references to rc1 to %{rel}.
- You are missing the icon cache updates, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
**
rpmlint output is clean.
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
**
Fix the issues before import to CVS. The package has been
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #28 from Antti Andreimann 2009-07-06 17:27:57 EDT --- (In reply to comment #26) > > Requires: ace-devel > > I don't think adding a requirement for ACE is a good idea. ACE support is > optional and I would expect only a few people needing this functionality > (binary serialization to ACE CDR streams). Is there something like Suggests: > or > Recommends: ? AFAIK there is no "recommended packages" information in RPM files. The dependency is currently commented out because Fedora does not have ACE packages. If they become available, the decision whether to depend on them or not can be made. The current information in the spec file serves only as a reminder to me and other package maintainers to look into the issue when ACE packages become available. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Tom "spot" Callaway changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Tom "spot" Callaway 2009-07-06 17:24:04 EDT --- Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (a0e296c454571dd650abd7d830a311c2c84e9339) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478744] Review Request: wmfire - WindowMaker dock app that displays cpu, memory or network load as flames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478744 Tom "spot" Callaway changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492816] Review Request: squeal - A SQL-like interface for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492816 Jason Tibbitts changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #15 from Jason Tibbitts 2009-07-06 17:08:24 EDT --- Looks good, thanks. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #14 from Jussi Lehtola 2009-07-06 17:07:16 EDT --- btw on fedora-devel there has been a discussion raging on whether autotools files are OK to patch and rerun autotools vs hacking the preprocessed files manually, which is analogous to this matter. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509739] Review Request: daemonize - run a command as a Unix daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509739 --- Comment #19 from Jussi Lehtola 2009-07-06 17:08:47 EDT --- Sure, and for the informal reviews too. Or you can just put the bug numbers here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497622 --- Comment #12 from Jussi Lehtola 2009-07-06 17:04:21 EDT --- Hmm, it seems that aqua is a customized version of PMG as per http://cardon.wustl.edu/MediaWiki/index.php/APBS . In that case I'm really not sure what should be done. Many possibilities come to mind - package aqua separately [if it has development that is clearly separate from apbs] - create a aqua subpackage [development as part of apbs but still other apps might use it] - don't package aqua at all [an incompatible fork of the PMG library that is used nowhere else] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507071] Review Request: libqinfinity -
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507071 Ben Boeckel changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Ben Boeckel 2009-07-06 16:45:05 EDT --- New Package CVS Request === Package Name: libqinfinity Short Description: Qt interface for libinfinity Owners: mathstuf Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 496742] Review Request: elfelli - Visualisation tool for flux lines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=496742 --- Comment #7 from Fabian Affolter 2009-07-06 16:32:44 EDT --- (In reply to comment #3) > - Optflags are not used. Upstream fixed this > - scons install recompiles targets. fixed Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/elfelli.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/elfelli-0.3.1-1.rc1.fc11.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1457695 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467655] Review Request: yafaray - a raytracer for Blender.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467655 --- Comment #57 from Nicolas Chauvet (kwizart) 2009-07-06 16:23:25 EDT --- Can I have an update of yafaray package to be compliant with selinux ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492815] Review Request: fife - Cross platform game creation framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492815 --- Comment #13 from Tom "spot" Callaway 2009-07-06 16:17:58 EDT --- If it gets rid of all the files which are under that non-free license, then that should be enough to lift the legal hold. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457279] Review Request: cerebro - Cerebro provides mesh network services and presence information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457279 --- Comment #28 from Polychronis Ypodimatopoulos 2009-07-06 16:10:56 EDT --- Addressed both issues and replaced the sha module with hashlib to eliminate the DeprecationWarning. The latest RPMs can be found at the usual place: http://dev.laptop.org/~ypod/releases/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492815] Review Request: fife - Cross platform game creation framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492815 --- Comment #12 from Simon Wesp 2009-07-06 16:06:35 EDT --- would be okay if i drop rio_de_hola aka demo? these files are in the srpm, too.. but not in the rpms. is this a compromiss? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498846] Review Request: R-RM2 - Revenue Management and Pricing for R
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498846
--- Comment #9 from Denis Arnaud 2009-07-06
15:51:28 EDT ---
Thanks for that review!
1. You are absolutely right about the license. The authors specify "GPL >= 3";
so, GPLv3+ must be used (instead of GPLv3).
2. As for the %{packrel} macro, as I now understand, it should be used for the
release of the upstream R package (and not the RPM release).
The updated specification file and source RPM are to be found at the following
URLs:
-
Spec URL: http://denisarnaud.fedorapeople.org/R/RM2/3/R-RM2.spec
SRPM URL: http://denisarnaud.fedorapeople.org/R/RM2/3/R-RM2-0.0-3.fc11.src.rpm
-
As for the package review process, besides a few reviews, I watch almost all
the C++-related packages, so as to try to help where there is no other reviewer
assigned (it is not that much, but I own quite a few upstream open source
projects, which I have to push if I ever want them to reach a critical mass).
However, you are right, and I do fully understand that we are never enough to
perform peer reviews :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507053] Review Request: latrace - glibc 2.4+ LD_AUDIT feature frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507053 --- Comment #6 from Jiri Olsa 2009-07-06 15:50:15 EDT --- Well, ltrace is able to display system calls also, which latrace is not, as it is a pure glibc LD_AUDIT frontend. The justification for the latrace usage should be probably the speed.. it should be far more faster then ltrace, since it uses callbacks directly from the glibc dynamic linker. for latrace usage plz see links on http://latrace.sourceforge.net/doc.shtml -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #27 from Boris Kolpackov 2009-07-06 15:49:25 EDT --- > Can these files be converted into UTF-8 easily? I think these files can be safely removed from the package. They are a by-product of creating the PDF files from XHTML and we only keep them because, well, we have them and maybe somebody would need them for something. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #26 from Boris Kolpackov 2009-07-06 15:46:40 EDT --- > Requires: ace-devel I don't think adding a requirement for ACE is a good idea. ACE support is optional and I would expect only a few people needing this functionality (binary serialization to ACE CDR streams). Is there something like Suggests: or Recommends: ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508483] Review Request: ewl - Enlightenment Widget Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508483
--- Comment #10 from Christian Krause 2009-07-06 15:29:45
EDT ---
> > * License: TODO
> > - License in spec file does not match the actual license (COPYING looks
> > like a
> > variant of the MIT license)
> > - however, the included spec file mentiones BSD
> > - the enlightenment authors mentioned usually only BSD as the license of the
> > related projects
> > - I've asked fedora-legal for clarification and got a response that the
> > following license field should be used:
> > License: MIT with advertising
> > https://www.redhat.com/archives/fedora-legal-list/2009-July/msg3.html
> > - license file packaged
>
> When I looked at the license, I initially mis-identified it as being an BSD
> license. And then, like you saw as well, I saw other components of
> enlightenment with BSD licenses. So that led me to believe that I really had
> put in the correct license.
>
> Anyway, this is fixed.
Sorry, not 100% - the line must be exactly as I wrote:
License: MIT with advertising
> > * compilation: TODO
> > - supports parallel build
> > - RPM_OPT_FLAGS are correctly used
> > - it would be better not to build the static libraries instead of deleting
> > them
> > later, please add a "--disable-static" and remove the deleting of the *.a
> > files
>
> Fixed.
Please remove the commented lines completely:
# Removing .a files
#find $RPM_BUILD_ROOT -name '*.a' -exec rm '{}' \;
> > * main package should not contain development related parts: TODO
> > /usr/lib/ewl/tests should be in -devel package
>
> Fixed.
Unfortunately this fix has introduced a minor issue: the directory
%{_libdir}/%{name} itself is now an orphan, since it isn't included neither in
the main nor in the -devel package. Please add
%dir {_libdir}/%{name}
to the main pacakge.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #13 from Marcin Wojdyr 2009-07-06 14:58:05 EDT --- I changed the spec to avoid using automake. Spec URL: http://www.unipress.waw.pl/~wojdyr/spec/xylib.spec SRPM URL: http://www.unipress.waw.pl/~wojdyr/spec/xylib-0.4-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 Antti Andreimann changed: What|Removed |Added Flag||fedora-cvs? --- Comment #25 from Antti Andreimann 2009-07-06 14:48:18 EDT --- Thank You! New Package CVS Request === Package Name: xsd Short Description: W3C XML schema to C++ data binding compiler Owners: anttix Branches: F-10 F-11 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502065] Review Request: slashem - Super Lotsa Added Stuff Hack - Extended Magic
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502065 --- Comment #12 from Jerry James 2009-07-06 14:25:56 EDT --- Sorry for missing the fonts in the first place. Since this has already been approved and CVS is done, you can do anything you like. If it was me, though, and it looked like a nethack-bitmap-fonts package would appear within a short time, I'd just wait. Otherwise, you could be pushing an update in only a couple of weeks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 Mamoru Tasaka changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #24 from Mamoru Tasaka 2009-07-06 13:59:19 EDT --- Okay. This package (xsd) is APPROVED by mtasaka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509739] Review Request: daemonize - run a command as a Unix daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509739 --- Comment #18 from Gary T. Giesen 2009-07-06 13:56:37 EDT --- (In reply to comment #16) > Okay, but now the install process isn't preserving the time stamps. Add > INSTALL="install -p" as argument to make install. > > After you've fixed this the package should be good to go. I won't give an > official approval yet, since to import you need to be sponsored, which I won't > do before you fill the criteria (other submission and informal reviews). Would you like me to add you to the CC for my other submissions? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492816] Review Request: squeal - A SQL-like interface for the command line
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492816 --- Comment #14 from Dave Malcolm 2009-07-06 13:53:55 EDT --- Thanks. > Generally there's no point in mentioning the name of the package in the > summary. There's a group trying to clean these up; there's little point in > adding another for them to fix. Fixed; summary now reads "Data manipulation tool for the command line" > It would be nice to elaborate just a bit in the %description. One gets the > impression that this package is something akin to mysqlclient, but in reality > it's very far from that. I'd at least mention that it can parse log files and > allow you to make sql-like queries on them. Good point; I'd entirely missed that. I've rewritten the description based on your suggestion. > I'm supposed to ask you to bug upstream to include the text of the license. > In > this case I guess I'm just bugging you directly. I consider myself bugged :-) I did a 0.4.1 release containing a COPYING file, and added it to the specfile. Updated SRPM: http://people.redhat.com/dmalcolm/python/squeal-0.4.1-1.src.rpm Updated specfile: http://people.redhat.com/dmalcolm/python/squeal.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508510] Review Request: python-Scriptaculous - Scriptaculous packaged as TurboGears widgets.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508510 --- Comment #4 from Itamar Reis Peixoto 2009-07-06 13:41:31 EDT --- fixed. http://ispbrasil.com.br/python-Scriptaculous/python-Scriptaculous.spec http://ispbrasil.com.br/python-Scriptaculous/python-Scriptaculous-1.8.2-2.fc11.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1457322 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492815] Review Request: fife - Cross platform game creation framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492815 Mamoru Tasaka changed: What|Removed |Added Blocks||182235(FE-Legal) Flag|fedora-review+ |fedora-review? --- Comment #11 from Mamoru Tasaka 2009-07-06 13:25:55 EDT --- Blocking FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509798] Review Request: armv5tejl-unknown-linux-gnueabi-binutils - A GNU collection of binary utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509798 --- Comment #1 from Jason Tibbitts 2009-07-06 13:27:55 EDT --- Any reason the name is so terribly long? We already have msp430-binutils, spu-binutils and mingw32-* which seems to give precedence to armv5ejl-binutils, unless you expect to actually need to package binutils for some OS other than linux or some particular variant other than "unknown". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481355] Review Request: nurbs++ - A C++ library to manipulate and create NURBS curves and surfaces.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481355
--- Comment #12 from Mamoru Tasaka 2009-07-06
13:20:47 EDT ---
For 3.0.11-4:
* License
- As spot commented, please change the license
tag to "LGPLv2+".
* Conditional BuildRequires
-
274 checking for cppunit-config... no
-
- cppunit-devel is available on Fedora. Would you try
to add "BR: cppunit-devel" ?
- Also configure.in suggests that ImageMagick support
should be enabled by default. Would you try to
add "BR: ImageMagick-devel"?
* Man files
%files
%{_datadir}/man/man1/%{name}-config.1.gz
%files devel
%{_bindir}/nurbs++-config
---
- For macros:
* Please use %{_mandir} for %{_datadir}/man
* If you use %{name} macro for %{name}-config.1.gz, please
also use %{name} in %{_bindir}/nurbs++-config
Then:
- %{name}-config.1.gz man file should belong to -devel subpackage,
not to main package.
* Undefined non-weak symbols
- $ rpmlint nurbs++ shows lots of rpmlint warnings related to
undefined non-weak symbols:
---
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsd.so.0.1.0
_ZTIN4PLib11ClassPOvoidIdEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsd.so.0.1.0
_ZTIN4PLib6MatrixIfEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsd.so.0.1.0
_ZTIN4PLib6MatrixIdEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsf.so.0.1.0
_ZTIN4PLib11ClassPOvoidIfEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsf.so.0.1.0
_ZTIN4PLib6MatrixIfEE
nurbs++.i586: W: undefined-non-weak-symbol /usr/lib/libnurbsf.so.0.1.0
_ZTIN4PLib6MatrixIdEE
---
You can see these undefined non-weak symbols also by:
---
$ ldd -r /usr/lib/libnurbsd.so.0.1.0 >/dev/null
undefined symbol: _ZTIN4PLib11ClassPOvoidIdEE (/usr/lib/libnurbsd.so.0.1.0)
undefined symbol: _ZTIN4PLib6MatrixIfEE (/usr/lib/libnurbsd.so.0.1.0)
undefined symbol: _ZTIN4PLib6MatrixIdEE (/usr/lib/libnurbsd.so.0.1.0)
...
---
It seems that
- libnurbsd.so.0 should be linked also against
* libmatrix.so
* libmatrixN.so
* libmatrixI.so
- libnurbsf.so should be linked also against
* The above 3 libraries
* Also libGL.so, libGLU.so
For example:
$
LD_PRELOAD=/usr/lib/libmatrix.so.1:/usr/lib/libmatrixN.so.1:/usr/lib/libmatrixI.so.1:/usr/lib/libGL.so:/usr/lib/libGLU.so
ldd -r /usr/lib/libnurbsf.so
linux-gate.so.1 => (0x00c8b000)
/usr/lib/libmatrix.so.1 (0x007f)
/usr/lib/libmatrixN.so.1 (0x00aaa000)
/usr/lib/libmatrixI.so.1 (0x00eea000)
/usr/lib/libGL.so (0x0011)
/usr/lib/libGLU.so (0x00ce)
libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x003e5000)
libm.so.6 => /lib/libm.so.6 (0x008c7000)
libc.so.6 => /lib/libc.so.6 (0x00184000)
libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x00b61000)
libX11.so.6 => /usr/lib/libX11.so.6 (0x004dc000)
libXext.so.6 => /usr/lib/libXext.so.6 (0x006c2000)
libXxf86vm.so.1 => /usr/lib/libXxf86vm.so.1 (0x0030)
libXdamage.so.1 => /usr/lib/libXdamage.so.1 (0x00327000)
libXfixes.so.3 => /usr/lib/libXfixes.so.3 (0x00305000)
libdrm.so.2 => /usr/lib/libdrm.so.2 (0x0030a000)
libpthread.so.0 => /lib/libpthread.so.0 (0x00c22000)
libdl.so.2 => /lib/libdl.so.2 (0x00caa000)
/lib/ld-linux.so.2 (0x00761000)
libxcb.so.1 => /usr/lib/libxcb.so.1 (0x0073)
libXau.so.6 => /usr/lib/libXau.so.6 (0x00bbd000)
librt.so.1 => /lib/librt.so.1 (0x00315000)
* %changelog format
- It is useful in Fedora CVS that one line is put between each %changelog
entry like:
* Sat Jun 06 2009 3.0.11-4
- Patch to fix build for gcc-4.4
- Add buildrequires to fix autoreconf/libtool command missing in f11 koji
* Sat Jan 24 2009 3.0.11-3
- Modified patch to enable opengl build
* Sat Jan 24 2009 3.0.11-2
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509609] Package Request: mediawiki-rss - rss tag extension for mediaiwki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509609 Ian Weller changed: What|Removed |Added Flag||needinfo?(her...@gmail.com) --- Comment #3 from Ian Weller 2009-07-06 13:18:04 EDT --- Clint, can you confirm for me that this PHP script pulls in the Magpie RSS libraries properly? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509883] New: Review Request: sipcalc - "advanced" console based ip subnet calculator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sipcalc - "advanced" console based ip subnet calculator https://bugzilla.redhat.com/show_bug.cgi?id=509883 Summary: Review Request: sipcalc - "advanced" console based ip subnet calculator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: gie...@snickers.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://dirtypackets.net/software/rpm/sipcalc/sipcalc.spec SRPM URL: http://dirtypackets.net/software/rpm/sipcalc/sipcalc-1.1.4-1.src.rpm Description: Sipcalc is an "advanced" console based ip subnet calculator This is a new package, I am a new packager (this is my second package submitted for review) and I require a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509883] Review Request: sipcalc - "advanced" console based ip subnet calculator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509883 Gary T. Giesen changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492815] Review Request: fife - Cross platform game creation framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492815 --- Comment #10 from Tom "spot" Callaway 2009-07-06 13:10:40 EDT --- Wow, that license is a mess. I'm just going to say non-free. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #23 from Antti Andreimann 2009-07-06 13:08:12 EDT --- (In reply to comment #19) > correctly honored. If this is already honored, make build.log more > verbose so that we can easily check it from build.log. Build flags were already correctly honoured, the build log is now more verbose. Updated package: %build -CXXFLAGS=$RPM_OPT_FLAGS ./build.sh +MAKEFLAGS="verbose=1" CXXFLAGS=$RPM_OPT_FLAGS ./build.sh Also added new entries to changelog and a few comments. Spec URL: http://anttix.org/fedora/pkg/xsd.spec SRPM URL: http://anttix.org/fedora/pkg/xsd-3.2.0-3.fc10.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1457171 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492815] Review Request: fife - Cross platform game creation framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492815 --- Comment #9 from Jason Tibbitts 2009-07-06 13:02:53 EDT --- That license seems to contradict itself (commercial use is OK with credit, but no permission to sell, etc.) but I have a hard time thinking that even a liberal interpretation could be free. It starts out good: " All the graphics and meshes are freeware. Even for commercial Games. I just want my name in the Credits in the commercial case: Reiner "Tiles" Prokein. You can modify my graphics in every needed way to fit it to your needs: size, colour, fileformat, etc., you can reuse the textures ... . " But then it contradicts itself: " Even when the Graphics and meshes are freeware, it doesn´t mean that you can upload my raw graphics and meshes to your page, sell them or do something else with it. This also includes recoloured or in other ways modified Sprites, Tilesets or meshes. The graphics and meshes itself are mine as long as you haven´t made something with it. But it becomes completely yours when you make a game or something like that with it :) . " -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507053] Review Request: latrace - glibc 2.4+ LD_AUDIT feature frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507053 --- Comment #5 from Bill Nottingham 2009-07-06 12:57:18 EDT --- Should this obsolete ltrace? Maybe I'm confused as to the usage case overlap here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #22 from Mamoru Tasaka 2009-07-06 12:45:41 EDT --- (In reply to comment #21) > (In reply to comment #19) > > > ? ace > > > > # Requires: ace-devel - only needed for applications using ACE streams > > # enable when Fedora gets ACE packages > > > > - Is this differect from > > https://admin.fedoraproject.org/pkgdb/packages/name/ace ? > > Yep! > The ace that XSD supports is an Adaptive Communication Environment > and can be found from here: > http://www.cs.wustl.edu/~schmidt/ACE.html Ah, thanks. This one is review request bug 450164 (which is blocked by legal issue) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509739] Review Request: daemonize - run a command as a Unix daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509739 --- Comment #17 from Gary T. Giesen 2009-07-06 12:41:58 EDT --- Updated package incorporating new release (1.5.6), which upstream has applied Makefile patches for. Incorporated changes to INSTALL="install -p" Package is available at: http://dirtypackets.net/software/rpm/daemonize/daemonize-1.5.6-1.src.rpm http://dirtypackets.net/software/rpm/daemonize/daemonize.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507053] Review Request: latrace - glibc 2.4+ LD_AUDIT feature frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507053 --- Comment #4 from Jiri Olsa 2009-07-06 12:39:20 EDT --- (In reply to comment #3) > formal review is here, see the notes below: > > BAD source files match upstream: > OK package meets naming and versioning guidelines. > OK specfile is properly named, is cleanly written and uses macros > consistently. > OK dist tag is present. > OK license field matches the actual license. > OK license is open source-compatible (GPLv3+). License text included in > package. > OK latest version is being packaged. > OK BuildRequires are proper. > OK compiler flags are appropriate. > OK %clean is present. > OK package builds in mock (Rawhide/x86_64). > OK debuginfo package looks complete. > BAD rpmlint is silent. > OK final provides and requires look sane. > N/A %check is present and all tests pass. > OK no shared libraries are added to the regular linker search paths. > OK owns the directories it creates. > OK doesn't own any directories it shouldn't. > OK no duplicates in %files. > BAD file permissions are appropriate. > OK correct scriptlets present. > OK code, not content. > OK documentation is small, so no -docs subpackage is necessary. > OK %docs are not necessary for the proper functioning of the package. > OK no headers. > OK no pkgconfig files. > OK no libtool .la droppings. > OK not a GUI app. > > - source archives differs - a newer one is packaged in srpm, you should never > change a publicly released archive, but release a new one with increased > version > - rpmlint complains a bit: > latrace.src: W: no-version-in-last-changelog > latrace.x86_64: W: no-version-in-last-changelog > - https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs fixed > latrace.x86_64: W: no-soname /usr/lib64/libltaudit.so > - can be ignored here fixed > latrace.x86_64: W: shared-lib-calls-exit /usr/lib64/libltaudit.so > e...@glibc_2.2.5 > - hint when rpmlint is run with "-i" > This library package calls exit() or _exit(), probably in a non-fork() > context. Doing so from a library is strongly discouraged - when a library > function calls exit(), it prevents the calling program from handling the > error, reporting it to the user, closing files properly, and cleaning up any > state that the program has. It is preferred for the library to return an > actual error code and let the calling program decide how to handle the > situation. > - requires a comment why this is correct it is in the flex code.. YY_FATAL_ERROR define defaults to yy_fatal_error function, which calls exit. So far I can see 2 options: - either leave it as it is, ending up in the program exit due to the fatal cond., - or redefine YY_FATAL_ERROR to notify user without exit, but this ends with segfault.. currently I'd rather leave it as it is > > latrace.x86_64: E: non-standard-executable-perm /usr/bin/latrace 0555 > latrace.x86_64: E: non-standard-executable-perm /usr/lib64/libltaudit.so 0555 > - should be 0755 > - config files in /etc should be writable by owner (0644) fixed new spec file and sources are uploaded: Spec URL: http://people.redhat.com/jolsa/latrace/latrace.spec SRPM URL: http://people.redhat.com/jolsa/latrace/latrace-0.5.6-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 Antti Andreimann changed: What|Removed |Added Alias|xsdcpp |xsd -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #21 from Antti Andreimann 2009-07-06 12:23:05 EDT --- (In reply to comment #19) > ? ace > > # Requires: ace-devel - only needed for applications using ACE streams > # enable when Fedora gets ACE packages > > - Is this differect from > https://admin.fedoraproject.org/pkgdb/packages/name/ace ? Yep! The ace that XSD supports is an Adaptive Communication Environment and can be found from here: http://www.cs.wustl.edu/~schmidt/ACE.html I'll add this URL as a comment to the spec file as a reminder what the hell is ACE ;) > Please make it sure that Fedora specific compilation flags are > correctly honored. If this is already honored, make build.log more > verbose so that we can easily check it from build.log. I'll look into it. Thanx. > - > xsd-doc.i586: W: file-not-utf8 > /usr/share/doc/xsd-doc-3.2.0/cxx/tree/guide/cxx-tree-guide.ps > xsd-doc.i586: W: file-not-utf8 > /usr/share/doc/xsd-doc-3.2.0/cxx/parser/guide/cxx-parser-guide.ps > xsd-doc.i586: W: file-not-utf8 > /usr/share/doc/xsd-doc-3.2.0/cxx/tree/manual/cxx-tree-manual.ps > - > - Can these files be converted into UTF-8 easily? Unfortunately I'm not aware of a tool that can convert Postscript files to UTF-8. I tried to do it manually, but wasn't successful :( I did however document this error in initial report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497622 --- Comment #11 from Tim Fenn 2009-07-06 12:22:34 EDT --- Everything is all set except that aqua seems to only be available as part of the apbs download. However, its LGPLv2+, which doesn't jive with apbs. Should I just pull aqua out of apbs' SVN repo and make it its own package that way? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469470] Review Request: mz - A fast versatile packet generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469470 Mamoru Tasaka changed: What|Removed |Added CC||mtas...@ioa.s.u-tokyo.ac.jp --- Comment #22 from Mamoru Tasaka 2009-07-06 12:13:16 EDT --- Well, the newest srpm is the one written in comment 14, right? (Personally I would prefer that srpm is also to renamed as "mausezahn") -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #20 from Mamoru Tasaka 2009-07-06 12:05:25 EDT --- (In reply to comment #18) > I have a question though: does it make sense to add to spec: > Provides: xsd-devel I don't think this is needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508510] Review Request: python-Scriptaculous - Scriptaculous packaged as TurboGears widgets.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508510 --- Comment #3 from Itamar Reis Peixoto 2009-07-06 12:03:39 EDT --- pong please hold, I will do this today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #19 from Mamoru Tasaka 2009-07-06 12:04:33 EDT --- For 3.2.0-2: ? ace # Requires: ace-devel - only needed for applications using ACE streams # enable when Fedora gets ACE packages - Is this differect from https://admin.fedoraproject.org/pkgdb/packages/name/ace ? * compiler flags 67 make: Entering directory `/builddir/build/BUILD/xsd-3.2.0+dep/libcult-1.4.4/cult' 68 m4 /builddir/build/BUILD/xsd-3.2.0+dep/libcult-1.4.4/cult/cli/mapper.hxx.m4 69 c++ /builddir/build/BUILD/xsd-3.2.0+dep/libcult-1.4.4/cult/eh/exception.cxx 70 c++ /builddir/build/BUILD/xsd-3.2.0+dep/libcult-1.4.4/cult/mm/new.cxx 71 c++ /builddir/build/BUILD/xsd-3.2.0+dep/libcult-1.4.4/cult/mm/counter.cxx 72 c++ /builddir/build/BUILD/xsd-3.2.0+dep/libcult-1.4.4/cult/mm/buffer.cxx 73 c++ /builddir/build/BUILD/xsd-3.2.0+dep/libcult-1.4.4/cult/rtti/type-info.cxx 74 c++ /builddir/build/BUILD/xsd-3.2.0+dep/libcult-1.4.4/cult/trace/log.cxx - From this build.log it "seems" that Fedora specific compilation flags are not honored correctly: https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags Please make it sure that Fedora specific compilation flags are correctly honored. If this is already honored, make build.log more verbose so that we can easily check it from build.log. ! rpmlint warnings - xsd-doc.i586: W: file-not-utf8 /usr/share/doc/xsd-doc-3.2.0/cxx/tree/guide/cxx-tree-guide.ps xsd-doc.i586: W: file-not-utf8 /usr/share/doc/xsd-doc-3.2.0/cxx/parser/guide/cxx-parser-guide.ps xsd-doc.i586: W: file-not-utf8 /usr/share/doc/xsd-doc-3.2.0/cxx/tree/manual/cxx-tree-manual.ps - - Can these files be converted into UTF-8 easily? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #18 from Antti Andreimann 2009-07-06 12:01:48 EDT --- Thanx! Can somebody now mark the package as fedora-review+ ? :) I have a question though: does it make sense to add to spec: Provides: xsd-devel For example syslinux (which contains headers and closely related binaries just like this package) does so. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508510] Review Request: python-Scriptaculous - Scriptaculous packaged as TurboGears widgets.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508510 --- Comment #2 from Parag AN(पराग) 2009-07-06 11:55:04 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507773] Review Request: python-daemon - Library to implement a well-behaved Unix daemon process
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507773 --- Comment #5 from Parag AN(पराग) 2009-07-06 11:54:29 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489686 Chitlesh GOORAH changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR), | |505154 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505154] Tracker for reviews of Science and Technology related packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505154 Chitlesh GOORAH changed: What|Removed |Added Depends on|489686 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=489686
Chitlesh GOORAH changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #78 from Chitlesh GOORAH 2009-07-06 11:35:52
EDT ---
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the base package %{name}
- MUST: The package meets the Packaging Guidelines.
- MUST: The package is licensed (LGPLv3+) with an open-source compatible
license
and meet other legal requirements as defined in the legal section of Packaging
Guidelines.
- MUST: The License field in the package spec file matches the actual license.
- MUST: the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package is
included in %doc.
- MUST: The spec file must be written in American English.
- MUST: The spec file for the package is be legible.
- MUST: The sources used to build the package must matches the upstream source,
as provided in the spec URL.
- MUST: The package successfully compiles and builds into binary rpms on at
least i386.
- MUST: All build dependencies is listed in BuildRequires.
- MUST: The spec file handles locales properly.
- MUST: If the package does not contain shared library files located in the
dynamic linker's default paths
- MUST: the package is not designed to be relocatable
- MUST: the package owns all directories that it creates.
- MUST: the package does not contain any duplicate files in the %files listing.
- MUST: Permissions on files are set properly.
- MUST: The package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
- MUST: The package consistently uses macros, as described in the macros
section of Packaging Guidelines.
- MUST: The package contains code, or permissable content. This is described in
detail in the code vs. content section of Packaging Guidelines.
- MUST: There are no Large documentation files
- MUST: %doc does not affect the runtime of the application. To summarize: If
it is in %doc, the program must run properly if it is not present.
- MUST: There are no Header files or static libraries
- MUST: The package does not contain library files with a suffix
- MUST: Package does NOT contain any .la libtool archives
- MUST: Package containing GUI applications includes a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
- MUST: Package does not own files or directories already owned by other
packages
SHOULD Items:
- SHOULD: The source package does include license text(s) as LICENSE.txt
- SHOULD: mock builds succcessfully in i386.
- SHOULD: The reviewer tested that the package functions as described. A
package should not segfault instead of running, for example.
- SHOULD: No scriptlets were used, those scriptlets must be sane.
- SHOULD: No subpackages present.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489686 --- Comment #79 from Chitlesh GOORAH 2009-07-06 11:37:55 EDT --- Complete the packaging process as from "Add_Package_to_CVS_and_Set_Owner" section https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_CVS_and_Set_Owner -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508836] Review Request: colossus - computer implementation of Titan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508836 --- Comment #16 from Bruno Wolff III 2009-07-06 11:14:06 EDT --- Thanks for the legal review. If circumstances change later, upstream has offered to help with any new artwork. They have already made extra legion markers for the variants and those are where things are the closest. The upstream project is known as Colossus, so excising "Titan" won't be a huge burden if that becomes necessary. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509856] Review Request: qrencode - The libqrencode library and application encodes QR Code symbols (2d barcodes)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509856 Bowe Strickland changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
