[Bug 512727] Review Request: perl-Async-MergePoint - Resynchronise diverged control flow
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512727 Marcela Maslanova mmasl...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Marcela Maslanova mmasl...@redhat.com 2009-07-27 01:53:38 EDT --- I suppose you forgot set cvs flag to ? http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure I hope you don't mind if I set it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513636] Review Request: php-layers-menu - Hierarchical PHP based DHTML menu system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513636 --- Comment #2 from David Nalley da...@gnsa.us 2009-07-27 02:18:38 EDT --- (In reply to comment #1) MUST: The package must be named according to the Package Naming Guidelines . I have some questions about package name The name strikes me as phplayersmenu, which should make the package name php-phplayersmenu, but I have asked for clarification. Based on the feedback I received, this name appears acceptable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 473835] Review Request: autoarchive - Simple backup tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473835 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Fabian Affolter fab...@bernewireless.net 2009-07-27 02:57:54 EDT --- New Package CVS Request === Package Name: autoarchive Short Description: Simple backup tool Owners: fab Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509990] Review Request: openssh-blacklist - Fingerprints of the keys affected by CVE-2008-0166
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509990 --- Comment #16 from Tomas Hoger tho...@redhat.com 2009-07-27 03:57:51 EDT --- Do you plan to introduce some other tool besides iwak that will use those private keys? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511280] Review Request: comoonics-cdsl-py - Cdsl tools written in python to manage cdsl (base on the open-sharedroot)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511280 --- Comment #5 from Frank Danapfel fdana...@redhat.com 2009-07-27 03:58:37 EDT --- The remaining requirements have also been checked: - PASS: doesn't ship locale files - PASS: no libraries shipped - GOOD: package is not relocatable - GOOD: all shipped directories owned by package, direct dependency or filesystem - GOOD: no duplicates in %files - GOOD: permissions on files are set properly - GOOD: package has a %clean section - GOOD: package uses macros consistently - GOOD: the package contains code, not content - PASS: no large documentation files - GOOD: %doc doesn't affect runtime - PASS: no header files - PASS: no static libraries - PASS: no pkgconfig files - PASS: no libraries included - PASS: no devel package - GOOD: no *.la libtool archives - PASS: no desktop file - GOOD: doesn't own files or directories owned by other packages - GOOD: build root is cleaned at the beginning of %install - GOOD: all file names are valid UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509990] Review Request: openssh-blacklist - Fingerprints of the keys affected by CVE-2008-0166
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509990 --- Comment #17 from Jan F. Chadima jchad...@redhat.com 2009-07-27 04:27:34 EDT --- Yes me or one of my students want to port some of CR0 tools (http://www.cr0.org/progs/sshfun/) and maybe more. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511280] Review Request: comoonics-cdsl-py - Cdsl tools written in python to manage cdsl (base on the open-sharedroot)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511280 Frank Danapfel fdana...@redhat.com changed: What|Removed |Added AssignedTo|fdana...@redhat.com |nphil...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513636] Review Request: php-layers-menu - Hierarchical PHP based DHTML menu system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513636 --- Comment #3 from Andrew Colin Kissa and...@topdog.za.net 2009-07-27 04:34:51 EDT --- Hi David, I have made the changes requested but i think it is better that i package the pear package as well (i can find the time) since that will speed up everything and remove the hold on this chain of packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512954] Review Request: opencryptoki - Implementation of the PKCS#11 (Cryptoki) specification v2.11
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512954
Dan Horák d...@danny.cz changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #6 from Dan Horák d...@danny.cz 2009-07-27 04:46:13 EDT ---
formal review is here, see the notes below:
OK source files match upstream:
c20e52f19a22cb9695b8298ca11481f3106e3c8d opencryptoki-2.2.8.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (CPL). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths - extra
ld.so.conf file added
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in devel
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- rpmlint complains a bit:
opencryptoki.x86_64: W: non-standard-gid /var/lib/opencryptoki pkcs11
opencryptoki.x86_64: E: non-standard-dir-perm /var/lib/opencryptoki 0770
= this is correct setup
opencryptoki.x86_64: W: incoherent-init-script-name pkcsslotd ('opencryptoki',
'opencryptokid')
= harmless, can be ignored
opencryptoki-libs.x86_64: W: non-conffile-in-etc
/etc/ld.so.conf.d/opencryptoki-x86_64.conf
= this is OK, the file shouldn't be edited by user
opencryptoki-libs.x86_64: W: dangling-relative-symlink
/usr/lib64/opencryptoki/methods ../../sbin
opencryptoki-libs.x86_64: W: dangling-relative-symlink
/usr/lib64/pkcs11/methods ../../sbin
= this is OK
opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/opencryptoki/stdll/libpkcs11_tpm.so
opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/opencryptoki/stdll/libpkcs11_sw.so
opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/opencryptoki/libopencryptoki.so
= explained in spec as required, libs should be dlopen-ed probably due
license compatibility reasons
this package is APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513797] Review Request: gnome-applet-cpufire - GNOME panel applet showing the CPU load as a fire
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513797 Edwin ten Brink ed...@tenbrink-bekkers.nl changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|ed...@tenbrink-bekkers.nl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512727] Review Request: perl-Async-MergePoint - Resynchronise diverged control flow
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512727 --- Comment #6 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-27 04:52:16 EDT --- Thx. I've missed it, indeed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509990] Review Request: openssh-blacklist - Fingerprints of the keys affected by CVE-2008-0166
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509990 --- Comment #18 from Tomas Hoger tho...@redhat.com 2009-07-27 04:58:20 EDT --- Ok. This still does not seem to have a very good 'required disk space on mirrors' vs. 'expected number of users of the package' ratio, but maybe it's just me. I'd still consider splitting those private keys subpackages into one with expected keys sizes (1024, 2048, 4096) and those of size less likely to be used in the wild (1023, 2047). Have you seen any research on most commonly used ssh key sizes? Do you have a tool that can be given a pid range and it'll generate all keys in the range? So the effort in generating missing keys can be split across multiple systems? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512674] Review Request: python-iwlib - Python module to interface with iwlib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512674 Dan Horák d...@danny.cz changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Dan Horák d...@danny.cz 2009-07-27 04:58:49 EDT --- Each iteration of a package during the review should be released with an increased release and with a changelog entry summarizing the changes. IMO using plain http instead of https should be preferred for Source URL. But all issues are fixed now and this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493246 Bug 493246 depends on bug 507703, which changed state. Bug 507703 Summary: Review Request: perl-Proc-Simple - Launch and control background processes https://bugzilla.redhat.com/show_bug.cgi?id=507703 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||ERRATA --- Comment #24 from Liang Suilong liangsuil...@gmail.com 2009-07-27 05:18:39 EDT --- ping again -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 506804] Review Request: anerley - Moblin widgets for people information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506804 --- Comment #10 from Peter Robinson pbrobin...@gmail.com 2009-07-27 05:26:55 EDT --- New upstream release, and a build now all the deps are in rawhide :) SRPM: http://pbrobinson.fedorapeople.org/anerley-0.0.18-1.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1532838 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511895] Review Request: clutter-imcontext - IMContext Framework Library for Clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511895 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #15 from Peter Robinson pbrobin...@gmail.com 2009-07-27 05:29:00 EDT --- Built and on its way to rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513898] Review Request: keychecker - Generate list of installed packages sorted by GPG key
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513898 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro Flag||fedora-review+ --- Comment #3 from manuel wolfshant wo...@nobugconsulting.ro 2009-07-27 05:33:47 EDT --- All well, package approved. Please be as kind as to fix the typo from Source0 (fedorahosted.org rather than fedorahosted,org) before import. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497622
--- Comment #33 from Jussi Lehtola jussi.leht...@iki.fi 2009-07-27 05:51:19
EDT ---
(In reply to comment #32)
Package does not build:
RPM build errors:
File not found:
/builddir/build/BUILDROOT/apbs-1.1.0-5.fc11.x86_64/usr/bin/ApbsClient.pyc
File not found:
/builddir/build/BUILDROOT/apbs-1.1.0-5.fc11.x86_64/usr/bin/ApbsClient.pyo
This is due to RPM in Fedora 11 not byte compiling files in %{_bindir}.
Instead
of %exclude you could just delete the files after %install with rm -f which
doesn't complain about possible non-existing files.
I just removed the %exclude statement and built using F11 (since I won't be
packaging this for F10 anyway).
Spec URL: http://www.stanford.edu/~fenn/packs/apbs.spec
SRPM URL: http://www.stanford.edu/~fenn/packs/apbs-1.1.0-6.fc11.src.rpm
.. but won't you be building for EPEL, if you need this for pymol?
**
We usually don't add license files ourselves.
**
You're using ATLAS for ARPACK? You might want to use it for blas, too:
--with-blas=-L%{_libdir}/atlas -lf77blas -latlas
should do it.
**
For the tools installation I suggest using a loop:
for bin in tools/manip/{psize.py,coulomb,born}
tools/mesh/{mgmesh,dxmath,mergedx2,mergedx,value,uhbd_asc2bin,smooth,dx2mol,dx2uhbd,similarity,multivalue,benchmark,analysis}
arpack/driver; do
install -p -m 755 $bin %{buildroot}%{_bindir}/apbs-`basename $bin`
done
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497622 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #34 from Jussi Lehtola jussi.leht...@iki.fi 2009-07-27 05:53:57 EDT --- Well, I guess this package is good to go. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513874] Review Request: perl-Math-Calc-Units - Human-readable unit-aware calculator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513874 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497622
--- Comment #35 from Jussi Lehtola jussi.leht...@iki.fi 2009-07-27 05:55:48
EDT ---
Before importing, check the stuff in comment #33; I'd add
rm -rf %{buildroot}%{_bindir}/*.py{c,o}
to the end of install to be able to build on F-10 and EPEL.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513869] Review Request: perl-Beanstalk-Client - Client class to talk to a beanstalkd server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513869 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513954] New: Review Request: HTML_Template_PHPLIB - PHP template system based on preg_*
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: HTML_Template_PHPLIB - PHP template system based on preg_* https://bugzilla.redhat.com/show_bug.cgi?id=513954 Summary: Review Request: HTML_Template_PHPLIB - PHP template system based on preg_* Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: and...@topdog.za.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://topdog-software.com/oss/SRPMS/fedora/HTML_Template_PHPLIB/HTML_Template_PHPLIB.spec SRPM URL: http://topdog-software.com/oss/SRPMS/fedora/HTML_Template_PHPLIB/HTML_Template_PHPLIB-1.4.0-1.fc11.src.rpm Description: This is the PEAR port of the popular PHPLIB template system. It contains some features not currently found in the original version -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513636] Review Request: php-layers-menu - Hierarchical PHP based DHTML menu system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513636 --- Comment #4 from Andrew Colin Kissa and...@topdog.za.net 2009-07-27 06:06:48 EDT --- I have submitted a review request for HTML_Template_PHPLIB https://bugzilla.redhat.com/show_bug.cgi?id=513954 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512954] Review Request: opencryptoki - Implementation of the PKCS#11 (Cryptoki) specification v2.11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512954 Michal Schmidt mschm...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Michal Schmidt mschm...@redhat.com 2009-07-27 06:07:19 EDT --- New Package CVS Request === Package Name: opencryptoki Short Description: Implementation of the PKCS#11 (Cryptoki) specification v2.11 Owners: michich sharkcz Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512674] Review Request: python-iwlib - Python module to interface with iwlib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512674 Jiri Popelka jpope...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jiri Popelka jpope...@redhat.com 2009-07-27 06:26:34 EDT --- New Package CVS Request === Package Name: python-iwlib Short Description: Wireless settings python bindings Owners: jpopelka Branches: F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512724] Review Request: perl-Devel-FindRef - Track down reference problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512724 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512723] Review Request: perl-Socket-GetAddrInfo - RFC 2553's getaddrinfo and getnameinfo functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512723 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512729] Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512729 Bug 512729 depends on bug 512723, which changed state. Bug 512723 Summary: Review Request: perl-Socket-GetAddrInfo - RFC 2553's getaddrinfo and getnameinfo functions https://bugzilla.redhat.com/show_bug.cgi?id=512723 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512726] Review Request: perl-Test-Refcount - Assert reference counts on objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512726 Bug 512726 depends on bug 512724, which changed state. Bug 512724 Summary: Review Request: perl-Devel-FindRef - Track down reference problems https://bugzilla.redhat.com/show_bug.cgi?id=512724 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246525] Review Request: libMini - A high-performance terrain rendering library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=246525 --- Comment #36 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-27 06:33:41 EDT --- @Rick Do you understand what the problem is with the current Mini.pc ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 363741] Review Request: libewf - Library for the Expert Witness Compression Format (EWF)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=363741 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #6 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-27 07:03:24 EDT --- Package Change Request == Package Name: libewf New Branches: EL-5 Owners: kwizart -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511212] Review Request: cluster-glue - reusable clustering components
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=511212
Fabio Massimo Di Nitto fdini...@redhat.com changed:
What|Removed |Added
CC||fdini...@redhat.com
--- Comment #12 from Fabio Massimo Di Nitto fdini...@redhat.com 2009-07-27
07:13:39 EDT ---
Hi guys,
I did run through a review of cluster-glue.
rpmlint output:
[fabbi...@daitarn-fedora rpmbuild]$ rpmlint SPECS/cluster-glue.spec
SRPMS/cluster-glue-0.9-4.fc12.src.rpm RPMS/x86_64/cluster-glue-*
cluster-glue.x86_64: E: non-standard-dir-perm /var/lib/heartbeat/cores/nobody
0700
cluster-glue.x86_64: E: non-standard-dir-perm /var/lib/heartbeat/cores/root
0700
cluster-glue.x86_64: E: non-standard-dir-perm /var/lib/heartbeat/cores/daemon
0700
5 packages and 1 specfiles checked; 3 errors, 0 warnings.
For the record:
SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency. [22]
the -devel package Requires: %{name} = %{version}-%{release}
If this is done on purpose it should be documented in the spec file otherwise
dropped.
SHOULD: The reviewer should test that the package builds in mock. [29]
For some reasons mock is busted in rawhide and I am unable to perform this
check. The package builds fine in an installed rawhide machine.
The package passes all the checklist for ReviewGuidelines.
Kevin: I hope this can help speed up the process.
Fabio
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439100] Review Request: octaviz - 3D visualization system for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439100 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net Flag|needinfo?(e...@eh3.com) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439100] Review Request: octaviz - 3D visualization system for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439100 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC|fab...@bernewireless.net| --- Comment #23 from Fabian Affolter fab...@bernewireless.net 2009-07-27 07:29:31 EDT --- Claudio, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479515] Review Request: Music Organizer - Music Organizer , organize your mp3, ogg, flac and mp4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479515 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag||needinfo?(camillegal...@yah ||oo.fr) --- Comment #6 from Fabian Affolter fab...@bernewireless.net 2009-07-27 07:25:46 EDT --- Camille, are you still interested to maintain this package in Fedora? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439100] Review Request: octaviz - 3D visualization system for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439100 --- Comment #24 from Fabian Affolter fab...@bernewireless.net 2009-07-27 07:30:59 EDT --- Sorry again...Claudio, can you please make the changes from Comment #18? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503297] Review Request: panoglview - Immersive viewer for spherical panoramas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503297 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Fabian Affolter fab...@bernewireless.net 2009-07-27 07:32:34 EDT --- Package was built: http://koji.fedoraproject.org/koji/buildinfo?buildID=120355 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC|fedora-package-rev...@redha | |t.com | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511212] Review Request: cluster-glue - reusable clustering components
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=511212
--- Comment #13 from Andrew Beekhof and...@beekhof.net 2009-07-27 07:43:01
EDT ---
(In reply to comment #12)
SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency. [22]
the -devel package Requires: %{name} = %{version}-%{release}
If this is done on purpose it should be documented in the spec file otherwise
dropped.
I'll drop it.
SHOULD: The reviewer should test that the package builds in mock. [29]
For some reasons mock is busted in rawhide and I am unable to perform this
check. The package builds fine in an installed rawhide machine.
Strange, I'm running rawhide from last week and mock seems to work fine.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448661] Review Request: u-boot-tools - contains mkimage a tool to create kernel bootable images for u-boot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=448661 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net Flag|needinfo?(ga...@kernel.cras | |hing.org) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513774] Review Request: python-firkin - A python module to convert between different measurement units
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513774 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Blocks||505154(FE-SCITECH) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505154] Tracker: Review Requests for Science and Technology related packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505154 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Depends on||513774 Bug 505154 depends on bug 496742, which changed state. Bug 496742 Summary: Review Request: elfelli - Visualisation tool for flux lines https://bugzilla.redhat.com/show_bug.cgi?id=496742 What|Old Value |New Value Status|ON_QA |CLOSED Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507410] Review Request: yum-download-order - Yum plugin to order downloading of packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507410 Sergio Pascual sergio.pa...@gmail.com changed: What|Removed |Added Flag||needinfo?(rpan...@redhat.co ||m) --- Comment #8 from Sergio Pascual sergio.pa...@gmail.com 2009-07-27 07:58:14 EDT --- Rakesh, the tarball upstream doesn't match the source in rpm. Please upload the new tarball so that I can write the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507410] Review Request: yum-download-order - Yum plugin to order downloading of packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507410 Rakesh Pandit rpan...@redhat.com changed: What|Removed |Added Flag|needinfo?(rpan...@redhat.co | |m) | --- Comment #9 from Rakesh Pandit rpan...@redhat.com 2009-07-27 08:02:59 EDT --- Sergio, I am on holidays and will do it in some days depending on time I get for this week (no access to my test box at working place). If I miss this week I will surely do it first week of Augest after going back to my place. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225769] Merge Review: freeradius
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225769
Peter Lemenkov lemen...@gmail.com changed:
What|Removed |Added
Blocks||487059
--- Comment #4 from Peter Lemenkov lemen...@gmail.com 2009-07-27 08:11:27
EDT ---
REVIEW (sorry for the delay):
+/- rpmlint outputs a LOT of messages:
http://peter.fedorapeople.org/freeradius_rpmlint.txt
However, as John Dennis already mentioned in bz#487059, most of these issues
may be omitted safely:
* non-standard GID:
* non-readable files
* non-config files under /etc
* no-documentation
The rest of rpmlint messages:
freeradius.i586: W: obsolete-not-provided freeradius-dialupadmin
freeradius.i586: W: obsolete-not-provided freeradius-dialupadmin-ldap
freeradius.i586: W: obsolete-not-provided freeradius-dialupadmin-mysql
freeradius.i586: W: obsolete-not-provided freeradius-dialupadmin-postgresql
I think, this may be omitted too.
freeradius.i586: E: zero-length /var/log/radius/radius.log
Likewise.
freeradius.i586: E: incoherent-logrotate-file /etc/logrotate.d/radiusd
Due to historical reasons, the main application name differs from the package's
name. We cannot change anything here. So this issue should be omitted.
freeradius.i586: W: file-not-utf8
/usr/share/doc/freeradius-2.1.6/rfc/pppext-eap-sim-12.txt
This should be fixed at the %prep stage.
freeradius.i586: E: zero-length /var/log/radius/radutmp
May be omitted.
freeradius.i586: W: file-not-utf8 /usr/share/doc/freeradius-2.1.6/rlm_dbm
This should be fixed at the %prep stage.
freeradius.i586: E: executable-marked-as-config-file /etc/rc.d/init.d/radiusd
Does it really should be marked as a config? I'm sure it doesn't. All
installation-specific changes should be placed in /etc/sysconfig/%{name} or
something similar.
freeradius.i586: W: file-not-utf8
/usr/share/doc/freeradius-2.1.6/rfc/draft-sterman-aaa-sip-00.txt
This should be fixed at the %prep stage.
freeradius.i586: E: non-standard-executable-perm /etc/raddb/certs/bootstrap
0750
I don't like the idea to place executables (scripts) into /etc/ (exept known
exeptions like /etc/init.d ). However looks like this should be placed here due
to historical reasons. So this issue may be omitted too.
freeradius.i586: W: incoherent-init-script-name radiusd ('freeradius',
'freeradiusd')
Due to historical reasons, the main application name differs from the package's
name. We cannot change anything here. So this issue should be omitted.
freeradius-debuginfo.i586: W: hidden-file-or-dir
/usr/src/debug/freeradius-server-2.1.6/src/main/.libs
freeradius-debuginfo.i586: W: hidden-file-or-dir
/usr/src/debug/freeradius-server-2.1.6/src/main/.libs
Looks like a leftover from wrongly picked up binaries byt script to generate
debuginfo. I think this may be ignored.
freeradius-debuginfo.i586: W: spurious-executable-perm
/usr/src/debug/freeradius-server-2.1.6/src/modules/rlm_ippool/rlm_ippool_tool.c
freeradius-debuginfo.i586: W: spurious-executable-perm
/usr/src/debug/freeradius-server-2.1.6/src/modules/rlm_linelog/rlm_linelog.c
This should be fixed at the %prep stage.
freeradius-postgresql.i586: W: summary-not-capitalized postgresql support for
freeradius
freeradius-unixODBC.i586: W: summary-not-capitalized unixODBC support for
freeradius
This may be omitted
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec .
+/- The package meets the Packaging Guidelines. At least, I cannot find any
issues. Yet, some small issues still remains:
* I'm sure, that %description for -devel subpackage must be changed, since it
has nothing to do with static libraries.
* See my note regarding ldconfig below.
* I advice you to consider adding support for Firebird and iodbc, since both of
them are included in Fedora. However this is not a blocker - just my
suggestion.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible (as legible, as this quite complex
package can be).
+ The sources used to build the package match the upstream source, as provided
in the spec URL.
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
dist-5E-epel
http://koji.fedoraproject.org/koji/taskinfo?taskID=1536573
dist-f11
http://koji.fedoraproject.org/koji/taskinfo?taskID=1536583
+ All build dependencies are listed in BuildRequires.
- The main package calls ldconfig in %post and %postun, however I didn't
[Bug 512725] Review Request: perl-Devel-Refcount - Obtain the REFCNT value of a referent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512725 --- Comment #4 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-27 08:35:07 EDT --- I've moved to cpanspec without bumping release. ^ Spec URL: http://kwizart.fedorapeople.org/review/perl-Devel-Refcount.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Devel-Refcount-0.06-1.fc11.src.rpm Description: Obtain the REFCNT value of a referent -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513307] Review Request: Netdisco - A web-based network management tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513307 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503336] Review Request: newsbeuter - console based feed reader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503336 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 487098] Review Request: Djblets - A collection of useful classes and functions for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487098 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466183] Review Request: sblim-sfcb - Small Footprint CIM Broker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466183 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511280] Review Request: comoonics-cdsl-py - Cdsl tools written in python to manage cdsl (base on the open-sharedroot)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511280 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #6 from Nils Philippsen nphil...@redhat.com 2009-07-27 09:12:44 EDT --- I concur with Frank's review. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513898] Review Request: keychecker - Generate list of installed packages sorted by GPG key
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513898 Jon Stanley jonstan...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jon Stanley jonstan...@gmail.com 2009-07-27 09:50:53 EDT --- New Package CVS Request === Package Name: keychecker Short Description: Generate list of installed packages sorted by GPG key Owners: jstanley Branches: F-10 F-11 EL-4 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498390] Review Request: rakudo - Rakudo - A Perl compiler for Parrot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498390 --- Comment #4 from Gerd Pokorra g...@zimt.uni-siegen.de 2009-07-27 09:59:28 EDT --- The next step to build Rakudo Perl 6 from the parrot package is done. The Spec- and SRPM-files on the FTP-Server are updated. URL of the current srcatch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1539789 As next dynpmc.pl will be fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=493246
--- Comment #25 from Jan Klepek jan.kle...@hp.com 2009-07-27 10:02:46 EDT ---
looks ok, last small things...
1] shutter.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 12)
2] in %install you are creating directory named 0755 in bin/ and share/
Are there any problems? I think it is OK for us.
When i think about it, you probably want to do something else by following
commands:
install -d -p 0755 $RPM_BUILD_ROOT%{_bindir}
install -d -p 0755 $RPM_BUILD_ROOT%{_datadir}
cp -fr -p 0755 bin/* $RPM_BUILD_ROOT%{_bindir}/
cp -rf -p 0755 share/* $RPM_BUILD_ROOT%{_datadir}/
if you want to set permissions, you have to use switch -m (for install, cp
doesn't allow this as far as I know)
from this POV i don't think that spec file is legible (incorrectly used
commands)
I'm sorry for lag between my answers/replies, work takes more time nowadays
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 246525] Review Request: libMini - A high-performance terrain rendering library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=246525 --- Comment #37 from Rick L Vinyard Jr rviny...@cs.nmsu.edu 2009-07-27 10:07:36 EDT --- (In reply to comment #36) @Rick Do you understand what the problem is with the current Mini.pc ? Yes. Just haven't had time to look into the library yet. Things are hectic again... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504468] Review Request: rubygem-treetop - A Ruby-based text parsing and interpretation DSL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504468 Jan Klepek jan.kle...@hp.com changed: What|Removed |Added Flag||needinfo?(lkund...@v3.sk) --- Comment #6 from Jan Klepek jan.kle...@hp.com 2009-07-27 10:12:09 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511280] Review Request: comoonics-cdsl-py - Cdsl tools written in python to manage cdsl (base on the open-sharedroot)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511280 Marc Grimme gri...@atix.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Marc Grimme gri...@atix.de 2009-07-27 10:36:25 EDT --- New Package CVS Request === Package Name: comoonics-cdsl-py Short Description: Comoonics cdsl utilities and library written in Python Owners: elcody02 markhla Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511212] Review Request: cluster-glue - reusable clustering components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511212 --- Comment #14 from Andrew Beekhof and...@beekhof.net 2009-07-27 10:45:31 EDT --- New version: - Use linux-ha.org for Source0 - Remove Requires: $name from -devel as its implied - Instead of 'daemon', use the same user and group from the Heartbeat package and create it if necessary* SPEC:http://oss.clusterlabs.org/~beekhof/fedora/cluster-glue.spec SRPM: http://oss.clusterlabs.org/~beekhof/fedora/cluster-glue-0.9-5.fc12.src.rpm * Originally I had been of the notion that we should use daemon instead of hacluster/haclient. However for the sake of consistency, its probably better not to change the user/group. Looking at the Heartbeat spec, it does not create a user with a fixed id. Is that intentional? There is a comment in the changelog indicating that it used to, with uid=24 it seems, but that functionality seems to have been dropped somewhere along the line. Anyway, I've preserved the Heartbeat's %pre semantics when adding it to cluster-glue. Btw. I can no longer confirm that it builds with mock as the big rebuild seems to cause: ERROR with rpm_check_debug vs depsolve: rpmlib(PayloadIsXz) = 5.2-1 is needed by glibc-devel-2.10.90-7.1.x86_64 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503256 --- Comment #46 from Gareth John gareth.l.j...@googlemail.com 2009-07-27 10:53:31 EDT --- Hi all sorry for the long delay. Here is the most up to date spec and src.rpm. I have checked all of the comments and have made sure that no rpath issues occur. I have put the -doc pkg into the -devel docs section as it contains developers docs. I have also checked everything out in rpmlint and mock and it seems to be ok on all fronts it builds in mock and gives no warnings on rpmlint other than no docs in -example pkg. Here are the files. http://garethsrpms.googlecode.com/files/gtkmm-utils-0.4.0-8.fc10.src.rpm http://garethsrpms.googlecode.com/files/gtkmm-utils.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503847] Review Request: paperbox - A GTK tracker based document browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503847 --- Comment #10 from Gareth John gareth.l.j...@googlemail.com 2009-07-27 11:12:23 EDT --- Hello no movement as per your comment #6 Jussi. Have no updated gtkmm-utils as you no doubt know. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504424] Review Request: ruby-json - A JSON implementation in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504424 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(lxt...@gmail.com) --- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-27 11:12:40 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513998] New: Review Request: html2txt - Produces a text-only file from an HTML file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: html2txt - Produces a text-only file from an HTML file https://bugzilla.redhat.com/show_bug.cgi?id=513998 Summary: Review Request: html2txt - Produces a text-only file from an HTML file Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: h...@devin.com.br QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.devin.com.br/fedora-devel/SPECS/html2txt.spec SRPM URL: http://www.devin.com.br/fedora-devel/html2txt-0.99.1-1.fc11.src.rpm Description: html2txt doesn't do any conversion of your file, but only stripes ANYTHING between the '' and '' signs in the original html-file and writes the result to the specified text file. The html file remains untouched. -- I don't know if I'll need a new sponsor because I didn't package and work with Fedora team since 2006. FedoraProject Brazil asked for help on packaging the KyaPanel, so I'm trying to come back to help. Although KyaPanel is a noarch package, it uses this html2txt for some reporting generation. I'm studying with the author the possibility to substitute this single utility for a sed script, for compliance with the noarch nature of the whole package. But since this is not the case at this time, I think that packaging this program won't hurt :) The current KyaPanel review request is: https://bugzilla.redhat.com/show_bug.cgi?id=485401 And it's missing the spec, etc. I'll work through the week on the spec and its dependencies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513292] Review Request: condor-low-latency - Condor's Low-Latency scheduling
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513292 Robert Rati rr...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513286] Review Request: condor-ec2-enhanced - EC2 Enhanced AMI package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513286 Robert Rati rr...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513291] Review Request: condor-job-hooks - Condor Job Hooks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513291 Robert Rati rr...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513288] Review Request: condor-ec2-enhanced-hooks - Condor EC2 Enhanced hooks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513288 Robert Rati rr...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491694] Review Request: Anyterm - Web based terminal emulator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491694
--- Comment #32 from David Lutterkort lut...@redhat.com 2009-07-27 11:55:01
EDT ---
This looks good now, the only issue is that there is a type in the BuildRoot:
it should use %{name}, not ${name}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491694] Review Request: Anyterm - Web based terminal emulator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491694
--- Comment #33 from Mohammed Morsi mmo...@redhat.com 2009-07-27 12:06:21
EDT ---
Updated, changed ${name} to %{name}, new SRPM / SPEC uploaded here (though
that was the only change):
http://mohammed.morsi.org/blog/files/anyterm.spec
http://mohammed.morsi.org/blog/files/anyterm-1.1.29-8.fc10.src_.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513998] Review Request: html2txt - Produces a text-only file from an HTML file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513998 --- Comment #1 from Hugo Cisneiros h...@devin.com.br 2009-07-27 12:09:06 EDT --- Koji scratch build on dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1541252 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491694] Review Request: Anyterm - Web based terminal emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491694 David Lutterkort lut...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #34 from David Lutterkort lut...@redhat.com 2009-07-27 12:10:45 EDT --- OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used OK - Source md5sum matches upstream OK - No hardcoded pathnames OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent OK - rpmlint is silent OK - Proper debuginfo packages APPROVED (thanks to everybody doing inofficial reviews, made the official review a lot easier) Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513998] Review Request: html2txt - Produces a text-only file from an HTML file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513998 Bruno Wolff III br...@wolff.to changed: What|Removed |Added CC||br...@wolff.to --- Comment #2 from Bruno Wolff III br...@wolff.to 2009-07-27 12:49:18 EDT --- html2txt doesn't seem to be a very good tool for converting html to plain text. Could you use some other tool that is already in Fedora to do that? lynx will do it, but there are probably other tools that could do it as well. You can test lynx -force_html -dump and see if it does what you need. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513307] Review Request: Netdisco - A web-based network management tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513307 --- Comment #5 from Walter Gould w...@gouldfamily.org 2009-07-27 13:01:14 EDT --- Thanks Silas, I appreciate the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513636] Review Request: php-layers-menu - Hierarchical PHP based DHTML menu system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513636
--- Comment #5 from Andrew Colin Kissa and...@topdog.za.net 2009-07-27
13:10:32 EDT ---
FIXED
* Name - as stated the name is acceptable
* Install directory - corrected to %{_datadir}/php/%{name}/
* License - Updated to correct one LGPLv2+
* Bundled libraries - Unbundled HTML_Template_PHPLIB
Updated spec and srpm
http://topdog-software.com/oss/SRPMS/fedora/php-layers-menu/php-layers-menu.spec
http://topdog-software.com/oss/SRPMS/fedora/php-layers-menu/php-layers-menu-3.2.0-0.2.rc.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510943] Review Request: ipplan - Web-based IP address manager and tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510943 --- Comment #6 from Andrew Colin Kissa and...@topdog.za.net 2009-07-27 13:14:05 EDT --- Updated spec because of changes to dependent packages. http://topdog-software.com/oss/SRPMS/fedora/ipplan/ipplan.spec http://topdog-software.com/oss/SRPMS/fedora/ipplan/ipplan-4.91-3.a.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513998] Review Request: html2txt - Produces a text-only file from an HTML file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513998 --- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2009-07-27 13:25:46 EDT --- There's also html2text, already in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 451771] Review Request: maximus - an addon for metacity
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451771 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag||fedora-review? --- Comment #11 from Jason Tibbitts ti...@math.uh.edu 2009-07-27 13:28:32 EDT --- I guess I'll go ahead and set the flag, but I'm starting to think this should just be closed instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513286] Review Request: condor-ec2-enhanced - EC2 Enhanced AMI package
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513286
Nuno Santos nsan...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||nsan...@redhat.com
AssignedTo|nob...@fedoraproject.org|nsan...@redhat.com
--- Comment #1 from Nuno Santos nsan...@redhat.com 2009-07-27 13:32:42 EDT
---
There are a few issues that need to be corrected, highlighted by !!! below:
condor-ec2-enhanced-1.0-13.fc10.src.rpm
MUST Items:
* MUST: rpmlint must be run on every package. The output should be posted in
the review.
!!!
$ rpmlint condor-ec2-enhanced-1.0-13.fc10.src.rpm
condor-ec2-enhanced.src: E: no-cleaning-of-buildroot %install
condor-ec2-enhanced.src: E: no-cleaning-of-buildroot %clean
condor-ec2-enhanced.src: W: no-%build-section
condor-ec2-enhanced.src: W: no-%clean-section
1 packages and 0 specfiles checked; 2 errors, 2 warnings.
!!!
$ rpmlint
/home/nsantos/rpmbuild/RPMS/noarch/condor-ec2-enhanced-1.0-13.fc11.noarch.rpm
condor-ec2-enhanced.noarch: W: dangerous-command-in-%post mv
condor-ec2-enhanced.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/condor-ec2-enhanced
condor-ec2-enhanced.noarch: W: incoherent-subsys
/etc/rc.d/init.d/condor-ec2-enhanced $prog
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
* MUST: The package must be named according to the Package Naming Guidelines .
OK
* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
* MUST: The package must meet the Packaging Guidelines .
!!!
missing %clean section
* MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
OK (ASL 2.0)
* MUST: The License field in the package spec file must match the actual
license.
OK
* MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the
text of the license(s) for the package must be included in %doc.
OK
* MUST: The spec file must be written in American English.
OK
* MUST: The spec file for the package MUST be legible.
OK
* MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
Reviewers should use md5sum for this task. If no upstream URL can be
specified for this package,
please see the Source URL Guidelines for how to deal with this.
!!!
missing upstream information (see
http://fedoraproject.org/wiki/Packaging/SourceURL for details)
* MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK
$ rpmbuild -ba condor-ec2-enhanced.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.yvsoqK
+ umask 022
+ cd /home/nsantos/rpmbuild/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /home/nsantos/rpmbuild/BUILD
+ rm -rf condor-ec2-enhanced-1.0
+ /usr/bin/gzip -dc
/home/nsantos/rpmbuild/SOURCES/condor-ec2-enhanced-1.0-13.tar.gz
+ /bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd condor-ec2-enhanced-1.0
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ echo 'Patch #0 (chkconfig_off.patch):'
Patch #0 (chkconfig_off.patch):
+ /bin/cat /home/nsantos/rpmbuild/SOURCES/chkconfig_off.patch
+ /usr/bin/patch -s -p1 --fuzz=0
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.GUH0KC
+ umask 022
+ cd /home/nsantos/rpmbuild/BUILD
+ '[' /home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
'!=' / ']'
+ rm -rf /home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
++ dirname
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
+ mkdir -p /home/nsantos/rpmbuild/BUILDROOT
+ mkdir /home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386
+ cd condor-ec2-enhanced-1.0
+ LANG=C
+ export LANG
+ unset DISPLAY
+ mkdir -p
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386/usr/sbin
+ mkdir -p
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//etc/condor
+ mkdir -p
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//etc/rc.d/init.d
+ cp -f caroniad
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//usr/sbin
+ cp -f config/caroniad.conf
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//etc/condor
+ cp -f config/condor-ec2-enhanced.init
/home/nsantos/rpmbuild/BUILDROOT/condor-ec2-enhanced-1.0-13.fc11.i386//etc/rc.d/init.d/condor-ec2-enhanced
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/redhat/brp-compress
+ /usr/lib/rpm/redhat/brp-strip /usr/bin/strip
+ /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump
+ /usr/lib/rpm/brp-python-bytecompile
+
[Bug 503490] Review Request: ayttm - Universal Instant Messaging Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503490 Siddhesh Poyarekar spoya...@redhat.com changed: What|Removed |Added CC||spoya...@redhat.com --- Comment #6 from Siddhesh Poyarekar spoya...@redhat.com 2009-07-27 13:34:18 EDT --- Minto, Parag: Following our discussion a few days ago, I talked about this with my upstream team: https://sourceforge.net/mailarchive/forum.php?thread_name=6e19a8cd0907250150h7ff2b53dl445dae2c191a22a%40mail.gmail.comforum_name=ayttm-devel and have committed a workaround for libtool libraries (*.la) upstream. I have added a new option --enable-posix-dlopen to use the dlopen/dlsym on *.so instead of the libtool routines. This option is disabled by default, so you will need to add it as a configure option in your package. This is available in ayttm cvs now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513797] Review Request: gnome-applet-cpufire - GNOME panel applet showing the CPU load as a fire
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513797 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flag||fedora-review? --- Comment #2 from Jason Tibbitts ti...@math.uh.edu 2009-07-27 13:51:36 EDT --- Setting the fedora-review flag as that seems to have been overlooked. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510979] Review Request: phpSmug - PHP wrapper for the SmugMug API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510979 --- Comment #13 from Jason Tibbitts ti...@math.uh.edu 2009-07-27 13:55:45 EDT --- I have none. I'll take care of this when I'm next running CVS, unless Kevin gets to it before I do. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491694] Review Request: Anyterm - Web based terminal emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491694 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #35 from Mohammed Morsi mmo...@redhat.com 2009-07-27 13:55:24 EDT --- New Package CVS Request === Package Name: anyterm Short Description: A web-based terminal emulator Owners: mmorsi Branches: F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491694] Review Request: Anyterm - Web based terminal emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491694 --- Comment #36 from Itamar Reis Peixoto ita...@ispbrasil.com.br 2009-07-27 14:05:03 EDT --- (In reply to comment #35) what you think about maintaining the EL-5 branch too ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510736] Review Request: pycdio - A Python interface to the CD Input and Control library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510736 --- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2009-07-27 14:11:26 EDT --- Red Hat employees have no special procedures with respect to sponsorship; they need to find a sponsor from the same group as everyone else. Of course, they may simply be able to walk over and talk to a sponsor if they happen to be in the the right office, but that's no different than someone could do if they happened to be in the same general pyhsical location as, say, me. Red Hat employees do sign a different CLA than most other contributors, but as far as I know that is the only real difference. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510734 --- Comment #32 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2009-07-27 14:15:43 EDT --- Even with --with-system-libvncserver --without-filetransfer x11vnc build failed :( /home/pasha/rpmbuildroot/BUILD/x11vnc-0.9.8/x11vnc/connections.c:3161: undefined reference to `rfbUnregisterTightVNCFileTransferExtension' x11vnc-connections.o: In function `client_gone': /home/pasha/rpmbuildroot/BUILD/x11vnc-0.9.8/x11vnc/connections.c:726: undefined reference to `rfbRegisterTightVNCFileTransferExtension' I dpn't known what to do now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481066] Review Request: etoys - the Etoys image for the Squeak VM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481066 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481064] Review Request: squeak-image - the standard image file for the Squeak VM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481064 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481056] Review Request: squeak-vm - a Smalltalk interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481056 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513286] Review Request: condor-ec2-enhanced - EC2 Enhanced AMI package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513286 --- Comment #2 from Robert Rati rr...@redhat.com 2009-07-27 14:51:26 EDT --- Updated package info: Spec URL: http://rrati.fedorapeople.org/condor-ec2-enhanced.spec SRPM URL: http://rrati.fedorapeople.org/condor-ec2-enhanced-1.0-14.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513288] Review Request: condor-ec2-enhanced-hooks - Condor EC2 Enhanced hooks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513288 --- Comment #1 from Robert Rati rr...@redhat.com 2009-07-27 14:52:24 EDT --- Updated package info: Spec URL: http://rrati.fedorapeople.org/condor-ec2-enhanced-hooks.spec SRPM URL: http://rrati.fedorapeople.org/condor-ec2-enhanced-hooks-1.0-15.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513292] Review Request: condor-low-latency - Condor's Low-Latency scheduling
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513292 --- Comment #1 from Robert Rati rr...@redhat.com 2009-07-27 14:53:06 EDT --- Updated package info: Spec URL: http://rrati.fedorapeople.org/condor-low-latency.spec SRPM URL: http://rrati.fedorapeople.org/condor-low-latency-1.0-15.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513291] Review Request: condor-job-hooks - Condor Job Hooks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513291 --- Comment #1 from Robert Rati rr...@redhat.com 2009-07-27 14:52:49 EDT --- Updated package info: Spec URL: http://rrati.fedorapeople.org/condor-job-hooks.spec SRPM URL: http://rrati.fedorapeople.org/condor-job-hooks-1.0-8.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497622
--- Comment #36 from Tim Fenn f...@stanford.edu 2009-07-27 15:02:56 EDT ---
(In reply to comment #33)
(In reply to comment #32)
Package does not build:
RPM build errors:
File not found:
/builddir/build/BUILDROOT/apbs-1.1.0-5.fc11.x86_64/usr/bin/ApbsClient.pyc
File not found:
/builddir/build/BUILDROOT/apbs-1.1.0-5.fc11.x86_64/usr/bin/ApbsClient.pyo
This is due to RPM in Fedora 11 not byte compiling files in %{_bindir}.
Instead
of %exclude you could just delete the files after %install with rm -f
which
doesn't complain about possible non-existing files.
I just removed the %exclude statement and built using F11 (since I won't be
packaging this for F10 anyway).
Spec URL: http://www.stanford.edu/~fenn/packs/apbs.spec
SRPM URL: http://www.stanford.edu/~fenn/packs/apbs-1.1.0-6.fc11.src.rpm
.. but won't you be building for EPEL, if you need this for pymol?
Right... in that case, using rm -f in %install isn't enough -
brp-python-bytecompile runs after %install, so it just recreates the .pyc/.pyo
files. The other option is to rename the files so they don't have a .py
extension, but I'm not sure if that will break other tools. Could I just use a
different spec file for the F-10 and EPEL branches?
We usually don't add license files ourselves.
The package doesn't include a LGPL license file (for some reason, they included
the GPL license file with LGPL licensed code) - I'll mention this to upstream.
You're using ATLAS for ARPACK? You might want to use it for blas, too:
--with-blas=-L%{_libdir}/atlas -lf77blas -latlas
should do it.
Yes - the tools/arpack/ folder makes calls to ATLAS, even though the configure
script doesn't look for it (grrr). Added the recommended flags.
For the tools installation I suggest using a loop:
for bin in tools/manip/{psize.py,coulomb,born}
tools/mesh/{mgmesh,dxmath,mergedx2,mergedx,value,uhbd_asc2bin,smooth,dx2mol,dx2uhbd,similarity,multivalue,benchmark,analysis}
arpack/driver; do
install -p -m 755 $bin %{buildroot}%{_bindir}/apbs-`basename $bin`
done
thanks for all the pointers on this package, its been a challenge!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513896] Review Request: pcp - performance monitoring and collection service
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513896
--- Comment #2 from Eric Sandeen esand...@redhat.com 2009-07-27 15:08:41 EDT
---
Mark, a few random questions comments, more may follow. :)
What is the reason for the Provides: on the libraries? Generally RPM sorts out
library provides on its own. If there's something special here it could use a
comment.
What's the reason for all the %attr specifications in the file list? Does
make install not put the proper permissions on them? Assuming rpmdiff
shows permissions differences, there would appear to be no difference and I'd
just lose every explicit %attr set.
also:
%pre
exit 0
the above does nothing and should be removed.
We probably should just not package the static libs unless there's a real
reason for it - is there? If not, could just rm -f them in %install.
./configure can/should be replaced with %configure, although this seems to
break the build. :( I'd have to look and see what the difference is.
Lots of explicit paths can (and I think should?) be referred to w/ macros:
/usr/lib* - %{_libdir}
/usr/share/man/man3 - %{_mandir}/man3 (etc)
/usr/bin - %{_bindir}
/usr/include - %{_includedir}
In a lot of cases, it may be a lot simpler to use wildcards rather than listing
each file subdir individually. For example:
%dir /foo/bar/baz
/foo/bar/baz/*
But if 2 subpackages share files in a subdir they'd need to be explicitly
listed I guess, and only one should own the dir of course. I guess it's your
preference but wow, that is a long %files list ;)
When I build I get some odd messages:
cpio: pcp-3.0.0/src/dbpmda/src/stdout: Cannot stat: No such file or directory
cpio: pcp-3.0.0/src/dbpmda/src/gram.tab.c: Cannot stat: No such file or
directory
cpio: pcp-3.0.0/src/pmie/src/grammar.tab.c: Cannot stat: No such file or
directory
cpio: pcp-3.0.0/src/pmlc/stdout: Cannot stat: No such file or directory
cpio: pcp-3.0.0/src/pmlc/gram.tab.c: Cannot stat: No such file or directory
cpio: pcp-3.0.0/src/pmlogextract/stdout: Cannot stat: No such file or
directory
cpio: pcp-3.0.0/src/pmlogextract/gram.tab.c: Cannot stat: No such file or
directory
cpio: pcp-3.0.0/src/pmlogger/stdout: Cannot stat: No such file or directory
cpio: pcp-3.0.0/src/pmlogger/gram.tab.c: Cannot stat: No such file or directory
I think these are generated files, and the debuginfo collection step isn't able
to find them. This may mean that the debuginfo rpms are incomplete?
You might be able to simplify the README installation etc (DOCFILES) by
dropping their install from the makefiles, and just doing:
%files
%doc README COPYING FOO BAR
I'm not sure if hand-recreating what %doc does has any pitfalls or not.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497622
--- Comment #37 from Jussi Lehtola jussi.leht...@iki.fi 2009-07-27 15:16:26
EDT ---
(In reply to comment #36)
(In reply to comment #33)
(In reply to comment #32)
I just removed the %exclude statement and built using F11 (since I won't
be
packaging this for F10 anyway).
.. but won't you be building for EPEL, if you need this for pymol?
Right... in that case, using rm -f in %install isn't enough -
brp-python-bytecompile runs after %install, so it just recreates the .pyc/.pyo
files. The other option is to rename the files so they don't have a .py
extension, but I'm not sure if that will break other tools. Could I just use a
different spec file for the F-10 and EPEL branches?
Duh.
Yes, you can use a different spec file, or even better:
%if 0%{?fedora}11 || 0%{?rhel} == 4 || 0%{?rhel} == 5
%exclude %{_bindir}/*.pyc
%exclude %{_bindir}/*.pyo
%endif
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510736] Review Request: pycdio - A Python interface to the CD Input and Control library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510736 Dennis Gilmore den...@ausil.us changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|den...@ausil.us Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225913] Merge Review: irqbalance
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225913 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2009-07-27 15:22:08 EDT --- I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226510] Merge Review: udev
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #16 from Jon Ciesla l...@jcomserv.net 2009-07-27 15:24:45 EDT --- In attempting to take a look at this, I ran across: checking for USBUTILS... configure: error: Package requirements (usbutils = 0.82) were not met: Looks like the BuildRequires should be versioned. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497622
--- Comment #38 from Tim Fenn f...@stanford.edu 2009-07-27 15:29:05 EDT ---
(In reply to comment #37)
(In reply to comment #36)
(In reply to comment #33)
(In reply to comment #32)
I just removed the %exclude statement and built using F11 (since I
won't be
packaging this for F10 anyway).
.. but won't you be building for EPEL, if you need this for pymol?
Right... in that case, using rm -f in %install isn't enough -
brp-python-bytecompile runs after %install, so it just recreates the
.pyc/.pyo
files. The other option is to rename the files so they don't have a .py
extension, but I'm not sure if that will break other tools. Could I just
use a
different spec file for the F-10 and EPEL branches?
Duh.
Yes, you can use a different spec file, or even better:
%if 0%{?fedora}11 || 0%{?rhel} == 4 || 0%{?rhel} == 5
%exclude %{_bindir}/*.pyc
%exclude %{_bindir}/*.pyo
%endif
will do. I'll hold off on requesting CVS access until I hear something
regarding maloc version numbering.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512500] Review Request: multimedia-menus - Categorization for the GNOME/KDE AudioVideo/Multimedia menu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512500 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Peter Robinson pbrobin...@gmail.com 2009-07-27 15:31:46 EDT --- From a technical perspective the package looks fine so APPROVED! I don't see the rest of it as part of the review process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
