[Bug 478470] Review Request: mrpt - The Mobile Robot Programming Toolkit (MRPT)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478470 Jose Luis changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478470] Review Request: mrpt - The Mobile Robot Programming Toolkit (MRPT)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478470 --- Comment #36 from Jose Luis 2009-08-11 02:53:41 EDT --- Package Change Request == Package Name: mrpt New Branches: F-11 Owners: jlblanco Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #20 from Jussi Lehtola 2009-08-11 02:46:44 EDT --- (In reply to comment #19) > (In reply to comment #18) > > > Makefile, COPYRIGHT and README in the upstream tarball *STILL* have > > executable > > flags. Remove them from the upstream release, or remove them in the %prep > > phase. > "chmod -x"ing then in %prep is what you want. .. but if one is upstream it is better to do it there since Fedora is not the only distribution suffering from incorrect permissions. ** Your %doc line is empty, add README and COPYRIGHT to %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 Ralf Corsepius changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #19 from Ralf Corsepius 2009-08-11 02:13:38 EDT --- (In reply to comment #18) > Makefile, COPYRIGHT and README in the upstream tarball *STILL* have executable > flags. Remove them from the upstream release, or remove them in the %prep > phase. "chmod -x"ing then in %prep is what you want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #18 from Jussi Lehtola 2009-08-11 01:51:29 EDT --- As instructed in comment #6 and comment #13, please paste new SPEC & SRPM urls in the review whenever you have updated something. ** The package *STILL DOES NOT COMPILE* In file included from sys_main.c:28: sys_basher.h:37:21: error: ncurses.h: No such file or directory In file included from sys_basher.h:49, from sys_main.c:28: sys_curses.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token sys_curses.h:30: error: expected ')' before '*' token sys_curses.h:31: error: expected ')' before '*' token In file included from sys_disk.c:28: sys_basher.h:37:21: error: ncurses.h: No such file or directory In file included from sys_utils.c:28: sys_basher.h:37:21: error: ncurses.h: No such file or directory In file included from sys_basher.h:49, from sys_disk.c:28: sys_curses.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token sys_curses.h:30: error: expected ')' before '*' token sys_curses.h:31: error: expected ')' before '*' tokenIn file included from sys_basher.h:49, from sys_utils.c:28: sys_curses.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token sys_curses.h:30: error: expected ')' before '*' token sys_curses.h:31: error: expected ')' before '*' token make: *** [sys_main.o] Error 1 make: *** Waiting for unfinished jobs In file included from sys_kernel.c:28: sys_basher.h:37:21: error: ncurses.h: No such file or directory make: *** [sys_disk.o] Error 1 In file included from sys_basher.h:49, from sys_kernel.c:28: sys_curses.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token sys_curses.h:30: error: expected ')' before '*' token sys_curses.h:31: error: expected ')' before '*' token make: *** [sys_kernel.o] Error 1 make: *** [sys_utils.o] Error 1 If you need ncurses, add BuildRequires: ncurses-devel as instructed in comment #2. ** Makefile, COPYRIGHT and README in the upstream tarball *STILL* have executable flags. Remove them from the upstream release, or remove them in the %prep phase. ** You are missing the -2 release from the changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 514150] Review Request: ibus-qt - The qt support tools for ibus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514150 Huang Peng changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #7 from Huang Peng 2009-08-11 01:31:09 EDT --- Thanks Imported ibus-qt, and built it for rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515280] Review Request: gnome-colors-icon-theme - GNOME-Colors icon theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515280 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Kevin Fenzi 2009-08-11 01:16:35 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516327] Review Request: perl-latest - Use the latest Perl features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516327 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi 2009-08-11 01:15:34 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493246 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #34 from Kevin Fenzi 2009-08-11 01:14:41 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515308] Review Request: usbmuxd - Daemon for communicating with Apple's iPod Touch and iPhone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515308 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi 2009-08-11 01:13:03 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515351] Review Request: vdr-epgsearch - Powerful schedules menu replacement plugin for VDR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515351 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi 2009-08-11 01:10:12 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 514150] Review Request: ibus-qt - The qt support tools for ibus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514150 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi 2009-08-11 01:07:32 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516195] Review Request: hunspell-mos - Mossi hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516195 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi 2009-08-11 01:09:07 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 514602] Review Request: system-config-audit - an utility for editing audit configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514602 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi 2009-08-11 01:03:35 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516547] Review Request: django-south - Intelligent schema migrations for Django apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516547
Toshio Ernie Kuratomi changed:
What|Removed |Added
CC||a.bad...@gmail.com
AssignedTo|nob...@fedoraproject.org|a.bad...@gmail.com
Flag||fedora-review?
--- Comment #1 from Toshio Ernie Kuratomi 2009-08-11
01:05:12 EDT ---
GOOD:
* rpmlint is clean
* Approved license and license tag matches LICENSE file.
- No conflicting licenses found in headers of package.
- License file included in %doc
* Specfile is readable
* Source matches upstream but see below.
* No locale files
* Not a shared library
* Not relocatable
* Owns all files and directories it creates
* %clean section set corectly
* macros used consistently
* code, not content
* %doc files do not affect package runtime.
* All filenames are valid utf-8
NEEDSWORK:
* Package name doesn't fit the guidelines but there is a lot of precedent for
django plugins. Asking on the fedora-packaging list. options are:
- python-django-south
- Django-south
- Write an exception and use django-south
I like either the first or the last.
* You should add a revision to the checkout line in the Source0 comment so that
someone can get the exact revision at a later date. Something like this:
# hg clone -r 3a3140b338a4 https://bitbucket.org/andrewgodwin/south/
django-south-0.6-rc1
The idea is for the reviewer to know how to reproduce the exact tarball that
is in the srpm.
* This is a pre-release so the Release should start with "0." to avoid update
problems when 0.6 final is released. Since it's a snapshot package, it
should have some information about being a checkout encoded as well:
%global vcsdate 20090710
%global vcstag rc1-6
Release:0.1.%{vcsdate}hg%{vcstag}%{?dist}
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages
* Does not build in koji:
koji build --scratch dist-f12 django-south-0.6-1.fc11.rc1.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=1596489
Looks like you need to BuildRequire: python-setuptools-devel
In case you haven't seen them, the packaging generic Guidelines and python
Guidelines are relevant to this package:
https://fedoraproject.org/wiki/Packaging:Guidelines
https://fedoraproject.org/wiki/Packaging:Python
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512729] Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512729 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi 2009-08-11 01:00:56 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513119] Review Request: PgsLookAndFeel - Nice looking LookAndFeel for Swing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513119 Bug 513119 depends on bug 516074, which changed state. Bug 516074 Summary: Review Request: jide-oss - Swing component library built on top of Java/Swing https://bugzilla.redhat.com/show_bug.cgi?id=516074 What|Old Value |New Value Status|ON_QA |CLOSED Resolution||ERRATA --- Comment #27 from Fedora Update System 2009-08-10 23:32:09 EDT --- PgsLookAndFeel-1.1-4.20090805cvs.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/PgsLookAndFeel-1.1-4.20090805cvs.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513119] Review Request: PgsLookAndFeel - Nice looking LookAndFeel for Swing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513119 --- Comment #28 from Fedora Update System 2009-08-10 23:33:21 EDT --- PgsLookAndFeel-1.1-4.20090805cvs.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/PgsLookAndFeel-1.1-4.20090805cvs.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 514150] Review Request: ibus-qt - The qt support tools for ibus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514150 Huang Peng changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Huang Peng 2009-08-10 22:23:14 EDT --- New Package CVS Request === Package Name: ibus-qt Short Description: The qt support tools for ibus Owners: phuang Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 514150] Review Request: ibus-qt - The qt support tools for ibus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514150 --- Comment #4 from Huang Peng 2009-08-10 22:20:17 EDT --- OK. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511998] Review Request: zikula-module-menutree - Menutree allows to create multilevel, hierarchical (tree-like) menu.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511998 Paul W. Frields changed: What|Removed |Added Depends on||516667 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492091] Review Request: zikula-module-Content - Page editing module for Zikula
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492091 Paul W. Frields changed: What|Removed |Added CC||sticks...@gmail.com Depends on||516662 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513420] Review Request: whaawmp - Media Player written in pygtk that uses GStreamer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513420 Jason Tibbitts changed: What|Removed |Added Flag||fedora-review? --- Comment #11 from Jason Tibbitts 2009-08-10 19:36:07 EDT --- Setting the fedora-review flag as that seems to have been overlooked. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 514351] Review Request: xfce4-stopwatch-plugin - Stopwatch plugin for the Xfce panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514351 Jason Tibbitts changed: What|Removed |Added Flag||fedora-review? --- Comment #6 from Jason Tibbitts 2009-08-10 19:35:47 EDT --- Setting the fedora-review flag as that seems to have been overlooked. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516547] Review Request: django-south - Intelligent schema migrations for Django apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516547 Jason Tibbitts changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456582] Review Request: tex-fontools - Tools for handling fonts with LaTeX and fontinst
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456582 Jason Tibbitts changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution||NOTABUG Flag|needinfo?(gabur...@cs.umd.e | |du) | --- Comment #12 from Jason Tibbitts 2009-08-10 19:27:59 EDT --- No response; closing as promised. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507110] Review Request: openal-soft - OpenAL-Soft lib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507110 --- Comment #24 from Thomas Kowaliczek 2009-08-10 19:14:56 EDT --- i have send an mail to the fedora-devel-list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508525] Review Request: gjs - Javascript Bindings for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508525 --- Comment #19 from Owen Taylor 2009-08-10 19:02:35 EDT --- Don't know what I was looking at in pkgdb, indeed looks OK. Went ahead and filed a review request for a gnome-shell package using this package (bug 516654) - thanks for doing gjs! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516654] New: Review Request: gnome-shell - Window management and application launching for GNOME [3]
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gnome-shell - Window management and application launching for GNOME [3] https://bugzilla.redhat.com/show_bug.cgi?id=516654 Summary: Review Request: gnome-shell - Window management and application launching for GNOME [3] Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: otay...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://www.gnome.org/~otaylor/gnome-shell.spec SRPM URL: http://www.gnome.org/~otaylor/gnome-shell-2.27.0-1.src.rpm Description: GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience. (The 2.27.0 tarball packaged here is mostly intended for getting packaging started rather than as a big splashy release; it's just taken in the middle of rapid development without any formal freeze process. I think it's in reasonable shape, but there probably are some horrible bugs we don't know about yet.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507299] Review Request: network-manager-netbook - Moblin Netbook GUI for NetworkManger
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507299
--- Comment #10 from Peter Robinson 2009-08-10 18:48:37
EDT ---
> Perhaps mobile-broadband-provider-info should be added to the "BuildRequires"
> list.
It does include the package as BuildRequires. The problem is that the build of
that package removes the pkgconfig during the build process and that is what
its looking for. There is a bug filed which blocks this package in bugzilla.
> In the meantime, I did a preliminary review of the spec file and found a few
> issues/questions:
>
>
> 1) * MUST: The License field in the package spec file must match the actual
> license.
>
> License:GPLv2+
>
> but the COPYING file in the latest source RPM explicitly states "Version 3":
>
> GNU GENERAL PUBLIC LICENSE
>Version 3, 29 June 2007
Actually no its not. The COPYING file in the source package is actually a
symbolic link to /usr/share/automake-1.10/COPYING so what your seeing is likely
that file in your local file system. I've sent an email to the mailing list for
a license clarification. See here
http://mail.gnome.org/archives/networkmanager-list/2009-August/msg00084.html
> 2) * MUST: The sources used to build the package must match the upstream
> source, as provided in the spec URL. Reviewers should use md5sum for this
> task.
> If no upstream URL can be specified for this package, please see the Source
> URL
> Guidelines for how to deal with this.
>
> I think the comment and URL field in the spec should be:
>
> # git clone git://git.gnome.org/network-manager-netbook
>
> URL:http://git.gnome.org/cgit/network-manager-netbook/
Copy and paste error. Will be fixed in the next srpm.
> 3) * MUST: If a package contains library files with a suffix (e.g.
> libfoo.so.1.1), then library files that end in .so (without suffix) must go in
> a -devel package.
>
> There are library files with a suffix in the files list, but no -devel
> package.
> Should one be added?
I'll review this and update as appropriate.
> 4) * MUST: Packages containing GUI applications must include a
> %{name}.desktop
> file, and that file must be properly installed with desktop-file-install in
> the
> %install section. If you feel that your packaged GUI application does not need
> a .desktop file, you must put a comment in the spec file with your
> explanation.
>
> I believe this needs to be added to the spec file.
The gui is a applet so I don't think it needs one. I'll look further as there's
possibly a configuration gui too.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476435] Review Request: sugar-record - Recording tool for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476435 --- Comment #18 from Peter Robinson 2009-08-10 18:28:26 EDT --- A few minor issues. This should be removed: /usr/share/sugar/activities/Record.activity/camerac/camera.c The COPYING/README files are included twice: /usr/share/sugar/activities/Record.activity/COPYING /usr/share/sugar/activities/Record.activity/NEWS Also does the removal of the embedded gst stuff make the package noarch again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509445] Review Request: sblim-cmpi-rpm - CIM access to rpm and other information about installed packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509445 --- Comment #10 from Praveen K Paladugu 2009-08-10 18:23:53 EDT --- With the latest sources, had to add a patch to add libd.a among the libraries while linking. Without this there were some build failures because of the dlopen other dl function definitions missing. http://linux.us.dell.com/files/fedora/sblim-cmpi-rpm/sblim-cmpi-rpm-1.0.1-3.fc10.src.rpm http://linux.us.dell.com/files/fedora/sblim-cmpi-rpm/sblim-cmpi-rpm.spec I added all the above changes suggested. Please verify. Thank you Praveen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513754] Review Request: moblin-session - Moblin User Experience Startup Scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513754 --- Comment #7 from Peter Robinson 2009-08-10 18:00:32 EDT --- I've fixed all the above mentioned. There was an issue with the included moblin.desktop because it used an incorrect value in the file so I've updated in as a separate file and emailed the upstream author (there's no bugzilla component for it). SRPM: http://pbrobinson.fedorapeople.org/moblin-session-0.12-3.fc11.src.rpm > This package seems rather trivial; I wonder why it has not been merged with > some other core moblin stuff by upstream... Yes, I agree but I suppose a the session startup manager is a separate component no matter how small. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513150] Review Request: bios_extract - Tool to extract the different submodules of common legacy bioses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513150 --- Comment #21 from Fedora Update System 2009-08-10 17:53:03 EDT --- bios_extract-0-0.4.20090713git.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513869] Review Request: perl-Beanstalk-Client - Client class to talk to a beanstalkd server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513869 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #7 from Fedora Update System 2009-08-10 17:49:57 EDT --- perl-Beanstalk-Client-1.05-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Beanstalk-Client'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8443 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513150] Review Request: bios_extract - Tool to extract the different submodules of common legacy bioses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513150 Fedora Update System changed: What|Removed |Added Fixed In Version|0-0.4.20090713git.fc11 |0-0.4.20090713git.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469470] Review Request: mausezahn - A fast versatile packet generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469470 --- Comment #44 from Fedora Update System 2009-08-10 17:50:02 EDT --- mausezahn-0.34.9-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mausezahn'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8443 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516074] Review Request: jide-oss - Swing component library built on top of Java/Swing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516074 Fedora Update System changed: What|Removed |Added Fixed In Version|2.7.1-3.1181svn.fc11|2.7.1-3.1181svn.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516074] Review Request: jide-oss - Swing component library built on top of Java/Swing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516074 --- Comment #24 from Fedora Update System 2009-08-10 17:45:07 EDT --- jide-oss-2.7.1-3.1181svn.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #17 from Joshua Rosen 2009-08-10 17:46:30 EDT --- I've uploaded a new release to my website. Please check it out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516074] Review Request: jide-oss - Swing component library built on top of Java/Swing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516074 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||2.7.1-3.1181svn.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497192] Review Request: polkit-qt - Qt bindings for PolicyKit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497192 Fedora Update System changed: What|Removed |Added Fixed In Version|0.9.2-1.fc11|0.9.2-1.fc10 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516074] Review Request: jide-oss - Swing component library built on top of Java/Swing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516074 --- Comment #23 from Fedora Update System 2009-08-10 17:42:51 EDT --- jide-oss-2.7.1-3.1181svn.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497192] Review Request: polkit-qt - Qt bindings for PolicyKit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497192 --- Comment #8 from Fedora Update System 2009-08-10 17:45:23 EDT --- polkit-qt-0.9.2-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469470] Review Request: mausezahn - A fast versatile packet generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469470 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #43 from Fedora Update System 2009-08-10 17:39:06 EDT --- mausezahn-0.34.9-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mausezahn'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8412 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492810] Review Request: RabbIT - proxy for a faster web
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492810
--- Comment #15 from Pavel Alexeev (aka Pahan-Hubbitus)
2009-08-10 17:38:47 EDT ---
(In reply to comment #13)
I really don't understand for what you again post so much warning data
mentioned twice previously...
> TODO:
> - update to RabbIT 4
Good suggestion. Done.
> - try to contact upstream - he/she/it should use name and version as source,
> not only mainversion.
I contact them. He answer what do that, but now in vacation around 2 or 3
weeks.
> - don't own with the rabbit-user the whole package
Ok.
> - remove my name from your changelog
Really strange request... But off course ok.
> - don't use packagename in summary
Ok.
> - own %{_datadir}/%{name}/ instead of %{_datadir}/%{name}/htdocs
Ok.
> - you can use a macro in source0; %{name}3 instead of RabbIT3
Ok. But %lname, not %name.
> - make your package RPMLINT-conform:
> ~ remove class path in manifest
There problem. If I remove it, I get error on start:
# ./RabbIT
Exception in thread "main" java.lang.NoClassDefFoundError: org/xbill/DNS/Lookup
at rabbit.dns.DNSJavaHandler.setup(DNSJavaHandler.java:32)
at rabbit.proxy.HttpProxy.setupDNSHandler(HttpProxy.java:171)
at rabbit.proxy.HttpProxy.setConfig(HttpProxy.java:272)
at rabbit.proxy.HttpProxy.setConfig(HttpProxy.java:136)
at rabbit.proxy.ProxyStarter.startProxy(ProxyStarter.java:66)
at rabbit.proxy.ProxyStarter.start(ProxyStarter.java:60)
at rabbit.proxy.ProxyStarter.main(ProxyStarter.java:18)
Caused by: java.lang.ClassNotFoundException: org.xbill.DNS.Lookup
at java.net.URLClassLoader$1.run(URLClassLoader.java:217)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:205)
at java.lang.ClassLoader.loadClass(ClassLoader.java:323)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294)
at java.lang.ClassLoader.loadClass(ClassLoader.java:268)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:336)
... 7 more
and don't known what do around this :(
> ~ you can't avoid all user-messages from rpmlint (/var/run/ and so is okay
> for rabbit)
I known :)
> ~ userdel is okay
Thank you for clarification.
> ~ add a logrotate for log-files
For what if it has inner mechanism of log rotation?? Just rpmlint can't known
about this.
> ~ make your init.d-script conform
Conform to what??
> ~ check your user and your service name - you have rabbit and RabbIT -> just
> use rabbit for all
Ok, I use rabbit now for service and service file.
http://hubbitus.net.ru/rpm/Fedora11/RabbIT/RabbIT-4.0-8.fc11.src.rpm
http://hubbitus.net.ru/rpm/Fedora11/RabbIT/RabbIT.spec
Warning: this build is NOT run! Please see class-path error described before.
I'm continue investigation. Help appreciated.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513150] Review Request: bios_extract - Tool to extract the different submodules of common legacy bioses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513150 Fedora Update System changed: What|Removed |Added Fixed In Version|0-0.2.20090713git.el5 |0-0.4.20090713git.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513150] Review Request: bios_extract - Tool to extract the different submodules of common legacy bioses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513150 --- Comment #20 from Fedora Update System 2009-08-10 17:38:38 EDT --- bios_extract-0-0.4.20090713git.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516364] Review Request: xrdp - Open source remote desktop protocol (RDP) server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516364 --- Comment #3 from Itamar Reis Peixoto 2009-08-10 17:33:23 EDT --- I have fixed most of the things, except for * SourceURL / Naming - For cvs based source, please follow: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control Can you help, about how to proceed with cvs ? http://sourceforge.net/projects/xrdp/develop I don't know if with cvs I can download a specific revision like svn does with "svn export -r 250" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509658] Review Request: h5py - A Python interface to the HDF5 library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509658 Ravikiran Rajagopal changed: What|Removed |Added CC||r...@gmx.de --- Comment #3 from Ravikiran Rajagopal 2009-08-10 16:43:09 EDT --- The specfile needs to add the command line parameter --api=18 in order to use the features provided by the currently shipping version of HDF5 libraries. Also, use BuildRequires: hdf5-devel >= 1.8.2 for the same reason (though F11 currently ships 1.8.3). Also add Requires: hdf5 >= 1.8.2 for runtime. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468230] Review Request: TurboGears2 - Next generation Front-to-back web development megaframework built on Pylons
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468230 --- Comment #10 from Jan ONDREJ 2009-08-10 15:30:05 EDT --- Please, do not require python-sqlalchemy0.5 for Fedora 11. python-sqlalchemy-0.5.4 is already a part of Fedore 11. Requires: python-sqlalchemy0.5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508922] Review Request: scselinux - GUI Code for system-config-selinux, polgen, and lockdown
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508922 --- Comment #3 from Bill Nottingham 2009-08-10 15:31:38 EDT --- The description should describe what the package does, not its development history. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502693] Review Request: Elgg 1.5 - An open source social networking platform.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502693 --- Comment #6 from Louis Lagendijk 2009-08-10 15:31:37 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508922] Review Request: scselinux - GUI Code for system-config-selinux, polgen, and lockdown
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508922 --- Comment #2 from Christopher Pardy 2009-08-10 15:26:59 EDT --- Spec URL: http://www.fedorahosted.org/releases/s/y/system-config-selinux/system-config-selinux.spec SRPM URL: http://www.fedorahosted.org/releases/s/y/system-config-selinux/system-config-selinux-0.2.tar.gz Description: To better conform with the upstream the gui code that was previously in policycoreutils has been moved into it's own package and given a rewrite to use policy kit. This code implements the 2 guis, system-config-selinux and polgengui. These have in the past been implemented as a patch on fedora systems to the policycoreutils package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516343] Review Request: metadata-extractor - JPEG metadata extraction framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516343 --- Comment #10 from Andrea Musuruane 2009-08-10 15:04:07 EDT --- (In reply to comment #9) > Can you provide location for your latest specfile and SRPM? Sure. Here they are: Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/metadata-extractor.spec SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/metadata-extractor-2.3.1-2.fc10.src.rpm Changelog: * Mon Aug 10 2009 Andrea Musuruane 2.3.1-2 - Created JAR alias - Added a patch to make junit tests complete successfully -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515136] Review Request: gettext-commons - Java internationalization (i18n) library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515136 --- Comment #1 from Andrea Musuruane 2009-08-10 15:02:27 EDT --- Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/gettext-commons.spec SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/gettext-commons-0.9.6-2.fc10.src.rpm Changelog: * Sun Aug 09 2009 Andrea Musuruane 0.9.6-2 - Created JAR alias -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507804] Review Request: perl-Flickr-API - Flickr API interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507804 --- Comment #9 from Fedora Update System 2009-08-10 15:02:27 EDT --- perl-Flickr-API-1.02-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Flickr-API-1.02-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #16 from Joshua Rosen 2009-08-10 14:37:14 EDT --- Thanks for the patch to my Makefile, I'll apply it. I'm also removing ncurses from the make file. I was playing with ncurses last year but I decided that it didn't add anything so I dropped it. I'll put up a new release shortly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516364] Review Request: xrdp - Open source remote desktop protocol (RDP) server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516364
--- Comment #2 from Mamoru Tasaka 2009-08-10
14:33:56 EDT ---
Some notes:
* License
- As far as I checked the whole codes, the license tag
should be "GPLv2+ with exceptions"
* -libs
- Would you explain why you want to create -libs subpackage?
* SourceURL / Naming
- For cvs based source, please follow:
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#PreReleasePackages
* Miscs
- In comments or %changelog, please use %% instead of % to avoid
macros expansion.
- About Patch1, I would recommend to just include your new
startwm.sh as new source (because it can be seen much easier).
- For Patch0, maybe
$ sed -i -e '/\[xrdp2\]/,$d' xrdp/xrdp.ini
may be easier.
- Please fix the following rpmlint(s)
-
xrdp.i686: E: subsys-not-used /etc/rc.d/init.d/xrdp
xrdp-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/xrdp-0.5.0/keygen/keygen.c
-
* Scriptlets
- Calling /sbin/ldconfig is not needed (for -libs subpackage)
because no libraries are installed under default library search
paths (and so I wonder why -libs splitting is needed)
* Files
(If you want -libs subpackage)
- Documents like COPYING or so should belong to -libs subpackage
because -libs subpackage can be installed without main package
while main package cannot be installed without -libs subpackage
- Same for the ownership of the directory %{_libdir}/xrdp
- Please example what package should own the directory
%_datadir/xrdp
- Would you explain why you want to write "default" attribute like
%attr(0755,root,root) or %attr(0644,root,root) explicitly?
You can set these permissions at %install instead and remove
these explicit %attr if you are unsure.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458866] Review Request: xls2csv - A script that recodes a spreadsheet's charset and saves as CSV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458866 --- Comment #10 from Pavel Alexeev (aka Pahan-Hubbitus) 2009-08-10 14:32:28 EDT --- Ok, you are agai right. Readme says: "This script is free software; you can redistribute it and/or modify it under the same terms as Perl itself.", so, according to guidelines: http://fedoraproject.org/wiki/Packaging:Perl#License_tag I change License to "GPL+ or Artistic" http://hubbitus.net.ru/rpm/Fedora11/xls2csv/xls2csv-1.06-4.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #15 from Jussi Lehtola 2009-08-10 14:05:53 EDT --- Created an attachment (id=356931) --> (https://bugzilla.redhat.com/attachment.cgi?id=356931) Patch to clean up upstream make file This patch cleans up the upstream makefile by - letting there be only one compiler variable - using CFLAGS everywhere - dropping mechanical compile commands that can be handled with a general algorithm - making clean clean everything (and not care if no objects exist) - adding a handler if ncurses.h does not exist Please apply this to the upstream makefile. Also run $ chmod 644 * before making the new tarball. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468226] Review Request: python-tw-jquery - ToscaWidgets wrapping for jQuery
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468226 --- Comment #11 from Fedora Update System 2009-08-10 14:04:35 EDT --- python-tw-jquery-0.9.5-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-tw-jquery-0.9.5-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516466
--- Comment #13 from Jussi Lehtola 2009-08-10 14:00:54
EDT ---
(In reply to comment #12)
> I've changed the license from the original BSD to the new BSD. I've also fixed
> the Makefile and the spec file. My website has been updated to reflect these
> changes. Please look it over.
As I advised in comment #6, please don't attach the specs or tarballs, just
paste the relevant links to the spec & srpm. In this case:
http://www.polybus.com/sys_basher/sys_basher.spec
http://www.polybus.com/sys_basher/sys_basher-1.1.17-3.fc11.src.rpm
would have done nicely.
**
Now the license tag is again incorrect, it should be just "BSD" instead of "BSD
no advertising". Please see
http://fedoraproject.org/wiki/Licensing#Software_License_List
**
You are still missing BuildRequires, making the package not build under mock.
+ make -j4
gcc -c -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g
sys_main.c
gcc -c -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g
sys_utils.c
gcc -c -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g
sys_disk.c
gcc -c -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g
sys_kernel.c
In file included from sys_disk.c:28:
In file included from sys_utils.c:28:
sys_basher.h:37:21: error: ncurses.h: No such file or directory
sys_basher.h:37:21: error: ncurses.h: No such file or directory
In file included from sys_main.c:28:
sys_basher.h:37:21: error: ncurses.h: No such file or directory
You might want to add a clause for ncurses.h, too. Or maybe switch to using
e.g. GNU autotools to configure the build process.
**
As one can see, the build process does not use the Fedora optimization flags.
Use
make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
to fix this.
**
On a side note, I'm wondering why you have many variables for the same thing in
the Makefile. You should have only the standard variables CC and CFLAGS, and
call them in the make process. I'll attach a patch in a moment.
**
You are missing changelog entries altogether. Add entries for every change and
release you've done so far.
**
All of the tarball files (except the spec file) are still executable. Please
remove the executable flags from the files in the upstream tarball.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 Jussi Lehtola changed: What|Removed |Added Blocks|182235(FE-Legal)| --- Comment #14 from Jussi Lehtola 2009-08-10 14:01:27 EDT --- License is now BSD which is GPL compatible, dropping FE-LEGAL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468226] Review Request: python-tw-jquery - ToscaWidgets wrapping for jQuery
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468226 --- Comment #13 from Fedora Update System 2009-08-10 14:04:46 EDT --- python-tw-jquery-0.9.5-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/python-tw-jquery-0.9.5-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468226] Review Request: python-tw-jquery - ToscaWidgets wrapping for jQuery
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468226 --- Comment #12 from Fedora Update System 2009-08-10 14:04:41 EDT --- python-tw-jquery-0.9.5-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-tw-jquery-0.9.5-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515898] Review Request: imapfilter - A flexible client side mail filtering utility for IMAP servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515898 David Sommerseth changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #5 from David Sommerseth 2009-08-10 13:43:22 EDT --- (removed FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515898] Review Request: imapfilter - A flexible client side mail filtering utility for IMAP servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515898 --- Comment #4 from David Sommerseth 2009-08-10 13:42:33 EDT --- Found one issue regarding debuginfo packages, missing CFLAGS=-g during compilation. I've contacted the upstream developer to see if we can get a patch into the configure scripts which adds the needed compiler flags via CFLAGS. Awaiting feedback before I continue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468230] Review Request: TurboGears2 - Next generation Front-to-back web development megaframework built on Pylons
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468230 Bug 468230 depends on bug 476789, which changed state. Bug 476789 Summary: Review Request: python-repoze-what - Authorization for WSGI applications https://bugzilla.redhat.com/show_bug.cgi?id=476789 What|Old Value |New Value Status|ON_QA |CLOSED Resolution||ERRATA --- Comment #9 from Luke Macken 2009-08-10 13:23:49 EDT --- Sorry about that, try this: http://lmacken.fedorapeople.org/rpms/TurboGears2-2.0.1-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 479021] Review Request: python-repoze-what-plugins-sql - The repoze.what SQL plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479021 --- Comment #9 from Fedora Update System 2009-08-10 13:24:32 EDT --- python-repoze-what-plugins-sql-1.0-0.5.rc1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-repoze-what-plugins-sql-1.0-0.5.rc1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507299] Review Request: network-manager-netbook - Moblin Netbook GUI for NetworkManger
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507299
--- Comment #9 from D. Marlin 2009-08-10 13:00:34 EDT ---
This package does not yet build due to missing dependencies:
checking for NMN... configure: error: Package requirements (dbus-glib-1 >= 0.75
gtk+-2.0 gconf-2.0 gnome-keyring-1 libnm-util libnm_glib
mobile-broadband-provider-info) were not met:
No package 'mobile-broadband-provider-info' found
Perhaps mobile-broadband-provider-info should be added to the "BuildRequires"
list.
In the meantime, I did a preliminary review of the spec file and found a few
issues/questions:
1) * MUST: The License field in the package spec file must match the actual
license.
License:GPLv2+
but the COPYING file in the latest source RPM explicitly states "Version 3":
GNU GENERAL PUBLIC LICENSE
Version 3, 29 June 2007
2) * MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
I think the comment and URL field in the spec should be:
# git clone git://git.gnome.org/network-manager-netbook
URL:http://git.gnome.org/cgit/network-manager-netbook/
3) * MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
There are library files with a suffix in the files list, but no -devel package.
Should one be added?
4) * MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
I believe this needs to be added to the spec file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507110] Review Request: openal-soft - OpenAL-Soft lib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507110 --- Comment #23 from Mamoru Tasaka 2009-08-10 13:02:26 EDT --- When you rebuit this, please announce this on fedora-devel-list because numbers of packages are affected by this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509933] Review Request: chameleon - Database schema transformation tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509933 --- Comment #13 from Fedora Update System 2009-08-10 12:49:57 EDT --- chameleon-0.2-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/chameleon-0.2-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509933] Review Request: chameleon - Database schema transformation tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509933 --- Comment #12 from Fedora Update System 2009-08-10 12:49:52 EDT --- chameleon-0.2-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/chameleon-0.2-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #12 from Joshua Rosen 2009-08-10 12:46:58 EDT --- I've changed the license from the original BSD to the new BSD. I've also fixed the Makefile and the spec file. My website has been updated to reflect these changes. Please look it over. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #11 from Joshua Rosen 2009-08-10 12:45:22 EDT --- Created an attachment (id=356924) --> (https://bugzilla.redhat.com/attachment.cgi?id=356924) updated spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #10 from Joshua Rosen 2009-08-10 12:42:13 EDT --- Created an attachment (id=356921) --> (https://bugzilla.redhat.com/attachment.cgi?id=356921) source files with New BSD license -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516464] Review Request: adtool - Active Directory administration utility for Unix
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516464
--- Comment #3 from Jussi Lehtola 2009-08-10 12:25:08
EDT ---
rpmlint output is clean.
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. NEEDSWORK
- Use one of the time stamp keeping versions at
https://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8
to convert the encoding.
- You shouldn't need to run
chmod 0644 tests/test.sh
shipping executable files in %doc is OK.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
NEEDSWORK
- No license is mentioned anywhere in the source code or documents.
- GPLv2 license is attached, so the package is assumed to be under the GPL.
=> License tag must be GPL+.
* You should contact upstream and ask them to add license headers to the source
code.
https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512729] Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512729 Nicolas Chauvet (kwizart) changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Nicolas Chauvet (kwizart) 2009-08-10 12:06:14 EDT --- New Package CVS Request === Package Name: perl-IO-Async Short Description: A collection of modules that implement asynchronous filehandle IO Owners: kwizart Branches: F-11 F-10 EL-5 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512729] Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512729 --- Comment #7 from Nicolas Chauvet (kwizart) 2009-08-10 12:04:36 EDT --- Thx for the review, I will add the missing BR. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512020] Review Request: pyliblo - Python bindings for the liblo OSC library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512020 --- Comment #6 from Fedora Update System 2009-08-10 11:41:06 EDT --- pyliblo-0.7.2-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pyliblo-0.7.2-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512020] Review Request: pyliblo - Python bindings for the liblo OSC library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512020 --- Comment #5 from Fedora Update System 2009-08-10 11:41:01 EDT --- pyliblo-0.7.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/pyliblo-0.7.2-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510255] Review Request: cobertura - a Java tool for calculating the test coverage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510255 Kevin Fenzi changed: What|Removed |Added Depends on||182235(FE-Legal) --- Comment #4 from Kevin Fenzi 2009-08-10 11:31:37 EDT --- well, the license makes sense to me. If you like we can ask legal to take a quick look at it to be sure? Hopefully they can do so soon so we can get your feature moving... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493246 --- Comment #33 from Liang Suilong 2009-08-10 11:27:47 EDT --- New Package CVS Request === Package Name: shutter Short Description: Shutter is a GTK+ 2.0 screenshot application written in perl. Owners: liangsuilong Branches: F-10 F-11 devel InitialCC: liangsuilong Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493246 Liang Suilong changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516578] Review Request: hyphen-fo - Faroese hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516578 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493246 --- Comment #32 from Liang Suilong 2009-08-10 11:20:47 EDT --- I upgrade a new version shutter. Here is shutter-0.80.1 SRPM: http://liangsuilong.fedorapeople.org/shutter/shutter-0.80-5.fc11.src.rpm SPEC: http://liangsuilong.fedorapeople.org/shutter/shutter.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #9 from Jussi Lehtola 2009-08-10 11:23:56 EDT --- You can also remove the executable perms from the source files from the tarball. And your headers are lacking the license headers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515034] Review Request: nss-softokn - Cryptographic Module of NSS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515034 Elio Maldonado Batiz changed: What|Removed |Added Attachment #356396|0 |1 is obsolete|| --- Comment #16 from Elio Maldonado Batiz 2009-08-10 11:18:27 EDT --- Created an attachment (id=356903) --> (https://bugzilla.redhat.com/attachment.cgi?id=356903) New spec file This is update spec file. The same one that I have updated at http://fedorapeople.org/~emaldonado/nss-softokn/devel/nss-softokn.spec and a nwe srpm built from it is at http://fedorapeople.org/~emaldonado/nss-softokn/devel/nss-softokn-3.12.3.99.3-8.fc11.test.1.src.rpm It addresses most of the issues raised in the earlier review. Notice that: - Source3 is the script that makes the nss-softokn source tar ball out of the big nss source tar ball. - I have to save a couple of files to a temp location during build and restore them during install because now the buildroot gets removed at install whether we do it or not. (That had caused the f12 mass rebuild to fail for NSS) - I haven't implemented yet the suggestion of using Triggers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515049 --- Comment #24 from Fedora Update System 2009-08-10 11:17:55 EDT --- dvisvgm-0.8.1-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/dvisvgm-0.8.1-4.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515049 --- Comment #25 from Fedora Update System 2009-08-10 11:18:01 EDT --- dvisvgm-0.8.1-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/dvisvgm-0.8.1-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #8 from Joshua Rosen 2009-08-10 11:17:00 EDT --- I'll switch the license to New BSD so that it will be compatible with the GPL. I'll fix the Makefile and clean up the spec file. I'll let you know when I've updated my website. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515032] Review Request: nss-util - Utilities for Network Security Services (NSS) and Softoken module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515032 --- Comment #13 from Elio Maldonado Batiz 2009-08-10 10:55:32 EDT --- I have updated the contents of the URLs. Also did a scratch build and installed nss-util and nss-softokn in a virtual machine. As part of the split and nss-util (nss-util-devl actually) needs to become the owner of the /usr/includes/nss3 directory. This is fine if you are doing a clean install of Fedora 12. If someone does and update to F12 nss from F11 where nss is already there thre will be conflicts because nss was the previous owner. I had to execute rpm -ihv nss-util-*.rpm --force. Even tough a clean install of F12 is strongly recommended some users do update from F-11 to F-12 and will face those conflicts. How is changing of ownership of directories upon splits customarily handled? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 Jussi Lehtola changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #7 from Jussi Lehtola 2009-08-10 10:48:44 EDT --- (In reply to comment #3) > This is my first package. > > I generated the .spec file using rpmdev-newspec and then edited it with > Xemacs, > the tabs look fine to me. When I look at the spec in xemacs I see that Group:, URL: and License: are not aligned with the rest of the lines. As far as I can tell this is not a tab width issue since those are spaces, not tabs, in the spec file. Anyway, this is just an esthetical issue. > rpmbuild doesn't seem to work without the mkdirs, is it expecting them in > Makefile? Yes, normally makefiles have them. As you are upstream, you should add them to the sys_basher release. > My license is the original BSD. I have advertising on my sys_basher website > for > my products and services but there is none in the program or in the source > package. Yes, original BSD, i.e. 4 clause BSD is marked in Fedora as "BSD with Advertising" as you could have seen from the link in comment #2. It is *NOT* compatible with GPL. As lm_sensors is under GPLv2+, including this package in Fedora at the moment would break licensing. Blocking FE-LEGAL. > The program requires lm_sensors, is rpmbuild smart enough to figure that out > from the source code? Yes, rpm checks out everything that has been compiled dynamically and requires the relevant libraries. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #6 from Jussi Lehtola 2009-08-10 10:38:19 EDT --- You don't need to attach the spec or the source tar ball, you just need to give the new links to the spec and srpm. For example, next time you update the spec file due to some comments (remember to increase the release tag every time you update!), you could give them as e.g. http://www.polybus.com/sys_basher/sys_basher.spec http://www.polybus.com/sys_basher/sys_basher-1.1.17-2.fc11.src.rpm Of course, you would need to make them available at those addresses, first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516578] New: Review Request: hyphen-fo - Faroese hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: hyphen-fo - Faroese hyphenation rules https://bugzilla.redhat.com/show_bug.cgi?id=516578 Summary: Review Request: hyphen-fo - Faroese hyphenation rules Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: caol...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-fo.spec SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-fo-0.20040420-1.fc11.src.rpm Description: Faroese hyphenation rules -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516195] Review Request: hunspell-mos - Mossi hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516195 Caolan McNamara changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Caolan McNamara 2009-08-10 10:13:55 EDT --- New Package CVS Request === Package Name: hunspell-mos Short Description: Mossi hunspell dictionaries Owners: caolanm Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 439195] Review Request: perl-Task-Weaken - Ensure that a platform has weaken support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439195 Paul Howarth changed: What|Removed |Added CC||p...@city-fan.org --- Comment #11 from Paul Howarth 2009-08-10 09:56:06 EDT --- The license for this package is "Same terms as Perl itself", which is "GPL+ or Artistic", not "GPLv2+ or Artistic" as included in the package. Perhaps you could fix that and update to 1.03? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516148] Review Request: trac-tickettemplate-plugin - Allows for templates in trac tickets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516148 --- Comment #5 from Fedora Update System 2009-08-10 09:46:56 EDT --- trac-tickettemplate-plugin-0.5-0.1.svn6332.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/trac-tickettemplate-plugin-0.5-0.1.svn6332.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516340] Review Request: fupt - Fedora Unity Paste tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516340 Ralf Corsepius changed: What|Removed |Added CC|rc040...@freenet.de | --- Comment #16 from Ralf Corsepius 2009-08-10 09:14:32 EDT --- A master piece of a Red Hat employing letting through crap ware. Taking me off this childish review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
