[Bug 517776] Review Request: gettext-ant-tasks

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517776


Cédric OLIVIER cedric.oliv...@free.fr changed:

   What|Removed |Added

 Blocks||508351




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 508351] Review Request: josm - java openstreetmap editor

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351


Cédric OLIVIER cedric.oliv...@free.fr changed:

   What|Removed |Added

 Depends on||517776




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 508351] Review Request: josm - java openstreetmap editor

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351





--- Comment #11 from Cédric OLIVIER cedric.oliv...@free.fr  2009-08-17 
02:03:57 EDT ---
I also packaged gettext-ant-tasks at :
https://bugzilla.redhat.com/show_bug.cgi?id=517776

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 508351] Review Request: josm - java openstreetmap editor

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351





--- Comment #12 from Cédric OLIVIER cedric.oliv...@free.fr  2009-08-17 
02:06:08 EDT ---
I have updated the josm package with svn version 1788 and adding
josm-translation.

Spec URL : http://cedric.olivier.free.fr/rpms/josm-1788/release2/josm.spec
SRPM URL :
http://cedric.olivier.free.fr/rpms/josm-1788/release2/josm-0-1.1788svn.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 503136] Review Request: csync - a file synchroniser utility

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503136





--- Comment #6 from Alex Hudson (Fedora Address) fed...@alexhudson.com  
2009-08-17 02:20:17 EDT ---
Pong Jussi - I'm so sorry, I missed your previous ping! For some reason, this
bug didn't come up as needing attention from me.

I have an updated csync .spec, but I haven't addressed all the issues yet: I
should have this done in the next week or so.

Thanks for being so persistent, it's much appreciated.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517776] New: Review Request: gettext-ant-tasks

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gettext-ant-tasks

https://bugzilla.redhat.com/show_bug.cgi?id=517776

   Summary: Review Request: gettext-ant-tasks
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: cedric.oliv...@free.fr
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL :
http://cedric.olivier.free.fr/rpms/gettext-ant-tasks/gettext-ant-tasks.spec
SRPM URL :
http://cedric.olivier.free.fr/rpms/gettext-ant-tasks/gettext-ant-tasks-0.9.6-1.fc11.src.rpm

Description:
The Gettext Commons project provides Java classes for internationalization 
(i18n) through GNU gettext.

The lightweight library combines the power of the unix-style gettext tools 
with the widely used Java ResourceBundles. This makes it possible to use the 
original text instead of arbitrary property keys, which is less cumbersome 
and makes programs easier to read.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517511] Package Review: perl-Parse-ExuberantCTags - Efficiently parse exuberant ctags files

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517511


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Marcela Maslanova mmasl...@redhat.com  2009-08-17 
02:45:00 EDT ---
New Package CVS Request
===
Package Name: perl-Parse-ExuberantCTags
Short Description: Efficiently parse exuberant ctags files
Owners: mmaslano
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 483863] Review Request: g3dviewer - A 3D file/object viewer

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483863


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #8 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-17 02:41:53 
EDT ---
rpmlint output is clean.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK

MUST: The spec file for the package is legible and macros are used
consistently. ~OK
- For consistency I'd change
 %{_bindir}/g3d*
to
 %{_bindir}/%{name}
 %{_bindir}/g3d-thumbnailer
(It's better style to use %{name} consistently in %files.)

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Missing CREDITS.

MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

**

Joshua: you missed the missing file in %doc. (However, we don't ship files
related to installation such as INSTALL.)

**

The issues are minor; with these notes the package is 

APPROVED

please fix the issues before CVS import.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517517] Package Review: perl-PPIx-EditorTools - Utility methods and base class for manipulating Perl via PPI

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517517





--- Comment #2 from Marcela Maslanova mmasl...@redhat.com  2009-08-17 
02:45:30 EDT ---
Thank you very much for all your reviews in short time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517507] Package Review: perl-Locale-Msgfmt - Compile .po files to .mo files

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517507


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Marcela Maslanova mmasl...@redhat.com  2009-08-17 
02:44:20 EDT ---
New Package CVS Request
===
Package Name: perl-Locale-Msgfmt
Short Description: Compile .po files to .mo files
Owners: mmaslano
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517517] Package Review: perl-PPIx-EditorTools - Utility methods and base class for manipulating Perl via PPI

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517517


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #3 from Marcela Maslanova mmasl...@redhat.com  2009-08-17 
02:46:08 EDT ---
New Package CVS Request
===
Package Name: perl-PPIx-EditorTools
Short Description: Utility methods and base class for manipulating Perl via PPI
Owners: mmaslano
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 469931] Review Request: ipmiutil - IPMI Management Utilities

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469931


Dan Horák d...@danny.cz changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 AssignedTo|d...@danny.cz|nob...@fedoraproject.org
   Flag|fedora-review?, |
   |needinfo?(d...@danny.cz) |




--- Comment #11 from Dan Horák d...@danny.cz  2009-08-17 03:28:55 EDT ---
Andy, I am sorry, but I must step down as the reviewer. I am very busy with
other work and can't dedicate the required amount of time for this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517615] Review Request: icoutils - Utilities for extracting and converting Microsoft icon and cursor files

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517615





--- Comment #4 from Martin Gieseking martin.giesek...@uos.de  2009-08-17 
05:04:28 EDT ---
Spec URL: http://mgieseki.fedorapeople.org/icoutils/icoutils.spec
SRPM URL:
http://mgieseki.fedorapeople.org/icoutils/icoutils-0.28.0-1.fc11.src.rpm

Upstream maintainer Oskar Liljeblad updated the license to GPLv3+, adapted the
comments accordingly, and applied the ppc build patch.

koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1609039

rpmlint output is still clean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641


Andrew Colin Kissa and...@topdog.za.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||and...@topdog.za.net
 AssignedTo|nob...@fedoraproject.org|and...@topdog.za.net




--- Comment #2 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
05:29:51 EDT ---

Since doctrine requires php = 5.3.2 the requires should specify that

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641





--- Comment #3 from Christof Damian chris...@damian.net  2009-08-17 05:54:09 
EDT ---
(In reply to comment #2)
 Since doctrine requires php = 5.3.2 the requires should specify that  

Doctrine 1.1 requires 5.2.3, but this request is just for the doctrine pear
channel and doesn't require a certain php version.

The bug 517643 is for the doctrine library and specifies 5.2.3 as required.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517743


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi




--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-17 05:54:38 
EDT ---
(In reply to comment #0)
 Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec
 SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.8.8-1.fc11.src.rpm
 Description:
 PyPE (Python Programmers' Editor) was written in order to offer a
 lightweight but powerful editor for those of you who think emacs is too
 much and idle is too little. Syntax highlighting is included out of the
 box, as is multiple open documents via tabs.
 
 $ rpmlint SPECS/PyPE* SRPMS/PyPE* RPMS/noarch/PyPE*
 PyPE.noarch: E: non-executable-script
 /usr/lib/python2.6/site-packages/PyPE/plugins/parsers.py 0644 /usr/bin/python
 2 packages and 1 specfiles checked; 1 errors, 0 warnings
 
 Not sure what to do about this error - should I make the script executable or
 remove the shebang line? I'm pretty sure that script is not executed
 stand-alone.

Remove the shebang, Python libraries don't need it.

 By the way, this is my first python-package and I hope I did everything right
 :)  

A few things to correct:

- Use the safer, time stamp keeping versions of the conversion tricks from
 http://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8
and
 http://fedoraproject.org/wiki/PackagingTricks#Remove_DOS_line_endings

- Don't install manually - use setup.py to do the install. Have a look at the
sample python spec
 $ rpmdev-newspec python

- You need to own
 %{python_sitelib}/%{name}/
not
 %{python_sitelib}/%{name}/*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641





--- Comment #4 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
06:01:02 EDT ---

I do not see the point in installing a channel which may not be usable, unless
the channel provides any packages that do not require = php 5.2 3 (you do
realise that the channel will not be used exclusively by your other package,
nothing will stop a user from running pear install
pear.phpdoctrine.org/Doctrine-1.0.x)

That information should be in the spec, such that anyone intending to use the
spec for EPEL for instance will pick it up straight away that they cannot.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517743





--- Comment #2 from Sandro Mathys s...@sandro-mathys.ch  2009-08-17 06:05:03 
EDT ---
Hi Jussi, thanks for the initial review!

(In reply to comment #1)
 Remove the shebang, Python libraries don't need it.

Okay :)

 A few things to correct:
 
 - Use the safer, time stamp keeping versions of the conversion tricks from
  http://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8
 and
  http://fedoraproject.org/wiki/PackagingTricks#Remove_DOS_line_endings

Hmm...what I'm using is actually what I was told to use in another review, but
I'll look into this tricks :)

 - Don't install manually - use setup.py to do the install. Have a look at the
 sample python spec
  $ rpmdev-newspec python

Well, I did use the python spec-template. The thing is: there is no `setup.py
install` that does this thing for you and if you try to do it like that, you
only get the information that you should just copy the directory to wherever
you want to execute it from.

 - You need to own
  %{python_sitelib}/%{name}/
 not
  %{python_sitelib}/%{name}/*

Good catch!

I'll implement those changes ASAP, whenever I've got some minutes :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480724] Review Request: djbdns - A Domain Name System by D. J. Bernstein

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480724


_pjp_ pj.pan...@yahoo.co.in changed:

   What|Removed |Added

URL|http://pjp.dgplug.org/tools |http://pjp.dgplug.org/djbdn
   |/djbdns-1.05.tar.gz |s/djbdns-1.05.3.tar.gz




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480724] Review Request: djbdns - A Domain Name System by D. J. Bernstein

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480724





--- Comment #36 from _pjp_ pj.pan...@yahoo.co.in  2009-08-17 06:14:55 EDT ---
  Hi,

I'm *happy* to announce the new release of djbdns-1.05.3. Please take a look

at: http://pjp.dgplug.org/djbdns

And for package review

SPEC: http://pjp.dgplug.org/djbdns/djbdns.spec
SORC: http://pjp.dgplug.org/djbdns/djbdns-1.05.3.tar.gz
SRPM: http://pjp.dgplug.org/djbdns/djbdns-1.05.3-1.fc10.src.rpm

Thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643


Andrew Colin Kissa and...@topdog.za.net changed:

   What|Removed |Added

 CC||and...@topdog.za.net




--- Comment #1 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
06:25:05 EDT ---

This is covered by multiple licenses (LGPLv2+,BSD,MIT) your spec should reflect
that

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 508351] Review Request: josm - java openstreetmap editor

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351





--- Comment #13 from Andrea Musuruane musur...@gmail.com  2009-08-17 06:24:56 
EDT ---
* To be consistent with other distributions (Debian ATM) you should use 0.0
instead of 0 as version. This is not mandatory though.

* Release tag is still wrong. It should be 0.X.1788svn%{?dist} and not
1.1788svn%{?dist}. The first 0 indicate that this is a pre-release version. The
X is an incremented number (start at 1) you should bump at *each* new release.
1788svn is the svn version of the checkout you used.

* The version-release couple in the changelog is not consistent (0-1788svn)
with the one declared at the beginning of the spec file. Always run rpmlint on
the rpm produced by rpmbuild. Errors like this one can be easily caught in this
way.

* All patches should have an upstream bug link or comment
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

In general, it is a good practise to state what a patch does.

* Description can be improved. The following is from the Debian package:
JOSM is an editor for OpenStreetMap (OSM) written in Java.
The current version supports stand alone GPX tracks, GPX track data
from OSM database and existing nodes, line segments and metadata tags
from the OSM database.

OpenStreetMap is a project aimed squarely at creating and providing
free geographic data such as street maps to anyone who wants them. 
The project was started because most maps you think of as free actually
have legal or technical restrictions on their use, holding back people
from using them in creative, productive or unexpected ways.

* Adapt this Debian patch not to include the dependencies into the target jar
file
http://patch-tracking.debian.net/patch/series/view/josm/0.0.svn1529-1/10_build

* After that add gettext-commons and metadata-extractor to Requires.

* Please remove junk from the SPEC file. Like:
#find . -name 'jfcunit.jar' -exec rm -f '{}' \;
#find . -name 'josm-translation.jar' -exec rm -f '{}' \;
#find . -name 'metadata-extractor-2.3.1-nosun.jar' -exec rm -f '{}' \;

* I have some doubt about the following:
install -p -m 644 dist/%{name}-custom.jar
$RPM_BUILD_ROOT%{_javadir}/%{name}-%{version}.jar

%{name}-%{version}.jar will be josm-0 for a long time. I wonder if you should
call it like upstream josm-snapshot-svn_version. Maybe some more experienced
java packager should help here :)

* You should add an alias for josm.jar and use it to run the program without
having to edit run script at each release.

* Desktop file category you use is not right. Network is used by a Network
application such as a web browser:

http://standards.freedesktop.org/menu-spec/latest/apa.html

You should use Categories=Education;Science;Geoscience;

* You should also add a comment line in the desktop file, like:
Comment=Editor for OpenStreetMap.org

This is not mandatory but it could help the final user.

* A man page is available from Debain. Please include it:
http://patch-tracking.debian.net/patch/debianonly/view/josm/0.0.svn1529-1

* In the generate-tarball script, please:
- clean up temporary directories at the end of the script.
- you could reuse the same tarball in more then one Fedora release therefore do
not use Fedora tags in the filename. Call it something like
josm-0.0.svn.tar.gz. You can also generate the filename based on
$JOSM_SVN_TAG. This means you can drop the $NAME_VERSION and $RELEASE
variables.
- are you sure plugins are needed? Debian do not check them out.
- you could use svn export and not remove .svn directories later.
- instead of creating a i18n directory and moving into it, you could do it all
in one line, specifying i18n as the destination directory instead of the
current directory .. The same would apply to plugins if they are required.
- do not bother to remove macosx directory. Moreover, it can be useful. It has
an .icns file with icons at different resolutions. These can be used instead of
a single 128x128 icon. The libicns-utils can be used to extract them.
- IMHO it would be better to get rid of src/org/apache in the %prep section of
the SPEC file.

* Add the following files in %doc:
Contribution gpl-2.0.txt

gpl-2.0.txt is required because of the text of the license must be included in
%doc:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641





--- Comment #5 from Christof Damian chris...@damian.net  2009-08-17 06:28:49 
EDT ---
But the channel is usable by anyone, just not the Doctrine 1.1 package.

If any more packages get added to the doctrine channel in the future which
don't require 5.2.3 I would have to change the minimum again, this doesn't make
sense. Or once Doctrine 2.0 is released I would have to change it to 5.3, which
is even worse.

But the main thing is: this channel doesn't require 5.2.3, Doctrine does.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517183] Review Request: mipv6-daemon - IPv6 Mobility Daemon

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517183





--- Comment #5 from Thomas Graf tg...@redhat.com  2009-08-17 06:33:10 EDT ---
I've integrated all your recommendations and replaced the spec file and srpm
with new versions.

I've also included an example /etc/mip6d.conf and /etc/sysconfig/mip6d and
fixed the reload init script target.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641





--- Comment #6 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
06:34:22 EDT ---

That's why am asking you if the channel provides other packages apart from
doctrine if it does then fine, if it is just dedicated to doctrine then you
have to enforce the checking.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641





--- Comment #7 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
06:37:00 EDT ---

As far as i can tell this channel is dedicated only to doctrine

pear list-all -c pear.phpdoctrine.org
All packages [Channel pear.phpdoctrine.org]:

Package   Latest Local
pear.phpdoctrine.org/Doctrine 1.1.3PHP Doctrine ORM

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641





--- Comment #8 from Christof Damian chris...@damian.net  2009-08-17 06:41:40 
EDT ---
At the moment it is. And at the moment it is mainly for Doctrine 1.1, but it is
not going to stay this way. 

And it doesn't matter, because the channel doesn't require php 5.2.3.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641


Andrew Colin Kissa and...@topdog.za.net changed:

   What|Removed |Added

 AssignedTo|and...@topdog.za.net|nob...@fedoraproject.org




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517641


Andrew Colin Kissa and...@topdog.za.net changed:

   What|Removed |Added

 Status|ASSIGNED|NEW




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #2 from Christof Damian chris...@damian.net  2009-08-17 06:51:38 
EDT ---
(In reply to comment #1)
 This is covered by multiple licenses (LGPLv2+,BSD,MIT) your spec should 
 reflect
 that  

You are right, I didn't see that. I uploaded new versions:

Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec
SRPM URL:
http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-2.fc11.src.rpm

I set it to: LGPLv2 and MIT and BSD. I couldn't find any reference to
LGPLv2+, but maybe I missed it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #3 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
06:56:31 EDT ---

A GPL or LGPL licensed package that lacks any statement of what version that
it's licensed under in the source code/program output/accompanying docs is
technically licensed under *any* version of the GPL or LGPL, not just the
version in whatever COPYING file they include. Note that this is LGPLv2+, not
LGPL+, because version 2 was the first version of LGPL. 

https://fedoraproject.org/wiki/Licensing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476829] Review Request: foomatic-db - Database of printers and printer drivers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476829





--- Comment #8 from Dan Horák d...@danny.cz  2009-08-17 07:01:14 EDT ---
I am back in work from vacations, so the review continues.

I have still found few issues:
- you should have the license as GPLv2+ and MIT for the ppd subpackage
because at least PPDs for Brother, OKI and SHARP are licensed under GPLv2+
- add the COPYING file from foomatic-db-20090702 as %doc for the main package
- the question is who should own the /usr/share/foomatic/db/sources directory,
because when only the ppds subpackage is installed then this dir (and all
upper dirs) will be unowned. If the ppds subpackage can be installed
independently then creating foomatic-db-filesystem subpackage (containing the
empty /usr/share/foomatic/db structure) looks like an option to me.

The rest looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517822] New: Review Request: hyphen-mr - Marathi hyphenation rules

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: hyphen-mr - Marathi hyphenation rules

https://bugzilla.redhat.com/show_bug.cgi?id=517822

   Summary: Review Request: hyphen-mr - Marathi hyphenation rules
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://paragn.fedorapeople.org/hyphen-mr.spec   
SRPM URL: http://paragn.fedorapeople.org/hyphen-mr-0.20090813-1.fc11.src.rpm 
Description:  Marathi hyphenation rules.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517821] New: Review Request: hyphen-bn - Bengali hyphenation rules

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: hyphen-bn - Bengali hyphenation rules

https://bugzilla.redhat.com/show_bug.cgi?id=517821

   Summary: Review Request: hyphen-bn - Bengali hyphenation rules
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://paragn.fedorapeople.org/hyphen-bn.spec
SRPM URL: http://paragn.fedorapeople.org/hyphen-bn-0.20090813-1.fc11.src.rpm
Description: Bengali hyphenation rules

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #4 from Christof Damian chris...@damian.net  2009-08-17 07:22:55 
EDT ---
The LICENSE file contains: GNU LESSER GENERAL PUBLIC LICENSE Version 2.1,
February 1999 

It doesn't state or higher as far as I can see.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #5 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
07:25:50 EDT ---
Just read comment #3

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480724] Review Request: djbdns - A Domain Name System by D. J. Bernstein

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480724





--- Comment #37 from Dan Peterson dpi...@gmail.com  2009-08-17 07:31:09 EDT 
---
Please change the name. :(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517643





--- Comment #6 from Christof Damian chris...@damian.net  2009-08-17 07:39:52 
EDT ---
(In reply to comment #5)
 Just read comment #3  

OK, changed to LGPLv2+ :

Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec
SRPM URL:
http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-3.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517416] Review Request: awl - Andrew's Web Libraries - PHP Utility Libraries

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517416


Andrew Colin Kissa and...@topdog.za.net changed:

   What|Removed |Added

 CC||and...@topdog.za.net




--- Comment #1 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
07:41:38 EDT ---

There is an issue with the file placement, Non PEAR classes should be placed in
%{_datadir}/php

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476829] Review Request: foomatic-db - Database of printers and printer drivers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476829





--- Comment #9 from Tim Waugh twa...@redhat.com  2009-08-17 07:53:53 EDT ---
Spec URL: http://twaugh.fedorapeople.org/foomatic-db/foomatic-db.spec
SRPM URL:
http://twaugh.fedorapeople.org/foomatic-db/foomatic-db-4.0-3.20090702.fc11.src.rpm

* Mon Aug 17 2009 Tim Waugh twa...@redhat.com 4.0-3.20090702
- License for ppds sub-package should include GPLv2+.
- Ship COPYING file in main package.
- Added filesystem sub-package for directory ownership.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476829] Review Request: foomatic-db - Database of printers and printer drivers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476829


Dan Horák d...@danny.cz changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #10 from Dan Horák d...@danny.cz  2009-08-17 08:21:25 EDT ---
All issues are fixed, this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476829] Review Request: foomatic-db - Database of printers and printer drivers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476829





--- Comment #11 from Tim Waugh twa...@redhat.com  2009-08-17 08:31:03 EDT ---
Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476829] Review Request: foomatic-db - Database of printers and printer drivers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476829





--- Comment #13 from Tim Waugh twa...@redhat.com  2009-08-17 08:33:13 EDT ---
New Package CVS Request
===
Package Name: foomatic-db
Short Description: Database of printers and printer drivers
Owners: twaugh
Branches: devel
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476829] Review Request: foomatic-db - Database of printers and printer drivers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476829


Tim Waugh twa...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #12 from Tim Waugh twa...@redhat.com  2009-08-17 08:32:09 EDT ---
New Package CVS Request
===
Package Name: foomatic-db
Short Description: Database of printers and printer drivers
Owners: twa...@redhat.com
Branches: devel
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517520] Review Request: easymock - Easy mock objects

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517520





--- Comment #2 from Alexander Kurtakov akurt...@redhat.com  2009-08-17 
09:25:47 EDT ---
(In reply to comment #1)
 Thanks for the submission.  Everything looks pretty good.  See comments below.
 
 - it would be nice to use %{buildroot} instead of $RPM_BUILD_ROOT but it's not
 a blocker
Fixed.

 - my generated source tarball has a different md5sum but the contents are the
 same (likely timestamp differences)
I think so.

 - will we build with maven once it's updated?
Yes, once maven is updated to new enough version and all the needed plugins are
packaged.

 - other than the non-conffile-in-etc for the maven pom, everything is rpmlint
 clean
 - what provides %add_to_maven_depmap?  I don't see it doing much in my log.  
 Do
 we need a BR on maven?
It's provided by jpackage-utils so we don't need a BR on maven.

 - please provide a link to the origin of the OSGi manifest
Done.

 
 It builds fine locally for me.  

New links:
Spec URL: http://akurtakov.fedorapeople.org/easymock.spec
SRPM URL: http://akurtakov.fedorapeople.org/easymock-2.5-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 489424] Review Request: editarea - EditArea is a free javascript editor for source code

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489424





--- Comment #5 from Colin Coe colin@gmail.com  2009-08-17 09:28:41 EDT ---
OK, point taken.

Spec file fixed and RPM rebased to v0.8.1.1

http://members.iinet.net.au/~coec/editarea.spec
http://members.iinet.net.au/~coec/editarea-0.8.1.1-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517849] New: Review Request: mpiwrappers - Environment module wrappers for MPI packages in RHEL

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mpiwrappers - Environment module wrappers for MPI 
packages in RHEL

https://bugzilla.redhat.com/show_bug.cgi?id=517849

   Summary: Review Request: mpiwrappers - Environment module
wrappers for MPI packages in RHEL
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jussi.leht...@iki.fi
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/mpiwrappers.spec

SRPM URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/mpiwrappers-1-1.fc11.src.rpm

Description:
This package provides a compatibility layer with the use of environment modules
for the MPI compilers in RHEL to ease packaging of MPI software in Fedora EPEL.

**

See
http://www.fedoraproject.org/wiki/PackagingDrafts/MPI#EPEL

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517849] Review Request: mpiwrappers - Environment module wrappers for MPI packages in RHEL

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517849


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||dledf...@redhat.com




--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-17 09:43:00 
EDT ---
CC Doug, you might want to take a look at this.

**

I'm not totally sure if support for mvapich{,2} should be added, too. As they
aren't available on all architectures building packages against them would
require the use of conditionals in spec files using them. Besides, I don't
think rpm on RHEL 4 and 5 can't cope with subpackages that don't have the same
build arch as the main package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517338] Review Request: irssi-xmpp is an irssi plugin to connect to the Jabber network

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517338





--- Comment #3 from Nikola Pajkovsky npajk...@redhat.com  2009-08-17 09:40:31 
EDT ---
SPEC: http://www.package-review.xf.cz/irssi-xmpp.spec
SRPM: http://package-review.xf.cz/irssi-xmpp-0.50-1.fc12.src.rpm

Now without patch. 
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1609791

I hope it's enough.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517520] Review Request: easymock - Easy mock objects

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517520


Andrew Overholt overh...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Andrew Overholt overh...@redhat.com  2009-08-17 09:41:43 
EDT ---
Thanks, approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517851] New: Review Request: beacon - WYSIWYG editor for docbook xml

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: beacon - WYSIWYG editor for docbook xml

https://bugzilla.redhat.com/show_bug.cgi?id=517851

   Summary: Review Request: beacon - WYSIWYG editor for docbook
xml
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: skoma...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SPEC: http://rakesh.fedorapeople.org/spec/beacon.spec
SRPM: http://rakesh.fedorapeople.org/srpm/beacon-0.5-1.fc11.src.rpm

Description:
WYSIWYG editor for docbook xml

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517851] Review Request: beacon - WYSIWYG editor for docbook xml

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517851


Satya Komaragiri skoma...@redhat.com changed:

   What|Removed |Added

 CC||kw...@redhat.com,
   ||loupgaroubl...@gmail.com
 Blocks||177841(FE-NEEDSPONSOR)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517338] Review Request: irssi-xmpp is an irssi plugin to connect to the Jabber network

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517338


Andrew Colin Kissa and...@topdog.za.net changed:

   What|Removed |Added

 CC||and...@topdog.za.net




--- Comment #4 from Andrew Colin Kissa and...@topdog.za.net  2009-08-17 
10:01:09 EDT ---

You need to increment you spec file version when ever you make a change to it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517520] Review Request: easymock - Easy mock objects

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517520


Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Alexander Kurtakov akurt...@redhat.com  2009-08-17 
10:03:50 EDT ---
New Package CVS Request
===
Package Name: easymock
Short Description: Easy mock objects
Owners: akurtakov
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517338] Review Request: irssi-xmpp is an irssi plugin to connect to the Jabber network

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517338





--- Comment #5 from Nikola Pajkovsky npajk...@redhat.com  2009-08-17 10:11:46 
EDT ---
I thought that's not needed in initial build. Because there will be written
only my mistakes when I tried to make new package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517858] New: Review Request: RackTables - RackTables is a datacenter asset management system

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: RackTables - RackTables is a datacenter asset 
management system

https://bugzilla.redhat.com/show_bug.cgi?id=517858

   Summary: Review Request: RackTables - RackTables is a
datacenter asset management system
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: colin@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://members.iinet.net.au/~coec/RackTables.spec
SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-1.src.rpm
Description: RackTables is a datacenter asset management system.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517859] New: Review Request: vmpsd - vmpsd is a GPL implementation of Cisco Systems' VMPS

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: vmpsd - vmpsd is a GPL implementation of Cisco 
Systems' VMPS

https://bugzilla.redhat.com/show_bug.cgi?id=517859

   Summary: Review Request: vmpsd - vmpsd is a GPL implementation
of Cisco Systems' VMPS
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: colin@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://members.iinet.net.au/~coec/vmpsd.spec
SRPM URL: http://members.iinet.net.au/~coec/vmpsd-1.4.01-1.src.rpm
Description: 
VMPS (VLAN Management Policy Server) is a way of assigning switch ports to 
specific VLANs based on MAC address of connecting device. OpenVMPS is a GPL 
implementation of VMPS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 463808] Review Request: robotfindskitten - A game/zen simulation.

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463808


Will Woods wwo...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #10 from Will Woods wwo...@redhat.com  2009-08-17 10:48:16 EDT ---
Oh oops - this bug should have been closed when the package got pushed live,
but I think I forgot to add the bug ID to the update request. 

Anyway, package is now live in F10/F11 updates and Rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517851] Review Request: beacon - WYSIWYG editor for docbook xml

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517851


Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lkund...@v3.sk
 AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk




--- Comment #1 from Lubomir Rintel lkund...@v3.sk  2009-08-17 11:19:17 EDT ---
Taking this.

Satya: I'm wondering if you did any informal package reviews. In case you
didn't it might be a good idea to do a couple of them, so that you can
demonstrate that you're familiar with packaging guidelines in order to get
sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 502689] Review Request: mingw32-cppunit - MinGW Windows C++ unit testing framework

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502689


Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |mingw32-cppunit - C++ unit  |mingw32-cppunit - MinGW
   |testing framework   |Windows C++ unit testing
   ||framework




--- Comment #5 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-08-17 
11:18:52 EDT ---
Spec URL:
http://kwizart.fedorapeople.org/review/mingw32-cppunit.spec
SRPM URL:
http://kwizart.fedorapeople.org/review/mingw32-cppunit-1.12.1-2.fc11.src.rpm
Description: MinGW Windows C++ unit testing framework

Changelog
- Fix BR mingw32-gcc-c++
- Update description
- Disable duplicated docs with native package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 488995] Review Request: pidgin-tlen - Tlen IM Pidgin plugin

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488995


Dan Horák d...@danny.cz changed:

   What|Removed |Added

 Blocks||504493
 Depends on|504493  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490140] Review Request: zsync - Client-side implementation of the rsync algorithm

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490140


Dan Horák d...@danny.cz changed:

   What|Removed |Added

 Blocks||504493
 Depends on|504493  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 516340] Review Request: fupt - Fedora Unity Paste tool

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516340





--- Comment #21 from Toshio Ernie Kuratomi a.bad...@gmail.com  2009-08-17 
11:35:38 EDT ---
Fix for searching is in the packagedb devel branch but we're in the middle of
some extensive changes right now.  So it may be awhile before it's deployed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 516874] Review Request: eqntott - Generates truth tables from Boolean equations

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516874





--- Comment #5 from Shakthi Kannan shakthim...@gmail.com  2009-08-17 11:38:40 
EDT ---
I have now kept only README and ChangeLog in the %doc section.

SPEC URL: http://shakthimaan.fedorapeople.org/SPECS/eqntott.spec
SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/eqntott-9.0-2.fc11.src.rpm

Successful Koji builds for dist-f10, dist-f11:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1610099
http://koji.fedoraproject.org/koji/taskinfo?taskID=1610109

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517851] Review Request: beacon - WYSIWYG editor for docbook xml

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517851





--- Comment #2 from Yaakov Nemoy loupgaroubl...@gmail.com  2009-08-17 
11:53:53 EDT ---
Satya: as your GSoC mentor, if you do some reviews informally, and can get
sponsored as a packager before the program is over, i can definitely take that
into account as part of your evaluation. Let me know if you have any questions
about this process.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517366] Review Request: emacs-haskell-mode - Haskell editing mode for Emacs

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517366





--- Comment #6 from Arun SAG saga...@gmail.com  2009-08-17 12:09:49 EDT ---
(In reply to comment #5)
 #08 The %changelog entry should be 2.4-3.20090815cvs. Please change that.
 
 #09 If you are using a cvs snapshot, why are the sources still using
 emacs-haskell-2.4.tar.gz?
 
 #06 Please remove control characters in haskell-site-file.el (^L), and check
 for the same in other files.
 
 This still exists in the .src.rpm!  

SPEC File: http://sagarun.fedorapeople.org/SPECS/emacs-haskell-mode.spec

SRPM :
http://sagarun.fedorapeople.org/SRPMS/emacs-haskell-mode-2.4-5.20090815cvs.fc11.src.rpm

Link to koji builds:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1610169 -Fedora 10

http://koji.fedoraproject.org/koji/taskinfo?taskID=1610177 -Fedora 11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516971





--- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-08-17 
12:29:17 EDT ---
For -2:

* Timestamps
  - Forgot to mention, however when using install or
cp commands, add -p option to keep timestamps on
installed files:
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

* Dependency/pkgconfig file
  - And please address the below:
(In reply to comment #2)
   - For example installed /usr/include/tcrdb.h contains:
 ---
 30  #include tcutil.h
 31  #include tcadb.h
 ---
 so at least tokyotyrant-devel should have Requires: tokyocabinet-devel.
 And tokyotyrant.pc should have Requires: tokyocabinet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 516717] Review Request: viewnior - Elegant Image Viewer

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516717





--- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-08-17 
12:48:17 EDT ---
Disabling some option on configure is allowed (however
the reason should be commented on the spec file so that
other people can find the reason easily)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=244192


John (J5) Palmieri jo...@redhat.com changed:

   What|Removed |Added

 CC||jo...@redhat.com




--- Comment #37 from John (J5) Palmieri jo...@redhat.com  2009-08-17 13:43:44 
EDT ---
Ping.  I would really like to see this packaged.  Right now I install by hand
but it tends to stop working when eclipse is upgraded.  Any status on getting
this in Fedora?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=244192





--- Comment #38 from Jason Tibbitts ti...@math.uh.edu  2009-08-17 13:53:25 
EDT ---
The submitter seems to have gone away and this ticket should probably be
closed.  Perhaps someone else wants to submit it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517507] Package Review: perl-Locale-Msgfmt - Compile .po files to .mo files

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517507


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #3 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:16:50 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513754] Review Request: moblin-session - Moblin User Experience Startup Scripts

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513754


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #11 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:18:14 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517517] Package Review: perl-PPIx-EditorTools - Utility methods and base class for manipulating Perl via PPI

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517517


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #4 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:15:01 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514928] Review Request: rubygem-fastercsv - FasterCSV is CSV, but faster, smaller and cleaner

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514928


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #10 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:19:48 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517520] Review Request: easymock - Easy mock objects

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517520





--- Comment #5 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:24:17 EDT ---
This package was already imported in bug 500257 as a 'pre-review' for the java
update. 
Is this a continuation and full review of it? Can you coordinate with the owner
there?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476829] Review Request: foomatic-db - Database of printers and printer drivers

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476829


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #14 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:26:58 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 508922] Review Request: system-config-selinux - GUI Code for system-config-selinux, polgen, and lockdown

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508922


Christopher Pardy chris.pa...@gmail.com changed:

   What|Removed |Added

 CC||chris.pa...@gmail.com




--- Comment #7 from Christopher Pardy chris.pa...@gmail.com  2009-08-17 
14:27:26 EDT ---
My RedHat email was deactivated, I'm adding my alternate email as cc.

Spec URL:
http://www.fedorahosted.org/releases/s/y/system-config-selinux/system-config-selinux.spec

SRPM URL:
http://www.fedorahosted.org/releases/s/y/system-config-selinux/system-config-selinux-0.2-2.fc11.src.rpm

Description: system-config-selinux provides the graphical tools
system-config-selinux and selinux-polgen for managing SELinux systems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517511] Package Review: perl-Parse-ExuberantCTags - Efficiently parse exuberant ctags files

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517511


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #3 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:30:10 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513954] Review Request: HTML_Template_PHPLIB - PHP template system based on preg_*

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513954


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #9 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:26:10 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517412] Review Request: django-profile - Django pluggable user profile zone

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517412


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #10 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:27:52 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517409] Review Request: django-authority - A Django app for generic per-object permissions and custom permission checks

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517409


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Kevin Fenzi ke...@tummy.com  2009-08-17 14:28:48 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513754] Review Request: moblin-session - Moblin User Experience Startup Scripts

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513754


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #12 from Peter Robinson pbrobin...@gmail.com  2009-08-17 14:48:30 
EDT ---
Built in koji.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517183] Review Request: mipv6-daemon - IPv6 Mobility Daemon

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517183





--- Comment #6 from Jarod Wilson jwil...@redhat.com  2009-08-17 14:51:44 EDT 
---
(In reply to comment #4)
 The different config files are necessary because mip6d only supports a few
 options to be set via command arguments, that's the reason for adding the 
 check
 for sysconfig to allow passing on arguments to mip6d directly. An empty
 mip6d.conf is what should be done if the node is a client node which should be
 the default.

Ah, okay, I was assuming there was only one config file, and it was just
referenced with different names and paths, having both /etc/mip6d.conf and
/etc/sysconfig/mip6d is fine too, so long as they're both referenced in the
spec and properly used in the initscript. About to look over the updated
package in a moment...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513954] Review Request: HTML_Template_PHPLIB - PHP template system based on preg_*

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513954





--- Comment #12 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 15:19:22 EDT ---
php-pear-HTML_Template_PHPLIB-1.4.0-2.fc11 has been submitted as an update for
Fedora 11.
http://admin.fedoraproject.org/updates/php-pear-HTML_Template_PHPLIB-1.4.0-2.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513954] Review Request: HTML_Template_PHPLIB - PHP template system based on preg_*

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513954





--- Comment #11 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 15:19:18 EDT ---
php-pear-HTML_Template_PHPLIB-1.4.0-2.el5 has been submitted as an update for
Fedora EPEL 5.
http://admin.fedoraproject.org/updates/php-pear-HTML_Template_PHPLIB-1.4.0-2.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513954] Review Request: HTML_Template_PHPLIB - PHP template system based on preg_*

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513954





--- Comment #10 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 15:19:13 EDT ---
php-pear-HTML_Template_PHPLIB-1.4.0-2.fc10 has been submitted as an update for
Fedora 10.
http://admin.fedoraproject.org/updates/php-pear-HTML_Template_PHPLIB-1.4.0-2.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513636] Review Request: php-layers-menu - Hierarchical PHP based DHTML menu system

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513636





--- Comment #12 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 15:22:26 EDT ---
php-layers-menu-3.2.0-0.2.rc.el5 has been submitted as an update for Fedora
EPEL 5.
http://admin.fedoraproject.org/updates/php-layers-menu-3.2.0-0.2.rc.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513636] Review Request: php-layers-menu - Hierarchical PHP based DHTML menu system

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513636





--- Comment #13 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 15:22:31 EDT ---
php-layers-menu-3.2.0-0.2.rc.fc11 has been submitted as an update for Fedora
11.
http://admin.fedoraproject.org/updates/php-layers-menu-3.2.0-0.2.rc.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513636] Review Request: php-layers-menu - Hierarchical PHP based DHTML menu system

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513636





--- Comment #11 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 15:22:20 EDT ---
php-layers-menu-3.2.0-0.2.rc.fc10 has been submitted as an update for Fedora
10.
http://admin.fedoraproject.org/updates/php-layers-menu-3.2.0-0.2.rc.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517520] Review Request: easymock - Easy mock objects

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517520


Fernando Nasser fnas...@redhat.com changed:

   What|Removed |Added

 CC||fnas...@redhat.com




--- Comment #6 from Fernando Nasser fnas...@redhat.com  2009-08-17 15:22:23 
EDT ---
Just rename to easymock2 and avoid conflicts with the unversioned easymock
please

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 500248] Pre-Review Request: plexus-cli - Command Line Interface facilitator for Plexus

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500248


Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 CC||akurt...@redhat.com




--- Comment #10 from Alexander Kurtakov akurt...@redhat.com  2009-08-17 
15:28:20 EDT ---
(In reply to comment #9)
 As with 500252, I'd like to see a fixed SRPM with the proper license tag 
 before
 letting this go forward.  
Spot,
Do we need to put the license headers as a patch or we can just add a comment
pointing to the jira issue for clarification?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 500248] Pre-Review Request: plexus-cli - Command Line Interface facilitator for Plexus

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500248





--- Comment #11 from Tom spot Callaway tcall...@redhat.com  2009-08-17 
15:34:43 EDT ---
Just make a new SRPM where the source files are properly licensed, please.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=244192





--- Comment #39 from rob rob.my...@gtri.gatech.edu  2009-08-17 15:49:17 EDT 
---
(In reply to comment #37)
 Any status on getting this in Fedora?

I will take a look at it for F11/rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 497833] Review Request: tuna - Application tuning GUI command line utility

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497833


Arnaldo Carvalho de Melo a...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(a...@redhat.com)  |




--- Comment #8 from Arnaldo Carvalho de Melo a...@redhat.com  2009-08-17 
15:49:02 EDT ---
What is the problem with python-matplotlib being explicitely required? The
oscilloscope uses it.

fixed the -p and msgfmt buildreq issues, new files at:

http://fedorapeople.org/~acme/tuna/tuna-0.9-2.fc11.src.rpm
http://fedorapeople.org/~acme/tuna/tuna.spec
http://userweb.kernel.org/~acme/tuna/tuna-0.9.tar.bz2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517409] Review Request: django-authority - A Django app for generic per-object permissions and custom permission checks

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517409





--- Comment #10 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 15:58:31 EDT ---
django-authority-0.3-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/django-authority-0.3-2.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517409] Review Request: django-authority - A Django app for generic per-object permissions and custom permission checks

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517409





--- Comment #9 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 15:58:26 EDT ---
django-authority-0.3-2.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/django-authority-0.3-2.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514928] Review Request: rubygem-fastercsv - FasterCSV is CSV, but faster, smaller and cleaner

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514928





--- Comment #11 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 16:09:05 EDT ---
rubygem-fastercsv-1.5.0-2.el5 has been submitted as an update for Fedora EPEL
5.
http://admin.fedoraproject.org/updates/rubygem-fastercsv-1.5.0-2.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514928] Review Request: rubygem-fastercsv - FasterCSV is CSV, but faster, smaller and cleaner

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514928





--- Comment #12 from Fedora Update System upda...@fedoraproject.org  
2009-08-17 16:09:11 EDT ---
rubygem-fastercsv-1.5.0-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/rubygem-fastercsv-1.5.0-2.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517183] Review Request: mipv6-daemon - IPv6 Mobility Daemon

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517183





--- Comment #7 from Jarod Wilson jwil...@redhat.com  2009-08-17 16:13:09 EDT 
---
Okay, per https://fedoraproject.org/wiki/Packaging/ReviewGuidelines ...

* MUST: rpmlint -- only 1 warning, can be ignored
$ rpmlint mipv6-daemon*
mipv6-daemon.x86_64: W: incoherent-init-script-name mip6d ('mipv6-daemon',
'mipv6-daemond')
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

* MUST: package name -- looks fine. typically, it should match the tarball
name, but the -umip portion appears to be simply designating this as the usagi
implementation of mobile ipv6. Perhaps it would be worth noting this in the
%description field though, just so its clear. (though if this is the *only*
implementation, then its sort of implied, I guess).

* MUST: spec name matches -- ok

* MUST: package meets packaging guidelines -- ok

* MUST: license -- GPLv2, ok

* MUST: license matches source -- ok

* MUST: included license text installed w/pkg -- ok

* MUST: spec in American English -- ok

* MUST: spec legible -- ok

* MUST: sources match upstream -- ok
  a8ebeb4f41ceed71037d0f5596ccc11d  mipv6-daemon-umip-0.4.tar.gz
  a8ebeb4f41ceed71037d0f5596ccc11d  mipv6-daemon-umip-0.4.tar.gz.1

* MUST: compile on at least one primary arch -- NEEDSWORK. I just gave this a
shot in a rawhide x86_64 chroot, and the build failed. However, its simply a
missing 'BuildRequires: indent', and then it builds fine.

* MUST: ExcludeArch stuff -- n/a

* MUST: build deps -- NEEDSWORK, see above re: indent.

* MUST: locales -- n/a

* MUST: ldconfig scriptlet -- n/a

* MUST: own created directories -- ok

* MUST: no multiple listings of a file -- ok

* MUST: permissions -- ok

* MUST: %clean rm -rf -- ok

* MUST: macro consistency -- ok

* MUST: pkg contains code -- ok

* MUST: large docs in -doc sub-pkg -- n/a

* MUST: %doc bits not used at runtime -- ok

* MUST: header files -- n/a

* MUST: static libs -- n/a

* MUST: pkgconfig files -- n/a

* MUST: libs w/suffix -- n/a

* MUST: -devel req. main pkg -- n/a

* MUST: libtool droppings -- n/a

* MUST: gui .desktop file -- n/a

* MUST: doesn't own other packages dirs -- ok

* MUST: %install rm -rf -- ok

* MUST: filenames valid UTF-8 -- ok

* SHOULD: upstream need license? -- n/a

* SHOULD: description/summary translations -- n/a

* SHOULD: builds in mock -- NEEDSWORK (just the missing BR: indent)

* SHOULD: builds on all arches -- unknown

* SHOULD: functions as it should -- unknown (I don't have the time or knowledge
at the moment for functional testing, assuming packager has tested)

* SHOULD: scriptlets are sane -- ok

* SHOULD: subpkg reqs -- n/a

* SHOULD: pkgconfig files -- n/a

* SHOULD: file requires -- n/a


Basically, just add the missing BuildRequires: indent (or just tack it onto the
end of the line with flex and bison), and this package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 500245] Pre-Review Request: aqute-bndlib - BND Library

2009-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500245





--- Comment #5 from Andrew Overholt overh...@redhat.com  2009-08-17 16:16:04 
EDT ---
SRPM as provided by Fernando imported.

Jesse:  what pre-review tag should I use for a build?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >