[Bug 499539] Review Request: saxpath - Simple API for xpath
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499539 --- Comment #11 from Yang Yong yy...@redhat.com 2009-08-20 02:32:34 EDT --- overholt, Added my changelog entry and removed the trailing tab character on line 6, please review again, thanks. SPEC URL: http://yyang.fedorapeople.org/saxpath/saxpath.spec SRPM URL: http://yyang.fedorapeople.org/saxpath/saxpath-1.0-1.5.fc12.src.rpm POM URL: http://yyang.fedorapeople.org/saxpath/saxpath-1.0.pom -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517822] Review Request: hyphen-mr - Marathi hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517822 Parag pnem...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #4 from Parag pnem...@redhat.com 2009-08-20 02:58:51 EDT --- Built for all requested branches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517821] Review Request: hyphen-bn - Bengali hyphenation rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517821 Parag pnem...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #4 from Parag pnem...@redhat.com 2009-08-20 02:58:46 EDT --- Built for all requested branches with bn_BD support. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518381] New: Review Request: easymock - Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: easymock - Easy mock objects https://bugzilla.redhat.com/show_bug.cgi?id=518381 Summary: Review Request: easymock - Easy mock objects Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: akurt...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://akurtakov.fedorapeople.org/easymock.spec SRPM URL: http://akurtakov.fedorapeople.org/easymock-1.2-10.fc12.src.rpm Description: EasyMock provides Mock Objects for interfaces in JUnit tests by generating them on the fly using Java's proxy mechanism. Due to EasyMock's unique style of recording expectations, most refactorings will not affect the Mock Objects. So EasyMock is a perfect fit for Test-Driven Development. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518381] Review Request: easymock - Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518381 --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 03:05:10 EDT --- This is a full review request. The pre-review request was bug #500257. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518381] Review Request: easymock - Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518381 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks||429551 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515081] Review Request: R-affy - Methods for Affymetrix Oligonucleotide Arrays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515081 --- Comment #12 from Pierre-YvesChibon pin...@pingoured.fr 2009-08-20 03:51:58 EDT --- scratch build F11 : http://koji.fedoraproject.org/koji/taskinfo?taskID=1616636 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501957] Review Request: perl-Tk--ProgressBar-Mac - Mac ProgressBar for Perl::Tk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501957 Jan Klepek jan.kle...@hp.com changed: What|Removed |Added Flag|fedora-review+ |fedora-review? --- Comment #7 from Jan Klepek jan.kle...@hp.com 2009-08-20 05:01:42 EDT --- David, Why did you set fedora.review+ ? It is not yet approved package. I have set fedora.review? back. I will review it this week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512068] Review Request: rancid - Really Awesome New Cisco confIg Differ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512068 --- Comment #26 from Daniel Roesen d...@cluenet.de 2009-08-20 05:19:03 EDT --- I do not have the details yet, but the update to 2.3.2-3 wiped out my CVSROOT completely. Just as a warning to other users... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503847] Review Request: paperbox - A GTK tracker based document browser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=503847
--- Comment #16 from Jussi Lehtola jussi.leht...@iki.fi 2009-08-20 05:49:49
EDT ---
rpmlint output is clean.
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. NEEDSWORK
- Don't mix '%{name}' and 'paperbox' in %files. Choose one and stick with it.
- You can use longer lines in %description and fit it in 5 lines.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. NEEDSWORK
- Drop --add-category=X-Fedora, it isn't used.
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517197] Review Request: ghc-GLUT - bindings to the C GLUT library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517197 Yaakov Nemoy loupgaroubl...@gmail.com changed: What|Removed |Added CC||loupgaroubl...@gmail.com Flag||needinfo?(b...@serpentine.co ||m) --- Comment #1 from Yaakov Nemoy loupgaroubl...@gmail.com 2009-08-20 06:38:02 EDT --- Oddly enough, i can't get the md5sums to match. The file sizes of what is shipped in the RPM is different than what i get from Hackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517155] Review Request: ghc-OpenGL - bindings to the C OpenGL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517155 Yaakov Nemoy loupgaroubl...@gmail.com changed: What|Removed |Added CC||loupgaroubl...@gmail.com --- Comment #1 from Yaakov Nemoy loupgaroubl...@gmail.com 2009-08-20 06:43:21 EDT --- I'm getting the same checksum errors here. This is a bit odd. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 488397] Review Request: ghc-tar - Reading, writing and manipulating .tar archive files in Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488397 Yaakov Nemoy loupgaroubl...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Yaakov Nemoy loupgaroubl...@gmail.com 2009-08-20 06:50:17 EDT --- New Package CVS Request === Package Name: ghc-tar Short Description: Reading, writing and manipulating .tar archive files in Haskell Owners: Branches: F-11 F-12 InitialCC: fedora-haskell-list -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517914] Review Request: aqute-bndlib - The bnd tool helps you create and diagnose OSGi R4 bundles.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517914
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2009-08-20
06:55:51 EDT ---
Formal review:
OK; rpmlint gives only non-conffile-in-etc
OK; The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license
OK: The License field in the package spec file must match the actual license.
OK: License bundled and marked as %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: Sources match upstream.
OK: The package MUST successfully compile and build into binary rpms.
OK: All build dependencies are listed in BuildRequires
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application.
OK: Packages must not own files or directories already owned by other packages.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.
Package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518381] Review Request: easymock - Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518381 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com --- Comment #2 from Parag AN(पराग) panem...@gmail.com 2009-08-20 07:18:29 EDT --- I am confused here. I can see this package built on koji http://koji.fedoraproject.org/koji/buildinfo?buildID=128000 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518381] Review Request: easymock - Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518381 --- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 07:33:30 EDT --- (In reply to comment #2) I am confused here. I can see this package built on koji http://koji.fedoraproject.org/koji/buildinfo?buildID=128000 It is build only in a special tag dist-f12-maven for bootstrapping purposes. And this bug is for the normal package review to get included in rawhide. See: https://fedoraproject.org/wiki/User:Toshio/Pre-review_Guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517520] Review Request: easymock2- Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517520 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 07:35:52 EDT --- Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128038 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #9 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 07:41:49 EDT --- A few issues: - rpmlint output: directory-naming.noarch: W: non-standard-group Development/Libraries/Java directory-naming.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/directory-naming-0.8/LICENSE.txt directory-naming.noarch: W: non-conffile-in-etc /etc/maven/fragments/directory-naming FIXED except non-conffile-in-etc - javadoc issues for naming-factory: [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/BeanFactory.java:64: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/MailSessionFactory.java:59: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/SendMailFactory.java:81: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator FIXED. I don't see this warnings. - there's a minor (a date in a comment) difference between the source that I generate and the one in the SRPM I think this is acceptable. - I'd like to see a comment for the patch to the project files FIXED. Removed. It was for maven1 build which we do not support. - I removed the remaining sed lines for setproxy and the build was fine. I think they can be removed. FIXED. Removed. New sources: Spec: http://akurtakov.fedorapeople.org/directory-naming.spec Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-6.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516782] Review Request: libcpuset - Processor and memory placement library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516782
Stepan Kasal ska...@redhat.com changed:
What|Removed |Added
CC||ska...@redhat.com
--- Comment #7 from Stepan Kasal ska...@redhat.com 2009-08-20 07:56:58 EDT
---
Hello,
(In reply to comment #4)
%configure --disable-static --disable-dependency-tracking
CFLAGS=$RPM_OPT_FLAGS
make %{?_smp_mflags}
[...]
2. %configure already contain CFLAGS. The explicit CFLAGS= is superflous.
... and misplaced; CFLAGS should be set *before* configure is called.
(In reply to comment #6)
Yes, upstream doesn't package their package properly but ships a [..]
package, which doesn't comply to the autotools' working principles.
Correct. Jan, please report that upstream.
If you want deterministic builts, you're better off running the autotools in
advance to building, generate patches and apply them during builds.
... and make sure that the timestamps of all the autotools generated files (no
matter whether they chnaged or not) are in the correct order.
Otherwise, the autotools rebuild rules are triggered. They do nothing in
autotools-free buildroot, but do the rebuild otherwise; that can be confusing.
But getting the timestamps right is often quite tricky.
That's why I recommend calling autoreconf if the changes to autoconfigury are
bigger. I would recommend it in this case as well.
Moreover, the rule do not run autotools evolved in times when autotools were
much less stable than these days, so the risk that things will break with an
update was higher.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508922] Review Request: system-config-selinux - GUI Code for system-config-selinux, polgen, and lockdown
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508922 --- Comment #9 from Christopher Pardy chris.pa...@gmail.com 2009-08-20 08:02:24 EDT --- I couldn't get your build log to display, but I think I've added enough build requires for all the python files. I moved the chcon and restorecon to %post, hopefully that works. Spec URL: http://www.fedorahosted.org/releases/s/y/system-config-selinux/system-config-selinux.spec SRPM URL: http://www.fedorahosted.org/releases/s/y/system-config-selinux/system-config-selinux-0.2-3.fc11.src.rpm Description: system-config-selinux provides the graphical tools system-config-selinux and selinux-polgen for managing SELinux systems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518219] Review Request: dumbster - Fake SMTP Server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518219
--- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2009-08-20
08:01:37 EDT ---
(In reply to comment #2)
- change the groups to make rpmlint quiet
Fixed.
- md5sum of source doesn't match but contents do
I can't do anything about this.
- you can remove the post{,un} requirements for javadoc
Fixed.
- there are two sections to SimpleSmtpServer.java; I'd like to see the first
one go upstream or at least be discussed with upstream. I won't block on
this.
I'll consider sending a patch. But project looks pretty much dead.
Spec URL: http://akurtakov.fedorapeople.org/dumbster.spec
SRPM URL: http://akurtakov.fedorapeople.org/dumbster-1.6-9.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516782] Review Request: libcpuset - Processor and memory placement library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516782
--- Comment #8 from Ralf Corsepius rc040...@freenet.de 2009-08-20 08:06:01
EDT ---
(In reply to comment #7)
Hello,
(In reply to comment #4)
%configure --disable-static --disable-dependency-tracking
CFLAGS=$RPM_OPT_FLAGS
make %{?_smp_mflags}
[...]
2. %configure already contain CFLAGS. The explicit CFLAGS= is superflous.
... and misplaced; CFLAGS should be set *before* configure is called.
Wrong. With modern autoconf (ca. 2.50) CFLAGS should be set after configure.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516782] Review Request: libcpuset - Processor and memory placement library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516782 --- Comment #9 from Jan Safranek jsafr...@redhat.com 2009-08-20 08:17:22 EDT --- CFLAGS are not in the .spec anymore, stay on topic please :). Regarding autoreconf... I think it's pretty stable and probability of broken builds is pretty low now, so I am going to stick to it as it is now. Of course, I'll report it upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516782] Review Request: libcpuset - Processor and memory placement library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516782 --- Comment #10 from Ralf Corsepius rc040...@freenet.de 2009-08-20 08:40:34 EDT --- (In reply to comment #9) CFLAGS are not in the .spec anymore, stay on topic please :). Regarding autoreconf... I think it's pretty stable and probability of broken builds is pretty low now, It's mere random luck. I guess, you also give a loaded gun to your children to play with? so I am going to stick to it as it is now. Sufficent reason for me, to recommend other reviewers to not approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518441] New: Review Request: ike - Shrew Soft VPN Client For Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ike - Shrew Soft VPN Client For Linux https://bugzilla.redhat.com/show_bug.cgi?id=518441 Summary: Review Request: ike - Shrew Soft VPN Client For Linux Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: and...@topdog.za.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://topdog-software.com/oss/SRPMS/fedora/ike/ike.spec SRPM URL: http://topdog-software.com/oss/SRPMS/fedora/ike/ike-2.1.5-0.1.rc2.fc11.src.rpm Description: This free IPSEC VPN client can be used to communicate with Open Source IPSEC VPN servers as well as some commercial IPSEC VPN servers. * Rpmlint is clean * Scratch build - http://koji.fedoraproject.org/koji/taskinfo?taskID=1617339 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508922] Review Request: system-config-selinux - GUI Code for system-config-selinux, polgen, and lockdown
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508922 --- Comment #10 from Daniel Walsh dwa...@redhat.com 2009-08-20 08:49:31 EDT --- You should not need any restorecon in the post, rpm should handle this automatically. Also do not use chcon in a spec file. They will not survive a relabel. If you install and the labeling is wrong, then it needs to be fixed in the selinux-policy package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518437] Review Request: django-filter - A Django application for allowing users to filter queryset dynamically
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518437 Allisson Azevedo allis...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||allis...@gmail.com AssignedTo|nob...@fedoraproject.org|allis...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518437] New: Review Request: django-filter - A Django application for allowing users to filter queryset dynamically
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: django-filter - A Django application for allowing users to filter queryset dynamically https://bugzilla.redhat.com/show_bug.cgi?id=518437 Summary: Review Request: django-filter - A Django application for allowing users to filter queryset dynamically Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dieg...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://diegobz.fedorapeople.org/packages/django-filter/django-filter.spec SRPM URL: http://diegobz.fedorapeople.org/packages/django-filter/django-filter-0.5.0-1.fc11.src.rpm Description: Django-filter provides a simple way to filter down a queryset based on parameters a user provides. --- New dependency for the upcoming Transifex 0.7. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Blocks||518446 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Blocks||518445 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Blocks||518449 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Blocks||518448 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 506825] Review Request: bickley - A meta data management API and framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506825 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Blocks||518446 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #11 from Peter Robinson pbrobin...@gmail.com 2009-08-20 09:06:45 EDT --- Closed as its now in rawhide. Thanks spot! Will be adding very shortly the packages for the moblin panel that were split out of this package in the 0.34.0 release. They add functionality but the core UI is testable without them. I'll add them with a dep on this as a tracker. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518449] New: Review Request: moblin-panel-people - Moblin Panel for People
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: moblin-panel-people - Moblin Panel for People https://bugzilla.redhat.com/show_bug.cgi?id=518449 Summary: Review Request: moblin-panel-people - Moblin Panel for People Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pbrobin...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 513452 Blocks: 506446 Estimated Hours: 0.0 Classification: Fedora SPEC: http://pbrobinson.fedorapeople.org/moblin-panel-people.spec SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-people-0.0.1-1.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1617424 Description: The Moblin mutter panel for managing and contacting people. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518448] New: Review Request: moblin-panel-pasteboard - Moblin Panel for Paste Board
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: moblin-panel-pasteboard - Moblin Panel for Paste Board https://bugzilla.redhat.com/show_bug.cgi?id=518448 Summary: Review Request: moblin-panel-pasteboard - Moblin Panel for Paste Board Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pbrobin...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 513452 Blocks: 506446 Estimated Hours: 0.0 Classification: Fedora SPEC: http://pbrobinson.fedorapeople.org/moblin-panel-pasteboard.spec SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-pasteboard-0.0.1-1.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1617403 Description: The Moblin mutter panel for Paste Board. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518445] New: Review Request: moblin-panel-applications - Moblin Panel for launching Applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: moblin-panel-applications - Moblin Panel for launching Applications https://bugzilla.redhat.com/show_bug.cgi?id=518445 Summary: Review Request: moblin-panel-applications - Moblin Panel for launching Applications Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pbrobin...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 513452 Blocks: 506446 Estimated Hours: 0.0 Classification: Fedora SPEC: http://pbrobinson.fedorapeople.org/moblin-panel-applications.spec SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-applications-0.0.1-1.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1617363 Description: The Moblin mutter panel for launching applications. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518446] New: Review Request: moblin-panel-media - Moblin Panel for Media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: moblin-panel-media - Moblin Panel for Media https://bugzilla.redhat.com/show_bug.cgi?id=518446 Summary: Review Request: moblin-panel-media - Moblin Panel for Media Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pbrobin...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 506825,513452 Blocks: 506446 Estimated Hours: 0.0 Classification: Fedora SPEC: http://pbrobinson.fedorapeople.org/moblin-panel-media.spec SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-media-0.0.1-1.fc11.src.rpm koji: none at the moment due to dep on bickley. Built locally though. Description: The Moblin mutter panel for managing and playing media. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Blocks||518450 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Blocks||518447 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518447] New: Review Request: moblin-panel-myzone - Moblin Panel for MyZone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: moblin-panel-myzone - Moblin Panel for MyZone https://bugzilla.redhat.com/show_bug.cgi?id=518447 Summary: Review Request: moblin-panel-myzone - Moblin Panel for MyZone Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pbrobin...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 513452 Blocks: 506446 Estimated Hours: 0.0 Classification: Fedora SPEC: http://pbrobinson.fedorapeople.org/moblin-panel-myzone.spec SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-myzone-0.0.1-1.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1617385 Description: The Moblin mutter panel for MyZone. MyZone allows you to see that status of friends on social networks, chekck what you have on in your calendar, and more. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502130] Review Request: openocd - Open On-Chip Debugger
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502130 --- Comment #11 from Chitlesh GOORAH chitl...@gmail.com 2009-08-20 09:07:56 EDT --- #001 : ScriptletSnippets - Texinfo Please turn the spec file with respect to the Fedora packaging guidelines as stated on http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo #002 : %prep instead of %build Move the following to the %prep section - cd doc iconv -f iso8859-1 -t utf-8 openocd.info openocd.info.conv mv -f openocd.info.conv openocd.info - #003 : Improve future commit patches and logs Use the following style for the %configure : %configure \ --disable-werror \ --disable-static \ --enable-shared \ --enable-parport \ --enable-parport_ppdev \ --enable-ft2232_libftdi --enable-ep93xx \ --enable-at91rm9200 \ --enable-usbprog \ --enable-presto_libftdi \ --enable-jlink \ --enable-vsllink \ --enable-rlink \ --enable-dummy \ --enable-gw16012 \ --enable-amtjtagaccel \ --enable-arm-jtag-ew This is because, when openocd will be approved and everytime you will update it, you will have to commit the srpm to fedora cvs repositories. For each commit, a log message (a patch-like message) will automatically be sent to the fedora-cvs-commits mailing list, hence it would be nice that the updated item can be easily spotted in the logs. #004: Build requires: libftdi-devel already requires libusb-devel see $ rpm -qR libftdi-devel Remove libusb-devel from the buildrequires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518450] New: Review Request: moblin-panel-status - Moblin Panel for Social Network Status
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: moblin-panel-status - Moblin Panel for Social Network Status https://bugzilla.redhat.com/show_bug.cgi?id=518450 Summary: Review Request: moblin-panel-status - Moblin Panel for Social Network Status Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pbrobin...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Depends on: 513452 Blocks: 506446 Estimated Hours: 0.0 Classification: Fedora SPEC: http://pbrobinson.fedorapeople.org/moblin-panel-status.spec SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-status-0.0.3-1.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1617446 Description: The Moblin mutter panel for managing of social networks and your current status. This includes tweeting on twitter and updating of MySpace, FaceBook and you IM status. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507849] Review Request: anjal - email client for small screen devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507849 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #14 from Peter Robinson pbrobin...@gmail.com 2009-08-20 09:09:05 EDT --- and now pushed to rawhide. Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518437] Review Request: django-filter - A Django application for allowing users to filter queryset dynamically
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518437 Allisson Azevedo allis...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Allisson Azevedo allis...@gmail.com 2009-08-20 09:19:49 EDT --- [+] source files match upstream: [+] package meets naming and versioning guidelines. [+] license field matches the actual license. [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [+] compiler flags are appropriate. This is a noarch package. [+] %clean is present. [+] package builds in koji. http://koji.fedoraproject.org/koji/taskinfo?taskID=1617409 [+] package installs properly. [+] rpmlint is silent. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] no scriptlets present. [+] documentation is small, so no -docs subpackage is necessary. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518437] Review Request: django-filter - A Django application for allowing users to filter queryset dynamically
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518437 Diego Búrigo Zacarão dieg...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Diego Búrigo Zacarão dieg...@gmail.com 2009-08-20 09:31:39 EDT --- Thank you, Allisson. New Package CVS Request === Package Name: django-filter Short Description: A Django application for allowing users to filter queryset dynamically Owners: diegobz Branches: F-10 F-11 EL-5 InitialCC: diegobz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517641 --- Comment #10 from Christof Damian chris...@damian.net 2009-08-20 09:42:20 EDT --- I have contacted the doctrine people via twitter, mailing list and IRC which hopefully will clear the license question up. Andrew pointed out in bug 517643 that Doctrine is a mix of LGPLv2+, MIT, and BSD. So, lets wait and see. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513896] Review Request: pcp - performance monitoring and collection service
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513896
--- Comment #15 from Jarod Wilson jwil...@redhat.com 2009-08-20 09:42:56 EDT
---
(In reply to comment #14)
Eric Sandeen wrote:
* MUST: The package must meet the Packaging Guidelines.
NEEDSWORK? - 4 errors still above. subsys-not-used should be easy to fix
up,
I looked at this and I'd rather not change it.
It turned out not to be that easy to fix. The three PCP services
(pcp, pmie and pmproxy) all manage their own var/run/pcp/pid files.
This pre-dates the standard functionality for managing pid files and
is also multi-platform and also rock solid stable.
I think we can live with that.
* MUST: The License field in the package spec file must match the actual
license.
NEEDSWORK?
From COPYING:
All the libraries in the Performance Co-Pilot (PCP) open source
release are licensed under Version 2.1 of the GNU Lesser General
Public License.
All other components in the PCP open source release are licensed
under Version 2 of the GNU General Public License.
but the specfile says:
License: GPL+ and LGPLv2+
The previous version tried to specify the license for the base package
and the two subpackages, which is wrong because -libs has a different
license. So I've now split this so each package specifies it's own license.
Changed the spec so the base package and -devel specify GPLv2+
(assuming GPLv2+ is the best match for GPLv2.1, as specified in COPYING
since there is no explicit option for GPLv2.1), and -libs is LGPLv2
(exactly matching what's in COPYING).
GPLv2+ is only for GPLv2.anything or later, if it doesn't say or later,
then simply GPLv2 is the tag you want.
* MUST: Devel packages must require the base package using a fully
versioned dependency: Requires: %{name} = %{version}-%{release}
NEEDSWORK: Requires: pcp-libs = %{version}
For whatever reason I guess we must require pcp, not pcp-libs.
Nathan and I discussed this and we concluded the only True Dependencies are:
pcp-devel requires pcp-libs
pcp requires pcp-libs
Neither pcp-devel nor pcp-libs actually requires pcp. There is a good
reason we don't want pcp-devel to require pcp - basically it has to do with
the pcp daemon on the build machine getting killed when pcp in the chroot
gets uninstalled, i.e. we want to be able to build packages (such as pcp-gui)
that BuildRequires pcp-devel *without* pcp installed (just pcp-devel and
pcp-libs should be installed).
I think it might be cleanest/most obvious to users if the -devel package were
renamed to pcp-libs-devel, since its really the devel headers for the
libraries. Then we're even reasonably satisfying the guidelines, I'd argue.
* SHOULD: Subpackages other than devel should require the base package
using a fully versioned dependency. NO, but it seems ok
Comment: if -libs and the base package require each other, then what's the
point
of splitting out -libs since they can never be installed separately?
Welcome to multiarch. :) Splitting the libs out allows you to have pcp.x86_64,
pcp-libs.x86_64 and pcp-libs.i686 all installed at the same time without any
file conflicts (in theory).
So based on the above, I'm leaving the run-time and build-time dependencies
as they strictly need to be. If the final Fedora reviewer and/or sponsor
insist
on additional dependencies, then I'll conform, reluctantly :)
I don't think its necessary on this one, there's a reasonable reason not to.
I presume this is the srpm I should be looking at now?
ftp://oss.sgi.com/projects/pcp/download/v3/pcp-3.0.0-3.fc10.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518233] Review Request: jakarta-commons-jxpath - Simple XPath interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518233 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 09:54:46 EDT --- Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128061 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499539] Review Request: saxpath - Simple API for xpath
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499539 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Andrew Overholt overh...@redhat.com 2009-08-20 09:51:08 EDT --- Other than the need to wrap the %changelog entries at = 80 characters, this package is good to go. Let's fix the wrapping once it's in CVS. Approved. Thanks! Don't forget to follow this procedure to get it into CVS: https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500254] Pre-Review Request: jakarta-commons-jxpath - Simple XPath interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500254 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||akurt...@redhat.com Resolution||NEXTRELEASE --- Comment #6 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 09:54:15 EDT --- Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128061 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517914] Review Request: aqute-bndlib - The bnd tool helps you create and diagnose OSGi R4 bundles.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517914 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Andrew Overholt overh...@redhat.com 2009-08-20 10:05:41 EDT --- New Package CVS Request === Package Name: aqute-bndlib Short Description: The bnd tool helps you create and diagnose OSGi R4 bundles. Owners: overholt, akurtakov Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 472658] Review Request: shmpps - Shared Memory driver for PPS signals
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472658 Chris Adams li...@cmadams.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Chris Adams li...@cmadams.net 2009-08-20 10:07:45 EDT --- New Package CVS Request === Package Name: shmpps Short Description: Shared Memory driver for PPS time signals Owners: cmadams Branches: F-10 F-11 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499539] Review Request: saxpath - Simple API for xpath
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499539 --- Comment #13 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 10:08:42 EDT --- CVS was already done from pre-review #500243. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517914] Review Request: aqute-bndlib - The bnd tool helps you create and diagnose OSGi R4 bundles.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517914 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-cvs? | --- Comment #7 from Andrew Overholt overh...@redhat.com 2009-08-20 10:13:33 EDT --- Oops, I forgot that the pre-review had been passed and therefore there was already a CVS module. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517859] Review Request: vmpsd - vmpsd is a GPL implementation of Cisco Systems' VMPS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517859 --- Comment #2 from Colin Coe colin@gmail.com 2009-08-20 10:14:05 EDT --- Hi Stjepan Gros, and thanks for the review. My understanding is that it is OK to put the scripts in the spec file but I will put it in the source if I'm wrong. I've corrected to %preun and tidied up the rpmlint output. rpmlint /home/coec/rpmbuild/SRPMS/vmpsd-1.4.01-1.fc11.src.rpm /home/coec/rpmbuild/RPMS/i586/vmpsd-1.4.01-1.fc11.i586.rpm vmpsd.spec vmpsd.i586: W: service-default-enabled /etc/rc.d/init.d/vmpsd 2 packages and 1 specfiles checked; 0 errors, 1 warnings. I should have advised that I need a sponsor also. I've updated the spec and src.rpm. Spec URL: http://members.iinet.net.au/~coec/vmpsd.spec SRPM URL: http://members.iinet.net.au/~coec/vmpsd-1.4.01-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #10 from Andrew Overholt overh...@redhat.com 2009-08-20 10:20:43 EDT --- In the near future, I'd like to see us move away from this package as it appears to be dead upstream. The summary and description could also use some work. Let's do something more like: Summary: Apache Directory Naming Component Description: Naming is a lightweight, in-memory JNDI service provider. To enable flexible deployment with limited dependencies, Naming is divided in 6 packages, each producing a separate jar artifact. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518219] Review Request: dumbster - Fake SMTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518219 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Andrew Overholt overh...@redhat.com 2009-08-20 10:24:35 EDT --- I no longer get the javadoc issue. Everything else looks good. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518473] New: Review Request: odf-converter-integrator - Convert Office 2007 (OOXML) files for OpenOffice.or
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: odf-converter-integrator - Convert Office 2007 (OOXML) files for OpenOffice.or https://bugzilla.redhat.com/show_bug.cgi?id=518473 Summary: Review Request: odf-converter-integrator - Convert Office 2007 (OOXML) files for OpenOffice.or Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: asto...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://astokes.fedorapeople.org/odf-converter-integrator/odf-converter-integrator.spec SRPM URL: http://astokes.fedorapeople.org/odf-converter-integrator/odf-converter-integrator-0.2.3-1.src.rpm Description: A utility to convert Microsoft Office 2007 (Office Open XML) files and automatically start OpenOffice.org. Registers file types and mime types such as .docx, .xlsx, and .pptx so that Nautilus, Firefox, and other programs automatically recognize them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499539] Review Request: saxpath - Simple API for xpath
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499539 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #14 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 10:39:24 EDT --- Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128071 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500243] Pre-Review Request: saxpath - Simple API for XPath
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500243 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||akurt...@redhat.com Resolution||NEXTRELEASE --- Comment #11 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 10:39:04 EDT --- Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128071 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518473] Review Request: odf-converter-integrator - Convert Office 2007 (OOXML) files for OpenOffice.or
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518473 --- Comment #1 from Adam Stokes asto...@redhat.com 2009-08-20 10:40:44 EDT --- Please note I also need EPEL branches created for at least 5 Thank you, Adam Stokes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518473] Review Request: odf-converter-integrator - Convert Office 2007 (OOXML) files for OpenOffice.or
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518473 Adam Stokes asto...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518310] Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518310
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||akurt...@redhat.com
AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com
Flag||fedora-review+
--- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2009-08-20
10:58:14 EDT ---
Formal review:
OK: rpmlint gives only no-conffile-in-etc for the maven pom.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: LICENSE.txt included as %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: Instructions for retrieving sources aded.
OK: The package MUST successfully compile and build into binary rpms
OK: All build dependencies must be listed in BuildRequires
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content. [17]
OK: Large documentation files must go in a -doc subpackage. Javadoc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
OK: Packages must not own files or directories already owned by other packages.
PK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.
The package is approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518482] New: Review Request: django-sorting - A Django application for easy sorting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: django-sorting - A Django application for easy sorting https://bugzilla.redhat.com/show_bug.cgi?id=518482 Summary: Review Request: django-sorting - A Django application for easy sorting Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dieg...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://diegobz.fedorapeople.org/packages/django-sorting/django-sorting.spec SRPM URL: http://diegobz.fedorapeople.org/packages/django-sorting/django-sorting-0.1-1.fc11.src.rpm Description: Django-sorting allows for easy sorting, and sorting links generation without modifying your views. New dependency for the upcoming Transifex 0.7 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516971
--- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-08-20
11:18:29 EDT ---
Well,
- -3.fc12.src.rpm you posted does not seem to contain pkgconfig/Requires
changes you posted on comment 5?
- As I said in comment 2, adding Requires: tokyocabinet in
tokyotyrant.pc{,in}
is more correct than to add -ltokyocabinet to Libs: in case the directory
where tokyocabinet header files are moved, like:
Name: Tokyo Tyrant
Description: network interface of Tokyo Cabinet
Version: 1.1.33
Requires: tokyocabinet
Libs: -L${libdir} -ltokyotyrant
Cflags: -I${includedir}
---
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518310] Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518310 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #4 from Andrew Overholt overh...@redhat.com 2009-08-20 11:23:33 EDT --- Built in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=1617781 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] New: Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: eclipse-testframework - Eclipse Test Framework https://bugzilla.redhat.com/show_bug.cgi?id=518486 Summary: Review Request: eclipse-testframework - Eclipse Test Framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: akurt...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://akurtakov.fedorapeople.org/eclipse-testframework.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-testframework-3.5.0-1.fc11.src.rpm Description: Eclipse Test Framework. Used in conjunction with Eclipse JUnit tests. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500246] Pre-Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500246 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #16 from Andrew Overholt overh...@redhat.com 2009-08-20 11:23:59 EDT --- Built in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=1617781 (Full review was bug #518310) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 513896] Review Request: pcp - performance monitoring and collection service
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513896
--- Comment #16 from Jarod Wilson jwil...@redhat.com 2009-08-20 11:27:51 EDT
---
Okay, there's still some slightly alarming rpmlint spew... I understand the
header files need to be in the main package, but what about all these c files?
Particularly the ones under 'sample' and 'demo' sub-directories. These should
go into somewhere like /usr/share/doc/pcp/{sample,demo}/, not into
/usr/share/pcp or /var/lib/pcp.
The .NeedRebuild touch and rm in the scriptlets is also... Not pretty. Files
created by an rpm need to be owned by the rpm, even if they're temporary files.
You could add an empty file to the rpm %files list itself, so the rpm lays it
down and owns it, and there's technically no harm in the file being deleted
from the system after this rebuild takes place. If the file continues to exist,
an rpm -e will remove it, no need for the rm in the %postun scriptlet.
Speaking of the scriptlets... Standard convention is to put them before the
%files lists, not after. %files is generally the last thing before the
%changelog.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500247] Pre-Review Request: plexus-containers - Containers for Plexus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500247 --- Comment #6 from Andrew Overholt overh...@redhat.com 2009-08-20 11:29:11 EDT --- Full review request: bug #518489. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518489] New: Review Request: plexus-containers - Containers for Plexus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: plexus-containers - Containers for Plexus https://bugzilla.redhat.com/show_bug.cgi?id=518489 Summary: Review Request: plexus-containers - Containers for Plexus Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: overh...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://overholt.fedorapeople.org/plexus-containers.spec SRPM URL: http://overholt.fedorapeople.org/plexus-containers-1.0-0.1.a34.7.fc11.src.rpm Description: The Plexus project seeks to create end-to-end developer tools for writing applications. At the core is the container, which can be embedded or for a full scale application server. There are many reusable components for hibernate, form processing, jndi, i18n, velocity, etc. Plexus also includes an application server which is like a J2EE application server, without all the baggage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477979] Review Request: ripMIME - Extract attachments out of a MIME encoded email packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477979 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.4.0.9-2.fc11 |1.4.0.9-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||overh...@redhat.com AssignedTo|nob...@fedoraproject.org|overh...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500931] Review Request: emacs-verilog-mode - Verilog mode for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500931 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||528-1.el5 Resolution|RAWHIDE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500931] Review Request: emacs-verilog-mode - Verilog mode for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500931 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-08-20 11:00:39 EDT --- emacs-verilog-mode-528-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518482] Review Request: django-sorting - A Django application for easy sorting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518482 Allisson Azevedo allis...@gmail.com changed: What|Removed |Added CC||allis...@gmail.com AssignedTo|nob...@fedoraproject.org|allis...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518486] Review Request: eclipse-testframework - Eclipse Test Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 --- Comment #1 from Andrew Overholt overh...@redhat.com 2009-08-20 11:38:22 EDT --- OK naming, licensing OK files OK macros OK clean, sections ? can we get a better URL ? should it depend upon eclipse = 3.5? ? do we need to symlink to the JUnit bundles in the installation? X please version the tarball and its contents X we need an R3_5 tag passed to the fetch script. otherwise, ... OK source (md5sum doesn't match, but contents do) X rpmlint is not clean: $ rpmlint eclipse-testframework-3.5.0-1.fc11.noarch.rpm eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test.performance_3.5.0.200908201130 0775 eclipse-testframework.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-testframework-3.5.0/license.html eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/META-INF 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0/META-INF 0775 eclipse-testframework.noarch: W: dangling-relative-symlink /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.easymock_2.4.0.v20090202-0900.jar ../../../../../java/easymock2.jar eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/features/org.eclipse.test_3.5.0.200908201130 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test_3.2.0 0775 eclipse-testframework.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-testframework-3.5.0/epl-v10.html 1 packages and 0 specfiles checked; 8 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518381] Review Request: easymock - Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518381 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||overh...@redhat.com AssignedTo|nob...@fedoraproject.org|overh...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477979] Review Request: ripMIME - Extract attachments out of a MIME encoded email packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477979 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2009-08-20 11:00:28 EDT --- ripmime-1.4.0.9-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518381] Review Request: easymock - Easy mock objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518381 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Andrew Overholt overh...@redhat.com 2009-08-20 11:48:18 EDT --- OK license OK tarball instructions (md5sums of .gz don't match due to timestamps but contents match) OK (not really) naming - should be easymock1 and easymock2 should be easymock; I've opened bug #518495 to fix this after this maven update push is finished OK files OK requires Approved. Note: I'd like to see us re-build this package with maven once maven is updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518365] Review Request: jakarta-commons-configuration - Commons Configuration Package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518365 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||overh...@redhat.com AssignedTo|nob...@fedoraproject.org|overh...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518482] Review Request: django-sorting - A Django application for easy sorting
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518482
Allisson Azevedo allis...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Allisson Azevedo allis...@gmail.com 2009-08-20 11:53:06
EDT ---
[+] source files match upstream:
[+] package meets naming and versioning guidelines.
[+] license field matches the actual license.
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] compiler flags are appropriate.
This is a noarch package.
[+] %clean is present.
[+] package builds in koji.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1617869
[+] package installs properly.
[+] rpmlint is silent.
[+] owns the directories it creates.
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] no scriptlets present.
[+] documentation is small, so no -docs subpackage is necessary.
Please modify URL and Source to use macros before import to CVS:
URL:http://pypi.python.org/pypi/%{name}
Source:
http://pypi.python.org/packages/source/d/%{name}/%{name}-%{version}.tar.gz
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518365] Review Request: jakarta-commons-configuration - Commons Configuration Package
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518365
--- Comment #2 from Andrew Overholt overh...@redhat.com 2009-08-20 11:59:28
EDT ---
OK naming
OK version
OK licensing
OK requires
OK source (md5sums match)
OK files
OK macros
OK changelog
OK sections (rm at beginning of install, clean present)
X Fix description: add an of between mix and different
X get rid of post{,un} requires for javadoc
X use %{__sed} -i 's/\r//' instead of dos2unix
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518482] Review Request: django-sorting - A Django application for easy sorting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518482 Diego Búrigo Zacarão dieg...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Diego Búrigo Zacarão dieg...@gmail.com 2009-08-20 12:07:29 EDT --- OK, changes required done! Thanks :) New Package CVS Request === Package Name: django-sorting Short Description: A Django application for easy sorting Owners: diegobz Branches: F-10 F-11 EL-5 InitialCC: diegobz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517983] Review Request: 3proxy - Tiny but very powerful proxy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517983
--- Comment #2 from Peter Lemenkov lemen...@gmail.com 2009-08-20 12:43:07
EDT ---
REVIEW:
- rpmlint is not silent (I added numbering for the sake of simplicity);
[pe...@sulaco ~]$ rpmlint rpmbuild/RPMS/ppc/3proxy-*
1. 3proxy.ppc: E: executable-marked-as-config-file /etc/3proxy.cfg
2. 3proxy.ppc: E: script-without-shebang /etc/3proxy.cfg
3. 3proxy.ppc: W: log-files-without-logrotate /var/log/3proxy
4. 3proxy.ppc: W: service-default-enabled /etc/rc.d/init.d/3proxy
2 packages and 0 specfiles checked; 2 errors, 2 warnings.
[pe...@sulaco ~]$
1st and 2nd warnings should be fixed - just use 644 as a parameter for
install utility (seems that this is a typo) when you're installing 3proxy.cfg
( %{SOURCE2} )
3rd may be omitted, but it's a generally good idea to provide add-on for
logrotate in such cases.
4th should be fixed - just replace # chkconfig: 2345 02 98 with # chkconfig:
- 02 98 (note the dash sign instead of 2345).
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec .
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual licenses.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.
[pe...@sulaco SOURCES]$ sha256sum 3proxy-0.6.tgz*
fbeec42136598afb7eab212c925501b27855b07281142b2f1bbc97c14c204fde
3proxy-0.6.tgz
fbeec42136598afb7eab212c925501b27855b07281142b2f1bbc97c14c204fde
3proxy-0.6.tgz.1
[pe...@sulaco SOURCES]$
- All build dependencies must be listed in BuildRequires
http://koji.fedoraproject.org/koji/taskinfo?taskID=1617957
Missing BR dos2unix. Please, try to build in koji before submitting Review
Requests.
+/- Assuming, that you added dos2unix as a BR, the package successfully
compiles and builds into binary rpms on at least one primary architecture.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1617973
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
- Permissions on files must be set properly. See my notes, regarding rpmlint
messages.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Please, address issues noted below, and I'll continue.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518489] Review Request: plexus-containers - Containers for Plexus
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=518489
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||akurt...@redhat.com
AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com
Flag||fedora-review+
--- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2009-08-20
12:46:57 EDT ---
Formal review:
OK: rpmlint must be run on every package. Rpmlint gives the following warnings:
plexus-containers.noarch: W: no-documentation
plexus-containers.noarch: W: non-conffile-in-etc
/etc/maven/fragments/plexus-containers
plexus-containers-component-annotations.noarch: W: no-documentation
plexus-containers-container-default.noarch: W: no-documentation
It would be good if we can fix them but it's not a blocker.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: Instructions for fetching
OK: The package MUST successfully compile
OK: All build dependencies must be listed in BuildRequires
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). [15]
OK: Each package must consistently use macros. [16]
OK: The package must contain code, or permissable content. [17]
OK: Large documentation files must go in a -doc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application.
OK: Packages must not own files or directories already owned by other packages.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8. [26]
This package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485652] Review Request: navit - Car navigation system with routing engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485652 --- Comment #30 from Karel Volný kvo...@redhat.com 2009-08-20 12:47:37 EDT --- s ... (In reply to comment #29) http://wiki.navit-project.org/index.php/OpenStreetMaps ok, this led me to downloading http://maps.navit-project.org/api/map/?bbox=-12.96386718757,33.59619140625,34.1455078125,72.09228515625 You should either add the appropriate configuration elements to /etc/navit/navit.xml, so I did - I modified the template so it reads: !-- Mapset template for openstreetmaps -- mapset enabled=yes map type=binfile enabled=yes data=/var/local/osm_bbox_-13.0,33.6,34.1,72.1.bin/ /mapset ... needless to say that the file exists and is world readable after starting navit, I still got the sample map, and the Data menu entry is empty You may have to remove or comment out the section for the sample map set, also. ok, so let's try to disable it: !-- If you dont want to use the sample map, either set enabled=no in the next line or remove the xml file from the maps directory -- mapset enabled=no xi:include href=$NAVIT_SHAREDIR/maps/*.xml/ /mapset wov, now I can see the rest of the Europe, if I zoom out the map ... but still, the Data menu entry is empty ... OK, I'll go RTFM further ;-) Also note that the default configuration assumes you have a GPS device active, and gpsd running. not a good default, IMO ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518083] Review Request: rubygem-pathname2 - An alternate implementation for the Pathname library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518083 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517641 --- Comment #11 from Christof Damian chris...@damian.net 2009-08-20 12:49:36 EDT --- I got a response from jwage on twitter and he said it is LGPL. So here are the new files: Spec URL: http://rpms.damian.net/SPECS/php-channel-doctrine.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-doctrine-1.0.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 485652] Review Request: navit - Car navigation system with routing engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485652 --- Comment #31 from Adam Williamson awill...@redhat.com 2009-08-20 12:56:04 EDT --- I'm not sure I've ever seen anything in the Data menu. I'm not entirely sure what it's for :) The default may actually be different these days, I wrote the README for the Mandriva package back at version 0.1.0. I think it may not default to GPS mode any more, I'll have to check. Still, it would make a degree of sense, because it's specifically designed as a _navigation_ app, and that's not much use without GPS functionality. If you just want to look at maps there's better ways :) -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #11 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 13:09:03 EDT --- (In reply to comment #10) In the near future, I'd like to see us move away from this package as it appears to be dead upstream. The summary and description could also use some work. Let's do something more like: Apache Directory project is pretty live project but this is just too old version. Latest release is from yesterday :). Summary: Apache Directory Naming Component Description: Naming is a lightweight, in-memory JNDI service provider. To enable flexible deployment with limited dependencies, Naming is divided in 6 packages, each producing a separate jar artifact. Fixed. New sources: Spec: http://akurtakov.fedorapeople.org/directory-naming.spec Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-7.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517641] Review Request: php-channel-doctrine - Adds doctrine project channel to PEAR
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517641 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Blocks|182235(FE-Legal)| Flag|fedora-review? |fedora-review+ --- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2009-08-20 13:14:05 EDT --- Looks good; APPROVED. I'll unblock FE-Legal. By the way, your web server sends .spec files as application/octet-stream, so they can't be viewed in the browser. A bit inconvenient, that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518205] Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Andrew Overholt overh...@redhat.com 2009-08-20 13:14:09 EDT --- (In reply to comment #11) (In reply to comment #10) In the near future, I'd like to see us move away from this package as it appears to be dead upstream. The summary and description could also use some work. Let's do something more like: Apache Directory project is pretty live project but this is just too old version. Latest release is from yesterday :). You're correct. I did mean the old component. New sources: Spec: http://akurtakov.fedorapeople.org/directory-naming.spec Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-7.fc12.src.rpm Thanks. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518489] Review Request: plexus-containers - Containers for Plexus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518489 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #2 from Andrew Overholt overh...@redhat.com 2009-08-20 13:19:41 EDT --- Built: http://koji.fedoraproject.org/koji/taskinfo?taskID=1618018 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500247] Pre-Review Request: plexus-containers - Containers for Plexus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500247 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #7 from Andrew Overholt overh...@redhat.com 2009-08-20 13:20:04 EDT --- Built: http://koji.fedoraproject.org/koji/taskinfo?taskID=1618018 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500251] Pre-Review Request: dumbster - Fake SMTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500251 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||akurt...@redhat.com Resolution||NEXTRELEASE --- Comment #9 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 13:21:55 EDT --- Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128103 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 518219] Review Request: dumbster - Fake SMTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518219 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2009-08-20 13:22:25 EDT --- Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128103 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501006] Review Request: xine-ui - A skinned xlib-based gui for xine-lib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501006 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2009-08-20 13:27:55 EDT --- xine-ui-0.99.5-15.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509609] Review Request: mediawiki-rss - rss tag extension for mediaiwki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509609 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.5-2.fc11 |1.5-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
