[Bug 501960] Review Request: webinject - Web/HTTP Test Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501960 --- Comment #17 from Jan Klepek jan.kle...@hp.com 2009-12-27 05:05:35 EDT --- Applications/Internet would be better -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 550582] Review Request: dpkg - Package maintenance system for Debian Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=550582
--- Comment #3 from leigh scott leigh123li...@googlemail.com 2009-12-27
05:59:17 EDT ---
(In reply to comment #2)
Just a few comments:
-
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
- Could you reduce the %files a bit?
e.g.: %{_bindir}/dpkg-*
%{_mandir}/*/man*/dpkg-*
and so on.
It will be easier to follow, and maybe the compression format of the man
pages
changes and you need to rename all *.gz to something else.
- There is a new version upstream.
How do you create the patch?
(Maybe sed would be enought. Most of the changes are only in the *.po file,
which will change quite often...)
You are wrong, doing this will mess the package up.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504476 Jan Klepek jan.kle...@hp.com changed: What|Removed |Added Flag||needinfo?(lkund...@v3.sk) --- Comment #9 from Jan Klepek jan.kle...@hp.com 2009-12-27 05:57:13 EDT --- Lubomir or Matthew, ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 550582] Review Request: dpkg - Package maintenance system for Debian Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=550582
--- Comment #4 from leigh scott leigh123li...@googlemail.com 2009-12-27
06:02:45 EDT ---
(In reply to comment #2)
Just a few comments:
-
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
- Could you reduce the %files a bit?
e.g.: %{_bindir}/dpkg-*
%{_mandir}/*/man*/dpkg-*
and so on.
The dpkg package is total scrambled if you do this
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461119] Review Request: libtiger - Rendering library for Kate streams using Pango and Cairo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461119 --- Comment #5 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-12-27 06:14:25 EDT --- I will fix Is this a full review ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512726] Review Request: perl-Test-Refcount - Assert reference counts on objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512726 Bug 512726 depends on bug 514942, which changed state. Bug 514942 Summary: An assertion in FindRef.xs fails https://bugzilla.redhat.com/show_bug.cgi?id=514942 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NOTABUG -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504476 --- Comment #10 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-12-27 07:06:10 EDT --- (I have not tried to check this gem by myself, however please be careful when attempting to delete hidden files or zero-size files. I have already seen some cases (including gem based rpms) in which deleting such files made the package non-workable. Also it is recommended to execute $ rake test in %check as this gem file contains test/ directory) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 542341] Review Request: mercury - Replacement for the Maven Artifact subsystem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542341 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Depends on||550790 --- Comment #5 from Lubomir Rintel lkund...@v3.sk 2009-12-27 07:11:56 EDT --- Bug which causes raw hide build to fail: #550790 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 550104] Review Request: magento - Magento is an ecommerce web application.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550104 Alagunambi Welkin alagunambiwel...@gmail.com changed: What|Removed |Added CC||alagunambiwel...@gmail.com --- Comment #1 from Alagunambi Welkin alagunambiwel...@gmail.com 2009-12-27 07:14:26 EDT --- Hi, Just a quick review suggestion, In magento.spec line no. 28 remove unwanted tabs Alagunambi Welkin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549366] Review Request: flaw - F.L.A.W is a small multiplayer action game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549366 Alagunambi Welkin alagunambiwel...@gmail.com changed: What|Removed |Added CC||alagunambiwel...@gmail.com --- Comment #4 from Alagunambi Welkin alagunambiwel...@gmail.com 2009-12-27 07:21:26 EDT --- Hi, Just a quick review suggestion, you can change the Source0 value to http://downloads.sourceforge.net/flaw/flaw-1.2.tar.gz Alagunambi Welkin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 534061] Review Request: hostname - Utility to set/show the host name or domain name
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=534061 Jiri Popelka jpope...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 523523] Review Request: clutter-gesture - Gesture Library for Clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523523 Christian Krause c...@plauener.de changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Christian Krause c...@plauener.de 2009-12-27 08:30:30 EDT --- Thank you very much for the update. (In reply to comment #2) Fixed: - Let URL tag point to specific project page on moblin.org - Add MIT to license tag - Remove unusual %configure flags / CFLAGS Reported upstream. - Package API documentation - Fix public header files I've reviewed the new package and besides the public header / pkgconfig issue it looks fine now. Have you already heard something from upstream? However, since it is possible to compile eom against clutter-gesture (and the test programs work), the header issue does not block the review. The remaining minor non-blocking issues are: 1. Package API documentation 2. Fix public header files / pkgconfig Please note, that /usr/lib/pkgconfig/clutter-gesture.pc also contains a placeholder which was not replaced by the configure script: modlibexecd...@modlibexecdir@ This must also be fixed. - APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517743
--- Comment #15 from Sandro Mathys s...@sandro-mathys.ch 2009-12-27 09:33:56
EDT ---
Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.9-1.fc12.src.rpm
(In reply to comment #13)
This is a MUST. ;)
If you have multiple licenses, you have to e.g. refer to in this case
readme.txt or say in a comment, which files have which license.
Oh, I thought that only applies for the old version where licensing was not
clear. But now that I actually read the link it's clear :) Wonder why I never
saw this before, I pretty sure have other multi-license packages :/
FIXED (comment above License)
anything under wxWidgets can be relicensed under GPL. BUT in fact, Josiah has
already done that
But the whole file itself is GPL - no wxWidgets everywhere.
Right, after reading through the license comments again, seems to be sane.
What is copyrighted under LGPL?
There is a lgpl.txt, but that's it. Or am I wrong?
Josiah already answered that :) And so did you in comment #5 btw :)
So, it stays for me: GPLv2.
So it's GPLv2 and LGPLv2. FIXED
Some other issues:
- $RPM_BUILD_ROOT%{_datadir}/%{name} is created, but empty (rest of old icon
path) - not needed anymore.
Hm...right. FIXED
- sed -i -e s;PYTHONPATH;%{python_sitelib};g %{SOURCE1}
has no effect. There is no pythonpath in the .desktop ( yet? ;) )
Uh, good catch! Grabbed the wrong desktop file in the end :/ FIXED
- Don't copy *.pyc and *pyw.
They are created later in the /usr/lib/rpm/brp-python-bytecompile part
anyway.
See
https://fedoraproject.org/wiki/Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
MUST: don't install them, and Josiah please don't include them (same for
*.dll);)
FIXED. Not upstream tho.
- changelog format:
There is '* new version' - '- new version'
Awww, right. FIXED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 523523] Review Request: clutter-gesture - Gesture Library for Clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523523 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Peter Robinson pbrobin...@gmail.com 2009-12-27 10:04:51 EDT --- Thanks for the review New Package CVS Request === Package Name: clutter-gesture Short Description: Gesture Library for Clutter Owners: pbrobinson Branches: F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 550582] Review Request: dpkg - Package maintenance system for Debian Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=550582
--- Comment #5 from Thomas Spura toms...@fedoraproject.org 2009-12-27
10:26:18 EDT ---
(In reply to comment #4)
(In reply to comment #2)
Just a few comments:
-
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
- Could you reduce the %files a bit?
e.g.: %{_bindir}/dpkg-*
%{_mandir}/*/man*/dpkg-*
and so on.
The dpkg package is total scrambled if you do this
Right, it was a bit late, when I wrote that ;)
Deleting the .gz at the end of the manuals would be great anyway...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 461119] Review Request: libtiger - Rendering library for Kate streams using Pango and Cairo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461119 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org Flag||fedora-review? --- Comment #6 from Thomas Spura toms...@fedoraproject.org 2009-12-27 11:02:03 EDT --- (In reply to comment #5) I will fix Is this a full review ? No. I didn't want to do a full review, when %files is not yet in final state; but will do the rest of it now... REVIEW: Good: - Group ok - name ok - description ok - removing *.la, ok - no static libs - libs correctly packaged (ldconfig...) - timestamps ok - parallel make - rpmlint clean - builds in koji https://koji.fedoraproject.org/koji/taskinfo?taskID=1892775 Needswork: - License is wrong: Why BSD? There are LGPLv2+ headers and COPYING. - %files Will check for permissions and so on later. - BR: - cairo-devel is missing, gets pulled in by pango-devel, but I wouldn't trust that... - check for = 0.2.7 is not needed anymore, but ok - How about including the examples into -devel, too? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #12 from Mario Ceresa mrcer...@gmail.com 2009-12-27 11:57:45 EDT --- Hello Leon, I hope you spent a merry Christmas! At last I figured how to patch the program to remove gXLib. It was pretty easy: 1) start with the source dir 2) patch googsystray-1.0.0/googsystray/GMain.py as follows: 144c144 from gXlib import X, display, XK, protocol --- from Xlib import X, display, XK, protocol 3) remove googsystray-1.0.0/googsystray: gXlib 4) Patch googsystray-1.0.0/setup.py: 126,132c126 packages = ['googsystray', 'googsystray/gXlib', 'googsystray/gXlib/protocol', 'googsystray/gXlib/support', 'googsystray/gXlib/keysymdef', 'googsystray/gXlib/xobject', ], --- packages = ['googsystray'], 5) # yum install python-xlib Then I did a $ python setup.py install $ googsystray and it worked like a charm. When you have time, if you could regenerate the spec (adding Requires: python-xlib) and the source rpm, we can complete the checks and finally approve the package! :) Thanks and regards, Mario -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #16 from Thomas Spura toms...@fedoraproject.org 2009-12-27 12:16:39 EDT --- You use 'sed -i'. Everytime you change the .desktop to contain PYTHONPATH, you destroy it, when you run rpmbuild again. (And the included .desktop does not contain PYTHONPATH again ;) ) If you upload the corrected one manually (with cvs add... and not with ./common/cvs-import.sh) this will be ok in cvs... ### LICENSE I'm still not sure, if the license is correct. Josiah copied the LGPLv2 file and made some changes under GPLv2. ([...] which describes which parts of itself are lgpl v2 licensed. [...]) and in the file is adapted from, which means there where changes... LGPLv2 allows relicensing under GPLv2 (see https://fedoraproject.org/wiki/Licensing#GPL_Compatibility_Matrix ). - Anything GPLv2 But I'm no layer. If Josiah would agree to this, it'll be ok. If not, I'd like the legal team to take a look. ###y Anything else fine in the spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #13 from Peter Lemenkov lemen...@gmail.com 2009-12-27 12:23:54 EDT --- Hello, Mario! I'd bet, that unified diff will be more useful for Leon :) Just send us diff -u output instead of plain diff (note -u switch). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 539387] Review Request: InsightToolkit - Medical imaging processing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539387 --- Comment #10 from Peter Lemenkov lemen...@gmail.com 2009-12-27 13:05:49 EDT --- Ok, finally found some time to continue reviewing this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545720
--- Comment #14 from Mario Ceresa mrcer...@gmail.com 2009-12-27 13:21:22 EDT
---
Hello Peter, hello Leon,
here you are :)
[ma...@shadow SOURCES]$ diff -ru googsystray-1.0.0_orig/ googsystray-1.0.0/
Only in googsystray-1.0.0_orig/bin: googsystray~
diff -ru googsystray-1.0.0_orig/build/lib/googsystray/GMain.py
googsystray-1.0.0/build/lib/googsystray/GMain.py
--- googsystray-1.0.0_orig/build/lib/googsystray/GMain.py 2009-11-28
20:22:41.0 +0100
+++ googsystray-1.0.0/build/lib/googsystray/GMain.py2009-12-27
17:18:23.0 +0100
@@ -141,7 +141,7 @@
else:
- from gXlib import X, display, XK, protocol
+ from Xlib import X, display, XK, protocol
import GIcon, GConf, GV, GReader, GMail, GCal, GContacts, GIPC, GWave
Only in googsystray-1.0.0_orig/build/lib/googsystray: gXlib
diff -ru googsystray-1.0.0_orig/googsystray/GMain.py
googsystray-1.0.0/googsystray/GMain.py
--- googsystray-1.0.0_orig/googsystray/GMain.py 2009-11-28 20:22:41.0
+0100
+++ googsystray-1.0.0/googsystray/GMain.py 2009-12-27 17:18:23.0
+0100
@@ -141,7 +141,7 @@
else:
- from gXlib import X, display, XK, protocol
+ from Xlib import X, display, XK, protocol
import GIcon, GConf, GV, GReader, GMail, GCal, GContacts, GIPC, GWave
Only in googsystray-1.0.0/googsystray: googsystray
Only in googsystray-1.0.0_orig/googsystray: gXlib
diff -ru googsystray-1.0.0_orig/setup.py googsystray-1.0.0/setup.py
--- googsystray-1.0.0_orig/setup.py 2009-12-01 18:39:01.0 +0100
+++ googsystray-1.0.0/setup.py 2009-12-27 17:23:47.0 +0100
@@ -123,13 +123,7 @@
author_email = jim.duc...@gmail.com,
url = http://www.sourceforge.net/projects/googsystray/;,
data_files = files,
- packages = ['googsystray',
- 'googsystray/gXlib',
- 'googsystray/gXlib/protocol',
- 'googsystray/gXlib/support',
- 'googsystray/gXlib/keysymdef',
- 'googsystray/gXlib/xobject',
- ],
+ packages = ['googsystray'],
package_data = { googsystray : [sounds/*,icons/*] },
scripts = [bin/googsystray],
long_description = Really long text here.,
Cheers,
Mario
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 539387] Review Request: InsightToolkit - Medical imaging processing library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=539387
--- Comment #11 from Peter Lemenkov lemen...@gmail.com 2009-12-27 13:27:23
EDT ---
(In reply to comment #8)
* Source0 url should be corrected. See Source1 for example
I'm not quite sure if I get this. Do you want me to remove %name and %version
from Source0 and write directly
http://voxel.dl.sourceforge.net/sourceforge/itk/InsightToolkit-3.16.0.tar.gz ?
For files, stored at SF, you should use something like this:
Source0: http://downloads.sourceforge.net/itk/%{name}-%{version}.tar.gz
Note, that this URL doesn't have pre-defined mirror site (like yours one have).
* %{_libdir}/%{name}/*.cmake should be placed in devel rather than in main
package, I believe. Also, I'm not sure this is a correct place to put CMake
files in.
Moved to the devel section. Neither I am sure about their correct position.
Maybe they should be put in cmake config dir?
I suppose so.
* Source1 should be added as %doc in devel-subpackage
First copied to builddir in %prep and then added as %doc. Not sure if this is
the correct way
Not so correct. You should simply copy %{SOURCE1} instead of using full path:
- cp %{_builddir}/../SOURCES/ItkSoftwareGuide-2.4.0.pdf .
+ cp %{SOURCE1} .
* I just found, that ITK contains numerous bundled libraries, many of them are
duplication Fedora's system ones - see 'Utilities' directory. This should be
fixed (and necessary BuildRequires should be added).
Fixed adding -DUSE_SYSTEM_* to cmake flags. Anyway I didn't find any package
for niether GDCM nor VXL.
To be really sure, you need to remove these directories with duplicated system
libraries, at a %prep stage. And properly patch the rest of the code, if
something will go wrong.
Should I package them as well or can I leave the itk versions for now?
Ideally, yes. But it's not *MUST*, it's a *SHOULD* rule. So we may simply use
them as-is for now.
I'm looking at at your new spec right now, so more notes to come.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 539387] Review Request: InsightToolkit - Medical imaging processing library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=539387
--- Comment #12 from Peter Lemenkov lemen...@gmail.com 2009-12-27 14:40:36
EDT ---
Ok, here are new issues:
* Unowned directory %{_datadir}/%{name}. I suggest you either to add it to the
main sub-package, or to put examples into docdir.
* doc sub-package mustn't own %{_docdir}/%{name}-%{version} - it's already
owned by main sub-package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 550100] Review Request: python-olpcgames - Utilities for developing games on the OLPC platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550100 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||1.6-3.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 539983] Review Request: qjson - qt-based library that maps JSON data to QVariant object
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539983 --- Comment #27 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:26:23 EDT --- qjson-0.7.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 539983] Review Request: qjson - qt-based library that maps JSON data to QVariant object
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539983 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||0.7.1-1.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 550100] Review Request: python-olpcgames - Utilities for developing games on the OLPC platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550100 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:24:25 EDT --- python-olpcgames-1.6-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 529256] Review Request: i3status - Generates a status line for dzen2 or wmii
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529256 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||2.0-1.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 544581] Review Request: python-minimock - The simplest possible mock library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544581 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||1.2.5-1.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 544581] Review Request: python-minimock - The simplest possible mock library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544581 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:29:10 EDT --- python-minimock-1.2.5-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 550100] Review Request: python-olpcgames - Utilities for developing games on the OLPC platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550100 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.6-3.fc11 |1.6-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522272] New Package for Dogtag PKI: symkey
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522272 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:29:31 EDT --- symkey-1.3.0-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520719] New Package for Dogtag PKI: tomcatjss
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520719 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||1.2.0-2.fc12 Resolution|NOTABUG |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 529256] Review Request: i3status - Generates a status line for dzen2 or wmii
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529256 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:30:14 EDT --- i3status-2.0-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522272] New Package for Dogtag PKI: symkey
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522272 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.3.0-4.fc11|1.3.0-4.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520719] New Package for Dogtag PKI: tomcatjss
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520719 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:28:46 EDT --- tomcatjss-1.2.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 550100] Review Request: python-olpcgames - Utilities for developing games on the OLPC platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550100 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:29:44 EDT --- python-olpcgames-1.6-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549366] Review Request: flaw - F.L.A.W is a small multiplayer action game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549366 --- Comment #5 from Fabian Affolter fab...@bernewireless.net 2009-12-27 16:06:19 EDT --- (In reply to comment #4) you can change the Source0 value to http://downloads.sourceforge.net/flaw/flaw-1.2.tar.gz But I would like to suggest still to use macros. It's much easier to maintain. Changing the version in the Source0 with every update just sucks ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 544581] Review Request: python-minimock - The simplest possible mock library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544581 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:34:28 EDT --- python-minimock-1.2.5-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 539983] Review Request: qjson - qt-based library that maps JSON data to QVariant object
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539983 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.7.1-1.fc11|0.7.1-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467641] Review Request: sugar-maze - Maze for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467641 Bug 467641 depends on bug 514687, which changed state. Bug 514687 Summary: Sugar activities needs python-olpc-games https://bugzilla.redhat.com/show_bug.cgi?id=514687 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 539983] Review Request: qjson - qt-based library that maps JSON data to QVariant object
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539983 --- Comment #28 from Fedora Update System upda...@fedoraproject.org 2009-12-27 15:33:30 EDT --- qjson-0.7.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 467641] Review Request: sugar-maze - Maze for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467641 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Status Whiteboard|NotReady| --- Comment #13 from Fabian Affolter fab...@bernewireless.net 2009-12-27 16:34:04 EDT --- Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-maze.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-maze-0-0.4.20091227.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 546866] Review Request: qffmpeg - Stripped-down fork of ffmpeg for libspice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546866 --- Comment #2 from Jeroen van Meeuwen kana...@kanarip.com 2009-12-27 18:10:47 EDT --- Ralf, agreed. It's dependencies seem to build just fine with regular ffmpeg. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 544873] Review Request: gitweb-caching - Gitweb w/ simple file caching
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544873
Jon Stanley jonstan...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Jon Stanley jonstan...@gmail.com 2009-12-27 18:28:56 EDT
---
One more minor nitpicky thing I found doing the review - you need to include
the COPYING file as %doc in the package. Provided that you do that before you
import, this package is APPROVED.
Find me on IRC and I'll get you sponsored and walk you through the next steps.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
NO - License file included in package
YES - Spec in American English
YES - Spec is legible.
YES - Sources match upstream md5sum:
$ sha1sum --quiet -c ../sha1sums.txt
$
Note that the tarball in the package is generated via a gitweb snapshot as
mentioned in the comments
I've verified that the sha1sum of every file matches the upstream git repo
N/A - Package needs ExcludeArch
YES - BuildRequires correct
N/A - Spec handles locales/find_lang
N/A - Package is relocatable and has a reason to be.
YES - Package has %defattr and permissions on files is good.
YES - Package has a correct %clean section.
YES - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
YES - Package is code or permissible content.
N/A - Doc subpackage needed/used.
YES - Packages %doc files don't affect runtime.
N/A - Headers/static libs in -devel subpackage.
N/A - Spec has needed ldconfig in post and postun
N/A - .pc files in -devel subpackage/requires pkgconfig
N/A - .so files in -devel subpackage.
N/A - -devel package Requires: %{name} = %{version}-%{release}
N/A - .la files are removed.
N/A - Package is a GUI app and has a .desktop file
YES - Package compiles and builds on at least one arch.
YES - Package has no duplicate files in %files.
YES - Package doesn't own any directories other packages own.
YES - Package owns all the directories it creates.
YES - No rpmlint output.
YES - final provides and requires are sane:
SHOULD Items:
YES - Should build in mock.
YES - Should build on all supported archs
YES - Should function as described.
YES - Should have sane scriptlets.
N/A - Should have subpackages require base package with fully versioned depend.
YES - Should have dist tag
YES - Should package latest version
N/A - check for outstanding bugs on package. (For core merge reviews)
Issues:
1. Include the license file (COPYING) in the package as %doc
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549366] Review Request: flaw - F.L.A.W is a small multiplayer action game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549366 --- Comment #6 from Alagunambi Welkin alagunambiwel...@gmail.com 2009-12-27 23:37:08 EDT --- (In reply to comment #5) (In reply to comment #4) you can change the Source0 value to http://downloads.sourceforge.net/flaw/flaw-1.2.tar.gz But I would like to suggest still to use macros. It's much easier to maintain. Changing the version in the Source0 with every update just sucks ;-) Ooops! I forgot to mention to add macros instead of name, version, all I suggested to change the link address, thanks the pointing it! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 544964] Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544964
--- Comment #2 from Matthew Kent mk...@magoazul.com 2009-12-28 01:04:28 EDT
---
(In reply to comment #1)
Well,
* License
- I guess the license for this package should
be GPL+ or Ruby or Artistic.
Sure! Fixed.
* rcov for %check
- build.log says:
---
89 + rake test
90 Hoe.new {...} deprecated. Switch to Hoe.spec.
91 (in
/builddir/build/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16)
92 which: no dot in
(/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/root/bin:/usr/local/sbin)
93 /usr/bin/ruby -w -Ilib:ext:bin:test -e 'require rubygems; require
test/unit; require test/test_mime_type.rb; require
test/test_mime_types.rb'
94 RCov is not available. In order to run rcov, you must: sudo gem
install
spicycode-rcov
---
I don't know well about RCov, however when I install
rubygem-rcov, rake check fails as:
---
[tasa...@localhost mime-types-1.16]$ rake test --trace
(in
/home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16)
Hoe.new {...} deprecated. Switch to Hoe.spec.
rake aborted!
undefined method `test_files' for #Hoe:0xb75d9a78
/home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:53
/usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/lib/rcov/rcovtask.rb:91:in `initialize'
/home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51:in
`new'
/home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `load'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `raw_load_rakefile'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2016:in `load_rakefile'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in
`standard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2015:in `load_rakefile'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1999:in `run'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in
`standard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1997:in `run'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31
/usr/bin/rake:19:in `load'
/usr/bin/rake:19
---
ref: http://bugs.gentoo.org/288996
Would you check this?
Rcov will produce a pretty report of the test coverage but is by no means
necessary for the unit tests themselves.
As to the error it looks like the Rakefile wants a specific version of rcov,
p.extra_dev_deps %w(rcov ~0.8)
while Fedora is on 0.9.6. I'll file a ticket with the upstream project about
updating it to something more recent.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 544964] Review Request: rubygem-mime-types - Return the MIME Content-Type for a given filename
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544964 --- Comment #3 from Matthew Kent mk...@magoazul.com 2009-12-28 01:18:04 EDT --- Spec URL: http://magoazul.com/wip/SPECS/rubygem-mime-types.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-mime-types-1.16-2.fc13.src.rpm * Sun Dec 27 2009 Matthew Kent mk...@magoazul.com - 1.16-2 - Fix license (#544964). - Add note about rcov warning in test phase (#544964). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549286] Review Request: rubygem-merb-core - Lightweight Ruby-based MVC framework for web development
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549286 --- Comment #3 from Matthew Kent mk...@magoazul.com 2009-12-28 01:47:57 EDT --- Thank you for the review! (In reply to comment #2) The example provided by you works for me. Some remarks: * Requires Would you check if the following dependencies are not needed? - ebb from lib/merb-core/rack/adapter/ebb.rb merb supports multiple frontend webservers via adapters and the -a parameter: The rack adapter to use to run merb (default is mongrel)[mongrel, emongrel, thin, ebb, fastcgi, webrick] As they use mongrel by default I chose to add it as a dependency and none of the others. Not having those gems installed doesn't inhibit functionality of the app. The gem doesn't depend on any adapter at all oddly enough, though one could use webrick that ships with ruby itself. - ruby-debug from lib/merb-core/config.rb No package for this currently, though it looks useful. Doesn't look to block the main function of merb-core though and isn't listed as a primary or development dependency. I'll add to my list of things to package. - ruby-prof from lib/merb-core/core_ext/kernel.rb lib/merb-core/rack/middleware/profiler.rb No package for this currently, though it looks useful. Doesn't look to block the main function of merb-core though and isn't listed as a primary or development dependency. I'll add to my list of things to package. - swiftiply from lib/merb-core/rack/adapter/evented_mongrel.rb lib/merb-core/rack/adapter/swiftiplied_mongrel.rb - thin from lib/merb-core/rack/adapter/thin.rb - thin-turbo (could not find on gems.rubyforge.org) from lib/merb-core/rack/adapter/thin_turbo.rb See above note about adapters. Will look into the thin-turbo issue and file a ticket if necessary. - webrat from lib/merb-core/test.rb The Rakefile lists it as a development dependency and I believe it's only required to run the merb test suite which isn't in this version. I'll be sure to revisit it when the next version of merb, which appears to come with the test suite, is released. - webrick from lib/merb-core/rack/adapter/webrick.rb This ships with ruby, though actually using it as an adapter doesn't seem to work with my example (404's each time). I should file an upstream bug for this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 549286] Review Request: rubygem-merb-core - Lightweight Ruby-based MVC framework for web development
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549286 --- Comment #4 from Matthew Kent mk...@magoazul.com 2009-12-28 02:09:07 EDT --- (In reply to comment #3) Thank you for the review! (In reply to comment #2) - ruby-debug from lib/merb-core/config.rb No package for this currently, though it looks useful. Doesn't look to block the main function of merb-core though and isn't listed as a primary or development dependency. I'll add to my list of things to package. Scratch this - is available in Bug 532306 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
