[Bug 176374] Review Request: nagios-plugins

2006-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-06-14 20:12 EST ---
Successfully built.  Should be availe in FC4/5 soon.  Thanks all.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-11 14:24 EST ---
One step ahead of me.  It is now built cleanly.  I'm going to wait and make sure
everything looks good in devel before I build it for FC-X.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-11 11:24 EST ---
Mike,

Adding the lines below to the %install section should fix it

%ifarch ppc ppc64
%{__rm} -f %{buildroot}%{_libdir}/nagios/plugins/check_sensors
%endif

jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-08 07:55 EST ---
Created an attachment (id=130733)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130733&action=view)
Do not create the sensors plugin in ppc builds


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-08 07:50 EST ---
Mike,

Instead of just excluding the ppc arch could you try to use conditional blocks
like the one below:

...
%ifnarch ppc ppc64
%files sensors
%defattr(-,root,root,-)
%{_libdir}/nagios/plugins/check_sensors
%endif
...

I will attach a possible patch (not tested as I don't have access to ppc 
systems).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-08 00:02 EST ---
The build is done with these changes, I'm going to make sure it's fine in devel
before I release it in FC4/5

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-07 18:35 EST ---
Mike,

We have to exclude the subpackage nagios-plugins-sensors from being created for
ppc as lm_sensors is not built for it (and also exclude it from the
nagios-pluggins-all requirement list).

jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 17:48 EST ---
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-03 18:12 EST ---
Mike,

As in this review there are several people envolved, we should fall back
to a voting decision (as in old Fedora.us days).  At least two or three other
reviewers should express their opinion by placing a comment like PUBLISH++ or
PUBLISH--.

But if no one expresses his opinion, lets say in the next 48 hours, I will
approve this package changing the blocking ticket from FE-REVIEW to FE-ACCEPT.
(I still would love to see a comment from someone with a 64bit system.) 


My vote is for approval.

PUBLISH++

MD5SUMS:
6387568f71b4c7fd6afe62afdb5e1972  nagios-plugins-1.4.3-5.src.rpm

2c40fc69d51cc979e85150870a1daa93  nagios-plugins-1.4.3.tar.gz
6af2d874922483154a5e8adf87e066b3  nagios-plugins.spec

jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-03 17:11 EST ---
These updates have been made:

SPEC: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins.spec
SRPM: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins-1.4.3-5.src.rpm

Jose Pedro Oliveira: you have assigned this to yourself and voted for approval,
are you approving it?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-06-02 12:40 EST ---
You have to 
-Requires: nagios-plugins = %{version}-${release}
+Requires: nagios-plugins = %{version}-%{release}
in two places

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-06-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-06-01 17:57 EST ---
MD5SUMS:
766f257aa209759b94f68a8a37119cf5  nagios-plugins-1.4.3-4.src.rpm

2c40fc69d51cc979e85150870a1daa93  nagios-plugins-1.4.3.tar.gz
f4e1bb47d20816d128f9704be7bd6b04  nagios-plugins.spec


PUBLISH++

This is my vote for approval.  

Notes:

* The following itens should be corrected
  (maybe after importing the package to the CVS repo)
  - The last changelog entry needs to be corrected (release bump)
  - The empty export statement before the configure macro should be removed

* Could someone (re)build this package in a 64bit system and express his vote?

* I have assigned this ticket to me.  If someone wants it, please feel free to  
 
  reassign it.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-20 22:08 EST ---
SPEC: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins.spec
SRPM: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins-1.4.3-4.src.rpm

Changelog:
- Now using configure macro instead of ./configure
- Added BuildRequest: perl(Net::SNMP)
- For reference, this was bugzilla.redhat.com ticket# 176374

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-20 11:16 EST ---
Created an attachment (id=129746)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=129746&action=view)
Inherit distro CFLAGS

Mike,

This patch does the following: 

* [Blocker] Makes the package use the distro CFLAGS 

  Most of the plugins weren't being compiled with the distro CFLAGS.
  Using the %configure macro takes care of that.

* Adds perl(Net::SNMP) to the build requirements

  One less warning message from the configure.

Suggestion: Could you also add the bugzilla ticket to one of the changelog
entries? 

Hopefully these will be the last corrections.

jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-05-20 11:00 EST ---
Changing  FE-NEW  to  FE-REVIEW.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-20 01:02 EST ---
SPEC: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins.spec
SRPM: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins-1.4.3-3.src.rpm

Changelog:
- Added check_ide_smart
- Added some dependencies
- Added support for check_if* (perl-Net-SNMP now in extras)
- nagios-plugins now owns dir %{_libdir}/nagios



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-18 18:16 EST ---
Next time you're in the Chicagoland area lemme know, I owe you a beer.  I'm
chomping through some of these changes and testing.  I'll post what I've got by
tomorow night.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-18 17:59 EST ---
Mike,

perl-Net-SNMP has been built for FC-4, FC-5, and devel. The devel RPMs have
already been pushed into the mirrors. The FC-4 and FC-5 will take a little a bit
longer (next push).

jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-17 18:59 EST ---
Missing requirements in perl plugins


The perl module - utils.pm - as the following lines modified by the
configure script (utils.sh also has similar lines).

## updated by autoconf
$PATH_TO_RPCINFO = "/usr/sbin/rpcinfo" ;
$PATH_TO_NTPDATE = "/usr/sbin/ntpdate" ;
$PATH_TO_NTPDC   = "/usr/sbin/ntpdc" ;
$PATH_TO_NTPQ= "/usr/sbin/ntpq" ;
$PATH_TO_LMSTAT  = "" ;
$PATH_TO_SMBCLIENT = "/usr/bin/smbclient" ;
$PATH_TO_MAILQ   = "/usr/bin/mailq";
$PATH_TO_QMAIL_QSTAT = "";

and these variables are used by some of the perl plugins. For example,
the check_ntp should require the ntp package 

Code used by in the check_ntp plugin
-
my $ntpdate = $utils::PATH_TO_NTPDATE;
my $ntpq= $utils::PATH_TO_NTPQ;
...
open (NTPDATE, $ntpdate . " -q $host 2>&1 |")
...
open(NTPQ, $ntpq . " -np $host 2>&1 |")


Plugins with missing requirements:

* nagios-plugins-mailq
  should require the /usr/bin/mailq file (or sendmail (?))

* nagios-plugins-ntp
  should require the ntp package (or the above ntp utilities)

* nagios-plugins-disk_smb
  should require the samba-client package or the /usr/bin/smbclient binary


Directory ownership

the nagios-plugins base rpm should also own the
  /usr/lib/nagios/plugins/ directory


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-17 18:33 EST ---
This just documents several configure warnings. A future comment will
deal with problems in perl and bash plugins.

Configure warnings

[1]
checking for rc_read_config in -lradiusclient... no
configure: WARNING: Skipping radius plugin
configure: WARNING: install radius libs to compile this plugin (see 
REQUIREMENTS).
[2]
checking for lmstat... no
configure: WARNING: Get lmstat from Globetrotter Software to monitor flexlm 
licenses
[3]
configure: WARNING: Tried /usr/bin/perl - install Net::SNMP perl module if you
want to use the perl snmp plugins
[4]
checking for quakestat... no
checking for qstat... no
configure: WARNING: Get qstat from
http://www.activesw.com/people/steve/qstat.html in order to make check_game 
plugin
[5]
checking for qmail-qstat... no
configure: WARNING: Could not find qmail-qstat or eqivalent


[1] disables the check_radius binary plugin (not built)

[2] comercial product
the perl plugin - check_flexlm - will not work as expected

[3] two perl plugins being removed
perl-Net-SNMP review ticket #191628 

[4] disables the check_game binary plugin (not built)
http://www.qstat.org/

[5] no binary distribution of qmail
the check_mailq perl plugin won't be able to check qmail queues 

Note: Another plugin that appears to be disabled is the check_ide_smart (.c)

At least [1], [3], and [4] should be added to a TODO list.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-13 20:35 EST ---
(In reply to comment #27)
> Comment #26: Yes the only reason I'm not packaging the check_if's is because
> Net::SNMP isn't in there, I was going to package it after nagios-plugins got
> approved but if you want to package it have at it :-D

perl-Net-SNMP review ticket: #191628  ;)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-13 19:53 EST ---
Comment #26: Yes the only reason I'm not packaging the check_if's is because
Net::SNMP isn't in there, I was going to package it after nagios-plugins got
approved but if you want to package it have at it :-D

As far as the individual plugin requires... it was a pain in the butt but I
think I got all the requires that rpm doesn't pick up:

SPEC: http://mmcgrath.net/~mmcgrath/nagios/nagios.spec
SRPM: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins-1.4.3-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-13 15:23 EST ---
Mike,

Missing requirements

Every external binary needed by a plugin needs to be on the requirement
list of that plugin.

An example, the check_fping plugin requires the /usr/sbin/fping file (or the
fping package). Right now you are only requiring it during the building process.

$ strace -f  -e trace=execve ./check_fping 127.0.0.1
execve("./check_fping", ["./check_fping", "127.0.0.1"], [/* 23 vars */]) = 0
Process 9277 attached
[pid  9277] execve("/usr/sbin/fping", ["/usr/sbin/fping", "-b", "56", "-c", "1",
"127.0.0.1"], [/* 1 var */]) = 0
Process 9277 detached
--- SIGCHLD (Child exited) @ 0 (0) ---

Other plugins will needed to be checked. Will try to check a couple more
during in the next days.


Net::SNMP
-
Are you removing the following two plugins because
http://search.cpan.org/dist/Net-SNMP/ isn't available in Extras? 

# check_ifoperstatus and check_ifstatus require Net::SNMP
%{__rm} %{buildroot}/%{_libdir}/nagios/plugins/check_ifoperstatus
%{__rm} %{buildroot}/%{_libdir}/nagios/plugins/check_ifstatus

I will see if I can package it ASAP. 

/jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-08 09:24 EST ---
I've been sponsored but this package has not yet been approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-07 23:44 EST ---
cool. then you should put the package in FE and close this bug. I'm happy to see
nagios-plugins got in FE now. Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-05-07 20:50 EST ---
Sorry, I'm removing FE-NEEDSPONSOR, I've been sponsored

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374





--- Additional Comments From [EMAIL PROTECTED]  2006-05-07 20:48 EST ---
Sorry about that, the Nagios people have been really busy lately :-D.  All 
updated:

SRPM: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins-1.4.3-1.src.rpm
SPEC: http://mmcgrath.net/~mmcgrath/nagios/nagios-plugins.spec

Its also been requested that I build some i386 bin's for people to use.  

i386: http://mmcgrath.net/~mmcgrath/nagios/i386/

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-05-07 17:39 EST ---
Mike,

Could you update nagios-plugins to version 1.4.3 (released last month).

TIA


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 176374] Review Request: nagios-plugins

2006-05-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-05-07 17:26 EST ---
I've just built this package and some of the plugins wouldn't install due to a
dependency on /usr/local/bin/perl. Turns out configure has found a symlink to
/usr/bin/perl I put there to make some random perl scripts run.

It would seem sensible for the package to enforce the correct perl by adding
this to the configure line:
  --with-perl=%{_bindir}/perl

There's a few other --with parameters which could be similarly helpful.

On the other hand, seems to be working well on fc5 x86_64.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review