[Bug 184011] Review Request: nickle

2008-01-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nickle


https://bugzilla.redhat.com/show_bug.cgi?id=184011


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-01-18 12:42 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184011] Review Request: nickle

2008-01-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nickle


https://bugzilla.redhat.com/show_bug.cgi?id=184011


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+, fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-01-18 11:52 EST ---
Package Change Request
==
Package Name: nickle
New Branches: EL-5


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184011] Review Request: nickle

2006-11-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nickle


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184011


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-11-13 01:25 EST ---
Rawhide build done. Thanks for reviewing!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184011] Review Request: nickle

2006-11-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nickle


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184011


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-11-12 17:06 EST ---
* source files match upstream:   
   ffc7b03a830e64ec054330ae00b8  nickle-2.54.tar.gz
* package meets naming and packaging guidelines
* specfile is properly named, is cleanly written and uses macros consistently
* dist tag is present
* build root is correct
* license field matches the actual license
* license is open source-compatible, license text included in package
* latest version is being packaged
* BuildRequires are proper
* compiler flags are appropriate
* %clean is present
* package builds in mock (FC-6, i386)
* package installs properly
* rpmlint is silent (no doc for -devel package, which is ok)
* final provides and requires are sane
* no shared libraries are added to the regular linker search paths
* owns the directories it creates
* doesn't own any directories it shouldn't
* no duplicates in %files
* file permissions are appropriate
* no scriptlets present
* code, not content
* documentation is small, so no -docs subpackage is necessary
* %docs are not necessary for the proper functioning of the package
* header files in -devel package
* no pkgconfig files
* no libtool .la droppings

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184011] Review Request: nickle

2006-11-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nickle


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184011





--- Additional Comments From [EMAIL PROTECTED]  2006-11-04 11:35 EST ---
http://hircus.org/fedora/nickle/nickle-2.54-2.src.rpm
http://hircus.org/fedora/nickle/nickle.spec

Fixed, thanks. Note that the two left-over COPYING files in %{_docdir}/examples
are there because they cite different authors than the main COPYING file.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184011] Review Request: nickle

2006-11-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nickle


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184011





--- Additional Comments From [EMAIL PROTECTED]  2006-11-04 07:18 EST ---
I think it is enough to have
  rm -rf $RPM_BUILD_ROOT
instead of
  [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

The examples directory appears twice, once in the docdir and once in
/usr/share/nickle. I prefer the docdir.
The examples directory contains Makefile* files which are not functional.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184011] Review Request: nickle

2006-11-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nickle


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184011





--- Additional Comments From [EMAIL PROTECTED]  2006-11-02 21:15 EST ---
pong.

http://hircus.org/fedora/nickle/nickle-2.54-1.src.rpm
http://hircus.org/fedora/nickle/nickle.spec

Sorry for the late response! Changed the %ghost to %exclude and avoided using
%dir and then listing everything under it.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 184011] Review Request: nickle

2006-11-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nickle


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184011


[EMAIL PROTECTED] changed:

   What|Removed |Added

  QAContact|fedora-extras-  |fedora-package-
   |[EMAIL PROTECTED] |[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-11-02 16:58 EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review