[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/show_bug.cgi?id=187964 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: bsd-games - A collection of text-based games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964
--- Additional Comments From [EMAIL PROTECTED] 2006-04-29 18:00 EST ---
(In reply to comment #39)
(In reply to comment #37)
(In reply to comment #36)
Wouldn't it be easier to just write:
%{_datadir}/bsd-games
Why yes, it would.
In that case concider dropping these 3 lines from the spec?
Done.
* Shouldn't the highscore files be marked %config(noreplace) ?
I say no. If the high score file formats changes at any time then we want
to
make sure that the old ones get removed. We could mark them as %config
only,
but that seems pointless because the only reason to preserve the old
scoreboard
files is if a migration tool is also provided to move it to the new format,
and
I don't see that happening for any of these games.
Do you concider the changing of these files format likely? If you don't makr
them %config(noreplace) the highscores will get reset on each package update,
I
don't think you / we want that.
I was under the mistaken impression that rpm would not touch files during an
upgrade that hadn't changed from one release to the next, but it seems that's
not the case for these scoreboard files.
I'll fix these three minor issues before building.
Thanks a bunch for the review. I know it was time consuming since this is like
40 packages all rolled into one. :)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-28 01:57 EST --- I've addressed the issues from comment 30 and comment 31. The hack gid patch has a lot of changes to limit the setgid portions of code. Fortunately, phantasia was easier to deal with, and sail was already done upstream. dm has also been dropped. http://www.kobold.org/~wart/fedora/bsd-games-2.17-7.src.rpm http://www.kobold.org/~wart/fedora/bsd-games.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-28 13:39 EST --- FWIW, I discovered that the change from setregid() to setresgid() is superfluous because it turns out, on linux at least, that setregid() will also change the saved gid if the new real gid is not -1, or if the new egid != the old egid. However, the setresgid patch should remain because it adds error checking to the setresgid() call and aborts if the privileges could not be dropped. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-27 14:08 EST --- I'm slowly descending into the bsd-games source, some initial remarks: 1) in bsd-games-2.17-hackgid.patch (line 81) you've seem to have left in / added a debug printf. 2) in hack you allow the user to specify the save game location and then the savegame gets opened with full gamehack gid rights. This is a problem. Please modify hack so that the first thing it does in main is: gamehack_gid = getegid(); setgid(getgid()); Where gamehack_gid is a global available gid_t and then when it needs the extra rights it should do: setgid(gamehack_gid); // do stuff setgid(getgid()); 3) The same (2) probably also goes for the other games which don't permanently drop their setgid rights with setresgid. The spec looks good, but it will probably take me some time to properly review all the setresgid using games for any problems. In the mean time a new version addressing the above would be nice. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-27 15:39 EST --- Okay, I've reviewed all the sgid games-games except for bsd-tetris which seems to be a special case. Remarks: 1) cfscores is sgid games, but canfield/cfscores/cfscores.c drops rights immediatly even before reading the scores file because of this and since this program only reads hence I believe the sgid bit is not needed. 2) Whats the use of having dm if we install the games directly instead of in a hide path and creating gamename symlinks to the game? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-27 16:00 EST --- I just also checked tetris, thats ok too. Mike could you, post a new version which takes my comments from comment 30 and comment 31 into account, then I can hopefully use that for a full review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-27 16:11 EST --- (In reply to comment #32) I just also checked tetris, thats ok too. Mike could you, post a new version which takes my comments from comment 30 and comment 31 into account, then I can hopefully use that for a full review. I'm working on that now in between meetings. :) I'll have something by evening PDT. I think I'm going to drop dm altogether since it takes a significant amount of admin work to use, and I don't see too much benefit from using it. Besides, the links to dm will get replaced with the actual binaries once the package gets an update. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-26 13:05 EST --- Updated packages without fedora-usermgmt, ready for a full review: http://www.kobold.org/~wart/fedora/bsd-games-2.17-6.src.rpm http://www.kobold.org/~wart/fedora/bsd-games.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-25 09:19 EST --- So it's consistant across systems? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-25 14:53 EST --- As I think about it more, I'm changing my mind that fedora-usermgmt is needed here. consistent gids in a cluster is better solved by nis or some other network login system. These aren't system groups that need to be installed, so plain groupadd should be enough. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 187964] Review Request: bsd-games - A collection of text-based games
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 --- Additional Comments From [EMAIL PROTECTED] 2006-04-25 21:12 EST --- (In reply to comment #24) Consistent GIDs are useful if the scoreboard files are to be shared across a cluster. This is how nethack and the like were configured at my university's computing cluster. So what? What guarantees these uids/gids are consistent with that you rsp. fedora-usermgnt chose? Answer: Your system administrator. Neither you nor fedora-usermgnt will be able to do so. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
