[Bug 188207] Review Request: esdl - SDL bindings for Erlang

2006-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esdl - SDL bindings for Erlang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188207





--- Additional Comments From [EMAIL PROTECTED]  2006-04-25 11:01 EST ---
(In reply to comment #10)
 The package builds fine; I even learned a bit about erlang so that I could
 install and test it.  Unfortunately there are a few problems.  The only thing 
 I
 think is blocking is the errant provide of sdl_driver.so,
This seems not to be problem, it also happens with other packages, for
example mesa-libGL provides mga_dri.so, although this is in /usr/lib/dri,
or epiphany-extensions and many others.

 although I'd like to
 know what's up with the debuginfo RPM.
I can't say anything about this. On the other hand, maybe
the c_src directory can be excluded entirely.

 Issues:
 The license 2-clause BSD like with an added section indicating what rights the
 US government gets (and also indicating that this doesn't limit anyone's
 rights).  To me it seems clearly free; someone might want to look over it and
 decide whether there a better license tag for this than Distributable, but I
 don't see this as a blocker.
I am not familiar with legal matters, so I must rely on your judgement. What
do you propose?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188207] Review Request: esdl - SDL bindings for Erlang

2006-04-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esdl - SDL bindings for Erlang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188207


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-04-24 12:58 EST ---
Tom, are you saying that the Provides: esdl is acceptable as well?  I'm
vaguely disquieted by it because it shouldn't be necessary; nothing in Extras
will require it.

I'll go ahead and work up a full review in any case.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188207] Review Request: esdl - SDL bindings for Erlang

2006-04-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esdl - SDL bindings for Erlang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188207





--- Additional Comments From [EMAIL PROTECTED]  2006-04-24 12:59 EST ---
(In reply to comment #8)
 Tom, are you saying that the Provides: esdl is acceptable as well?  I'm
 vaguely disquieted by it because it shouldn't be necessary; nothing in Extras
 will require it.
You are right, I'll remove it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 188207] Review Request: esdl - SDL bindings for Erlang

2006-04-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: esdl - SDL bindings for Erlang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188207





--- Additional Comments From [EMAIL PROTECTED]  2006-04-23 21:41 EST ---
OK, it builds now.  Still no parallel make, although it doesn't seem to hurt
anything when I enable it.

rpmlint complains about all of the .h and .c files from the c_src directory.  I
don't know much about Erlang but I doubt these are needed at runtime.  Can they
be shifted out to a -devel package without breaking things?

rpmlint also complains about the lack of a changelog entry for your last 
changes.

Finally, since this is an Erlang package (perhaps the first in Extras), might we
consider avoiding some of the mess that Python is in and adopt a reasonable
Perl-like naming convention like erlang-SDL or erlang-esdl?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
[EMAIL PROTECTED]
http://www.redhat.com/mailman/listinfo/fedora-package-review