[Bug 190705] Review Request: perl-Test-Base

2008-07-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Base


https://bugzilla.redhat.com/show_bug.cgi?id=190705


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190705] Review Request: perl-Test-Base

2006-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Base


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190705





--- Additional Comments From [EMAIL PROTECTED]  2006-05-08 14:01 EST ---
Steven,

The Algorithm::Diff requirement and build requirement can be dropped
as Text::Diff requires it.

The Test::Base::Filter may use the LWP::Simple module to download files. Being
this a test module I think it should be nice to require it (not BR).

jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190705] Review Request: perl-Test-Base

2006-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Base


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190705





--- Additional Comments From [EMAIL PROTECTED]  2006-05-08 14:14 EST ---
(In reply to comment #7)
 The Algorithm::Diff requirement and build requirement can be dropped
 as Text::Diff requires it.
 
 The Test::Base::Filter may use the LWP::Simple module to download files. Being
 this a test module I think it should be nice to require it (not BR).

Done and done.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190705] Review Request: perl-Test-Base

2006-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Base


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190705





--- Additional Comments From [EMAIL PROTECTED]  2006-05-08 14:25 EST ---
Thanks Steven.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190705] Review Request: perl-Test-Base

2006-05-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Base


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190705


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190705] Review Request: perl-Test-Base

2006-05-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Base


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190705





--- Additional Comments From [EMAIL PROTECTED]  2006-05-07 23:43 EST ---
You'll note I suggested the addition of those BR:s, but all they add is
additional test coverage.

As far as I know, we have no policy on optional requirements.  I suppose there's
no harm in adding them as long as they're small and we have repoclosure, but I
would argue that it would be a terrible idea to dictate that all optional
requirements be made mandatory.  So I would leave it up to the maintainer.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190705] Review Request: perl-Test-Base

2006-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Base


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190705


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||190937




--- Additional Comments From [EMAIL PROTECTED]  2006-05-06 18:07 EST ---
OK, the stack was smaller than I thought (one module).  Review away.  :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review