[Bug 190873] Review Request: gnome-ppp - A GNOME 2 WvDial frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190873 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190873] Review Request: gnome-ppp - A GNOME 2 WvDial frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190873 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190873] Review Request: gnome-ppp - A GNOME 2 WvDial frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190873 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-05-06 02:02 EST --- Good: * md5sum matches upstream: ec2e20fc713a01c953d759bea3df8618 gnome-ppp-0.3.23.tar.bz2 * Package appropriately named (matches upstream) * spec file matches src.rpm name * Package meets package guidelines * Appropriate License (GPL), matches COPYING file, in %doc * Spec file written in legible American English * Succesfully builds in FC5 i386 mock * locales handled properly * no shared libs to fuss over * not relocatable * owns every directory it creates * no duplicate files. Not even any triplicate files. * %defattr properly used, proper file permissions * Proper %clean * consistent use of $RPM_BUILD_ROOT * doc package not necessary * Package functions w/o docs * No devel package to fuss over * Includes proper desktop file - uses desktop-file-install * Scriptlets are sane -=- I no longer have a modem for it to configure, so I have not tested this package. But that is a *should* and not a *must* -=- Output of rpmlint on mock built fc5 i386 packages: [EMAIL PROTECTED] result]$ ls *.rpm gnome-ppp-0.3.23-1.fc5.i386.rpm gnome-ppp-debuginfo-0.3.23-1.fc5.i386.rpm gnome-ppp-0.3.23-1.fc5.src.rpm [EMAIL PROTECTED] result]$ rpmlint *.rpm [EMAIL PROTECTED] result]$ echo $? 0 [EMAIL PROTECTED] result]$ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190873] Review Request: gnome-ppp - A GNOME 2 WvDial frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190873 --- Additional Comments From [EMAIL PROTECTED] 2006-05-06 02:12 EST --- Note on the test thing - I did try the app. No segfault. It correctly creates a ~/.wvdial.conf w/o a modem for it to detect though, that's as far as I could get. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190873] Review Request: gnome-ppp - A GNOME 2 WvDial frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190873 --- Additional Comments From [EMAIL PROTECTED] 2006-05-06 18:53 EST --- Thanks for the review and responding so quickly, Michael. (In reply to comment #1) > > I no longer have a modem for it to configure, so I have not tested this > package. > But that is a *should* and not a *must* > IMO it should be a MUST and to be honest I haven't thought about that before. I don't have a modem atm ether, so I did not test this package. I rolled this package for my sister who is a complete newby. She manged to setup a connection and is happy with the package, so I guess it must be foolproof. ;) But I'm not sure if modem detection and works properly, so I asked a friend of mine to test this. I'm not going to build or release this, before I receive feedback (because I'm not interested in maintaining a broken piece of software). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190873] Review Request: gnome-ppp - A GNOME 2 WvDial frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190873 --- Additional Comments From [EMAIL PROTECTED] 2006-05-06 19:15 EST --- It will use /dev/modem by default - I *think* udev will create /dev/modem symlink if hardware is present, so modem detection would only be necessary if fedora itself did not pick it up (or more than one is present). Even if detection fails, /dev/ttySN manually configured should work. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190873] Review Request: gnome-ppp - A GNOME 2 WvDial frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190873 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-05-06 19:58 EST --- Right, gnome-ppp is just calling wvdialconf anyway, so this doesn't really matter. Imported into CVS, build for devel. Closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 190873] Review Request: gnome-ppp - A GNOME 2 WvDial frontend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/show_bug.cgi?id=190873 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
