[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-18 03:32 EST --- Recovering from bugzilla crash, this one was approved by me and imported and build by Ian, closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-11 14:18 EST --- The Makefile.in now has: libCEGUILuaScriptModule_la_LIBADD = -llua -ltolua++ rather than adding them directly on the link line. Makefile.am is now using: libCEGUILuaScriptModule_la_LIBADD = -llua -ltolua++ instead of the LIBS variable. I have a problem, if remove -rpath $(libdir) from the Makefiles, it fails on installation with: /usr/bin/install -c .libs/libCEGUILuaScriptModule.lai /usr/local/lib/libCEGUILuaScriptModule.la /usr/bin/install: cannot stat `.libs/libCEGUILuaScriptModule.lai': No such file or directory If -rpath $(libdir) is present, it installs OK. I'm not sure what to do about this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-11 15:22 EST --- Ok, solved, my bad: The output of libtool --help --mode=link contains: -rpath LIBDIR the created library will eventually be installed in LIBDIR So this is a different rpath option as -Wl,rpath passed to gcc / g++ or -rpath passed to ld. I guess it might cause a -Wl,rpath in the link command when LIBDIR is a non standard dir and hence it has the name, but appeareantly libtool is smart enough not to pass -rpath when LIBDIR (as passed to libtool) is a standard libdir (which it is in our case: /usr/lib[64]). I've verified this with my local installed build of -5 (+tinyxml + 64 bit fixes): [EMAIL PROTECTED] ~]$ objdump -x /usr/lib64/libCEGUILuaScriptModule.so | grep -i rpath [EMAIL PROTECTED] ~]$ So the -rpath in this case can stay, soryyy. Still this dance wasn't in (entirely) vain as the other -rpath's where really a problem. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-11 16:08 EST --- No problem Hans, it's been a good learning process and I've a learnt a lot :-) Here's the latest http://dribble.org.uk/cegui.spec http://dribble.org.uk/cegui-0.4.1-8.src.rpm PS. I have submitted the appropriate patches for this and the others upstream. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-11 16:24 EST --- (In reply to comment #25) No problem Hans, it's been a good learning process and I've a learnt a lot :-) Here's the latest http://dribble.org.uk/cegui.spec http://dribble.org.uk/cegui-0.4.1-8.src.rpm Looks good, approved! PS. I have submitted the appropriate patches for this and the others upstream. Good! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-10 15:28 EST --- Sorry, But the tolua++ patch still has issues. The changes to cegui_mk2/ScriptingModules/CEGUILua/LuaScriptModule/src/Makefile.in and cegui_mk2/ScriptingModules/CEGUILua/LuaScriptModule/src/Makefile.am are not in sync In .in you add -llua -ltolua++ to the final link command in the .am you add them to the LIBS variable and worse, the link command still contains -rpath, appearantly -rpath not only comes from the configure script but is also hardcoded into some of the makefiles. Further discussing SMC by mail (your right it really doesn't belong in this BZ ticket even though it did help finding and fixing the tinyxml and 64bit bugs). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: cegui - Free library providing windowing and widgets
for graphics APIs / engines
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342
--- Additional Comments From [EMAIL PROTECTED] 2006-06-09 06:01 EST ---
Created an attachment (id=130806)
-- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130806action=view)
Patch fixing tinyxml usage bug
I've been testing cegui with Secret Maryo Chronicles yesterday (fungame, but
I'm afraid its a bit to inspired/like the original to be packagable). While
testing I've found a small (and known but not fixed judging from the comments
GRRR) bug in the TinyXML calling code. This patch fixes this:
About your -5 spin, looking good but:
@@ -6889,7 +6889,7 @@
# are reset later if shared libraries are not supported. Putting them
# here allows them to be overridden if necessary.
runpath_var=LD_RUN_PATH
-hardcode_libdir_flag_spec='${wl}--rpath ${wl}$libdir'
+hardcode_libdir_flag_spec='${wl}$libdir'
export_dynamic_flag_spec='${wl}--export-dynamic'
# ancient GNU ld didn't support --whole-archive et. al.
if $LD --help 21 | grep 'no-whole-archive' /dev/null; then
That should be:
+hardcode_libdir_flag_spec=''
The old version would expand to:
hardcode_libdir_flag_spec='-Wl,--rpath -Wl,$libdir'
Which would cause gcc to call ld with:
--rpath $libdir
So both must be removed. Notice that there are multiple cases in the patch
where you've got this wrong.
Hint: in cases like this I often find it easier to just edit the patch then to
generate a whole new one, just change the offending lines starting with a +
without touching anything else.
p.s.
If you're interested in SMC let me know I've got some patches for some issues
it has (send upstream too).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-09 15:12 EST --- Created an attachment (id=130838) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130838action=view) Patch fixjng 64 bit problems And the next and hopefully last patch there is a wrong usage of long instead of int in the openGL renderer which breaks things on 64 bit, this patch fixes this. Without this all the samples went black, now they actually work. With this patch I've also got SMC running 100% on 64 bit, so its seems CEGUI is 64 bit clean with this little fix. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-09 17:47 EST --- Hi here's the latest version with those patches applied too, much obliged Hans. Regarding those SMC patches, sure I wouldn't mind them. Coincidentally it was SMC that got me looking into cegui and DevIL in the first place :) http://dribble.org.uk/cegui.spec http://dribble.org.uk/cegui-0.4.1-6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-08 17:38 EST --- Ok Hans, here's the latest version: http://dribble.org.uk/cegui.spec http://dribble.org.uk/cegui-0.4.1-5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 14:57 EST --- I'm in the process of trying to patch cegui, not to use the bundled version of tolua++. So far I can get it to build successfully to the point where it ignores the bundled tolua++. It also has to regenerate the c++ bindings using the 'system' tolua++ otherwise it won't compile. However the following library 'libCEGUIluatoluapp.so.0', does not get built. On further investigation it appears that this library is probably just a wrapper library, containing the equivalent of 'liblua.so' and/or 'libtolua++.so' although it may be useful to confirm this. I'm not sure how best to proceed. 1. Do not supply 'libCEGUIluatoluapp.so.0' and hope the packages compiled against cegui will link with 'liblua.so' and/or 'libtolua++.so' when necessary and patch them if they dont. 2. Construct libCEGUIluatoluapp.so.0 based upon the system 'liblua.so' and 'libtolua++.so', but this seems a little messy to me and largely circumvents the entire reason for not using the bundled version in the first place. 3. Perhaps some sort of alias method using symlinks / sonames? Not even sure if this is possible. Anyway if you'd like to see the current state of things with the SRPM I'll upload it. I'd appreciate your thoughts on this, if you have the time :) Thanks Hans. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 15:52 EST --- I say go with 1, but you do need to add -llua -ltolua++ to the link command building the cegui.so which actually calls the (to)lua functions. If it only calls tolua++ functions then -ltolua++ should be enough, tolua++ itself is linked against lua itself and this will bring in lua for itself as needed. When the .so containing the functions which call (to)lua is linked against to(lua) then the app doesn't need the to link with 'liblua.so' and/or 'libtolua++.so'. We may still need the app to not link to CEGUIluatoluapp though. Anyways please do post a link to the SRPM then I can see what you've got sofar and offer some feedback. p.s. Great work! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 Bug 193342 depends on bug 193884, which changed state. Bug 193884 Summary: Review Request: tolua++ - A tool to integrate C/C++ code with Lua https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193884 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-02 03:59 EST --- The license is hidden in the README, also see tolua++-1.0.92/debian/copyright in the tarbal. I mus admit the license is a bit vague in details though, I would drop freeware as description in the License: field. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||193884 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: cegui - Free|Review Request: cegui - Free |library providing windowing |library providing windowing |and widgets for graphics|and widgets for graphics |APIs / engines |APIs / engines -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-06-01 19:36 EST --- Latest lua released, now with a shared lib. No reply as yet from the maintainers regarding the license of tolua++ although I suspect it's probably MIT, but that should be confirmed. I'll proceed with at least getting an RPM constructed in the meantime. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 Bug 193342 depends on bug 193312, which changed state. Bug 193312 Summary: Review Request: DevIL - A cross-platform image library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193312 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-05-29 05:35 EST --- Glad to hear you're looking into tolua++, I think the best way to proceed is to first package tolua++ and then fix cegui to use it. Once you're done packaging tolua++ feel free to add me to the cc-list for the review then I'll take a look (as time permits). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: cegui: Free|Review Request: cegui - Free |library providing windowing |library providing windowing |and widgets for graphics|and widgets for graphics |APIs / engines |APIs / engines -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED BugsThisDependsOn||193312 OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-05-28 15:42 EST --- (In reply to comment #2) Thanks very much for the patch. I had to make a tiny change to it, because it introduced the following trivial error: src/Makefile.am:151: noinst_HEADERS must be set with `=' before using `+=' Ah, I didn't get that error because I removed ./bootstrap from %build. You should not call automake, aclocal, autoconf, etc (which ./bootstrap does) unless you've got a really good reason. If you do call them you should do so in %prep not %build. Does this also apply to the private copy of lua include with the source package? I suspect it probably does, although there's no shared libs in the FE lua. Yes it does apply to lua and tinyxml too. I did notice lua but I forgot again. Even though lua as packaged only provides a .a file and not a .so file you should still use the system version during the build, it might contain Fedora specific fixes (for example for the always bleeding edge Fedora gcc version) and feel free to file a bug against lua asking for a .so instead of the .a . Since tinyxml isn't currently packaged we can leave that in, if you want todo something with regard to the xml code in cegui, it would prabably be best to convert to libxml or expat, we alreayd have more then enough xml libs as is. But as said, just leave it as is for now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-05-28 15:53 EST --- While I'm at here are some things which need fixing (for starters, not a full review yet): -duplicate files in %doc between base -devel -devel-docs -remove / fix non modular X (Build)Requires And as a reminder (see above) -remove call to ./bootstrap.sh -use system pcre About the system lua, it seems that cegui contains a special version of lua called tolua++, I'm still investigating this, so don't waste any time on it in the mean time. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-05-28 16:11 EST --- Okay, tolua++ which is used by cegui is an extension to lua, you can find tolua++ here: http://www.codenix.com/~tolua/ cegui actually includes both lua and tolua++. Since they have been dropped into one dir by the cegui author and since the tolua++ included in cegui is so old that it probably doesn't suppor the lua shipped with Fe. Its probably best to: -package the real tolua++ from above -completly remove the one included in cegui -use the system installed tolua++ when building cegui (just as with pcre) Since this is going to be a somewhat longer path the originally planned, first get DevIL into shape and then I'll sponsor you so you can import DevIL and AGReader while you (we) are working on this. Also please be so kind as to file a bug against lua about it only containing a .a and put me in the CC of this bug, it might be a good idea to put a pointer to this bug into this new bug. (just type bug 193342 then BZ will automaticly create a link). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-05-28 23:14 EST --- Ok, here's the current state of play for cegui. http://dribble.org.uk/cegui.spec http://dribble.org.uk/cegui-0.4.1-3.src.rpm I've filed a bug against lua and begin looking at tolua++. Thanks Hans -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui: Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui: Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: cegui: Free|Review Request: cegui: Free |library providing windowing |library providing windowing |and widgets for graphics|and widgets for graphics |APIs / engines |APIs / engines AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 193342] Review Request: cegui: Free library providing windowing and widgets for graphics APIs / engines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui: Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 --- Additional Comments From [EMAIL PROTECTED] 2006-05-27 18:26 EST --- Created an attachment (id=130112) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130112action=view) Patch making cegui use the system pcre cegui comes with its own copy of pcre. Which is a library which is also available seperatly in FE. Using private copies of libraries is concidered a bad practice (it removes / reverts most advantages of using shared libs if there are many copies of each lib in different packages). Please do a rm -fr src/pcre in %prep, add pcre-devel to the BR and use the attached patch to get cegui to compile with the system pcre. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
