[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inotify-tools - Command line utilities for inotify https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-08-01 12:06 EST --- Package was built fine in devel :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inotify-tools - Command line utilities for inotify https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-01 01:13 EST --- Looks good. APPROVED. Please remember to close this review request once imported into CVS and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inotify-tools - Command line utilities for inotify https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 15:30 EST --- Sorry for the delay - I was on a vacation. I chose mirror because there are sometimes problems with connecting to download.sourceforge.net. * Mon Jul 31 2006 Dawid Gajownik - 2.2-3 - Fix URL http://gajownik.zspswidwin.pl/inotify-tools.spec http://gajownik.zspswidwin.pl/inotify-tools-2.2-3.src.rpm Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: inotify-tools - Command line utilities for inotify
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-07-19 04:29 EST ---
I will do the review for this submission.
Review for release 2:
* RPM name is OK
* Source inotify-tools-2.2.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
Notes:
You should use http://download.sourceforge.com/ and not one of the mirrors.
e.g.
Source0: http://download.sourceforge.com/%{name}/%{name}-%{version}.tar.gz
Fix that up and I can't see any reason for not approving this.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inotify-tools - Command line utilities for inotify https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688 --- Additional Comments From [EMAIL PROTECTED] 2006-07-06 09:28 EST --- I've e-mailed upstream about this compilation warning and he gave me instructions how to fix it :-) http://fedora.pl/~gajownik/inotify-tools.spec http://fedora.pl/~gajownik/inotify-tools-2.2-2.src.rpm * Thu Jul 6 2006 Dawid Gajownik - 2.2-2 - Fix compilation warnings -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: inotify-tools - Command line utilities for inotify
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688
--- Additional Comments From [EMAIL PROTECTED] 2006-07-06 06:00 EST ---
== Not an official review as I'm not yet sponsored ==
Mock build for development i386 is sucessfull
* MUST Items:
- MUST: rpmlint shows no error.
- MUST: dist tag is present.
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package inotify-tools, in the
format inotify-tools.spec.
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
GPL.
- MUST: This package includes License file COPYING.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct
(0ca1dd7a9bb0c6d0bbd084d8436b850f)
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like README.
- MUST: Package did NOT contained any .la libtool archives.
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: inotify-tools - Command line utilities for inotify https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688 --- Additional Comments From [EMAIL PROTECTED] 2006-07-06 04:52 EST --- Thanks for the review! Today was released new version so here's an updated package: http://fedora.pl/~gajownik/inotify-tools.spec http://fedora.pl/~gajownik/inotify-tools-2.2-1.src.rpm * Thu Jul 6 2006 Dawid Gajownik - 2.2-1 - New version 2.2 - Update URL and description - Add man pages -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: inotify-tools - Command line utilities for inotify
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-07-06 00:17 EST ---
Not an official review as I'm not yet sponsored
Mock build for development i386 is sucessfull
MUST Items:
- MUST: rpmlint shows no error.
- MUST: dist tag is present.
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package inotify-tools, in the
format inotify-tools.spec.
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
GPL.
- MUST: This package includes License file COPYING.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct
(8053f441fc3fe0f0c73cf483399da17b)
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like README.
- MUST: Package did NOT contained any .la libtool archives.
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
