[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter Alias: optipng https://bugzilla.redhat.com/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 21:40 EST --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter Alias: optipng https://bugzilla.redhat.com/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter Alias: optipng https://bugzilla.redhat.com/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163779 | nThis|| Alias||optipng Flag||fedora-review+, fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 15:08 EST --- Package Change Request == Package Name: optipng New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-10-11 16:57 EST --- built for devel (Job 19525) A make new-sources FILE=... helped, it wrote that the tarball was already there but updated sources and .cvsignore. Thank you for the review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2006-10-11 12:14 EST --- Yeah, it looks like it didn't upload the source to the lookaside cache, or update sources and .cvsignore. You might create a new src.rpm with a bumped release and re-run cvs-import.sh on it to get everything uploaded. Let me know if I can assist any... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2006-10-10 17:02 EST --- Thank you for your offer, it was only a lack of time. But now that I wanted to import it, the import script said something about the time beeing wrong and that it might have run incompletely. Actually it did not import the .tar.gz. I hope I will look into this tomorrow and finish the import. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2006-10-08 00:14 EST --- Is there any hold up on importing and building this? Anything I can do to assist? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-10-01 00:43 EST --- No problem. This version addresses all the blockers I saw... so this package is APPROVED. Don't forget to close this bug NEXTRELEASE once it's been imported and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2006-09-29 14:32 EST --- I tend to forget to finally submit my comments here, everything is done already except that I did not send my comment here. SPEC: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/optipng.spec SRPM: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/repo/optipng-0.5.4-1.src.rpm Sorry for the delay. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2006-09-29 13:51 EST --- Ping Till. Do you still want to submit this package? Any idea when you might address the items from comments #10 and #11? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2006-09-13 00:06 EST --- Oh, forgot to mention... in the 0.5.4. release they mention that they "Added support for builds based on the system-supplied libpng." So, perhaps you can switch to using the system libpng? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-13 00:04 EST --- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (zlib/libpng) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: a6f3234a47464ecc1f455b52f0769492 optipng-0.5.3.tar.gz a6f3234a47464ecc1f455b52f0769492 optipng-0.5.3.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. - Should build in mock. Issues: 1. version 0.5.4 is out now. 2. You have 2 commented out lines: #BuildRequires: #Requires: Might just remove those? 3. rpmlint says: W: optipng invalid-license zlib/libpng W: optipng invalid-license zlib/libpng W: optipng-debuginfo invalid-license zlib/libpng This can be ignored (see bug 198616). E: optipng-debuginfo empty-debuginfo-package Not sure whats causing that. You are building with -g It would be good to fix however. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|177841 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-02 01:20 EST --- Removing FE-NEEDSPONSOR as submitter was already sponsored in: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197442 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: optipng - a |Review Request: optipng - a |PNG optimizer and converter |PNG optimizer and converter |- need a Sponsor| --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 15:23 EST --- FE-NEEDSPONSOR blocker already set, no need to be in Summary too. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter - need a Sponsor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: optipng - a PNG optimizer and converter - need a
Sponsor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732
--- Additional Comments From [EMAIL PROTECTED] 2006-07-28 08:56 EST ---
Spec URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/optipng.spec
SRPM URL:
http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/repo/optipng-0.5.3-1.fc5.src.rpm
* Sa Jul 29 2006 Till Maas - 0.5.3-1
- version bump
- Changed license tag back to zlib/libpng (#198616 rpmlint)
- use $RPM_OPT_FLAGS instead of %{optflags}
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter - need a Sponsor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: optipng - a PNG optimizer and converter - need a
Sponsor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732
--- Additional Comments From [EMAIL PROTECTED] 2006-07-21 02:38 EST ---
(In reply to comment #5)
> One note in your spec file that you'll get flagged on: you're mixing
> macro/variable styles (e.g. using $RPM_BUILD_ROOT and %{optimize}).
...make that %{optflags}.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter - need a Sponsor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: optipng - a PNG optimizer and converter - need a
Sponsor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732
--- Additional Comments From [EMAIL PROTECTED] 2006-07-21 02:36 EST ---
One note in your spec file that you'll get flagged on: you're mixing
macro/variable styles (e.g. using $RPM_BUILD_ROOT and %{optimize}).
See
http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter - need a Sponsor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter - need a Sponsor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2006-07-06 17:51 EST --- Spec URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/optipng.spec SRPM URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/repo/optipng-0.5.2-2.src.rpm License Tag is now zlib. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter - need a Sponsor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter - need a Sponsor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 --- Additional Comments From [EMAIL PROTECTED] 2006-07-06 06:42 EST --- Spec URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/optipng.spec SRPM URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/repo/optipng-0.5.2-1.src.rpm Sorry, SRPM contained a type, you reviewed the correct SRPM. http://www.opensource.org/licenses/zlib-license.php calls the license zlib/libpng, libpng in Core uses OSI approved as license text. But I can change the license tag to zlib next time I boot my development machine. Thx for the review -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter - need a Sponsor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: optipng - a PNG optimizer and converter - need a
Sponsor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732
--- Additional Comments From [EMAIL PROTECTED] 2006-07-06 01:16 EST ---
Ok i search your website and found that SRPM.
== Not an official review as I'm not yet sponsored ==
* Mock build for development i386 is sucessfull
MUST Items:
- MUST: rpmlint shows error as
rpmlint -i optipng-0.5.2-1.src.rpm
W: optipng invalid-license zlib/libpng
The license you specified is invalid. The valid licenses are:
-GPL-LGPL
-Artistic -BSD
-MIT-QPL
-MPL-IBM Public License
-Apache License -PHP License
-Public Domain -Modified CNRI Open Source
License
-zlib License -CVW License
-Ricoh Source Code Public License -Python license
-Vovida Software License-Sun Internet Standards Source
License
-Intel Open Source License -Jabber Open Source License
if the license is close to an existing one, you can use ' style'.
==>You Need provide package with Open Source Licenses Mentioned above. Though
you have provided zlib/libpng and zlib is present, you can ignore this warning.
- MUST: dist tag is present
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package optipng, in the
format optipng.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
zlib/libpng.
- MUST: License file License.txt is included in package.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct
(8cc507e596c95ee44621f7adc8ce0534).
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like README.txt.
- MUST: Package did NOT contained any .la libtool archives.
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter - need a Sponsor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter - need a Sponsor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-06 00:37 EST --- Correct your SRPM URL. I think it MUST be http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/repo/optipng-0.5.2-1.src.rpm Or upload that SRPM. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 197732] Review Request: optipng - a PNG optimizer and converter - need a Sponsor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: optipng - a PNG optimizer and converter - need a Sponsor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
