[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-09-08 16:52 EST --- Excellent! Please feel free to import this into Fedora Extras - remember to close this bug and set the RESOLVE BUG to NEXT_RELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-07 22:25 EST --- Removing FE-NEEDSPONSOR as submitter was sponsored in: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204975 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-09-01 14:50 EST --- Hey Bruno. I see you have applied for sponsorship... You might want to take a look at: http://www.fedoraproject.org/wiki/Extras/HowToGetSponsored It's hard for sponsors to know you are ready based on just one package. Do you have more to submit to give a better idea? Or if you can add comments to other reviews that will show that you understand the guidelines... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-09-01 16:07 EST --- (In reply to comment #19) Do you have more to submit to give a better idea? Yes lots: http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/5/x86_64/SRPMS.panorama/ I've created another review request for vigra: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204975 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-08-15 17:43 EST --- (In reply to comment #17) Can you include something to the effect that this is the modified version - altered in order to not break the patent? Ok, I've added this text to the %description: Due to patent restrictions, this library has a maximum fisheye field-of-view restriction of 160 degrees to prevent stitching of hemispherical photographs. http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/libpano12.spec http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/5/x86_64/SRPMS.panorama/libpano12-2.8.4-7.fc5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-07-26 16:59 EST --- This needs at least a few more cleanups: * Separate the tools into a separate subpackage from the library. * This is something of a cosmetic change but all packages I know of in Fedora group the meta info at the top of the file. So I'd very strongly encourage putting the devel subpackage %package through %description info right after the main package's %description. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libpano12 : Library and tools for manipulating
panoramic images
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-07-25 05:38 EST ---
Okay, let's look at the spec
%define name_version %{name}-%{version}
This isn't needed. Just wipe it
BR gcc isn't needed
Not sure on the obsoletes/provides.
%configure --prefix - %configure is enough (unless the tarball decides to put it
somewhere odd). If it is available as a configure option, include
--disable-static
%install
the two strip lines aren't required.
%package devel
Requires : should be %{version}-%{release}. It helps keep the devel files in
pace with the main package.
%description devel
The second paragraph isn't needed
%files
%{_bindir}/* - how many binaries does the package make? If they all start with
PT, then %{_bindir}/PT* and then one for the other one is a much better idea.
The same applies with the %{_libdir}
Does libpano12 not create it's own directory in %{_includedir} or is it again
just a couple of files?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-07-25 06:54 EST --- D'oh! %prep %setup -q %build %configure --disable-static make I need more coffee! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-07-25 07:14 EST --- (In reply to comment #6) %prep %setup -q %build %configure --disable-static make Ok done: http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/libpano12.spec http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/5/x86_64/SRPMS.panorama/libpano12-2.8.4-4.fc5.src.rpm There is a %build example without a make here: http://fedoraproject.org/wiki/Packaging/Guidelines#head-8c605ebf8330f6d505f384e671986fa99a8f72ee -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-07-25 07:24 EST --- That URL is purely as an example of using find_lang With the changes (which are the same as yours) the package builds fine outside of mock. rpmlint shows nothing for the main binary, a warning (no-documentation) for the -devel package, and nothing for the -debuginfo and -src.rpm. I'm test building it in mock now. Out of interest, how easy would it be for someone to build this and break the patent? It is really my only concern on this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-07-25 07:35 EST --- (In reply to comment #8) Out of interest, how easy would it be for someone to build this and break the patent? It is really my only concern on this package. It's a one-line change to a header file and a rebuild. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-07-25 07:39 EST --- Given the ease by which a patent can be broken, I'll carry on reviewing it, but will need to clarify the position higher up the food chain. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-07-25 08:00 EST --- builds fine in mock. I've asked about #10 and will let you know when I have an answer. rpmlint on the installed packages is fine as well. All being fine with the legal bods, I can't see a problem with the amended spec and package, though the no-documentation warning in devel does need some attention. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064 --- Additional Comments From [EMAIL PROTECTED] 2006-07-25 10:54 EST --- (In reply to comment #12) You don't need the INSTALL file. However, you do need the text files inside of doc to be added (probably best to add these to the devel package). You also need to include the README.linux file. Done. The files in doc/ are end-user documentation, so I put them in the main package. I've taken the dist tag out of the changelogs. I seem to remember putting it in there quieten some version of rpmlint. http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/libpano12.spec http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/5/x86_64/SRPMS.panorama/libpano12-2.8.4-5.fc5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
