[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qstat - Real-time Game Server Status for Quake servers https://bugzilla.redhat.com/show_bug.cgi?id=200374 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qstat - Real-time Game Server Status for Quake servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-08-01 10:49 EST --- Injected into CVS. Thanks for review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qstat - Real-time Game Server Status for Quake servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 04:22 EST --- Updated package here: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/qstat-2.10-4.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qstat - Real-time Game Server Status for Quake servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 12:37 EST --- All MUSTFIX items fixed. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qstat - Real-time Game Server Status for Quake servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374 --- Additional Comments From [EMAIL PROTECTED] 2006-07-29 15:47 EST --- GOOD * rpmlint output clean * Package and spec file name named appropriately * Artistic license ok, license file included * File matches upstream: ac3ce3dbed5248bd5738a4968460880e qstat-2.10.tar.gz * Spec file legible and in Am. English * Builds and packages in mock on FC4, FC5, and FC5, both i386 and x86_64 * Package provides list is sane * No BR: necessary * No locales * No shared libs * Not relocatable * Does not create any directories that it should own * No duplicate %files * File permissions ok * build root cleaned in %install and %clean as necessary * Contains code, not content * No need for -doc or -devel subpackages * No .la files created * Not a gui app; no .desktop file needed MUSTFIX === * %doc contains some unnecessary files that should be removed: COMPILE.txt Makefile* template/Makefile* NOTES = * There are a number of compiler warnings about pointer signedness that appear harmless. If you feel inclined, you could report these upstream. qstat.c:2912: warning: pointer targets in passing argument 6 of 'recvfrom' differ in signedness -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qstat - Real-time Game Server Status for Quake servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374 --- Additional Comments From [EMAIL PROTECTED] 2006-07-28 09:14 EST --- Updated package here: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/qstat-2.10-3.src.rpm * Fri Jul 28 2006 Andy Shevchenko [EMAIL PROTECTED] 2.10-3 - drop check for / in install and clean sections - drop -n for setup macro - do not use attr macro in files section - qstat can be used not only for Quake, so change Summary -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qstat - Real-time Game Server Status for Quake servers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-07-27 17:08 EST ---
A few small points before I get to a full review:
You don't need the check for / when you clean the buildroot in %install and
%clean. A simple rm -rf will suffice:
rm -rf %{buildroot}
The -n %{name}-%{version} is unnecessary. %setup already uses this as a
default.
The %attr statements for qstat.cfg and the qstat binary are also not necessary
as these permissions/ownership are already used.
qstat can be used for more than just quake servers, so remove 'quake' from the
summary line. You could replace it with 'FPS game' instead.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qstat - Real-time Game Server Status for Quake servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
